Blob Blame History Raw
autofs-5.1.4 - fix deadlock in dumpmaps

From: Ian Kent <raven@themaw.net>

Commit a223d11fa8e (autofs-5.1.3 - serialize calls to open_xxxx()
functions) introduces a deadlock when using the dumpmaps function.

In this case the open fd mutex needs to be unlocked in the forked
child process of the do_spawn() function.

Signed-off-by: Ian Kent <raven@themaw.net>
---
 CHANGELOG      |    1 +
 daemon/spawn.c |    1 +
 2 files changed, 2 insertions(+)

--- autofs-5.1.4.orig/CHANGELOG
+++ autofs-5.1.4/CHANGELOG
@@ -62,6 +62,7 @@
 - fix incorrect check in validate_program_options().
 - fix log message in spawn_umount().
 - workaround getaddrinfo(3) ai_canonname bug
+- fix deadlock in dumpmaps.
 
 24/05/2017 autofs-5.1.3
 =======================
--- autofs-5.1.4.orig/daemon/spawn.c
+++ autofs-5.1.4/daemon/spawn.c
@@ -338,6 +338,7 @@ static int do_spawn(unsigned logopt, uns
 		dup2(pipefd[1], STDOUT_FILENO);
 		dup2(pipefd[1], STDERR_FILENO);
 		close(pipefd[1]);
+		open_mutex_unlock();
 
 		/* what to mount must always be second last */
 		while (*pargv++)