From 4df62f86ee3fc6a75a056dcf9c9eaf65ec0925f8 Mon Sep 17 00:00:00 2001 From: Ken Gaillot Date: Feb 05 2021 06:23:34 +0000 Subject: Refactor: scheduler: avoid a level of indentation when unpacking node histories --- diff --git a/lib/pengine/unpack.c b/lib/pengine/unpack.c index 641b601..7e68d64 100644 --- a/lib/pengine/unpack.c +++ b/lib/pengine/unpack.c @@ -1111,17 +1111,19 @@ unpack_node_loop(xmlNode * status, bool fence, pe_working_set_t * data_set) process = TRUE; } - if(process) { - crm_trace("Unpacking resource history for %snode %s", - (fence? "unseen " : ""), id); - this_node->details->unpacked = TRUE; + if (!process) { + continue; + } - lrm_rsc = find_xml_node(state, XML_CIB_TAG_LRM, FALSE); - lrm_rsc = find_xml_node(lrm_rsc, XML_LRM_TAG_RESOURCES, FALSE); - unpack_lrm_resources(this_node, lrm_rsc, data_set); + crm_trace("Unpacking resource history for %snode %s", + (fence? "unseen " : ""), id); - rc = EAGAIN; // Other node histories might depend on this one - } + this_node->details->unpacked = TRUE; + lrm_rsc = find_xml_node(state, XML_CIB_TAG_LRM, FALSE); + lrm_rsc = find_xml_node(lrm_rsc, XML_LRM_TAG_RESOURCES, FALSE); + unpack_lrm_resources(this_node, lrm_rsc, data_set); + + rc = EAGAIN; // Other node histories might depend on this one } return rc; }