Blame m4/compiler_options.m4

Packit fabffb
AC_DEFUN([_NM_COMPILER_FLAG], [
Packit fabffb
	CFLAGS_SAVED="$CFLAGS"
Packit fabffb
	CFLAGS="$CFLAGS $GLIB_CFLAGS -Werror $1"
Packit fabffb
	AC_MSG_CHECKING([whether $1 works as expected])
Packit fabffb
Packit fabffb
	AC_COMPILE_IFELSE([AC_LANG_SOURCE([[]])], [
Packit fabffb
		AC_COMPILE_IFELSE([AC_LANG_SOURCE([[$2]])], [
Packit fabffb
			AC_MSG_RESULT(yes)
Packit fabffb
			CFLAGS="$CFLAGS_SAVED"
Packit fabffb
			$3
Packit fabffb
		],[
Packit fabffb
			AC_MSG_RESULT(no)
Packit fabffb
			CFLAGS="$CFLAGS_SAVED"
Packit fabffb
			$4
Packit fabffb
		])
Packit fabffb
	],[
Packit fabffb
		AC_MSG_RESULT(not supported)
Packit fabffb
		CFLAGS="$CFLAGS_SAVED"
Packit fabffb
	])
Packit fabffb
])
Packit fabffb
Packit fabffb
dnl Check whether a particular compiler flag is supported,
Packit fabffb
dnl append it to the specified variable if the check succeeds.
Packit fabffb
dnl NM_COMPILER_FLAG([ENV-VAR], [FLAG], [ACTION-IF-SUPPORTED], [ACTION-IF-NOT-SUPPORTED])
Packit fabffb
AC_DEFUN([NM_COMPILER_FLAG], [
Packit fabffb
        _NM_COMPILER_FLAG([$2], [], [
Packit fabffb
		eval "AS_TR_SH([$1])='$$1 $2'"
Packit fabffb
		$3
Packit fabffb
	], [$4])
Packit fabffb
])
Packit fabffb
Packit fabffb
dnl Check whether a particular warning is not emitted with code provided,
Packit fabffb
dnl append an option to disable the warning to a specified variable if the check fails.
Packit fabffb
dnl NM_COMPILER_WARNING([ENV-VAR], [C-SNIPPET], [WARNING]])
Packit fabffb
AC_DEFUN([NM_COMPILER_WARNING], [
Packit fabffb
        _NM_COMPILER_FLAG([-W$2], [$3], [eval "AS_TR_SH([$1])='$$1 -W$2'"], [eval "AS_TR_SH([$1])='$$1 -Wno-$2'"])
Packit fabffb
])
Packit fabffb
Packit fabffb
dnl NM_COMPILER_WARNINGS([ENV-VAR], [MORE-WARNINGS])
Packit fabffb
AC_DEFUN([NM_COMPILER_WARNINGS],
Packit fabffb
[AC_ARG_ENABLE(more-warnings,
Packit fabffb
	AS_HELP_STRING([--enable-more-warnings], [Possible values: no/yes/error]),
Packit fabffb
	set_more_warnings="$enableval",set_more_warnings=$2)
Packit fabffb
AC_MSG_CHECKING(for more warnings)
Packit fabffb
if test "$GCC" = "yes" -a "$set_more_warnings" != "no"; then
Packit fabffb
	AC_MSG_RESULT(yes)
Packit fabffb
Packit fabffb
	dnl This is enabled in clang by default, makes little sense,
Packit fabffb
	dnl and causes the build to abort with -Werror.
Packit fabffb
	CFLAGS_SAVED="$$1"
Packit fabffb
	eval "AS_TR_SH([$1])='$$1 -Qunused-arguments'"
Packit fabffb
	AC_COMPILE_IFELSE([AC_LANG_SOURCE([])], [], eval "AS_TR_SH([$1])='$CFLAGS_SAVED'")
Packit fabffb
	unset CFLAGS_SAVED
Packit fabffb
Packit fabffb
	dnl clang only warns about unknown warnings, unless
Packit fabffb
	dnl called with "-Werror=unknown-warning-option"
Packit fabffb
	dnl Test if the compiler supports that, and if it does
Packit fabffb
	dnl attach it to the CFLAGS.
Packit fabffb
	NM_COMPILER_WARNING([$1], [unknown-warning-option], [])
Packit fabffb
Packit fabffb
	CFLAGS_MORE_WARNINGS="-Wall"
Packit fabffb
Packit fabffb
	if test "x$set_more_warnings" = xerror; then
Packit fabffb
		CFLAGS_MORE_WARNINGS="$CFLAGS_MORE_WARNINGS -Werror"
Packit fabffb
	fi
Packit fabffb
Packit fabffb
	for option in \
Packit fabffb
		      -Wextra \
Packit fabffb
		      -Wdeclaration-after-statement \
Packit fabffb
		      -Wfloat-equal \
Packit fabffb
		      -Wformat-nonliteral \
Packit fabffb
		      -Wformat-security \
Packit fabffb
		      -Wimplicit-fallthrough \
Packit fabffb
		      -Wimplicit-function-declaration \
Packit fabffb
		      -Winit-self \
Packit fabffb
		      -Wlogical-op \
Packit fabffb
		      -Wmissing-declarations \
Packit fabffb
		      -Wmissing-include-dirs \
Packit fabffb
		      -Wmissing-prototypes \
Packit fabffb
		      -Wpointer-arith \
Packit fabffb
		      -Wshadow \
Packit fabffb
		      -Wshift-negative-value \
Packit fabffb
		      -Wstrict-prototypes \
Packit fabffb
		      -Wundef \
Packit fabffb
		      -Wvla \
Packit fabffb
		      -Wno-duplicate-decl-specifier \
Packit fabffb
		      -Wno-format-truncation \
Packit fabffb
		      -Wno-format-y2k \
Packit fabffb
		      -Wno-missing-field-initializers \
Packit fabffb
		      -Wno-pragmas \
Packit fabffb
		      -Wno-sign-compare \
Packit fabffb
		      -Wno-unused-parameter \
Packit fabffb
		      ; do
Packit fabffb
		dnl GCC 4.4 does not warn when checking for -Wno-* flags (https://gcc.gnu.org/wiki/FAQ#wnowarning)
Packit fabffb
		_NM_COMPILER_FLAG([-Wall $(printf '%s' "$option" | sed 's/^-Wno-/-W/')], [],
Packit fabffb
		                  [CFLAGS_MORE_WARNINGS="$CFLAGS_MORE_WARNINGS $option"], [])
Packit fabffb
	done
Packit fabffb
	unset option
Packit fabffb
Packit fabffb
	dnl Disable warnings triggered by known compiler problems
Packit fabffb
Packit fabffb
	dnl https://bugzilla.gnome.org/show_bug.cgi?id=745821
Packit fabffb
	NM_COMPILER_WARNING([$1], [unknown-attributes], [#include <glib.h>])
Packit fabffb
Packit fabffb
	dnl https://bugzilla.gnome.org/show_bug.cgi?id=744473
Packit fabffb
	NM_COMPILER_WARNING([$1], [typedef-redefinition], [#include <gio/gio.h>])
Packit fabffb
Packit fabffb
	dnl https://llvm.org/bugs/show_bug.cgi?id=21614
Packit fabffb
	NM_COMPILER_WARNING([$1], [array-bounds],
Packit fabffb
		[#include <string.h>]
Packit fabffb
		[void f () { strcmp ("something", "0"); }]
Packit fabffb
	)
Packit fabffb
Packit fabffb
	dnl https://llvm.org/bugs/show_bug.cgi?id=22949
Packit fabffb
	NM_COMPILER_WARNING([$1], [parentheses-equality],
Packit fabffb
		[#include <sys/wait.h>]
Packit fabffb
		[void f () { if (WIFCONTINUED(0)) return; }]
Packit fabffb
	)
Packit fabffb
Packit fabffb
	dnl systemd-dhcp's log_internal macro and our handle_warn are sometimes
Packit fabffb
	dnl used in void context,u sometimes in int. Makes clang unhappy.
Packit fabffb
	NM_COMPILER_WARNING([$1], [unused-value],
Packit fabffb
		[#define yolo ({ (666 + 666); })]
Packit fabffb
		[int f () { int i = yolo; yolo; return i; }]
Packit fabffb
	)
Packit fabffb
Packit fabffb
	dnl clang 3.9 would like to see "{ { 0 } }" here, but that does not
Packit fabffb
	dnl look too wise.
Packit fabffb
	NM_COMPILER_WARNING([$1], [missing-braces],
Packit fabffb
		[union { int a[1]; int b[2]; } c = { 0 }]
Packit fabffb
	)
Packit fabffb
Packit fabffb
	dnl a new warning in gcc 8, glib 2.55 doesn't play nice yet
Packit fabffb
	dnl https://bugzilla.gnome.org/show_bug.cgi?id=793272
Packit fabffb
	NM_COMPILER_WARNING([$1], [cast-function-type],
Packit fabffb
		[#include <glib-object.h>]
Packit fabffb
		[typedef struct { GObject parent; } NMObject;]
Packit fabffb
		[typedef struct { GObjectClass parent; } NMObjectClass;]
Packit fabffb
		[static void nm_object_init (NMObject *object) { } ]
Packit fabffb
		[static void nm_object_class_init (NMObjectClass *object) { }]
Packit fabffb
		[G_DEFINE_TYPE (NMObject, nm_object, G_TYPE_OBJECT)]
Packit fabffb
	)
Packit fabffb
Packit fabffb
	eval "AS_TR_SH([$1])='$CFLAGS_MORE_WARNINGS $$1'"
Packit fabffb
else
Packit fabffb
	AC_MSG_RESULT(no)
Packit fabffb
fi
Packit fabffb
])
Packit fabffb
Packit fabffb
AC_DEFUN([NM_LTO],
Packit fabffb
[AC_ARG_ENABLE(lto, AS_HELP_STRING([--enable-lto], [Enable Link Time Optimization for smaller size (default: no)]))
Packit fabffb
if (test "${enable_lto}" = "yes"); then
Packit fabffb
	CC_CHECK_FLAG_APPEND([lto_flags], [CFLAGS], [-flto])
Packit fabffb
	if (test -n "${lto_flags}"); then
Packit fabffb
		CFLAGS="-flto $CFLAGS"
Packit fabffb
	else
Packit fabffb
		AC_MSG_ERROR([Link Time Optimization -flto is not supported.])
Packit fabffb
	fi
Packit fabffb
else
Packit fabffb
	enable_lto='no'
Packit fabffb
fi
Packit fabffb
])
Packit fabffb
Packit fabffb
AC_DEFUN([NM_LD_GC],
Packit fabffb
[AC_ARG_ENABLE(ld-gc, AS_HELP_STRING([--enable-ld-gc], [Enable garbage collection of unused symbols on linking (default: auto)]))
Packit fabffb
if (test "${enable_ld_gc}" != "no"); then
Packit fabffb
	CC_CHECK_FLAG_APPEND([ld_gc_flags], [CFLAGS], [-fdata-sections -ffunction-sections -Wl,--gc-sections])
Packit fabffb
	if (test -n "${ld_gc_flags}"); then
Packit fabffb
		enable_ld_gc="yes"
Packit fabffb
		CFLAGS="$ld_gc_flags $CFLAGS"
Packit fabffb
	else
Packit fabffb
		if (test "${enable_ld_gc}" = "yes"); then
Packit fabffb
			AC_MSG_ERROR([Unused symbol eviction requested but not supported.])
Packit fabffb
		else
Packit fabffb
			enable_ld_gc="no"
Packit fabffb
		fi
Packit fabffb
	fi
Packit fabffb
fi
Packit fabffb
])
Packit fabffb