Blame README

Packit 030a23
Pixman is a library that provides low-level pixel manipulation
Packit 030a23
features such as image compositing and trapezoid rasterization.
Packit 030a23
Packit 030a23
Questions, bug reports and patches should be directed to the pixman
Packit 030a23
mailing list:
Packit 030a23
Packit 030a23
        http://lists.freedesktop.org/mailman/listinfo/pixman
Packit 030a23
Packit 030a23
You can also file bugs at
Packit 030a23
Packit 030a23
        https://bugs.freedesktop.org/enter_bug.cgi?product=pixman
Packit 030a23
Packit 030a23
For real time discussions about pixman, feel free to join the IRC
Packit 030a23
channels #cairo and #xorg-devel on the FreeNode IRC network.
Packit 030a23
Packit 030a23
Packit 030a23
Contributing
Packit 030a23
------------
Packit 030a23
Packit 030a23
In order to contribute to pixman, you will need a working knowledge of
Packit 030a23
the git version control system. For a quick getting started guide,
Packit 030a23
there is the "Everyday Git With 20 Commands Or So guide"
Packit 030a23
Packit 030a23
        http://www.kernel.org/pub/software/scm/git/docs/everyday.html
Packit 030a23
Packit 030a23
from the Git homepage. For more in depth git documentation, see the
Packit 030a23
resources on the Git community documentation page:
Packit 030a23
Packit 030a23
        http://git-scm.com/documentation
Packit 030a23
Packit 030a23
Pixman uses the infrastructure from the freedesktop.org umbrella
Packit 030a23
project. For instructions about how to use the git service on
Packit 030a23
freedesktop.org, see:
Packit 030a23
Packit 030a23
        http://www.freedesktop.org/wiki/Infrastructure/git/Developers
Packit 030a23
Packit 030a23
The Pixman master repository can be found at:
Packit 030a23
Packit 030a23
	git://anongit.freedesktop.org/git/pixman
Packit 030a23
Packit 030a23
and browsed on the web here:
Packit 030a23
Packit 030a23
	http://cgit.freedesktop.org/pixman/
Packit 030a23
Packit 030a23
Packit 030a23
Sending patches
Packit 030a23
---------------
Packit 030a23
Packit 030a23
The general workflow for sending patches is to first make sure that
Packit 030a23
git can send mail on your system. Then, 
Packit 030a23
Packit 030a23
 - create a branch off of master in your local git repository
Packit 030a23
Packit 030a23
 - make your changes as one or more commits
Packit 030a23
Packit 030a23
 - use the 
Packit 030a23
Packit 030a23
        git send-email
Packit 030a23
Packit 030a23
   command to send the patch series to pixman@lists.freedesktop.org.
Packit 030a23
Packit 030a23
In order for your patches to be accepted, please consider the
Packit 030a23
following guidelines:
Packit 030a23
Packit 030a23
 - This link:
Packit 030a23
Packit 030a23
        http://www.kernel.org/pub/software/scm/git/docs/user-manual.html#patch-series
Packit 030a23
Packit 030a23
   describes how what a good patch series is, and to create one with
Packit 030a23
   git.
Packit 030a23
Packit 030a23
 - At each point in the series, pixman should compile and the test
Packit 030a23
   suite should pass.
Packit 030a23
Packit 030a23
   The exception here is if you are changing the test suite to
Packit 030a23
   demonstrate a bug. In this case, make one commit that makes the
Packit 030a23
   test suite fail due to the bug, and then another commit that fixes
Packit 030a23
   the bug.
Packit 030a23
Packit 030a23
   You can run the test suite with 
Packit 030a23
Packit 030a23
        make check
Packit 030a23
Packit 030a23
   It will take around two minutes to run on a modern PC.
Packit 030a23
Packit 030a23
 - Follow the coding style described in the CODING_STYLE file
Packit 030a23
Packit 030a23
 - For bug fixes, include an update to the test suite to make sure
Packit 030a23
   the bug doesn't reappear.
Packit 030a23
Packit 030a23
 - For new features, add tests of the feature to the test
Packit 030a23
   suite. Also, add a program demonstrating the new feature to the
Packit 030a23
   demos/ directory.
Packit 030a23
Packit 030a23
 - Write descriptive commit messages. Useful information to include:
Packit 030a23
        - Benchmark results, before and after
Packit 030a23
	- Description of the bug that was fixed
Packit 030a23
	- Detailed rationale for any new API
Packit 030a23
	- Alternative approaches that were rejected (and why they
Packit 030a23
          don't work)
Packit 030a23
	- If review comments were incorporated, a brief version
Packit 030a23
          history describing what those changes were.
Packit 030a23
Packit 030a23
 - For big patch series, send an introductory email with an overall
Packit 030a23
   description of the patch series, including benchmarks and
Packit 030a23
   motivation. Each commit message should still be descriptive and
Packit 030a23
   include enough information to understand why this particular commit
Packit 030a23
   was necessary.
Packit 030a23
Packit 030a23
Pixman has high standards for code quality and so almost everybody
Packit 030a23
should expect to have the first versions of their patches rejected.
Packit 030a23
Packit 030a23
If you think that the reviewers are wrong about something, or that the
Packit 030a23
guidelines above are wrong, feel free to discuss the issue on the
Packit 030a23
list. The purpose of the guidelines and code review is to ensure high
Packit 030a23
code quality; it is not an exercise in compliance.