commit 5dc30451b80f6bb0079424a130875c10486e4d34 Author: Behdad Esfahbod Date: Mon Aug 7 21:37:07 2017 -0700 Two fixes to avar mapping 1. Handle segment with two entries correctly, 2. Fix rounding math. Ouch! Fixes https://github.com/behdad/harfbuzz/issues/521 src/hb-ot-var-avar-table.hh | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) commit dc2c418e397bf251faf03d824fc780ac19bb1dee Author: Behdad Esfahbod Date: Thu Aug 3 12:34:15 2017 +0100 [check-defs/symbols.sh] Drop empty-symbol lines Fixes https://github.com/behdad/harfbuzz/issues/510 src/check-defs.sh | 2 +- src/check-symbols.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 6f38845d9c6852812eb1963a1fd7e5ec771e5ce3 Author: Behdad Esfahbod Date: Wed Jul 19 17:20:55 2017 -0700 [hb-shape] Rename --show-messages to --trace https://github.com/behdad/harfbuzz/issues/506 util/hb-shape.cc | 2 +- util/options.cc | 2 +- util/options.hh | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) commit e60350551addbd945491f662e98464c9e3e9fec5 Author: Behdad Esfahbod Date: Tue Jul 18 19:14:19 2017 -0700 [hb-shape] Improve shaping-debug output Before, that was printed using --debug (and in both hb-shape and hb-view). Changed it, now hb-shape has a new command-line argument called --show-messages. When invoked, it also respects other output formatting options. The messages are better formatted and printed to te same place that hb-shape output is directed to. Previously they were written to stderr. Fixes https://github.com/behdad/harfbuzz/issues/506 util/hb-ot-shape-closure.cc | 10 +++++++--- util/hb-shape.cc | 33 +++++++++++++++++++++++++++++++-- util/main-font-text.hh | 27 ++++----------------------- util/options.cc | 10 +++++++--- util/options.hh | 2 ++ util/shape-consumer.hh | 18 ++++++++++++------ util/view-cairo.hh | 4 ++-- 7 files changed, 65 insertions(+), 39 deletions(-) commit 65f64d14005e4d0808e818b3c97bd3d600628011 Author: Ebrahim Byagowi Date: Wed Jul 19 02:42:53 2017 +0430 Unbreak arm-none-eabi build again (#514) src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fc15e60eadfc89aca5b8815262b8ee888f285169 Author: Behdad Esfahbod Date: Tue Jul 18 11:24:42 2017 -0700 1.4.7 NEWS | 10 ++++++++++ configure.ac | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) commit c1432bce3cfc1156d19b21892d4083afa8838d94 Author: Behdad Esfahbod Date: Fri Jul 14 17:34:47 2017 +0100 [arabic] Adjust feature order again Fixes https://github.com/behdad/harfbuzz/issues/505 src/hb-ot-shape-complex-arabic.cc | 7 ++++++- .../sha1sum/bf39b0e91ef9807f15a9e283a21a14a209fd2cfc.ttf | Bin 0 -> 7312 bytes test/shaping/tests/arabic-feature-order.tests | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) commit 9813be3d1212eef5a525d64978e0bb2032cd44d9 Author: Cosimo Lupo Date: Fri Jul 14 17:11:46 2017 +0100 [coretext] Allow to disable kern (#508) * Minor * [coretext] Fix leak * [coretext] Do not reset num_features * [coretext] allow to disable kern; re-enabling doesn't seem to be working src/hb-coretext.cc | 41 ++++++++++++++++++++++++++++++++--------- 1 file changed, 32 insertions(+), 9 deletions(-) commit 9dd29c681e8e856c139f20f405d7c0e04928aa70 Author: Behdad Esfahbod Date: Fri Jul 14 17:01:27 2017 +0100 [use] Allow up to two medial-below letters Fixes https://github.com/behdad/harfbuzz/issues/376 src/hb-ot-shape-complex-use-machine.rl | 3 ++- .../sha1sum/e68a88939e0f06e34d2bc911f09b70890289c8fd.ttf | Bin 0 -> 2192 bytes test/shaping/tests/use-syllable.tests | 3 +++ 3 files changed, 5 insertions(+), 1 deletion(-) commit 216b003c914d2209a6846b1ce61fe7a3421c789c Author: Behdad Esfahbod Date: Fri Jul 14 16:38:51 2017 +0100 [use] Fix shaping of U+AA29 CHAM VOWEL SIGN AA Part of https://github.com/behdad/harfbuzz/issues/376 Also see https://github.com/roozbehp/unicode-data/issues/6 Test added, using NotoSansCham built from Noto Phase III sources. src/gen-arabic-table.py | 2 +- src/gen-indic-table.py | 2 +- src/gen-use-table.py | 8 +++++--- src/hb-ot-shape-complex-use-table.cc | 4 ++-- test/shaping/Makefile.am | 1 + .../sha1sum/96490dd2ff81233b335a650e7eb660e0e7b2eeea.ttf | Bin 0 -> 1368 bytes test/shaping/tests/use-syllable.tests | 1 + 7 files changed, 11 insertions(+), 7 deletions(-) commit f1cd7ca89306ff252816e9747177d8dab00524f6 Author: Behdad Esfahbod Date: Fri Jul 14 15:59:40 2017 +0100 [indic] Add github URL src/hb-ot-shape-complex-indic.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 3cc84f45b995b243fca82ce18481f11d69846eb5 Author: Behdad Esfahbod Date: Fri Jul 14 15:50:22 2017 +0100 [indic] Fix https://github.com/behdad/harfbuzz/issues/478 src/hb-ot-shape-complex-indic-private.hh | 2 +- src/hb-ot-shape-complex-indic.cc | 8 ++++++++ test/shaping/Makefile.am | 1 + .../sha1sum/54674a3111d209fb6be0ed31745314b7a8d2c244.ttf | Bin 0 -> 1352 bytes test/shaping/tests/indic-syllable.tests | 1 + 5 files changed, 11 insertions(+), 1 deletion(-) commit e359a4b8f57bbc778843f233c4f5d6fb07ff11d9 Author: Behdad Esfahbod Date: Fri Jul 14 14:14:35 2017 +0100 [indic] Disable automatic ZWNJ handling for Indic features Fixes https://github.com/behdad/harfbuzz/issues/294 Also fixes a bunch of other Indic issues. Test results after: BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%) DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%) GUJARATI: 366355 out of 366457 tests passed. 102 failed (0.0278341%) GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%) KANNADA: 951201 out of 951913 tests passed. 712 failed (0.0747968%) KHMER: 299071 out of 299124 tests passed. 53 failed (0.0177184%) MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%) TAMIL: 1091754 out of 1091754 tests passed. 0 failed (0%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) Before: BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%) DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%) GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%) GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%) KANNADA: 951190 out of 951913 tests passed. 723 failed (0.0759523%) KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%) MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) src/hb-ot-shape-complex-indic.cc | 4 ++-- test/shaping/Makefile.am | 1 + .../sha1sum/f443753e8ffe8e8aae606cfba158e00334b6efb1.ttf | Bin 0 -> 3972 bytes test/shaping/tests/indic-joiners.tests | 2 ++ 4 files changed, 5 insertions(+), 2 deletions(-) commit cdf1fd0627c5517c948ca05d2e9427c3e441adf9 Author: Behdad Esfahbod Date: Fri Jul 14 12:43:34 2017 +0100 [indic] Add infrastructure to disable ZWNJ-skipping in context-matching Not used yet. src/hb-ot-layout-gsubgpos-private.hh | 45 ++++++++++++++++++++---------------- src/hb-ot-layout.cc | 1 + src/hb-ot-map-private.hh | 10 +++++--- src/hb-ot-map.cc | 8 +++++-- 4 files changed, 39 insertions(+), 25 deletions(-) commit 3a73e0d5e17b87ac7e307d855c2cb43d040bd195 Author: Dominik Schlösser Date: Fri Jul 14 13:14:55 2017 +0200 Shaping tests for Tibetan vowels (#446) * Shaping tests for Tibetan vowels * Test-cases for the Dzongkha contractions with multiple vowel-signs added. * going to be removed * Extended contraction-test-cases to all test cases in contractions.txt that actually use multiple-vowels (113 cases) test/shaping/Makefile.am | 3 ++ .../2de1ab4907ab688c0cfc236b0bf51151db38bf2e.ttf | Bin 0 -> 125256 bytes .../82f4f3b57bb55344e72e70231380202a52af5805.ttf | Bin 0 -> 11116 bytes .../a02a7f0ad42c2922cb37ad1358c9df4eb81f1bca.ttf | Bin 0 -> 106096 bytes test/shaping/tests/tibetan-contractions-1.tests | 60 +++++++++++++++++++++ test/shaping/tests/tibetan-contractions-2.tests | 53 ++++++++++++++++++ test/shaping/tests/tibetan-vowels.tests | 11 ++++ 7 files changed, 127 insertions(+) commit 4e21ec546932c2a982aa52fce718c1a0d90a71d6 Author: Dominik Schlösser Date: Fri Jul 14 13:14:23 2017 +0200 Fix for reordering of Tibetan vowel u (#443) * Undone change for Tibetan vowel u * removed comment on reordering that became invalid with roll-back * Support for Dzongkha contractions with multiple vowel-signs * Removed non-functional and unnecessary defines for HB_MODIFIED_COMBINING_CLASS_CCC138,140 src/hb-unicode-private.hh | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) commit ad52e044bcf733bcc6c0373bafcd78a8c0beb400 Author: fanc999 Date: Wed Jun 21 22:19:57 2017 +0800 Win32/NMake builds: Support builds from GIT (#498) Add Python scripts to generate the full win32/config.h.win32 and src/hb-version.h which can be used to build directly from a GIT checkout. Since the scripts are currently intended for building from a GIT checkout, these are not distributed in the release tarballs. Also, support the re-build of Ragel-generated .hh headers using the NMake build system, and allow one to specify the path of the Ragel executable if a suitable one cannot be found in the PATH. Update the Win32/NMake build documentation to let people know about how these mechanisms can be utilized. win32/README.txt | 20 ++++++- win32/build-rules-msvc.mak | 5 +- win32/config-msvc.mak | 7 +++ win32/create-lists-msvc.mak | 9 ++++ win32/generate-msvc.mak | 6 +++ win32/info-msvc.mak | 8 ++- win32/pc_base.py | 124 ++++++++++++++++++++++++++++++++++++++++++++ win32/replace.py | 115 ++++++++++++++++++++++++++++++++++++++++ win32/setup.py | 62 ++++++++++++++++++++++ 9 files changed, 353 insertions(+), 3 deletions(-) commit 3b0e47ca006b8fe6a24ace72dd931e3649bb8e6f Author: Ebrahim Byagowi Date: Mon Jun 19 14:47:09 2017 +0430 Fix arm-none-eabi build (fixes #451) (#496) CMakeLists.txt | 4 ++-- src/hb-buffer.cc | 4 ++-- src/hb-common.cc | 28 ++++++++++++++++++++-- src/hb-ot-font.cc | 2 +- src/hb-ot-layout.cc | 2 +- src/hb-ot-shape-complex-arabic-table.hh | 14 +++++------ src/hb-ot-shape-complex-arabic.cc | 2 +- src/hb-ot-shape-complex-hangul.cc | 16 ++++++------- src/hb-ot-shape-complex-indic-table.cc | 22 ++++++++--------- src/hb-ot-shape-complex-indic.cc | 12 +++++----- src/hb-ot-shape-complex-myanmar.cc | 2 +- src/hb-ot-shape-complex-thai.cc | 12 +++++----- src/hb-ot-shape-complex-use-table.cc | 42 ++++++++++++++++----------------- src/hb-unicode-private.hh | 16 ++++++------- src/hb-utf-private.hh | 18 +++++++------- 15 files changed, 110 insertions(+), 86 deletions(-) commit 76c4873e8cad2871d2d547318d371b9a89d8c806 Author: Ebrahim Byagowi Date: Fri Jun 2 21:53:10 2017 +0430 Support branch prediction helpers on clang compiles (#491) src/hb-private.hh | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) commit 7dba30639a6f62803dfc21706bc7c654799f373e Author: Behdad Esfahbod Date: Thu Jun 1 11:44:42 2017 -0400 Handle allocation failure in hb-language code src/hb-common.cc | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) commit 92e2c4baafa0401cb8d7dd2bbd70acfaeaf2aabf Author: Sebastian Rasmussen Date: Mon May 29 12:53:30 2017 -0500 Avoid using strdup inside library. (#488) If an application provides a malloc replacement through hb_malloc_impl() it is important that it is used to allocate everything, but the use of strdup() circumvents this and causes system malloc() to be called instead. This pairs badly with the custom hb_free_impl() being called later. src/hb-common.cc | 8 +++++++- src/hb-private.hh | 4 ---- 2 files changed, 7 insertions(+), 5 deletions(-) commit 06cfe3f7369684fc05fa16da7f6778350f8bcba5 Author: Khaled Hosny Date: Wed May 17 21:32:47 2017 +0300 Do not skip TAG characters in glyph substitution (#487) Hide them like Mongolian Free Variation Selectors instead. Fixes https://github.com/behdad/harfbuzz/issues/463 src/hb-ot-layout-gsubgpos-private.hh | 2 +- src/hb-ot-layout-private.hh | 13 +++++++++---- test/shaping/Makefile.am | 1 + .../sha1sum/53374c7ca3657be37efde7ed02ae34229a56ae1f.ttf | Bin 0 -> 5044 bytes test/shaping/tests/emoji-flag-tags.tests | 2 ++ 5 files changed, 13 insertions(+), 5 deletions(-) commit 1817221620dce713aae67352568ebcc231ab9512 Author: Behdad Esfahbod Date: Tue May 16 14:26:28 2017 -0700 Minor src/hb-atomic-private.hh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 152736981d5bb9e098c1a8b86fcf8fe577a4a9ec Author: Ebrahim Byagowi Date: Sat May 13 21:32:56 2017 +0430 [cmake] Add framework build support (#484) CMakeLists.txt | 46 +++++++++++++++++++++++++++++++++++++++------- 1 file changed, 39 insertions(+), 7 deletions(-) commit bf50ddaf2b416bd80ae8849593bc745b578193d9 Author: Ebrahim Byagowi Date: Thu May 4 20:31:42 2017 +0430 [cmake] minor (#482) CMakeLists.txt | 30 +++++++++++++++++++----------- 1 file changed, 19 insertions(+), 11 deletions(-) commit 141b33de9a141248e2f034d55f48460159536cb9 Author: Behdad Esfahbod Date: Sun Apr 23 16:19:13 2017 -0700 1.4.6 NEWS | 9 +++++++++ configure.ac | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) commit 74b99ef2249107e7cd01bd1ee522a5d9ce61e05f Author: mhosken Date: Thu Apr 20 19:13:22 2017 +0100 Fix graphite2 rtl conversion (#475) src/hb-graphite2.cc | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-) commit 696641314e7eb60a5a2e08c1c4fd1e5e41022148 Author: ebraminio Date: Wed Apr 19 22:59:46 2017 +0430 [cmake] Final touches (#473) CMakeLists.txt | 113 +++++++++++++++++++++++++++------------------------------ 1 file changed, 54 insertions(+), 59 deletions(-) commit aacca37590656e235218557ea509eb5624dfbff9 Author: Chris Peterson Date: Mon Apr 17 23:25:24 2017 -0700 Fix clang -Wcomma warnings (#471) (#472) clang's new -Wcomma compiler option warns about possible misuse of the comma operator such as between two statements. hb-common.cc:190:9 [-Wcomma] possible misuse of comma operator here hb-ot-layout-gsubgpos-private.hh:345:30 [-Wcomma] possible misuse of comma operator here hb-shape-plan.cc:438:26 [-Wcomma] possible misuse of comma operator here src/hb-common.cc | 6 ++++-- src/hb-ot-layout-gsubgpos-private.hh | 2 +- src/hb-shape-plan.cc | 7 ++++--- 3 files changed, 9 insertions(+), 6 deletions(-) commit 4d7c52066b5b205b20ba2679cb57a4e593942102 Author: ebraminio Date: Mon Apr 17 15:53:46 2017 +0430 [cmake] Remove HB_DISABLE_DEPRECATED as it seems needed for pango build (#470) CMakeLists.txt | 2 -- 1 file changed, 2 deletions(-) commit 5ecf96e3a22e896184710a9f146a8bf149af6ca4 Author: William Hua Date: Mon Apr 17 01:33:42 2017 -0400 Use absolute paths of ragel generated headers (#467) https://github.com/behdad/harfbuzz/issues/455 src/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit c42869eb713f53504e1b77a679cff2f88ebd0c20 Author: Dominik Schlösser Date: Sat Apr 15 21:17:05 2017 +0200 Small doc fix: `make check` runs the tests (#469) test/shaping/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 75931427aa4344cd75321c618b8373ffcf1ffc33 Author: ebraminio Date: Fri Apr 14 05:08:11 2017 +0430 [cmake] Fix try compile link issues (#466) CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) commit cb021e14ab345def326fb58ce486515af179b2cf Author: ebraminio Date: Fri Apr 14 04:31:17 2017 +0430 [cmake] typo (#465) CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit a41d5ea4453995dfd7c523427c6017623164c6ff Author: ebraminio Date: Fri Apr 14 04:25:50 2017 +0430 [cmake] Add atomic ops availability detection (#464) CMakeLists.txt | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) commit 8568588202dd718b089e43cd6d46f689c706f665 Author: ebraminio Date: Thu Apr 13 02:17:16 2017 +0430 [cmake] Remove NO_MT flag (#462) CMakeLists.txt | 1 - 1 file changed, 1 deletion(-) commit c04c1fe86ee4b9b58ad88dad5593239ade4c75b8 Author: jfkthame Date: Tue Apr 11 22:29:13 2017 +0100 Blacklist GDEF table in additional Tahoma versions. (#459) There are more broken versions of Tahoma out there on various Windows releases, so we need to add them to our blacklist to avoid broken rendering. See https://bugzilla.mozilla.org/show_bug.cgi?id=1279925 for details. src/hb-ot-layout.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit adfd4ae1cf6c4abe66aecf1eb0a05c7183a0f4e2 Author: ebraminio Date: Tue Apr 11 23:18:18 2017 +0430 [cmake] Improve third party libraries support (#461) CMakeLists.txt | 57 ++++++++++++++++++++++++++++++++++++-------- src/hb-ucdn/Makefile.sources | 5 +++- 2 files changed, 51 insertions(+), 11 deletions(-) commit 3a8bc572115a28741d5a80f3f1e28e6756b9abfa Author: ebraminio Date: Tue Apr 11 21:32:14 2017 +0430 [cmake] Add utils build support (#460) CMakeLists.txt | 150 +++++++++++++++++++++++++++++++++++++++++---------------- 1 file changed, 108 insertions(+), 42 deletions(-) commit bc1244e2395f844b2b41315cb1eef29570e46b29 Author: Chun-wei Fan Date: Thu Apr 6 18:44:28 2017 +0800 NMake Makefiles: Fix ICU builds Fix the check conditions in config-msvc.mak and info-msvc.mak so that the ICU items does indeed get built into the HarfBuzz main DLL, and that the correct configuration info is displayed. Also update the checks in detectenv-msvc.mak so that we can detect that we are using Visual Studio 2017 (although the 2015-built binaries use the same CRT DLL as the 2017 ones). win32/config-msvc.mak | 22 ++++++++++++---------- win32/detectenv-msvc.mak | 4 +++- win32/info-msvc.mak | 12 ++++++++---- 3 files changed, 23 insertions(+), 15 deletions(-) commit a4471d0c2cc4baa81e2cea695f9bd15e03d0f15e Author: Behdad Esfahbod Date: Wed Apr 5 15:42:11 2017 +0200 Move list of ragel sources to Makefile.sources as well src/Makefile.am | 14 ++++---------- src/Makefile.sources | 9 +++++++++ 2 files changed, 13 insertions(+), 10 deletions(-) commit d2acaf6d729727f47c5aacf7ee40097580b6f18d Author: ebraminio Date: Wed Apr 5 02:21:23 2017 -0700 Split ragel generated files lists and remove hardcoded rl files lists (#453) CMakeLists.txt | 126 +++++++++++++++++++++----------------------------- src/Makefile.am | 2 + src/Makefile.sources | 16 +++++-- win32/config-msvc.mak | 8 ++-- 4 files changed, 71 insertions(+), 81 deletions(-) commit 7d64c0ef37dd930e9807bd80d398491aa9c4428c Author: ebraminio Date: Tue Apr 4 15:03:51 2017 +0430 Add CMake build support (#444) CMakeLists.txt | 254 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Makefile.am | 1 + appveyor.yml | 61 +++++++++----- 3 files changed, 295 insertions(+), 21 deletions(-) commit 740fdbcd0e6d25c1d6f12537ca2aa559650b9d52 Author: jfkthame Date: Mon Apr 3 12:22:39 2017 +0100 avoid UBSan warning in get_stage_lookups (#450) See https://bugzilla.mozilla.org/show_bug.cgi?id=1336600 src/hb-ot-map-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8d256841ca7462fd596329abf6f71bafb56fd621 Author: Dominik Schloesser Date: Sun Mar 26 09:22:34 2017 +0200 Current fonttools (3.9.1) generate subset-file called font.subset.ttf instead of older font.ttf.subset test/shaping/record-test.sh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit c2a9de15f5d9477c6f1c143ed8265f71fdb04584 Author: Dominik Schloesser Date: Sun Mar 26 09:21:13 2017 +0200 Updated samples: record-it.sh is now record-test.sh test/shaping/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit f2e6c7ce51283809033d08692a2dee7cf04aefc5 Author: Khaled Hosny Date: Sun Mar 26 10:48:53 2017 +0200 [tools] Make hb-unicode-code work with Python 3 Related to https://github.com/behdad/harfbuzz/pull/445 test/shaping/hb_test_tools.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) commit edcf6344bc62af9ea726a633468c9243e127fa13 Author: Behdad Esfahbod Date: Fri Mar 24 10:24:52 2017 -0700 Blacklist more versions of Padauk Patch from Phil Race. src/hb-ot-layout.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit e693ba77980d5ded65bf773d48b6b58274933fb7 Author: Khaled Hosny Date: Thu Mar 23 00:35:36 2017 +0200 [ci] Fix msys2 build on AppVeyor For whatever reason the env variables need to be the Windows way or they end up being empty. appveyor.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 91570a1eeb1eca425372e203656369f39ede5c61 Author: Khaled Hosny Date: Wed Mar 22 23:07:15 2017 +0200 Just always use strtod here src/hb-common.cc | 4 ---- 1 file changed, 4 deletions(-) commit 539571c1a9cb5d443d029247874af37fed75432f Author: Chun-wei Fan Date: Fri Feb 24 17:58:25 2017 +0800 src/hb-common.cc: Fix build on older Visual Studio Visual Studio only supported strtof() from Visual Studio 2013 onwards, so use strtod() instead to do the operation, which should do the same thing, sans going to a double, not a float. src/hb-common.cc | 4 ++++ 1 file changed, 4 insertions(+) commit b90fb83ea6067802e62af9e1ea0c61c7ac79e9a9 Author: Chun-wei Fan Date: Fri Feb 24 17:47:44 2017 +0800 Visual Studio builds: Fix Introspection when UCDN enabled The sources in src/hb-ucdn and not included correctly into the NMake Makefiles, as we need their explicit relative location as we pass all the sources we used into the introspection scanner. This was not an issue before as we excluded the UCDN sources in the build when we enabled introspection (meaning GLib is enabled), but since we default on using UCDN on all builds unless explicitly disabled, we need to deal with this. This did not affect builds using UCDN without introspection due to the use of NMake batch rules. Fix this by creating a NMake Makefile module on-the-fly with the correct subdir info, and using that list in there instead. win32/Makefile.vc | 15 +++++++++++++++ win32/config-msvc.mak | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) commit f0aa167e447e8aa818a63a4a325be57844bf0353 Author: Chun-wei Fan Date: Thu Feb 23 13:02:49 2017 +0800 Update Visual Studio builds for UCDN usage We now use UCDN by default, so make it so in the build files; however don't hardcode HAVE_UCDN as one may still opt not to use it (but pass it in as a CFLAG unless one explicitly disables UCDN by using NO_UCDN=1 on the NMake command line). Note that we are not blocking builds where UCDN is disabled along with GLib and ICU, as that will trigger a build error anyways which will tell the user what needs to be done to remedy this. win32/README.txt | 6 +++--- win32/config-msvc.mak | 28 +++++++++++++++------------- win32/config.h.win32.in | 2 +- win32/info-msvc.mak | 43 +++++++++++++++++++++++++------------------ 4 files changed, 44 insertions(+), 35 deletions(-) commit 60e2586f7652aaa0ee908eb8f54b1498e2ad299e Author: Behdad Esfahbod Date: Fri Mar 10 23:02:28 2017 -0800 1.4.5 NEWS | 8 ++++++++ configure.ac | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) commit 47e7a1800fba9b8bf042a1f4976a15ab012ebfc7 Author: Behdad Esfahbod Date: Fri Mar 10 13:23:02 2017 -0800 Revert "Fix Context lookup application when moving back after a glyph delete" This reverts commit b9b005f3a44ccf78a45b212b126287b69b9f4b40. This introduced invalid access cases. Revert until I fix correctly. src/hb-ot-layout-gsubgpos-private.hh | 7 ++++--- .../sha1sum/5bbf3712e6f79775c66a4407837a90e591efbef2.ttf | Bin 6400 -> 0 bytes test/shaping/tests/context-matching.tests | 1 - 3 files changed, 4 insertions(+), 4 deletions(-) commit 3c080a7a0aefec1e9620e3fb399ad280ea4ee5a2 Author: Behdad Esfahbod Date: Tue Mar 7 18:13:28 2017 -0800 Fix buffer serialize of empty buffer Ouch! src/hb-buffer-serialize.cc | 2 ++ 1 file changed, 2 insertions(+) commit 8e42c3cb2bb81351d0a28f213cb4f6d35f4b5e46 Author: Behdad Esfahbod Date: Sun Mar 5 13:54:56 2017 -0800 1.4.4 NEWS | 8 ++++++++ configure.ac | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) commit 9ac9af725c781f4597e8db46cf330d595c072739 Author: Behdad Esfahbod Date: Sun Mar 5 13:51:01 2017 -0800 Add TODO item src/hb-ot-layout-gsubgpos-private.hh | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) commit 5aec2fb8d0a4db52ae414d980b66018ca5ce1e9c Author: Behdad Esfahbod Date: Thu Mar 2 11:46:33 2017 -0800 Remove TODO item that is not going to happen src/hb-ot-shape.cc | 1 - 1 file changed, 1 deletion(-) commit b9b005f3a44ccf78a45b212b126287b69b9f4b40 Author: Behdad Esfahbod Date: Wed Mar 1 14:27:23 2017 -0800 Fix Context lookup application when moving back after a glyph delete This was broken forever, since days that we did not allow moving tape backwards. Works now. Reported by Doug Felt. src/hb-ot-layout-gsubgpos-private.hh | 7 +++---- .../sha1sum/5bbf3712e6f79775c66a4407837a90e591efbef2.ttf | Bin 0 -> 6400 bytes test/shaping/tests/context-matching.tests | 1 + 3 files changed, 4 insertions(+), 4 deletions(-) commit a11501444cfc4854bfe2b1d3ce0fc5a957e959d8 Author: Behdad Esfahbod Date: Sat Feb 25 13:37:54 2017 -0800 Add few tests found by libFuzzer and oss-fuzz .../sha1sum/a34a9191d9376bda419836effeef7e75c1386016.ttf | Bin 0 -> 1010 bytes .../sha1sum/a69118c2c2ada48ff803d9149daa54c9ebdae30e.ttf | Bin 0 -> 820 bytes .../sha1sum/b6acef662e0beb8d5fcf5b61c6b0ca69537b7402.ttf | Bin 0 -> 3301 bytes .../sha1sum/e88c339237f52d21e01c55f01b9c1b4cc14a0467.ttf | Bin 0 -> 515 bytes test/shaping/tests/fuzzed.tests | 4 ++++ 5 files changed, 4 insertions(+) commit 85630996b8afa699f7b5d19346cdf5c72fcd6e2d Author: Behdad Esfahbod Date: Sat Feb 25 13:30:38 2017 -0800 Fix buffer-overrun with Bengali reph positioning code This has no security implications whatsoever since we always keep and extra element at the end of buffer, just in case. Discovered by oss-fuzz CC https://github.com/behdad/harfbuzz/issues/139 Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=660 src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6685d281d6f50bf046bbfef4a5263e15d15f2f02 Author: Behdad Esfahbod Date: Sat Feb 25 11:35:05 2017 -0800 1.4.3 NEWS | 12 ++++++++++++ configure.ac | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) commit a657f23ca31237d652b5c101ed24194b6aeadaf8 Author: Dominik Röttsches Date: Mon Feb 20 21:52:07 2017 +0200 Blacklist another instance of Padauk (#419) In https://crbug.com/681813 another instance of Padauk was identified triggering collapsed glyphs. Blacklist this version by patching hb-ot-layout.cc to print out gdef, gsub, and gpos table length, then adding those to the list of blacklisted versions. src/hb-ot-layout.cc | 3 +++ 1 file changed, 3 insertions(+) commit 70202983f57fe85b2d3b56a9c205effeee66222d Author: ebraminio Date: Sat Feb 18 10:37:36 2017 +0330 [ci] Disable vcpkg freetype installation and fix Appveyor CI (#422) appveyor.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) commit 44f7d6ecde9bf7427a05cbe73ed5d668b8a72b2a Author: jfkthame Date: Fri Feb 17 03:03:24 2017 +0000 Guard against underflow when adjusting length (#421) * Guard against underflow when adjusting length With the fuzz-testcase in mozilla bug 1295299, we end up with a recursed lookup that removes 3 items, when `match_positions[idx]` is 0, which results in (unsigned) `end` wrapping to a huge value. Making `end` a signed int is probably the simplest route to a fix. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1295299. * Add testcase for #421. src/hb-ot-layout-gsubgpos-private.hh | 6 +++--- .../sha1sum/558661aa659912f4d30ecd27bd09835171a8e2b0.ttf | Bin 0 -> 1358 bytes test/shaping/tests/fuzzed.tests | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) commit 45766b673f427bb791c9d5886cadedfac0447066 Author: jfkthame Date: Thu Feb 16 17:40:21 2017 +0000 [indic] Add support for Grantha marks that may be used in Tamil to th… (#401) * [indic] Add support for Grantha marks that may be used in Tamil to the Indic table. See https://bugzilla.mozilla.org/show_bug.cgi?id=1331339. Testcase: U+0BA4,U+0BC6,U+1133c,U+0BAA,U+1133c,U+0BC6,U+1133c * [indic] Add test for Grantha nukta that is allowed in Tamil by ScriptExtensions.txt src/hb-ot-shape-complex-indic-table.cc | 7 +++++++ .../sha1sum/3493e92eaded2661cadde752a39f9d58b11f0326.ttf | Bin 0 -> 1400 bytes test/shaping/tests/indic-script-extensions.tests | 1 + 3 files changed, 8 insertions(+) commit d4bb52b9fd8a5bc4af13752ea3e464eccfe3223b Author: Behdad Esfahbod Date: Thu Feb 9 14:13:25 2017 -0800 Unbreak hb-coretext build src/hb-coretext.cc | 3 +++ 1 file changed, 3 insertions(+) commit c8dfed8e1ee4ab64b6936f5c8561db0666e37647 Merge: 7c47474f b435c7c4 Author: Behdad Esfahbod Date: Wed Feb 8 14:36:18 2017 -0800 Merge pull request #357 from khaledhosny/graphite-scale [graphite] Fix shaping with varying font sizes commit 7c47474f209bdf84cf87844c277ed711cad78196 Author: Behdad Esfahbod Date: Wed Feb 8 14:33:28 2017 -0800 Set LC_ALL instead of LANG when creating harfbuzz.def Hopefully fixes Travis faliure? https://github.com/behdad/harfbuzz/pull/413#issuecomment-278481882 https://travis-ci.org/khaledhosny/harfbuzz/jobs/199785332#L1065 src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ffde3c9f9effcd2b47f5fd76df45551e68c0b1ec Author: Philip Withnall Date: Wed Feb 8 21:56:57 2017 +0000 hb-font: Fix a potentially undefined use of memcmp() (#413) While it’s fine to call memcmp(x, 0, 0) in practice, the C99 standard explicitly says that this is not allowed: even if the length is zero, the pointer arguments must be valid. http://stackoverflow.com/a/16363034 Coverity ID: 141178 Signed-off-by: Philip Withnall src/hb-font.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 09594df1aecbb7d37093055147c25cc7d7b7fef6 Author: Behdad Esfahbod Date: Tue Feb 7 18:25:12 2017 -0800 Update ax_pthread.m4 to latest upstream version Might help with https://github.com/behdad/harfbuzz/issues/399 m4/ax_pthread.m4 | 394 ++++++++++++++++++++++++++++++++++++++++--------------- 1 file changed, 285 insertions(+), 109 deletions(-) commit a6ced90efccf869defc0b310effca220f01cf318 Author: Philip Withnall Date: Wed Feb 8 02:18:33 2017 +0000 test: Fix some memory leaks in test-font.c (#409) Coverity IDs: 141039, 141040, 141041 test/api/test-font.c | 35 ++++++++++++++++++++++++++++++----- 1 file changed, 30 insertions(+), 5 deletions(-) commit 925ceacfed45c44dd2a025c32bebb1358b560741 Author: Philip Withnall Date: Wed Feb 8 02:17:48 2017 +0000 util: Add missing field initialisers in constructor (#410) Coverity ID: 141042 util/hb-shape.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 73c6dcbb45269186f204b2212288b6384ce42c9d Author: Behdad Esfahbod Date: Tue Feb 7 16:53:21 2017 -0800 Silence Coverity warning Fixes https://github.com/behdad/harfbuzz/issues/408 src/hb-ot-shape-complex-arabic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 466b3e58bdc64229dab08c6e0e0079c789540370 Author: Behdad Esfahbod Date: Fri Feb 3 16:43:25 2017 -0800 Shuffle things around a bit src/hb-coretext.cc | 4 ++-- src/hb-directwrite.cc | 4 ++-- src/hb-fallback-shape.cc | 4 ++++ src/hb-graphite2.cc | 4 ++-- src/hb-ot-layout-private.hh | 1 - src/hb-ot-layout.cc | 2 -- src/hb-ot-math.cc | 3 +-- src/hb-ot-shape.cc | 4 ++++ src/hb-ot-var.cc | 2 -- src/hb-shape-plan.cc | 7 ------- src/hb-shaper-private.hh | 11 +++++++---- src/hb-uniscribe.cc | 4 ++-- 12 files changed, 24 insertions(+), 26 deletions(-) commit fc8189b63931f03c5d2e70dde198e9c856bd78f5 Author: Behdad Esfahbod Date: Fri Feb 3 16:17:08 2017 -0800 Minor src/hb-shaper-private.hh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit d3d3691806aaa6aed93a88c845d472e727e7f850 Author: Behdad Esfahbod Date: Fri Feb 3 15:42:03 2017 -0800 Add dirty-state tracking to hb_face_t src/hb-face-private.hh | 9 +++++++++ src/hb-face.cc | 19 ++++++++++++++++++- src/hb-font.cc | 2 +- 3 files changed, 28 insertions(+), 2 deletions(-) commit 2171f48b4b1e66a3c16a83cc00b0006d32ae9738 Author: Behdad Esfahbod Date: Fri Feb 3 10:58:09 2017 -0800 Add dirty-state tracking to hb_font_t src/hb-font-private.hh | 12 ++++++++++++ src/hb-font.cc | 30 ++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+) commit 95808bad2c17a9ef41c58c04faf1b4706fb7d72e Author: Behdad Esfahbod Date: Fri Feb 3 10:39:40 2017 -0800 Add new API hb_font_set_face() For completeness. src/hb-font.cc | 29 +++++++++++++++++++++++++++++ src/hb-font.h | 4 ++++ 2 files changed, 33 insertions(+) commit 4ec19319ab195d852708661e12da2a6485fce544 Author: jfkthame Date: Thu Feb 2 18:48:23 2017 +0000 Add Win10 Anniversary Update version of Tahoma to GDEF blacklist. (#412) src/hb-ot-layout.cc | 4 ++++ 1 file changed, 4 insertions(+) commit 1dd630a7f2c2cec780fee507367341bc9050cdb3 Author: Behdad Esfahbod Date: Wed Feb 1 11:57:21 2017 -0800 Minor Fixes https://github.com/behdad/harfbuzz/issues/411 src/hb-fallback-shape.cc | 2 +- src/hb-ot-shape-normalize.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit e888f642db16f52836cbfec29de43ff20236dc85 Author: Behdad Esfahbod Date: Thu Jan 26 14:50:14 2017 -0800 Route Adlam through Arabic shaper Fixes joined Adlam rendering. Fixes https://github.com/googlei18n/noto-fonts/issues/828 src/hb-ot-shape-complex-private.hh | 3 +++ test/shaping/Makefile.am | 1 + .../5dfad7735c6a67085f1b90d4d497e32907db4c78.ttf | Bin 0 -> 21160 bytes test/shaping/tests/arabic-like-joining.tests | 1 + 4 files changed, 5 insertions(+) commit 72c754873c6b15cecb32d9e491c98495f804347a Author: jfkthame Date: Thu Jan 26 22:35:41 2017 +0000 Add Win7 version of himalaya.ttf to the GDEF table blacklist. (#407) src/hb-ot-layout.cc | 2 ++ 1 file changed, 2 insertions(+) commit 22af28a3f14c6d748ed589f8980b168152116c8c Author: Behdad Esfahbod Date: Mon Jan 23 23:42:53 2017 -0800 [var] Implement MVAR table Unhooked. Untested. src/Makefile.sources | 1 + src/hb-font.cc | 2 +- src/hb-ot-var-mvar-table.hh | 110 ++++++++++++++++++++++++++++++++++++++++++++ src/hb-ot-var.cc | 1 + 4 files changed, 113 insertions(+), 1 deletion(-) commit 67a191164dec2cfcab97363175c58e459f6ff8f9 Author: Behdad Esfahbod Date: Mon Jan 23 23:21:30 2017 -0800 [var] Whitespace src/hb-ot-var-hvar-table.hh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 6af6c1114a3495584ac4197c62592741c407b5a2 Author: Behdad Esfahbod Date: Mon Jan 23 18:35:00 2017 -0800 1.4.2 NEWS | 31 +++++++++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 32 insertions(+), 1 deletion(-) commit 79e8e27ffd3da29ca27d3aebd2ef425bf1cb7f9d Author: Behdad Esfahbod Date: Mon Jan 23 17:55:31 2017 -0800 [var] Hook up advance variations to hb-ot-font Yay, works! src/hb-ot-font.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 607434037199ccca422287e4d097487f17f3cfb5 Author: Behdad Esfahbod Date: Mon Jan 23 17:55:16 2017 -0800 [var] Fix bug in HVAR/VVAR impl src/hb-ot-var-hvar-table.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit bd3b11d92663343350813ca29606b369f691af03 Author: Behdad Esfahbod Date: Mon Jan 23 17:34:44 2017 -0800 [var] Prepare for hooking up advance variations to hb-ot-font src/hb-ot-font.cc | 28 +++++++++++++++++----------- src/hb-ot-var-hvar-table.hh | 8 ++++---- 2 files changed, 21 insertions(+), 15 deletions(-) commit a4fca9f0051dbc177390a4e555b2d0fe642f724e Author: Behdad Esfahbod Date: Mon Jan 23 11:56:08 2017 -0800 [var] Implement DeltaSetIndexMap and advance delta fetching Not hooked up to hb-ot-font yet. src/hb-ot-layout-common-private.hh | 8 ++++++ src/hb-ot-var-hvar-table.hh | 56 ++++++++++++++++++++++++++++++++++++-- 2 files changed, 61 insertions(+), 3 deletions(-) commit 7b399f73efa76cd97131fd123a9a1566f8639cfd Author: Behdad Esfahbod Date: Mon Jan 23 11:41:43 2017 -0800 [var] Start adding HVAR/VVAR src/Makefile.sources | 1 + src/hb-ot-font.cc | 1 + src/hb-ot-var-avar-table.hh | 1 - src/hb-ot-var-fvar-table.hh | 1 - src/hb-ot-var-hvar-table.hh | 115 ++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 117 insertions(+), 2 deletions(-) commit b732c53eb5bd0c2cc86f35a9d9623c92579a0b8c Author: Behdad Esfahbod Date: Sun Jan 22 20:31:53 2017 -0800 Add LArrayOf<> src/hb-open-type-private.hh | 1 + src/hb-ot-cbdt-table.hh | 4 ++-- src/hb-ot-layout-common-private.hh | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) commit 5e156fa5ed33cd1a8ff388833563f15930bb12f9 Author: Behdad Esfahbod Date: Sun Jan 22 20:28:56 2017 -0800 Add LOffsetTo<> src/hb-open-file-private.hh | 2 +- src/hb-open-type-private.hh | 1 + src/hb-ot-cbdt-table.hh | 4 ++-- src/hb-ot-cmap-table.hh | 6 +++--- src/hb-ot-layout-common-private.hh | 10 +++++----- src/hb-ot-layout-gdef-table.hh | 4 ++-- src/hb-ot-layout-gsubgpos-private.hh | 2 +- 7 files changed, 15 insertions(+), 14 deletions(-) commit d6bdbbca307d1a4aed60a78133eea40a1a9d5bf3 Author: Behdad Esfahbod Date: Sun Jan 22 20:16:51 2017 -0800 [var] Remove HB_OT_TAG_fvar/avar We're not going to define public macros for tags for tables. There's little use to those and they are implementation detail. docs/harfbuzz-sections.txt | 2 -- src/hb-ot-var-avar-table.hh | 2 ++ src/hb-ot-var-fvar-table.hh | 2 ++ src/hb-ot-var.h | 3 --- 4 files changed, 4 insertions(+), 5 deletions(-) commit a11d9a0466e480efebd69a34827675387cd2ca34 Author: Behdad Esfahbod Date: Sun Jan 22 20:09:47 2017 -0800 Minor src/hb-ot-font.cc | 6 +++--- src/hb-ot-hmtx-table.hh | 8 +++----- 2 files changed, 6 insertions(+), 8 deletions(-) commit 7a860f656e4aec45c45e0f5fb28c49a91dc5eef2 Author: Behdad Esfahbod Date: Sun Jan 22 19:52:09 2017 -0800 [var] Add macros for standard axes docs/harfbuzz-sections.txt | 7 +++++++ src/hb-ot-var.h | 6 ++++++ 2 files changed, 13 insertions(+) commit a484e237b11650d00092329855d33dd2f67980e4 Author: Behdad Esfahbod Date: Sun Jan 22 19:41:33 2017 -0800 [var] Implement 'avar' table mapping Untested! src/hb-ot-math.cc | 2 -- src/hb-ot-var-avar-table.hh | 46 ++++++++++++++++++++++++++++++++++++++++++++- src/hb-ot-var.cc | 23 +++++++++++++++-------- 3 files changed, 60 insertions(+), 11 deletions(-) commit a42909057207cbed1ef95716170434c05beb0002 Author: Behdad Esfahbod Date: Sun Jan 22 19:01:07 2017 -0800 [var] Flesh out --variations documentation util/options.cc | 53 ++++++++++++++--------------------------------------- 1 file changed, 14 insertions(+), 39 deletions(-) commit 5ec96d30cad1592b5e468bd8ad1832dbaf0ad32b Author: Behdad Esfahbod Date: Sun Jan 22 18:52:00 2017 -0800 [var] Adjust API in prep for 'avar' implementation The 'avar' table does not allow random access to axis maps, so change API to avoid quadratic-time implementation. Removed -hb_ot_var_normalize_axis_value(), added +hb_ot_var_normalize_variations() and +hb_ot_var_normalize_coords() instead. docs/harfbuzz-sections.txt | 3 ++- src/Makefile.sources | 1 + src/hb-font.cc | 20 +++++--------------- src/hb-ot-var.cc | 45 +++++++++++++++++++++++++++++++++++++++------ src/hb-ot-var.h | 16 ++++++++++++---- 5 files changed, 59 insertions(+), 26 deletions(-) commit 8a577aaa0dd760409bcad1ae3d4f5fb561a62a4b Author: Behdad Esfahbod Date: Sun Jan 22 18:22:40 2017 -0800 [var] Stub implementation of avar table src/hb-ot-var-avar-table.hh | 99 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 99 insertions(+) commit 7647a05a0b37c53465560952b412db4e590f2716 Author: Behdad Esfahbod Date: Sun Jan 22 17:47:49 2017 -0800 Minor src/hb-font.cc | 5 ++++- src/hb-font.h | 2 +- src/hb-ft.cc | 2 +- util/helper-cairo.cc | 14 +++++++++----- 4 files changed, 15 insertions(+), 8 deletions(-) commit d2f249e745a9179943ee39c719b73e1057acbc13 Author: Behdad Esfahbod Date: Sun Jan 22 17:42:33 2017 -0800 Stub out doc comments for new symbols docs/harfbuzz-docs.xml | 2 +- docs/harfbuzz-sections.txt | 35 +++++++++++++++++++++++++++++++++-- src/hb-common.cc | 10 ++++++++++ src/hb-common.h | 5 +++++ src/hb-directwrite.cc | 2 +- src/hb-directwrite.h | 2 +- src/hb-font.cc | 20 ++++++++++++++++++++ src/hb-ot-var.cc | 24 ++++++++++++++++++++++-- src/hb-ot-var.h | 12 +++++------- src/hb-set.cc | 2 +- 10 files changed, 99 insertions(+), 15 deletions(-) commit 5dfd341f51543279039ddafe883c0a1de205fb8a Author: Behdad Esfahbod Date: Sun Jan 22 16:55:40 2017 -0800 Minor src/hb-directwrite.cc | 4 ++-- src/hb-shape.cc | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) commit 825e40407da74576f8e83ce0bacad5b0459b83c8 Author: Behdad Esfahbod Date: Sun Jan 22 16:41:45 2017 -0800 [hb-ft] Remove use of variable-length array Hopefully also fixes build failure on msvc. src/hb-ft.cc | 33 +++++++++++++++++++++------------ 1 file changed, 21 insertions(+), 12 deletions(-) commit 47ee34e84745756a9aaeb964772377b6c1417ed1 Author: Behdad Esfahbod Date: Sat Jan 21 18:10:08 2017 -0800 [var] Hook up variations to FreeType face hb-view correctly renders variations with ft font-funcs now. hb-ot-font needs HVAR implementation. src/hb-ft.cc | 10 ++++++++++ util/helper-cairo.cc | 16 +++++++++++++++- 2 files changed, 25 insertions(+), 1 deletion(-) commit 111f3e55178f7cd5a8ae4e8ae111cb48aea4acb5 Author: Behdad Esfahbod Date: Sat Jan 21 17:51:41 2017 -0800 [util] Add --variations Is hooked up to the font, but not to FreeType, so raster doesn't show yet. Documentation needs to be done. util/options.cc | 91 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ util/options.hh | 8 ++++- 2 files changed, 98 insertions(+), 1 deletion(-) commit bb1e19268f02d4aad2240c52852e72afcf0f79ad Author: Behdad Esfahbod Date: Sat Jan 21 17:41:37 2017 -0800 [var] Rename var_coord to variation Looks much better. src/hb-common.cc | 36 ++++++++++++++++++------------------ src/hb-common.h | 10 +++++----- src/hb-font.cc | 20 ++++++++++---------- src/hb-font.h | 6 +++--- 4 files changed, 36 insertions(+), 36 deletions(-) commit 64fe92bf2d43a0ea31743d774e073f202021dbd1 Author: Behdad Esfahbod Date: Sat Jan 21 15:36:35 2017 -0800 [var] Remove use of variable-length arrays src/hb-font.cc | 30 +++++++++++++++++++++--------- 1 file changed, 21 insertions(+), 9 deletions(-) commit 2491134b386507f611a47e43e3f7c2766d0d288b Author: Behdad Esfahbod Date: Sat Jan 21 15:21:50 2017 -0800 [var] Add hb_font_set_var_coords() src/hb-font.cc | 38 ++++++++++++++++++++++++++++++++++++-- src/hb-font.h | 8 ++++++-- 2 files changed, 42 insertions(+), 4 deletions(-) commit 113393efec5e0c4c10c141a6d4b801d50fcd8ab8 Author: Behdad Esfahbod Date: Sat Jan 21 15:12:03 2017 -0800 Remove a few unused includes src/hb-face.cc | 6 +----- src/hb-font.cc | 7 ------- src/hb-ot-layout.cc | 5 +---- src/hb-ot-tag.cc | 3 --- 4 files changed, 2 insertions(+), 19 deletions(-) commit 2d40923ca914c90304d07d6e7b9b1040c79c76fe Author: Behdad Esfahbod Date: Sat Jan 21 15:06:15 2017 -0800 Minor src/hb-ot-math.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8b2a58047095604dcdc576ecbe3e8c2ebb8f48f0 Author: Behdad Esfahbod Date: Sat Jan 21 15:05:00 2017 -0800 [var] Add hb_font_set_var_coords_design() src/hb-font.cc | 21 +++++++++++++++++++-- src/hb-font.h | 7 ++++++- 2 files changed, 25 insertions(+), 3 deletions(-) commit 0dcc7b49a830e2680d3e6d86d953efab85cef6ff Author: Behdad Esfahbod Date: Sat Jan 21 14:50:22 2017 -0800 [var] Minor lifecycle adjustment src/hb-font.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit bf0d3a665baac9e33c0f774b22197c321b864c80 Author: Behdad Esfahbod Date: Sat Jan 21 14:48:46 2017 -0800 [var] Add hb_font_get_var_coords_normalized() src/hb-font.cc | 10 ++++++++++ src/hb-font.h | 4 ++++ 2 files changed, 14 insertions(+) commit b3c0714b4bbb726b2b3e5e0416ac84cb5c6eb34e Author: Behdad Esfahbod Date: Fri Jan 20 20:30:03 2017 -0800 [var] Add hb_var_coord_t and parsing routines src/hb-common.cc | 94 +++++++++++++++++++++++++++++++++++++++++++++++++++++--- src/hb-common.h | 15 ++++++++- 2 files changed, 103 insertions(+), 6 deletions(-) commit 72364103bc9d910d19f23a3764d045af79d076d5 Author: Behdad Esfahbod Date: Fri Jan 20 20:16:53 2017 -0800 Move code around src/hb-common.cc | 250 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/hb-common.h | 18 ++++ src/hb-shape.cc | 248 ------------------------------------------------------ src/hb-shape.h | 16 ---- 4 files changed, 268 insertions(+), 264 deletions(-) commit 785982bf830723552270db5649abcb9f9f0b46b1 Author: Behdad Esfahbod Date: Fri Jan 20 19:57:27 2017 -0800 [var] Flesh out some more src/Makefile.am | 2 ++ src/hb-ot-var-fvar-table.hh | 69 ++++++++++++++++++++++++++++++++------------- src/hb-ot-var.cc | 39 ++++++++++++++++++++++++- src/hb-ot-var.h | 21 +++++++++----- 4 files changed, 104 insertions(+), 27 deletions(-) commit 422c0c36c80145a2d993f80d5c7d3265e3d8357a Author: Behdad Esfahbod Date: Fri Jan 20 19:14:54 2017 -0800 [var] Flesh out a bit src/hb-ot-var-fvar-table.hh | 72 ++++++++++++++++++++++++++++++++++++--------- src/hb-ot-var.h | 10 ++++++- 2 files changed, 67 insertions(+), 15 deletions(-) commit b8376b10904e1772b8d34d852d1100ca7e2185e2 Author: Behdad Esfahbod Date: Fri Jan 20 18:19:28 2017 -0800 Minor src/hb-ft.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f2e73d37e77ccea8b948d1ecf5f11e7a699386dc Author: Behdad Esfahbod Date: Fri Jan 20 17:42:18 2017 -0800 [var] Remove over-optimization src/hb-font.cc | 4 ---- 1 file changed, 4 deletions(-) commit 469926cc45760cb681d44e5757b18b9bdd736189 Author: Behdad Esfahbod Date: Fri Jan 20 17:40:46 2017 -0800 [var] Change double to float in API src/hb-ot-var.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 55d42fd667b9c34a1109bb850bf2ea7322c01040 Author: Behdad Esfahbod Date: Thu Jan 19 19:35:48 2017 -0800 Start adding hb-ot-var.h and implementation Supports enumerating variation axes, normalizing values, etc. src/Makefile.sources | 3 + src/hb-ot-layout-private.hh | 6 ++ src/hb-ot-layout.cc | 4 ++ src/hb-ot-var-fvar-table.hh | 133 ++++++++++++++++++++++++++++++++++++++++++++ src/hb-ot-var.cc | 63 +++++++++++++++++++++ src/hb-ot-var.h | 81 +++++++++++++++++++++++++++ src/hb-ot.h | 1 + 7 files changed, 291 insertions(+) commit 272b5115325b785e92ff5500d4bfc3a67490b6f8 Author: Behdad Esfahbod Date: Thu Jan 19 19:33:07 2017 -0800 Minor src/hb-ot-math.cc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) commit a8a5e81a52f56f5f8bf975dc4d9f79bede5d895b Author: Behdad Esfahbod Date: Thu Jan 19 16:55:04 2017 -0800 [test-ot-math] Add test with nil face/font test/api/test-ot-math.c | 8 ++++++++ 1 file changed, 8 insertions(+) commit 331d07bd40a3d9ff30db5cdf85fdc4f10f0fcb99 Author: Behdad Esfahbod Date: Thu Jan 19 16:51:36 2017 -0800 Minor test/api/test-ot-math.c | 3 +++ 1 file changed, 3 insertions(+) commit b5ecf1bfa459a755e36bc4c7f545c7f803b7d016 Author: Behdad Esfahbod Date: Thu Jan 19 16:50:29 2017 -0800 Fix warnings test/api/test-ot-math.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) commit 2f2ceee1853649d1b2ad4315a38cd9c07659932a Author: Behdad Esfahbod Date: Thu Jan 19 16:48:01 2017 -0800 Minor test/api/test-ot-math.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 2452543fdd383e62b8c4bc44b11bfd6796fc9963 Author: Khaled Hosny Date: Wed Jan 18 22:48:13 2017 +0200 [ot] Fix automatic fraction for RTL scripts (#405) The numbers for right-to-left scripts are processed also from right to left, so the order of applying “numr” and “dnom” features should be reversed in such case. Fixes https://github.com/behdad/harfbuzz/issues/395 src/hb-ot-shape.cc | 16 ++++++++++++++-- test/shaping/Makefile.am | 1 + .../15dfc433a135a658b9f4b1a861b5cdd9658ccbb9.ttf | Bin 0 -> 4936 bytes test/shaping/tests/automatic-fractions.tests | 3 +++ 4 files changed, 18 insertions(+), 2 deletions(-) commit 1337428e4f8a2a4c78312c581bf4e96cd49d783f Author: Sascha Brawer Date: Wed Jan 18 13:51:02 2017 +0100 Update language tags to OpenType 1.8.1 (#403) Resolves https://github.com/behdad/harfbuzz/issues/324 src/hb-ot-tag.cc | 77 ++++++++++++++++++++++++++++++++++++++++++++------ test/api/test-ot-tag.c | 58 +++++++++++++++++++++++++++++++++++++ 2 files changed, 126 insertions(+), 9 deletions(-) commit 784d1180de19fbf4948f08ee2124277cc06066dd Author: Behdad Esfahbod Date: Wed Jan 11 11:58:13 2017 -0800 Fix build with clang src/hb-open-type-private.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 1f810daf1640f279c2f7aad8c312664cf2293987 Author: Behdad Esfahbod Date: Mon Jan 9 23:50:56 2017 -0800 Port math table to hb_lazy_table_loader_t src/hb-open-type-private.hh | 22 +++++++++++++++++----- src/hb-ot-layout-private.hh | 4 ++-- src/hb-ot-layout.cc | 7 +++---- src/hb-ot-math.cc | 17 +---------------- 4 files changed, 23 insertions(+), 27 deletions(-) commit ebbcc1112229cde9ed469efdfeac7ef79dfcd834 Author: Behdad Esfahbod Date: Mon Jan 9 22:45:25 2017 -0800 Add hb_lazy_table_loader_t src/hb-open-type-private.hh | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) commit 1af9d924a474f210fda10b5e8ab6b388241aa0b5 Author: Behdad Esfahbod Date: Mon Jan 9 22:22:37 2017 -0800 Move lazy-loader to more generic place src/hb-open-type-private.hh | 47 ++++++++++++++++++++++++++++++++++++++++++++ src/hb-ot-font.cc | 48 ++------------------------------------------- 2 files changed, 49 insertions(+), 46 deletions(-) commit ac274331c285e1b42632870e150e1d66a9e21933 Author: Behdad Esfahbod Date: Mon Jan 9 22:20:38 2017 -0800 In lazy-loading, remember allocation failure src/hb-ot-font.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 29fb0cb727555ea60460d794a3c6f30179546af9 Author: Behdad Esfahbod Date: Mon Jan 9 21:18:55 2017 -0800 Minor src/hb-face-private.hh | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) commit 93ef684b9bc411b7642df3adeb2248ad6010ee66 Author: Behdad Esfahbod Date: Mon Jan 9 21:11:00 2017 -0800 Rename hb-ot-layout-math-table.hh to hb-ot-math-table.hh src/Makefile.sources | 2 +- src/{hb-ot-layout-math-table.hh => hb-ot-math-table.hh} | 6 +++--- src/hb-ot-math.cc | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) commit 3b5263b0e9e23e56e14ce6a8498c21c5ce95cc35 Author: Behdad Esfahbod Date: Mon Jan 9 15:49:08 2017 -0800 Typo src/hb-ot-layout-math-table.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ebf927d3d4394159e480fec2042a0456df8dd0f4 Author: ebraminio Date: Mon Jan 9 13:12:09 2017 +0330 Make UCDN default enabled (fixes #389) (#391) win32/config-msvc.mak | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) commit 00adf9c8a4573a2b3ef61991197821af03bca310 Author: Behdad Esfahbod Date: Mon Jan 9 00:00:49 2017 -0800 Minor Should be enough to get -hangul.cc out of SOURCES in Firefox build: https://dxr.mozilla.org/mozilla-central/source/gfx/harfbuzz/src/moz.build No one else should care! src/hb-ot-shape-complex-hangul.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7cf9952e7fc015d0b08d3de6c95357662d57ad8d Author: Behdad Esfahbod Date: Sun Jan 8 23:55:54 2017 -0800 [USE] Remove non-canonical decompositions We have had added this in Indic shaper to assist shaping these scripts. In Universal Shaping Engine however, it is up to font designer to decompose them. Hence moving them from Indic shaper to USE was wrong. Fixup for f6ba63b2e8eb577385f70758efdd3b8408c8a9cb Part of fixing https://github.com/behdad/harfbuzz/issues/387 src/hb-ot-shape-complex-use.cc | 22 ---------------------- 1 file changed, 22 deletions(-) commit b435c7c46a46350771e837e87fee448fd9dc06d3 Author: Khaled Hosny Date: Fri Nov 11 02:16:39 2016 +0200 [graphite] Stop creating unused gr_face It is unused after previous commit, hb_graphite2_font_get_gr_font() makes no sense now so deprecating it. src/hb-graphite2.cc | 22 +++++----------------- src/hb-graphite2.h | 4 ++++ 2 files changed, 9 insertions(+), 17 deletions(-) commit 1b00a3b0488a5d1c6ede141ae0545e2eb9af0ed8 Author: Khaled Hosny Date: Sun Oct 30 20:16:41 2016 +0200 [graphite] Fix shaping with varying font sizes Shape using design units and scale the output. See https://bugs.documentfoundation.org/show_bug.cgi?id=103403#c7 src/hb-graphite2.cc | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) commit af596a5655ee2ed09da17a7de79f619e1547dcd9 Author: Behdad Esfahbod Date: Thu Jan 5 20:24:41 2017 -0800 1.4.1 NEWS | 10 ++++++++++ configure.ac | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) commit 31f7b1bb94c2cef7ce58df52ddd1b09b42e8f596 Author: Behdad Esfahbod Date: Thu Jan 5 20:20:06 2017 -0800 Add tests for USE using Marchen font and text From http://www.babelstone.co.uk/Fonts/Marchen.html test/shaping/Makefile.am | 1 + .../85414f2552b654585b7a8d13dcc3e8fd9f7970a3.ttf | Bin 0 -> 66936 bytes test/shaping/tests/use-marchen.tests | 35 +++++++++++++++++++++ 3 files changed, 36 insertions(+) commit 53543f8b3e19456279c86f711feba42ce976668c Author: Behdad Esfahbod Date: Thu Jan 5 20:12:32 2017 -0800 Ship UCDN and use it by default So we are not relying on version of Unicode data in glib... Fixes https://github.com/behdad/harfbuzz/issues/386 Fixes https://github.com/behdad/harfbuzz/issues/388 configure.ac | 12 ++++++++---- src/hb-unicode.cc | 6 +++--- 2 files changed, 11 insertions(+), 7 deletions(-) commit f3397069479cae34e6bdc658e2875fb178b03e43 Author: Behdad Esfahbod Date: Thu Jan 5 01:27:49 2017 -0800 1.4.0 NEWS | 34 ++++++++++++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 35 insertions(+), 1 deletion(-) commit ae00af4a47587308969dfaf7baa93164d7842710 Author: Frédéric Wang Date: Tue Jan 3 05:55:09 2017 +0100 Move math-specific code from hb-ot-layout to hb-ot-math #235 (#384) src/Makefile.sources | 1 + src/hb-ot-layout.cc | 244 --------------------------------------------- src/hb-ot-math.cc | 272 +++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 273 insertions(+), 244 deletions(-) commit e053ccc5bb7268fe5900dd364d906638c58b2908 Author: Behdad Esfahbod Date: Wed Dec 28 15:51:57 2016 -0500 Remove Android.mk Android uses its own file these days and third-party developers should be using the autotools-based system against Android NDK. Android.mk | 107 ------------------------------------------------------------ Makefile.am | 1 - 2 files changed, 108 deletions(-) commit 6cff75394192a1ab0dda82981752ade532838333 Author: Behdad Esfahbod Date: Wed Dec 28 13:46:21 2016 -0500 Remove Tibetan decomposition rules from Indic shaper The decomposition is very obscure and unlikely to help any fonts. Just remove it since Uniscribe probably doesn't do this either. Fixes https://github.com/behdad/harfbuzz/issues/382 src/hb-ot-shape-complex-indic.cc | 4 ---- 1 file changed, 4 deletions(-) commit f6ba63b2e8eb577385f70758efdd3b8408c8a9cb Author: Behdad Esfahbod Date: Wed Dec 28 13:45:32 2016 -0500 Port decompositions from Indic to USE shaper Part of https://github.com/behdad/harfbuzz/issues/382 src/hb-ot-shape-complex-indic.cc | 16 ---------------- src/hb-ot-shape-complex-use.cc | 22 ++++++++++++++++++++++ 2 files changed, 22 insertions(+), 16 deletions(-) commit e678b537f77954615721abd65fef28854f95dc5d Author: Behdad Esfahbod Date: Mon Dec 26 14:11:59 2016 -0500 [indic] Remove Chakma decomposition rule from Indic shaper This is now added to USE: https://github.com/behdad/harfbuzz/pull/383 See: https://github.com/behdad/harfbuzz/issues/381 https://github.com/behdad/harfbuzz/issues/382 src/hb-ot-shape-complex-indic.cc | 4 ---- 1 file changed, 4 deletions(-) commit 49ba698124399373cea000d08e0e9fe5fc2396e8 Author: jfkthame Date: Wed Dec 28 18:00:51 2016 +0000 [use] Special-case Chakma split-vowel decomp in the USE shaper. (#383) src/hb-ot-shape-complex-use.cc | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) commit c4ca49d55b49c65e04f0b2acecacd6a5c70978f4 Author: Behdad Esfahbod Date: Mon Dec 26 14:52:08 2016 -0500 Revert "[indic] Remove redundant Chakma decomposition rule" This reverts commit 805f76fc002d703acfcc4c5727f0b4d1baecefaa. Need to investigate why having this rule (with the reversed order) fixes decomposition as reported by punchcutter: https://github.com/behdad/harfbuzz/issues/381#issuecomment-269237796 src/hb-ot-shape-complex-indic.cc | 4 ++++ 1 file changed, 4 insertions(+) commit 805f76fc002d703acfcc4c5727f0b4d1baecefaa Author: Behdad Esfahbod Date: Mon Dec 26 14:11:59 2016 -0500 [indic] Remove redundant Chakma decomposition rule This was not used BTW since Chakma doesn't go through Indic shaper anymore. See: https://github.com/behdad/harfbuzz/issues/381 https://github.com/behdad/harfbuzz/issues/382 src/hb-ot-shape-complex-indic.cc | 4 ---- 1 file changed, 4 deletions(-) commit 3cc48a46b56be06e6734aaabf37a4b521606380c Author: Behdad Esfahbod Date: Mon Dec 26 13:10:31 2016 -0500 [indix] Comment src/hb-ot-shape-complex-indic.cc | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) commit 7d1c5d8281b05a5c178ea3ae048b0062145968aa Author: nvelinov Date: Sat Dec 24 02:46:37 2016 +0100 Compilation Error for ASSERT_STATIC on Some Compilers (#380) * this pointer in type definitions is not interpreted as a constant. This rule is not enforced strictly by all compilers, but the Green Hills Software compiler will regard this as an error. * Merging branches for the DEFINE_SIZE_UNION macro Adding check for the existence of static_size field in the tested member. src/hb-open-type-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e2b878055bb1c0b84e1f7cfbf3d3f80bfc6811ea Author: Behdad Esfahbod Date: Thu Dec 22 14:40:19 2016 -0600 Disable OTL processing for Hebrew if GPOS doesn't have Hebrew subtable New approach to fix this: https://github.com/behdad/harfbuzz/commit/69f9fbc4200442a35484d3c790ae8f4979be5d60 Previous approach was reverted as it was too broad. See context: https://github.com/behdad/harfbuzz/issues/347#issuecomment-267838368 With U+05E9,U+05B8,U+05C1,U+05DC and Arial Unicode, we now (correctly) disable GDEF and GPOS, so we get results very close to Uniscribe, but slightly different since our fallback position logic is not exactly the same: Before: [gid1166=3+991|gid1142=0+737|gid5798=0+1434] After: [gid1166=3+991|gid1142=0@402,-26+0|gid5798=0+1434] Uniscribe: [gid1166=3+991|gid1142=0@348,0+0|gid5798=0+1434] src/hb-ot-shape-complex-arabic.cc | 1 + src/hb-ot-shape-complex-default.cc | 1 + src/hb-ot-shape-complex-hangul.cc | 1 + src/hb-ot-shape-complex-hebrew.cc | 13 +++++++++++++ src/hb-ot-shape-complex-indic.cc | 1 + src/hb-ot-shape-complex-myanmar.cc | 2 ++ src/hb-ot-shape-complex-private.hh | 8 ++++++++ src/hb-ot-shape-complex-thai.cc | 1 + src/hb-ot-shape-complex-tibetan.cc | 1 + src/hb-ot-shape-complex-use.cc | 1 + src/hb-ot-shape.cc | 29 ++++++++++++++++------------- 11 files changed, 46 insertions(+), 13 deletions(-) commit 1a0f4aa6dfee69236b422f7c8825eff940f45c19 Author: Behdad Esfahbod Date: Thu Dec 22 13:33:54 2016 -0600 Revert "Synthesize GDEF glyph class for any glyph that does not have one in GDEF" This reverts commit 69f9fbc4200442a35484d3c790ae8f4979be5d60. See https://github.com/behdad/harfbuzz/issues/347#issuecomment-268873401 Fixes https://github.com/behdad/harfbuzz/issues/347 src/hb-ot-layout-gsub-table.hh | 22 ++-------------------- src/hb-ot-shape.cc | 29 +++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 20 deletions(-) commit 4b4a1b9f235598b04ce9ae1f9670fc978ab7620d Author: Behdad Esfahbod Date: Wed Dec 21 23:10:43 2016 -0600 Fix assert fail with contextual matching As discovered by libFuzzer / Chromium fuzzing. Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=659496 CC https://github.com/behdad/harfbuzz/issues/139 src/hb-ot-layout-gsubgpos-private.hh | 6 +++++- .../sha1sum/217a934cfe15c548b572c203dceb2befdf026462.ttf | Bin 0 -> 1384 bytes test/shaping/tests/fuzzed.tests | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) commit df98ce5fc8cf1dafd58c329975f07aafbeee3263 Author: Behdad Esfahbod Date: Wed Dec 21 19:27:30 2016 -0600 Improve debug output with really deep nesting src/hb-private.hh | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) commit eab418c5e6fa34b90133862cc8ce11e617ce08bf Author: Behdad Esfahbod Date: Wed Dec 21 15:51:28 2016 -0600 Avoid infinite loop in CoverageFormat2 iteration with bad fonts Fixes https://github.com/behdad/harfbuzz/issues/363 src/hb-ot-layout-common-private.hh | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-) commit a0688e8e7b58c156f5809c272b5884bfe75f68ae Author: Behdad Esfahbod Date: Tue Dec 20 20:52:50 2016 -0600 Ouch, finish previous change test/fuzzing/Makefile.am | 3 ++- test/fuzzing/hb-fuzzer.cc | 30 ++++-------------------------- 2 files changed, 6 insertions(+), 27 deletions(-) commit de14c19d14be90367a1231de56dd347e3f54931c Author: Behdad Esfahbod Date: Tue Dec 20 20:50:38 2016 -0600 [fuzzer] Separate main() into a new file test/fuzzing/hb-fuzzer.hh | 4 ++++ test/fuzzing/main.cc | 21 +++++++++++++++++++++ 2 files changed, 25 insertions(+) commit 7ed71eb347c894c5b4b012bcca0816922c3052c2 Author: Behdad Esfahbod Date: Tue Dec 20 15:01:16 2016 -0600 Protect collect_glyphs() and closure() against malicious DDOS fonts Fixes https://github.com/behdad/harfbuzz/issues/363 src/hb-ot-layout-gsub-table.hh | 58 ++++++++++++++++++++++++++++++++++-------- 1 file changed, 48 insertions(+), 10 deletions(-) commit 1c98ff87c76536553e53c131e75aba33033ee3a0 Author: Mike Hommey Date: Fri Sep 30 18:15:37 2016 +0900 Support building with older glib versions It is desirable to be able to build against older versions of glib. fd7a245 changed the configure check to require glib > 2.38 for G_TEST_DIST. Before that, version 2.16 was required, but in fact, since aafe395, G_PASTE is being used, which was introduced in 2.19.1. And since 0ef179e2, hb-glib uses GBytes, which were introduced in 2.31.10. 2.19.1 is rather old, but 2.38 is rather new. For Firefox, building against 2.22 is still supported, although we could probably get away with bumping that to 2.28. Either way, GBytes is not available. Arguably, if you build against a glib that doesn't support GBytes, you're not going to use the hb_glib_blob_create function, so we hide the function when building against such a glib. As for G_TEST_DIST, when building against versions of glib that don't support it, we can fallback to the previous behavior, which, AIUI, was just making the test not work when building in a separate directory. configure.ac | 2 +- src/hb-glib.cc | 2 ++ src/hb-glib.h | 3 ++- test/api/test-ot-math.c | 4 ++++ 4 files changed, 9 insertions(+), 2 deletions(-) commit ad273881c597a95929ce3b84f63865f9d7dcdb7e Author: Volker H. Simonis Date: Wed Dec 14 18:56:17 2016 +0100 Minor fixes to pacify Coverity code scan Fixes https://github.com/behdad/harfbuzz/pull/377 src/hb-ot-font.cc | 6 +++++- src/hb-ot-layout-gpos-table.hh | 14 +++++++------- 2 files changed, 12 insertions(+), 8 deletions(-) commit 1e1825bf47aa29968f75a78305d4541ce2c9d40c Author: ebraminio Date: Sat Dec 17 10:30:40 2016 +0330 [dwrite] Provide an experimental API for justification (#279) src/hb-directwrite.cc | 48 ++++++++++++++++++++++++++++++++++++++++-------- src/hb-directwrite.h | 4 ++++ 2 files changed, 44 insertions(+), 8 deletions(-) commit 4cd0cd67914db1da10906e40335faea7dbec1d0a Author: elmarb Date: Wed Dec 7 11:50:27 2016 +0100 NMake ICU option builds with builtin ICU (#375) win32/build-rules-msvc.mak | 13 ------------- win32/config-msvc.mak | 37 ++++++++++++++++++++----------------- win32/create-lists-msvc.mak | 13 ------------- win32/detectenv-msvc.mak | 4 +++- win32/generate-msvc.mak | 2 +- win32/info-msvc.mak | 12 +++++------- win32/install.mak | 4 ---- 7 files changed, 29 insertions(+), 56 deletions(-) commit 75fa884f925c203a839b5874f30bf9ebf025b6e4 Author: Khaled Hosny Date: Mon Dec 5 23:20:47 2016 +0200 [win32] Fix wrong description of the ICU option (#372) win32/README.txt | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit 219cb29c5d230ecc6ee154b447fabd7b59fbe089 Author: Behdad Esfahbod Date: Wed Sep 28 17:16:06 2016 +0200 Fix build after rebasing opentype-gx branch on top of MATH table src/hb-ot-layout-common-private.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 0aedfd59be54972e61a952753ffc0d12631771fe Author: Behdad Esfahbod Date: Wed Sep 28 17:05:43 2016 +0200 [GX] Apply 'rvrn' feature before any other feature src/hb-ot-shape.cc | 3 +++ 1 file changed, 3 insertions(+) commit 42c81425316190f6424ecb9b19d5a886aa1e4136 Author: Behdad Esfahbod Date: Tue Sep 13 23:49:46 2016 +0200 [GX] Fix build with older FreeType configure.ac | 4 ++++ src/hb-ft.cc | 12 ++++++++---- 2 files changed, 12 insertions(+), 4 deletions(-) commit 72873cf522a6e3bec1b6508d8d20d3d2ce233cd6 Author: Sascha Brawer Date: Tue Sep 13 18:40:07 2016 +0200 Call hb_font_set_var_coords_normalized() from FT_Face coords src/hb-ft.cc | 14 ++++++++++++++ 1 file changed, 14 insertions(+) commit 4ebbeb7c50e5c1e934d230ceacf792602c6eb9b9 Author: Behdad Esfahbod Date: Sat Sep 10 04:52:34 2016 -0700 [GX] Make FeatureVariations actually work Yay!!!! src/hb-ot-layout-common-private.hh | 19 +++++++------------ src/hb-ot-layout-gsubgpos-private.hh | 3 ++- 2 files changed, 9 insertions(+), 13 deletions(-) commit 72ada4f0c6998fc2a282efc2a573733e37db8be5 Author: Behdad Esfahbod Date: Sat Sep 10 03:57:24 2016 -0700 [GX] Hook up feature variations Shape-plan caching is not implemented. src/hb-coretext.cc | 8 +++- src/hb-directwrite.cc | 6 ++- src/hb-fallback-shape.cc | 4 +- src/hb-font.cc | 6 +-- src/hb-graphite2.cc | 4 +- src/hb-ot-map-private.hh | 17 +++++--- src/hb-ot-map.cc | 25 ++++++++--- src/hb-ot-shape-private.hh | 6 ++- src/hb-ot-shape.cc | 9 ++-- src/hb-shape-plan-private.hh | 9 +++- src/hb-shape-plan.cc | 102 +++++++++++++++++++++++++++++++++++++++---- src/hb-shape-plan.h | 19 ++++++++ src/hb-shape.cc | 5 ++- src/hb-uniscribe.cc | 4 +- 14 files changed, 183 insertions(+), 41 deletions(-) commit ec87ba9ba32a374d49dd3e40137f75f4f4232aee Author: Behdad Esfahbod Date: Sat Sep 10 03:53:11 2016 -0700 [GX] Add hb_ot_layout_feature_with_variations_get_lookups() src/hb-ot-layout-common-private.hh | 30 +++++++++++++++++++++++++++++- src/hb-ot-layout-gsubgpos-private.hh | 12 ++++++++++++ src/hb-ot-layout.cc | 28 ++++++++++++++++++++++++---- src/hb-ot-layout.h | 9 +++++++++ 4 files changed, 74 insertions(+), 5 deletions(-) commit 30c42b644eb33551aa0986287182a46f2d8c32ed Author: Behdad Esfahbod Date: Sat Sep 10 03:32:39 2016 -0700 [GX] Add hb_ot_layout_table_find_feature_variations() src/hb-ot-layout-common-private.hh | 18 +++++++++++------- src/hb-ot-layout-gsubgpos-private.hh | 6 +++--- src/hb-ot-layout.cc | 15 +++++++++++++++ src/hb-ot-layout.h | 10 ++++++++++ 4 files changed, 39 insertions(+), 10 deletions(-) commit 7ceadbe981aa50481163bb365f0fe3f994266165 Author: Behdad Esfahbod Date: Sat Sep 10 02:44:20 2016 -0700 Shuffle code around src/hb-ot-map.cc | 81 ++++++++++++++++++++++++++++---------------------------- 1 file changed, 41 insertions(+), 40 deletions(-) commit bde5e3959c0ffdb92db87668035b01aaee9b2352 Author: Behdad Esfahbod Date: Sat Sep 10 02:43:20 2016 -0700 Move add_lookups from map to map-builder In prep for more changes. src/hb-ot-map-private.hh | 15 ++++++++------- src/hb-ot-map.cc | 29 +++++++++++++++-------------- 2 files changed, 23 insertions(+), 21 deletions(-) commit 26648cebcd14bd26142ccfe5ac8c0be08a213671 Author: Behdad Esfahbod Date: Sat Sep 10 02:11:05 2016 -0700 [GX] Remove (partial) support for anisotropic variations It doesn't always work, not part of FreeType, and we were not going to expose it in the API anyway. Can always be added later. src/hb-font-private.hh | 3 +-- src/hb-font.cc | 17 ++++++----------- src/hb-ot-layout-common-private.hh | 9 ++++----- 3 files changed, 11 insertions(+), 18 deletions(-) commit c22176d4bac720b4c9121b3d6629595831f19fb0 Author: Behdad Esfahbod Date: Sat Sep 10 01:58:27 2016 -0700 [GX] Handle setting var coords to NULL src/hb-font.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 59055b5494f802013ca3613a15e565ae1ca0c589 Author: Behdad Esfahbod Date: Sat Sep 10 01:24:28 2016 -0700 [GX] Implement Feature Variations Not hooked up to shaper yet. src/hb-ot-layout-common-private.hh | 168 ++++++++++++++++++++++++++++++++++- src/hb-ot-layout-gdef-table.hh | 1 - src/hb-ot-layout-gpos-table.hh | 2 - src/hb-ot-layout-gsub-table.hh | 2 - src/hb-ot-layout-gsubgpos-private.hh | 15 +++- 5 files changed, 180 insertions(+), 8 deletions(-) commit 85ec4944346a1ac111217698e1424669a9732280 Author: Behdad Esfahbod Date: Sat Sep 10 00:25:16 2016 -0700 [GX] Fix another x/y thinko Thanks Werner! src/hb-ot-layout-common-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cf3de4d8f79fc6e8413957cdef034e975343ce30 Author: Behdad Esfahbod Date: Sat Sep 10 00:22:24 2016 -0700 [GX] Rename VarStore to VariationStore src/hb-ot-layout-common-private.hh | 12 ++++++------ src/hb-ot-layout-gdef-table.hh | 14 +++++++------- src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-layout-gsubgpos-private.hh | 2 +- 4 files changed, 15 insertions(+), 15 deletions(-) commit 1f6ed356e0a849b61ce98b6a2f38d04d98c2191e Author: Behdad Esfahbod Date: Sat Sep 10 00:01:10 2016 -0700 [GX] Fix build with some compilers Eg. https://ci.appveyor.com/project/behdad/harfbuzz/build/1.0.48/job/o9mnd33kcdeeg30r hb-open-type-private.hh:103:29: error: static data member 'OT::Device::::::static_size' in unnamed class [-fpermissive] src/hb-ot-layout-common-private.hh | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) commit 250bcd6fb691d6f15fa9ca71b475ce419d0b5e37 Author: Behdad Esfahbod Date: Fri Sep 9 23:12:14 2016 -0700 [GX] Skip tail zero entries when setting variation coordinates src/hb-font.cc | 4 ++++ 1 file changed, 4 insertions(+) commit 1124d2ece55e323ed934357b30e68df75829cfaa Author: Behdad Esfahbod Date: Fri Sep 9 22:48:27 2016 -0700 [GX] Fix thinko src/hb-ot-layout-common-private.hh | 1 - src/hb-ot-layout-gpos-table.hh | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) commit ad69e8f07c6e3e47fe7e7103c2ff7c053d272b1a Author: Behdad Esfahbod Date: Fri Sep 9 22:23:34 2016 -0700 [GX] Add new API hb_font_set_var_coords_normalized() Will probably change. src/hb-font.cc | 23 +++++++++++++++++++++++ src/hb-font.h | 5 +++++ 2 files changed, 28 insertions(+) commit 151d93de8a595924a8dcb00fcba648b4b3df0bf5 Author: Behdad Esfahbod Date: Fri Sep 9 17:03:11 2016 -0700 [GX] Hook up GPOS to Variation Store stored in GDEF Untested. src/hb-ot-layout-common-private.hh | 22 ++++++++++---------- src/hb-ot-layout-gdef-table.hh | 27 +++++++++++++++--------- src/hb-ot-layout-gpos-table.hh | 40 ++++++++++++++++-------------------- src/hb-ot-layout-gsubgpos-private.hh | 2 ++ 4 files changed, 48 insertions(+), 43 deletions(-) commit dcfd309533ac83e44369dea7204d668623b08207 Author: Behdad Esfahbod Date: Fri Sep 9 16:51:07 2016 -0700 [GX] Change GDEF API to return varStore src/hb-ot-layout-gdef-table.hh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 49cb87850c2692be45b201168c8ce10b263168cc Author: Behdad Esfahbod Date: Fri Sep 9 16:27:03 2016 -0700 [GX] Pass apply-context down to get_anchor() Needed to access GDEF for varStore. src/hb-ot-layout-gpos-table.hh | 57 ++++++++++++++++++++++-------------------- 1 file changed, 30 insertions(+), 27 deletions(-) commit f0c3fd8c9ab402be923fe0845fb51d99841829b6 Author: Behdad Esfahbod Date: Fri Sep 9 16:22:45 2016 -0700 [GX] Add varStore member to GDEF Still not hooked up from GPOS. src/hb-ot-layout-gdef-table.hh | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) commit 5c971f8dbc823dbad4a2869cf9e835095ab6ddb2 Author: Behdad Esfahbod Date: Fri Sep 9 16:05:17 2016 -0700 Minor change to GDEF, in prep for new version src/hb-ot-layout-gdef-table.hh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit dc9f2297998b4cbc4f9e4c2591fc2bb5f92986d1 Author: Behdad Esfahbod Date: Fri Sep 9 15:40:15 2016 -0700 [GX] Port variation stuff to Variation Store design Not hooked up to GDEF yet. src/hb-ot-layout-common-private.hh | 294 +++++++++++++++++++++++-------------- src/hb-ot-layout-gpos-table.hh | 2 +- 2 files changed, 184 insertions(+), 112 deletions(-) commit a7edeb6f02cbc4418285fdfc58ef8a8740a380e9 Author: Behdad Esfahbod Date: Fri Sep 9 15:39:52 2016 -0700 Make OffsetArrayOf take OffsetType template argument src/hb-open-type-private.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 8dddc231cf9d934eb93a39f2657717cbdad43a64 Author: Behdad Esfahbod Date: Fri Sep 9 13:17:33 2016 -0700 [GX] Revert "[GX] Add VariationAlternates, to allow conditional lookups in GSUB/GPOS" This reverts commit 2859f1c7174d6f7ae5dcf0db5411bc0182b21594. We are going in a different direction. src/hb-open-type-private.hh | 1 - src/hb-ot-layout-common-private.hh | 99 +------------------------------------- 2 files changed, 2 insertions(+), 98 deletions(-) commit bb4d2e6ed562c248fff15313a013d49e38a18789 Author: Behdad Esfahbod Date: Fri Sep 9 13:08:52 2016 -0700 [GX] Free GX coordinates src/hb-font.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit baa329c6a12c7ffd56feed32351d9405b7d1651b Author: Behdad Esfahbod Date: Fri Mar 18 15:52:24 2016 -0700 [GX] Add compact VariationDevice implementation Add compact format that uses signed bytes instead of shorts. src/hb-open-type-private.hh | 1 + src/hb-ot-layout-common-private.hh | 35 ++++++++++++++++++++++++----------- 2 files changed, 25 insertions(+), 11 deletions(-) commit 71b06fd392680b6fcfece60d8a83ba6c56eada09 Author: Behdad Esfahbod Date: Sat Mar 12 23:49:09 2016 -0800 [GX] Add VariationAlternates, to allow conditional lookups in GSUB/GPOS Not hooked up to runtime yet. src/hb-open-type-private.hh | 1 + src/hb-ot-layout-common-private.hh | 99 +++++++++++++++++++++++++++++++++++++- 2 files changed, 98 insertions(+), 2 deletions(-) commit 976eeb8e025e2b7601a91e661d6e9a88bf8afbd2 Author: Behdad Esfahbod Date: Sat Mar 12 23:28:12 2016 -0800 [GX] Minor src/hb-ot-layout-common-private.hh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit ed8a9067ca0fe51ac4b80dab55db596763df72bb Author: Behdad Esfahbod Date: Wed Mar 2 12:54:35 2016 -0800 [GX] Minor src/hb-ot-layout-common-private.hh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 15c5ee67473a17859a919104c5e6fed1f813aa65 Author: Behdad Esfahbod Date: Wed Mar 2 12:41:49 2016 +0900 [GX] Minor rename src/hb-ot-layout-common-private.hh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 4c535a822f16b23a4e41e14d1b17fe179b83eabc Author: Behdad Esfahbod Date: Wed Mar 2 12:21:36 2016 +0900 [GX] Hookup VariationDevice to Device table implementation src/hb-ot-layout-common-private.hh | 65 +++++++++++++++++++++++++++++++++++++- 1 file changed, 64 insertions(+), 1 deletion(-) commit a0c2366075fcb894212b9bf137e4dd34bb65537c Author: Behdad Esfahbod Date: Tue Mar 1 19:42:24 2016 +0900 [GX] Break out early if factor is zero Also disable sanity-checking of variation records. src/hb-ot-layout-common-private.hh | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) commit ca286703164caf1eda665f6f27ef83bf04e2f8ba Author: Behdad Esfahbod Date: Tue Mar 1 19:29:36 2016 +0900 [GX] Towards anisotropic interpolation Also hookup to ValueRecord and Anchors. src/hb-font-private.hh | 5 +++-- src/hb-font.cc | 9 +++++++-- src/hb-ot-layout-common-private.hh | 4 ++-- src/hb-ot-layout-gpos-table.hh | 20 ++++++++++---------- 4 files changed, 22 insertions(+), 16 deletions(-) commit 6d9d3c55bbd4209ba339ccd2b925bb4a6c97f622 Author: Behdad Esfahbod Date: Tue Mar 1 19:12:08 2016 +0900 [GX] Add data types for encoding numerical variations src/hb-font-private.hh | 10 ++++ src/hb-font.cc | 3 + src/hb-ot-layout-common-private.hh | 113 +++++++++++++++++++++++++++++++++++++ 3 files changed, 126 insertions(+) commit b843c6d8b66c2833cd35407ee494546465e6d775 Author: Behdad Esfahbod Date: Mon Dec 5 13:42:28 2016 -0800 1.3.4 NEWS | 8 ++++++++ configure.ac | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) commit 8c842e4a44908cce0f416481c73dc0866a0a9c95 Author: Behdad Esfahbod Date: Sun Dec 4 20:28:38 2016 -0800 [hb-fuzzer] Get glyph extents for output glyphs To exercise glyph-extents codepaths (glyf / CBLC+CBDT). test/fuzzing/hb-fuzzer.cc | 13 +++++++++++++ 1 file changed, 13 insertions(+) commit 9f6144cdb9dd2bc8cd147306e678d76ae82663d8 Author: Behdad Esfahbod Date: Sun Dec 4 19:55:17 2016 -0800 [CBDT] Add test for fetching glyph extents test/shaping/Makefile.am | 1 + .../sha1sum/ee39587d13b2afa5499cc79e45780aa79293bbd4.ttf | Bin 0 -> 3724 bytes test/shaping/tests/color-fonts.tests | 1 + 3 files changed, 2 insertions(+) commit e4bfccfb2a0f425ff69b0a50ca8a4731c4001069 Author: Behdad Esfahbod Date: Sun Dec 4 19:43:33 2016 -0800 [CBDT] Minor src/hb-ot-cbdt-table.hh | 21 ++++++++++++++------- src/hb-ot-font.cc | 38 ++++++++++++++++++++------------------ 2 files changed, 34 insertions(+), 25 deletions(-) commit b7068af423dba30fd831041aabf4b805d26fe349 Author: Behdad Esfahbod Date: Sun Dec 4 19:36:30 2016 -0800 [CBDT] Fix thinko! src/hb-ot-cbdt-table.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a141d1da9bb0f91521a9a7749f9533c75cfe6a2f Author: Behdad Esfahbod Date: Sun Dec 4 19:26:54 2016 -0800 [CBDT] Implement IndexSubtableFormat3 src/hb-ot-cbdt-table.hh | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) commit 9eda74c92c9024ffb8ec6e9344c99d51dd763f0c Author: Behdad Esfahbod Date: Sun Dec 4 19:12:52 2016 -0800 [cbdt] Move some more code around src/hb-ot-cbdt-table.hh | 61 ++++++++++++++++++++++++++++++++++--------------- src/hb-ot-font.cc | 18 ++++++--------- 2 files changed, 49 insertions(+), 30 deletions(-) commit 654f9ab0d8d5ee032b5da763e34e7b1f454416b9 Author: Behdad Esfahbod Date: Sun Dec 4 18:56:24 2016 -0800 [cbdt] Fix sign bug Was introduced in d495fc5e38038f4cfb20425b1109324fa70bf2f9 src/hb-ot-cbdt-table.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c27d6fcf8db6f02e075dd1868ae67d878fff39d4 Author: Behdad Esfahbod Date: Fri Dec 2 22:43:05 2016 -0800 [cbdt] Last of sanitization fixes Should be all good now.. src/hb-ot-font.cc | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) commit d495fc5e38038f4cfb20425b1109324fa70bf2f9 Author: Behdad Esfahbod Date: Fri Dec 2 21:36:42 2016 -0800 [cbdt] Clean up some more Almost there.. src/hb-ot-cbdt-table.hh | 134 +++++++++++++++++++++++++++++++++++++++++++----- src/hb-ot-font.cc | 38 ++++---------- 2 files changed, 131 insertions(+), 41 deletions(-) commit ce09e90e1502d5f944bafd64e51c29e365a963ae Author: Behdad Esfahbod Date: Fri Dec 2 20:12:57 2016 -0800 [cbdt] More sanitize work src/hb-ot-cbdt-table.hh | 65 +++++++++++++++++++++++++++++-------------------- src/hb-ot-font.cc | 46 ++++++++++++++++++---------------- 2 files changed, 63 insertions(+), 48 deletions(-) commit 70eb2ff682344688635cebb716fee0b73557c925 Author: Behdad Esfahbod Date: Fri Dec 2 19:51:23 2016 -0800 Check for offset overflows during sanitize src/hb-open-type-private.hh | 2 ++ 1 file changed, 2 insertions(+) commit 4b58c9e326acde09d389c699014e4e7f6259f50a Author: Behdad Esfahbod Date: Fri Dec 2 19:25:54 2016 -0800 [cbdt] Start fixing sanitization (or lack thereof) src/hb-ot-cbdt-table.hh | 77 ++++++++++++++++++++++++++++++++++++------------- src/hb-ot-font.cc | 22 +++++++------- 2 files changed, 68 insertions(+), 31 deletions(-) commit b92ba7bafcd9545a401fb871eb342e6284032c47 Author: Behdad Esfahbod Date: Fri Dec 2 15:21:43 2016 -0800 [CBDT] Use CHAR instead of int8_t src/hb-open-type-private.hh | 1 + src/hb-ot-cbdt-table.hh | 28 ++++++++++++++-------------- 2 files changed, 15 insertions(+), 14 deletions(-) commit efca7bf97f9967af4fa399a6665b723af643cecd Author: Behdad Esfahbod Date: Fri Dec 2 15:11:37 2016 -0800 Rename 'ebdt' to 'cbdt' since we only support the PNG format src/Makefile.sources | 2 +- src/{hb-ot-ebdt-table.hh => hb-ot-cbdt-table.hh} | 6 +++--- src/hb-ot-font.cc | 12 ++++++------ 3 files changed, 10 insertions(+), 10 deletions(-) commit 831852594b777f250efedb76d19bee1cfc8eeaa4 Author: Seigo Nonaka Date: Fri Dec 2 15:03:50 2016 -0800 Introduce get_extent support for color bitmap font. (#351) hb_font_get_glyph_extents now works for color bitmap fonts. Currently only font having index format 1 and image format 17 is supported. src/Makefile.sources | 1 + src/hb-ot-ebdt-table.hh | 193 ++++++++++++++++++++++++++++++++++++++++++++++++ src/hb-ot-font.cc | 96 ++++++++++++++++++++++++ 3 files changed, 290 insertions(+) commit 261837e7202ec584f653f379851e1c6457396b07 Author: Ebrahim Byagowi Date: Fri Oct 28 21:49:11 2016 +0330 Fix "nmake install" when ADDITIONAL_LIB_DIR is provided and test it on CI (#356) appveyor.yml | 1 + win32/detectenv-msvc.mak | 4 ++-- win32/generate-msvc.mak | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) commit d163cd956246449e3e48b54ce6eb5cdb14e3a0a6 Author: Behdad Esfahbod Date: Wed Oct 26 18:27:48 2016 +0200 [tests] Add tests for vertical origin with ft and ot font-funcs .../sha1sum/f9b1dd4dcb515e757789a22cb4241107746fd3d0.ttf | Bin 0 -> 1004 bytes test/shaping/tests/vertical.tests | 2 ++ 2 files changed, 2 insertions(+) commit 2b117720c03869c7714304fd7fbfb2b01199bb3a Author: Behdad Esfahbod Date: Wed Oct 26 18:12:50 2016 +0200 Use horizontal ascent as fallback vertical origin src/hb-font-private.hh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) commit a7b32f2057098012b3ab43121397766ae45b3559 Author: Behdad Esfahbod Date: Wed Oct 26 18:08:41 2016 +0200 Move code around src/hb-font-private.hh | 38 +++++++++++++++++++++++--------------- 1 file changed, 23 insertions(+), 15 deletions(-) commit 63635c763dd9393df236f49d491510cca18a1ccc Author: Behdad Esfahbod Date: Wed Oct 26 17:54:04 2016 +0200 [hb-ot-font] Use ascent+descent as fallback vertical advance src/hb-ot-font.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 9ee23c49a7a7b2479ae0d36a64720e92eb8a36e7 Author: Behdad Esfahbod Date: Wed Oct 26 17:44:16 2016 +0200 Fix vertical glyph origin with hb-ot-font src/hb-font-private.hh | 51 ++++++++++++++++++++++++++++---------------------- 1 file changed, 29 insertions(+), 22 deletions(-) commit b3b0816d5fc00298621f738cf400de60f8a42c5d Author: Behdad Esfahbod Date: Wed Oct 26 17:19:07 2016 +0200 Fix vertical font metrics Ouch! src/hb-font-private.hh | 4 ++-- src/hb-ot-font.cc | 8 ++++++-- 2 files changed, 8 insertions(+), 4 deletions(-) commit 966ac7ecd3d0128a3adacdd26aacef2bd8afa4d4 Author: Behdad Esfahbod Date: Wed Oct 26 16:17:15 2016 +0200 1.3.3 NEWS | 24 ++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 25 insertions(+), 1 deletion(-) commit 118164293cc7eb18ba03896f602aff816400134b Author: Behdad Esfahbod Date: Wed Oct 26 16:04:30 2016 +0200 Fix "make distcheck" configure.ac | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit b6c765871b752c9436ec993e47b48f9d4fecaed5 Author: Behdad Esfahbod Date: Wed Oct 26 10:33:33 2016 +0200 [ci] Fix appveyor.yml syntax error appveyor.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0e79ebb3ca9b7b6d238a0007e5ca022845ee9afc Author: Behdad Esfahbod Date: Sun Oct 23 14:39:43 2016 +0200 [gobject] Update for new MATH structs src/hb-gobject-structs.cc | 3 +++ 1 file changed, 3 insertions(+) commit 8c854dc023b1f9e081a3bbd16416b88a4671c267 Merge: bb9805f5 c3fa5d0e Author: Khaled Hosny Date: Tue Oct 25 00:31:36 2016 +0300 Merge pull request #352 from fred-wang/makefile-am Remove inexistent file ttx file from test/api/Makefile.am commit c3fa5d0e03b57be131c66ea8720806c946d0e10f Author: Frédéric Wang Date: Mon Oct 24 21:42:04 2016 +0200 Remove inexistent file ttx file from test/api/Makefile.am test/api/Makefile.am | 1 - 1 file changed, 1 deletion(-) commit bb9805f5419f18c7f5cab32d660fd4109c30f7cc Merge: 702d9f52 755a0c20 Author: Ebrahim Byagowi Date: Sat Oct 22 12:23:05 2016 +0330 Merge pull request #349 from ebraminio/mergebackvcpkgpatches [ci] Enable hb-freetype on Windows build tests commit 755a0c20798e3c3e6bb933a28e38f9667fccdadc Author: Ebrahim Byagowi Date: Fri Oct 21 11:48:58 2016 +0330 [ci] Enable freetype on msvc using vcpkg appveyor.yml | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) commit 4631d84c2bb51395efe3156f9c9f1a6b0e277947 Author: Ebrahim Byagowi Date: Tue Oct 18 14:30:00 2016 +0330 Merge back @vlj's local patches of vcpkg win32/config-msvc.mak | 7 +++++++ win32/detectenv-msvc.mak | 3 +++ 2 files changed, 10 insertions(+) commit 702d9f522d1ac4797700f0ea056f69169b8d1a78 Merge: 331c46c7 d8e2eb9e Author: Ebrahim Byagowi Date: Fri Oct 14 13:54:55 2016 +0330 Merge pull request #340 from ebraminio/nouniscribe Make Uniscribe optional on nmake win32 builds commit d8e2eb9ee0f47af7e90056d8db5949d10a88786a Author: Ebrahim Byagowi Date: Sun Oct 9 09:06:05 2016 +0330 Make Uniscribe optional on nmake win32 builds Most of harfbuzz clients don't need Uniscribe and DirectWrite support at all as harfbuzz is a replacement for Uniscribe so Chromium and Firefox are using harfbuzz without them on Windows. This removal also helps win32 nmake clients to have reduced binary size and libs count. appveyor.yml | 2 +- win32/README.txt | 13 +++++++------ win32/config-msvc.mak | 18 +++++++++++++----- win32/config.h.win32.in | 2 +- win32/info-msvc.mak | 11 +++++++++-- 5 files changed, 31 insertions(+), 15 deletions(-) commit 331c46c79b4d18cb4948be12c78ebb71a143e7ac Author: Behdad Esfahbod Date: Tue Oct 11 13:45:22 2016 -0700 Fix configure on iOS Fixes https://github.com/behdad/harfbuzz/issues/342 configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit f6e194e77a2c34cd118b47c0d73a22afde85dfda Merge: 7201fdd0 bef240b3 Author: Ebrahim Byagowi Date: Tue Oct 11 17:23:41 2016 +0330 Merge pull request #344 from ebraminio/fixmacci [ci] Whitelist more symbols and unbreak mac CI commit bef240b36ee9086b0d92e351e4c5118c0bbb5df6 Author: Ebrahim Byagowi Date: Mon Oct 10 17:27:52 2016 +0330 [ci] Whitelist more symbols and unbreak mac CI Thanks to @khaledhosny, actually this is his work :) src/check-symbols.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 7201fdd0a8e26d49b13e289b53de375d5b1c9fcb Author: Behdad Esfahbod Date: Tue Oct 4 14:53:17 2016 -0700 LFS (large file system?) support in hb-*shap*, hb-view Fixes https://github.com/behdad/harfbuzz/issues/336 configure.ac | 3 +++ 1 file changed, 3 insertions(+) commit 34fc4a2cfa61089b7ec2d9510d99cdc4c13bceb4 Author: Behdad Esfahbod Date: Wed Sep 28 19:17:27 2016 +0200 Fix dist test/api/Makefile.am | 10 ++++++++++ 1 file changed, 10 insertions(+) commit d1c62370a0c2bdb365a1468dc8d782b9a7245946 Author: Behdad Esfahbod Date: Wed Sep 28 19:11:22 2016 +0200 Aim math API for 1.3.3 instead of 1.4.0 docs/harfbuzz-docs.xml | 6 +++--- docs/harfbuzz-sections.txt | 12 ++++++------ src/hb-ot-layout.cc | 18 +++++++++--------- src/hb-ot-math.h | 10 +++++----- 4 files changed, 23 insertions(+), 23 deletions(-) commit 7adbc5dd62ca03a65d1886e0f32e7026964dc5e5 Author: Khaled Hosny Date: Fri Sep 30 04:01:24 2016 -0700 Fix building math docs (#335) src/hb-ot-layout.cc | 9 --------- 1 file changed, 9 deletions(-) commit fd7a245d3525905ffbce57472b52900fcb0e330b Author: Behdad Esfahbod Date: Tue Sep 27 17:56:35 2016 +0200 Require glib >= 2.38.0 for G_TEST_DIST configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6d3e6abf0c6ad55dabae96c76b4da9ab14bf16ef Merge: f73a87d9 c3e21a66 Author: Behdad Esfahbod Date: Tue Sep 27 17:15:59 2016 +0200 Merge branch 'math' Supercedes https://github.com/behdad/harfbuzz/pull/326 Fixes https://github.com/behdad/harfbuzz/pull/331 commit c3e21a6620c35500afa350d11620f69802920df3 Author: Behdad Esfahbod Date: Tue Sep 27 16:51:38 2016 +0200 [MATH] Fix more docs src/hb-ot-layout.cc | 18 +++++++++--------- src/hb-ot-math.h | 25 +++++++++++++++++++++++++ 2 files changed, 34 insertions(+), 9 deletions(-) commit 46cc4a3a2a529c80677babe38ca1542f9c773ac0 Author: Behdad Esfahbod Date: Tue Sep 27 16:44:22 2016 +0200 [MATH] Rename hb_math_*_t types to hb_ot_math_*_t With this, I believe MATH table API is not ready to be merged. docs/harfbuzz-sections.txt | 6 +++--- src/hb-ot-layout-math-table.hh | 12 ++++++------ src/hb-ot-layout.cc | 8 ++++---- src/hb-ot-math.h | 16 ++++++++-------- test/api/test-ot-math.c | 4 ++-- 5 files changed, 23 insertions(+), 23 deletions(-) commit db5ebcf10f8595d1f4a9df27befd6cb5e76ca94d Author: Behdad Esfahbod Date: Tue Sep 27 16:42:25 2016 +0200 Update docs docs/harfbuzz-docs.xml | 9 +++++++++ docs/harfbuzz-sections.txt | 30 ++++++++++++++++++++++++++++-- 2 files changed, 37 insertions(+), 2 deletions(-) commit 0762b35474c47171e5661904e93851eb73a44e5c Author: Frédéric Wang Date: Tue Sep 27 15:28:35 2016 +0200 Document API for MathVariants (#330) src/hb-ot-layout.cc | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) commit 8d622f1114d6a0eca1786b94c7fc1a0bcd87f74b Author: Frédéric Wang Date: Tue Sep 27 13:53:34 2016 +0200 Add tests for get_mathvariant (#329) test/api/test-ot-math.c | 160 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 160 insertions(+) commit f73a87d9a8c76a181794b74b527ea268048f78e3 Author: Behdad Esfahbod Date: Tue Sep 27 13:50:54 2016 +0200 1.3.2 NEWS | 7 +++++++ configure.ac | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) commit 485e4873fb7cacfa9d853272c2275bbc5826023e Author: Frédéric Wang Date: Tue Sep 27 13:18:00 2016 +0200 Add tests for hb_ot_math_get_glyph_variants (#328) test/api/test-ot-math.c | 126 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 126 insertions(+) commit f16bf6c2dacf5b9c82b2d1ffacc092cc396189a7 Author: Phil Krylov Date: Tue Sep 27 12:38:49 2016 +0200 Allow building with graphite2 without pkg-config (#318) configure.ac | 10 ++++++++++ 1 file changed, 10 insertions(+) commit a5629a2ed9c2e69f2b4ebb74d85fbe0b5ba2be67 Author: Behdad Esfahbod Date: Tue Sep 27 11:30:44 2016 +0200 [MATH] Simplify test test/api/test-ot-math.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit edcfa789bf92c18f5badad31c0ad04a6a77d7226 Author: Frédéric Wang Date: Tue Sep 27 11:02:08 2016 +0200 test-ot-math: Use different scales for vertical and horizontal directions and add test for hb_ot_math_get_min_connector_overlap. (#327) test/api/test-ot-math.c | 81 ++++++++++++++++++++++++++++++------------------- 1 file changed, 49 insertions(+), 32 deletions(-) commit bc19f7fe20e89823dba07a46c3d48c7406b781b6 Author: Behdad Esfahbod Date: Tue Sep 27 10:58:08 2016 +0200 [MATH] Add HB_OT_MATH_SCRIPT src/hb-ot-math.h | 3 +++ 1 file changed, 3 insertions(+) commit cdc9eef7da934ae71578694f29665e439686c3bd Author: Behdad Esfahbod Date: Mon Sep 26 22:18:41 2016 +0200 [MATH] Enable tests for glyph-assembly italics-correction test/api/test-ot-math.c | 49 ++++++++++++++++++++++++++++++------------------- 1 file changed, 30 insertions(+), 19 deletions(-) commit 86106c7528d9bff8de6bc3e1487be780c31ea4fd Author: Behdad Esfahbod Date: Mon Sep 26 22:12:48 2016 +0200 [MATH] Rename all API to hb_ot_math_* src/hb-ot-layout-private.hh | 10 -- src/hb-ot-layout.cc | 69 ++++---- src/hb-ot-math.h | 56 +++--- test/api/Makefile.am | 6 +- test/api/test-ot-layout-math.c | 382 ----------------------------------------- test/api/test-ot-math.c | 381 ++++++++++++++++++++++++++++++++++++++++ 6 files changed, 447 insertions(+), 457 deletions(-) commit 1ba767cd4e3606beb9dc59806b83b1e61f5958d4 Author: Behdad Esfahbod Date: Mon Sep 26 21:57:14 2016 +0200 [MATH] Move API from hb-ot-layout.h to hb-ot-math.h src/hb-ot-layout.h | 52 -------------------------------------------------- src/hb-ot-math.h | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/hb-ot.h | 1 + 3 files changed, 57 insertions(+), 52 deletions(-) commit 97b72da6006d8d6355ee90d514f627e6604a4936 Author: Behdad Esfahbod Date: Mon Sep 26 21:53:25 2016 +0200 Whitespace src/hb-ot-layout-math-table.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 559eb564472575ae4d87a241314b8a3ca24418c4 Author: Behdad Esfahbod Date: Mon Sep 26 21:46:05 2016 +0200 [MATH] Wire up get_glyph_assembly() src/hb-ot-layout-math-table.hh | 64 ++++++++++++++++++++++++++++++++++++++---- src/hb-ot-layout.cc | 26 +++++++++-------- src/hb-ot-layout.h | 14 ++++----- 3 files changed, 81 insertions(+), 23 deletions(-) commit 353f455af7ccbc1af8338dcb0c8ab87aef866c79 Author: Behdad Esfahbod Date: Mon Sep 26 21:22:48 2016 +0200 [MATH] Wire up get_glyph_variants() src/hb-font-private.hh | 11 ++- src/hb-ot-layout-math-table.hh | 178 +++++++++++++++++++---------------------- src/hb-ot-layout.cc | 7 +- src/hb-ot-layout.h | 2 +- 4 files changed, 95 insertions(+), 103 deletions(-) commit 7fe0e28c22331a353d396f8bc1e3a60f1580a96d Author: Behdad Esfahbod Date: Mon Sep 26 17:51:47 2016 +0100 [MATH] Start fleshing out glyph variant API src/hb-font-private.hh | 4 +++ src/hb-ot-layout-math-table.hh | 10 ++---- src/hb-ot-layout.cc | 73 +++++++++++++++--------------------------- src/hb-ot-layout.h | 20 ++++++++++++ src/hb-ot-math.h | 18 +++++++++++ 5 files changed, 71 insertions(+), 54 deletions(-) commit 1f3327f21045df8a050a21a949b44b9ce186ceaa Author: Behdad Esfahbod Date: Mon Sep 26 16:10:08 2016 +0100 [MATH] Clean up math variants src/hb-ot-layout-math-table.hh | 35 +++++++++-------------------------- 1 file changed, 9 insertions(+), 26 deletions(-) commit 51da7a1cd672aada84bdbb3a2a8dd77ab1134249 Author: Frédéric Wang Date: Thu Aug 25 11:17:50 2016 +0200 MATH table: Add API to access math variants. src/hb-ot-layout-math-table.hh | 253 +++++++++++++++++++++++++++++++- src/hb-ot-layout-private.hh | 10 ++ src/hb-ot-layout.cc | 54 +++++++ test/api/fonts/MathTestFontPartial4.otf | Bin 0 -> 14360 bytes test/api/test-ot-layout-math.c | 51 +++++++ 5 files changed, 364 insertions(+), 4 deletions(-) commit 722e620f20fa2225cf874f4aeb115a064142fcf1 Author: Frédéric Wang Date: Mon Sep 26 11:51:36 2016 +0200 Use G_TEST_DIST to build the path of math test fonts test/api/Makefile.am | 2 ++ test/api/test-ot-layout-math.c | 8 ++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) commit 8d58e3433e242bd9dd18aa08f55ab0a406583fb0 Author: Behdad Esfahbod Date: Mon Sep 26 13:39:58 2016 +0100 [MATH] Fix get_kerning() with negative y-scale src/hb-ot-layout-math-table.hh | 36 +++++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 15 deletions(-) commit 94f5df5626b223ad92d0c167f560c1f2e2f19042 Author: Behdad Esfahbod Date: Mon Sep 26 13:31:47 2016 +0100 [MATH] Clean up get_kerning() src/hb-ot-layout-math-table.hh | 29 +++++++++++++++++------------ src/hb-ot-layout.cc | 5 +---- 2 files changed, 18 insertions(+), 16 deletions(-) commit 17ff30e9afde79e41c17786223293e867b49ebba Author: Behdad Esfahbod Date: Mon Sep 26 12:18:32 2016 +0100 [MATH] Clean up get_top_accent_attachment() Note, the function now returns "half of horizontal advance width" if top accent attachment for glyph is not explicitly defined. This is what the spec requires. Updated tests. src/hb-ot-layout-math-table.hh | 31 +++++++++++-------------------- src/hb-ot-layout.cc | 7 +------ test/api/test-ot-layout-math.c | 8 ++++---- 3 files changed, 16 insertions(+), 30 deletions(-) commit 8bcf517fe59608d2247a8974445b3ff0f4b4b4ac Author: Behdad Esfahbod Date: Mon Sep 26 12:12:41 2016 +0100 [MATH] Clean up get_italics_correction() src/hb-ot-layout-math-table.hh | 16 ++++++++-------- src/hb-ot-layout.cc | 17 ++++++----------- src/hb-ot-layout.h | 4 ++-- test/api/test-ot-layout-math.c | 18 +++++++++--------- 4 files changed, 25 insertions(+), 30 deletions(-) commit 06003f71ba0d0327fb1a17098a9d7faa8fb336f0 Author: Behdad Esfahbod Date: Mon Sep 26 12:07:29 2016 +0100 [MATH] Clean up a bit more src/hb-ot-layout-math-table.hh | 12 +-------- src/hb-ot-layout.cc | 57 ++++++++++++++++-------------------------- 2 files changed, 22 insertions(+), 47 deletions(-) commit 54c0cc38fba24fa4370231408ba121589b190a28 Author: Behdad Esfahbod Date: Mon Sep 26 11:56:40 2016 +0100 [MATH] Clean up get_math_constant implementation src/hb-ot-layout-math-table.hh | 10 +++++----- src/hb-ot-layout.cc | 5 ++--- 2 files changed, 7 insertions(+), 8 deletions(-) commit 8a8cfad9a0834fe278a747c1d755144bd78f564b Author: Behdad Esfahbod Date: Mon Sep 26 11:47:05 2016 +0100 [MATH] Cleanup previous commit a bit src/hb-ot-layout-math-table.hh | 186 ++++++++++++++++++++--------------------- src/hb-ot-layout.cc | 30 +++---- src/hb-ot-layout.h | 14 ++-- 3 files changed, 113 insertions(+), 117 deletions(-) commit d7182d129612c619b9026ee9b15f2dcfada132db Author: Frédéric Wang Date: Thu Aug 25 11:15:31 2016 +0200 MATH Table: Add API to access glyph info. src/hb-ot-layout-math-table.hh | 271 +++++++++++++++++++++++++++++++- src/hb-ot-layout.cc | 114 ++++++++++++++ src/hb-ot-layout.h | 18 +++ src/hb-ot-math.h | 7 + test/api/fonts/MathTestFontPartial1.otf | Bin 0 -> 14348 bytes test/api/fonts/MathTestFontPartial2.otf | Bin 0 -> 14356 bytes test/api/fonts/MathTestFontPartial3.otf | Bin 0 -> 14380 bytes test/api/test-ot-layout-math.c | 155 ++++++++++++++++++ 8 files changed, 563 insertions(+), 2 deletions(-) commit 6fd2fe418dc838743f0d4a8a2222cdcaf587500c Author: Behdad Esfahbod Date: Mon Sep 26 11:24:39 2016 +0100 [MATH] Fixup math constants commit a bit more src/hb-ot-layout-math-table.hh | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) commit 1a381153a2e6a15bded1f8e31f6b0e0cadb078af Author: Behdad Esfahbod Date: Mon Sep 26 11:15:59 2016 +0100 [MATH] Fixups for math constants commit src/hb-ot-layout-math-table.hh | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) commit 319ff59161e6b027391f8b9fdce0db6dd44cc20d Author: Frédéric Wang Date: Thu Aug 25 11:06:41 2016 +0200 MATH Table: Add API to access math contants. src/Makefile.sources | 1 + src/hb-ot-layout-math-table.hh | 146 +++++++++++++++++++++++++++++++++++- src/hb-ot-layout.cc | 25 ++++++ src/hb-ot-layout.h | 5 ++ src/hb-ot-math.h | 100 ++++++++++++++++++++++++ test/api/fonts/MathTestFontFull.otf | Bin 0 -> 25412 bytes test/api/test-ot-layout-math.c | 72 ++++++++++++++++++ 7 files changed, 345 insertions(+), 4 deletions(-) commit 4d3892e9b05a4df67b2f5cfd6dd3a1e0f5b38fc7 Author: Behdad Esfahbod Date: Mon Sep 26 10:45:58 2016 +0100 [MATH] Fixups for previous commit src/hb-ot-layout-math-table.hh | 8 ++++---- src/hb-ot-layout.cc | 29 +++++++++++++++++++---------- src/hb-ot-layout.h | 2 ++ test/api/Makefile.am | 6 ++---- test/api/test-ot-layout-math.c | 16 +++++++++------- 5 files changed, 36 insertions(+), 25 deletions(-) commit 5fbcb992bd7887f95b1cf2ca045c9226de8148fc Author: Frédéric Wang Date: Thu Aug 25 10:47:15 2016 +0200 MATH Table: Add API to check availability of math data. src/Makefile.sources | 1 + src/hb-ot-layout-math-table.hh | 60 +++++++++++++++++++++ src/hb-ot-layout-private.hh | 3 ++ src/hb-ot-layout.cc | 45 ++++++++++++++++ src/hb-ot-layout.h | 7 +++ test/api/Makefile.am | 14 ++++- test/api/fonts/MathTestFontEmpty.otf | Bin 0 -> 14320 bytes test/api/fonts/MathTestFontNone.otf | Bin 0 -> 14284 bytes test/api/test-ot-layout-math.c | 98 +++++++++++++++++++++++++++++++++++ 9 files changed, 227 insertions(+), 1 deletion(-) commit 02bfd965af588640250c47f344ad3096c8a373e0 Author: Gregory Morse Date: Mon Sep 12 10:22:15 2016 +0200 Update detectenv-msvc.mak (#316) Windows x86 ARM capability win32/detectenv-msvc.mak | 3 +++ 1 file changed, 3 insertions(+) commit fc4e671f311241e21c1cc3ed941b1fc651875a2e Author: Ebrahim Byagowi Date: Fri Sep 9 23:28:28 2016 +0430 [coretext] Use intended coretext version check logic (#315) src/hb-coretext.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 48677345281a93d8829dd37d0480a6062945416a Author: Khaled Hosny Date: Thu Sep 8 04:44:37 2016 +0300 Try to unbreak building on older macOS again (#314) src/hb-coretext.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d22ab6cf040467e7f17476ccdfe9cab4dce16639 Author: Behdad Esfahbod Date: Wed Sep 7 14:28:47 2016 -0700 1.3.1 NEWS | 9 +++++++++ configure.ac | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) commit b717cd7be506217e466e32a456df9af4d2720c0c Author: Dominik Röttsches Date: Wed Sep 7 23:56:57 2016 +0300 Do reconfigure the cascade list for Emoji font on OS X 10.9.5 (#313) This seems to fix crash issues on 10.9.5 reported on Chrome, compare crbug.com/549610 src/hb-coretext.cc | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) commit 67e9fdf427e8536f0a134f84ad3bf1740245fe12 Author: Dominik Röttsches Date: Mon Sep 5 11:27:25 2016 +0300 Blacklist Padauk 2.80 and 3.00 (#311) According to comments in issue #305 broken GDEF tables lead to incorrect rendering of Latin characters. Blacklisting this font. src/hb-ot-layout.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit 17f0dd2dfb9a15aed9d1a229115940cc23bdbc97 Author: Ebrahim Byagowi Date: Fri Sep 2 01:21:48 2016 +0430 [ci] Add msys2 build to CI and run its testsuite on Windows (#310) appveyor.yml | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) commit 5362ce6a6455c539d615e7fb221a904ac744b74c Author: Ebrahim Byagowi Date: Thu Sep 1 20:05:45 2016 +0430 [dwrite] Minor, don't include unnecessary headers (#309) src/hb-directwrite.cc | 4 ---- 1 file changed, 4 deletions(-) commit c4f36b04e32ae5111ef11d225e5d6e82c8216185 Author: Ebrahim Byagowi Date: Thu Sep 1 17:31:16 2016 +0430 [ci] Add Windows CI support, provided by AppVeyor (#308) README | 1 + appveyor.yml | 28 ++++++++++++++++++++++++++++ win32/generate-msvc.mak | 2 +- 3 files changed, 30 insertions(+), 1 deletion(-) commit 3d976d20f1b97c771e64a9cfed2760ebec64037a Author: Khaled Hosny Date: Sat Aug 27 16:38:42 2016 +0300 Show the shaper name in the debug message (#306) src/hb-shape-plan.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 547ddb0721365dca985aef5b759d08718f7c5f82 Merge: bd1aac9c e7ecbba2 Author: Sascha Brawer Date: Thu Aug 18 22:33:14 2016 +0200 Merge pull request #303 from behdad/fonnapa Support Americanist Phonetic Notation commit e7ecbba2cc3c9369c5e7dc7296cb210018aca3bb Author: Sascha Brawer Date: Thu Aug 18 12:48:38 2016 +0200 Support Americanist Phonetic Notation OpenType language system tag: `APPH` https://www.microsoft.com/typography/otspec/languagetags.htm IETF BCP47 variant tag: `fonnapa` http://www.iana.org/assignments/language-subtag-registry/language-subtag-registry src/hb-ot-tag.cc | 14 ++++++++++++-- test/api/test-ot-tag.c | 6 ++++++ 2 files changed, 18 insertions(+), 2 deletions(-) commit bd1aac9c0021a936058637424a478abf792533dd Merge: 18c19dd3 a0f1b44b Author: Sascha Brawer Date: Thu Aug 18 13:59:38 2016 +0200 Merge pull request #302 from khaledhosny/master [travis] Fix MacOS libtool issue commit a0f1b44b6c0e3b1e6a1ba63dde2be22e0425353f Author: Khaled Hosny Date: Tue Aug 16 03:09:04 2016 +0200 [coretext] Blind fix for build on MacOS 10.9 src/hb-coretext.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0634d5600e559a69a92d49173ffb8e715fe7576c Author: Khaled Hosny Date: Tue Aug 16 02:49:48 2016 +0200 [travis] Fix MacOS libtool issue Reveals another MacOS build breakage in the Core Text shaper. .travis.yml | 1 + 1 file changed, 1 insertion(+) commit 18c19dd34dcdcaab0a6d47768339f8fb70c0d3f0 Author: Behdad Esfahbod Date: Tue Aug 9 13:03:14 2016 -0700 Fix build test/api/test-ot-tag.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 91f2585411aaf5565fcf0c991b9055b0b397f1cd Author: Behdad Esfahbod Date: Mon Aug 8 18:08:08 2016 -0700 Actually add test test/shaping/Makefile.am | 1 + 1 file changed, 1 insertion(+) commit f1b76275da716a4174092e6389979e03c0e3be59 Author: Behdad Esfahbod Date: Mon Aug 8 18:06:09 2016 -0700 Add tests for Chinese language tags Using font from https://github.com/behdad/harfbuzz/issues/300 .../sha1sum/6991b13ce889466be6de3f66e891de2bc0f117ee.ttf | Bin 0 -> 5596 bytes test/shaping/tests/language-tags.tests | 12 ++++++++++++ 2 files changed, 12 insertions(+) commit 37f21bdbb75c98d741e749b7f1e0f367941aef4e Author: Behdad Esfahbod Date: Mon Aug 8 17:57:06 2016 -0700 Map Macao to ZHH lang tag Fixes https://github.com/behdad/harfbuzz/issues/300 src/hb-ot-tag.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 09c7a2d6bf00dc902343e999f92cac0e8146f949 Author: Behdad Esfahbod Date: Mon Aug 8 17:28:54 2016 -0700 Limit bits-per-feature to eight Limits number of alternatives per glyph per feature to 255, so be it. That's better than possibly breaking shaping because of one bad feature value. src/hb-ot-map.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 333173103bb618f721bd25d0c565a3c3c9ea224e Author: Behdad Esfahbod Date: Mon Aug 8 17:24:04 2016 -0700 Fix sign of shift operators This one: map->mask = (1 << (next_bit + bits_needed)) - (1 << next_bit); before the fix, the shift was done as an int, causing overflow if it ever got to 1 << 31. Sprinkle 'u's around. Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=634805 src/hb-buffer-private.hh | 6 +++--- src/hb-cache-private.hh | 8 ++++---- src/hb-coretext.cc | 2 +- src/hb-directwrite.cc | 2 +- src/hb-face.cc | 2 -- src/hb-font.cc | 2 -- src/hb-ft.cc | 6 ++++-- src/hb-ot-map.cc | 4 ++-- src/hb-set-private.hh | 4 ++-- src/hb-uniscribe.cc | 4 ++-- 10 files changed, 19 insertions(+), 21 deletions(-) commit 10a0d4aa2254f783758bb908175047df3a0b41fe Author: Behdad Esfahbod Date: Mon Aug 8 16:51:08 2016 -0700 Map zh-Hant-HK to ZHH Fixes https://github.com/behdad/harfbuzz/issues/300 src/hb-ot-tag.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit dd31fc9f7e6d23b414b22874de96eb3c002c80ba Author: Khaled Hosny Date: Fri Jul 22 02:26:54 2016 +0300 Don’t build UCDN support when building with GLib (#296) Regression from: b424b6c372dfe4c0ed75a49761eb34a416819446. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 489acf6c3180d3726158864fa0e1adeea3c23fae Author: Behdad Esfahbod Date: Fri Jul 22 17:41:43 2016 -0700 [coretext] "Fix" crashes on CoreText < 10.10 Fixes https://github.com/behdad/harfbuzz/issues/297 src/hb-coretext.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit a732e00ea4fffebaa85a89420f09df4c11d650e0 Author: Behdad Esfahbod Date: Thu Jul 21 01:58:00 2016 -0700 1.3.0 NEWS | 15 +++++++++++++++ configure.ac | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) commit 08c08af2f9ed683ad20322c3ef1ba0f87ce15426 Author: Behdad Esfahbod Date: Thu Jul 21 01:23:33 2016 -0700 [ucdn] Update to Unicode 9.0.0 Fixes https://github.com/grigorig/ucdn/issues/12 src/hb-ucdn.cc | 6 + src/hb-ucdn/README | 1 - src/hb-ucdn/ucdn.c | 80 +- src/hb-ucdn/ucdn.h | 98 +- src/hb-ucdn/unicodedata_db.h | 4750 +++++++++++++++++++++++------------------- 5 files changed, 2783 insertions(+), 2152 deletions(-) commit f3f6c1ccbf89e15cda03e0c3a2df4297e98adf60 Author: jfkthame Date: Thu Jun 16 00:10:42 2016 +0100 Blacklist GDEF tables of more fonts This is based on bug reports that have been filed against Firefox since it updated to a version of harfbuzz that uses zeroing by GDEF rather than by Unicode. I'm sure there are a bunch more font versions that should also be included; these are just the ones I have on hand and have confirmed as having bad GDEF data. Given how the list here is growing, I think we should reconsider the approach, and perhaps revert to zeroing by Unicode instead. Fixes https://github.com/behdad/harfbuzz/issues/264 Fixes https://github.com/behdad/harfbuzz/pull/266 src/hb-ot-layout.cc | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) commit 34f9aa582c3a03b578c7eae3d2e8860a0bd5cb00 Author: Behdad Esfahbod Date: Wed Jul 20 02:35:54 2016 -0700 Implement symbol cmap in ft and ot fonts Fixes https://github.com/behdad/harfbuzz/issues/236 Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=627953 src/hb-ft.cc | 27 +++++++++++++++++++++++---- src/hb-ot-font.cc | 50 ++++++++++++++++++++++++++++++++++++++------------ 2 files changed, 61 insertions(+), 16 deletions(-) commit 6363d7df28dc4307ef1abb9857d14c35e656b85a Author: Behdad Esfahbod Date: Wed Jul 20 01:43:56 2016 -0700 Clean up buffer area when rewinding Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=614647 If allocation fails, we might be leaving junk behind. At least clear it up. src/hb-buffer.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit f80c34eb556d12c45c961d6742c289baef58899d Author: Behdad Esfahbod Date: Tue Jul 12 11:18:26 2016 -0700 Whitespace src/hb-unicode-private.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 874421203e0161db2cbfb27be6c039cba57f7c63 Author: Ebrahim Byagowi Date: Tue Jul 12 03:49:21 2016 +0430 [coretext] Speculative fix for CoreText nullptr access (#288) src/hb-coretext.cc | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) commit 6bf9db4f1e1d51f9acb5e37b89caa8f4d275e7ce Author: Birunthan Mohanathas Date: Mon Jul 11 13:38:23 2016 -0700 [ft] Fix unsafe cast of FT_Done_Face in hb_ft_{face,font}_create_referenced (#289) Prior to this change the function `FT_Error FT_Done_Face(FT_Face *)` was called through a pointer with the signature `void (void *)` resulting in undefined behaviour. src/hb-ft.cc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) commit 0b8f3ab0220ca4731516313828515f26bb480645 Author: Steve Lhomme Date: Mon Jul 11 21:57:26 2016 +0200 clang in MSVC mode doesn't like when we redefine __attribute__ (#283) src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2f522fd485c2e946c9bce9e3828b6ff6247c59e4 Merge: d3e2a06b e4d451ee Author: Behdad Esfahbod Date: Fri Jul 1 17:09:28 2016 -0700 Merge pull request #286 from khaledhosny/gi-tag_from_string [introspection] Fix hb_tag_from_string annotation commit e4d451ee55a57e1231b4076fcd1e87994f6b9528 Author: Khaled Hosny Date: Sat Jul 2 00:04:57 2016 +0200 [introspection] Fix hb_tag_from_string annotation src/hb-common.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d3e2a06b0f2587e913a9c3ff1a20c187f260db80 Author: Behdad Esfahbod Date: Thu Jun 30 11:01:22 2016 -0700 [python] Use utf-32 / utf-16 based on build of Python Fixes https://github.com/behdad/harfbuzz/pull/271 src/sample.py | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) commit fc9de44a03a97f6e93bd98d804596cb1f9f4b5fd Author: Behdad Esfahbod Date: Thu Jun 30 09:46:52 2016 -0700 Comments src/hb-coretext.cc | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) commit 46809dee30232d493539519b1bb527fa816c37db Merge: 70e72e5f 1bea49eb Author: Behdad Esfahbod Date: Thu Jun 30 09:41:03 2016 -0700 Merge pull request #268 from drott/conflictingFontFix Discard reconfigured CTFont if URL changes commit 1bea49eb4b7a94ab6222f9c3c40320cbdb247b2d Merge: 7aa3631d 70e72e5f Author: Dominik Röttsches Date: Wed Jun 29 12:10:41 2016 +0200 Merge branch 'master' into conflictingFontFix commit 70e72e5f61d73c33d3c8f3bf07f5a9afd0db046a Author: Behdad Esfahbod Date: Tue Jun 28 21:00:37 2016 -0700 [gobject] Fix a few warnings Part of https://github.com/behdad/harfbuzz/issues/277 src/hb-buffer.cc | 2 +- src/hb-gobject-structs.h | 12 ++++++++++++ src/hb-shape.cc | 2 -- src/hb-unicode.h | 15 --------------- 4 files changed, 13 insertions(+), 18 deletions(-) commit d8273aac19771033c5064a2f079c29d09a86e7c0 Merge: abae93fa ae9054c7 Author: Behdad Esfahbod Date: Tue Jun 28 21:15:28 2016 -0700 Merge pull request #280 from behdad/revert-271-patch-2 Revert "use utf32" commit ae9054c740631e36b7582b44c5afb42ff4509461 Author: Behdad Esfahbod Date: Tue Jun 28 21:14:38 2016 -0700 Revert "use utf32" src/sample.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 7aa3631dd06af74a1fa9f0bfaa5f721876be817f Merge: f7da0486 abae93fa Author: Dominik Röttsches Date: Tue Jun 28 09:52:18 2016 +0200 Merge branch 'master' into conflictingFontFix commit abae93faef32562f34a72981d252c848cc4f7565 Merge: 07461d06 8179ff5d Author: Behdad Esfahbod Date: Mon Jun 27 14:33:27 2016 -0400 Merge pull request #273 from ebraminio/master [dwrite] Use stream font loader instead GDI interop commit 8179ff5d7ba4a140cf6743729a22072800e98a79 Author: Ebrahim Byagowi Date: Mon Jun 27 03:54:15 2016 +0430 [dwrite] Don't allocate more than needed Addressing Nikolay Sivov reviews on harfbuzz mailing list src/hb-directwrite.cc | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) commit 07b724f3419a28c479cd8a75ae0eecb841a6d2f3 Author: Ebrahim Byagowi Date: Fri Jun 24 12:23:25 2016 +0430 [dwrite] Delete remained objects No longer noticeable memory increase on create/destroy iterations, highly better than current state of uniscribe backend src/hb-directwrite.cc | 33 ++++++++++++++++++++++++--------- 1 file changed, 24 insertions(+), 9 deletions(-) commit be565d17141818e006aa1e4582f3ae14c726fa85 Author: Ebrahim Byagowi Date: Fri Jun 24 11:42:01 2016 +0430 [dwrite] Release allocated blob on face destroy This reduces memory consumption of my iterated font create/destroy cycle test significantly and makes it much better than uniscribe backend even src/hb-directwrite.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit f3f0ea980a359343ac0e3d359a95855c2cf7be25 Author: Ebrahim Byagowi Date: Thu Jun 23 16:41:37 2016 +0430 [dwrite] Remove ifdefs without breaking execution on old Windows versions src/hb-directwrite.cc | 205 +++++++++++++++++++++++++------------------------- 1 file changed, 103 insertions(+), 102 deletions(-) commit 6b861dbd8b3662d0fa0e51fad1736d72192da868 Author: Ebrahim Byagowi Date: Tue Jun 21 13:57:26 2016 +0430 [dwrite] Use stream font loader instead GDI interop With help of https://dxr.mozilla.org/mozilla-central/source/gfx/2d/NativeFontResourceDWrite.cpp src/hb-directwrite.cc | 350 +++++++++++++++++++------------------------------- src/hb-directwrite.h | 2 +- 2 files changed, 135 insertions(+), 217 deletions(-) commit f7da0486ed8884481d477ce08fcf928c4da9a0a3 Merge: a0223274 07461d06 Author: Dominik Röttsches Date: Mon Jun 20 10:25:43 2016 +0300 Merge branch 'master' into conflictingFontFix commit 07461d06d242cd5cfda7ccb891189f074a89b460 Author: Kelvin Date: Sat Jun 18 22:46:38 2016 +0000 Use UTF-32 in Python sample src/sample.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit fca0c61d67aa309fc824fb18f247493c2b7701ef Merge: 4b8de1ea 98835058 Author: Khaled Hosny Date: Sun Jun 19 00:08:51 2016 +0300 Merge pull request #270 from khaledhosny/travis-failure Fix make check on Travis commit 988350586f607c7a46bbb658a2abecfd004f41fb Author: Khaled Hosny Date: Sat Jun 18 21:12:19 2016 +0200 [tests] Workaround Python 2 “narrow” builds The so-called Python 2 “narrow” builds support UCS2 only, this is a workaround to allow unichr to work with any Unicode character in such builds. This fixes Travis-CI failure as it has narrow Python 2 builds. Copied from: https://github.com/behdad/fonttools/blob/master/Lib/fontTools/misc/py23.py test/shaping/hb_test_tools.py | 38 +++++++++++++++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-) commit a0223274b97e82fe02730fd45729172511fec459 Author: Dominik Röttsches Date: Thu Jun 16 14:19:39 2016 +0200 Discard reconfigured CTFont if URL changes Fixes https://github.com/behdad/harfbuzz/issues/267 src/hb-coretext.cc | 24 +++++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) commit 4b8de1ea804b225e8357422d0686aad76b05ccf3 Author: Behdad Esfahbod Date: Mon Jun 6 23:08:54 2016 -0700 Round, not truncate, when scaling values Fixes https://github.com/behdad/harfbuzz/issues/255 src/hb-font-private.hh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit a93078a0ece6dcdea8c5b46cabd30854dd7cf593 Author: Behdad Esfahbod Date: Mon Jun 6 15:58:41 2016 -0700 Change bugreport URL to github That's where everything is happening these days. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bed201d2b839c1b1e727e17efc2e0c8f705b86c5 Author: Behdad Esfahbod Date: Mon Jun 6 14:14:24 2016 -0700 Update for latest Unicode 9 data files src/hb-ot-shape-complex-indic-table.cc | 10 +++++----- src/hb-ot-shape-complex-indic.cc | 5 ----- src/hb-ot-shape-complex-use-table.cc | 4 ++-- 3 files changed, 7 insertions(+), 12 deletions(-) commit aba4b0ca52f490adfc2f3c6ec0accddd6596fdf6 Author: Behdad Esfahbod Date: Wed Jun 1 16:57:29 2016 -0700 Add TODO src/hb-font.cc | 1 + 1 file changed, 1 insertion(+) commit a2b03de5b30b7e83f7fbf3457e9ba9c00eb88d00 Author: Behdad Esfahbod Date: Fri May 6 17:56:07 2016 +0100 [myanmar] Handle U+AA74..U+AA76 Fixes https://github.com/behdad/harfbuzz/issues/218 src/hb-ot-shape-complex-myanmar.cc | 5 +++++ 1 file changed, 5 insertions(+) commit 6c0aa9e92bbd22011c85d98c6db021012f7b4101 Author: Behdad Esfahbod Date: Fri May 6 17:50:06 2016 +0100 Fix build on droid.io test/shaping/tests/use.tests | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9b6312f9451db790db00dc2c2e27a5a1db852e72 Author: Behdad Esfahbod Date: Fri May 6 17:41:49 2016 +0100 [use] Update to draft spec from Andrew Glass from August 2015 src/gen-use-table.py | 29 +++-- src/hb-ot-shape-complex-use-machine.rl | 15 +-- src/hb-ot-shape-complex-use-private.hh | 1 - src/hb-ot-shape-complex-use-table.cc | 142 ++++++++++----------- src/hb-ot-shape-complex-use.cc | 11 +- .../6ff0fbead4462d9f229167b4e6839eceb8465058.ttf | Bin 0 -> 1148 bytes test/shaping/tests/use.tests | 1 + 7 files changed, 93 insertions(+), 106 deletions(-) commit 3e4e7616a8ca80a50a438601b84428b4ba4c8694 Author: Behdad Esfahbod Date: Fri May 6 17:28:25 2016 +0100 [use] Add a catch-all clause to the machine src/hb-ot-shape-complex-use-machine.rl | 2 ++ src/hb-ot-shape-complex-use.cc | 2 ++ 2 files changed, 4 insertions(+) commit d04e461fe3310ccaf8633efcb79b8eb6ca2201c3 Author: Behdad Esfahbod Date: Fri May 6 17:17:00 2016 +0100 [use] Fix 'Number-joiner terminated cluster' to use HN instead of H From draft update to USE. src/hb-ot-shape-complex-use-machine.rl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 359dead960c825edeb4587915a511d323f1c1f2a Author: Behdad Esfahbod Date: Fri May 6 16:19:19 2016 +0100 Allow MultipleSubst to delete glyph Fixes https://github.com/behdad/harfbuzz/issues/253 Hopefully we got the logic right. src/hb-ot-layout-gsub-table.hh | 17 +++++++---------- src/hb-ot-layout-gsubgpos-private.hh | 11 +++++++---- 2 files changed, 14 insertions(+), 14 deletions(-) commit 3c1666cfb589275de96d54eecb95a13a98e3819e Author: Behdad Esfahbod Date: Fri May 6 16:05:07 2016 +0100 [indic] Remove more unused logic after Javanese is gone src/hb-ot-shape-complex-indic.cc | 50 +++++++++++++++------------------------- 1 file changed, 18 insertions(+), 32 deletions(-) commit 8b5d6e755b271d0d22b31a7726d5bfbf2aae8b2f Author: Behdad Esfahbod Date: Fri May 6 15:59:27 2016 +0100 [indic] Remove unused Javanese bits src/hb-ot-shape-complex-indic-machine.rl | 3 +-- src/hb-ot-shape-complex-indic-private.hh | 5 ++--- src/hb-ot-shape-complex-indic.cc | 4 ---- 3 files changed, 3 insertions(+), 9 deletions(-) commit 30e6e29f0f0f77eb65bfd1c4576b38c2da555017 Author: Behdad Esfahbod Date: Fri May 6 15:52:27 2016 +0100 [indic/use] Move Javanese from Indic shaper to USE Fixes https://github.com/behdad/harfbuzz/issues/243 With javatext.ttf, the reodering medial Ra gets its advance width zero'ed in Uniscribe implementation, and the font adds the advance back. Our Indic shaper does not do that, but USE does. So, route Javanese through USE. That's what Microsoft does anyway. Test: U+A9A5,U+A9BA This also seems to fix the following sequence, and variations thereof: U+A99F,U+A9C0,U+A9A2,U+A9BF src/gen-indic-table.py | 1 - src/hb-ot-shape-complex-indic-table.cc | 23 ++++------------------ src/hb-ot-shape-complex-private.hh | 5 +---- .../south-east-asian/script-javanese/misc.txt | 1 + 4 files changed, 6 insertions(+), 24 deletions(-) commit c6ee5f5f06a27a6f147f63aaf51186622821f20b Author: Behdad Esfahbod Date: Fri May 6 15:39:02 2016 +0100 Add Javanese sample text .../south-east-asian/script-javanese/misc.txt | 53 ++++++++++++++++++++++ 1 file changed, 53 insertions(+) commit e21921a68a959b7e929f71a4260a6cbe055ab4e6 Author: Behdad Esfahbod Date: Fri May 6 15:24:39 2016 +0100 Minor BUILD.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit 01a30a6aa9a5827c93245961e3392a1f361745fe Author: Behdad Esfahbod Date: Fri May 6 11:50:02 2016 +0100 [indic] Remove data for scripts that don't go thorough this shaper src/gen-indic-table.py | 29 +- src/hb-ot-shape-complex-indic-table.cc | 604 +-------------------------------- 2 files changed, 43 insertions(+), 590 deletions(-) commit 7cd9269f4eba7b85cd72301a3fc39fab42a4e439 Author: Behdad Esfahbod Date: Fri May 6 11:34:46 2016 +0100 Update tables to Unicode 9.0.0 beta Fixes https://github.com/behdad/harfbuzz/issues/251 src/hb-ot-shape-complex-arabic-table.hh | 56 ++++++++----- src/hb-ot-shape-complex-indic-table.cc | 137 +++++++++++++++++++++++--------- src/hb-ot-shape-complex-use-table.cc | 86 ++++++++++++++------ 3 files changed, 196 insertions(+), 83 deletions(-) commit f718fe370ea89e8aeb407addaa6cc926d52a4cdb Author: Behdad Esfahbod Date: Fri May 6 11:21:12 2016 +0100 Minor src/gen-indic-table.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 691086f131cb6c9d97e98730c27673484bf93f87 Author: Behdad Esfahbod Date: Fri May 6 12:08:18 2016 +0100 Add Unicode 9 beta scripts These are frozen, so good time to add. src/hb-common.cc | 3 +++ src/hb-common.h | 9 +++++++++ src/hb-ot-shape-complex-private.hh | 9 +++++++++ src/hb-ot-shape-complex-use.cc | 3 +++ 4 files changed, 24 insertions(+) commit bc5198fe1277d662926a4f616913c085cd4fc8ee Author: Behdad Esfahbod Date: Fri May 6 11:59:05 2016 +0100 Whitespace src/hb-common.h | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) commit a5b7b0dd4508d8a1e7573b75c4cb8832c9e34e3f Author: Behdad Esfahbod Date: Mon May 2 10:44:13 2016 +0200 1.2.7 NEWS | 12 ++++++++++++ configure.ac | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) commit 9879fc1db3cad684f412c2f3d6b49e0435697d0e Author: Behdad Esfahbod Date: Mon May 2 10:29:12 2016 +0200 [ot-font] Remove unused 'post' table include for now To make a release... src/hb-ot-font.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f8061ae7972462ad800c23be7cd7b3d7ab94b93b Author: Behdad Esfahbod Date: Mon May 2 10:28:24 2016 +0200 [tests] Fix test test/shaping/Makefile.am | 2 +- .../tests/{fallback-positioning.test => fallback-positioning.tests} | 0 2 files changed, 1 insertion(+), 1 deletion(-) commit f00ab2a33ab34ba64f38cbbe65830c770a3e071e Author: Behdad Esfahbod Date: Mon May 2 10:24:00 2016 +0200 [hb-ot-font] Make 'glyf' table loading lazy Apparently some clients have reference-table callbacks that copy the table. As such, avoid loading 'glyf' table which is only needed if fallback positioning happens. src/hb-ot-font.cc | 45 ++++++++++++++++++++- test/shaping/Makefile.am | 1 + .../7ef276fc886ea502a03b9b0e5c8b547d5dc2b61c.ttf | Bin 0 -> 784 bytes test/shaping/tests/fallback-positioning.test | 2 + 4 files changed, 46 insertions(+), 2 deletions(-) commit 587d46227a56940a7f5bb053cbeda6144394acf7 Author: Behdad Esfahbod Date: Sat Apr 30 19:20:56 2016 +0200 [ot-font] Start implementing 'post' table, for accessing glyph names src/Makefile.sources | 1 + src/hb-open-type-private.hh | 12 ++++- src/hb-ot-font.cc | 1 + src/hb-ot-post-table.hh | 119 ++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 132 insertions(+), 1 deletion(-) commit 9abaaac409b8e3a0a9182b67dc384133013f7878 Merge: 2f560ee4 264b7a72 Author: Behdad Esfahbod Date: Wed Apr 27 03:38:24 2016 -0700 Merge commit '264b7a728a41becfbf23ce258fc2a3af19d0cbbe' into HEAD commit 2f560ee44b7b08683e8e6955fe3b95187e8bda32 Author: Behdad Esfahbod Date: Wed Apr 27 03:11:41 2016 -0700 [tibetan] Reorder marks to better match Uniscribe Fixes https://github.com/behdad/harfbuzz/issues/237 Note that Uniscribe enforces a certain syllable order. We don't. But with this change, I get all of the tibetan contractions pass with Microsoft Himalaya font. src/hb-unicode-private.hh | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit f68390f196216718c22c434e1d8921118e646824 Author: Behdad Esfahbod Date: Wed Apr 27 02:44:35 2016 -0700 [test] Add text for Tibetan shorthand contractions From http://www.babelstone.co.uk/Tibetan/Contractions.html .../script-tibetan/misc/contractions.txt | 612 +++++++++++++++++++++ 1 file changed, 612 insertions(+) commit 264b7a728a41becfbf23ce258fc2a3af19d0cbbe Merge: 7e2da035 adafdcdd Author: Khaled Hosny Date: Wed Apr 27 03:48:23 2016 +0300 Merge pull request #247 from khaledhosny/update-opentype-language-tags Update opentype language tags commit adafdcddced076da4bfa3114a00e15a387aaf1f7 Author: Arthur Reutenauer Date: Sat Nov 7 23:37:21 2015 +0000 Mass-added “difficult” tags – to be curated. src/hb-ot-tag.cc | 69 +++++++++++++++++++++++++++++--------------------------- 1 file changed, 36 insertions(+), 33 deletions(-) commit 3d6a2c0d7d9f6c5b3097f78c1123f9e59dcc76e2 Author: Arthur Reutenauer Date: Sat Nov 7 22:59:13 2015 +0000 Initial import of missing OpenType 1.7 language tags. src/hb-ot-tag.cc | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 61 insertions(+), 6 deletions(-) commit 7e2da035f68e46ce8f4759b67b4ed3a1b211d793 Author: Behdad Esfahbod Date: Tue Apr 26 16:42:25 2016 -0700 Undo accidental change src/hb-ot-shape-complex-arabic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b20305022a8235b19e6b640bc62651854e1336f1 Author: Behdad Esfahbod Date: Tue Apr 26 16:41:17 2016 -0700 Do NOT ignore Mongolian Free Variation Selectors during matching Fixes https://github.com/behdad/harfbuzz/issues/234 src/hb-ot-layout-gsubgpos-private.hh | 2 +- src/hb-ot-layout-private.hh | 23 +++++++++++++++++++-- src/hb-ot-shape-complex-arabic.cc | 2 +- .../a34a7b00f22ffb5fd7eef6933b81c7e71bc2cdfb.ttf | Bin 0 -> 3700 bytes .../tests/mongolian-variation-selector.tests | 1 + 5 files changed, 24 insertions(+), 4 deletions(-) commit 21ab5501f5f5267d20cf23256866dd9d82a667ef Author: Behdad Esfahbod Date: Tue Apr 26 16:02:04 2016 -0700 Move ZWJ/ZWNJ bits to top byte of unicode_props() To make room to remember Mongolian Free Variation Selectors. Part of fixing https://github.com/behdad/harfbuzz/issues/234 src/hb-ot-layout-private.hh | 40 ++++++++++++++++++++++------------------ 1 file changed, 22 insertions(+), 18 deletions(-) commit de508516cb06ddb064d75bd7be8e843a5ebcf70d Author: Behdad Esfahbod Date: Tue Apr 26 11:28:37 2016 -0700 [util] Print out --debug buffer to stderr util/main-font-text.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 29393884b9f045460fb65d6ad10a94461ba93430 Author: Behdad Esfahbod Date: Tue Apr 26 10:35:23 2016 -0700 Annotate blacklisted fonts with their sha1sum src/hb-ot-layout.cc | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) commit 14bb4a56971fd45063cd6c1288d911627088abb2 Merge: 1c625dff 5069062d Author: Sascha Brawer Date: Tue Apr 26 11:38:16 2016 +0200 Merge pull request #245 from KonstantinRitt/fixes/ce Unbreak build on Windows CE commit 5069062d0a9342bb716eebf3ddc1efad91924caa Author: Konstantin Ritt Date: Tue Apr 26 12:02:26 2016 +0400 Unbreak build on Windows CE 0475ef2f97e3035a2eea9a0f96031331e07e8e29 broke the build by using vsnprintf(), which is not defined on Windows CE src/hb-private.hh | 1 + 1 file changed, 1 insertion(+) commit 1c625dff2269c54ff429ca45be88893ff1fa6c34 Author: Behdad Esfahbod Date: Sat Apr 9 12:53:23 2016 -0700 Minor src/hb-ot-layout.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 851b0db36d1b724fc1e0db506445119c78186285 Author: Behdad Esfahbod Date: Fri Apr 8 23:46:55 2016 -0700 Minor. We should never get to this branch, but fix it anyway. src/hb-ot-layout-common-private.hh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 00ea66f35754a1e6e4d3b7b139d611a9a623a9d1 Author: Behdad Esfahbod Date: Fri Apr 8 13:51:01 2016 -0700 1.2.6 NEWS | 10 ++++++++++ configure.ac | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) commit 4f3d59a1877dcb94d09da48e9694a6c1b05a86fe Author: Behdad Esfahbod Date: Fri Apr 8 13:41:20 2016 -0700 Blacklist another set of timesi.ttf and timesbi.ttf src/hb-ot-layout.cc | 2 ++ 1 file changed, 2 insertions(+) commit ef476be80d773332e0c768a3465d99381d76edd9 Merge: a0331b55 d3134a66 Author: Behdad Esfahbod Date: Fri Apr 8 13:16:33 2016 -0700 Merge pull request #239 from ebraminio/dwfix Improve DirectWrite backend commit d3134a66ad551ded726db9528d3c25459088f105 Author: Ebrahim Byagowi Date: Tue Apr 5 21:01:05 2016 +0000 Fix when no feature is given src/hb-directwrite.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit a0331b55f7b45437980e1fc323251f4091bf2c4e Author: Behdad Esfahbod Date: Mon Apr 4 16:25:32 2016 -0700 1.2.5 NEWS | 7 +++++++ configure.ac | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) commit 6e55199b5f097ac93bad38f32e9813e2da14c5a7 Author: Behdad Esfahbod Date: Mon Apr 4 16:24:27 2016 -0700 Add test for 6dd80faf0dcb3e8a8915c3a25da44e2a67cb0cd8 test/shaping/Makefile.am | 1 + .../f22416c692720a7d46fadf4af99f4c9e094f00b9.ttf | Bin 0 -> 16736 bytes test/shaping/tests/mark-filtering-sets.tests | 5 +++++ 3 files changed, 6 insertions(+) commit 59089622dbb8dda783b1639c932123f125c3592d Author: Behdad Esfahbod Date: Mon Apr 4 14:54:32 2016 -0700 [coretext] Clarify comment src/hb-coretext.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) commit 6dd80faf0dcb3e8a8915c3a25da44e2a67cb0cd8 Author: Behdad Esfahbod Date: Mon Apr 4 14:34:25 2016 -0700 Fix FixedVersion::to_int() Ouch. Had broken it in 9a13ed453ef96822a47d6e6f58332b87f38d5c59 Fixes https://github.com/behdad/harfbuzz/issues/238 Will add test soon. src/hb-open-type-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4a104021697439fd21390a1f4cdc9310348882fa Author: Ebrahim Byagowi Date: Sat Apr 2 13:47:59 2016 +0000 Hide justification behind HB_DIRECTWRITE_EXPERIMENTAL_JUSTIFICATION src/hb-directwrite.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 63ee9ca5d81b53eb035972754ed95572821c393c Author: Ebrahim Byagowi Date: Fri Apr 1 15:47:07 2016 +0000 Use standard types instead Windows favourites ones src/hb-directwrite.cc | 100 +++++++++++++++++++++++++------------------------- 1 file changed, 50 insertions(+), 50 deletions(-) commit adf20ba0d18d1506e633dcd9b4827a6c93abcadd Author: Ebrahim Byagowi Date: Fri Apr 1 15:36:40 2016 +0000 Limit GetJustifiedGlyphs only to scripts with custom justification character src/hb-directwrite.cc | 98 +++++++++++++++++++++++++++++++-------------------- 1 file changed, 60 insertions(+), 38 deletions(-) commit 32ae9d1b3ffbe7e26e654437a56a26a95fe9f5a6 Author: Ebrahim Byagowi Date: Fri Apr 1 06:39:57 2016 +0000 Add justification support src/hb-directwrite.cc | 321 ++++++++++++++++++++++++++++++++------------------ 1 file changed, 205 insertions(+), 116 deletions(-) commit 10c3d9e41520595c88dd2a8321590e03ce8fcf47 Author: Ebrahim Byagowi Date: Thu Mar 31 18:19:44 2016 +0000 Basic opentype features support src/hb-directwrite.cc | 62 ++++++++++++++++++++++++++++++++++----------------- 1 file changed, 42 insertions(+), 20 deletions(-) commit d129897120d3ad414220d603557c15a60aa69fa6 Author: Ebrahim Byagowi Date: Thu Mar 31 13:45:37 2016 +0000 Refactor and remove dupe getglyphs call src/hb-directwrite.cc | 106 ++++++++++++++++++++++++-------------------------- 1 file changed, 51 insertions(+), 55 deletions(-) commit 5f1a8961008b93f72acc47336109af3a64e248d0 Author: Ebrahim Byagowi Date: Thu Mar 31 12:26:16 2016 +0000 Better glyph offset support src/hb-directwrite.cc | 44 ++++++++++++++++++++++++-------------------- 1 file changed, 24 insertions(+), 20 deletions(-) commit d691ba3f405738c6857450752b8cc0911dfcdb01 Author: Ebrahim Byagowi Date: Wed Mar 30 20:21:40 2016 +0000 Don't fail when language is not set src/hb-directwrite.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit 1c00a46c7a608ebc0b03c5abfcfe7f2b9881d0df Author: Ebrahim Byagowi Date: Wed Mar 30 20:15:09 2016 +0000 Make DirectWrite backend to work with different font sizes Actually copyedited same logic from Uniscribe to make it just work src/hb-directwrite.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit 0251b0cc5c39272d2299d4b2ab802faaafe96837 Author: Behdad Esfahbod Date: Thu Mar 17 14:37:11 2016 -0700 1.2.4 NEWS | 15 +++++++++++++++ configure.ac | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) commit 69f9fbc4200442a35484d3c790ae8f4979be5d60 Author: Behdad Esfahbod Date: Thu Mar 17 11:59:43 2016 -0700 Synthesize GDEF glyph class for any glyph that does not have one in GDEF Previously we only synthesized GDEF glyph classes if the glyphClassDef array in GDEF was null. This worked well enough, and is indeed what OpenType requires: "If the font does not include a GlyphClassDef table, the client must define and maintain this information when using the GSUB and GPOS tables." That sentence does not quite make sense since one needs Unicode properties as well, but is close enough. However, looks like Arial Unicode as shipped on WinXP, does have GDEF glyph class array, but defines no classes for Hebrew. This results in Hebrew marks not getting their widths zeroed. So, with this change, we synthesize glyph class for any glyph that is not specified in the GDEF glyph class table. Since, from our point of view, a glyph not being listed in that table is a font bug, any unwanted consequence of this change is a font bug :). Note that we still don't get the same rendering as Uniscribe, since Uniscribe seems to do fallback positioning as well, even though the font does have a GPOS table (which does NOT cover Hebrew!). We are not going to try to match that though. Test string for Arial Unicode: U+05E9,U+05B8,U+05C1,U+05DC Before: [gid1166=3+991|gid1142=0+737|gid5798=0+1434] After: [gid1166=3+991|gid1142=0+0|gid5798=0+1434] Uniscribe: [gid1166=3+991|gid1142=0@348,0+0|gid5798=0+1434] Note that our new output matches what we were generating until July 2014, because the Hebrew shaper used to zero mark advances based on Unicode, NOT GDEF. That's 9e834e29e0b657f0555df1ab9cea79ff7abcf08d. Reported by Greg Douglas. src/hb-ot-layout-gsub-table.hh | 22 ++++++++++++++++++++-- src/hb-ot-shape.cc | 29 ----------------------------- 2 files changed, 20 insertions(+), 31 deletions(-) commit fef5dd9a72f326c160a7194f558749d24bac7283 Merge: 01ea9eaa 5f995db1 Author: Behdad Esfahbod Date: Sat Mar 12 19:15:15 2016 -0800 Merge pull request #232 from c0nk/wip-icu Add --with-icu=builtin option; fix compile error commit 01ea9eaac373d9f3de6e56c1ca26cdcd259ecc8e Author: Behdad Esfahbod Date: Fri Mar 11 18:50:02 2016 -0800 [build] Use tar-ustar instead of tar-pax The default tar-v7 is not good enough for us (99 char filename limit), so I have had bumped to tar-pax. We got one complaint that someone's tar couldn't handle tar-pax. Set to tar-ustar which is ~13 years earlier than tar-pax and is good enough for us. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3e10460a1dd41de32752e308771aa30d23565cc0 Author: Behdad Esfahbod Date: Fri Mar 11 18:45:19 2016 -0800 Minor comment src/hb-unicode-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d14fea4bdcc1423fe9a585af3abdefa9605d17e6 Author: Behdad Esfahbod Date: Tue Mar 8 12:16:41 2016 -0800 Remove default clause in minor switch statements Bending to clang warnings... https://bugs.chromium.org/p/chromium/issues/detail?id=593057 src/hb-ot-shape-complex-indic.cc | 4 ---- src/hb-ot-shape-complex-thai.cc | 1 - 2 files changed, 5 deletions(-) commit ce8ae9970102f83b67bb1e8e8b2bf894a0e26c07 Merge: 731a430c 71248a84 Author: Behdad Esfahbod Date: Fri Mar 4 17:20:35 2016 -0800 Merge pull request #231 from KonstantinRitt/post123buildfix Fix build with HB_DISABLE_DEPRECATED commit 731a430cd36caabcef04e099b21ebc6daedd536f Author: Behdad Esfahbod Date: Wed Mar 2 13:32:42 2016 -0800 Fix requiredFeature stage handling logic Originally the way Jonathan had written this was correct in "continue"ing: https://github.com/jfkthame/harfbuzz/commit/35e28c7a733eaffcd9f062b18d7db9fbb3d990fc#diff-ead86a33a5cc9ad7f6e6381031a0baddR199 When I rewrote his patch, I messed it up: https://github.com/behdad/harfbuzz/commit/da132937989acb4d8ca9bd41c79f98750e7dda30#diff-ead86a33a5cc9ad7f6e6381031a0baddR209 the intended behavior was NOT to set found=TRUE and NOT to continue. This was resulting in feature_index[table_index] being left unset. Oops! src/hb-ot-map.cc | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit 68b6296d3333fd38bd5442d2ba087ced481603bc Author: Behdad Esfahbod Date: Tue Mar 1 16:41:53 2016 +0900 Add F2DOT14 type src/hb-open-type-private.hh | 9 +++++++++ 1 file changed, 9 insertions(+) commit 082b79fe9f06607998178dcdcbe817af28b017de Author: Behdad Esfahbod Date: Tue Mar 1 16:41:26 2016 +0900 Use FWORD and UFWORD when it makes sense I had forgotten about those types. src/hb-ot-glyf-table.hh | 8 ++++---- src/hb-ot-hmtx-table.hh | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) commit 5f995db10381172ec63fd7ffbb0acf2c6b3dae5e Author: Kal Conley Date: Fri Feb 26 00:36:17 2016 +0100 Fix missing ICU #include Fix compile error in hb-icu.cc when ICU configured with U_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 src/hb-icu.cc | 1 + 1 file changed, 1 insertion(+) commit b424b6c372dfe4c0ed75a49761eb34a416819446 Author: Kal Conley Date: Fri Feb 26 00:35:15 2016 +0100 Add --with-icu=builtin configure option configure.ac | 33 +++++++++++++++++++-------------- src/Makefile.am | 7 +++++++ 2 files changed, 26 insertions(+), 14 deletions(-) commit 71248a843f976c86022eb5bb8c6e8880b2499937 Author: Konstantin Ritt Date: Thu Feb 25 18:55:28 2016 +0400 Fix build with HB_DISABLE_DEPRECATED When HB_DISABLE_DEPRECATED is defined, no code from hb-deprecated.h should be used, even from within HB itself. src/hb-font.cc | 4 ++++ 1 file changed, 4 insertions(+) commit 0c7fb7419c20d04b803412945565562c32b42929 Author: Behdad Esfahbod Date: Thu Feb 25 14:40:09 2016 +0900 Speed up buffer variable allocation sanity check This makes defining HB_NDEBUG much less relevant, to the point of irrelevance. Sorry about all the fuss in previous release! src/hb-buffer-private.hh | 67 ++++++++++++++++++++++++++++----------------- src/hb-buffer.cc | 70 ------------------------------------------------ 2 files changed, 43 insertions(+), 94 deletions(-) commit 91dd11565221bdb108c138662ea013aac14bb968 Author: Behdad Esfahbod Date: Thu Feb 25 13:56:47 2016 +0900 Add HB_NDEBUG API changes: - If NDEBUG is defined, define HB_NDEBUG - Disable costlier sanity checks if HB_NDEBUG is defined. In 1.2.3 introduced some code to disable costly sanity checks if NDEBUG is defined. NDEBUG, however, disables all assert()s as well. With HB_NDEBUG, one can disable costlier checks but keep assert()s. I'll probably add a way to define HB_NDEBUG automatically in release tarballs. But for now, production systems that do NOT define NDEBUG, are encouraged to define HB_NDEBUG for our build. src/Makefile.am | 2 +- src/hb-buffer-private.hh | 4 ++-- src/hb-buffer.cc | 4 ++-- src/hb-private.hh | 9 +++++++++ 4 files changed, 14 insertions(+), 5 deletions(-) commit 75568b0a7f811ea18e23037735ec8541a7431f88 Author: Behdad Esfahbod Date: Thu Feb 25 12:26:26 2016 +0900 1.2.3 NEWS | 42 ++++++++++++++++++++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 43 insertions(+), 1 deletion(-) commit 988165021f8d48dc7120b071d056491256569f4f Author: Behdad Esfahbod Date: Thu Feb 25 12:23:02 2016 +0900 Disable internal buffer variable bookkeeping in NDEBUG builds Saves some sweet time and binary size! src/Makefile.am | 1 + src/hb-buffer-private.hh | 30 ++++++++++++++++++++---------- src/hb-buffer.cc | 6 ++++-- 3 files changed, 25 insertions(+), 12 deletions(-) commit 94dd0bb7e78125994cb7c833a5b03110f1ffc822 Author: Behdad Esfahbod Date: Thu Feb 25 11:31:03 2016 +0900 Add blacklist signature for Times New Roman (Bold) Italic on OS X src/hb-ot-layout.cc | 2 ++ 1 file changed, 2 insertions(+) commit dd8598c1c7f29fc92253b0cd4e856c1941b1d0c0 Author: Behdad Esfahbod Date: Thu Feb 25 11:20:05 2016 +0900 [test] Pass closure to hb_font_set_glyph_func() Exercises fix in c335fd7986fe360ab8e1c032c9b988d0d30511eb test/api/test-shape.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e23cf902e91142a10229e3514be4ceee69efde04 Author: Behdad Esfahbod Date: Thu Feb 25 11:11:15 2016 +0900 Blacklist GDEF table of timesi.ttf and timesbi.ttf on Win 7 See discussion: https://lists.freedesktop.org/archives/harfbuzz/2016-February/005489.html src/hb-ot-layout.cc | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) commit c335fd7986fe360ab8e1c032c9b988d0d30511eb Author: Behdad Esfahbod Date: Thu Feb 25 09:16:05 2016 +0900 In trampoline implementation of get_glyph(), don't destroy user data twice! src/hb-font.cc | 41 +++++++++++++++++++++++++++-------------- 1 file changed, 27 insertions(+), 14 deletions(-) commit 23335deaad9d4d9824ff41343264514d3f9f7e37 Author: Behdad Esfahbod Date: Wed Feb 24 20:27:13 2016 +0900 [ot-font] Accelerate cmap format4 get_glyph src/hb-ot-cmap-table.hh | 111 ++++++++++++++++++++++++++++-------------------- src/hb-ot-font.cc | 14 +++++- 2 files changed, 77 insertions(+), 48 deletions(-) commit e0f16a715bc3e621ff21a8be88102e9672630574 Author: Behdad Esfahbod Date: Wed Feb 24 19:52:36 2016 +0900 [ot-font] Towards accelerating get_glyph() src/hb-ot-font.cc | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) commit 5473ebfb84c7b6059ac16e04676b363acc51aa00 Author: Behdad Esfahbod Date: Wed Feb 24 19:32:43 2016 +0900 [ot-font] Remove level of indirection in get_glyph_variant src/hb-ot-cmap-table.hh | 14 ++------------ src/hb-ot-font.cc | 13 +++++++++---- 2 files changed, 11 insertions(+), 16 deletions(-) commit 49fe6ecf19522413e79a11a29aa0ffc5bdfcd2f8 Author: Behdad Esfahbod Date: Wed Feb 24 19:10:06 2016 +0900 [TODO] Update This file is rather obsolete. Still, give it a refresh. TODO | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) commit 8b5bc141cd3a6bfcea3c91a882a630426876ceb3 Author: Behdad Esfahbod Date: Wed Feb 24 19:05:23 2016 +0900 Add get_nominal_glyph() and get_variation_glyph() instead of get_glyph() New API: - hb_font_get_nominal_glyph_func_t - hb_font_get_variation_glyph_func_t - hb_font_funcs_set_nominal_glyph_func() - hb_font_funcs_set_variation_glyph_func() - hb_font_get_nominal_glyph() - hb_font_get_variation_glyph() Deprecated API: - hb_font_get_glyph_func_t - hb_font_funcs_set_glyph_func() Clients that implement their own font-funcs are encouraged to replace their get_glyph() implementation with a get_nominal_glyph() and get_variation_glyph() pair. The variation version can assume that variation_selector argument is not zero. src/hb-deprecated.h | 10 ++ src/hb-fallback-shape.cc | 4 +- src/hb-font-private.hh | 26 +++-- src/hb-font.cc | 203 ++++++++++++++++++++++++++++++++++--- src/hb-font.h | 55 +++++++--- src/hb-ft.cc | 38 ++++--- src/hb-ot-font.cc | 57 +++++++---- src/hb-ot-shape-complex-indic.cc | 8 +- src/hb-ot-shape-complex-myanmar.cc | 2 +- src/hb-ot-shape-complex-use.cc | 2 +- src/hb-ot-shape-fallback.cc | 6 +- src/hb-ot-shape-normalize.cc | 18 ++-- src/hb-ot-shape.cc | 6 +- 13 files changed, 344 insertions(+), 91 deletions(-) commit b30a971bf792b9c683c345e1be25c5a5869a113c Author: Behdad Esfahbod Date: Wed Feb 24 17:32:22 2016 +0900 1.2.2 NEWS | 14 +++++++++++++- configure.ac | 2 +- 2 files changed, 14 insertions(+), 2 deletions(-) commit af48e3d27c01c538f46f1dc376d994a0c24a8170 Author: Behdad Esfahbod Date: Wed Feb 24 16:06:40 2016 +0900 Fix recent test Not sure why the FT functions were returning advance 1024. This caused failure on drone.io. Switch to hb-ot-font and disable glyph names. test/shaping/tests/cursive-positioning.tests | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 17c831701756bb46300c412fd64b19d67f299c18 Author: Behdad Esfahbod Date: Wed Feb 24 16:06:23 2016 +0900 [tests] Fix for multiple options in test runner scripts test/shaping/run-tests.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit ebd7431f824c718db6ce5b85e94f2b3911127af4 Author: Behdad Esfahbod Date: Wed Feb 24 15:53:40 2016 +0900 Partially revert 86c68c7a2c971efe8e35b1f1bd99401dc8b688d2 That commit moved the advance adjustment for mark positioning to be applied immediately, instead of doing late before. This breaks if mark advances are zeroed late, like in Arabic. Also, easier to hit it in RTL scripts since a single mark with non-zero advance is enough to hit the bug, whereas in LTR, at least two marks are needed. This reopens https://github.com/behdad/harfbuzz/issues/211 The cursive+mark interaction is broken again. To be fixed in a different way. src/hb-ot-layout-gpos-table.hh | 28 ++++++++++++---------------- test/shaping/tests/cursive-positioning.tests | 2 +- 2 files changed, 13 insertions(+), 17 deletions(-) commit 284481b3120963353f5f34ed094f07ffc13480ef Author: Behdad Esfahbod Date: Wed Feb 24 15:52:37 2016 +0900 Add test for mark positioning in rtl with non-zero mark advance Apparently I broke this 86c68c7a2c971efe8e35b1f1bd99401dc8b688d2. Fix coming. .../sha1sum/07f054357ff8638bac3711b422a1e31180bba863.ttf | Bin 0 -> 848 bytes test/shaping/tests/cursive-positioning.tests | 1 + 2 files changed, 1 insertion(+) commit 56a84e8dd18c63782b8db3a86e94651dae5bb01b Author: Behdad Esfahbod Date: Wed Feb 24 15:50:33 2016 +0900 [tests] Allow commenting out tests to be skipped test/shaping/run-tests.sh | 4 ++++ 1 file changed, 4 insertions(+) commit 7cfd6cc486f2751d7f78c5008a636d677af4e12f Author: Behdad Esfahbod Date: Wed Feb 24 12:30:57 2016 +0900 [Android.mk] Update with warning flags Android.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit dabf32a5ad706726412ba5c64e1ea614a707b928 Author: Behdad Esfahbod Date: Tue Feb 23 15:38:43 2016 +0900 1.2.1 NEWS | 13 +++++++++++++ configure.ac | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) commit 525cc7d28cbe4e8149ddba677224f134dc0a3274 Author: Behdad Esfahbod Date: Tue Feb 23 15:19:27 2016 +0900 Add note re only adding tests with Free Software fonts test/shaping/README.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 6a09d7e34b949f9929f616ee53278b2edfd9b7ea Author: Behdad Esfahbod Date: Tue Feb 23 13:47:16 2016 +0900 [test] Add README about how to add shaping tests test/shaping/Makefile.am | 1 + test/shaping/README.md | 37 +++++++++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+) commit f8ee7906d0454d950081c621f2b04a6d08e1b92f Author: Behdad Esfahbod Date: Tue Feb 23 13:45:38 2016 +0900 Remove MANIFEST files They are unused currently. We can add later if we hook them up to anything useful. test/shaping/fonts/sha1sum/MANIFEST | 52 ---------------------- test/shaping/tests/MANIFEST | 19 -------- test/shaping/texts/MANIFEST | 1 - test/shaping/texts/in-tree/MANIFEST | 9 ---- test/shaping/texts/in-tree/shaper-arabic/MANIFEST | 6 --- .../in-tree/shaper-arabic/script-arabic/MANIFEST | 3 -- .../script-arabic/language-persian/MANIFEST | 1 - .../script-arabic/language-urdu/MANIFEST | 1 - .../script-arabic/language-urdu/crulp/MANIFEST | 1 - .../language-urdu/crulp/ligatures/MANIFEST | 7 --- .../shaper-arabic/script-arabic/misc/MANIFEST | 1 - .../script-arabic/misc/diacritics/MANIFEST | 7 --- .../in-tree/shaper-arabic/script-mandaic/MANIFEST | 1 - .../shaper-arabic/script-mandaic/misc/MANIFEST | 0 .../shaper-arabic/script-mongolian/MANIFEST | 1 - .../shaper-arabic/script-mongolian/misc/MANIFEST | 4 -- .../in-tree/shaper-arabic/script-nko/MANIFEST | 1 - .../in-tree/shaper-arabic/script-nko/misc/MANIFEST | 1 - .../in-tree/shaper-arabic/script-phags-pa/MANIFEST | 1 - .../shaper-arabic/script-phags-pa/misc/MANIFEST | 1 - .../in-tree/shaper-arabic/script-syriac/MANIFEST | 1 - .../shaper-arabic/script-syriac/misc/MANIFEST | 2 - test/shaping/texts/in-tree/shaper-default/MANIFEST | 5 --- .../shaper-default/script-ethiopic/MANIFEST | 1 - .../shaper-default/script-ethiopic/misc/MANIFEST | 1 - .../in-tree/shaper-default/script-han/MANIFEST | 1 - .../shaper-default/script-han/misc/MANIFEST | 1 - .../shaper-default/script-hiragana/MANIFEST | 1 - .../shaper-default/script-hiragana/misc/MANIFEST | 2 - .../shaper-default/script-linear-b/MANIFEST | 1 - .../shaper-default/script-linear-b/misc/MANIFEST | 1 - .../shaper-default/script-tifinagh/MANIFEST | 1 - .../shaper-default/script-tifinagh/misc/MANIFEST | 1 - test/shaping/texts/in-tree/shaper-hangul/MANIFEST | 1 - .../in-tree/shaper-hangul/script-hangul/MANIFEST | 1 - .../shaper-hangul/script-hangul/misc/MANIFEST | 1 - test/shaping/texts/in-tree/shaper-hebrew/MANIFEST | 1 - .../in-tree/shaper-hebrew/script-hebrew/MANIFEST | 1 - .../shaper-hebrew/script-hebrew/misc/MANIFEST | 1 - test/shaping/texts/in-tree/shaper-indic/MANIFEST | 2 - .../texts/in-tree/shaper-indic/indic/MANIFEST | 11 ----- .../shaper-indic/indic/script-assamese/MANIFEST | 2 - .../indic/script-assamese/misc/MANIFEST | 0 .../indic/script-assamese/utrrs/MANIFEST | 3 -- .../indic/script-assamese/utrrs/codepoint/MANIFEST | 7 --- .../indic/script-assamese/utrrs/gpos/MANIFEST | 2 - .../indic/script-assamese/utrrs/gsub/MANIFEST | 1 - .../shaper-indic/indic/script-bengali/MANIFEST | 2 - .../indic/script-bengali/misc/MANIFEST | 2 - .../indic/script-bengali/utrrs/MANIFEST | 3 -- .../indic/script-bengali/utrrs/codepoint/MANIFEST | 7 --- .../indic/script-bengali/utrrs/gpos/MANIFEST | 2 - .../indic/script-bengali/utrrs/gsub/MANIFEST | 1 - .../shaper-indic/indic/script-devanagari/MANIFEST | 2 - .../indic/script-devanagari/misc/MANIFEST | 6 --- .../indic/script-devanagari/utrrs/MANIFEST | 3 -- .../script-devanagari/utrrs/codepoint/MANIFEST | 9 ---- .../indic/script-devanagari/utrrs/gpos/MANIFEST | 2 - .../indic/script-devanagari/utrrs/gsub/MANIFEST | 1 - .../shaper-indic/indic/script-gujarati/MANIFEST | 2 - .../indic/script-gujarati/misc/MANIFEST | 0 .../indic/script-gujarati/utrrs/MANIFEST | 3 -- .../indic/script-gujarati/utrrs/codepoint/MANIFEST | 7 --- .../indic/script-gujarati/utrrs/gpos/MANIFEST | 2 - .../indic/script-gujarati/utrrs/gsub/MANIFEST | 1 - .../shaper-indic/indic/script-gurmukhi/MANIFEST | 2 - .../indic/script-gurmukhi/misc/MANIFEST | 1 - .../indic/script-gurmukhi/utrrs/MANIFEST | 3 -- .../indic/script-gurmukhi/utrrs/codepoint/MANIFEST | 7 --- .../indic/script-gurmukhi/utrrs/gpos/MANIFEST | 2 - .../indic/script-gurmukhi/utrrs/gsub/MANIFEST | 1 - .../shaper-indic/indic/script-kannada/MANIFEST | 2 - .../indic/script-kannada/misc/MANIFEST | 2 - .../indic/script-kannada/utrrs/MANIFEST | 3 -- .../indic/script-kannada/utrrs/codepoint/MANIFEST | 8 ---- .../indic/script-kannada/utrrs/gpos/MANIFEST | 1 - .../indic/script-kannada/utrrs/gsub/MANIFEST | 1 - .../shaper-indic/indic/script-malayalam/MANIFEST | 2 - .../indic/script-malayalam/misc/MANIFEST | 3 -- .../indic/script-malayalam/utrrs/MANIFEST | 2 - .../script-malayalam/utrrs/codepoint/MANIFEST | 7 --- .../indic/script-malayalam/utrrs/gsub/MANIFEST | 1 - .../shaper-indic/indic/script-oriya/MANIFEST | 2 - .../shaper-indic/indic/script-oriya/misc/MANIFEST | 2 - .../shaper-indic/indic/script-oriya/utrrs/MANIFEST | 2 - .../indic/script-oriya/utrrs/codepoint/MANIFEST | 9 ---- .../indic/script-oriya/utrrs/gsub/MANIFEST | 1 - .../shaper-indic/indic/script-sinhala/MANIFEST | 2 - .../indic/script-sinhala/misc/MANIFEST | 4 -- .../indic/script-sinhala/utrrs/MANIFEST | 3 -- .../indic/script-sinhala/utrrs/codepoint/MANIFEST | 5 --- .../indic/script-sinhala/utrrs/gpos/MANIFEST | 1 - .../indic/script-sinhala/utrrs/gsub/MANIFEST | 7 --- .../shaper-indic/indic/script-tamil/MANIFEST | 2 - .../shaper-indic/indic/script-tamil/misc/MANIFEST | 1 - .../shaper-indic/indic/script-tamil/utrrs/MANIFEST | 3 -- .../indic/script-tamil/utrrs/codepoint/MANIFEST | 10 ----- .../indic/script-tamil/utrrs/gpos/MANIFEST | 2 - .../indic/script-tamil/utrrs/gsub/MANIFEST | 1 - .../shaper-indic/indic/script-telugu/MANIFEST | 2 - .../shaper-indic/indic/script-telugu/misc/MANIFEST | 1 - .../indic/script-telugu/utrrs/MANIFEST | 3 -- .../indic/script-telugu/utrrs/codepoint/MANIFEST | 7 --- .../indic/script-telugu/utrrs/gpos/MANIFEST | 1 - .../indic/script-telugu/utrrs/gsub/MANIFEST | 1 - .../in-tree/shaper-indic/south-east-asian/MANIFEST | 1 - .../south-east-asian/script-khmer/MANIFEST | 1 - .../south-east-asian/script-khmer/misc/MANIFEST | 3 -- test/shaping/texts/in-tree/shaper-myanmar/MANIFEST | 1 - .../in-tree/shaper-myanmar/script-myanmar/MANIFEST | 1 - .../shaper-myanmar/script-myanmar/misc/MANIFEST | 3 -- test/shaping/texts/in-tree/shaper-thai/MANIFEST | 2 - .../texts/in-tree/shaper-thai/script-lao/MANIFEST | 1 - .../in-tree/shaper-thai/script-lao/misc/MANIFEST | 1 - .../texts/in-tree/shaper-thai/script-thai/MANIFEST | 1 - .../in-tree/shaper-thai/script-thai/misc/MANIFEST | 4 -- test/shaping/texts/in-tree/shaper-tibetan/MANIFEST | 1 - .../in-tree/shaper-tibetan/script-tibetan/MANIFEST | 1 - .../shaper-tibetan/script-tibetan/misc/MANIFEST | 1 - test/shaping/texts/in-tree/shaper-use/MANIFEST | 6 --- .../texts/in-tree/shaper-use/script-batak/MANIFEST | 1 - .../in-tree/shaper-use/script-buginese/MANIFEST | 1 - .../texts/in-tree/shaper-use/script-cham/MANIFEST | 1 - .../in-tree/shaper-use/script-kaithi/MANIFEST | 1 - .../in-tree/shaper-use/script-kharoshti/MANIFEST | 1 - .../in-tree/shaper-use/script-tai-tham/MANIFEST | 2 - 126 files changed, 381 deletions(-) commit 815bdd7700155efcffa9a4c3ca5bfc31833d0586 Author: Behdad Esfahbod Date: Mon Feb 22 18:22:44 2016 +0900 In cluster-level=0, group ZWJ/ZWNJ with previous cluster This better emulates Unicode grapheme clusters. Note that Uniscribe does NOT do this, but should be harmless with most clients, and improve fallback with clients that use HarfBuzz cluster as unit of fallback. Fixes https://github.com/behdad/harfbuzz/issues/217 src/hb-ot-layout-private.hh | 6 ++++++ src/hb-ot-shape.cc | 3 ++- test/shaping/tests/indic-joiner-candrabindu.tests | 2 +- test/shaping/tests/mongolian-variation-selector.tests | 2 +- 4 files changed, 10 insertions(+), 3 deletions(-) commit 89137e325a19d62fb00979e1e8ab2ca59a2c1147 Author: Behdad Esfahbod Date: Mon Feb 22 16:00:59 2016 +0900 Minor src/hb-coretext.cc | 2 +- src/hb-ot-shape.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 15063b12f7619d4f44981248e28f38c172d12e1f Author: Behdad Esfahbod Date: Mon Feb 22 15:56:29 2016 +0900 [coretext] Move CTFont construction to face_data src/hb-coretext.cc | 66 +++++++++++++++++++++++++----------------------------- 1 file changed, 30 insertions(+), 36 deletions(-) commit ba3d49d9a56932d341bf1916a30f322be665e3a6 Author: Behdad Esfahbod Date: Mon Feb 22 15:50:12 2016 +0900 [coretext] Move code around src/hb-coretext.cc | 70 +++++++++++++++++++++++++++++++----------------------- 1 file changed, 40 insertions(+), 30 deletions(-) commit 90194efb8480d58c55b7a19962624c7aadbdca63 Author: Behdad Esfahbod Date: Mon Feb 22 15:42:53 2016 +0900 [coretext] Move code around src/hb-coretext.cc | 46 ++++++++++++++++++++++++++-------------------- 1 file changed, 26 insertions(+), 20 deletions(-) commit ca539e37a4b71e585a267a288db1a3975cbb99fc Author: Behdad Esfahbod Date: Mon Feb 22 15:37:18 2016 +0900 [build] git.mk fix for m4/gtk-doc.m4 Makefile.am | 1 + 1 file changed, 1 insertion(+) commit 54788cb1ecc5a5ffd63d07cd1f0b07b2afa9a8ca Author: Behdad Esfahbod Date: Mon Feb 22 15:32:52 2016 +0900 [win32] Install git.mk win32/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) commit 9a13ed453ef96822a47d6e6f58332b87f38d5c59 Author: Behdad Esfahbod Date: Mon Feb 22 11:44:45 2016 +0900 Make FixedVersion a template src/hb-open-file-private.hh | 4 ++-- src/hb-open-type-private.hh | 9 +++++---- src/hb-ot-head-table.hh | 4 ++-- src/hb-ot-hhea-table.hh | 2 +- src/hb-ot-layout-gdef-table.hh | 2 +- src/hb-ot-layout-gsubgpos-private.hh | 2 +- src/hb-ot-layout-jstf-table.hh | 2 +- src/hb-ot-maxp-table.hh | 2 +- 8 files changed, 14 insertions(+), 13 deletions(-) commit 238b943e850ea1ab0093e12c74d2cd7c686f318e Author: Behdad Esfahbod Date: Mon Feb 22 15:31:22 2016 +0900 [coretext] Fix leak! src/hb-coretext.cc | 1 + 1 file changed, 1 insertion(+) commit e561122856a50ed405d71cb1629317e7ae63f316 Author: Behdad Esfahbod Date: Mon Feb 22 15:28:37 2016 +0900 [coretext] Move code around src/hb-coretext.cc | 109 ++++++++++++++++++++++++++++++----------------------- 1 file changed, 62 insertions(+), 47 deletions(-) commit 04c64431530a4a6d9ebd33674c4665a8e6d25bdd Author: Behdad Esfahbod Date: Mon Feb 22 15:12:27 2016 +0900 [coretext] Ignore PPEM in font size selection src/hb-coretext.cc | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) commit 62c2711121fe78f373c15c0f53090b62b52d11c1 Author: Behdad Esfahbod Date: Mon Feb 22 15:07:20 2016 +0900 [coretext] Limit grapheme-cluster forming to cluster-level=0 src/hb-coretext.cc | 1 + src/hb-ot-shape.cc | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) commit 061105ec443eb7350ffe217305f9d8902c179e2f Author: Behdad Esfahbod Date: Mon Feb 22 14:59:39 2016 +0900 [coretext] Fix shaping with varying font size Fixes https://github.com/libass/libass/issues/212 src/hb-coretext.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 27847cab1264b4ce8342603f4626b4e0645979e4 Author: Behdad Esfahbod Date: Fri Feb 19 15:56:50 2016 +0700 1.2.0 NEWS | 20 ++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 21 insertions(+), 1 deletion(-) commit c3731559042e1730e85d19574321ad850010f7de Author: Behdad Esfahbod Date: Fri Feb 19 15:13:07 2016 +0700 [fuzzing] Add test for recent fix Test from https://github.com/behdad/harfbuzz/issues/223 I forgot that we do run hb-fuzzer on tests in shaping/tests/fuzzed.tests. .../sha1sum/205edd09bd3d141cc9580f650109556cc28b22cb.ttf | Bin 0 -> 1966 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 + test/shaping/tests/fuzzed.tests | 1 + 3 files changed, 2 insertions(+) commit aa33cb72ab29c31e87f0cca9a0e72fe3a68247b7 Author: Behdad Esfahbod Date: Fri Feb 19 15:12:24 2016 +0700 [fuzzing] Make test runner actually work test/fuzzing/Makefile.am | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 2735555c6b0c95db7dfc2b391f92a1a5c06084c4 Author: Behdad Esfahbod Date: Fri Feb 19 15:12:16 2016 +0700 [fuzzing] Add TODO item test/fuzzing/hb-fuzzer.cc | 1 + 1 file changed, 1 insertion(+) commit b87e36f6f119fac80b8fd55f3abae563c2c5b798 Author: Behdad Esfahbod Date: Fri Feb 19 14:52:31 2016 +0700 Avoid buffer->move_to() in case of buffer error Fixes https://github.com/behdad/harfbuzz/issues/223 Right now we cannot test this because it has to be tested using hb-fuzzer. We should move all fuzzing tests from test/shaping/tests/fuzzed.tests to test/fuzzing/ and have its own test runner. At that point, should add test from this issue as well. src/hb-buffer.cc | 2 ++ src/hb-ot-layout-gsubgpos-private.hh | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) commit 7e76bbabbaa56af314abff8ddba8866c634919cd Author: Behdad Esfahbod Date: Fri Feb 19 14:43:39 2016 +0700 [fuzzing] Make "make hb-fuzzer" build lib dependency Not going to do with util/, but is convenient here. test/fuzzing/Makefile.am | 3 +++ 1 file changed, 3 insertions(+) commit 568a0c60e8695a6ad8a93ec60d55b137c48890cb Author: Behdad Esfahbod Date: Thu Feb 18 19:31:51 2016 +0700 Remove pointless overflow check in pointer math Fixes https://github.com/behdad/harfbuzz/issues/227 src/hb-blob.cc | 1 - 1 file changed, 1 deletion(-) commit aae2847099cbf05bf0668fbe526fc58736837c1b Author: Behdad Esfahbod Date: Thu Feb 18 17:06:25 2016 +0700 Emoji skin tone modifiers need to be treated as combining marks Fixes https://github.com/behdad/harfbuzz/issues/169 src/hb-ot-layout-private.hh | 15 ++++++++++++++- src/hb-unicode-private.hh | 5 +++-- 2 files changed, 17 insertions(+), 3 deletions(-) commit da41e48f0a1a6af6d44ef25185d2421a29bd4166 Author: Behdad Esfahbod Date: Tue Feb 16 17:16:33 2016 +0700 [USE] Zero mark advances by GDEF early This is what Microsoft's implementation does. Marks that need advance need to add it back using 'dist' or other feature in GPOS. Update tests to match. src/hb-ot-shape-complex-use.cc | 2 +- test/shaping/fonts/sha1sum/MANIFEST | 1 + .../sha1sum/f518eb6f6b5eec2946c9fbbbde44e45d46f5e2ac.ttf | Bin 0 -> 1356 bytes test/shaping/tests/context-matching.tests | 2 +- test/shaping/tests/use.tests | 2 ++ 5 files changed, 5 insertions(+), 2 deletions(-) commit 86c68c7a2c971efe8e35b1f1bd99401dc8b688d2 Author: Behdad Esfahbod Date: Tue Feb 16 16:07:20 2016 +0700 [GPOS] Fix interaction of mark attachments and cursive chaining Fixes https://github.com/behdad/harfbuzz/issues/211 What happens in that bug is that a mark is attached to base first, then a second mark is cursive-chained to the first mark. This only "works" because it's in the Indic shaper where mark advances are not zeroed. Before, we didn't allow cursive to run on marks at all. Fix that. We also where updating mark major offsets at the end of GPOS, such that changes in advance of base will not change the mark attachment position. That was superior to the alternative (which is what Uniscribe does BTW), but made it hard to apply cursive to the mark after it was positioned. We could track major-direction offset changes and apply that to cursive in the post process, but that's a much trickier thing to do than the fix here, which is to immediately apply the major-direction advance-width offsets... Ie.: https://github.com/behdad/harfbuzz/issues/211#issuecomment-183194739 If this breaks any fonts, the font should be fixed to do mark attachment after all the advances are set up first (kerning, etc). Finally, this, still doesn't make us match Uniscribe, for I explained in that bug. Looks like Uniscribe applies minor-direction cursive adjustment immediate as well. We don't, and we like it our way, at least for now. Eg. the sequence in the test case does this: - The first subscript attaches with mark-to-base, moving in x only, - The second subscript attaches with cursive attachment to first subscript moving in x only, - A final context rule moves the first subscript up by 104 units. The way we do, the final shift-up, also shifts up the second subscript mark because it's cursively-attached. Uniscribe doesn't. We get: [ttaorya=0+1307|casubscriptorya=0@-242,104+-231|casubscriptnarroworya=0@20,104+507] while Uniscribe gets: [ttaorya=0+1307|casubscriptorya=0@-242,104+-211|casubscriptnarroworya=0+487] note the different y-offset of the last glyph. In our view, after cursive, things move together, period. src/hb-ot-layout-gpos-table.hh | 31 +++++++++++---------- .../706c5d7b625f207bc0d874c67237aad6f1e9cd6f.ttf | Bin 0 -> 3868 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 + test/shaping/tests/cursive-positioning.tests | 1 + 4 files changed, 18 insertions(+), 15 deletions(-) commit 80c8855cfeffa028d74a25df884d0e5577c95c6c Author: Behdad Esfahbod Date: Fri Feb 12 12:50:17 2016 +0700 Minor src/hb-common.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6ab920224c32e38072a0bec5e84d4b0d58b74167 Author: Behdad Esfahbod Date: Thu Feb 11 16:57:52 2016 +0700 [GPOS] Minor No effect. src/hb-ot-layout-gpos-table.hh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit cbc3a76c5a38ab24f72e80357377711bd3f54d56 Author: Behdad Esfahbod Date: Thu Feb 11 16:48:13 2016 +0700 [GPOS] Merge fixing of offsets for cursive and mark attachments Part of fixing https://github.com/behdad/harfbuzz/issues/211 src/hb-buffer-private.hh | 3 +- src/hb-ot-layout-gpos-table.hh | 73 ++++++++++++++++++------------------------ 2 files changed, 33 insertions(+), 43 deletions(-) commit 7d8d58ac81fe267e29ea68cdc6f4a4fa8c22d40f Author: Behdad Esfahbod Date: Thu Feb 11 16:34:28 2016 +0700 [GPOS] Divide position_finish() into two phases, for advances and offsets Right now the position_finish_advances() is empty. To be used for spacing attachments proposal later. src/hb-ot-layout-gpos-table.hh | 11 +++++++++-- src/hb-ot-layout-gsub-table.hh | 6 ------ src/hb-ot-layout-private.hh | 19 +++++++++---------- src/hb-ot-layout.cc | 16 ++++++++-------- src/hb-ot-shape.cc | 7 +++---- 5 files changed, 29 insertions(+), 30 deletions(-) commit 8474231567a08873cc5e0aa08fea60316a04c27e Author: Behdad Esfahbod Date: Thu Feb 11 16:27:41 2016 +0700 [ot] Minor shuffling code around src/hb-ot-layout-gpos-table.hh | 2 -- src/hb-ot-shape.cc | 13 ++++++++----- 2 files changed, 8 insertions(+), 7 deletions(-) commit b0b11614e9fb9ecd1faae28b0ed71ac6bf5c1266 Author: Behdad Esfahbod Date: Thu Feb 11 15:28:55 2016 +0700 [GPOS] Add harmless recursion in fix_mark_attachment() Will do nothing. Just useful for merging two functions. src/hb-ot-layout-gpos-table.hh | 2 ++ 1 file changed, 2 insertions(+) commit 686567baab5a32ffea843538643e01de2885fa4f Author: Behdad Esfahbod Date: Thu Feb 11 15:25:28 2016 +0700 [GPOS] Merge attach_chain() and cursive_chain() Differentiate, using new attach_type(). src/hb-ot-layout-gpos-table.hh | 50 +++++++++++++++++++++++++++--------------- 1 file changed, 32 insertions(+), 18 deletions(-) commit 806ad8dc65931ab7893bff7d5592a67a9bd237ca Author: Behdad Esfahbod Date: Thu Feb 11 14:53:11 2016 +0700 [GPOS] Minor shuffling src/hb-ot-layout-gpos-table.hh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit 0f6278d1fbb75856132f1fa2d29648979f033316 Author: Behdad Esfahbod Date: Thu Feb 11 14:49:10 2016 +0700 [GPOS] Negate sign of attach_lookback(), and rename it to attach_chain() No behavior change. Preparing to unify how cursive and mark attachments work. src/hb-ot-layout-gpos-table.hh | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) commit 5b5dc2c0406d8180e72d97a54334c722fda325b1 Author: Behdad Esfahbod Date: Thu Feb 11 12:15:38 2016 +0700 [tests] Add test for advance zeroing of an ASCII letter marked as mark in GDEF test/shaping/fonts/sha1sum/MANIFEST | 1 + .../sha1sum/a98e908e2ed21b22228ea59ebcc0f05034c86f2e.ttf | Bin 0 -> 1016 bytes test/shaping/tests/zero-width-marks.tests | 1 + 3 files changed, 2 insertions(+) commit 660c9d3fc21172e8dc340b017122c084dac6334c Author: Behdad Esfahbod Date: Thu Feb 11 12:14:27 2016 +0700 Remove font-dependent ASCII-only perf hack Is confusing. I already hit it myself. Remove. We can optimize ASCII based on Unicode properties. But should not do based on assumptions on the font. src/hb-ot-shape.cc | 4 ---- 1 file changed, 4 deletions(-) commit 3fe0cf10401875f1e9b8b5fbaf59826e64ea61d2 Author: Behdad Esfahbod Date: Wed Feb 10 18:43:43 2016 +0700 Fix previous commit! test/shaping/fonts/sha1sum/MANIFEST | 6 +++--- test/shaping/tests/zero-width-marks.tests | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) commit 293a210eee0a53b59f4b33298f42ec6e59d785e0 Author: Behdad Esfahbod Date: Wed Feb 10 18:39:59 2016 +0700 [tests] Fix fonts in cc4a78bf22c4a735b84c89b04be3bb531f42135e They had an invalid LookupFlag (32). .../sha1sum/0dd3a51c3ea50997cb1f72515d1060408f8b4b59.ttf | Bin 1412 -> 0 bytes .../sha1sum/56cfd0e18d07f41c38e9598545a6d369127fc6f9.ttf | Bin 0 -> 1412 bytes .../sha1sum/828114d00931885bc25abf7cdb878b2914a2e743.ttf | Bin 1448 -> 0 bytes .../sha1sum/894e96a367f00c196d82e6243673a1d4414f4f6a.ttf | Bin 1448 -> 0 bytes .../sha1sum/cc5f3d2d717fb6bd4dfae1c16d48a2cb8e12233b.ttf | Bin 0 -> 1448 bytes .../sha1sum/ffa0f5d2d9025486d8469d8b1fdd983e7632499b.ttf | Bin 0 -> 1448 bytes 6 files changed, 0 insertions(+), 0 deletions(-) commit eaadcbbc53e02838c847e53ef214a55d6915d677 Author: Behdad Esfahbod Date: Wed Feb 10 18:29:54 2016 +0700 Remove now-unused mark zeroing BY_UNICODE src/hb-ot-shape-complex-private.hh | 2 -- src/hb-ot-shape.cc | 29 ----------------------------- 2 files changed, 31 deletions(-) commit cc4a78bf22c4a735b84c89b04be3bb531f42135e Author: Behdad Esfahbod Date: Wed Feb 10 18:24:08 2016 +0700 [tests] Add tests for Latin mark zeroing .../sha1sum/0dd3a51c3ea50997cb1f72515d1060408f8b4b59.ttf | Bin 0 -> 1412 bytes .../sha1sum/828114d00931885bc25abf7cdb878b2914a2e743.ttf | Bin 0 -> 1448 bytes .../sha1sum/894e96a367f00c196d82e6243673a1d4414f4f6a.ttf | Bin 0 -> 1448 bytes test/shaping/fonts/sha1sum/MANIFEST | 4 ++++ .../sha1sum/fcdcffbdf1c4c97c05308d7600e4c283eb47dbca.ttf | Bin 0 -> 1344 bytes test/shaping/tests/zero-width-marks.tests | 4 ++++ 6 files changed, 8 insertions(+) commit 55ff34b9c157a839d026465af8f30424ce7f891b Author: Behdad Esfahbod Date: Wed Feb 10 18:20:02 2016 +0700 [tests] Add tests for Thai mark zeroing .../sha1sum/45855bc8d46332b39c4ab9e2ee1a26b1f896da6b.ttf | Bin 0 -> 1088 bytes .../sha1sum/7a37dc4d5bf018456aea291cee06daf004c0221c.ttf | Bin 0 -> 1080 bytes .../sha1sum/8099955657a54e9ee38a6ba1d6f950ce58e3cc25.ttf | Bin 0 -> 1024 bytes test/shaping/fonts/sha1sum/MANIFEST | 4 ++++ .../sha1sum/bb0c53752e85c3d28973ebc913287b8987d3dfe8.ttf | Bin 0 -> 976 bytes test/shaping/tests/zero-width-marks.tests | 4 ++++ 6 files changed, 8 insertions(+) commit b3582a8ee82942a931130a83b2867b239f8ca71a Author: Behdad Esfahbod Date: Wed Feb 10 18:10:15 2016 +0700 Change default mark advance zeroing behavior from Unicode to GDEF See thread at: https://lists.freedesktop.org/archives/harfbuzz/2016-February/005462.html src/hb-ot-shape-complex-default.cc | 2 +- src/hb-ot-shape-complex-thai.cc | 2 +- src/hb-ot-shape-complex-tibetan.cc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) commit 43bb2b8fb00705c3334730a58ade7984181018b2 Author: Behdad Esfahbod Date: Wed Feb 10 14:11:43 2016 +0700 Minor test/shaping/hb_test_tools.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bdaa784bb610ec65626d63cc068a0958ff5005fc Merge: a168db47 f6ffba63 Author: Behdad Esfahbod Date: Wed Feb 10 11:11:36 2016 +0700 Merge pull request #164 from fanc999/msvc.build Enable Build of HarfBuzz under Visual Studio using NMake Makefiles commit a168db4739148459bc33c7dae88e73efa0153d72 Author: Behdad Esfahbod Date: Wed Feb 10 11:10:08 2016 +0700 [README] Add ABI Tracker link README | 1 + 1 file changed, 1 insertion(+) commit f6ffba634bb33d6d4b051abce9c23fcae280c3fe Author: Chun-wei Fan Date: Wed Dec 9 14:57:15 2015 +0800 MSVC builds: Add support to build DirectWrite shaping backend Add into the NMake Makefiles to build the DirectWrite shaping backend, but as PR #134 mentions, this is considered to be in an experimental state, so don't include this in the build by default for now. This is most probably going to replace the Uniscribe backend eventually, since DirectWrite is meant to be Uniscribe's replacement, and is needed for Windows Store apps if a system shaping API is to be used. win32/README.txt | 4 ++++ win32/config-msvc.mak | 10 ++++++++++ win32/config.h.win32.in | 3 +++ win32/info-msvc.mak | 7 +++++++ 4 files changed, 24 insertions(+) commit c6792854557ca104948e8f0b142c9384105b0d05 Author: Chun-wei Fan Date: Wed Feb 3 18:31:23 2016 +0800 build: Build the DirectWrite sources if requested This adds to the autotools build system so that the (experimental) DirectWrite support for HarfBuzz is built (and dist'ed). configure.ac | 25 +++++++++++++++++++++++++ src/Makefile.am | 7 +++++++ src/Makefile.sources | 3 +++ 3 files changed, 35 insertions(+) commit d7b6636e5ebf1ddf7d7a04007ffbc411cf7e462e Author: Chun-wei Fan Date: Tue Nov 3 19:00:42 2015 +0800 build: Support Visual Studio builds using NMake This adds a set of NMake Makefiles that can be used to build HarfBuzz, from the standard basic build building the minimal HarfBuzz DLL (consisting of OpenType, fallback and Uniscribe support only), to a full fledged build consisting of GLib and FreeType support, as well as building the utilities, the test programs in src/ and test/api, and HarfBuzz-ICU and HarfBuzz-GObject, and up to building the introspection files. This means a flexible build mechanism is supported here, so anything that is supported for a Windows build (code-wise), should all be supported by this build system. As in an earlier commit, the source listings are shared with the autotools builds with the various Makefile.sources in src/, src/hb-ucdn and util/, and this set of NMake Makefiles will transform these lists into the form they want. In the current form, all the test programs in test/api pass, and this has been checked successfully with 'make -j8 distcheck'. BUILD.md | 4 +- Makefile.am | 2 +- configure.ac | 2 + win32/Makefile.am | 14 +++ win32/Makefile.vc | 52 +++++++++++ win32/README.txt | 75 ++++++++++++++++ win32/build-rules-msvc.mak | 140 ++++++++++++++++++++++++++++++ win32/config-msvc.mak | 188 ++++++++++++++++++++++++++++++++++++++++ win32/create-lists-msvc.mak | 151 ++++++++++++++++++++++++++++++++ win32/create-lists.bat | 42 +++++++++ win32/detectenv-msvc.mak | 136 +++++++++++++++++++++++++++++ win32/generate-msvc.mak | 26 ++++++ win32/hb-introspection-msvc.mak | 42 +++++++++ win32/info-msvc.mak | 130 +++++++++++++++++++++++++++ win32/install.mak | 29 +++++++ win32/introspection-msvc.mak | 73 ++++++++++++++++ 16 files changed, 1104 insertions(+), 2 deletions(-) commit 5c3e7260bcb4999b8b7cb9afb26e6eaff867634b Author: Chun-wei Fan Date: Tue Nov 3 18:52:46 2015 +0800 MSVC builds: Add a pre-configured config.h(.win32) template This adds a pre-configured config.h template that can be used for Visual Studio builds, where autotools is not normally available. This has the configs that are suitable for Visual Studio builds, as well as all the features used for Windows builds enabled (HAVE_OT, HAVE_FALLBACK and HAVE_UNISCRIBE). Note that the optional features are not enabled here, they are enabled by /D's (or -D's) in the NMake Makefiles as requested. win32/config.h.win32.in | 155 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 155 insertions(+) commit 35ded3af74a5bc4b038a07308354d5f7501ae3c7 Author: Chun-wei Fan Date: Tue Nov 3 16:56:27 2015 +0800 build: Move source listings into separate Makefile snippets This moves all the source listings in src/Makefile.am, src/hb-ucdn/Makefile.am and util/Makefile.am into separate Makefile snippets, so that they may be shared between different Makefile-based build systems, such as NMake for Visual Studio. src/Makefile.am | 165 +++++++++---------------------------------- src/Makefile.sources | 147 ++++++++++++++++++++++++++++++++++++++ src/hb-ucdn/Makefile.am | 6 +- src/hb-ucdn/Makefile.sources | 4 ++ util/Makefile.am | 34 ++------- util/Makefile.sources | 32 +++++++++ 6 files changed, 223 insertions(+), 165 deletions(-) commit b894a85ad1e7c3ecfb6d3732a7c9779f5462fe70 Author: Behdad Esfahbod Date: Tue Feb 2 16:39:19 2016 +0800 Fix more hangs in case of buffer allocation errors Hopefully fixes https://github.com/behdad/harfbuzz/issues/214 src/hb-ot-shape-complex-indic.cc | 2 +- src/hb-ot-shape-complex-myanmar.cc | 2 +- src/hb-ot-shape-complex-use.cc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) commit b693992ea160b66541f678dc9be29b513c77a30b Merge: 9a6a33cc 498574e6 Author: Behdad Esfahbod Date: Tue Feb 2 12:33:32 2016 +0800 Merge pull request #222 from n8willis/master Add usermanual chapter on cluster levels commit 498574e6c1a83bbd2768925af6e39806fe1ea8bb Author: n8willis Date: Thu Jan 28 12:21:32 2016 -0600 Update Makefile.am docs/Makefile.am | 1 + 1 file changed, 1 insertion(+) commit e12fc666994573dbabb6928a8b2e8698667088ce Author: n8willis Date: Thu Jan 28 12:14:12 2016 -0600 Added initial usermanual chapter on cluster levels. docs/harfbuzz-docs.xml | 1 + docs/usermanual-clusters.xml | 304 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 305 insertions(+) commit 9a6a33ccbea8a2e23e779bd955958fa41974c1c7 Merge: d05b7833 146fe252 Author: Behdad Esfahbod Date: Mon Jan 18 12:47:18 2016 +0100 Merge pull request #216 from mhosken/master Refactor graphite2 to make ovleraps into negative width spaces commit 146fe252c3ebd0253344ce20981554e40926497b Author: Martin Hosken Date: Sat Jan 16 17:24:00 2016 -0600 Refactor graphite2 to make ovleraps into negative width spaces src/hb-graphite2.cc | 71 ++++++++++++++++++++++++++++++++--------------------- 1 file changed, 43 insertions(+), 28 deletions(-) commit d05b783322d90208b2ddf06a5ebffc7c301be3d7 Author: Behdad Esfahbod Date: Tue Jan 12 16:17:21 2016 +0000 Fix compiler warning Fixes https://github.com/behdad/harfbuzz/issues/212 src/hb-ot-tag.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d163dc18e66c9e2f404d09310482464245cae704 Author: Behdad Esfahbod Date: Tue Jan 12 13:05:01 2016 +0000 Minor src/hb-ot-layout-common-private.hh | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) commit 505b7d4732c6a8c423f43c0de46e05dc583e82c0 Author: Behdad Esfahbod Date: Mon Jan 11 18:31:04 2016 +0000 [fuzzing] Fuzz input text Very rudimentary right now, but will get kcc's bot going. From https://github.com/behdad/harfbuzz/issues/139#issuecomment-163580783 test/fuzzing/hb-fuzzer.cc | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) commit 3e704521f67e021fb51cda7319925fd39eba4f97 Author: Behdad Esfahbod Date: Mon Jan 11 17:38:41 2016 +0000 [OT] Get list of lookup subtables once and loop through them This speeds up shaping the Amiri font by over 15%. This was primarily needed for my work on OpenType GX, since we will be collecting only sublookups that are "active" for current font instance; but it's a nice boost in general as well. We might, in the future, collect subtables in the lookup_accel. That would also allow us to do a per-subtbale set-digest, which should speed things up some more, specially for ContextChainFormat3 lookups... Amiri, for example, contains one lookup with 53 subtables! src/hb-ot-layout.cc | 120 +++++++++++++++++++++++++++++++++++----------------- 1 file changed, 81 insertions(+), 39 deletions(-) commit 11441291bbf4326dca9b14ec3e9cad3d4d229303 Author: Behdad Esfahbod Date: Mon Jan 11 13:16:35 2016 +0000 1.1.3 NEWS | 29 +++++++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 30 insertions(+), 1 deletion(-) commit 97624d9244de0fdb9c03f60e03fe242028efa8a1 Author: Behdad Esfahbod Date: Mon Jan 11 12:58:45 2016 +0000 [docs] Minor fixes. src/hb-buffer.h | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) commit a39ff95fce39226e80850ff251cb34a7aad12bd7 Author: Behdad Esfahbod Date: Mon Jan 11 12:28:37 2016 +0000 [coretext] Speed up CoreText font fallback Fixes https://code.google.com/p/chromium/issues/detail?id=547912 src/hb-coretext.cc | 45 ++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 40 insertions(+), 5 deletions(-) commit 5afebbdcb2dab0e9a42d580df629d8e60b50d2f9 Author: Behdad Esfahbod Date: Thu Jan 7 22:53:59 2016 +0000 Add Homebrew build instructions BUILD.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) commit e8a27d79476a5d7a83cf2287d92ca291257546f4 Author: Behdad Esfahbod Date: Thu Jan 7 22:52:16 2016 +0000 Don't build hb-fuzzer in "make", only "make check" test/fuzzing/Makefile.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 25671466d245449187f8ab17e1a233f1d087d5ed Author: Behdad Esfahbod Date: Thu Jan 7 19:11:41 2016 +0000 Add 9 reserved entries to hb_font_extents_t Might add italic-angle, underline/strikethrough-position/thickness in the future. Do this before new struct goes into a release. src/hb-font.h | 10 ++++++++++ 1 file changed, 10 insertions(+) commit e6d5e4c3106180cb22253c2c278b40f7c4c98f2f Author: Behdad Esfahbod Date: Wed Jan 6 12:29:50 2016 +0000 [uniscribe] Fix negative advance This happens with at least one test font I have. src/hb-uniscribe.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 99d34955762d0fff4b66a30e6fbe65fd1cf9976b Author: Behdad Esfahbod Date: Wed Jan 6 12:20:47 2016 +0000 [test] Add test text for Kaithi test/shaping/texts/in-tree/shaper-hangul/MANIFEST | 1 + test/shaping/texts/in-tree/shaper-hebrew/MANIFEST | 1 + test/shaping/texts/in-tree/shaper-tibetan/MANIFEST | 1 + test/shaping/texts/in-tree/shaper-use/MANIFEST | 1 + test/shaping/texts/in-tree/shaper-use/script-kaithi/MANIFEST | 1 + test/shaping/texts/in-tree/shaper-use/script-kaithi/misc.txt | 6 ++++++ 6 files changed, 11 insertions(+) commit 53c47c85827a7e3ca82000e3baa9aa87c5770ce9 Author: Behdad Esfahbod Date: Tue Jan 5 13:26:20 2016 +0000 Increase sanitize edit count from 8 to 32 See previous commit. src/hb-open-type-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit da2fcfdc51a2cc0d0a782efa6c91b733f7aa84ba Author: Behdad Esfahbod Date: Tue Jan 5 13:23:45 2016 +0000 Don't count fixing-up FeatureParams offset as error The font Garamond Premier Pro Caption (and possibly many other Adobe fonts), have many FeatureParamsSize tables with the old wrong offset. We handle fixing those up, but they were still contributing to edit_count, and when I reduced HB_SANITIZE_MAX_EDIT from 100 to 8 in 14c2de321826c36037adde859ccca3e2011325a9, these fonts were now getting GPOS dropped and hence kerning disabled. Fix, by not counting edits made towareds offset fix-up. I'll also increase edit count again, in the next commit. src/hb-ot-layout-common-private.hh | 3 +++ 1 file changed, 3 insertions(+) commit d0adc80965506810820f9ec165b8df80cc8907e3 Author: Behdad Esfahbod Date: Sat Jan 2 13:25:18 2016 +0000 Check magicNumber in head table during sanitize src/hb-ot-head-table.hh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 3a48c776701a919e11b067129586e40372d90d54 Merge: 9230911f 4b4948d3 Author: Behdad Esfahbod Date: Sat Jan 2 00:59:14 2016 +0000 Merge pull request #208 from khaledhosny/travis-trusty [travis] Try building on Trusty commit 4b4948d360a2141e0ffda2994aa308645dc32f59 Author: Khaled Hosny Date: Sat Jan 2 00:36:19 2016 +0400 [travis] Try building on Trusty Trusty has gtk-doc 1.20 which has better markdown support which should fix some of the brokenness in the newly added documentation. The build seems to be as fast as the current container-based build on Precise. .travis.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 9230911facf90c06626e54023ca4d99f5e05f1a4 Author: Behdad Esfahbod Date: Fri Jan 1 19:06:43 2016 +0000 [travis] Only run coveralls if testing behdad/harfbuzz Fixes failures in others' forks, like: https://travis-ci.org/khaledhosny/harfbuzz/jobs/99719710#L3912 .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6f66f05757d3d5738571b3d4ee40afffb8f26ff9 Merge: bfdf684f 9ab9f974 Author: Behdad Esfahbod Date: Fri Jan 1 16:44:01 2016 +0000 Merge pull request #207 from khaledhosny/docs-4 [docs] More buffers documentation commit 9ab9f974d42e0001966e243a23a64e6aefbd4764 Author: Khaled Hosny Date: Fri Jan 1 20:38:21 2016 +0400 [docs] More buffers documentation docs/harfbuzz-sections.txt | 4 +- src/hb-buffer-serialize.cc | 85 ++++++++++++++++++++++++++++++------------- src/hb-buffer.cc | 91 +++++++++++++++++++++++++++++++++++----------- src/hb-buffer.h | 78 +++++++++++++++++++++++++-------------- src/hb-shape.cc | 10 +++-- 5 files changed, 187 insertions(+), 81 deletions(-) commit bfdf684f7957645dd016fbf76700c5911c4bee2d Merge: d7ed6f50 85c2443b Author: Behdad Esfahbod Date: Wed Dec 30 22:20:14 2015 +0100 Merge pull request #205 from khaledhosny/more-docs More docs commit d7ed6f50b4ff13a94701131913d931f13a4d1266 Merge: b758e5ea a7f0e25d Author: Behdad Esfahbod Date: Wed Dec 30 22:20:00 2015 +0100 Merge pull request #206 from nico/patch-3 Remove unused HB_SHAPER_DATA_ENSURE_DECLARE lines. commit a7f0e25dafa90bd21b01c38cb0782ade54b75cdc Author: Nico Weber Date: Wed Dec 30 16:05:52 2015 -0500 Remove unused HB_SHAPER_DATA_ENSURE_DECLARE lines. The coretext_aat shaper delegates to the regular coretext_..._ensure() functions, so coretext_aat_..._ensure() functions defined by these macros are unused. The compiler warns about them, which in turn can confuse people to think that the coretext_aat_..._ensure() functions weren't called by accident. src/hb-coretext.cc | 4 ---- 1 file changed, 4 deletions(-) commit 85c2443b737335b77c7e9bb6fd6741912f70fcef Author: Khaled Hosny Date: Wed Dec 30 22:57:04 2015 +0400 [docs] Reduce gtkdoc-check errors Now it is just reporting one error about “503 undocumented or incomplete symbols”, that will be the easy part I guess. docs/harfbuzz-docs.xml | 74 ++++++++++++++++++++++++++++++++++++++++++++++ docs/harfbuzz-sections.txt | 40 +++++++++++++++++++++++++ 2 files changed, 114 insertions(+) commit 9cffe329f15b3a74a3af4e68c1884f1dbda49666 Author: Khaled Hosny Date: Wed Dec 30 22:50:08 2015 +0400 [docs] Typo src/hb-buffer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b758e5ea223eced0fde9a3e62d0fdf04c04914a1 Merge: 266bfa37 8b1224f0 Author: Behdad Esfahbod Date: Wed Dec 30 16:44:19 2015 +0100 Merge pull request #203 from nico/patch-1 Remove unused `retry:` label. commit 266bfa3772e75fedcd93db22bf8672a13ad7a7d9 Author: Behdad Esfahbod Date: Wed Dec 30 16:25:48 2015 +0100 [docs] Minor .ci/deploy-docs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d08035f8f15b7ddd89a318ea34bc386a9e33a8ea Author: Behdad Esfahbod Date: Wed Dec 30 16:15:36 2015 +0100 [docs] Fix up build, really .ci/deploy-docs.sh | 9 ++++----- .travis.yml | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) commit 0d45c3cf63692151166ca7071f755dfaa8922a67 Author: Behdad Esfahbod Date: Wed Dec 30 16:09:39 2015 +0100 [docs] Turn bash tracing on .ci/deploy-docs.sh | 4 ++++ 1 file changed, 4 insertions(+) commit 33b2d981a0b12ea165ef9282204a73f4a1ce0477 Author: Behdad Esfahbod Date: Wed Dec 30 15:56:56 2015 +0100 [docs] Another try, not sure why the bot isn't building .ci/deploy-docs.sh | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) commit f3a051149b3b565b5ad4e489bf730c5203c3549e Author: Behdad Esfahbod Date: Wed Dec 30 15:45:43 2015 +0100 [docs] Shuffling code around in deploy-docs.sh Temporarily makes it rebuild docs on every change again. .ci/deploy-docs.sh | 46 +++++++++++++++++++++++++++------------------- 1 file changed, 27 insertions(+), 19 deletions(-) commit 8f31d0a94b27bb658aabe600472fc10bc47885f6 Merge: 9d280cf4 fb192c26 Author: Behdad Esfahbod Date: Wed Dec 30 15:13:37 2015 +0100 Merge pull request #202 from khaledhosny/doc-fixes Doc fixes commit fb192c263e17081c87f4cc971274d9be42f19513 Author: Khaled Hosny Date: Wed Dec 30 15:05:50 2015 +0400 [docs] A bit more buffers documentation docs/harfbuzz-sections.txt | 2 ++ src/hb-buffer.cc | 7 +++--- src/hb-buffer.h | 56 ++++++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 60 insertions(+), 5 deletions(-) commit 8ab797c5b86c33eab6ee024471fd3c147325d26a Author: Khaled Hosny Date: Tue Dec 29 17:42:16 2015 +0400 [docs] A bit more buffers documentation docs/harfbuzz-sections.txt | 60 +++++++++++++++--------------- src/hb-buffer.cc | 93 +++++++++++++++++++++++++++++++--------------- src/hb-buffer.h | 7 +++- src/hb-common.cc | 43 +++++++++++++-------- src/hb-common.h | 15 +++++--- 5 files changed, 135 insertions(+), 83 deletions(-) commit f18d2226b62f20d29e6299c01ae8467c725ea971 Author: Khaled Hosny Date: Tue Dec 29 15:21:20 2015 +0400 [docs] Some documentation on buffers Some of it (create, reference, destroy) are adapted from Cairo docs. docs/harfbuzz-sections.txt | 55 +++++++------- src/hb-buffer.cc | 174 +++++++++++++++++++++++++++------------------ 2 files changed, 132 insertions(+), 97 deletions(-) commit d7bf9d05c519a369a7b3a02e9ed5ecc05a20cd3e Author: Khaled Hosny Date: Tue Dec 29 02:23:24 2015 +0400 [docs] Fix comment syntax To lower the number of gtk-doc warnings. .travis.yml | 2 +- src/hb-directwrite.cc | 4 ++-- src/hb-ot-layout.cc | 14 ++++++++++++++ src/hb-unicode.h | 16 ++++++++++++++++ 4 files changed, 33 insertions(+), 3 deletions(-) commit 8b1224f0eece7a5b6846e206333e57ac4653a705 Author: Nico Weber Date: Mon Dec 28 21:31:28 2015 -0500 Remove unused `retry:` label. Fixes a -Wunused-label warning when building harfbuzz with clang -Wall. src/hb-coretext.cc | 1 - 1 file changed, 1 deletion(-) commit 1f5559293f9bb1b4e911f4bdecf276ff1f6ae01c Author: Khaled Hosny Date: Tue Dec 29 02:15:21 2015 +0400 [docs] Ignore the new HB_EXTERN decoration Otherwise, almost all API functions are not extracted. docs/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 9d280cf49f25181f64c978752f926b79e7c3746a Author: Khaled Hosny Date: Sat Dec 26 06:45:51 2015 +0400 Fix previous commit .ci/deploy-docs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b789199f107912cfce5e4a95d6152f9a1a7993f2 Author: Khaled Hosny Date: Sat Dec 26 06:35:08 2015 +0400 [travis] Build docs only on tagged revisions Lets see if it works… .ci/deploy-docs.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit e5b90c08a4c1f475560209a5e47628f695606d89 Author: Behdad Esfahbod Date: Fri Dec 25 18:41:41 2015 +0100 [travis] Remove secure var I've set up a secure var for behdad/harfbuzz through Travis web interface, no need to set the var here. .ci/deploy-docs.sh | 2 +- .travis.yml | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) commit e75c1ffdf548185ce1f1df7937f0d028e5e40efe Merge: 6173c2a6 d25317f6 Author: Behdad Esfahbod Date: Fri Dec 25 18:21:08 2015 +0100 Merge pull request #199 from behdad/travis-docs Deploy docs to gh-pages branch from Travis builds commit 6173c2a6fc6ea0bf812f7f398770b5342974f9bf Author: Behdad Esfahbod Date: Fri Dec 25 18:18:23 2015 +0100 Fix flaky test This test font had a upem of 769, which results in rounding-related errors with the FreeType font funcs. Change the upem to 1024 to fix that. Fixes https://github.com/behdad/harfbuzz/issues/201 ...> 1c2fb74c1b2aa173262734c1f616148f1648cfd6.ttf} | Bin 4064 -> 4064 bytes test/shaping/fonts/sha1sum/MANIFEST | 2 +- test/shaping/tests/ligature-id.tests | 70 ++++++++++----------- 3 files changed, 36 insertions(+), 36 deletions(-) commit 3fcae6d82da389c9944386a8ab41eb1c13b99330 Author: Behdad Esfahbod Date: Fri Dec 25 18:18:02 2015 +0100 [tests] Add --reference, for re-recording tests test/shaping/run-tests.sh | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) commit d25317f67f3c5c77f9059961935b0f35cbaa9ac4 Author: Khaled Hosny Date: Wed Dec 23 01:29:48 2015 +0400 Move more docs from FreeDesktop page docs/Makefile.am | 1 + docs/harfbuzz-docs.xml | 15 ++++---- docs/usermanual-install-harfbuzz.xml | 70 ++++++++++++++++++++++++++++++++++++ 3 files changed, 80 insertions(+), 6 deletions(-) commit 493a92220844c8996be67c8a7a2c5447942fe2c1 Author: Khaled Hosny Date: Wed Dec 23 00:33:41 2015 +0400 Rename user manual files Use chapter ids instead of numbers, so that we can reorder them, introduce new ones etc. without the numbers becoming out of date. docs/Makefile.am | 12 ++++++------ docs/harfbuzz-docs.xml | 12 ++++++------ ... => usermanual-buffers-language-script-and-direction.xml} | 0 docs/{usermanual-ch04.xml => usermanual-fonts-and-faces.xml} | 0 ...{usermanual-ch06.xml => usermanual-glyph-information.xml} | 0 docs/{usermanual-ch02.xml => usermanual-hello-harfbuzz.xml} | 0 ...{usermanual-ch05.xml => usermanual-opentype-features.xml} | 0 .../{usermanual-ch01.xml => usermanual-what-is-harfbuzz.xml} | 0 8 files changed, 12 insertions(+), 12 deletions(-) commit 4dc2265918089ee08c6d82eed0cfd41e02d7d231 Author: Khaled Hosny Date: Wed Dec 23 00:26:20 2015 +0400 Intro from freedesktop.org/wiki/Software/HarfBuzz/ docs/HarfBuzz.png | Bin 0 -> 3419 bytes docs/Makefile.am | 3 ++- docs/harfbuzz-docs.xml | 31 ++++++++++++++++++++++++++++++- 3 files changed, 32 insertions(+), 2 deletions(-) commit 22b07782ced6503a0bf33f2fe157b70540238f6d Author: Khaled Hosny Date: Mon Dec 14 23:33:51 2015 +0400 Deploy docs to gh-pages branch from Travis builds Build docs in Travis and push them to the gh-pages branch, which makes them available at http://behdad.github.io/harfbuzz/ .ci/deploy-docs.sh | 25 +++++++++++++++++++++++++ .travis.yml | 4 ++++ 2 files changed, 29 insertions(+) commit fc38e6034c76d5450f5398d667184bc3696efcc4 Author: Behdad Esfahbod Date: Wed Dec 23 14:50:53 2015 +0100 [layout] Collect coverage glyphs in PairPos Apparently class=0 is used for ClassDef1. See: https://github.com/adobe-type-tools/afdko/issues/90 src/hb-ot-layout-gpos-table.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8718dae818b22c3933c33bdfc8a7413ef4c3110a Author: Behdad Esfahbod Date: Fri Dec 18 19:53:40 2015 +0000 [python] Hook up sample debugger src/sample.py | 6 ++++++ 1 file changed, 6 insertions(+) commit 0475ef2f97e3035a2eea9a0f96031331e07e8e29 Author: Behdad Esfahbod Date: Fri Dec 18 18:17:07 2015 +0000 [buffer] Add debugging, aka, message, API Currently just announces lookup applications. Message-API *will* change. hb-shape / hb-view are updated to print-out messages to stder if --debug is specified. src/hb-buffer-private.hh | 18 ++++++++++++++++++ src/hb-buffer.cc | 44 ++++++++++++++++++++++++++++++++++++++++++++ src/hb-buffer.h | 15 +++++++++++++++ src/hb-ot-layout.cc | 12 ++---------- util/main-font-text.hh | 18 ++++++++++++++++++ 5 files changed, 97 insertions(+), 10 deletions(-) commit 9ea0aa43ac5cf243b698aae0ec80241b5efd7488 Author: Behdad Esfahbod Date: Fri Dec 18 17:30:18 2015 +0000 Don't deserialize positions if buffer has no positions src/hb-buffer-serialize.cc | 3 +++ src/hb-ot-layout.cc | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) commit 862b1644e9469a7e70555141f53729409d50d0d2 Author: Behdad Esfahbod Date: Fri Dec 18 13:54:06 2015 +0000 [use] Only set syllable-based topographical features if not Arabic-joining src/hb-ot-shape-complex-use.cc | 3 +++ 1 file changed, 3 insertions(+) commit 45b7ec365225109eb0854e6c417f48860b5f24af Author: Behdad Esfahbod Date: Fri Dec 18 13:47:16 2015 +0000 [indic] Followup fix for Malayalam context matching We regeressed Malayalam in 508cc3d3cfcfb0383df0fe795cc28db4e0fd5729 This brings down the failures to 198 (from 750). BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%) DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%) GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%) GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%) KANNADA: 951190 out of 951913 tests passed. 723 failed (0.0759523%) KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%) MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) MYANMAR: 1123865 out of 1123883 tests passed. 18 failed (0.00160159%) src/hb-ot-shape-complex-indic.cc | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) commit 2813e3049a69d64e5395f68c52c4690e1d256d55 Author: Behdad Esfahbod Date: Fri Dec 18 11:05:11 2015 +0000 [indic] Update data tables to Unicode 8.0 Test stats remain unchanged, except for Malayalam, which we investigate: BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%) DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%) GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%) GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%) KANNADA: 951190 out of 951913 tests passed. 723 failed (0.0759523%) KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%) MALAYALAM: 1047584 out of 1048334 tests passed. 750 failed (0.0715421%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) Myanmar, compared to Windows 10 mmrtext.ttf: MYANMAR: 1123865 out of 1123883 tests passed. 18 failed (0.00160159%) src/gen-indic-table.py | 1 + src/hb-ot-shape-complex-indic-private.hh | 40 ++-- src/hb-ot-shape-complex-indic-table.cc | 372 ++++++++++++++++++------------- src/hb-ot-shape-complex-indic.cc | 23 +- src/hb-ot-shape-complex-myanmar.cc | 4 + 5 files changed, 244 insertions(+), 196 deletions(-) commit fc06cff40f136440f6402d0a5e735e2a4a3c062a Author: Behdad Esfahbod Date: Thu Dec 17 17:47:35 2015 +0000 Remove HB_OT_SHAPE_ZERO_WIDTH_MARKS_DEFAULT The DEFAULT naming wasn't helpful, so just remove it. src/hb-ot-shape-complex-default.cc | 2 +- src/hb-ot-shape-complex-private.hh | 4 +--- src/hb-ot-shape-complex-thai.cc | 2 +- src/hb-ot-shape-complex-tibetan.cc | 2 +- 4 files changed, 4 insertions(+), 6 deletions(-) commit 508cc3d3cfcfb0383df0fe795cc28db4e0fd5729 Author: Behdad Esfahbod Date: Thu Dec 17 17:31:17 2015 +0000 [indic] Allow context when matching for Malayalam new-spec Test sequence: U+0995,U+09CD,U+09B0 With Nirmala shipped on Windows 10, this failed to form the below form. Works now. Reported by Sairus. src/hb-ot-shape-complex-indic.cc | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) commit eaf1e93ef1ee19a3e72d781e8abbd7f1165c1618 Author: Behdad Esfahbod Date: Thu Dec 17 16:57:47 2015 +0000 [uniscribe] Handle E_NOT_SUFFICIENT_BUFFER as well as E_OUTOFMEMORY On Windows 10 we are seeing that other error message... Test sequence: U+0995,U+-9CD,U+09B0 With Nirmala shipped on Windows 10, this failed to form the below form. Works now. Reported by Sairus. src/hb-uniscribe.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 21e5d7edc4f28157254ef29a8ac247f3a572f6a6 Author: Behdad Esfahbod Date: Thu Dec 17 16:28:38 2015 +0000 [util] Use O_BINARY instead of _O_BINARY The latter doesn't seem to be available in Cygwin. I'm surprised it compiled before... util/options.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 100fbeaf196515774c985ee839d0fa0695f9a6fa Author: Behdad Esfahbod Date: Thu Dec 17 15:23:09 2015 +0000 Fix ligature component of a mark happening after a ligature within a ligature! Say, if we are ligating "A B_C m D", then previously 'm' was being attached to 'B' in the combined A_B_C_D ligature. Now we attach it to 'C'. No test for this though :(. src/hb-ot-layout-gsubgpos-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2f02fc79a5018e3348fccf366c470803554e1e58 Author: Behdad Esfahbod Date: Thu Dec 17 15:21:14 2015 +0000 Improve ligature-component handling We use three bits for lig_id these days, so we finally got a report of two separate ligatures with the same lig_id happening adjacent to each other, and then the component-handling code was breaking things. Protect against that by ignoring same-lig-id but lig-comp=0 glyphs after a new ligature. Fixes https://github.com/behdad/harfbuzz/issues/198 src/hb-ot-layout-gsubgpos-private.hh | 12 +++++-- test/shaping/Makefile.am | 1 + test/shaping/fonts/sha1sum/MANIFEST | 1 + .../c78d1f25ea1df1210414f2fe2e0e1e53082bba76.ttf | Bin 0 -> 4064 bytes test/shaping/tests/MANIFEST | 1 + test/shaping/tests/ligature-id.tests | 35 +++++++++++++++++++++ 6 files changed, 47 insertions(+), 3 deletions(-) commit 2ab0de9fbd03231b647345b01e31b136e2e00978 Author: Behdad Esfahbod Date: Thu Dec 17 11:59:15 2015 +0000 [use] Fix halant detection Before, we were just checking the use_category(). This detects as halant a ligature that had the halant as first glyph (as seen in NotoSansBalinese.) Change that to use the is_ligated() glyph prop bit. The font is forming this ligature in ccmp, which is before the rphf / pref tests. So we need to make sure the "ligated" bit survives those tests. Since those only check the "substituted" bit, we now only clear that bit for them and "ligated" survives. Fixes https://github.com/behdad/harfbuzz/issues/180 src/hb-ot-layout-private.hh | 6 ++---- src/hb-ot-shape-complex-use.cc | 19 ++++++++++++------- test/shaping/Makefile.am | 1 + test/shaping/fonts/sha1sum/MANIFEST | 1 + .../fbb6c84c9e1fe0c39e152fbe845e51fd81f6748e.ttf | Bin 0 -> 2616 bytes test/shaping/tests/MANIFEST | 1 + test/shaping/tests/use.tests | 1 + 7 files changed, 18 insertions(+), 11 deletions(-) commit 86bcbd65b0d98357fb3d67a2f4f2a704ace55e10 Author: Behdad Esfahbod Date: Thu Dec 17 11:04:33 2015 +0000 [arabic] Use glyph advance width in apply_stch() instead of extents That seems to be what Windows is doing, and makes more sense. src/hb-ot-shape-complex-arabic.cc | 24 +++++++----------------- 1 file changed, 7 insertions(+), 17 deletions(-) commit f11c11a1f123ef245e59ba892230db14170a8e5a Author: Behdad Esfahbod Date: Wed Dec 16 17:08:36 2015 +0100 Fix Since: tags for new API https://github.com/behdad/harfbuzz/commit/e1d4d0f1dbd8518b5672245c05d73f22a9ed03ea#commitcomment-15006653 src/hb-font.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 15f2c055c17c54b0a6ae6eef50dcda13c58cda75 Merge: 49e72634 a13b023d Author: Behdad Esfahbod Date: Mon Dec 14 14:19:03 2015 +0100 Merge pull request #196 from srl295/aix AIX fixes commit a13b023dbfd0532e8cd74c356fbbd4453d0ffaa0 Author: Steven R. Loomis Date: Fri Dec 11 10:21:27 2015 -0800 AIX fixes - use '-w' instead of '\<...\>' for check-header-guards grep manpage says these are the same - put '-q' first in the grep options - move VAR into hb-private.hh - hb-font-private.hh - use [VAR] instead of [] for variable array src/check-header-guards.sh | 5 ++--- src/hb-font-private.hh | 2 +- src/hb-open-type-private.hh | 3 --- src/hb-private.hh | 2 ++ 4 files changed, 5 insertions(+), 7 deletions(-) commit 49e72634af74a9fbad01f42f48e104218413acc0 Author: Behdad Esfahbod Date: Thu Dec 10 17:44:19 2015 +0100 Limit use of AIX intrinsics to IBM's compiler src/hb-atomic-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e1d4d0f1dbd8518b5672245c05d73f22a9ed03ea Merge: 70b33eda 808d3fc0 Author: Behdad Esfahbod Date: Thu Dec 10 16:56:07 2015 +0100 Merge branch 'font-extents' Fixes https://github.com/behdad/harfbuzz/pull/165 commit 808d3fc0eadd379909f2a0308fd3db474f1efde8 Author: Behdad Esfahbod Date: Thu Dec 10 16:55:16 2015 +0100 [util] Port hb-view to use font metrics from HarfBuzz instead of cairo util/helper-cairo.cc | 4 +++- util/view-cairo.cc | 24 ++++++++++++------------ 2 files changed, 15 insertions(+), 13 deletions(-) commit 31fa3892947138c7950303ea3719bb5ceb813625 Author: Behdad Esfahbod Date: Thu Dec 10 16:38:29 2015 +0100 [ft] Use ftface->size->metrics for font extent info src/hb-ft.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 3ad16048fdd841f31f1cb98d7ff9ea1871841146 Author: Behdad Esfahbod Date: Thu Dec 10 16:37:49 2015 +0100 [ot-font] Respect OS/2 fsSelection USE_TYPO_METRICS bit src/hb-ot-font.cc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) commit 70b33edae7c8b9c031b83c95f00cb383789f1041 Author: Behdad Esfahbod Date: Thu Dec 10 15:54:42 2015 +0100 Add atomic ops for AIX Patch from Volker Simonis. src/hb-atomic-private.hh | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) commit 98460779bae19e4d64d29461ff154b3527bf8420 Author: Behdad Esfahbod Date: Mon Dec 7 21:38:47 2015 +0100 Remove final pause from Arabic shaper Back in the old days, we used to apply 'calt' and 'cswh' in Arabic shaper, with a pause in between. Then we disabled the 'cswh' because Microsoft disabled it, but forgot to remove the unnecessary pause. Do that now. This has the benefit that it fixes shaping with monbaiti from Windows 10. In that version of that font, the lookups from 'calt' are duplicated in 'rclt', and Mongolian was changed to go through Universal Shaping Engine. We still use the Arabic shaper for Mongolian. With a pause after 'calt', we were applying the duplicate lookups from 'calt' and 'rclt' twice. It happened to be the case that these lookups were NOT idempotent. So we were getting wrong shaping. See thread "Windows 10 monbaiti.ttf upgrade (5.01 -> 5.51) caused loss of diacritical marks when shaped with harfbuz" on the mailing list. This fixes that. src/hb-ot-shape-complex-arabic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dee0fbf9e2eac8b61730efc4978bc10c552b5227 Merge: 255df680 a7ffe353 Author: Behdad Esfahbod Date: Mon Dec 7 10:44:08 2015 +0100 Merge pull request #192 from behdad/jfkthame-stch [issue 191] Make apply_stch() give a more precise fit commit 255df6801201fb22402420f7b7b7ea8b042df8ba Author: Behdad Esfahbod Date: Mon Dec 7 10:34:47 2015 +0100 Fix undefined behavior in cmp function Fixes https://bugs.freedesktop.org/show_bug.cgi?id=93274 src/hb-ot-map-private.hh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit fcf9e61bad13c828b5482f26491c82db65d91c96 Author: Behdad Esfahbod Date: Mon Dec 7 10:30:43 2015 +0100 Fix sorting order of ot_languages array Looks like the original sort was wrongly done. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=93275 src/hb-ot-tag.cc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) commit 70952ddb5a29c5bcbb4b6c3a05a428496033234a Author: Behdad Esfahbod Date: Mon Dec 7 10:28:46 2015 +0100 Add test to make sure ot-languages array is sorted Currently fails. Part of https://bugs.freedesktop.org/show_bug.cgi?id=93275 src/Makefile.am | 9 ++++++++- src/hb-ot-tag.cc | 23 +++++++++++++++++++++++ 2 files changed, 31 insertions(+), 1 deletion(-) commit 8c37556f730d7e961394075cd863f624af4c53c4 Merge: 8e5f9026 f35b3e93 Author: Behdad Esfahbod Date: Mon Dec 7 09:34:58 2015 +0100 Merge pull request #134 from ebraminio/dwrite Add working but less prefect DirectWrite backend commit a7ffe3535836032dba5559080dffeec79473197b Author: jfkthame Date: Sat Dec 5 17:47:37 2015 +0000 Make apply_stch() give a more precise fit This aims to make Syriac Abbr Mark sizing more accurate when repeating segments are used, by adding an extra repeat and tightening up the spacing slightly rather than leaving a shortfall corresponding to a partial repeat-width. src/hb-ot-shape-complex-arabic.cc | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) commit 8e5f902656d2882d24c30e8b26ddbd3963baa55c Author: Behdad Esfahbod Date: Mon Nov 30 16:53:21 2015 -0800 src/test.cc: wrong field printed Fixes https://github.com/behdad/harfbuzz/issues/188 Fixes https://bugs.freedesktop.org/show_bug.cgi?id=93182 src/test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6f2e6de1fae0ab2269b472a750788817de6c2a6e Author: Simon Cozens Date: Mon Oct 26 16:23:22 2015 +0900 Get font ascender and descender metrics from OS/2 table. src/hb-font-private.hh | 39 ++++++++++++++++++- src/hb-font.cc | 102 ++++++++++++++++++++++++++++++++++++++++++++++++- src/hb-font.h | 62 ++++++++++++++++++++++++++++-- src/hb-ft.cc | 21 ++++++++++ src/hb-ot-font.cc | 58 ++++++++++++++++++++++++++-- 5 files changed, 274 insertions(+), 8 deletions(-) commit 097c998a0c7b250924801bb69f5fa0c529edd183 Author: Simon Cozens Date: Mon Oct 26 16:22:38 2015 +0900 Parse the OS/2 table. src/Makefile.am | 1 + src/hb-ot-os2-table.hh | 105 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 106 insertions(+) commit d44d52bd0da033865641dfd39d94852119fd4fd7 Author: Behdad Esfahbod Date: Thu Nov 26 19:35:43 2015 -0500 1.1.2 NEWS | 15 +++++++++++++++ configure.ac | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) commit 35d18585fc57750d817f57bfffe569069f9803b5 Author: Behdad Esfahbod Date: Thu Nov 26 19:30:37 2015 -0500 Fix a few docs blocks src/hb-buffer.cc | 4 ++++ src/hb-glib.cc | 2 ++ src/hb-ot-font.cc | 2 ++ src/hb-ot-layout.cc | 6 ++++++ src/hb-ot-shape.cc | 4 ++++ 5 files changed, 18 insertions(+) commit 0e38c918b66df31978d8fd3d8271a9b781384545 Author: Behdad Esfahbod Date: Thu Nov 26 19:26:26 2015 -0500 [introspection] Make scanner happy with HB_EXTERN src/Makefile.am | 1 + 1 file changed, 1 insertion(+) commit ea512f71084296be3bd893f78650def894066de0 Author: Behdad Esfahbod Date: Thu Nov 26 19:22:22 2015 -0500 Use C-style casts instead of compare to 0, to convert hb_bool_t to bool src/hb-common.cc | 2 +- src/hb-fallback-shape.cc | 2 +- src/hb-font-private.hh | 2 +- src/hb-ot-layout.cc | 2 +- src/hb-ot-map.cc | 2 +- src/hb-ot-shape-complex-hangul.cc | 2 +- src/hb-ot-shape-complex-hebrew.cc | 2 +- src/hb-ot-shape-complex-indic.cc | 4 ++-- src/hb-ot-shape-normalize.cc | 6 +++--- src/hb-ot-shape.cc | 2 +- 10 files changed, 13 insertions(+), 13 deletions(-) commit 67a36a725e2a61a096ba0324f359d17f9b02d312 Author: Behdad Esfahbod Date: Thu Nov 26 18:48:42 2015 -0500 Fix vertical GPOS This was brorken earlier, though, it's really hard to notice it. Unlike the glyph_h_origin(), an unset glyph_v_origin() does NOT mean that the vertical origin is at 0,0. Related to https://github.com/behdad/harfbuzz/issues/187 src/hb-ot-shape.cc | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) commit 1c6a057dd1a52511474630896a597bf8e5215214 Author: Behdad Esfahbod Date: Thu Nov 26 18:48:30 2015 -0500 Add tests for previous commit test/shaping/Makefile.am | 1 + .../sha1sum/49c9f7485c1392fa09a1b801bc2ffea79275f22e.ttf | Bin 0 -> 1496 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 + test/shaping/tests/MANIFEST | 1 + test/shaping/tests/simple.tests | 2 ++ 5 files changed, 5 insertions(+) commit c41c145c7386ebe72b1cfb0475d836a689fecc5e Author: Behdad Esfahbod Date: Thu Nov 26 18:43:15 2015 -0500 Make nil glyph_h_origin() function return true Fixes https://github.com/behdad/harfbuzz/issues/187 Funcs implementations that have a non-zero horizontal origin must implement the glyph_h_origin() callback, nothing new here. Other implementations (all I know of!) can simply not set glyph_h_origin() now. I did that for hb-ot and hb-ft in 44f82750807475aa5b16099ccccd917d488df703, though that broke the fallback shaper because the default was returning false... src/hb-font.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 766963adba6770dcd45de4417481ed8eda60a716 Merge: b344af80 f798b8e2 Author: Behdad Esfahbod Date: Tue Nov 24 15:38:43 2015 -0600 Merge pull request #114 from ThePhD/vc++-fixes Fix all VC++ warnings and errors commit b344af80ca95b9eddfd6017aa6ae103388d6b5f8 Merge: 662acd26 835bbdc7 Author: Behdad Esfahbod Date: Tue Nov 24 15:30:27 2015 -0600 Merge pull request #177 from fanc999/exporting Enable use of compiler directives to export symbols commit 662acd26d10c38e96a9afcdaab2cb2979794966f Merge: b24e93e3 1979f6fe Author: Behdad Esfahbod Date: Tue Nov 24 15:29:44 2015 -0600 Merge pull request #181 from mhosken/master Fix y_scale problems in hb-gr commit b24e93e3a4d98111c4684fa08e9080b471881d5c Author: Behdad Esfahbod Date: Tue Nov 24 13:18:20 2015 -0600 1.1.1 NEWS | 7 +++++++ configure.ac | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) commit 233944ac91bb81250c0e63150eecfedfaf09f590 Merge: 5a24b1d2 d5382019 Author: Khaled Hosny Date: Tue Nov 24 18:37:35 2015 +0400 Merge pull request #185 from khaledhosny/travis-osx [travis] Enable Mac OS X support commit d538201918e6932ef7645f8d5b2c3491954936f8 Author: Khaled Hosny Date: Tue Nov 24 12:46:35 2015 +0400 [travis] Enable Mac OS X support Fixes https://github.com/behdad/harfbuzz/issues/182 .travis.yml | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) commit 5a24b1d25c59865e298bf105f54503e79587265c Author: Behdad Esfahbod Date: Mon Nov 23 16:46:14 2015 -0600 [travis] Remove coverity scan I never could get it to work, and it's a proprietary platform. .travis.yml | 11 ----------- README | 1 - 2 files changed, 12 deletions(-) commit 1979f6fedca82fa1e4f65491de491db1aa6dc645 Author: Martin Hosken Date: Mon Nov 23 10:03:56 2015 +0700 Fix y_scale problems in hb-gr src/hb-graphite2.cc | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) commit 835bbdc7c92bd774ff92c42a9277ded72066d29d Author: Chun-wei Fan Date: Thu Nov 19 18:34:12 2015 +0800 Public headers: Decorate public symbols with HB_EXTERN This prepares the headers for exporting symbols using visibility attributes or __declspec(dllexport), so that we do not need to maintain symbols listing files, as this is what was and is done in GLib and GTK+. src/hb-blob.h | 24 +++++----- src/hb-buffer.h | 100 +++++++++++++++++++------------------- src/hb-common.h | 22 ++++----- src/hb-coretext.h | 6 +-- src/hb-face.h | 34 ++++++------- src/hb-font.h | 114 ++++++++++++++++++++++---------------------- src/hb-ft.h | 18 +++---- src/hb-glib.h | 8 ++-- src/hb-gobject-enums.h.tmpl | 2 +- src/hb-gobject-structs.h | 26 +++++----- src/hb-graphite2.h | 4 +- src/hb-icu.h | 6 +-- src/hb-ot-font.h | 2 +- src/hb-ot-layout.h | 56 +++++++++++----------- src/hb-ot-shape.h | 4 +- src/hb-ot-tag.h | 8 ++-- src/hb-set.h | 52 ++++++++++---------- src/hb-shape-plan.h | 18 +++---- src/hb-shape.h | 10 ++-- src/hb-unicode.h | 52 ++++++++++---------- src/hb-uniscribe.h | 4 +- src/hb-version.h.in | 6 +-- src/hb.h | 4 ++ 23 files changed, 292 insertions(+), 288 deletions(-) commit f798b8e2d683a1b89b6905b1a8615375b847b468 Author: ThePhD Date: Sat Nov 21 16:57:26 2015 -0500 c-style cast src/hb-ot-shape-complex-use.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a6991813659376a6a11c00a9f67d85b4f7ba9b5d Merge: 1dc32ea4 f19c6db1 Author: Behdad Esfahbod Date: Fri Nov 20 13:28:42 2015 -0800 Merge pull request #176 from behdad/missing-braces Add braces for subobject initializer in _hb_font_funcs_nil commit 1dc32ea4d2f294f9d1ae1c8fd19fb75f9278223b Author: Behdad Esfahbod Date: Fri Nov 20 13:24:19 2015 -0800 Whitespace src/hb-private.hh | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) commit f94c0ecbb1488138d3ec3b9d6d9fb78113dfee4f Author: Behdad Esfahbod Date: Fri Nov 20 13:21:29 2015 -0800 Define HB_MARK_AS_FLAG_T as a macro instead of using templates The generic template operator overloading was causing more problems than it solved. Eg: https://github.com/behdad/harfbuzz/pull/163 https://github.com/behdad/harfbuzz/issues/175 So, just use macros. Fixes https://github.com/behdad/harfbuzz/issues/175 Fixes https://github.com/behdad/harfbuzz/pull/178 src/hb-private.hh | 27 +++++++++++---------------- 1 file changed, 11 insertions(+), 16 deletions(-) commit f19c6db18e2e2dd0e9a406fc7e8533049fab48b0 Author: jfkthame Date: Fri Nov 20 08:43:49 2015 +0000 Add braces for subobject initializer in _hb_font_funcs_nil To avoid triggering -Wmissing-braces; see https://bugzilla.mozilla.org/show_bug.cgi?id=1226175#c8 src/hb-font.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit 9cc1ed4fa68075b3b142a2737438109772dd0002 Author: Behdad Esfahbod Date: Thu Nov 19 12:39:09 2015 -0800 Do not allow recursiving to same position and same lookup This is just to make it harder to be extremely slow. There definitely are ways still, just harder. Oh well... how do we tame this problem without solving halting problem?! Fixes https://github.com/behdad/harfbuzz/issues/174 src/hb-ot-layout-gsubgpos-private.hh | 5 +++++ test/shaping/fonts/sha1sum/MANIFEST | 1 + .../sha1sum/fab39d60d758cb586db5a504f218442cd1395725.ttf | Bin 0 -> 1894 bytes test/shaping/tests/fuzzed.tests | 1 + 4 files changed, 7 insertions(+) commit 7d75eee799bbb5ee7eef2651cf7b7d3aee6f09b0 Author: Behdad Esfahbod Date: Thu Nov 19 12:03:04 2015 -0800 [fuzzing] Run fuzzing tests using hb-fuzzer as well test/fuzzing/Makefile.am | 4 ++++ 1 file changed, 4 insertions(+) commit 13188cba7f0eaacd587beeb1c2258526ae24c438 Author: Behdad Esfahbod Date: Thu Nov 19 11:59:03 2015 -0800 Revert "Fix hang in OOM situations" This reverts commit f0599db761d7fc2d585d86e757a797f75ebc7499. Commit abadc1717d997b69f987fdf1be9e12156d2d13d6 provides a better fix for this. src/hb-buffer-private.hh | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) commit 18e1c6b6ef7c85a1b02e3dae86280d8ed6b65118 Author: Behdad Esfahbod Date: Thu Nov 19 11:50:58 2015 -0800 Revert "Make sure we make progress in OOM situations" This reverts commit 68b507a3c3c62c28c38e13fee733702bb703b6ca. Commit abadc1717d997b69f987fdf1be9e12156d2d13d6 provides a better fix for this. src/hb-buffer-private.hh | 7 +++++-- src/hb-buffer.cc | 31 ++++++++----------------------- 2 files changed, 13 insertions(+), 25 deletions(-) commit e1118aeac3b5556df0ce502732df8ac92bdac45a Author: Behdad Esfahbod Date: Wed Nov 18 23:40:47 2015 -0800 1.1.0 NEWS | 22 ++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 23 insertions(+), 1 deletion(-) commit 63fe05c8b1cd4f08b525028409e1299f34750810 Author: Behdad Esfahbod Date: Wed Nov 18 23:52:34 2015 -0800 Fix make distcheck src/Makefile.am | 1 + 1 file changed, 1 insertion(+) commit 9b087dec7753ad96d256ce1b9ae347bd8d697c75 Author: Behdad Esfahbod Date: Wed Nov 18 23:23:35 2015 -0800 [travis] Only coverity-scan the coverity_scan branch This essentially disables coverity-scan right now, until we find a pattern to continuously submit branches there. For background reasoning, see: Fixes https://github.com/behdad/harfbuzz/issues/171 .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 85062e3b4655ec6d5c3cf5344ce22cd88c21a2aa Author: Behdad Esfahbod Date: Wed Nov 18 23:09:13 2015 -0800 Add tests for previous two commits To fully test what these are supposed to test, they should be run against libharfbuzz-fuzzing.la instead of libharfbuzz.la, but for now just record the files. .../sha1sum/43979b90b2dd929723cf4fe1715990bcb9c9a56b.ttf | Bin 0 -> 1804 bytes test/shaping/fonts/sha1sum/MANIFEST | 2 ++ .../sha1sum/b9e2aaa0d75fcef6971ec3a96d806ba4a6b31fe2.ttf | Bin 0 -> 1804 bytes test/shaping/tests/fuzzed.tests | 2 ++ 4 files changed, 4 insertions(+) commit 37b40cd8a18e25d3324f829acec197f016f4a524 Author: Behdad Esfahbod Date: Wed Nov 18 23:04:45 2015 -0800 Fix another move_to assertion failure If buf->idx is at end, don't set end past it... Fixes https://github.com/behdad/harfbuzz/issues/173 src/hb-ot-layout-gsubgpos-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit abadc1717d997b69f987fdf1be9e12156d2d13d6 Author: Behdad Esfahbod Date: Wed Nov 18 17:52:08 2015 -0800 Try to better handle OOM situations Fixes assert fail in https://github.com/behdad/harfbuzz/issues/161 with libharfbuzz-fuzzing. src/hb-ot-layout-gsubgpos-private.hh | 2 +- src/hb-ot-layout.cc | 2 +- src/hb-ot-shape-complex-hangul.cc | 2 +- src/hb-ot-shape-complex-indic.cc | 2 +- src/hb-ot-shape-complex-thai.cc | 2 +- src/hb-ot-shape-complex-use.cc | 8 +------- src/hb-ot-shape-normalize.cc | 10 +++++----- src/hb-ot-shape.cc | 2 +- 8 files changed, 12 insertions(+), 18 deletions(-) commit ec625f7dfb5f6df19d35d81af6605d05e08321f2 Author: Behdad Esfahbod Date: Wed Nov 18 16:37:59 2015 -0800 Try to fix gnome-continuous build fail test/fuzzing/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) commit ff16ef3379e06afe44b5e78b8893aeae0cee2b5b Author: Behdad Esfahbod Date: Wed Nov 18 16:27:32 2015 -0800 Enable building a bounded version of the library for fuzzing test/fuzzing/hb-fuzzer links against libharfbuzz-fuzzing.so now. src/Makefile.am | 16 ++++++++++++++++ test/fuzzing/Makefile.am | 9 ++------- test/fuzzing/README | 6 ++---- 3 files changed, 20 insertions(+), 11 deletions(-) commit e0082ae60dbd87d433f3b2b9d2bfa64b9a4c3663 Author: Behdad Esfahbod Date: Tue Nov 17 18:42:13 2015 -0800 Move things around src/hb-private.hh | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) commit dde8cc87bd880bd35baf764820f4c85bd0a58696 Merge: e97835ad 167c3271 Author: Behdad Esfahbod Date: Tue Nov 17 18:40:10 2015 -0800 Merge pull request #163 from fanc999/msvc.src Update the sources so they will compile under Visual Studio commit 167c3271778cd1a8c4433b9d2230901ce17c099e Author: Chun-wei Fan Date: Mon Nov 9 17:17:56 2015 +0800 Fix build on MSVC >= 2012 Use the DEFINE_ENUM_FLAG_OPERATORS macro in winnt.h on Visual Studio, which defines the bitwise operators for the enumerations that we want to mark as hb_mark_as_flags_t, which will take care of the situation on newer Visual Studio (>= 2012), where the build breaks with C2057 errors as the underlying types of the enumerations is not clear to the compiler when we do a bitwise op within the declaration of the enumerations themselves. Also disable the C4200 (nonstandard extension used : zero-sized array in struct/union) and C4800 ('type' : forcing value to bool 'true' or 'false' (performance warning)) warnings as the C4200 is the intended scenario and C4800 is harmless but is so far an unavoidable side effect of using DEFINE_ENUM_FLAG_OPERATORS. src/hb-buffer-private.hh | 6 +++--- src/hb-ot-layout-common-private.hh | 2 +- src/hb-ot-layout-private.hh | 4 ++-- src/hb-ot-map-private.hh | 2 +- src/hb-private.hh | 11 +++++++++++ 5 files changed, 18 insertions(+), 7 deletions(-) commit 4d27bb87468a1b84387e7ce084e3d92c0fc8f065 Author: Chun-wei Fan Date: Fri Nov 6 14:28:30 2015 +0800 hb-ot-shape-complex-arabic.cc: Fix build on Visual Studio Visual Studio does not like declaring a enum variable within a for statement, so fix the build by declaring the enum before doing the for loop. src/hb-ot-shape-complex-arabic.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit a49e7b7e40127beba25f39ef3c10d7a77e2bb0f0 Author: Chun-wei Fan Date: Tue Nov 3 18:49:34 2015 +0800 MSVC builds: Add fallback implementation for pre-2013 MSVC Pre-2013 MSVC does not have scalbn() and scalbnf(), which are used in the utility programs. Add fallback implementations for these, which can be used when necessary. util/options.hh | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) commit 998e8dda938cfef0146f1bfc4e8973a0e12d7d35 Author: Chun-wei Fan Date: Mon Nov 2 16:55:29 2015 +0800 util: Fix build on Visual Studio Use the fallback implementation for lround() only on pre-2013 Visual Studio, and ensure we are clear about the types of the parameters for lround() and scalbnf(), since Visual Studio can be quite picky on ambiguous parameter types. Also, use g_ascii_strcasecmp() rather than strcasecmp() as we are already using GLib for this code and we are assured that g_ascii_strcasemp() is available. For scalbnf() on pre-2013 Visaul Studio, a fallback implementation is needed, but use another forced-included header for those compilers, which will be added later. Also use (char)27 on Visual Studio builds as '\e' is not a recognized escape sequence, which will do the same thing. util/ansi-print.cc | 16 +++++++++------- util/helper-cairo.cc | 20 ++++++++++---------- util/options.cc | 2 +- 3 files changed, 20 insertions(+), 18 deletions(-) commit e97835ad43f5c68e8cb29599246cae0f4461d663 Author: Behdad Esfahbod Date: Tue Nov 10 11:37:01 2015 -0800 [util] Fix crash when --output-file is specified but not --output-format util/options.hh | 3 +++ 1 file changed, 3 insertions(+) commit d5f0d7c9fb14255388ab616f56e178cb7ca10ec2 Merge: 04ff23e7 529a9331 Author: Behdad Esfahbod Date: Sat Nov 7 07:50:58 2015 -0800 Merge pull request #167 from KonstantinRitt/unicode_cp_opt Micro optimizations to UTF-16 and UTF-32 codecs commit 04ff23e73d847ab3a5da0e9fac4fbca19aefd284 Author: Behdad Esfahbod Date: Fri Nov 6 16:29:44 2015 -0800 [arabic] Improve stretch length calculation Err on the side of being too short, than too wide. Reduces chance of overlaps with neighboring glyphs. src/hb-ot-shape-complex-arabic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 59821ab8b413df3a444c38b80582a5137e364a70 Author: Behdad Esfahbod Date: Fri Nov 6 16:27:44 2015 -0800 [arabic] Don't stretch over cased letters Addresses https://github.com/behdad/harfbuzz/commit/6e6f82b6f3dde0fc6c3c7d991d9ec6cfff57823d#commitcomment-14248516 src/hb-ot-shape-complex-arabic.cc | 24 +++++++++++++++++++++- src/hb-unicode-private.hh | 20 ------------------ .../script-syriac/misc/abbreviation-mark.txt | 4 ++-- 3 files changed, 25 insertions(+), 23 deletions(-) commit 5337db29af39084d677a63154f404eca0c20cfeb Author: Behdad Esfahbod Date: Fri Nov 6 16:18:09 2015 -0800 Revert "Don't process lookups if buffer is in error" This reverts commit f92bd86cc8c11d262d1830c631cb7c63fc9d4bc8. We don't want to be like cairo, where as soon as there's an error, nothing works anymore. So, lets process lookups as long as there's no new memory needed. That's also a model that hides fewer bugs. src/hb-ot-layout.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 529a93312815dff3c2f37f880bf6ccb428bd3da0 Author: Konstantin Ritt Date: Sat Nov 7 02:00:04 2015 +0400 Micro optimization to hb_utf16_t and hb_utf32_t ::prev() Implement reverse lookup instead of re-using next() src/hb-utf-private.hh | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) commit 44ae9be7a29eebd6003cad2fdb90b40512a9c8eb Author: Konstantin Ritt Date: Sat Nov 7 01:58:38 2015 +0400 Nano optimization to hb_utf16_t and hb_utf32_t ::next() src/hb-utf-private.hh | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) commit a6d7668a954a763a053f8af8edbff4731aa43729 Author: Behdad Esfahbod Date: Fri Nov 6 09:46:54 2015 -0800 [fuzzing] Cap max buffer len at 128 test/fuzzing/Makefile.am | 1 + 1 file changed, 1 insertion(+) commit f1c4adbcd3f6275e81e118ddadc9396f82daeccf Author: Behdad Esfahbod Date: Fri Nov 6 09:46:05 2015 -0800 Fix typo src/hb-buffer-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 68b507a3c3c62c28c38e13fee733702bb703b6ca Author: Behdad Esfahbod Date: Fri Nov 6 00:09:26 2015 -0800 Make sure we make progress in OOM situations src/hb-buffer-private.hh | 7 ++----- src/hb-buffer.cc | 31 +++++++++++++++++++++++-------- 2 files changed, 25 insertions(+), 13 deletions(-) commit 5a7eb5d4d862f402136044c19ead87ad098bd78f Author: Behdad Esfahbod Date: Fri Nov 6 00:01:24 2015 -0800 [fuzzing] Add test case for OOM From https://github.com/behdad/harfbuzz/issues/161 .../sha1sum/3511ff5c1647150595846ac414c595cccac34f18.ttf | Bin 0 -> 1483 bytes test/shaping/fonts/sha1sum/MANIFEST | 2 +- test/shaping/tests/fuzzed.tests | 1 + 3 files changed, 2 insertions(+), 1 deletion(-) commit f0599db761d7fc2d585d86e757a797f75ebc7499 Author: Behdad Esfahbod Date: Thu Nov 5 23:52:41 2015 -0800 Fix hang in OOM situations Fixes https://github.com/behdad/harfbuzz/issues/161 src/hb-buffer-private.hh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit f92bd86cc8c11d262d1830c631cb7c63fc9d4bc8 Author: Behdad Esfahbod Date: Thu Nov 5 23:52:29 2015 -0800 Don't process lookups if buffer is in error src/hb-ot-layout.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4301703bddb63a01651a0d58474bb15ac0ebbcf6 Author: Behdad Esfahbod Date: Thu Nov 5 23:44:59 2015 -0800 Limit buffer max size growth https://github.com/behdad/harfbuzz/issues/161 src/hb-buffer-private.hh | 11 +++++++++++ src/hb-buffer.cc | 8 ++++++++ src/hb-ot-shape.cc | 6 ++++++ test/fuzzing/Makefile.am | 2 ++ 4 files changed, 27 insertions(+) commit 19300183a6f0bac0d23f7a994b40a51e9c90d6e1 Author: Behdad Esfahbod Date: Thu Nov 5 23:08:50 2015 -0800 [fuzzing] Add build system configure.ac | 1 + test/Makefile.am | 2 +- test/fuzzing/Makefile.am | 44 ++++++++++++++++++++++++++++++++++++++++++++ test/fuzzing/README | 2 ++ test/fuzzing/hb-fuzzer.cc | 4 ++-- 5 files changed, 50 insertions(+), 3 deletions(-) commit 9c9ad214af43685b00f6d8493b7807d6607d4e2d Author: Behdad Esfahbod Date: Thu Nov 5 22:50:52 2015 -0800 [fuzzer] Add README https://github.com/behdad/harfbuzz/issues/139#issuecomment-154202645 test/fuzzing/README | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) commit 6e6f82b6f3dde0fc6c3c7d991d9ec6cfff57823d Author: Behdad Esfahbod Date: Thu Nov 5 17:29:03 2015 -0800 Implement SYRIAC ABBREVIATION MARK with 'stch' feature The feature is enabled for any character in the Arabic shaper. We should experiment with using it for Arabic subtending marks. Though, that has a directionality problem as well, since those are used with digits... Fixes https://github.com/behdad/harfbuzz/issues/141 src/hb-ot-shape-complex-arabic.cc | 219 ++++++++++++++++++++- src/hb-unicode-private.hh | 19 ++ .../shaper-arabic/script-syriac/misc/MANIFEST | 1 + .../script-syriac/misc/abbreviation-mark.txt | 11 ++ 4 files changed, 244 insertions(+), 6 deletions(-) commit c743ec5886a1f6d57de26da33a770a8706be83d6 Author: Behdad Esfahbod Date: Thu Nov 5 17:33:57 2015 -0800 [ft] Fix extents with negative scales Fixes https://github.com/behdad/harfbuzz/issues/162 src/hb-ft.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) commit 73fec3992acb492829bde1d885f1ebeed8dcc133 Author: Behdad Esfahbod Date: Thu Nov 5 15:22:18 2015 -0800 Reserve a few scratch-flags bits for complex shapers src/hb-buffer-private.hh | 5 +++++ 1 file changed, 5 insertions(+) commit 136863371c1402769426d892aef1b92f9ca1a25e Author: Behdad Esfahbod Date: Thu Nov 5 13:24:15 2015 -0800 Add new shaper method postprocess_glyphs() Unused currently. To be used for Syriac stretch implementation. https://github.com/behdad/harfbuzz/issues/141 src/hb-ot-shape-complex-arabic.cc | 3 ++- src/hb-ot-shape-complex-default.cc | 1 + src/hb-ot-shape-complex-hangul.cc | 7 ++++--- src/hb-ot-shape-complex-hebrew.cc | 1 + src/hb-ot-shape-complex-indic.cc | 1 + src/hb-ot-shape-complex-myanmar.cc | 2 ++ src/hb-ot-shape-complex-private.hh | 9 +++++++++ src/hb-ot-shape-complex-thai.cc | 1 + src/hb-ot-shape-complex-tibetan.cc | 1 + src/hb-ot-shape-complex-use.cc | 1 + src/hb-ot-shape.cc | 9 ++++++--- 11 files changed, 29 insertions(+), 7 deletions(-) commit 6c0ebd02c99e7536975ba7194832a1f33abd7faf Author: Behdad Esfahbod Date: Thu Nov 5 11:37:48 2015 -0800 [util] If font has color, generate PNG with color util/helper-cairo.cc | 33 ++++++++++++++++++++++++++------- util/helper-cairo.hh | 6 +++++- util/view-cairo.cc | 7 ++++++- 3 files changed, 37 insertions(+), 9 deletions(-) commit e95eb23a4ee920eab1e2f4eec9cf490bb431452c Author: Behdad Esfahbod Date: Wed Nov 4 22:55:11 2015 -0800 Don't try zeroing marks by GDEF if there are no non-ASCII This one is a hack, but should be ok. src/hb-ot-shape.cc | 4 ++++ 1 file changed, 4 insertions(+) commit 7fa54ed75aa30ae1d6ee9136ccb83b630c24fb65 Author: Behdad Esfahbod Date: Wed Nov 4 22:54:49 2015 -0800 Don't try zeroing mark attachments by Unicode if there's no non-ASCII src/hb-ot-shape.cc | 3 +++ 1 file changed, 3 insertions(+) commit 550bd14d2b21ec2a2b509ff42f4df4341dbf2d46 Author: Behdad Esfahbod Date: Wed Nov 4 22:58:58 2015 -0800 Actually commit changes for previous commit src/hb-buffer-private.hh | 2 ++ src/hb-ot-layout-gpos-table.hh | 15 ++++++++------- 2 files changed, 10 insertions(+), 7 deletions(-) commit ff31b3c1b8a2a21b57dba37eb5bb5db0579e0640 Author: Behdad Esfahbod Date: Wed Nov 4 22:42:41 2015 -0800 Skip GPOS cursive / attachment adjustmnent if none happened I'm starting to really like how free these new scratch_flags are. src/hb-ot-layout-gpos-table.hh | 3 +++ 1 file changed, 3 insertions(+) commit 0f407325f6923db11d332585e8250e3646cb74d6 Author: Behdad Esfahbod Date: Wed Nov 4 22:28:44 2015 -0800 Minor src/hb-ot-shape.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 497a6c2071cd0638e4c6af07621d01335fd963a9 Author: Behdad Esfahbod Date: Wed Nov 4 22:24:19 2015 -0800 Skip forming clusters if text is all ASCII src/hb-ot-shape.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 28de104f15b80df4b678267c4488b7d09a42720c Author: Behdad Esfahbod Date: Wed Nov 4 22:00:25 2015 -0800 Move variable-sized struct member to end Hopefully makes clang build happy src/hb-font-private.hh | 21 ++++++++++----------- src/hb-font.cc | 20 ++++++++++++++++++++ 2 files changed, 30 insertions(+), 11 deletions(-) commit 5bc28b5f688ee90d103d052e98bc15d6e0e7e0b1 Author: Behdad Esfahbod Date: Wed Nov 4 21:53:16 2015 -0800 Optimize positioning for when h_origin is nil src/hb-ot-shape.cc | 38 ++++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 18 deletions(-) commit 762770c964f9f0591bf4c44427f73ea3e1c51733 Author: Behdad Esfahbod Date: Wed Nov 4 21:42:55 2015 -0800 Add font->has_...() to check for individual nil font funcs Hopefully this wouldn't break any compiler. There was some magic moments to getting this to compile... src/hb-font-private.hh | 19 +++++++++++++++++-- src/hb-font.cc | 7 +++++++ 2 files changed, 24 insertions(+), 2 deletions(-) commit 88e9a9bcae61421d9dd65715d25e5f20b2847c03 Author: Behdad Esfahbod Date: Wed Nov 4 21:16:26 2015 -0800 Minor reshaping of hb_font_funcs_t implementation In anticipation of further changes. No functional changes. src/hb-font-private.hh | 80 ++++++++++++++++++++++++++------------------------ src/hb-font.cc | 4 +-- 2 files changed, 43 insertions(+), 41 deletions(-) commit a6a7715bac8b0c8f5473b84bc649c315ad4d2d51 Author: Behdad Esfahbod Date: Wed Nov 4 20:51:21 2015 -0800 Comments src/hb-font-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6c48ec830ffac00a920d047ed77acd1b05549074 Author: Behdad Esfahbod Date: Wed Nov 4 20:47:42 2015 -0800 [ot] Remove font funcs that do nothing src/hb-ot-font.cc | 95 ++++--------------------------------------------------- 1 file changed, 7 insertions(+), 88 deletions(-) commit 75ea2daa1d9bbe235cd4a8570efb1913d58c3c62 Author: Behdad Esfahbod Date: Wed Nov 4 20:43:59 2015 -0800 [ot] Port ot font funcs to allocated object src/hb-ot-font.cc | 47 ++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 38 insertions(+), 9 deletions(-) commit 44f82750807475aa5b16099ccccd917d488df703 Author: Behdad Esfahbod Date: Wed Nov 4 20:40:05 2015 -0800 [ft] Remove font funcs that do nothing src/hb-ft.cc | 29 ++++------------------------- 1 file changed, 4 insertions(+), 25 deletions(-) commit 7918c261efd283e0428ce7836e9e42768a6aa05c Author: Behdad Esfahbod Date: Wed Nov 4 20:37:49 2015 -0800 [ft] Port ft font funcs to allocated object src/hb-ft.cc | 45 ++++++++++++++++++++++++++++++++++++--------- 1 file changed, 36 insertions(+), 9 deletions(-) commit da29b43794cfa3f9a602c34b33c5d8a9c36f87b5 Author: Behdad Esfahbod Date: Wed Nov 4 20:22:44 2015 -0800 Separate nil font-funcs from parent-peeking font-funcs API change: all fonts created with hb_font_create() now inherit from (ie have parent) hb_font_get_empty(). src/hb-font.cc | 211 +++++++++++++++++++++++++++++++++++---------------- test/api/test-font.c | 2 +- 2 files changed, 145 insertions(+), 68 deletions(-) commit bee901b38ef3c26a04f69c299c8d5e028a0090e9 Author: Behdad Esfahbod Date: Wed Nov 4 19:28:17 2015 -0800 Optimize positioning direction calculations It makes the binary smaller AND faster. Yumm! src/hb-font-private.hh | 40 +++++++++++++++++++++++++++++++++++++++ src/hb-ot-shape.cc | 51 +++++++++++++++++++++++++++----------------------- 2 files changed, 68 insertions(+), 23 deletions(-) commit e3e4bb011ae1a2f1ba05e7ea450595b185304bec Author: Behdad Esfahbod Date: Wed Nov 4 18:58:02 2015 -0800 Don't do fractions if buffer is ASCII-only src/hb-buffer-private.hh | 5 +++-- src/hb-ot-layout-private.hh | 1 + src/hb-ot-shape.cc | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) commit 6986208ba3b395534f4c7bcfa51df6bf9038f717 Author: Behdad Esfahbod Date: Wed Nov 4 18:46:22 2015 -0800 Optimize runs without Default_Ignorable's Now that we have a buffer-wide scratch flags facility, use it to optimize away a few passes. src/hb-buffer-private.hh | 3 ++- src/hb-ot-layout-private.hh | 4 +++- src/hb-ot-shape-normalize.cc | 4 ++-- src/hb-ot-shape.cc | 10 ++++++---- src/hb-private.hh | 3 +++ 5 files changed, 16 insertions(+), 8 deletions(-) commit 14c2de321826c36037adde859ccca3e2011325a9 Author: Behdad Esfahbod Date: Wed Nov 4 18:00:57 2015 -0800 Limit max edits during sanitize to 8 Used to be 100. If a tabe needs more than one or two edits, it's probably completely bogus... Might help with speeding up fuzzing for https://github.com/behdad/harfbuzz/issues/157 src/hb-open-type-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9cbc39aef962a95b0eba32c24ff9c415d1316d56 Author: Behdad Esfahbod Date: Wed Nov 4 18:00:53 2015 -0800 Minor src/hb-ot-shape-normalize.cc | 2 ++ 1 file changed, 2 insertions(+) commit 52e6c4e15893ed1cb0997795912a07b3e446b65a Author: Behdad Esfahbod Date: Wed Nov 4 17:45:06 2015 -0800 If font doesn't support U+2011, fall back to U+2010 Test passes now. src/hb-ot-shape-normalize.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) commit 75483aafa6ad02d6391712d082d093823edcd758 Author: Behdad Esfahbod Date: Wed Nov 4 17:43:36 2015 -0800 Untangle if/else waterfall src/hb-ot-shape-normalize.cc | 40 +++++++++++++++++++++++++++------------- 1 file changed, 27 insertions(+), 13 deletions(-) commit 04fd8517f85ae9aa05b44f25578d2b19abfef7cb Author: Behdad Esfahbod Date: Wed Nov 4 17:38:22 2015 -0800 Add tests for hyphen fallback U+2011 is equivaent of U+2010, so we should do the fallback for it. Currently fails. test/shaping/Makefile.am | 1 + .../sha1sum/1c04a16f32a39c26c851b7fc014d2e8d298ba2b8.ttf | Bin 0 -> 820 bytes test/shaping/fonts/sha1sum/MANIFEST | 2 ++ test/shaping/tests/MANIFEST | 1 + test/shaping/tests/hyphens.tests | 2 ++ 5 files changed, 6 insertions(+) commit 550417117da7e14457a11f49a20145311f58587b Author: Behdad Esfahbod Date: Wed Nov 4 17:37:30 2015 -0800 [test] Drop hintings when subsetting fonts to record test/shaping/record-test.sh | 1 + 1 file changed, 1 insertion(+) commit 49ef630936325b2e56a870fcef9aa8473a8f8526 Author: Behdad Esfahbod Date: Wed Nov 4 17:27:07 2015 -0800 Adjust the width of various spaces if font does not cover them See discussion here: https://github.com/behdad/harfbuzz/commit/81ef4f407d9c7bd98cf62cef951dc538b13442eb There's no way to disable this fallback, but I don't think it would be needed. Let's hope for the best! Fixes https://github.com/behdad/harfbuzz/issues/153 src/hb-buffer-private.hh | 7 ++++ src/hb-buffer.cc | 2 ++ src/hb-ot-shape-fallback-private.hh | 4 +++ src/hb-ot-shape-fallback.cc | 67 +++++++++++++++++++++++++++++++++++++ src/hb-ot-shape-normalize.cc | 1 + src/hb-ot-shape.cc | 3 ++ src/hb-unicode-private.hh | 56 +++++++++++++++++-------------- test/shaping/tests/spaces.tests | 24 ++++++------- 8 files changed, 126 insertions(+), 38 deletions(-) commit aa7044de0ceacd71cab19212d266c3a66c03b41e Author: Behdad Esfahbod Date: Wed Nov 4 16:25:57 2015 -0800 Generalize flags types src/hb-buffer-private.hh | 3 +++ src/hb-ot-layout-common-private.hh | 5 +++++ src/hb-ot-layout-private.hh | 8 +++++--- src/hb-ot-map-private.hh | 16 +--------------- src/hb-ot-shape.cc | 2 +- src/hb-private.hh | 14 ++++++++++++++ 6 files changed, 29 insertions(+), 19 deletions(-) commit 7793aad946e09b53523b30d57de85abd1d15f8b6 Author: Behdad Esfahbod Date: Wed Nov 4 14:48:46 2015 -0800 Normalize various spaces to space if font doesn't support This resurrects the space fallback feature, after I disabled the compatibility decomposition. Now I can release HarfBuzz again without breaking Pango! It also remembers which space character it was, such that later on we can approximate the width of this particular space character. That part is not implemented yet. We normalize all GC=Zs chars except for U+1680 OGHA SPACE MARK, which is better left alone. src/hb-ot-layout-private.hh | 47 +++------------------ src/hb-ot-shape-normalize.cc | 12 +++++- src/hb-unicode-private.hh | 40 ++++++++++++++++++ test/shaping/Makefile.am | 1 + .../1c2c3fc37b2d4c3cb2ef726c6cdaaabd4b7f3eb9.ttf | Bin 0 -> 316 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 + test/shaping/tests/MANIFEST | 1 + test/shaping/tests/spaces.tests | 17 ++++++++ 8 files changed, 76 insertions(+), 43 deletions(-) commit 8b3c7f9ede77052225cff8495d660860bf9c7629 Author: Behdad Esfahbod Date: Wed Nov 4 15:30:48 2015 -0800 [test] Support recording multiple lines of text in record-test.sh test/shaping/record-test.sh | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) commit 85658394809fe0593ab5dfb30fd96118765c7dc5 Author: Behdad Esfahbod Date: Wed Nov 4 14:46:52 2015 -0800 Protect against possible invalid-memory access after OOM src/hb-buffer-private.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 4cc80bed25450af3d84a30ea417fa9275b15e014 Author: Behdad Esfahbod Date: Wed Nov 4 14:46:10 2015 -0800 Fix typo! Ouch! Fortunately that function was unused. src/hb-buffer-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9ac4b9656dd78ffd129bc3d560a92e2692bc3058 Author: Behdad Esfahbod Date: Wed Nov 4 14:18:39 2015 -0800 Add Unicode space category Unused so far. src/hb-ot-layout-private.hh | 78 +++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 76 insertions(+), 2 deletions(-) commit 8249ec3f86510fd24462ce71ed64a6978f0ade17 Author: Behdad Esfahbod Date: Wed Nov 4 13:26:17 2015 -0800 Make top-byte of unicode_props available to be used differently per-GC src/hb-ot-layout-private.hh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit cc5d3a33882b52f906ee4346707700f5e846d2ac Author: Behdad Esfahbod Date: Wed Nov 4 13:21:25 2015 -0800 Towards using top-byte of unicode-props for more things src/hb-ot-layout-gsubgpos-private.hh | 1 - src/hb-ot-layout-private.hh | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) commit 2f38dde5a1ea5459789fabaee661cae9235d204e Author: Behdad Esfahbod Date: Wed Nov 4 13:17:33 2015 -0800 Add _hb_glyph_info_is_unicode_mark() Unused right now. src/hb-ot-layout-private.hh | 6 ++++++ 1 file changed, 6 insertions(+) commit 90d75f93bb85aeb627c4e6bb9e4cbd75895c99f7 Author: Behdad Esfahbod Date: Tue Nov 3 12:58:12 2015 -0800 Tighten ccc-setting a bit and document it src/hb-ot-layout-private.hh | 12 +++++++++++- src/hb-unicode-private.hh | 5 +++++ 2 files changed, 16 insertions(+), 1 deletion(-) commit 2f0dfd43cdc2259e6117704f8077ab6951c761e5 Author: Behdad Esfahbod Date: Tue Nov 3 12:28:34 2015 -0800 Fix test expectation test/shaping/tests/fuzzed.tests | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit df698f3299d92867e3305715f675b2621c316acd Author: Behdad Esfahbod Date: Tue Nov 3 12:15:12 2015 -0800 [ot-font] Fix hmtx table length checking, *again* Exactly the same problem that I fixed in 63ef0b41dc48d6112d1918c1b1de9de8ea90adb5 I rewrote the table checking yesterday in 67f8821fb25d9bd55719f5e29a582ae1af4b02b3 and introduced the exact same issue again. :( Good thing we have ongoing fuzzing going now. Was discovered immediately by libFuzzer. Thanks kcc! https://github.com/behdad/harfbuzz/issues/139#issuecomment-153449473 Fixes https://github.com/behdad/harfbuzz/issues/156 src/hb-ot-font.cc | 4 ++-- .../sha1sum/8240789f6d12d4cfc4b5e8e6f246c3701bcf861f.ttf | Bin 0 -> 633 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 + test/shaping/tests/fuzzed.tests | 1 + 4 files changed, 4 insertions(+), 2 deletions(-) commit 3530cc2d7c3b7102902cb0e38b0bf9f46188078d Author: Behdad Esfahbod Date: Tue Nov 3 11:34:47 2015 -0800 [util] Fix option-parsing leaks util/helper-cairo.cc | 7 +++++-- util/main-font-text.hh | 22 ++++++++++++++++++--- util/options.cc | 21 ++++++++++---------- util/options.hh | 53 +++++++++++++++++++++++++++++++++----------------- 4 files changed, 70 insertions(+), 33 deletions(-) commit 642135f3b2d6d6eb800153c76c4718239733c0e6 Author: Behdad Esfahbod Date: Tue Nov 3 11:26:34 2015 -0800 [util] In --debug mode, duplicate font data This has the effect that the font data will end up in a memory section malloc()ed exactly to its size. This gives us better valgrind detection of out-of-bounds access. Previously, the font data was placed in a mmap()ed section or GString-allocated area, which didn't have proper protections at the end when running under valgrind. util/options.cc | 3 +++ 1 file changed, 3 insertions(+) commit ed2024ef93ac3af214082016e5aa8c14db9d7515 Author: Behdad Esfahbod Date: Mon Nov 2 17:58:12 2015 -0800 [perf] Micro-optimize src/hb-ot-layout-private.hh | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) commit 76a5310a830c7ae12037b768c5043bef0ff733a0 Author: Behdad Esfahbod Date: Mon Nov 2 17:52:45 2015 -0800 Remove irrelevant comment I tried moving the is_default_ignorable() function to an INTERNAL function. That made the binary size grow by 5k AND things got a tad bit slower! src/hb-ot-layout-private.hh | 1 - 1 file changed, 1 deletion(-) commit 8259669fbd1b070fc02287325894caf1bc4d590e Author: Behdad Esfahbod Date: Mon Nov 2 17:44:05 2015 -0800 Minor src/hb-ot-layout-gsubgpos-private.hh | 2 +- src/hb-ot-shape-complex-thai.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 9382c471eabce8d36d3a73c97499ab60af422716 Author: Behdad Esfahbod Date: Mon Nov 2 17:36:51 2015 -0800 Combine unicode_props0/1 into a uint16 Slightly faster. In prep for more changes. src/hb-ot-layout-private.hh | 55 ++++++++++++++++++++++++--------------------- 1 file changed, 29 insertions(+), 26 deletions(-) commit 71277185454482cff9b0c10b85c416eb4d6e0ed9 Author: Behdad Esfahbod Date: Mon Nov 2 17:27:48 2015 -0800 [perf] Only call combining_class() for marks Saves some time. Also preparing for reusing the ccc byte for other stuff. src/hb-ot-layout-private.hh | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) commit 5ba450407b9d9856453e63a815499da8721ff6a7 Author: Behdad Esfahbod Date: Mon Nov 2 15:43:08 2015 -0800 Make max context-length and max nesting level configurable ...at compile time. src/hb-ot-layout-common-private.hh | 10 ++++++++-- src/hb-ot-layout-gsub-table.hh | 4 ++-- src/hb-ot-layout-gsubgpos-private.hh | 20 ++++++++++---------- 3 files changed, 20 insertions(+), 14 deletions(-) commit 67f8821fb25d9bd55719f5e29a582ae1af4b02b3 Author: Behdad Esfahbod Date: Mon Nov 2 15:37:29 2015 -0800 [ot] Make bad-hmtx handling match FreeType Also route fuzzing-related tests through hb-ot-font, to reduce dependency on FreeType behavior for badly-broken fonts. Fixes failing test with FreeType master. src/hb-ot-font.cc | 24 ++++++++++++++---------- test/shaping/tests/fuzzed.tests | 10 +++++----- 2 files changed, 19 insertions(+), 15 deletions(-) commit 672ca3b4e65a75fb3a418ec5d117ad242a98acbb Author: Behdad Esfahbod Date: Mon Oct 26 14:05:05 2015 -0700 Use templates for making sure expression is constant src/hb-private.hh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 5c8174eda32c08187bc2ed40eefa1017f5b40668 Author: Behdad Esfahbod Date: Wed Oct 21 18:51:40 2015 -0200 Update comments for removal of compat decompositions src/hb-ot-shape-normalize.cc | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) commit f6799700404c49ae0a6018fd51be19551c76768a Author: Behdad Esfahbod Date: Wed Oct 21 17:20:55 2015 -0200 Disable compatibility decomposition usage during normalization Fixes https://github.com/behdad/harfbuzz/issues/152 src/hb-ot-shape-normalize.cc | 24 ------------------------ 1 file changed, 24 deletions(-) commit ce889189c1f8ef5b400a17f623dcb8b935d1102b Author: Behdad Esfahbod Date: Wed Oct 21 11:23:12 2015 -0200 Fix two more -Wshadow warnings https://bugzilla.mozilla.org/show_bug.cgi?id=1215894 src/hb-open-type-private.hh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit 4a6b1eedbb0044b57505eea65a329d2dc4f9f917 Author: Behdad Esfahbod Date: Wed Oct 21 11:20:55 2015 -0200 Fix one more -Wshadow warning https://bugzilla.mozilla.org/show_bug.cgi?id=1215894 src/hb-ot-layout-gsubgpos-private.hh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 6f932bc8f9045b224613a617af2b4f3450c79467 Author: Behdad Esfahbod Date: Wed Oct 21 11:16:49 2015 -0200 Fix a few more -Wshadow-local warnings https://bugzilla.mozilla.org/show_bug.cgi?id=1215894 src/hb-ot-shape-complex-indic.cc | 10 +++++----- src/hb-ot-shape-complex-myanmar.cc | 10 +++++----- src/hb-ot-shape-complex-use.cc | 10 +++++----- 3 files changed, 15 insertions(+), 15 deletions(-) commit b90cb366d7723c28758c6b75a0770613fbb5456e Author: Behdad Esfahbod Date: Wed Oct 21 11:13:21 2015 -0200 Fix one -Wshadow-compatible-local warning From https://bugzilla.mozilla.org/show_bug.cgi?id=1215894 src/hb-ot-shape-complex-indic.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 50e5750bd8670b4cf4463471a2348d4c99c9d054 Author: Behdad Esfahbod Date: Wed Oct 21 11:10:10 2015 -0200 Avoid unnecessary cast to 64-bit Fixes https://github.com/behdad/harfbuzz/issues/146 Or I think it should. src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 305d2fbf5a2db51447c8ed894a48a88896930673 Author: Behdad Esfahbod Date: Wed Oct 21 11:04:28 2015 -0200 Add HB_FALLTHROUGH Borrowed from https://bugzilla.mozilla.org/show_bug.cgi?id=1215411 src/hb-ot-shape-complex-indic.cc | 2 +- src/hb-ot-shape-complex-thai.cc | 2 +- src/hb-ot-shape-fallback.cc | 4 +++- src/hb-private.hh | 30 ++++++++++++++++++++++++++++++ 4 files changed, 35 insertions(+), 3 deletions(-) commit f35b3e931ddacd075c5d0810e9b17de07b232ee2 Author: Ebrahim Byagowi Date: Fri Sep 11 09:48:12 2015 +0430 Add a prototype of DirectWrite as a shaping backend src/hb-directwrite.cc | 827 ++++++++++++++++++++++++++++++++++++++++++++++++++ src/hb-directwrite.h | 34 +++ src/hb-shaper-list.hh | 3 + 3 files changed, 864 insertions(+) commit 6486e3755482563ecd89aeb3f8348ed190945e26 Author: Behdad Esfahbod Date: Tue Oct 20 16:39:41 2015 -0200 Fix typo Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 753ea7b90904c951c199861409458bea182abb37 Author: Behdad Esfahbod Date: Tue Oct 20 15:21:18 2015 -0200 Add BUILD.md to dist Makefile.am | 1 + 1 file changed, 1 insertion(+) commit 5d7a30fde09320c2c62c7c73570ce3f2e298eba6 Merge: 904b0dc3 2fb95a0c Author: Behdad Esfahbod Date: Tue Oct 20 15:19:41 2015 -0200 Merge pull request #148 from ebraminio/inst Add BUILD.md based on harfbuzz.org docs commit 904b0dc3811464cf61dc9457664de95ee4f61a86 Merge: 86cadc2c ba096bcc Author: Behdad Esfahbod Date: Mon Oct 19 16:59:43 2015 -0200 Merge pull request #147 from ebraminio/dockerci [ci] change to docker infrastructure commit ba096bcc28ca80e2096e0a15191848fcd175e395 Author: Ebrahim Byagowi Date: Mon Oct 19 21:41:01 2015 +0330 [ci] change to docker infrastructure .travis.yml | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) commit 2fb95a0c9d2cb8b03b7c158706d6b0e41283a6df Author: Ebrahim Byagowi Date: Mon Oct 19 22:02:12 2015 +0330 Add BUILD.md based on harfbuzz.org docs BUILD.md | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) commit 86cadc2cd4171050e9d74306b76c42f6ec74b861 Author: Behdad Esfahbod Date: Thu Oct 15 20:25:29 2015 -0300 1.0.6 NEWS | 13 +++++++++++++ configure.ac | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) commit ca97ea7aa2cb7186f432aaba76f4f151aa90c1d0 Author: Behdad Esfahbod Date: Thu Oct 15 20:20:22 2015 -0300 [ft] Revert change-of-behavior of hb_ft_font_create() introduced in 1.0.5 The default FreeType load flags where changed from FT_LOAD_NO_HINTING to FT_LOAD_DEFAULT in 2a9627c5641cd000e2adff0e42a0dc687b53ec70. This is crashing HarfBuzz-enabled FreeType as I suppose it causes infinite recursion between HB and FT autohinter... Revert the behavior change. Fixes https://github.com/behdad/harfbuzz/issues/143 src/hb-ft.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 338ffec9e4a5819f2be21c3a320a567378c977b1 Author: Behdad Esfahbod Date: Thu Oct 15 12:55:57 2015 -0300 Add tests for a couple of fixed issues found by libFuzzer From: https://github.com/behdad/harfbuzz/issues/139#issuecomment-147616887 https://github.com/behdad/harfbuzz/issues/139#issuecomment-148289957 .../sha1sum/375d6ae32a3cbe52fbf81a4e5777e3377675d5a3.ttf | Bin 0 -> 1024 bytes .../sha1sum/641bd9db850193064d17575053ae2bf8ec149ddc.ttf | Bin 0 -> 305 bytes test/shaping/fonts/sha1sum/MANIFEST | 2 ++ test/shaping/tests/fuzzed.tests | 2 ++ 4 files changed, 4 insertions(+) commit 63ef0b41dc48d6112d1918c1b1de9de8ea90adb5 Author: Behdad Esfahbod Date: Thu Oct 15 12:47:22 2015 -0300 [ot-font] Fix hmtx wrong table length check Discovered by libFuzzer. Ouch! https://github.com/behdad/harfbuzz/issues/139#issuecomment-148289957 src/hb-ot-font.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 613e630617074eb9b62b794cc37c9b42a7fb079b Author: Behdad Esfahbod Date: Tue Oct 13 23:33:28 2015 -0300 Reduce max nesting level from 8 to 6 We probably should implement better system to catch cyclic lookups. But for now, this speeds up worst case behavior with broken fonts considerably without compromising legitimate usecases. https://github.com/behdad/harfbuzz/issues/139#issuecomment-147788447 src/hb-ot-layout-common-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ab170529246ad80830bef2b3c8b48e9a8d2b7483 Author: Behdad Esfahbod Date: Tue Oct 13 10:55:33 2015 -0300 1.0.5 NEWS | 24 ++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 25 insertions(+), 1 deletion(-) commit ed13e2ce509408f849255be1d3cc3dbd7dbb3ba2 Author: Behdad Esfahbod Date: Tue Oct 13 10:32:56 2015 -0300 [ot-font] Fix leak https://github.com/behdad/harfbuzz/issues/139#issuecomment-147616887 src/hb-ot-font.cc | 1 + 1 file changed, 1 insertion(+) commit 55db94be2b754ba9b9121f09abcf8496c798affc Author: Behdad Esfahbod Date: Tue Oct 13 00:33:59 2015 -0400 Add test for previous commit .../sha1sum/0509e80afb379d16560e9e47bdd7d888bebdebc6.ttf | Bin 0 -> 61 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 + test/shaping/tests/fuzzed.tests | 1 + 3 files changed, 2 insertions(+) commit f96664974774bfeb237a7274f512f64aaafb201e Author: Behdad Esfahbod Date: Tue Oct 13 00:30:50 2015 -0400 Fix another memory access issue discovered by libFuzzer Fixes https://github.com/behdad/harfbuzz/issues/139#issuecomment-146984679 src/hb-ot-layout-gpos-table.hh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit c1a5dc46c2231f7b62421e06b9766ccfebaf3ef5 Author: Behdad Esfahbod Date: Mon Oct 12 17:39:52 2015 -0400 [fuzz] Add fuzzing script from kcc@ https://github.com/behdad/harfbuzz/issues/139 test/fuzzing/hb-fuzzer.cc | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) commit cc6ea308d4c99b9dd6d625fa3a9b0ef62fa2614f Author: Behdad Esfahbod Date: Mon Oct 12 17:21:52 2015 -0400 Extern "C" custom-allocator declerations src/hb-private.hh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 98c6fccc00062ead7a86892dd059aa13d266b981 Author: Behdad Esfahbod Date: Sun Oct 11 21:41:04 2015 -0400 Add test for ee9b0b6cb5fdb08671ab064f26c299135f828260 .../sha1sum/5a5daf5eb5a4db77a2baa3ad9c7a6ed6e0655fa8.ttf | Bin 0 -> 61 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 + test/shaping/tests/fuzzed.tests | 1 + 3 files changed, 2 insertions(+) commit 50f489a0a013fc589626bb532a9f64f50bb41f58 Author: Behdad Esfahbod Date: Sun Oct 11 20:59:29 2015 -0400 Typo src/hb-font-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ee9b0b6cb5fdb08671ab064f26c299135f828260 Author: Behdad Esfahbod Date: Fri Oct 9 14:23:15 2015 -0400 Fix another sanitize bug Also discovered by "libFuzzer". src/hb-open-type-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 34379b49e6922b86c15ee62f7fe3bf016cdc2514 Author: Behdad Esfahbod Date: Fri Oct 9 12:34:02 2015 -0400 Add test for previous fix test/shaping/Makefile.am | 1 + .../sha1sum/1a6f1687b7a221f9f2c834b0b360d3c8463b6daf.ttf | Bin 0 -> 64 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 + test/shaping/tests/MANIFEST | 1 + test/shaping/tests/fuzzed.tests | 1 + 5 files changed, 4 insertions(+) commit f396fbb000dc1c8acddbf6a16e193b328c5e551e Author: Behdad Esfahbod Date: Fri Oct 9 12:25:55 2015 -0400 Fix return value of sanitize when subformat is not readable This is a fix on top of the previous issue fixed in c917965b9e6fe2b21ed6c51559673288fa3af4b7. This was caught by "libFuzzer" testing. src/hb-open-type-private.hh | 2 ++ src/hb-ot-layout-gpos-table.hh | 15 +++++++-------- src/hb-ot-layout-gsub-table.hh | 13 ++++++------- src/hb-ot-layout-gsubgpos-private.hh | 8 ++++---- 4 files changed, 19 insertions(+), 19 deletions(-) commit 77a1a2bc18e7b04d4e352a8777ccce345b2f8659 Author: Behdad Esfahbod Date: Fri Oct 9 12:20:58 2015 -0400 Add hb_dispatch_context_t src/hb-open-type-private.hh | 26 ++++++++++++++++++++++---- src/hb-ot-layout-gsubgpos-private.hh | 36 ++++++++++++------------------------ src/hb-ot-layout.cc | 8 +++----- 3 files changed, 37 insertions(+), 33 deletions(-) commit 3e905e396bcd745bda88e751998a76556c5cb8c6 Author: Behdad Esfahbod Date: Thu Oct 8 12:51:02 2015 -0400 Add hb_font_set_parent() No reason to not have it. Makes life easier later. We (hb-ft, hb-ot-font, etc) can use this API to inject new parent into a font... src/hb-font.cc | 26 ++++++++++++++++++++++++++ src/hb-font.h | 4 ++++ test/api/test-font.c | 12 ++++++++++++ 3 files changed, 42 insertions(+) commit edeb3dabf4a589d67c3f1da7ba43a74e4d3a9afd Author: Behdad Esfahbod Date: Thu Oct 8 12:47:15 2015 -0400 [ft] Add version for new API src/hb-ft.cc | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) commit 2a9627c5641cd000e2adff0e42a0dc687b53ec70 Author: Behdad Esfahbod Date: Wed Oct 7 17:33:20 2015 -0400 [ft] API: Add hb_font_[sg]et_load_flags() API This changes the default load_flags of fonts created using hb_ft_font_create() from NO_HINTING to DEFAULT. Hope that doesn't break too much client code. Code calling hb_ft_font_set_funcs() is unaffected. src/hb-ft.cc | 163 +++++++++++++++++++++++++++++++++++++++-------------------- src/hb-ft.h | 13 +++-- 2 files changed, 118 insertions(+), 58 deletions(-) commit 3224a594dcf2164b5585b4ccba34f244af3f61b9 Author: Behdad Esfahbod Date: Wed Oct 7 17:33:02 2015 -0400 Minor src/hb-ot-font.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 52b418555b62a3b25399f202c1fa72ab7288c224 Author: Behdad Esfahbod Date: Sat Oct 3 13:20:55 2015 +0100 Allow compiling with custom allocators User can define hb_malloc_impl, etc, to name of custom allocator functions that have the same signature as malloc. src/hb-private.hh | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) commit 88da7bba9fa4665b33f5bfcd45add7443097eaf3 Author: Behdad Esfahbod Date: Fri Oct 2 14:38:20 2015 +0100 Default font scale to face upem Makes for a better default and avoids nasty inheritance issues. See mailing list thread "Default hb_font_t scale". src/hb-font.cc | 2 ++ test/api/test-font.c | 13 ++++++++----- 2 files changed, 10 insertions(+), 5 deletions(-) commit 1866e17114b41d565eb066e7d9393c2ff3e0a12b Author: Behdad Esfahbod Date: Fri Oct 2 14:21:29 2015 +0100 Make hb_font_create_sub_font() NOT make parent immutable We don't rely on that. However, whenever hb_font_make_immutable() is called, it makes its parenting chain immutable. src/hb-font.cc | 4 +++- test/api/test-font.c | 21 +++++++++++++++------ 2 files changed, 18 insertions(+), 7 deletions(-) commit 980e25cad2e58c31f5361862b9223d94ec47fc7a Author: Behdad Esfahbod Date: Fri Oct 2 08:21:12 2015 +0100 Fix hb-ot-shape-normalize with empty buffer Part of https://github.com/behdad/harfbuzz/issues/136 src/hb-ot-shape-normalize.cc | 2 ++ 1 file changed, 2 insertions(+) commit a5efaac4ff61b587f228830b265b39fe8e5e4e47 Author: Behdad Esfahbod Date: Fri Oct 2 08:02:29 2015 +0100 Replace a couple of malloc()s with calloc() src/hb-face.cc | 2 +- src/hb-shape-plan.cc | 2 +- src/hb-shaper.cc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) commit 26ba4d1e1fb8949632fe08e6a7600badfba4f142 Author: Behdad Esfahbod Date: Fri Oct 2 07:25:52 2015 +0100 Fix segfault with empty buffer in hb_shape_plan_execute() Move the empty-buffer check from hb_shape_full() to hb_shape_plan_execute(). Reported by Simon Cozens. src/hb-shape-plan.cc | 9 +++++++-- src/hb-shape.cc | 5 ----- 2 files changed, 7 insertions(+), 7 deletions(-) commit 432ffc47a46d41bea17d839d0d3980e654c6e638 Author: Behdad Esfahbod Date: Wed Sep 30 22:51:16 2015 +0100 1.0.4 NEWS | 7 +++++++ configure.ac | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) commit b47159011ca518c3b94d782ed16a91ffe9dd2ab2 Author: Behdad Esfahbod Date: Tue Sep 29 14:57:02 2015 +0100 Define return_trace() Not functional change (expected!). src/hb-open-file-private.hh | 20 +-- src/hb-open-type-private.hh | 62 +++---- src/hb-ot-cmap-table.hh | 56 +++---- src/hb-ot-glyf-table.hh | 4 +- src/hb-ot-head-table.hh | 2 +- src/hb-ot-hhea-table.hh | 2 +- src/hb-ot-hmtx-table.hh | 2 +- src/hb-ot-layout-common-private.hh | 108 ++++++------- src/hb-ot-layout-gdef-table.hh | 44 ++--- src/hb-ot-layout-gpos-table.hh | 252 +++++++++++++++-------------- src/hb-ot-layout-gsub-table.hh | 304 ++++++++++++++++++----------------- src/hb-ot-layout-gsubgpos-private.hh | 205 +++++++++++------------ src/hb-ot-layout-jstf-table.hh | 35 ++-- src/hb-ot-maxp-table.hh | 5 +- src/hb-ot-name-table.hh | 14 +- src/hb-private.hh | 6 +- 16 files changed, 575 insertions(+), 546 deletions(-) commit c917965b9e6fe2b21ed6c51559673288fa3af4b7 Author: Behdad Esfahbod Date: Tue Sep 29 14:45:35 2015 +0100 Add missing returns Fixes possible invalid read of two bytes. Reported by Behzad Najjarpour Jabbari, Secunia Research. src/hb-ot-layout-gpos-table.hh | 14 +++++++------- src/hb-ot-layout-gsub-table.hh | 12 ++++++------ src/hb-ot-layout-gsubgpos-private.hh | 8 ++++---- 3 files changed, 17 insertions(+), 17 deletions(-) commit f3159ba5141c2ab0e430e64742972df140f91c43 Author: Behdad Esfahbod Date: Tue Sep 29 14:34:56 2015 +0100 Micro-optimize hb_language_from_string() As measured / improved by Benson Limketkai. src/hb-common.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit f2ad935e19338a29113492150f0c5a5fd5befd75 Author: Sascha Brawer Date: Sun Jun 28 03:29:47 2015 +0200 Handle language tags that indicate phonetic IPA transcription The BCP-47 registry defines a variant subtag "fonipa" that can be used in combination with arbitrary other language tags. For example, "rm-CH-fonipa-sursilv" indicates the Sursilvan dialect of Romansh as used in Switzerland, transcribed used the International Phonetic Alphabet. http://www.iana.org/assignments/language-subtag-registry/language-subtag-registry src/hb-ot-tag.cc | 15 ++++++++++++++- test/api/test-ot-tag.c | 7 +++++++ 2 files changed, 21 insertions(+), 1 deletion(-) commit b8811429b6810c4f13be087b593a862c17d9d987 Author: Behdad Esfahbod Date: Thu Sep 3 15:53:22 2015 +0430 Fix Since tags Fixes https://github.com/behdad/harfbuzz/issues/103 src/hb-blob.cc | 24 +++++++++---------- src/hb-buffer-serialize.cc | 10 ++++---- src/hb-buffer.cc | 58 +++++++++++++++++++++++----------------------- src/hb-buffer.h | 9 +++++++ src/hb-common.cc | 24 +++++++++---------- src/hb-common.h | 3 +++ src/hb-coretext.cc | 3 +++ src/hb-font.h | 18 +++++++------- src/hb-ft.cc | 6 ++--- src/hb-graphite2.cc | 6 +++++ src/hb-ot-layout.cc | 2 +- src/hb-ot-tag.cc | 2 +- src/hb-set.h | 3 +++ src/hb-shape.cc | 2 +- src/hb-unicode.cc | 18 +++++++------- src/hb-unicode.h | 10 ++++---- 16 files changed, 111 insertions(+), 87 deletions(-) commit 5d74ff02ab01df67808b416af8bb9cefb06f841e Author: Behdad Esfahbod Date: Thu Sep 3 14:55:59 2015 +0430 Fix Since: version tags on font and face APIs A while back we marked every API as version:1.0. We should fix them all to reflect real version they were introduced. This is a start. Patch from Nikolay Sivov. src/hb-face.cc | 22 ++++++++--------- src/hb-font.cc | 76 +++++++++++++++++++++++++++++----------------------------- 2 files changed, 49 insertions(+), 49 deletions(-) commit 7f5405397406a24c5a001b5ef43dcf4d6926415e Author: Behdad Esfahbod Date: Tue Sep 1 17:03:50 2015 +0100 1.0.3 NEWS | 11 +++++++++++ configure.ac | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) commit 5828c45d7a816ccd0a7f10a665ea3cf8cfd63b05 Author: Behdad Esfahbod Date: Tue Sep 1 16:26:35 2015 +0100 [indic] Add comments to merge_clusters calls src/hb-ot-shape-complex-indic.cc | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) commit bdc8215949a7add742cc800b4fdea6acaa37d152 Author: Behdad Esfahbod Date: Tue Sep 1 16:24:54 2015 +0100 [thai] Respect cluster-level > 0 src/hb-ot-shape-complex-thai.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5b31fe383ead726ec77062501ed3bb24c02842b3 Author: Behdad Esfahbod Date: Tue Sep 1 16:24:34 2015 +0100 [use] Merge /before/ reordering src/hb-ot-shape-complex-use.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 0d438f89bd9422c66838c776eb4aa867de0a2ad8 Author: Behdad Esfahbod Date: Tue Sep 1 16:24:13 2015 +0100 [hangul] Merge /before/ reordering src/hb-ot-shape-complex-hangul.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f883de664fc4bfe01e30c89e07e31dc113f906d9 Author: Behdad Esfahbod Date: Tue Sep 1 16:23:40 2015 +0100 [OT] Merge /before/ reordering src/hb-ot-shape.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit c403d6320074455a5e8e48902c0ac4ee9685e33d Author: Behdad Esfahbod Date: Tue Sep 1 16:15:25 2015 +0100 [myanmar] Use buffer->sort() to sort cluster This can possibly produce more granular clusters. src/hb-ot-shape-complex-myanmar.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit e995d33c10a4bd9404699d01bddb2b69d811e9ed Author: Behdad Esfahbod Date: Tue Sep 1 16:13:32 2015 +0100 [OT] Merge clusters when reordering marks for normalization Fixes https://bugzilla.gnome.org/show_bug.cgi?id=541608 and cluster test. src/hb-buffer-private.hh | 2 ++ src/hb-buffer.cc | 21 +++++++++++++++++++++ src/hb-ot-shape-normalize.cc | 2 +- 3 files changed, 24 insertions(+), 1 deletion(-) commit b6d7d161a87b5dde710924e5c557d39c302f5630 Author: Behdad Esfahbod Date: Tue Sep 1 16:12:44 2015 +0100 [tests] Add Hebrew test for normalization under cluster-level=1 Currently fails. https://bugzilla.gnome.org/show_bug.cgi?id=541608 .../sha1sum/43ef465752be9af900745f72fe29cb853a1401a5.ttf | Bin 0 -> 4272 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 + test/shaping/tests/cluster.tests | 1 + 3 files changed, 2 insertions(+) commit 93099748e39740a3f6f003c83d9dec1d21660ce8 Author: Behdad Esfahbod Date: Tue Sep 1 16:11:27 2015 +0100 Minor src/hb-private.hh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) commit 85846b3de7491b6a07fed6a2c0c6c1b09943b249 Author: Behdad Esfahbod Date: Tue Sep 1 15:07:52 2015 +0100 Use insertion-sort instead of bubble-sort Needed for upcoming merge-clusters fix. src/hb-buffer.cc | 4 +-- src/hb-ot-shape-complex-arabic-fallback.hh | 6 ++-- src/hb-ot-shape-complex-indic.cc | 2 +- src/hb-ot-shape-complex-myanmar.cc | 2 +- src/hb-ot-shape-normalize.cc | 6 ++-- src/hb-private.hh | 56 +++++++++++++----------------- 6 files changed, 34 insertions(+), 42 deletions(-) commit fad2674874591b4a1df822603144c8864f5364c1 Author: Behdad Esfahbod Date: Tue Sep 1 14:45:46 2015 +0100 Minor test/Makefile.am | 4 ++++ test/api/Makefile.am | 4 ++++ test/shaping/Makefile.am | 4 ++++ 3 files changed, 12 insertions(+) commit 23e4fac6de913201f263a73e13d3c1fab31d1bdd Author: Behdad Esfahbod Date: Mon Aug 31 19:41:01 2015 +0100 Update git.mk from upstream git.mk | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) commit 5783e05f81bbf6debf2618c8994d6852630d9847 Author: Behdad Esfahbod Date: Mon Aug 31 19:18:10 2015 +0100 [docs] Move docs/reference/ contents into docs/ configure.ac | 3 +- docs/Makefile.am | 117 ++++++++++++++++++++++++++- docs/{reference => }/harfbuzz-docs.xml | 0 docs/{reference => }/harfbuzz-overrides.txt | 0 docs/{reference => }/harfbuzz-sections.txt | 0 docs/reference/Makefile.am | 118 ---------------------------- docs/{reference => }/usermanual-ch01.xml | 0 docs/{reference => }/usermanual-ch02.xml | 0 docs/{reference => }/usermanual-ch03.xml | 0 docs/{reference => }/usermanual-ch04.xml | 0 docs/{reference => }/usermanual-ch05.xml | 0 docs/{reference => }/usermanual-ch06.xml | 0 docs/{reference => }/version.xml.in | 0 13 files changed, 117 insertions(+), 121 deletions(-) commit cd5e3a13a6e0b6606d3a421f8cd44cdfb8314907 Author: Behdad Esfahbod Date: Mon Aug 31 19:16:41 2015 +0100 [docs] Fix out-of-tree build docs/reference/Makefile.am | 9 ++++++++- docs/reference/harfbuzz-docs.xml | 12 ++++++------ docs/{ => reference}/usermanual-ch01.xml | 0 docs/{ => reference}/usermanual-ch02.xml | 0 docs/{ => reference}/usermanual-ch03.xml | 0 docs/{ => reference}/usermanual-ch04.xml | 0 docs/{ => reference}/usermanual-ch05.xml | 0 docs/{ => reference}/usermanual-ch06.xml | 0 8 files changed, 14 insertions(+), 7 deletions(-) commit 3899795fa3c3e058e3885ec7a6638f0597a752cc Merge: d2059652 01e16e88 Author: Behdad Esfahbod Date: Mon Aug 31 10:46:01 2015 +0100 Merge pull request #131 from simoncozens/docs Use gtk-doc to build user's manual as well as reference commit 01e16e88f50b65b82dcb84773f532f18a351319f Author: Simon Cozens Date: Mon Aug 31 10:40:17 2015 +0100 Combine user / reference information into gtk-doc generated manual. docs/reference/harfbuzz-docs.xml | 91 +++++++++++++++++++++++----------------- 1 file changed, 52 insertions(+), 39 deletions(-) commit 11a07c4729174e1d4af028103ecb0a351e4c2707 Author: Simon Cozens Date: Mon Aug 31 10:39:10 2015 +0100 Correct tag hierarchy, to allow for table-of-contents entries. docs/usermanual-ch01.xml | 12 ++++++------ docs/usermanual-ch02.xml | 8 ++++---- docs/usermanual-ch03.xml | 24 ++++++++++++------------ docs/usermanual-ch04.xml | 16 ++++++++-------- docs/usermanual-ch05.xml | 12 ++++++------ 5 files changed, 36 insertions(+), 36 deletions(-) commit 387d6af428ddd5d4f211fe5748412011013a3826 Author: Simon Cozens Date: Mon Aug 31 10:31:09 2015 +0100 Missing tag (oops). docs/usermanual-ch02.xml | 1 + 1 file changed, 1 insertion(+) commit d205965286798af4b7ad07e1eafa58288bee4bdb Author: Behdad Esfahbod Date: Mon Aug 31 10:12:05 2015 +0100 [docs] Fix typo docs/usermanual-ch03.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c424b41705b50055c7f92b268cf78a2680af73af Merge: 31594b98 5470e744 Author: Behdad Esfahbod Date: Mon Aug 31 09:53:16 2015 +0100 Merge pull request #129 from simoncozens/docs First two chapters. More to follow. commit 31594b98af0c9181982c77d8d3803753007f8fd4 Author: Behdad Esfahbod Date: Sun Aug 30 17:33:04 2015 +0100 [test] Fix test-object See previous commit. test/api/test-object.c | 4 ---- 1 file changed, 4 deletions(-) commit 326b5ebf5748f547e4eb7388d66b79fe23130e2a Author: Behdad Esfahbod Date: Sun Aug 30 17:29:21 2015 +0100 Poison freed objects such that double-free is detected Previously we were setting refcount of freed objects to the inert value, which was harmful because it caused further destroy()s of the freed object to NOT call free() and hence hide the bug. Indeed, after eb0bf3ae6688b7 test-object was double-free'ing objects and this was never caught on Linux. It only was caught as crashing on Mac. Now we poison refcount upon freeing and check that it's valid whenever reading it. Makes test-object fail now. src/hb-object-private.hh | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) commit 5470e744dd264c2dc33437a68d20bcf7c5ffb905 Author: Simon Cozens Date: Sat Aug 29 08:21:18 2015 +0100 Current state and skeleton outline docs/usermanual-ch03.xml | 77 ++++++++++++++++++++++++++++++++++++++++++++++++ docs/usermanual-ch04.xml | 18 +++++++++++ docs/usermanual-ch05.xml | 13 ++++++++ docs/usermanual-ch06.xml | 8 +++++ 4 files changed, 116 insertions(+) commit 6578575cc8aeb05341f2053039acfcd735707674 Author: Behdad Esfahbod Date: Tue Aug 25 20:24:59 2015 +0100 [GPOS] Fix cursive connection with mix of RTL and non-RTL lookups See thread "Issue with cursive attachment" started by Khaled. Turned out fixing this wasn't as bad as I had assumed. I like the new code better; we now have a theoretical model of cursive connections that is easier to reason about. src/hb-ot-layout-gpos-table.hh | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) commit 7368da67244ea53195cd9b95a5c57485df695732 Author: Behdad Esfahbod Date: Tue Aug 25 20:28:39 2015 +0100 [test] Add test for cursive-positioning with mixed directions Fails now. Fix coming. See thread "Issue with cursive attachment" started by Khaled. Test fonts were made by modifying test font from Khaled to add more anchors. test/shaping/Makefile.am | 1 + .../sha1sum/298c9e1d955f10f6f72c6915c3c6ff9bf9695cec.ttf | Bin 0 -> 2520 bytes test/shaping/fonts/sha1sum/MANIFEST | 2 ++ .../sha1sum/c4e48b0886ef460f532fb49f00047ec92c432ec0.ttf | Bin 0 -> 2512 bytes test/shaping/tests/MANIFEST | 1 + test/shaping/tests/cursive-positioning.tests | 2 ++ 6 files changed, 6 insertions(+) commit f0807654da160bd7ceb9aff5b8338ec0b643171c Author: Simon Cozens Date: Tue Aug 25 19:57:15 2015 +0100 First two chapters. More to follow. docs/usermanual-ch01.xml | 115 ++++++++++++++++++++++++++++++ docs/usermanual-ch02.xml | 182 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 297 insertions(+) commit 58f2a73fb95af42e264a91cdef7bb5a89e965601 Author: Behdad Esfahbod Date: Tue Aug 25 18:55:34 2015 +0100 [GPOS] Rewrite cursive attachment slightly differently In anticipation for upcoming fix for bug reported by Khaled in thread "Issue with cursive attachment". src/hb-ot-layout-gpos-table.hh | 36 ++++++++++++++++++++++++------------ 1 file changed, 24 insertions(+), 12 deletions(-) commit fdd1770e006ca2d2973c049177ceda87a575e07f Author: Behdad Esfahbod Date: Mon Aug 24 13:49:55 2015 +0100 Add API/cmdline to show glyph extents when serializing buffer New API: HB_BUFFER_SERIALIZE_FLAG_GLYPH_EXTENTS hb-shape now accepts --show-extents. Patch from Simon Cozens. src/hb-buffer-serialize.cc | 17 +++++++++++++++++ src/hb-buffer.h | 3 ++- util/hb-shape.cc | 2 ++ util/options.cc | 1 + util/options.hh | 2 ++ 5 files changed, 24 insertions(+), 1 deletion(-) commit 2cee5b68a07b99214ef9428fe5d03e7b378a558f Author: Behdad Esfahbod Date: Mon Aug 24 13:45:12 2015 +0100 [ot-font] Fix short-offset calculation src/hb-ot-font.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit b50fcfa82994f93568a54dd1eb7fd327f6db5586 Author: Behdad Esfahbod Date: Sun Aug 23 14:42:20 2015 +0100 [ot-font] Implement glyph_extents() for TrueType fonts This brings ot-fonts into almost-complete shape and mostly in par with ft font. src/Makefile.am | 1 + src/hb-font.h | 9 +++-- src/hb-ot-font.cc | 90 +++++++++++++++++++++++++++++++++++++++-- src/hb-ot-glyf-table.hh | 104 ++++++++++++++++++++++++++++++++++++++++++++++++ src/hb-ot-head-table.hh | 3 +- 5 files changed, 198 insertions(+), 9 deletions(-) commit 0299b45000b5047c0b9bf0fe51f3b8b68a7982f8 Author: Behdad Esfahbod Date: Fri Aug 21 12:44:36 2015 +0100 Make BYTE a real type src/hb-open-type-private.hh | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) commit ed6962c795ae7c54aaee9ed5667fa65ccf7412bf Author: Behdad Esfahbod Date: Thu Aug 20 15:39:53 2015 +0100 [coretext] Use i32 instead of u32 as well Shouldn't cause *any* functional changes, but is more correct. src/hb-coretext.cc | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) commit 163c435f1807c138da9f74f09d29d913eb9e29e9 Author: Behdad Esfahbod Date: Thu Aug 20 15:39:06 2015 +0100 [uniscribe] Fix negative offsets Ouch! src/hb-uniscribe.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 789b89ef7130ffe5f22c571fc3cb4e6d35456654 Author: Behdad Esfahbod Date: Wed Aug 19 13:39:57 2015 +0100 1.0.2 NEWS | 13 +++++++++++++ configure.ac | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) commit 958c268fa3a520666436e77a2111a3b564a36d96 Author: Behdad Esfahbod Date: Wed Aug 19 13:22:12 2015 +0100 [coretext] Add TODO item src/hb-coretext.cc | 1 + 1 file changed, 1 insertion(+) commit 7c5bee09d9c7c25672c7c77572ebae0b731892d0 Author: Behdad Esfahbod Date: Wed Aug 19 13:20:31 2015 +0100 [uniscribe] Fix font scale handling By default shape at upem (or ppem), and scale results. Similar to work done in CoreText backend, but using upem as default. src/hb-uniscribe.cc | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) commit 902e74a098dad8c3b487856284f9fdf99b04f9f1 Author: Behdad Esfahbod Date: Tue Aug 18 18:55:03 2015 +0100 Commented-out code to print buffer before each lookup To be turned into a useful HB_DEBUG_SHAPE infrastructure... src/hb-ot-layout.cc | 12 ++++++++++++ 1 file changed, 12 insertions(+) commit 75504a50488a6aac0b9789f728fb5b87e641d4c3 Author: Behdad Esfahbod Date: Tue Aug 18 18:47:02 2015 +0100 Allow serializing buffer with output-buffer being used Ie, don't call get_positions() if positions are not requested for serialization. src/hb-buffer-serialize.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit e47b772a56af44a9a4f9ec907ee2091b725b94c1 Author: Behdad Esfahbod Date: Tue Aug 18 18:42:47 2015 +0100 [ot] Change buffer content type right after we map to glyphs Needed for upcoming debug output changes. src/hb-ot-shape.cc | 2 ++ 1 file changed, 2 insertions(+) commit d104415e4c1e0f9140f794cd8d09c6460c63e966 Author: Behdad Esfahbod Date: Tue Aug 18 17:33:34 2015 +0100 [Android.mk] Update for SEA removal and USE addition Android.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit ddd6bf12f1cabaa298feed820313483b9893528c Author: Behdad Esfahbod Date: Tue Aug 18 15:55:09 2015 +0100 Don't declare dependency on freetype in harfbuzz.pc See comments. src/Makefile.am | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit 2c8b3b2e5312c9858584f568b1528c57e5bb8a10 Author: Behdad Esfahbod Date: Tue Aug 18 14:36:43 2015 +0100 [debug] Print lookup index in debug-apply output src/hb-ot-layout-gpos-table.hh | 5 ++++- src/hb-ot-layout-gsub-table.hh | 5 ++++- src/hb-ot-layout-gsubgpos-private.hh | 7 +++++-- src/hb-ot-layout.cc | 3 ++- 4 files changed, 15 insertions(+), 5 deletions(-) commit 50ad7788eeb7160caef4ec78e65c7c630e601b06 Author: Behdad Esfahbod Date: Tue Aug 18 10:22:16 2015 +0100 [coretext] Remove assert that kicks in on Mac OS 10.6 http://crbug.com/419769 src/hb-coretext.cc | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) commit 2b646fa07f5f9d4d10d563a91d22a2750b5fc771 Author: Behdad Esfahbod Date: Mon Aug 17 16:03:28 2015 +0200 Remove unused function src/hb-ot-shape-complex-use.cc | 8 -------- 1 file changed, 8 deletions(-) commit 23237b0279a04407addf33f599c45faa60f002ca Author: ThePhD Date: Fri Aug 14 01:19:08 2015 -0400 Last apparent boolean fix! src/hb-ot-shape-complex-use.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5c99cf93d6242803bddcac2ca8300fdec7e0f8a7 Merge: 8ad89f05 539a610e Author: ThePhD Date: Fri Aug 14 01:02:00 2015 -0400 Merge branch 'master' into vc++-fixes commit 539a610e2e72375e598ab29fd390ed9ec93816d5 Author: Behdad Esfahbod Date: Tue Aug 11 12:58:49 2015 +0200 Add Libs.private and Requires.private to harfbuzz.pc Fixes https://bugs.freedesktop.org/show_bug.cgi?id=64501 configure.ac | 12 +++++++++--- src/Makefile.am | 15 ++++++++++++--- src/harfbuzz.pc.in | 2 ++ 3 files changed, 23 insertions(+), 6 deletions(-) commit c7dfe316f8c0fc04b7976fca5e58eb46d91b4821 Author: jfkthame Date: Fri Aug 7 17:55:03 2015 +0100 Don't rely on .cluster in _hb_ot_shape_normalize() Fixes https://github.com/behdad/harfbuzz/pull/124 src/hb-ot-shape-normalize.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9099e48e29fe5cfdf8566c8f1ba6ddc8c0799e7e Author: jfkthame Date: Fri Aug 7 17:51:28 2015 +0100 Don't rely on .cluster field in fallback_position Fixes tests/cluster. Fixes https://github.com/behdad/harfbuzz/pull/123 src/hb-ot-shape-fallback.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit f3792342f670978cdc3f8512fb5e80314ca0678d Author: Behdad Esfahbod Date: Sat Aug 8 18:02:18 2015 +0200 [tests] Add test for fallback positioning with cluster_level > 0 For https://github.com/behdad/harfbuzz/pull/123 Currently fails. Fix coming. test/shaping/Makefile.am | 1 + .../sha1sum/6466d38c62e73a39202435a4f73bf5d6acbb73c0.ttf | Bin 0 -> 824 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 + test/shaping/tests/MANIFEST | 1 + test/shaping/tests/cluster.tests | 1 + 5 files changed, 4 insertions(+) commit bd22a5cfae24b3b9253bccaeb139e698e74cd0c3 Author: Behdad Esfahbod Date: Fri Aug 7 11:13:27 2015 +0200 Bug 91559 - HarfBuzz 1.0.1: Inconsistent DLL files specified/created... Fixes https://bugs.freedesktop.org/show_bug.cgi?id=91559 src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 02d6439f420d959183dd446abd0b0118ee1ee061 Merge: 9002c27b 160f6355 Author: Behdad Esfahbod Date: Mon Aug 3 22:47:18 2015 +0300 Merge pull request #122 from RomainNaour/static-fix fix static linking with icu-uc commit 160f635523d596f61e292776f638d4eb09673463 Author: Romain Naour Date: Wed Jul 22 23:26:23 2015 +0200 fix static linking with icu-uc When linking test-unicode statically it needs $(ICU_LIBS) which contains all required flags. Especially -lstdc++. Fixes: http://autobuild.buildroot.net/results/210/2107f9dfb39eeb6559fb4271c7af8b39aef521ca/ Signed-off-by: Romain Naour test/api/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9002c27b2f54bb5135db92045c0d770b47317577 Author: Behdad Esfahbod Date: Mon Jul 27 12:17:54 2015 +0200 1.0.1 NEWS | 9 ++++++++- configure.ac | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) commit f1c20e1ba5bf218df7dc3e198bdcf1f449fc9387 Author: Behdad Esfahbod Date: Mon Jul 27 12:16:02 2015 +0200 [USE] Fix out-of-bounds static array access src/hb-ot-shape-complex-use.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 260442346a5756c3538ee8fcbf157d1cddcf6f36 Author: Behdad Esfahbod Date: Sun Jul 26 23:39:10 2015 +0200 1.0.0 NEWS | 10 ++++++++++ configure.ac | 4 ++-- src/Makefile.am | 2 +- 3 files changed, 13 insertions(+), 3 deletions(-) commit df6cb84449a473d540821e41fb5007b59644780f Merge: 2ed6be66 786ba458 Author: Behdad Esfahbod Date: Sun Jul 26 19:40:55 2015 +0200 Merge branch 'use' commit 2ed6be66703e6cc67f3a3746e197001dad3d9b74 Author: Behdad Esfahbod Date: Sun Jul 26 19:29:53 2015 +0200 0.9.42 NEWS | 12 ++++++++++++ configure.ac | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) commit 23e56e088a721863cfdef4f027fb66eecbd77457 Author: Behdad Esfahbod Date: Sat Jul 25 17:36:46 2015 +0200 Fix broken sentence src/hb-set-private.hh | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) commit 91a2e5d2878a8c0b4d4500e3d52d4fbaaf1ac0d7 Author: Grigori Goronzy Date: Wed Jul 8 23:28:11 2015 +0200 Update UCDN to upstream commit 8af93f30 This adds support for Unicode 8.0 and fixes a bug with wrong properties for ranges of codepoints. src/hb-ucdn.cc | 6 + src/hb-ucdn/ucdn.h | 6 + src/hb-ucdn/unicodedata_db.h | 2167 +++++++++++++++++++++--------------------- 3 files changed, 1118 insertions(+), 1061 deletions(-) commit 786ba45847127b9cd4d9c0c01ae0e6c61f3a8e06 Author: Behdad Esfahbod Date: Thu Jul 23 13:04:34 2015 +0100 [test] Encode Kharoshti text Ouch! .../in-tree/shaper-use/script-kharoshti/misc.txt | 72 +++++++++++----------- 1 file changed, 36 insertions(+), 36 deletions(-) commit b4231255032e243153a6f32cf8c93c158cb0bf6a Author: Behdad Esfahbod Date: Thu Jul 23 13:01:55 2015 +0100 [test] Add Batak and Buginese test texts test/shaping/texts/in-tree/shaper-use/MANIFEST | 2 + .../texts/in-tree/shaper-use/script-batak/MANIFEST | 1 + .../texts/in-tree/shaper-use/script-batak/misc.txt | 9 +++ .../in-tree/shaper-use/script-buginese/MANIFEST | 1 + .../in-tree/shaper-use/script-buginese/misc.txt | 70 ++++++++++++++++++++++ 5 files changed, 83 insertions(+) commit b8c159ffccad090974a2b97be0a0140fa09af132 Author: Behdad Esfahbod Date: Thu Jul 23 12:59:17 2015 +0100 [test] Remove shaper-sea texts under shaper-use test/shaping/texts/in-tree/MANIFEST | 1 - test/shaping/texts/in-tree/shaper-sea/MANIFEST | 2 -- test/shaping/texts/in-tree/shaper-sea/script-cham/MANIFEST | 1 - test/shaping/texts/in-tree/shaper-sea/script-tai-tham/MANIFEST | 1 - test/shaping/texts/in-tree/shaper-use/MANIFEST | 2 ++ .../{shaper-sea/script-cham/misc => shaper-use/script-cham}/MANIFEST | 0 .../{shaper-sea/script-cham/misc => shaper-use/script-cham}/misc.txt | 0 .../script-tai-tham/misc => shaper-use/script-tai-tham}/MANIFEST | 0 .../script-tai-tham/misc => shaper-use/script-tai-tham}/misc.txt | 0 .../script-tai-tham/misc => shaper-use/script-tai-tham}/torture.txt | 0 10 files changed, 2 insertions(+), 5 deletions(-) commit 67ba7320cc5545baeacfcff64cea338223b9bd6d Author: Behdad Esfahbod Date: Thu Jul 23 12:58:21 2015 +0100 [test] Remove New Tai Lue texts New Tai Lue changed encoding to visual, boring, model. test/shaping/texts/in-tree/shaper-sea/MANIFEST | 1 - test/shaping/texts/in-tree/shaper-sea/script-new-tai-lue/MANIFEST | 1 - test/shaping/texts/in-tree/shaper-sea/script-new-tai-lue/misc/MANIFEST | 1 - test/shaping/texts/in-tree/shaper-sea/script-new-tai-lue/misc/misc.txt | 1 - 4 files changed, 4 deletions(-) commit c81d957a264539dfe3252f9a94ee066c4a44edf4 Author: Behdad Esfahbod Date: Thu Jul 23 12:50:48 2015 +0100 [test] Add tests for improved 'vert' feature test/shaping/Makefile.am | 1 + .../sha1sum/191826b9643e3f124d865d617ae609db6a2ce203.ttf | Bin 0 -> 2140 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 + test/shaping/tests/MANIFEST | 1 + test/shaping/tests/vertical.tests | 1 + 5 files changed, 4 insertions(+) commit 8a6a16dbcb1808c7ed50f9ba320384565bbf405a Author: Behdad Esfahbod Date: Thu Jul 23 12:49:09 2015 +0100 [test] Add recently added test Ouch. test/shaping/Makefile.am | 1 + 1 file changed, 1 insertion(+) commit 895fb31c7f0201f13df5a6866b367476bc4aab2e Author: Behdad Esfahbod Date: Thu Jul 23 12:14:03 2015 +0100 [test] Support additional options to hb-shape in micro-test suite test/shaping/record-test.sh | 47 ++++++++++++++++++---- test/shaping/run-tests.sh | 9 ++++- test/shaping/tests/arabic-fallback-shaping.tests | 2 +- test/shaping/tests/arabic-feature-order.tests | 6 +-- test/shaping/tests/context-matching.tests | 6 +-- test/shaping/tests/default-ignorables.tests | 2 +- test/shaping/tests/hangul-jamo.tests | 4 +- test/shaping/tests/indic-joiner-candrabindu.tests | 4 +- test/shaping/tests/indic-old-spec.tests | 4 +- test/shaping/tests/indic-pref-blocking.tests | 4 +- .../tests/mongolian-variation-selector.tests | 6 +-- test/shaping/tests/zero-width-marks.tests | 4 +- 12 files changed, 67 insertions(+), 31 deletions(-) commit 0f98fe88f42471eb8fb28d08d45eca9cd8303f7a Author: Behdad Esfahbod Date: Thu Jul 23 11:52:11 2015 +0100 [ot] Search globally for 'vert' feature if not found in specified script/lang Fixes https://github.com/behdad/harfbuzz/issues/63 src/hb-ot-layout-private.hh | 9 +++++++++ src/hb-ot-layout.cc | 22 ++++++++++++++++++++++ src/hb-ot-map-private.hh | 7 ++++--- src/hb-ot-map.cc | 10 ++++++++++ src/hb-ot-shape.cc | 6 +++++- 5 files changed, 50 insertions(+), 4 deletions(-) commit f327aacfa107bbef0c823ef9c3b7dfc91316040c Author: Behdad Esfahbod Date: Thu Jul 23 11:32:59 2015 +0100 [ot] Minor src/hb-ot-shape.cc | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) commit d78463c8016ff1852233479a1ebde30c3bb6de6e Author: Behdad Esfahbod Date: Thu Jul 23 10:11:35 2015 +0100 Minor debug output fix src/hb-ot-layout.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d99f50bde0e8be0866385ca6886938d2023dbd4f Author: Behdad Esfahbod Date: Thu Jul 23 10:08:48 2015 +0100 Add missing TRACE_RETURN src/hb-ot-layout-gsubgpos-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2dc8e3f470d7c0b579f867605b8bf40688bc5722 Author: Behdad Esfahbod Date: Thu Jul 23 10:07:21 2015 +0100 [ot] Add missing return! src/hb-ot-layout-gsubgpos-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 582069172c39326c7f94373793c656439a4c2b59 Author: Behdad Esfahbod Date: Wed Jul 22 18:44:59 2015 +0100 Add test case for deleting default ignorables with positioning .../sha1sum/051d92f8bc6ff724511b296c27623f824de256e9.ttf | Bin 0 -> 2028 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 + test/shaping/tests/MANIFEST | 1 + test/shaping/tests/default-ignorables.tests | 1 + 4 files changed, 3 insertions(+) commit 8cfbc304ee563ec96e402beed34b10b6c0950a6a Author: Behdad Esfahbod Date: Wed Jul 22 18:41:10 2015 +0100 Fix hide-default-ignorables after f0010dfd01ef4a927b0bdc175dd4e343a8637174 We can't delete things before hb_ot_layout_position_finish(). So, just zero the advance before it, and remove later. src/hb-ot-shape.cc | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) commit 2dbd3d29d6548bd96fd976606ed689fac8ad8817 Author: Behdad Esfahbod Date: Wed Jul 22 18:28:39 2015 +0100 Fix hide-ignorables if font doesn't have space glyph Was broken by 82b521aeb7cc73879b44ca4278d6fa8b4347527f, as we have positioning data by then and can't use the output buffer. Ouch! src/hb-buffer-private.hh | 18 ------------------ src/hb-ot-shape.cc | 44 +++++++++++++++++++++++++++++++++++--------- 2 files changed, 35 insertions(+), 27 deletions(-) commit 4ba796b26ee62de0d2830a550f3aa3b4aecf6f59 Author: Behdad Esfahbod Date: Wed Jul 22 17:41:31 2015 +0100 Refactor _hb_glyph_info_is_default_ignorable() src/hb-ot-layout-gsubgpos-private.hh | 3 +-- src/hb-ot-layout-private.hh | 4 +++- src/hb-ot-shape.cc | 9 +++------ 3 files changed, 7 insertions(+), 9 deletions(-) commit f0010dfd01ef4a927b0bdc175dd4e343a8637174 Author: Behdad Esfahbod Date: Wed Jul 22 17:36:23 2015 +0100 [ot] Hide default-ignorables before finishing off positioning For example, fixes the following sequence with Arial XP: 628 25cc 651 25cc 64e 3a 20 628 651 34f 64e 628 25cc 64e 25cc 651 3a 20 628 64e 34f 651 Discovered as part of: https://bugs.freedesktop.org/show_bug.cgi?id=85873 src/hb-ot-shape.cc | 125 +++++++++++++++++++++++++++-------------------------- 1 file changed, 63 insertions(+), 62 deletions(-) commit 376d587f36b4ff10342ee6ca3bacd73532ea44c8 Author: Behdad Esfahbod Date: Wed Jul 22 16:51:12 2015 +0100 Implement more granular cluster-merging TODO: Documentation. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=71445 NEWS | 8 +++++++ src/hb-buffer-private.hh | 1 + src/hb-buffer.cc | 46 ++++++++++++++++++++++++++++++++++----- src/hb-buffer.h | 12 ++++++++++ src/hb-ot-shape-complex-hangul.cc | 13 +++++------ src/hb-ot-shape.cc | 7 ++++++ util/options.cc | 1 + util/options.hh | 3 +++ 8 files changed, 77 insertions(+), 14 deletions(-) commit a60e2cfa395718cde48eb81f43adc27b4a92e117 Author: Behdad Esfahbod Date: Wed Jul 22 15:49:08 2015 +0100 [ot] Don't rely on cluster numbers for ensure_native_direction() src/hb-ot-shape.cc | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) commit 701112dad9f6e690b253f1e64f4e7e549f5ae65f Author: Behdad Esfahbod Date: Wed Jul 22 15:42:20 2015 +0100 [ot] Simplify form_clusters() src/hb-buffer-private.hh | 9 ++++++++- src/hb-buffer.cc | 7 ++----- src/hb-ot-shape.cc | 11 +++++++++-- 3 files changed, 19 insertions(+), 8 deletions(-) commit 7b8b63adc5e0389fc4cf2720ef7e5804ab6c29cc Author: Behdad Esfahbod Date: Wed Jul 22 15:24:26 2015 +0100 [ot] Don't mirror character if font doesn't support mirrored character! src/hb-ot-shape.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 97d7c3a100e2673279f066540229d229aaf0df78 Author: Behdad Esfahbod Date: Wed Jul 22 14:28:25 2015 +0100 [graphite2] Fix bunch of stuff Based on patch from Martin Hosken, with review from Jonathan and I. src/hb-graphite2.cc | 82 +++++++++++++++++++++++++++++++++++------------------ 1 file changed, 54 insertions(+), 28 deletions(-) commit ea7f8414e34d4b5efc7b98974637c08f75440f0e Author: Behdad Esfahbod Date: Wed Jul 22 13:53:45 2015 +0100 [graphite2] Enlarge buffer for output glyphs! src/hb-graphite2.cc | 1 + 1 file changed, 1 insertion(+) commit 9cd59db1af47ff511edf251949d58b82673cf704 Author: Behdad Esfahbod Date: Wed Jul 22 13:27:06 2015 +0100 [USE] Implement topographical features for non-Arabic-joining scripts This works per-syllable as per the spec, but we think it should be per spacing/base/??? glyph instead. src/hb-ot-shape-complex-use.cc | 87 ++++++++++++++++++++++++++++++++++++++---- 1 file changed, 80 insertions(+), 7 deletions(-) commit ecb0b24ef3f8177e7c789f45a2e858bd67e31be3 Author: Behdad Esfahbod Date: Wed Jul 22 12:02:09 2015 +0100 Use foreach_cluster in Indic shaper src/hb-ot-shape-complex-indic.cc | 90 +++++++++------------------------------- 1 file changed, 19 insertions(+), 71 deletions(-) commit 56f71ff98890fc4fd13e8d9743dc34c4b9407309 Author: Behdad Esfahbod Date: Wed Jul 22 11:58:11 2015 +0100 Use foreach_syllable in Myanmar shaper src/hb-ot-shape-complex-myanmar.cc | 62 ++++++++------------------------------ 1 file changed, 12 insertions(+), 50 deletions(-) commit ac596511a8c9eeaeb455ca16b5b9c5f1b9923b3a Author: Behdad Esfahbod Date: Wed Jul 22 11:54:02 2015 +0100 Add foreach_syllable Use it in USE. src/hb-ot-layout-private.hh | 24 ++++++++ src/hb-ot-shape-complex-use.cc | 129 +++++++++++++---------------------------- 2 files changed, 64 insertions(+), 89 deletions(-) commit 8ba9e689680f7685c04cfe7c6019222bdf0c52b0 Author: Behdad Esfahbod Date: Wed Jul 22 11:16:01 2015 +0100 [USE] Do Arabic-like shaping src/hb-ot-shape-complex-use.cc | 77 ++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 75 insertions(+), 2 deletions(-) commit 9daf2dfb6bd5683fd951bdf166c8b87938257e52 Author: Behdad Esfahbod Date: Wed Jul 22 10:32:30 2015 +0100 Add hb-ot-shape-complex-arabic-private.hh src/Makefile.am | 1 + src/hb-ot-shape-complex-arabic-private.hh | 50 +++++++++++++++++++++++++++++++ src/hb-ot-shape-complex-arabic.cc | 37 +++++++++++++---------- 3 files changed, 73 insertions(+), 15 deletions(-) commit a51a661fe1dcfdd3a274a6be6ad741c68d430c8c Author: Behdad Esfahbod Date: Tue Jul 21 18:24:21 2015 +0100 [USE] Only reorder the first component of a split left mark src/hb-ot-shape-complex-use.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit a08a278b15c7e57a1d0a783f2bc877471b9d8229 Author: Behdad Esfahbod Date: Tue Jul 21 18:09:40 2015 +0100 [USE] Don't compose split matras Same logic as in Indic shaper. src/hb-ot-shape-complex-use.cc | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) commit 21cb08a417f1203523191192d6a342e8cd0ea14c Author: Behdad Esfahbod Date: Tue Jul 21 17:47:06 2015 +0100 Remove unused SEA shaper src/Makefile.am | 4 - src/hb-ot-shape-complex-sea-machine.rl | 102 --------- src/hb-ot-shape-complex-sea.cc | 380 --------------------------------- 3 files changed, 486 deletions(-) commit db1e9cdd41ff7c97c29b4d9b64b2351ed0ef0403 Author: Behdad Esfahbod Date: Tue Jul 21 17:46:06 2015 +0100 Retire SEA shaper in favor of USE src/hb-ot-shape-complex-private.hh | 25 +++---------------------- 1 file changed, 3 insertions(+), 22 deletions(-) commit 87dde9c64753dea4017f11a7734e7528b8eecac0 Author: Behdad Esfahbod Date: Tue Jul 21 17:31:43 2015 +0100 [USE] Only use USE shaper if script system is not DFLT Same logic as Indic and SEA. src/hb-ot-shape-complex-private.hh | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) commit 29832d797ff2f3a96721dd44f2f03a83fb2e8dda Author: Behdad Esfahbod Date: Tue Jul 21 17:24:18 2015 +0100 Route misc untested scripts through USE shaper instead of Indic These were never tested with Indic shaper, and indeed wouldn't work there because they didn't have their viramas and other config defined. They are all also supported by MS through USE, so route them there. src/hb-ot-shape-complex-private.hh | 91 +++++--------------------------------- 1 file changed, 11 insertions(+), 80 deletions(-) commit 40c4a991c7ea18017273ff8993eecc3953869e69 Author: Behdad Esfahbod Date: Tue Jul 21 17:14:54 2015 +0100 [USE] Implement dotted-circle This makes USE feature-complete as far as the Indic-like features are concerned. src/hb-ot-shape-complex-use-machine.rl | 10 ++++++++++ src/hb-ot-shape-complex-use.cc | 18 +++++++++++++++--- 2 files changed, 25 insertions(+), 3 deletions(-) commit 7ce03ebe7c525919ce22d9094480847ff1b3c2b2 Author: Behdad Esfahbod Date: Tue Jul 21 16:55:26 2015 +0100 [USE] Move pref src/hb-ot-shape-complex-use-machine.rl | 9 +++++---- src/hb-ot-shape-complex-use-private.hh | 9 +++++---- src/hb-ot-shape-complex-use.cc | 24 ++++++++++++++++++++++-- 3 files changed, 32 insertions(+), 10 deletions(-) commit 2d4b62ead931b13f95f5dc0e5b740d997a8d1a8e Author: Behdad Esfahbod Date: Tue Jul 21 16:46:37 2015 +0100 [USE] Fix-up variation selectors and word joiner in table src/gen-use-table.py | 7 ++++++- src/hb-ot-shape-complex-use-table.cc | 34 +++++++++++++++++++++++----------- 2 files changed, 29 insertions(+), 12 deletions(-) commit ad7178227f16abc17456f122deac1508031cbbc3 Author: Behdad Esfahbod Date: Tue Jul 21 16:43:27 2015 +0100 [USE] Use a couple warnings src/gen-use-table.py | 20 ++++----- src/hb-ot-shape-complex-use-table.cc | 82 ++++++++++++++++++------------------ 2 files changed, 51 insertions(+), 51 deletions(-) commit a85c4da9b1750c2f994f9f85226a3e755fafe50b Author: Behdad Esfahbod Date: Tue Jul 21 16:07:10 2015 +0100 [USE] Move rphf src/hb-ot-shape-complex-use.cc | 105 ++++++++++++++--------------------------- 1 file changed, 35 insertions(+), 70 deletions(-) commit 5b5617e0664e59770910d04d15175f643a5ffb73 Author: Behdad Esfahbod Date: Tue Jul 21 15:52:15 2015 +0100 Add FLAG_UNSAFE() Unused right now. src/hb-private.hh | 1 + 1 file changed, 1 insertion(+) commit f8160a495966c790b79134a9f9382b6545f8c733 Author: Behdad Esfahbod Date: Tue Jul 21 15:50:02 2015 +0100 Add FLAG_SAFE() for values known to be small-enough And add check to FLAG() src/hb-ot-shape-complex-arabic.cc | 2 +- src/hb-ot-shape-complex-indic.cc | 12 ++++++------ src/hb-ot-shape-complex-myanmar.cc | 2 +- src/hb-private.hh | 5 +++-- src/hb-unicode-private.hh | 2 +- 5 files changed, 12 insertions(+), 11 deletions(-) commit 366aeaad006b230481a3c08ab4d239fb6b64fef8 Author: Behdad Esfahbod Date: Tue Jul 21 15:45:48 2015 +0100 Add note re ASSERT_STATIC_EXPR_ZERO() src/hb-private.hh | 2 ++ 1 file changed, 2 insertions(+) commit d6adca9fbbbd6fc7c8906121b50c3930fbe2de8e Author: Behdad Esfahbod Date: Tue Jul 21 15:17:27 2015 +0100 Remove unused macro ASSERT_STATIC_EXPR() src/hb-ot-shape-complex-arabic-win1256.hh | 4 ++-- src/hb-ot-shape-complex-indic-private.hh | 2 -- src/hb-private.hh | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) commit 1025e1a9e7785ac67cc90d05b02862e38b3e6026 Author: Behdad Esfahbod Date: Tue Jul 21 15:05:35 2015 +0100 Use unsigned in FLAG() src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cf59c7589c2b4064f4b9f4936115f830089a8ee7 Author: Behdad Esfahbod Date: Tue Jul 21 14:51:45 2015 +0100 [USE] Use use_category() for rphf/pref memory src/hb-ot-shape-complex-use.cc | 63 +++++++++++++++--------------------------- 1 file changed, 22 insertions(+), 41 deletions(-) commit 595936ec25e9c0924851bd1aa1af5eed3723b54f Author: Behdad Esfahbod Date: Tue Jul 21 14:15:35 2015 +0100 [USE] Hook of rphf and pref custom processing Still no reordering. src/hb-ot-layout-private.hh | 8 ++ src/hb-ot-shape-complex-use.cc | 181 +++++++++++++++++++++++++++++++++++++++-- 2 files changed, 181 insertions(+), 8 deletions(-) commit ba72801325e4bd58f7597938d4409762c9fa530c Author: Behdad Esfahbod Date: Tue Jul 21 11:57:23 2015 +0100 [USE] Add CGJ to table src/gen-use-table.py | 13 ++++++++++--- src/hb-ot-shape-complex-use-table.cc | 1 + 2 files changed, 11 insertions(+), 3 deletions(-) commit 4febed61edc5367543e5a206ae01d3393841b612 Author: Behdad Esfahbod Date: Tue Jul 21 10:24:32 2015 +0100 [USE] Set up features src/hb-ot-shape-complex-use.cc | 68 +++++++++++++++++++++++------------------- 1 file changed, 38 insertions(+), 30 deletions(-) commit 52a957795697085a5d379921ddd8aa6cf2f1a99d Author: Behdad Esfahbod Date: Tue Jul 21 10:02:04 2015 +0100 [USE] Hook up new scripts to USE shaper Don't reroute scripts that we were routing to other shapers before (just yet). src/hb-ot-shape-complex-private.hh | 71 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 71 insertions(+) commit b4c0829bc18b696f140a260fa2e1089d10164519 Author: Behdad Esfahbod Date: Tue Jul 21 09:31:19 2015 +0100 [USE] Remove unused Unicode data enums from USE C++ side src/hb-ot-shape-complex-use-private.hh | 66 +--------------------------------- src/hb-ot-shape-complex-use.cc | 14 ++------ 2 files changed, 3 insertions(+), 77 deletions(-) commit 44910cef626e6d03baa4d89d8fbe2c088971902d Author: Behdad Esfahbod Date: Mon Jul 20 18:01:10 2015 +0100 [USE] Finish converting Unicode positional categories to USE Even compiles. src/gen-use-table.py | 114 +++++- src/hb-ot-shape-complex-use-table.cc | 702 ++++++++++++++++++----------------- 2 files changed, 467 insertions(+), 349 deletions(-) commit ad725552521273a1f571f04bc96a04221c3e067a Author: Behdad Esfahbod Date: Mon Jul 20 17:00:06 2015 +0100 [USE] Map from Unicode data to USE syllabic categories Positional sub-categories not applied yet. src/gen-use-table.py | 128 ++-- src/hb-ot-shape-complex-use-table.cc | 1062 ++++++++++++---------------------- 2 files changed, 409 insertions(+), 781 deletions(-) commit 20e246e674155d5fb6527722fc3ef3accf2413df Author: Behdad Esfahbod Date: Mon Jul 20 15:56:19 2015 +0100 [USE] Start moving Unicode-to-USE mapping into Python code src/Makefile.am | 2 +- src/gen-use-table.py | 176 +++++++++++++++++++++++++++++++++-- src/hb-ot-shape-complex-use-table.cc | 3 +- 3 files changed, 169 insertions(+), 12 deletions(-) commit eb74535cc2c0d0de41e54e75bdc71825ec969523 Author: Behdad Esfahbod Date: Mon Jul 20 15:33:25 2015 +0100 [USE] Fix Number clusters The spec wrongly has "H" where "HN" is meant. src/hb-ot-shape-complex-use-machine.rl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit a9663958fe861950b6f389b389f146232b2cd909 Author: Behdad Esfahbod Date: Mon Jul 20 14:24:55 2015 +0100 [USE] Start putting together the shaper body src/hb-ot-shape-complex-use-private.hh | 2 +- src/hb-ot-shape-complex-use.cc | 339 +++++++++++++++++++++++++++++++++ 2 files changed, 340 insertions(+), 1 deletion(-) commit e0eabd7f67462ac34fbfc749d897be478fbd1224 Author: Behdad Esfahbod Date: Mon Jul 20 13:30:51 2015 +0100 [USE] Put a Ragel machine together Grammar from the spec! src/hb-ot-shape-complex-use-machine.rl | 169 +++++++++++++++++++++++++++++++++ src/hb-ot-shape-complex-use-private.hh | 160 +++++++++++++++++++++++++++++++ 2 files changed, 329 insertions(+) commit fd74b939b176f47d34d34b3d33e2a09d255c2d9e Author: Behdad Esfahbod Date: Mon Jul 20 13:30:45 2015 +0100 Minor src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5e5c8560cca3cb9c6be90c7c18ecb77d5cca0c0f Author: Behdad Esfahbod Date: Mon Jul 20 12:01:20 2015 +0100 [USE] Minor optimization of USE table src/gen-use-table.py | 2 +- src/hb-ot-shape-complex-use-table.cc | 30 ++++++++++++------------------ 2 files changed, 13 insertions(+), 19 deletions(-) commit 14b12f92a9ef7db57c5252ef0442239319ce4bca Author: Behdad Esfahbod Date: Mon Jul 20 11:57:44 2015 +0100 [USE] Add Kharoshti test data from Unicode proposal test/shaping/texts/in-tree/MANIFEST | 1 + test/shaping/texts/in-tree/shaper-use/MANIFEST | 1 + .../in-tree/shaper-use/script-kharoshti/MANIFEST | 1 + .../in-tree/shaper-use/script-kharoshti/misc.txt | 36 ++++++++++++++++++++++ 4 files changed, 39 insertions(+) commit c48ff288522f33dc6c78520de0a0a74306630895 Author: Behdad Esfahbod Date: Mon Jul 20 11:46:17 2015 +0100 [USE] Build Universal Shaping Engine data table from Unicode 8 files src/gen-use-table.py | 35 +- src/hb-ot-shape-complex-use-table.cc | 1016 ++++++++++++++++++++++++++++++++++ 2 files changed, 1032 insertions(+), 19 deletions(-) commit e2c95116e1423f83a692d6170553d0cc95733d24 Author: Behdad Esfahbod Date: Mon Jul 20 11:32:48 2015 +0100 [USE] Add Universal Shaping Engine to Makefile src/Makefile.am | 23 +++- src/gen-use-table.py | 237 +++++++++++++++++++++++++++++++++ src/hb-ot-shape-complex-use-machine.rl | 0 src/hb-ot-shape-complex-use-private.hh | 0 src/hb-ot-shape-complex-use-table.cc | 0 src/hb-ot-shape-complex-use.cc | 0 6 files changed, 254 insertions(+), 6 deletions(-) commit 41a29af8053782e3a9c6a96a394bd76ef6d42099 Author: Behdad Esfahbod Date: Wed Jul 15 01:39:57 2015 +0100 Update Arabic shaping table for Unicode 8.0 src/hb-ot-shape-complex-arabic-table.hh | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) commit 64a2726e2c6efce4379a7609024ec21eb4b5e4dc Author: Behdad Esfahbod Date: Wed Jul 15 01:36:39 2015 +0100 Add Unicode 8.0 scripts Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1183209 src/hb-common.cc | 3 +++ src/hb-common.h | 7 +++++++ 2 files changed, 10 insertions(+) commit 9ae156b76820d9079bae062e7e38c34a386d9bd2 Author: Behdad Esfahbod Date: Sun Jul 5 22:43:17 2015 +0100 Fix pragma usage https://bugs.freedesktop.org/show_bug.cgi?id=91228 Commit cdcdfe61b97a0a48ccf834b6d924d187da9609be changed two `#pragma message` to `#pragma error` in hb-unicode.cc, however MSVC uses #error, just like the #else branch. `#pragma error` is an unknown pragma so MSVC does not fail the build because of it, which I believe was the intention of that commit. If it's meant to be an #error, then the #ifdef for _MSC_VER can be removed entirely. src/hb-unicode.cc | 5 ----- src/hb-warning.cc | 10 ---------- 2 files changed, 15 deletions(-) commit 8ad89f057d737ccbc6f411e9ebcf11b8130a50bb Author: ThePhD Date: Tue Jun 23 09:09:24 2015 -0400 Spelling words is not my strong point. src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e0a828ecbd708757d67977f7e92a6f4c1b0b92fd Author: ThePhD Date: Tue Jun 23 09:07:17 2015 -0400 Back to using regular `strdup`, with an `hb-private.hh` fix that special-cases VC++'s definition and usage of the words src/hb-common.cc | 2 +- src/hb-private.hh | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) commit 8e545d59610211261e684c10158b9e5df6fae24d Author: ThePhD Date: Mon Jun 22 22:29:04 2015 -0400 Fix all VC++ warnings and errors in the current commit's builds. src/hb-common.cc | 4 ++-- src/hb-fallback-shape.cc | 2 +- src/hb-ot-layout.cc | 2 +- src/hb-ot-map.cc | 2 +- src/hb-ot-shape-complex-hangul.cc | 2 +- src/hb-ot-shape-complex-hebrew.cc | 2 +- src/hb-ot-shape-complex-indic.cc | 4 ++-- src/hb-ot-shape-normalize.cc | 6 +++--- src/hb-ot-shape.cc | 2 +- 9 files changed, 13 insertions(+), 13 deletions(-) commit 5f13bbd9d4b0970851626e2ce3cf4ecb3cfde801 Author: Behdad Esfahbod Date: Fri Jun 19 13:31:49 2015 -0700 When removing default-ignorables, merge clusters Fixes test-shape, and: https://code.google.com/p/chromium/issues/detail?id=497578 src/hb-buffer-private.hh | 2 ++ src/hb-buffer.cc | 36 ++++++++++++++++++++++++++++++++++-- src/hb-ot-shape.cc | 2 +- 3 files changed, 37 insertions(+), 3 deletions(-) commit 82b521aeb7cc73879b44ca4278d6fa8b4347527f Author: Behdad Esfahbod Date: Fri Jun 19 11:57:57 2015 -0700 Rewrite hide_default_ignorables Separate the loops for the two cases of replacing with space and deleting. For deleting, use the out-buffer machinery. Needed for upcoming cluster merge fix. src/hb-buffer-private.hh | 18 ++++++++++++++ src/hb-ot-shape.cc | 65 +++++++++++++++++++++++++++++------------------- 2 files changed, 57 insertions(+), 26 deletions(-) commit b3a2f6afbac1956b65f29a17b9dc896e86135329 Author: Behdad Esfahbod Date: Thu Jun 18 17:15:33 2015 -0700 [test] Add test for cluster merging Based on test from https://code.google.com/p/chromium/issues/detail?id=497578 Currently fails. Basically, if there's a default_ignorable at the start of text, and font has no space glyph, we remove the default_ignorable, and that makes the first char in text to correspond to no cluster. Fix coming. test/api/test-shape.c | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) commit a6446d44e6d04e1eeea994682e29f9cb6265f7f6 Author: Behdad Esfahbod Date: Thu Jun 18 11:14:56 2015 -0700 0.9.41 NEWS | 10 ++++++++++ configure.ac | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) commit cd042fc8c4a3984c3647cd22a27c34f00636f6e8 Author: Behdad Esfahbod Date: Thu Jun 18 10:55:13 2015 -0700 [util] Disable hb-fc-list for now Until I figure out what to do about the API, and finalize the tool. util/Makefile.am | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) commit 351f68f4e01a107f62e4eb3458d7c7ae379939fb Author: Behdad Esfahbod Date: Fri Jun 12 17:46:06 2015 -0700 [bindings] Fix hb_language_get_default() and hb_ot_tag_to_language() Part of https://github.com/behdad/harfbuzz/issues/91 src/hb-common.cc | 2 +- src/hb-ot-tag.cc | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) commit f0c80060763475aa34a18ecbef600b6811855cb6 Author: Behdad Esfahbod Date: Fri Jun 12 17:37:41 2015 -0700 [TravisCI] Hook up Coverity First try... .travis.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) commit 8ac446908ca75bea989414a0f551a6da8885bf52 Author: Behdad Esfahbod Date: Fri Jun 12 17:29:05 2015 -0700 Add Coverity Scan badge README | 1 + 1 file changed, 1 insertion(+) commit a5e4f6d6088f6ed37fb1d68d3682b8eb4c9b46fe Author: Behdad Esfahbod Date: Wed Jun 10 10:57:46 2015 -0700 Fix warnings: "member call on null pointer of type" https://bugzilla.mozilla.org/show_bug.cgi?id=1167119 src/hb-private.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 16dac7eccf04bb357e95a8e4c18c8418dcfb4030 Author: Behdad Esfahbod Date: Wed Jun 3 12:07:46 2015 -0700 Fix build util/options.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8dacb7f8b46c70f22b70c78e0a8efc3309137650 Author: Behdad Esfahbod Date: Wed Jun 3 11:53:42 2015 -0700 Add include check to hb-ot-font.h src/hb-ot-font.h | 4 ++++ 1 file changed, 4 insertions(+) commit 37c8daf724add4a41a06385e571277d137dc2a2f Merge: f1b44303 01c3a885 Author: Behdad Esfahbod Date: Mon Jun 1 13:27:37 2015 -0700 Merge pull request #111 from brawer/since Fix "Since:" tags commit 01c3a88543850c87483fd8671044df53b368c520 Author: Sascha Brawer Date: Mon Jun 1 13:22:01 2015 +0200 Fix "Since:" tags Based on data from http://upstream-tracker.org/versions/harfbuzz.html Resolves #103 src/hb-buffer.cc | 32 +++++++++++++++++------------ src/hb-common.cc | 4 ++-- src/hb-face.cc | 12 +++++------ src/hb-font.cc | 14 ++++++------- src/hb-font.h | 4 ++-- src/hb-ft.cc | 4 ++-- src/hb-glib.cc | 3 +++ src/hb-gobject-structs.h | 18 +++++++++++++++++ src/hb-ot-font.cc | 3 +++ src/hb-ot-layout.cc | 30 ++++++++++++++++++++++++++++ src/hb-ot-shape.cc | 6 ++++++ src/hb-set.cc | 52 ++++++++++++++++++++++++------------------------ src/hb-shape-plan.cc | 18 ++++++++--------- src/hb-shape.cc | 8 ++++---- src/hb-unicode.cc | 6 +++--- src/hb-unicode.h | 31 ++++++++++++++++++++++++++--- 16 files changed, 168 insertions(+), 77 deletions(-) commit f1b44303df0712b433e35e1e1e75115c353b279e Author: Behdad Esfahbod Date: Thu May 21 14:00:15 2015 -0700 Fix unary minus operator applied to unsigned int Applying unary minus operator to unsigned int causes the following warning on MSVS: warning C4146: unary minus operator applied to unsigned type, result still unsigned Based on patch from Koji Ishi. Fixes https://github.com/behdad/harfbuzz/pull/110 src/hb-ot-font.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1ae6cdb365c15405500d4f50ec98016dde23a26b Author: Behdad Esfahbod Date: Tue May 19 17:42:30 2015 -0700 [gobject] Remove hb_language_t workarounds for g-i shortcomings Using latest gobject-introspection, I don't seem to be having this problem anymore: https://bugzilla.gnome.org/show_bug.cgi?id=707656 Removing that kludge makes language_t behave more like the way I expect it in Python. Also fixes: https://github.com/behdad/harfbuzz/issues/91 src/hb-gobject-structs.cc | 1 - src/hb-gobject-structs.h | 8 -------- 2 files changed, 9 deletions(-) commit ece434fa0fec6754e5164d881c1e967376729eca Author: Behdad Esfahbod Date: Tue May 19 17:20:58 2015 -0700 [gobject] Macroize value types Fixes user_data_t src/hb-gobject-structs.cc | 73 +++++++++++------------------------------------ 1 file changed, 17 insertions(+), 56 deletions(-) commit 9df099b4837df722e738675af318efcc9ac39a78 Author: Behdad Esfahbod Date: Mon May 18 18:37:06 2015 -0700 [ft] Don't set *glyph in get_glyph() if glyph not found src/hb-ft.cc | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) commit ff0f210519bcb0e44d4b986f7eef2004383cd344 Author: Behdad Esfahbod Date: Mon May 18 14:16:28 2015 -0700 [util] Minor util/ansi-print.cc | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) commit fbecde3d5c5c6d5af315140e4966dc850388ad63 Merge: 58015215 74139f98 Author: Behdad Esfahbod Date: Thu May 7 10:46:42 2015 -0700 Merge pull request #105 from ebraminio/master Fix Travis CI config to pass again commit 74139f9839f69ea3e7a1d17627f52fea6c06d58a Author: Ebrahim Byagowi Date: Thu May 7 13:09:32 2015 +0000 Fix Travis CI config to pass again .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 58015215321a76d68df8e0d51039904a67291108 Author: Behdad Esfahbod Date: Wed May 6 00:40:31 2015 -0700 Add note re OpenType 1.7 language tags src/hb-ot-tag.cc | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) commit f6266ad291d7686d5e110255ace5f2ff9e70bf38 Author: Roozbeh Pournader Date: Tue May 5 22:31:19 2015 -0700 [minor] Remove comment about Navajo OpenType code. Apparently the code is already standardized: https://www.microsoft.com/typography/otspec/languagetags.htm src/hb-ot-tag.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 42b00118eae46a5183e885e89e0856f41361f57e Merge: c60f3c8e cfeb0562 Author: Behdad Esfahbod Date: Tue May 5 14:49:47 2015 -0700 Merge pull request #102 from roozbehp/master Add OpenType language tag 'NAV ' for Navajo. commit c60f3c8e1156fe7328d42851013cca97333c3bf7 Author: Behdad Esfahbod Date: Mon May 4 23:10:32 2015 -0700 [README.python] Add package name for gobject-introspection on Ubuntu README.python | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit 82010a4bdb32248deb1337a3357dfae5b203c48d Author: Behdad Esfahbod Date: Mon May 4 23:09:51 2015 -0700 [travis] Comment out gobject-introspection again Apparently the version on Travis is 1.32.0, while we require 1.34.0. .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 8a254bdd29a99eb91b37e9e540179a1a01f77605 Author: Behdad Esfahbod Date: Mon May 4 19:22:11 2015 -0700 [travis] Build with introspection enabled .travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit be66ec5373634234f221ace9cfed45d76b87f20e Author: Behdad Esfahbod Date: Thu Apr 30 18:27:13 2015 -0400 Use TRUE/FALSE instead of true/false in docs src/hb-shape.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit d055e1fc781c123f38d321846937965ef794257e Author: Khaled Hosny Date: Wed Jan 8 02:28:55 2014 +0200 Some attempt into initial hb-shape documentation Very anaemic, needs to descripe the format understood by hb_feature_from_string() etc., but it is just start. src/hb-shape.cc | 70 ++++++++++++++++++++++++++++++++++++++------------------- src/hb-shape.h | 3 --- 2 files changed, 47 insertions(+), 26 deletions(-) commit 81bedda58cfc15f1987aa1952290cf9d87b4d074 Author: Behdad Esfahbod Date: Thu Apr 30 13:04:16 2015 -0400 New API: hb_buffer_reverse_range() src/hb-buffer.cc | 17 +++++++++++++++++ src/hb-buffer.h | 4 ++++ 2 files changed, 21 insertions(+) commit cfeb0562ebd8804dad731625153549eafeb78213 Author: Roozbeh Pournader Date: Wed Apr 29 09:32:42 2015 -0700 Add OpenType language tag 'NAV ' for Navajo. The code is not standardized yet, but is used in some Google fonts. src/hb-ot-tag.cc | 1 + 1 file changed, 1 insertion(+) commit f724cc351640ee075a9867ef42df32cf5e0ef3b7 Author: Jonathan Kew Date: Thu Apr 23 12:45:02 2015 +0100 Don't apply Arabic shaping to vertical text. src/hb-ot-shape-complex-private.hh | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit 97942420bbee1bc6953d5f805621066301fa17ca Author: Behdad Esfahbod Date: Thu Apr 23 18:56:24 2015 -0700 Update check-libstdc++ for clang src/check-libstdc++.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 8f0a4d67143ccdef0b5a6ac99fb9b680c3a2f69c Author: Behdad Esfahbod Date: Thu Apr 23 14:32:33 2015 -0700 [test] Ignor 'n' and 'i' in hb-unicode-encode Allows accepting uniXXXX format. test/shaping/hb_test_tools.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 39851ce84efd30f6d0570324ff8f3808a01b813b Author: Behdad Esfahbod Date: Tue Apr 21 19:23:27 2015 -0700 [coretext] Oops; fix issue number for previous commit src/hb-coretext.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 24f17afeafd40ff77177ed42c9007a0f34fcbb78 Author: Behdad Esfahbod Date: Tue Apr 21 19:21:32 2015 -0700 [coretext] Fix positioning with trailing whitespace Fixes https://code.google.com/p/chromium/issues/detail?id=476913 src/hb-coretext.cc | 11 +++++++++++ 1 file changed, 11 insertions(+) commit dba482fc4458776ffebdeb2d34b970b4223fa8fd Author: Behdad Esfahbod Date: Fri Apr 17 13:08:08 2015 -0700 [ot-font] Accept MS Symbol cmap if nothing else found src/hb-ot-font.cc | 1 + 1 file changed, 1 insertion(+) commit 3029e8b59d1667dc6a53355be89a2b55d7089b88 Author: Behdad Esfahbod Date: Tue Apr 14 13:32:22 2015 -0700 Revert "Add MSVC pragma for UTF-8 source code" This reverts commit 89cbd4d9533011fb5487caa99a0cd58923e7cf59. See discussion: https://bugzilla.gnome.org/show_bug.cgi?id=747772 src/hb-private.hh | 1 - 1 file changed, 1 deletion(-) commit 820505a186ff60e4bae9d717fe4d7ab2390e6fef Author: Behdad Esfahbod Date: Mon Apr 13 23:51:45 2015 -0700 Whitespace util/options.cc | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) commit 76d57331117be8e0c2d4a2aee8341969b62b6888 Merge: 89cbd4d9 9ee176ee Author: Behdad Esfahbod Date: Mon Apr 13 23:40:35 2015 -0700 Merge pull request #86 from cpfair/hb-shape-output-help-improvement Improve hb-shape/hb-view's help text w.r.t. output options commit 89cbd4d9533011fb5487caa99a0cd58923e7cf59 Author: Behdad Esfahbod Date: Mon Apr 13 12:27:08 2015 -0700 Add MSVC pragma for UTF-8 source code Not sure we have any right now; motivated by this: https://bugzilla.gnome.org/show_bug.cgi?id=747772 src/hb-private.hh | 1 + 1 file changed, 1 insertion(+) commit 713f99ff6138b4149d9fd382f9af3ace01ee0da5 Merge: 1086f21e 22524a51 Author: Behdad Esfahbod Date: Fri Apr 10 14:34:05 2015 -0700 Merge pull request #99 from khaledhosny/introspection-fixes2 More ntrospection fixes commit 22524a514f6609a2bc009b6035f6b5b932c719c7 Author: Khaled Hosny Date: Fri Apr 10 18:14:45 2015 +0200 [bindings] Fix hb_buffer_get_segment_properties Annotate the output parameter. src/hb-buffer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1086f21e546e2435d9da6024fd6afa7a36ba3707 Merge: 125cb083 fe97b65a Author: Behdad Esfahbod Date: Fri Apr 10 12:21:04 2015 -0700 Merge branch 'hb-fc' commit 125cb08345a7f27e565329d37093b1a60a41a403 Merge: e8fd8393 855a5d7c Author: Behdad Esfahbod Date: Fri Apr 10 12:19:57 2015 -0700 Merge pull request #98 from KonstantinRitt/WEC2013 Fix build on WEC2013 commit 04f89e8f7dfdb882e8c98afb613cba3f1d02ed7d Author: Khaled Hosny Date: Fri Apr 10 17:49:01 2015 +0200 [bindings] Fix ownership of returned hb_language_t It should not be freed by the caller. src/hb-buffer.cc | 2 +- src/hb-common.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 855a5d7cb8f585bf66dd18cb480b8c3feef62480 Author: Konstantin Ritt Date: Fri Apr 10 17:18:01 2015 +0400 Fix build on WEC2013 Based on patch from Björn Breitmeyer src/hb-private.hh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit fe97b65a54a416229e28b1c931e5e01ca19f31d3 Author: Behdad Esfahbod Date: Wed Aug 6 16:49:51 2014 -0400 [utils] Add hb-fc-list This is a tool that lists all fonts that can render a given string. It uses hb_shape() to do so, and as such is aware of HarfBuzz's normalizer. configure.ac | 19 +++++ util/Makefile.am | 15 ++++ util/hb-fc-list.c | 222 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ util/hb-fc.cc | 149 ++++++++++++++++++++++++++++++++++++ util/hb-fc.h | 46 +++++++++++ 5 files changed, 451 insertions(+) commit eb0bf3ae6688b7e98a706df2ad2714c071d77e22 Author: Behdad Esfahbod Date: Wed Aug 6 15:36:41 2014 -0400 Relax inert checks Previously, when creating an object from inert inputs (eg: "hb_font_create(hb_face_get_empty())") we returned the inert empty object. This is not helpful as there are legitimate usecases to do that. We now never return the inert object unless allocation failed. Tests are revised to reflect. src/hb-face.cc | 4 ++-- src/hb-font.cc | 4 +--- src/hb-shape-plan.cc | 7 +++++-- test/api/test-font.c | 10 +++++----- test/api/test-object.c | 34 +++++++++++++++++----------------- 5 files changed, 30 insertions(+), 29 deletions(-) commit e8fd83932a75cfbaa4638a757868915ebfac3c1f Author: Behdad Esfahbod Date: Thu Apr 9 15:52:26 2015 -0700 [util/hb-view] Fix rendering with all combinations of negative scales util/view-cairo.cc | 90 ++++++++++++++++++++++++++++-------------------------- util/view-cairo.hh | 2 -- 2 files changed, 47 insertions(+), 45 deletions(-) commit 69d5af93169ea2d87276b65d43c889a359d5d81e Author: Behdad Esfahbod Date: Thu Apr 9 15:17:16 2015 -0700 [util] Minor util/view-cairo.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) commit a664810e38b479e05ea32cac263cb5730629f9d8 Author: Behdad Esfahbod Date: Thu Apr 9 15:04:42 2015 -0700 [util] Accept comma as well as space when separating components of args Applies to --font-size and --margin. Hopefully the scanf usage here doesn't have compatibility issues (star being counted in the return value, etc). util/options.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 9c974360febcfd67247107352425fe8590d9d452 Author: Behdad Esfahbod Date: Thu Apr 9 12:04:14 2015 -0700 Minor rename src/hb-atomic-private.hh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit f3b170bdd970e31e9dbfed94c07c3cda41269aed Author: Behdad Esfahbod Date: Wed Apr 8 16:26:24 2015 -0700 Minor src/hb-common.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2958f2c147fc6327175b51a4eaca694263e34ac9 Author: Behdad Esfahbod Date: Wed Apr 8 16:26:16 2015 -0700 Fixup src/hb-atomic-private.hh | 1 + 1 file changed, 1 insertion(+) commit b931e0b0ceeab0e4819d9c4b838c1a1eb87b52e4 Author: Behdad Esfahbod Date: Wed Apr 8 14:39:00 2015 -0700 Fix warnings Part of https://github.com/behdad/harfbuzz/pull/68 src/hb-ot-font.cc | 4 ++-- src/hb-ot-layout-gsubgpos-private.hh | 22 +++++++++++----------- 2 files changed, 13 insertions(+), 13 deletions(-) commit cdcdfe61b97a0a48ccf834b6d924d187da9609be Author: Behdad Esfahbod Date: Wed Apr 8 13:25:04 2015 -0700 Err, instead of warn, if mutex / atomic / unicode funcs are missing Hopefully this results in fewer badly built HarfBuzz integrations. src/hb-unicode.cc | 8 ++++---- src/hb-warning.cc | 22 ++++++++-------------- 2 files changed, 12 insertions(+), 18 deletions(-) commit fc3c59a1d746c5280f6216a94fdc1be3e826051f Author: Behdad Esfahbod Date: Wed Apr 8 13:03:27 2015 -0700 Fix unused var warnings src/hb-ot-layout-gpos-table.hh | 1 - src/hb-ot-layout-gsub-table.hh | 1 - 2 files changed, 2 deletions(-) commit 3f174cd020b7762fae96f20ce14fc9e9abec748f Author: Konstantin Ritt Date: Sat Mar 28 00:49:33 2015 +0400 Minor refactoring to the atomics implementation s/atomic_int/atomic_int_impl/ and s/atomic_ptr/atomic_ptr_impl/ to bring it in par with hb_mutex_impl_t, then re-introduce hb_atomic_int_t as a wrapper around hb_atomic_int_impl_t. In hb_reference_count_t, make it clear the non-atomic get and set are intentional due to nature of the cases they are used in (comparison to -1 and the debug output/tracing). src/hb-atomic-private.hh | 86 +++++++++++++++++++++++++++++++----------------- src/hb-mutex-private.hh | 4 ++- src/hb-object-private.hh | 21 ++++++------ 3 files changed, 69 insertions(+), 42 deletions(-) commit 24930d544ee9e247e4cf6a5f6d5207ba9d7a3ddc Author: Behdad Esfahbod Date: Wed Apr 8 12:52:06 2015 -0700 Minor src/hb-mutex-private.hh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 45a8b46f478d4aa63ae5df74b6bb28ebdd7521ac Author: Behdad Esfahbod Date: Wed Apr 8 12:49:38 2015 -0700 Allow implementing atomic and mutex ops in config Motivated by https://github.com/behdad/harfbuzz/pull/92 src/hb-atomic-private.hh | 6 +++++- src/hb-mutex-private.hh | 7 ++++++- 2 files changed, 11 insertions(+), 2 deletions(-) commit 3fe4e92bc5ff09d84c6763cedf06ce80d15a5fb2 Author: Behdad Esfahbod Date: Wed Apr 8 12:49:23 2015 -0700 Minor src/hb-set-private.hh | 1 - 1 file changed, 1 deletion(-) commit 9868749abe468130d89c80a2501847a83acb4579 Author: Behdad Esfahbod Date: Mon Apr 6 14:51:31 2015 -0700 [test] Use /usr/bin/env python instead of /usr/bin/python Bug 76494 - #!/usr/bin/python in testsuite https://bugs.freedesktop.org/show_bug.cgi?id=76494 test/shaping/hb-diff | 2 +- test/shaping/hb-diff-colorize | 2 +- test/shaping/hb-diff-filter-failures | 2 +- test/shaping/hb-diff-ngrams | 2 +- test/shaping/hb-diff-stat | 2 +- test/shaping/hb-manifest-read | 2 +- test/shaping/hb-manifest-update | 2 +- test/shaping/hb-unicode-decode | 2 +- test/shaping/hb-unicode-encode | 2 +- test/shaping/hb-unicode-prettyname | 2 +- test/shaping/hb_test_tools.py | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-) commit bfcddd32a674dd19fca1bf521e95466a0eec5179 Merge: ce01ad7c 363ceec3 Author: Behdad Esfahbod Date: Mon Apr 6 14:41:32 2015 -0700 Merge pull request #93 from ebraminio/archpy3 Make hb_test_tools.py compatible with python 3 commit ce01ad7c2f5a259030f4dbec746f85522aa9c3f9 Author: Behdad Esfahbod Date: Wed Apr 1 11:05:59 2015 -0700 MSVC 2015 supports snprintf and not _snprintf src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 560718862f0bd994b62361652d6fd558c4182e2a Author: Behdad Esfahbod Date: Wed Apr 1 11:04:33 2015 -0700 Move WinCE define to better place src/hb-private.hh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 363ceec3fb0c9566db5a59da31e508f69dea1e92 Author: Ebrahim Byagowi Date: Mon Mar 30 03:27:14 2015 +0430 Make hb_test_tools.py compatible with python 3 On ArchLinux, /usr/bin/python is linked to python 3 so HarfBuzz `make check` is broken there. This makes hb_test_tools.py compatible with python 3 while no breaking it on python 2. test/shaping/hb_test_tools.py | 44 ++++++++++++++++++++++++------------------- 1 file changed, 25 insertions(+), 19 deletions(-) commit aee685086c8fde6f6c4590e483a177c19f222540 Author: Behdad Esfahbod Date: Thu Mar 26 14:13:53 2015 -0400 Fix VC++ /analyze warnings out\debug\hb-buffer-deserialize-text.rl(47) : warning C6001: Using uninitialized memory 'pos'. src/hb-buffer-deserialize-text.rl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 8886ab430ca68539cb318e175647e9f6973718b0 Merge: e3671b8f a394bb66 Author: Behdad Esfahbod Date: Sun Mar 22 16:18:57 2015 -0400 Merge pull request #90 from khaledhosny/introspection-fixes [bindings] Fix *_from_string functions commit a394bb66707184c995fe2d08c80e98220e6ec0b0 Author: Khaled Hosny Date: Sun Mar 22 20:29:10 2015 +0200 [bindings] Fix *_from_string functions Without the element-type they will be getting garbage, at least with Python. src/hb-common.cc | 8 ++++---- src/hb-font.cc | 2 +- src/hb-shape.cc | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) commit e3671b8f8bb339e8a563a9da9cd5069073200fec Author: Behdad Esfahbod Date: Fri Mar 20 18:03:02 2015 -0400 0.9.40 NEWS | 8 ++++++++ configure.ac | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) commit 9e401f6890f2bea1d11914bca436c2230f8d0f1b Author: Behdad Esfahbod Date: Fri Mar 20 16:08:38 2015 -0400 Fix reverse_range() for empty range Fixes coretext notdef loop consisting of all default_ignorable glyphs https://code.google.com/p/chromium/issues/detail?id=464755 src/hb-buffer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7481bd49d56d4e814ab1f85fc2df8bf934d520f4 Author: Behdad Esfahbod Date: Wed Mar 4 15:47:25 2015 -0800 Fix previous commit I misunderstood how which works. autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6763e21afb77b250ad4416ff921d46c63ea12443 Author: Behdad Esfahbod Date: Wed Mar 4 15:43:05 2015 -0800 Accept glibtoolize as libtoolize Of course, we don't really run it, autoreconf does. We just err if neither is available. glibtoolize is the name it is shipped under on OS X. Reported by Adam. autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 02a04e6afb1a76894f3723a467716607970d95d3 Author: Behdad Esfahbod Date: Wed Mar 4 12:32:03 2015 -0800 0.9.39 NEWS | 10 ++++++++++ configure.ac | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) commit 98e3ea8e34c798ce003e946c9a150bb41be9d09b Author: Behdad Esfahbod Date: Wed Mar 4 12:03:39 2015 -0800 Fix hb-uniscribe build src/hb-ot-name-table.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8ac345e5c0ed0aad6547592ea0839aabfb4ba980 Author: Behdad Esfahbod Date: Mon Mar 2 16:06:55 2015 -0800 Fix reverse_range() to only reverse alt array if positions are used In hb-coretext, when we were using scratch buffer for book-keeping, a reverse_range() caused by the notdef-insertion loop could mess up our log_clusters. Ouch! src/hb-buffer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1e03d7ac83f3e17aafed1e37390d9ff8394e36da Author: Behdad Esfahbod Date: Thu Feb 26 13:58:32 2015 -0800 Better error message if libtool is not installed Fixes https://github.com/behdad/harfbuzz/pull/88 autogen.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) commit 6c918e2997fb82e89485f2b50bee2bf4fcd70592 Author: Behdad Esfahbod Date: Thu Feb 26 13:55:34 2015 -0800 Clean up gtk-doc.make Makefile.am | 1 + 1 file changed, 1 insertion(+) commit 5ec5875acb12cf07447c9ebfb03212601368dfc4 Author: Behdad Esfahbod Date: Thu Feb 26 13:53:05 2015 -0800 Install git.mk in docs/ docs/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) commit d146678d103425b3da7ef393bc6d66f6ba4c5593 Author: Behdad Esfahbod Date: Thu Feb 26 13:52:50 2015 -0800 Update git.mk from upstream git.mk | 35 ++++++++++++++++++++++++++++------- 1 file changed, 28 insertions(+), 7 deletions(-) commit 5f541f8f7be82f29b77b481827deb212e12d53e4 Author: Behdad Esfahbod Date: Sat Feb 21 16:51:17 2015 +0300 Minor refactoring src/hb-private.hh | 44 ++++++++++++++++++++++++++++---------------- 1 file changed, 28 insertions(+), 16 deletions(-) commit ef79bdf73bbfde1bfaa222834809d105ab7755b3 Author: Behdad Esfahbod Date: Sat Feb 21 16:49:15 2015 +0300 Minor src/hb-ot-layout-common-private.hh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 68e04afbb1e1073c47474f7a4d6d2cacf7057f6f Author: Behdad Esfahbod Date: Sat Feb 21 16:30:28 2015 +0300 Typo src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 55553699b38d6481fbfacd0a32fc266e55553b34 Author: Behdad Esfahbod Date: Sat Feb 21 16:29:08 2015 +0300 Minor src/hb-private.hh | 2 -- 1 file changed, 2 deletions(-) commit 5175300fbaf4ff19b7d38c14c86331bb614b0390 Author: Behdad Esfahbod Date: Sat Feb 21 12:50:01 2015 +0300 [layout] Fix comparison of GlyphID and hb_codepoint_t Before, the IntType::cmp functions providing this and was truncating the hb_codepoint_t to 16bits before comparison. I have no idea how this was never discovered, and I'm too lazy to try to reproduce this with Pango (which uses non-16bit codepoint numbers for missing glyphs). src/hb-open-type-private.hh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 7cce809cb11e0ce65dbdab899779ece3dc337763 Author: Behdad Esfahbod Date: Sat Feb 21 12:41:08 2015 +0300 Remove unused (and wrong as of a few commits ago) cmp() function src/hb-open-type-private.hh | 1 - 1 file changed, 1 deletion(-) commit 8e3d4bae033bdec649676da26cfc3eb7610832a8 Author: Behdad Esfahbod Date: Sat Feb 21 12:31:59 2015 +0300 Minor src/hb-ot-layout-common-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f47cf1f12dd1fa3cd3aa84502139caca9d469af8 Author: Behdad Esfahbod Date: Sat Feb 21 11:45:22 2015 +0300 Minor src/hb-ot-layout.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 640b66c6348653bfd7cf88ea9caa2133c0eb949f Author: Behdad Esfahbod Date: Thu Feb 19 17:30:05 2015 +0300 [layout] If lookup has only one subtable, move the forward loop down to subtable I was hoping to see a nice speedup, but it resulted in a very minor one. src/hb-ot-layout.cc | 33 ++++++++++++++++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) commit e2f50f2a7ebf9882ea89dc3f0c740e7fce964e37 Author: Behdad Esfahbod Date: Thu Feb 19 17:15:05 2015 +0300 [layout] Add apply_forward / apply_backward src/hb-ot-layout.cc | 69 +++++++++++++++++++++++++++++++++++------------------ 1 file changed, 46 insertions(+), 23 deletions(-) commit 1d4a328472f094c0d75a062f6e176c6b1875cfdc Author: Behdad Esfahbod Date: Thu Feb 19 11:33:30 2015 +0300 [layout] Remove unneeded return value from apply() src/hb-ot-layout.cc | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) commit bbdd6fd21cc2e079defff7cb17c3eb8eff3f9e09 Author: Behdad Esfahbod Date: Thu Feb 19 17:03:02 2015 +0300 Minor simpilfy BEInt src/hb-open-type-private.hh | 25 ++----------------------- 1 file changed, 2 insertions(+), 23 deletions(-) commit 88a399acdc0fcb060803da0e7db56de2866981e3 Author: Behdad Esfahbod Date: Thu Feb 19 16:57:12 2015 +0300 Optimize IntType comparison to avoid branches for 16bit numbers src/hb-open-type-private.hh | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) commit 37de2d533126245774417234e3536fcfb24f3a6b Author: Behdad Esfahbod Date: Thu Feb 19 16:55:51 2015 +0300 Minor simplify IntType src/hb-open-type-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bd047d3b7f04d551c0a26bc0ce9b9d61481e34e1 Author: Behdad Esfahbod Date: Thu Feb 19 10:47:18 2015 +0300 [layout] Minor src/hb-ot-layout-gpos-table.hh | 6 ++++++ src/hb-ot-layout-gsub-table.hh | 6 ++++++ src/hb-ot-layout.cc | 4 ++-- 3 files changed, 14 insertions(+), 2 deletions(-) commit b9d3f60520c022dc952e65a66eb138d1f7cae2e1 Author: Behdad Esfahbod Date: Thu Feb 19 10:42:41 2015 +0300 [layout] Minor src/hb-ot-layout.cc | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) commit 1a2322134a5d7bba990da28baf893b35879a5a7a Author: Behdad Esfahbod Date: Thu Feb 19 10:40:23 2015 +0300 [layout] Don't check glyph props against lookup flags when recursing Shouldn't be needed. I have a hard time imagining this breaking any legitimate use case. src/hb-ot-layout-gpos-table.hh | 10 +--------- src/hb-ot-layout-gsub-table.hh | 10 +--------- 2 files changed, 2 insertions(+), 18 deletions(-) commit 095a1257cc3cc56b044b4cd842a92f0d0f933a50 Author: Behdad Esfahbod Date: Thu Feb 19 10:29:41 2015 +0300 [layout] Port sanitize() to use dispatch() Needed some rework of Extension table. Hopefully I got it right, and the new template usage doesn't break any compilers... src/hb-open-type-private.hh | 5 ++- src/hb-ot-layout-gpos-table.hh | 82 +---------------------------------- src/hb-ot-layout-gsub-table.hh | 72 ++----------------------------- src/hb-ot-layout-gsubgpos-private.hh | 84 ++++++++++++------------------------ 4 files changed, 37 insertions(+), 206 deletions(-) commit 758fb20630f84c3d373cda37974b88f16c02995e Author: Behdad Esfahbod Date: Wed Feb 18 13:45:03 2015 +0300 Remove unused macro src/hb-ot-shape-complex-arabic-win1256.hh | 1 - 1 file changed, 1 deletion(-) commit 40c58923cbf689c465f9b65334c455a9b7f71ab0 Author: Behdad Esfahbod Date: Wed Feb 18 13:18:46 2015 +0300 [layout] Refactor Lookup::dispatch() src/hb-ot-layout-common-private.hh | 20 ++++++++++++++++++++ src/hb-ot-layout-gpos-table.hh | 12 +----------- src/hb-ot-layout-gsub-table.hh | 12 +----------- src/hb-ot-layout-gsubgpos-private.hh | 6 ------ 4 files changed, 22 insertions(+), 28 deletions(-) commit 70366f5d19df2e654f0933474fecf1aa16e27812 Author: Behdad Esfahbod Date: Wed Feb 18 13:09:54 2015 +0300 [layout] Refactor get_subtable() src/hb-ot-layout-common-private.hh | 12 ++++++++++++ src/hb-ot-layout-gpos-table.hh | 4 ++-- src/hb-ot-layout-gsub-table.hh | 6 +++--- 3 files changed, 17 insertions(+), 5 deletions(-) commit f72f326aea6d1e93f63040730f7aecd401676c1c Author: Behdad Esfahbod Date: Tue Feb 17 19:18:07 2015 +0300 Minor src/hb-ot-layout-gpos-table.hh | 1 - 1 file changed, 1 deletion(-) commit 8e36ccfd4f076888076ca176c055c18104af03b6 Author: Behdad Esfahbod Date: Tue Feb 17 19:15:34 2015 +0300 [layout] Use dispatch() for add_coverage() src/hb-ot-layout-gpos-table.hh | 12 ++---------- src/hb-ot-layout-gsub-table.hh | 12 ++---------- src/hb-ot-layout-gsubgpos-private.hh | 12 ++++++++++-- 3 files changed, 14 insertions(+), 22 deletions(-) commit 50b8dc79daffc7ef671dd5eedfea47f8d5e946f4 Author: Behdad Esfahbod Date: Tue Feb 17 18:14:17 2015 +0300 [layout] Add may_dispatch() No functional change right now. src/hb-ot-layout-gpos-table.hh | 7 +++++++ src/hb-ot-layout-gsub-table.hh | 6 ++++++ src/hb-ot-layout-gsubgpos-private.hh | 12 ++++++++++++ 3 files changed, 25 insertions(+) commit de2118ed7a998a1df9b28fd1be96b4af89ed82c3 Author: Behdad Esfahbod Date: Tue Feb 17 17:27:44 2015 +0300 Make sanitize() a const method This makes a lot of code safer. We only try modifying the object in one place, after making sure it's safe to do so. So, do a const_cast<> in that one place... src/hb-open-file-private.hh | 15 +++-- src/hb-open-type-private.hh | 51 +++++++++++------ src/hb-ot-cmap-table.hh | 35 ++++++++---- src/hb-ot-head-table.hh | 6 +- src/hb-ot-hhea-table.hh | 3 +- src/hb-ot-hmtx-table.hh | 3 +- src/hb-ot-layout-common-private.hh | 58 ++++++++++++------- src/hb-ot-layout-gdef-table.hh | 30 ++++++---- src/hb-ot-layout-gpos-table.hh | 108 +++++++++++++++++++++++------------ src/hb-ot-layout-gsub-table.hh | 58 ++++++++++++------- src/hb-ot-layout-gsubgpos-private.hh | 65 +++++++++++++-------- src/hb-ot-layout-jstf-table.hh | 12 ++-- src/hb-ot-maxp-table.hh | 6 +- src/hb-ot-name-table.hh | 6 +- 14 files changed, 296 insertions(+), 160 deletions(-) commit 6759ed95a3bec2874826376b68ebff19ba277ef2 Author: Behdad Esfahbod Date: Tue Feb 17 16:05:30 2015 +0300 Minor src/hb-ot-layout-gpos-table.hh | 6 ++---- src/hb-ot-layout-gsub-table.hh | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) commit 6b599dac1f814a3c900300241d4c492a8f8b66d2 Author: Behdad Esfahbod Date: Tue Feb 17 16:04:07 2015 +0300 Remove unnecessary check in sanitize src/hb-ot-layout-gpos-table.hh | 2 -- src/hb-ot-layout-gsub-table.hh | 2 -- 2 files changed, 4 deletions(-) commit 365576d246949f9d587e90cf0539dc0381e4d0a3 Author: Behdad Esfahbod Date: Thu Jan 29 13:59:42 2015 +0100 [layout] Allocate iters in the context Can be further optimized, but I think I didn't break anything. Saves another 3% off Roboto shaping. src/hb-ot-layout-gpos-table.hh | 18 ++++++------------ src/hb-ot-layout-gsubgpos-private.hh | 21 +++++++++++++-------- src/hb-ot-shape-fallback.cc | 2 +- 3 files changed, 20 insertions(+), 21 deletions(-) commit 514564f5444b8ad2f210b1e3d7d66378f7275317 Author: Behdad Esfahbod Date: Thu Jan 29 13:48:48 2015 +0100 [layout] Move skippy_iter setup from constructor into init() src/hb-ot-layout-gpos-table.hh | 18 ++++++++++++------ src/hb-ot-layout-gsubgpos-private.hh | 28 +++++++++++++++------------- src/hb-ot-shape-fallback.cc | 3 ++- 3 files changed, 29 insertions(+), 20 deletions(-) commit b051be542a8945ec14b0192bbc285f3e1a78c8f1 Author: Behdad Esfahbod Date: Thu Jan 29 13:40:39 2015 +0100 [lookup] Add skippy_iter.reset() Towards reducing the cost of initializing skippy_iter() src/hb-ot-layout-gpos-table.hh | 18 ++++++++++++------ src/hb-ot-layout-gsubgpos-private.hh | 27 ++++++++++++++++++--------- src/hb-ot-shape-fallback.cc | 3 ++- 3 files changed, 32 insertions(+), 16 deletions(-) commit 2cecc38c7cf49b2cf697efa7e974ceee7055f2c5 Author: Behdad Esfahbod Date: Thu Jan 29 13:32:05 2015 +0100 [layout] Shuffle code around src/hb-ot-layout-gsubgpos-private.hh | 111 ++++++++++++++++++----------------- 1 file changed, 56 insertions(+), 55 deletions(-) commit 696266981df5ef6c62ad0115133dad1d6c1d9acc Author: Behdad Esfahbod Date: Thu Jan 29 13:08:41 2015 +0100 [layout] Merge forward and backward iterators src/hb-ot-layout-gpos-table.hh | 12 +++--- src/hb-ot-layout-gsubgpos-private.hh | 71 ++++++++---------------------------- src/hb-ot-shape-fallback.cc | 2 +- 3 files changed, 23 insertions(+), 62 deletions(-) commit 1f038eec3c0dd6331036f795614fe1ddcbf613b0 Author: Behdad Esfahbod Date: Thu Jan 29 13:05:25 2015 +0100 [layout] Fix backward reject() Has no functional effect since reject was never used with match_glyph_data. src/hb-ot-layout-gsubgpos-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 37d13acd8d414a4b53fac0152addfadecf755cd4 Author: Behdad Esfahbod Date: Thu Jan 29 11:38:01 2015 +0100 [layout] Remove some unnecessary checks in skippy src/hb-ot-layout-gpos-table.hh | 3 --- src/hb-ot-layout-gsubgpos-private.hh | 9 ++------- 2 files changed, 2 insertions(+), 10 deletions(-) commit baa14e18148d3f5493f78b4fe9e0c835a01f50f7 Author: Behdad Esfahbod Date: Thu Jan 29 11:08:43 2015 +0100 [lookup] Don't initialize skippy if coverage match fails Currently: - Initializing skippy is very expensive, - Our lookup accelerator (using set-digests) can be very ineffecite, As such, we end up many times initializing skippy but then failing coverage check. Reordering fixes that. When, later, we fix our accelerator to have truly small false-positive rate (for example by using the frozen-sets), then we might want to reorder these checks such that we wouldn't calculate coverage number if skippy is going to fail. This shows a 5% speedup with Roboto already. src/hb-ot-layout-gpos-table.hh | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) commit 7788993bc19bf122f1e143ab64cc1da2ed1865a3 Author: Behdad Esfahbod Date: Wed Jan 28 23:01:12 2015 -0800 [layout] Use setter method to set c->lookup_props src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-layout-gsub-table.hh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit f4ee48fd7b312550faf9b0be4cd1b2f2849dd08d Author: Behdad Esfahbod Date: Wed Jan 28 22:53:54 2015 -0800 [layout] Remove unused wrapper method src/hb-ot-layout-gsubgpos-private.hh | 2 -- 1 file changed, 2 deletions(-) commit 7b7129c7a997def599fb4d2ba05fda40d27aed20 Author: Behdad Esfahbod Date: Wed Jan 28 21:46:07 2015 -0800 Add hb_frozen_set_t I experimented with replacing use of hb_set_digest_t with this new hb_frozen_set_t, hoping to get a huge speedup for busy lookups (like kern lookup in Roboto), but I only got 6% speendup in Roboto and 4% in NotoNastaliqUrduDraft :(. src/hb-set-private.hh | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 56 insertions(+), 1 deletion(-) commit 241eac9559465fa79f396570af4e87f455b7e9d5 Author: Behdad Esfahbod Date: Wed Jan 28 20:55:42 2015 -0800 Hide internals of lookup accelerators src/hb-ot-layout-gsub-table.hh | 5 +++-- src/hb-ot-layout-private.hh | 5 +++++ src/hb-ot-layout.cc | 6 +++--- 3 files changed, 11 insertions(+), 5 deletions(-) commit e2d4e8480d85436a3acad8145acac345ed593f5a Author: Behdad Esfahbod Date: Wed Jan 28 20:29:48 2015 -0800 [util] Add convenience "make lib" target util/Makefile.am | 4 ++++ 1 file changed, 4 insertions(+) commit faaae64bf28abdcdd15185374bc09a3809794118 Merge: 7888a6b0 9768e651 Author: Behdad Esfahbod Date: Wed Feb 25 15:34:34 2015 -0800 Merge pull request #85 from KonstantinRitt/define_inline Fix build with MSVC on CE commit 9ee176ee978e6668c4faf00028811ce70979122e Author: Collin Fair Date: Sat Feb 14 09:59:44 2015 -0500 Stop hb-shape docs leaking into hb-view util/options.cc | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) commit 952b8dbdf61da9b4814e09ad3c1b9b76483bef5c Author: Collin Fair Date: Sat Feb 14 09:44:00 2015 -0500 'All' of the above, not 'each' util/options.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 9e867b64467c46eea5cc9b1d5a9404a1221bbbfc Author: Collin Fair Date: Sat Feb 14 09:32:04 2015 -0500 Remove reference to --help-output-content in --help-output (as --help-output-format's options aren't available in hb-view) util/options.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1d55ffeb66381889f11ebb9039ca4ec2ca5efbab Author: Collin Fair Date: Sat Feb 14 09:29:35 2015 -0500 Add serialization syntax documentation. Clarify naming and wording in --help-output/--help-format util/options.cc | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) commit 9768e651be0561f07d6f38c3ed8bc5ee04882990 Author: Konstantin Ritt Date: Sat Feb 14 00:58:51 2015 +0400 Fix build with MSVC on CE This code is C++ only. There isn't a single C++ compiler that fails to understand the "inline" keyword, since it's required by C++98. Any compiler older than C++98 is likely to choke on the template usage further down, so this isn't necessary. Moreover, the C++ standard says you cannot define macros. [lib.macro.names] says "Nor shall such a translation unit define macros for names lexically identical to keywords." -- technically, it's a promise that the Standard Library headers won't do it, the wording means that the entire translation unit won't do it, which implies no source can do it. MSVC complains about it: fatal error C1189: #error : The C++ Standard Library forbids macroizing keywords. Enable warning C4005 to find the forbidden macro. Author: Thiago Macieira src/hb-private.hh | 10 ---------- 1 file changed, 10 deletions(-) commit 7888a6b07a9922cedd3e0d235959058e0011357b Author: Behdad Esfahbod Date: Wed Jan 28 12:40:40 2015 -0800 [ft] Handle negative scales with vertical writing src/hb-ft.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit 982d94eaa2a377616f22f39427e5ed9f1ce43263 Author: Behdad Esfahbod Date: Wed Jan 28 10:51:33 2015 -0800 [coretext] Don't generate notdef glyph for default-ignorables As discovered on Chrome Mac: https://code.google.com/p/chromium/issues/detail?id=452326 src/hb-coretext.cc | 2 ++ src/hb-ot-shape.cc | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) commit 6917a045fd8d16952cad75fda8b291b11e1d3564 Author: Behdad Esfahbod Date: Wed Jan 28 10:43:32 2015 -0800 [coretext] Unbreak glyph positioning in presence of notdef runs As discovered on Chrome Mac: https://code.google.com/p/chromium/issues/detail?id=452326 This was originally broken in: commit 5a0eed3b50629be4826e4e9428f2c3255195395d Author: Behdad Esfahbod Date: Mon Aug 11 23:47:16 2014 -0400 [coretext] Implement vertical shaping src/hb-coretext.cc | 35 +++++++++++++++++++++++++++-------- 1 file changed, 27 insertions(+), 8 deletions(-) commit 1eff4350239b0768e1042b52db9fb1c0d266f96a Author: Behdad Esfahbod Date: Tue Jan 27 12:26:04 2015 -0800 Minor optimization src/hb-ot-shape-normalize.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) commit 675956aca01fc4e005a338af43d1c1f4f938abd1 Author: Konstantin Ritt Date: Tue Jan 27 11:23:07 2015 +0400 Do not leak hb_language_t on hb_language_item_t destruction src/hb-common.cc | 1 + 1 file changed, 1 insertion(+) commit b306f9674a599da50754d24fa5aefcb6bba04420 Author: Konstantin Ritt Date: Tue Jan 27 20:08:41 2015 +0400 Minor improvement to HB_SHAPER_DATA_DESTROY src/hb-shaper-private.hh | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) commit 61820bc4ca1f02433db4be7c81f27cf97e2bd519 Author: Behdad Esfahbod Date: Mon Jan 26 14:25:52 2015 -0800 [API] Add hb_buffer_add_latin1() This is by no ways to promote non-Unicode encodings. This is an entry point that takes Unicode codepoints that happen to all be the first 256 characters and hence fit in 8bit strings. This is useful eg in Chrome where strings that can fit in 8bit are implemented that way, and this avoids copying into UTF-8 or UTF-16. Perhaps we should rename this to hb_buffer_add_codepoints8(). I'm also curious if anyone would be really interested in hb_buffer_add_codepoints16(). Please discuss! src/hb-buffer.cc | 36 +++++++++++++++++++++++++------- src/hb-buffer.h | 8 ++++++++ src/hb-utf-private.hh | 57 ++++++++++++++++++++++++++++++++++++++------------- 3 files changed, 80 insertions(+), 21 deletions(-) commit 78c6e86c04f12154c88b9f9264d0bd50b721699b Author: Behdad Esfahbod Date: Mon Jan 26 14:08:36 2015 -0800 Fix hb_buffer_add_codepoints to actually NOT validate src/hb-buffer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 70c25ee215635db23eb0757641bd372940c0d85d Merge: 28f5e0b2 f3537b62 Author: Behdad Esfahbod Date: Sun Jan 25 13:06:03 2015 -0800 Merge pull request #81 from KonstantinRitt/fixes/build/win8phone winrt_buildfixes commit f3537b620b0a7392ea27f01f465c5ba79459c858 Author: Konstantin Ritt Date: Sun Jan 25 09:50:51 2015 +0400 Move some code around Just to keep Windows specific workarounds in a single place. src/hb-private.hh | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) commit afb62d88d78cacb6b881aaf329a654fd32f5ae29 Author: Konstantin Ritt Date: Sun Jan 25 08:16:26 2015 +0400 Do not define MemoryBarrier on WinCE There is a _HBMemoryBarrier() wrapper function that emulates MemoryBarrier() behavior when it is not defined. src/hb-private.hh | 1 - 1 file changed, 1 deletion(-) commit 7db326a15b173c0d101adc608bf551a628c65dcd Author: Konstantin Ritt Date: Sun Jan 25 08:13:24 2015 +0400 Fix build on WinRT There is no environment (like WinCE) and the basic version of InitializeCriticalSection is unsupported. https://codereview.qt-project.org/#/c/92496/ src/hb-mutex-private.hh | 4 ++++ src/hb-private.hh | 2 ++ 2 files changed, 6 insertions(+) commit 28f5e0b2f41670617bd778660364bbd58b1b68f2 Author: Behdad Esfahbod Date: Fri Jan 23 12:45:35 2015 -0800 0.9.38 NEWS | 23 +++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 24 insertions(+), 1 deletion(-) commit a319d0777b746a2bbe5cd5a206172f1580da3379 Author: Behdad Esfahbod Date: Fri Jan 23 12:44:24 2015 -0800 [ft] Handle negative x_scale / y_scale src/hb-ft.cc | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) commit b0b38bb892473d9a65e06dd3b4713da39f92bef9 Author: Behdad Esfahbod Date: Wed Jan 21 19:19:33 2015 -0800 [coretext] Fix positioning of notdef src/hb-coretext.cc | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) commit 70622e5089c01ea16fd9deed11cb39d43145c121 Author: Behdad Esfahbod Date: Wed Jan 21 18:50:57 2015 -0800 [coretext] Fix scaling Before we were not accounting for possible differences in x_scale and y_scale, as well as the signs of those. All should be in good shape now. src/hb-coretext.cc | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) commit 221ba02b0816584a02471037edae7cec9c1b8acc Author: Behdad Esfahbod Date: Wed Jan 21 16:42:09 2015 -0800 [coretext] Use vertical advance for notdef in vertical direction src/hb-coretext.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit 7988da24c507ee310772f72cc5bcfd3c0a1187a0 Author: Behdad Esfahbod Date: Wed Jan 21 18:33:50 2015 -0800 Add convenience make target "make lib" in src/ src/Makefile.am | 3 +++ 1 file changed, 3 insertions(+) commit 31d48dd919e3b4a0bec5ede384f76db9b44f4d71 Author: Behdad Esfahbod Date: Wed Jan 21 01:57:44 2015 -0800 Add README.python README.python | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) commit ca1c2813dd0b082a8c418bd3edd3f6cba97bd5f0 Author: Behdad Esfahbod Date: Wed Jan 21 01:51:48 2015 -0800 [bindings] Add README.python Makefile.am | 1 + 1 file changed, 1 insertion(+) commit cd4eb96abb90a84b42e9b288e39bad759e4411a0 Author: Behdad Esfahbod Date: Tue Jan 20 12:30:45 2015 -0800 [util] Add --font-size to hb-shape Also makes hb-view to use 8 bits of subpixel precision and shape at requested size, instead of always shaping at upem and scaling results. util/hb-ot-shape-closure.cc | 2 +- util/hb-shape.cc | 2 +- util/hb-view.cc | 5 ++++- util/helper-cairo.cc | 16 ++++++++-------- util/helper-cairo.hh | 5 ++--- util/main-font-text.hh | 4 ++-- util/options.cc | 44 +++++++++++++++++++++++++++++++++++++++++--- util/options.hh | 16 ++++++++++++---- util/view-cairo.cc | 2 +- util/view-cairo.hh | 8 ++++---- 10 files changed, 76 insertions(+), 28 deletions(-) commit 5789ca69d7464bab5fa0c5bdf404f3afaa490faf Author: Behdad Esfahbod Date: Fri Jan 9 14:22:01 2015 -0800 [util] Minor util/options.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 67dfa8c7c2f2e9040a9c60c680f739ada4a35fb5 Author: Behdad Esfahbod Date: Mon Jan 19 17:00:31 2015 -0800 When matching second glyph of kerning pairs, use bsearch Roboto has glyphs (like 'F') that have 200 kerning pairs. Add a handcoded bsearch instead of previous linear search. This doesn't show much speedup though, apparently we spend the bulk of the time somewhere before here. src/hb-ot-layout-gpos-table.hh | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) commit e9f5c65be027eb7759ab819e267e24dff3b017b6 Author: Behdad Esfahbod Date: Mon Jan 19 14:42:11 2015 -0800 [bindings] Minor src/sample.py | 2 ++ 1 file changed, 2 insertions(+) commit 3704628d1f124234324b5f2bdd5fdd61c14c7801 Merge: 1aaa7d67 5eb939dd Author: Behdad Esfahbod Date: Mon Jan 19 16:15:00 2015 -0800 Merge pull request #77 from roozbehp/master Change New Tai Lue shaping engine from SEA to default commit 5eb939ddfe9ef217da2e48d7d0f1f4b7501714ad Author: Roozbeh Pournader Date: Sun Jan 18 14:30:08 2015 -0800 Change New Tai Lue shaping engine from SEA to default This is to reflect the UTC decision to change the encoding model of New Tai Lue from logical to visual to be similar to Thai, Lao, and Tai Viet: http://www.unicode.org/L2/L2014/14250.htm#141-C26 The visual encoding is already the current practice of encoding New Tai Lue on the web anyway: http://www.unicode.org/L2/L2014/14195-newtailue.txt Fixes behdad/harfbuzz#66. src/hb-ot-shape-complex-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1aaa7d6799b42b392dd191d3c12011721ef99e74 Author: Behdad Esfahbod Date: Sat Jan 17 20:16:56 2015 -0800 [indic] Fix out-of-bounds access src/gen-indic-table.py | 2 +- src/hb-ot-shape-complex-indic-table.cc | 36 +++++++++++++++++----------------- 2 files changed, 19 insertions(+), 19 deletions(-) commit 238d6a38f2ceb7d8dceec9365a823f032b3b9f7d Author: Behdad Esfahbod Date: Wed Jan 7 10:51:44 2015 -0800 [bindings] Update sample.py src/sample.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit 2cd5323531dcd800549b2cb1cb51d708e72ab2d8 Author: Behdad Esfahbod Date: Tue Jan 6 19:16:38 2015 -0800 [bindings] Use hb_glib_blob_create() in sample hb_blob_create() is considered C-only API. src/hb-blob.cc | 8 ++++---- src/sample.py | 19 +++++++++---------- 2 files changed, 13 insertions(+), 14 deletions(-) commit 0ef179e2dc040c13497af847b8c1cec846dbdbf9 Author: Behdad Esfahbod Date: Tue Jan 6 16:58:33 2015 -0800 [glib] Add hb_glib_blob_create() that takes GBytes src/hb-glib.cc | 11 +++++++++++ src/hb-glib.h | 3 +++ 2 files changed, 14 insertions(+) commit b91904a40da6287f84bc79de60674fa57232ec09 Author: Behdad Esfahbod Date: Tue Jan 6 15:43:14 2015 -0800 [bindings] Replace deprecated allow-none with optional and nullable src/hb-blob.cc | 4 ++-- src/hb-shape.cc | 2 +- src/hb-unicode.cc | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) commit 81a31f3eff44a85bb2160d51156a01a18f0a97df Author: Behdad Esfahbod Date: Tue Jan 6 15:37:31 2015 -0800 [bindings] Make sample Python 2/3 compatible src/sample.py | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) commit b632e7997d9cb6e4782cab6d8c62e8e5edaa4cb0 Author: Behdad Esfahbod Date: Tue Jan 6 14:05:26 2015 -0800 Fix up gobject-introspection a bit Minimal shaping works now! src/hb-blob.cc | 6 +++--- src/hb-buffer.cc | 2 +- src/sample.py | 34 ++++++++++++++++++++++++++++------ 3 files changed, 32 insertions(+), 10 deletions(-) commit 3d1a666a8629a8502a2bcf23ab943e2b39a0da92 Author: Behdad Esfahbod Date: Mon Jan 5 14:43:13 2015 -0800 Remove hardcoded ICU include paths. ICU exports them using LOCAL_EXPORT_C_INCLUDE_DIRS. https://android-review.googlesource.com/#/c/121311/ Android.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 8cb41cb9508eb1bb6319e92f900cfe5e8a131be3 Merge: 365c03fc fb85d618 Author: Behdad Esfahbod Date: Sun Jan 4 20:32:18 2015 -0800 Merge pull request #76 from cpeterso/cpeterso/Wunused-function Add #ifdef HB_USE_ATEXIT to fix -Wunused-function warnings commit fb85d618f5883458bacf0ecb0894772291a2d738 Author: Chris Peterson Date: Sun Jan 4 19:31:10 2015 -0800 Add #ifdef HB_USE_ATEXIT to fix -Wunused-function warnings src/hb-common.cc | 2 +- src/hb-ft.cc | 4 +++- src/hb-shape.cc | 4 +++- src/hb-shaper.cc | 4 +++- 4 files changed, 10 insertions(+), 4 deletions(-) commit 365c03fc2bcdb4098314a0e123c46018fb882586 Merge: c36c4a99 d1897a98 Author: Behdad Esfahbod Date: Sat Jan 3 21:55:30 2015 -0800 Merge pull request #75 from cpeterso/cpeterso/Wunused-value Fix hb_atomic_ptr_cmpexch -Wunused-value warnings commit d1897a98d8da40cffb57c07099a9a93cfeaacc36 Author: Chris Peterson Date: Sat Jan 3 19:46:19 2015 -0800 Fix hb_atomic_ptr_cmpexch -Wunused-value warnings src/hb-common.cc | 2 +- src/hb-icu.cc | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) commit c36c4a9924609df648e62e47fa017b19b844fd98 Author: Behdad Esfahbod Date: Fri Jan 2 14:09:23 2015 -0800 Add missing va_end() Fixes https://github.com/behdad/harfbuzz/pull/74 util/options.cc | 1 + 1 file changed, 1 insertion(+) commit f34aaba8687a20794835e2dc878c52d1b53e6f85 Author: Behdad Esfahbod Date: Sun Dec 28 18:56:15 2014 -0800 [ft] Don't set font ppem For discussion see: http://lists.freedesktop.org/archives/harfbuzz/2012-April/001905.html Over time we have had added NO_HINTING all over the place in hb-ft. Finish it off. Not setting ppem on hb-font disables get_contour_point() calls which is good anyway. See comments in the commit. src/hb-ft.cc | 9 +++++++++ 1 file changed, 9 insertions(+) commit 350f3a02ce225e5d78db8ac96de1351ff9f96dd5 Author: Behdad Esfahbod Date: Sun Dec 28 17:44:26 2014 -0800 [ft] Add hb_ft_face_create_referenced() and hb_ft_font_create_referenced() When I originally wrote hb-ft, FreeType objects did not support reference counting. As such, hb_ft_face_create() and hb_ft_font_create() had a "destroy" callback and client was responsible for making sure FT_Face is kept around as long as the hb-font/face are alive. However, since this was not clearly documented, some clienets didn't correctly did that. In particular, some clients assumed that it's safe to destroy FT_Face and then hb_face_t. This, indeed, used to work, until 45fd9424c723f115ca98995b8f8a25185a6fc71d, which make face destroy access font tables. Now, I fixed that issue in 395b35903e052aecc97d0807e4f813c64c0d2b0b since the access was not needed, but the problem remains that not all clients handle this correctly. See: https://bugs.freedesktop.org/show_bug.cgi?id=86300 Fortunately, FT_Reference_Face() was added to FreeType in 2010, and so we can use it now. Originally I wanted to change hb_ft_face_create() and hb_ft_font_create() to reference the face if destroy==NULL was passed in. That would improve pretty much all clients, with little undesired effects. Except that FreeType itself, when compiled with HarfBuzz support, calls hb_ft_font_create() with destroy==NULL and saves the resulting hb-font on the ft-face (why does it not free it immediately?). Making hb-face reference ft-face causes a cycling reference there. At least, that's my current understanding. At any rate, a cleaner approach, even if it means all clients will need a change, is to introduce brand new API. Which this commit does. Some comments added to hb-ft.h, hoping to make future clients make better choices. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=75299 configure.ac | 4 ++-- src/hb-ft.cc | 32 ++++++++++++++++++++++++++++++++ src/hb-ft.h | 59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 92 insertions(+), 3 deletions(-) commit 9a3b74884b2e41c7040611030f4336f13d18fd3e Author: Behdad Esfahbod Date: Sun Dec 28 17:27:39 2014 -0800 Remove redundant check for FT_Face_GetCharVariantIndex We require FreeType >= 2.8.3. This symbol was introduced earlier than that. configure.ac | 9 +-------- src/hb-ft.cc | 2 -- 2 files changed, 1 insertion(+), 10 deletions(-) commit 1226b2e930aa456cc05bbe621c96f4286a95cff6 Author: Behdad Esfahbod Date: Sun Dec 28 17:04:23 2014 -0800 Fix FreeType version check configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit affacf2f37db767ab8df7f2db6cd9e0e9b0a2b8a Author: Behdad Esfahbod Date: Sun Dec 28 16:20:31 2014 -0800 [ft] Open blob in READONLY mode HB_MEMORY_MODE_READONLY_MAY_MAKE_WRITABLE is deprecated and fairly useless now. src/hb-ft.cc | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) commit 395b35903e052aecc97d0807e4f813c64c0d2b0b Author: Behdad Esfahbod Date: Sun Dec 28 16:03:26 2014 -0800 Avoid accessing layout tables at face destruction "Fixes" https://bugs.freedesktop.org/show_bug.cgi?id=86300 Based on discussion someone else who had a similar issue, most probably the user is releasing FT_Face before destructing hb_face_t / hb_font_t. While that's a client bug, and while we can (and should) use FreeType refcounting to help avoid that, it happens that we were accessing the table when we didn't really have to. Avoid that. src/hb-ot-layout-private.hh | 3 +-- src/hb-ot-layout.cc | 4 ++-- src/hb-ot-shape-complex-arabic-fallback.hh | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) commit 7d5e7613ced3dd39d05df83ca7e8952cbecd68f6 Author: Behdad Esfahbod Date: Thu Dec 18 18:22:21 2014 -0800 Fail blob creation if length overflows or is too large Fail if blob start plus length overflows; or if blob length is greater than 2GB. It takes a while for fonts to get to that size. In the mean time, it protects against bugs like this: http://www.icu-project.org/trac/ticket/11450 Also avoids some weird issues with 32bit vs 64bit systems as we accept length as unsigned int. As such, a length of -1 will cause overflow on 32bit machines, but happily accepted on a 64bit machine. Avoid that. src/hb-blob.cc | 5 ++++- test/api/test-blob.c | 3 +++ 2 files changed, 7 insertions(+), 1 deletion(-) commit d5a5052098b0aa79ff55c235e61a9db477c4120f Author: Behdad Esfahbod Date: Thu Dec 18 18:09:41 2014 -0800 Assert that blob length doesn't overflow address. This will crash now, if blob was created with wrong length. Check for that coming next commit. src/hb-open-type-private.hh | 1 + 1 file changed, 1 insertion(+) commit 66e37409b3bc1eddc86704ae26d9176677ce6aa6 Author: Behdad Esfahbod Date: Wed Dec 17 12:09:17 2014 -0800 0.9.37 NEWS | 8 ++++++++ configure.ac | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) commit 093c520de506aec74f3fb1e195c0ca85813424dd Author: Behdad Esfahbod Date: Fri Dec 12 21:07:53 2014 -0800 [otlayout] Mark variables that are C arrays as opposed to OT::ArrayOf src/hb-ot-layout-gpos-table.hh | 24 +++++++-------- src/hb-ot-layout-gsubgpos-private.hh | 60 ++++++++++++++++++------------------ 2 files changed, 42 insertions(+), 42 deletions(-) commit 9df0a520306a491f973d42965597bfda6023e508 Author: Behdad Esfahbod Date: Fri Dec 12 20:54:28 2014 -0800 [otlayout] Avoid invalid access with Context format 3 src/hb-ot-layout-gsubgpos-private.hh | 2 ++ 1 file changed, 2 insertions(+) commit 295ef1dd5229f47d8e0eb5b4eb48c90a6b470073 Author: Behdad Esfahbod Date: Fri Dec 12 20:43:18 2014 -0800 [ot] Debug get_coverage src/hb-ot-layout-gsubgpos-private.hh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 00f6a8e334ec4c586e4e633a95b411ccb50306d3 Author: Behdad Esfahbod Date: Fri Dec 12 20:36:49 2014 -0800 [ot] Print format in dispatch trace src/hb-ot-layout-gpos-table.hh | 16 ++++++++-------- src/hb-ot-layout-gsub-table.hh | 14 +++++++------- src/hb-ot-layout-gsubgpos-private.hh | 8 ++++---- 3 files changed, 19 insertions(+), 19 deletions(-) commit 5c7d6f02d71362c2b192a7d96e6181977682921c Author: Behdad Esfahbod Date: Fri Dec 12 20:28:49 2014 -0800 Minor src/hb-private.hh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 153beebba9b76901b8b62b90ba0dc69462ae2090 Author: Behdad Esfahbod Date: Fri Dec 12 19:46:09 2014 -0800 [ot] Make sure all toplevel tables have tableTag src/hb-open-file-private.hh | 2 ++ src/hb-ot-hhea-table.hh | 2 ++ src/hb-ot-hmtx-table.hh | 2 ++ 3 files changed, 6 insertions(+) commit 282b13f9b4d86b091714de7fbddc94b3e3ff3d91 Author: Behdad Esfahbod Date: Fri Dec 12 19:32:46 2014 -0800 [sanitize] Improve debug output some more src/hb-open-type-private.hh | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) commit 0766ee1f4e6046598a2e8fb1b167c3942b4a87a0 Author: Behdad Esfahbod Date: Fri Dec 12 18:23:20 2014 -0800 [sanitize] Improve debug output src/hb-open-type-private.hh | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) commit e6f80fa1044243898c402ec6a59d6c1b5420be53 Author: Behdad Esfahbod Date: Wed Dec 10 12:05:24 2014 -0800 [indic] Allow ZWJ/ZWNJ before SM In Oriya, a ZWJ/ZWNJ might be added before candrabindu to encourage or stop ligation of the candrabindu. This is clearly specified in the Unicode section on Oriya. Allow it there. Note that Uniscribe doesn't allow this. Micro tests added using Noto Sans Oriya draft. No changes in numbers. Currently at: BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%) DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%) GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%) GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%) KANNADA: 951190 out of 951913 tests passed. 723 failed (0.0759523%) KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%) MALAYALAM: 1048147 out of 1048334 tests passed. 187 failed (0.0178378%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) src/hb-ot-shape-complex-indic-machine.rl | 2 +- test/shaping/Makefile.am | 1 + .../sha1sum/5028afb650b1bb718ed2131e872fbcce57828fff.ttf | Bin 0 -> 4720 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 + test/shaping/tests/MANIFEST | 1 + test/shaping/tests/indic-joiner-candrabindu.tests | 2 ++ 6 files changed, 6 insertions(+), 1 deletion(-) commit c0e95abc5f3f14121483b71f10837828a3a1d73a Author: Behdad Esfahbod Date: Thu Nov 20 14:42:24 2014 -0800 0.9.36 NEWS | 12 ++++++++++++ configure.ac | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) commit fde3e4a423871463c883cb969e99c29cb6f69f6b Author: Behdad Esfahbod Date: Wed Oct 29 11:23:08 2014 -0700 In hb_ot_collect_glyphs(), don't recurse to a lookup more than once Otherwise, we might process a lookup thousands of times, with no benefit. This pathological case was hit by Noto Nastaliq Urdu Draft in Firefox's code to determine whether space glyph is involved in any GSUB/GPOS rules. A test page is at http://behdad.org/urdu See: https://bugzilla.mozilla.org/show_bug.cgi?id=1090869 src/hb-ot-layout-gsubgpos-private.hh | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) commit 5a5640d8506ccfc99fd119e89e829170d1fea421 Author: Behdad Esfahbod Date: Tue Oct 14 21:26:13 2014 -0700 Move code around src/hb-open-type-private.hh | 50 ++++++++++++++++++++++----------------------- 1 file changed, 25 insertions(+), 25 deletions(-) commit 666b42f73bd1f516657b206ef738108825bf239f Author: Behdad Esfahbod Date: Tue Oct 14 21:24:59 2014 -0700 Move macros around Fixes https://bugs.freedesktop.org/show_bug.cgi?id=84491 src/hb-open-type-private.hh | 63 ++++++++++++++++++++++++++++++++++++++------- src/hb-private.hh | 41 ----------------------------- src/hb-uniscribe.cc | 6 +++++ 3 files changed, 60 insertions(+), 50 deletions(-) commit 5c87120b8178566ddae99d9825edc24f9b87ea3d Author: Behdad Esfahbod Date: Tue Oct 14 20:07:31 2014 -0700 Fix misc warnings Fixes https://github.com/behdad/harfbuzz/pull/51 src/hb-buffer-deserialize-json.rl | 4 ++-- src/hb-ot-layout-gsub-table.hh | 2 +- src/hb-private.hh | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) commit a1f27ac3c48cfe6d532dc422cf256952fea472ed Author: Behdad Esfahbod Date: Thu Oct 2 16:54:33 2014 -0400 Update test expectation for previous commit test/shaping/tests/arabic-fallback-shaping.tests | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8afaf096870d7895cf2fffb6438b02c0ad1b6c52 Author: Behdad Esfahbod Date: Thu Oct 2 16:40:41 2014 -0400 [ft] Add NO_HINTING in a couple other places src/hb-ft.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 7228011411f0e490ad1ba9894dd0d576823903ea Author: Behdad Esfahbod Date: Wed Oct 1 18:58:43 2014 -0400 [travis] Fix clang again .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 406a020e5228d4a04da6282f5a75165bab7a483e Author: Behdad Esfahbod Date: Wed Oct 1 18:54:55 2014 -0400 [travis] Fail build if coveralls fails .travis.yml | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) commit a8aa20260dbd9af9cbcc7d545fa8b41b07aae276 Author: Behdad Esfahbod Date: Wed Oct 1 18:48:40 2014 -0400 [travis] Only run coveralls under gcc .travis.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 5de0407337d630117e424b7c715b7cbd432f4ef9 Author: Behdad Esfahbod Date: Wed Oct 1 18:18:25 2014 -0400 Help clang with gcov src/check-defs.sh | 2 +- src/check-symbols.sh | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) commit ef40ca8e5e830231539dc61088b58e907a840629 Author: Behdad Esfahbod Date: Wed Oct 1 18:07:27 2014 -0400 [travis] Try to make coverage work with clang .travis.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) commit 52784da17b7278f2587168234878bb15d918c9fe Author: Behdad Esfahbod Date: Wed Oct 1 17:57:43 2014 -0400 [travis] Minor README | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit f2c9005f5123c7f9b227fd9ac9a3438c5fe4cf47 Author: Behdad Esfahbod Date: Wed Oct 1 17:45:17 2014 -0400 Add README.md symlink to make github happy README.md | 1 + 1 file changed, 1 insertion(+) commit 40987e8aaca4155d9cff211549e8d23f24c334e5 Author: Behdad Esfahbod Date: Wed Oct 1 17:44:30 2014 -0400 [travis] Re-enable clang .travis.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) commit 5400ac476e5a5bcc66559fcfb05a683a6b433ea1 Author: Behdad Esfahbod Date: Wed Oct 1 17:41:41 2014 -0400 Add build and coverage status links README | 3 +++ 1 file changed, 3 insertions(+) commit 19360e0a5609c65842a989587b01a4dc7c9eae36 Author: Behdad Esfahbod Date: Wed Oct 1 17:35:03 2014 -0400 [travis] Report matrix settings to help debugging .travis.yml | 6 ++++++ 1 file changed, 6 insertions(+) commit 9b89fc52f49b80df1f27ac7de69e0152bdcc94d6 Author: Behdad Esfahbod Date: Wed Oct 1 17:20:31 2014 -0400 [travis] More coveralls .travis.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit a68f2b62c1f24009993911b1dbcb76b821e58c51 Author: Behdad Esfahbod Date: Wed Oct 1 17:05:58 2014 -0400 [travis] Give coveralls a hand .travis.yml | 1 + 1 file changed, 1 insertion(+) commit 5194d647e13aa5ba2cfcdbdcd4a659dc5bd11418 Author: Behdad Esfahbod Date: Wed Oct 1 17:03:26 2014 -0400 [travis] Disable clang for now .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 715f27f85f97fee13b119f60037db5c139489ee6 Author: Behdad Esfahbod Date: Wed Oct 1 16:53:00 2014 -0400 [test] Fixup test test/shaping/tests/hangul-jamo.tests | 9 --------- 1 file changed, 9 deletions(-) commit 2a508ddae5de3852243725ce22caa3dcffccb83e Author: Behdad Esfahbod Date: Wed Oct 1 16:49:22 2014 -0400 [travis] Another try at coveralls.io .travis.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit dfe8078e5be46cab5e67aed977749c1d6725e6a7 Author: Behdad Esfahbod Date: Wed Oct 1 16:38:47 2014 -0400 [travis] First try to hookup coveralls.io code coverage tracking .travis.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 1b387571e4d0eed883f1ae8ec85cf0e818b4a7f9 Author: Behdad Esfahbod Date: Wed Oct 1 16:14:59 2014 -0400 [travis] Unbreak .travis.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) commit e281ed360dfdf803aea87b6078983867d08e07a7 Author: Behdad Esfahbod Date: Wed Oct 1 16:09:08 2014 -0400 [travis] Minor .travis.yml | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) commit c0b82ba32a1987902a3b9c05b46f8be6b121883a Author: Behdad Esfahbod Date: Wed Oct 1 14:24:07 2014 -0400 Create ragel-generated files in srcdir src/Makefile.am | 25 ++++++++++--------------- 1 file changed, 10 insertions(+), 15 deletions(-) commit 79bbb10b0da49ace763a50f259c2ea687143f7ea Author: Behdad Esfahbod Date: Wed Oct 1 13:33:21 2014 -0400 Clean ragel-generated headers in maintainercleanfiles src/Makefile.am | 7 +++++++ 1 file changed, 7 insertions(+) commit 8971cac83eb4f06847abfa3eaa15857d27141810 Author: Behdad Esfahbod Date: Wed Oct 1 12:41:03 2014 -0400 Don't use tmp files in Makefile Useful for code-coverage generation of the ragel-generated files as they will now contain the correct .hh filename in them. src/Makefile.am | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) commit 22723186652224a635f1dad5cda0f753e78c301d Author: Behdad Esfahbod Date: Wed Oct 1 11:56:07 2014 -0400 check-static-inits: Filter out zero-length sections When compiling with -O0, zero-sized constructors were showing up and confusing the test. src/check-static-inits.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b695a3dc2300ed970a4154ad8b997407b3cb4faf Author: Behdad Esfahbod Date: Wed Oct 1 11:55:14 2014 -0400 check-static-inits: check for static finalizers src/check-static-inits.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 250398b1e4f102e4e44eeb9e2aebf0cd2d397344 Author: Behdad Esfahbod Date: Wed Oct 1 11:28:01 2014 -0400 Hide other bubble-sort src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c1e87442621beff98791ce56cfd1ccee506c4ee6 Author: Behdad Esfahbod Date: Wed Oct 1 11:07:08 2014 -0400 Hide bubble-sort! src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 80f77282264afb1356351024b1f062b2824bba3b Author: Behdad Esfahbod Date: Thu Sep 25 17:59:46 2014 +0300 [util] Fix ansi output when surface is empty util/helper-cairo-ansi.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 156852991e18e5ac256ee4d6b2916931cc274977 Author: Behdad Esfahbod Date: Thu Sep 25 17:45:49 2014 +0300 [ot-font] Add hb_ot_face_cmap_accelerator_t src/hb-ot-font.cc | 113 +++++++++++++++++++++++++++++++----------------------- 1 file changed, 66 insertions(+), 47 deletions(-) commit d088ccaf11d9475fe0d269ce130b1793b8a1ffbf Author: Behdad Esfahbod Date: Thu Sep 25 17:26:56 2014 +0300 [ot-font] Minor src/hb-ot-font.cc | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) commit d7c160a1530adabbcf33725b105072293115a34c Author: Behdad Esfahbod Date: Thu Sep 25 17:15:35 2014 +0300 [ot-font] Handle missing vertical metrics tables src/hb-ot-font.cc | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) commit be1cca270257bfdfee3fbe821175269713acf408 Author: Behdad Esfahbod Date: Thu Sep 25 16:53:24 2014 +0300 [ot-font] Add metrics_accel_t src/hb-ot-font.cc | 111 ++++++++++++++++++++++-------------------------- src/hb-ot-hhea-table.hh | 2 +- src/hb-ot-hmtx-table.hh | 4 +- 3 files changed, 54 insertions(+), 63 deletions(-) commit d41b809e9d21e655129a97c600d28f278fd7e62c Author: Behdad Esfahbod Date: Thu Sep 25 13:04:08 2014 +0300 [ot-font] Start adding vertical support src/hb-ot-font.cc | 57 ++++++++++++++++++++++++++++++++++---------- src/hb-ot-hhea-table.hh | 63 ++++++++++++++++++++++++++----------------------- src/hb-ot-hmtx-table.hh | 35 +++++++++++++++++---------- 3 files changed, 100 insertions(+), 55 deletions(-) commit 22f0de5025aeeef4c8b3ca876d291d4c8e558d94 Author: Behdad Esfahbod Date: Mon Aug 25 12:54:57 2014 -0400 Fix build src/hb-ot-shape-complex-arabic-win1256.hh | 3 +++ 1 file changed, 3 insertions(+) commit d457e3f0ff9b27616a34e4cc110d3edbf8796841 Author: Behdad Esfahbod Date: Mon Aug 25 12:31:19 2014 -0400 [arabic] Don't #include __FILE__ Fine! https://code.google.com/p/chromium/issues/detail?id=406957 src/hb-ot-shape-complex-arabic-win1256.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9ceb673d9c35bb28c9b2ed5359bdd8b23fda0019 Author: Behdad Esfahbod Date: Mon Aug 25 11:48:12 2014 -0400 [arabic] Allow disabling win1256 fallback code By defining HB_NO_WIN1256. src/hb-ot-shape-complex-arabic-fallback.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8a9319502141c09695461c386e54f998250420e9 Author: Behdad Esfahbod Date: Fri Aug 22 12:06:57 2014 -0400 [ot] Prefer Windows platform cmap tables / accept all Unicode encodingIDs Some fonts on the Mac ship with (0,1). src/hb-ot-font.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) commit 270971a0fccdf4964fd3e8ab8e5cf53037a3518d Author: Behdad Esfahbod Date: Fri Aug 15 14:28:04 2014 -0400 [win32] Avoid preprocessor warnings re macros src/hb-private.hh | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit 8c6bd34d38fb3007c3d660fce0095cc5c7e9962e Author: Behdad Esfahbod Date: Thu Aug 14 13:33:37 2014 -0400 Fix check-symbols on OS X src/check-libstdc++.sh | 14 +++++++------- src/check-symbols.sh | 8 +++++++- 2 files changed, 14 insertions(+), 8 deletions(-) commit 522b1cc5261c1419166bfb90d2ff634b684be66a Author: Behdad Esfahbod Date: Thu Aug 14 13:29:30 2014 -0400 [coretext] Hide feature_mappings src/hb-coretext.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0d2c2f238bf0a847ecd55a70cc0f081f18a053ac Author: Behdad Esfahbod Date: Thu Aug 14 13:25:55 2014 -0400 Simplify hb-object src/hb-object-private.hh | 118 +++++++++++++++-------------------------------- 1 file changed, 36 insertions(+), 82 deletions(-) commit 9d861b81f349188a4507350398786a6e94038095 Author: Behdad Esfahbod Date: Thu Aug 14 13:15:21 2014 -0400 Really fix clang build this time src/hb-object-private.hh | 141 +++++++++++++++++++++++------------------------ 1 file changed, 68 insertions(+), 73 deletions(-) commit 272226f294382b0c6921b36e0e67fc53daa765d3 Author: Behdad Esfahbod Date: Thu Aug 14 13:11:33 2014 -0400 Revert "Fix build on clang after previous commit" This reverts commit 9c80cbc87f23040a334e30c750f64523d9ef10c8. src/hb-object-private.hh | 34 +++++++++++++--------------------- 1 file changed, 13 insertions(+), 21 deletions(-) commit 9c80cbc87f23040a334e30c750f64523d9ef10c8 Author: Behdad Esfahbod Date: Thu Aug 14 13:09:52 2014 -0400 Fix build on clang after previous commit src/hb-object-private.hh | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-) commit a5a27073cfff91c4f80209ca8462543130af61dd Author: Behdad Esfahbod Date: Thu Aug 14 13:05:36 2014 -0400 Rewrite this==NULL checks to avoid undefined behavior Fixes https://code.google.com/p/chromium/issues/detail?id=403594 src/hb-object-private.hh | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) commit cc3b2d432b02f9381cdf19e2dd5fbbdd002a750c Author: Behdad Esfahbod Date: Thu Aug 14 12:59:16 2014 -0400 Remove this==NULL check from face->reference_table() Not supposed to happen, and apparently this is undefined in C++. https://code.google.com/p/chromium/issues/detail?id=403594 src/hb-face-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cd7ea4f791dc41d62ad238673e2ea0107883c9e3 Author: Behdad Esfahbod Date: Thu Aug 14 12:57:02 2014 -0400 Make hb_object_t members private In preparation for fixing: https://code.google.com/p/chromium/issues/detail?id=403594 src/hb-object-private.hh | 26 +++++++++++++++++++++----- src/hb-set-private.hh | 2 +- 2 files changed, 22 insertions(+), 6 deletions(-) commit c4308f895aef93ed884fd54e4ebc65b6d2cfc94a Author: Behdad Esfahbod Date: Wed Aug 13 19:42:01 2014 -0400 Minor test/shaping/hb_test_tools.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cd5a1149d980dc3c17b6bb9d961c761b2671ba1b Author: Behdad Esfahbod Date: Wed Aug 13 12:39:34 2014 -0400 0.9.35 NEWS | 29 +++++++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 30 insertions(+), 1 deletion(-) commit 20076cc41e673c31305fcb58d37b3b292fd35f83 Author: Behdad Esfahbod Date: Tue Aug 12 19:26:35 2014 -0400 [coretext] Add version guards for kCTLanguageAttributeName src/hb-coretext.cc | 7 +++++++ 1 file changed, 7 insertions(+) commit 1b3011c27df531875d432e909ae6b77f115c5017 Author: Behdad Esfahbod Date: Tue Aug 12 19:17:19 2014 -0400 [coretext] Pass buffer language to CoreText src/hb-coretext.cc | 12 ++++++++++++ 1 file changed, 12 insertions(+) commit 3eb6a4dbf25b11fce5e0e426e89f7457887aeca0 Author: Behdad Esfahbod Date: Tue Aug 12 19:10:33 2014 -0400 [coretext] Minor src/hb-coretext.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) commit 08acfe0d3a1d8223a9fa0696703fff63d6c2ea8b Author: Behdad Esfahbod Date: Tue Aug 12 18:57:08 2014 -0400 [hb-coretext] Fix cluster order of notdef runs in RTL text src/hb-coretext.cc | 3 +++ 1 file changed, 3 insertions(+) commit 30eed75de24ac0b6648a72d98d10bb24a563d7ef Author: Behdad Esfahbod Date: Tue Aug 12 17:15:09 2014 -0400 [shape-plan] Fix typo! The only effect is, if shaper_list was not NULL and no shaper was found, we now don't insert anything into cache and return earlier. src/hb-shape-plan.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dc9aba6fc53898acd7281b118cec0355d61b1df2 Author: Behdad Esfahbod Date: Tue Aug 12 17:14:36 2014 -0400 [shape-plan] Better debug messages src/hb-shape-plan.cc | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) commit e956c65bf724a8403471362288d2361361b6ac58 Author: Behdad Esfahbod Date: Tue Aug 12 17:03:27 2014 -0400 [shape-plan] Simplify macro src/hb-shape-plan.cc | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) commit 29e25550ce8fee3fecc42d20a45ce9c212dc59df Author: Behdad Esfahbod Date: Tue Aug 12 17:02:59 2014 -0400 Fix gcc warning src/hb-private.hh | 9 +++++++++ 1 file changed, 9 insertions(+) commit 8d5eebc0c6ada01128c6ee384340efdbef7ba29d Author: Behdad Esfahbod Date: Tue Aug 12 16:50:22 2014 -0400 [shape-plan] Fix shape-plan caching with more than one requested shaper Wasn't breaking out of loop, ouch! http://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1246370.html src/hb-shape-plan.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit bc3d0dc60104f1cda465a5e8ba5b40ed5bec70b9 Author: Behdad Esfahbod Date: Tue Aug 12 16:49:18 2014 -0400 [shape-plan] Add debug tracing src/hb-shape-plan.cc | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) commit 81b8d9777b9c38c7e6408591763a4cac6de18e4b Author: Behdad Esfahbod Date: Tue Aug 12 15:49:47 2014 -0400 [coretext] Fix buffer resizing Was very broken. Now fixed and tested. src/hb-coretext.cc | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) commit c3e924fb9e0e2d4003790817655efd9c5688c7e1 Author: Behdad Esfahbod Date: Tue Aug 12 14:25:11 2014 -0400 [coretext] Rewind scratch-allocated arrays when not needed anymore src/hb-coretext.cc | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) commit 8fd4d70b1450d7261a35ab3dea1c70baea2e5c99 Author: Behdad Esfahbod Date: Tue Aug 12 13:12:31 2014 -0400 [wince] Two more Windows CE fixes Report has it that it builds (and works) now: https://codereview.qt-project.org/#/c/92087/ src/hb-mutex-private.hh | 2 +- src/hb-private.hh | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) commit fd0001d7dbe6ede99a9f87f96f231ffb53303be8 Author: Behdad Esfahbod Date: Tue Aug 12 10:32:41 2014 -0400 [coretext] Compare CGFont and PS name, if CTFont didn't match See comments. Fixes vertical text. CoreText backend is in very good shape now! Also see: 5a0eed3b50629be4826e4e9428f2c3255195395d 25f4fb9b56bb3f8bec821571c78f8829e40daa54 Fixes http://github.com/behdad/harfbuzz/pull/36 src/hb-coretext.cc | 54 ++++++++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 48 insertions(+), 6 deletions(-) commit 5a0eed3b50629be4826e4e9428f2c3255195395d Author: Behdad Esfahbod Date: Mon Aug 11 23:47:16 2014 -0400 [coretext] Implement vertical shaping Currently doesn't work though, we detect font fallback. Apparently matching on ct_font is not safe for this. Looks like commit 25f4fb9b56bb3f8bec821571c78f8829e40daa54 wasn't enough after all. src/hb-coretext.cc | 127 ++++++++++++++++++++++++++++++++++------------------- 1 file changed, 81 insertions(+), 46 deletions(-) commit 1b55077f03758e49f93b8bc1de678e96ea58718c Author: Behdad Esfahbod Date: Mon Aug 11 20:45:12 2014 -0400 [coretext] Remove unnecessary alt_size Wasn't needed after a6b8dc87421de33746b0b14d86d2d1532aec02af. src/hb-coretext.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 10b1104d791a0b0103c6bbb083b5819f2b7d328d Author: Behdad Esfahbod Date: Mon Aug 11 20:02:45 2014 -0400 [coretext] Use CFRunStatus Assert that all runs had expected direction, and take hint for non-monotone clusters. src/hb-coretext.cc | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) commit fd1a6aa8d029c701b1532efa59ce901109cfc216 Author: Behdad Esfahbod Date: Mon Aug 11 20:01:37 2014 -0400 [coretext] Minor src/hb-coretext.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 130856c705641aa681307b5b51b5fb84e295f382 Author: Behdad Esfahbod Date: Mon Aug 11 19:16:26 2014 -0400 [coretext] Remove debug printf! src/hb-coretext.cc | 1 - 1 file changed, 1 deletion(-) commit b5fbc3b8f560235d014c62e49220574ffcf89349 Author: Behdad Esfahbod Date: Mon Aug 11 18:40:01 2014 -0400 API: Do not clear buffer-flags in hb_buffer_clear_contents() After 763e5466c0a03a7c27020e1e2598e488612529a7, one doesn't need to set flags for different pieces of text. The flags now are something the client sets up once, depending on how it actually uses the buffer. As such, don't clear it in clear_contents(). Tests updated. src/hb-buffer-private.hh | 4 +--- src/hb-buffer.cc | 4 ++-- test/api/test-buffer.c | 15 ++++++++++++--- 3 files changed, 15 insertions(+), 8 deletions(-) commit 104484cefeca03d95837bba5f39178693c86ce8a Author: Behdad Esfahbod Date: Mon Aug 11 18:23:43 2014 -0400 Minor src/hb-common.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 4acce77db7dd588ba277779c4997b0256ebe426e Author: Behdad Esfahbod Date: Mon Aug 11 17:46:50 2014 -0400 [coretext] Pass buffer direction to CoreText Have to use a CTTypesetter for this. src/hb-coretext.cc | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) commit 5ec45dd37caa8a87ce2689a66272ba8a343fe6ba Author: Behdad Esfahbod Date: Mon Aug 11 17:46:12 2014 -0400 [coretext] Minor It's hard to handle all possible NULL returns from CoreText. Add one more... src/hb-coretext.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 624a299b829ccf9864dd2f3001b1a49476e96b4a Author: Behdad Esfahbod Date: Mon Aug 11 15:29:18 2014 -0400 [coretext] Attach marks to base clusters Fixes https://githu.com/behdad/harfbuzz/issues/49 to the extent that it can be fixed. src/hb-coretext.cc | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) commit 3c41ccb5358b0be6cc68d49f436d2cb1792cd5e5 Author: Behdad Esfahbod Date: Mon Aug 11 15:11:59 2014 -0400 [coretext] Use input clusters Before, this shaper was returning UTF-16 cluster indices instead of returning whatever cluster values the user had had set up in the buffer. Ouch! src/hb-coretext.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) commit a6b8dc87421de33746b0b14d86d2d1532aec02af Author: Behdad Esfahbod Date: Mon Aug 11 15:08:19 2014 -0400 [coretext] Fix buffer resize handling We can't really resize buffer and continue in this shaper as we are using the scratch buffer for string_ref and log_cluster. Restructure shaper to retry from (almost) scratch. src/hb-buffer-private.hh | 3 + src/hb-coretext.cc | 428 ++++++++++++++++++++++++++--------------------- 2 files changed, 238 insertions(+), 193 deletions(-) commit 9b3c60c88b118f01610ae7a608b138f79f2dc7be Author: Behdad Esfahbod Date: Mon Aug 11 13:25:43 2014 -0400 [coretext] Always compute log_clusters To be used soon. src/hb-coretext.cc | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) commit 15c633dd1f412f9ef839d80a8f7af35e7ea48fbc Author: Behdad Esfahbod Date: Mon Aug 11 13:42:42 2014 -0400 Minor src/hb-graphite2.cc | 4 ++-- src/hb-uniscribe.cc | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) commit 9ce067c77524a9ffc77ceabcba5e7dab36fd39de Author: Behdad Esfahbod Date: Mon Aug 11 02:04:38 2014 -0400 [coretext] Simplify cluster mapping src/hb-coretext.cc | 41 +++++++++++++++++------------------------ 1 file changed, 17 insertions(+), 24 deletions(-) commit 49f7fb63761e4ca9936990fb90a77fd3600f5ad2 Author: Behdad Esfahbod Date: Sun Aug 10 19:19:38 2014 -0400 [coretext] Minor src/hb-coretext.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 25f4fb9b56bb3f8bec821571c78f8829e40daa54 Author: Behdad Esfahbod Date: Sun Aug 10 19:05:25 2014 -0400 [coretext] Fix fallback detection Fixes http://github.com/behdad/harfbuzz/pull/36 src/hb-coretext.cc | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) commit 77a7a53acef7de355116d488e7d64ff1d7e9e9e1 Author: Behdad Esfahbod Date: Sun Aug 10 18:59:47 2014 -0400 [coretext] Fix last range Test with: hb-view /Library/Fonts/Zapfino.ttf ZapfinoZapfino --features=-dlig[7:] --shaper=coretext src/hb-coretext.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c2b151d95262a8dc2d2ce94e19ab0ef5b0c8f98d Author: Behdad Esfahbod Date: Sun Aug 10 18:52:07 2014 -0400 Fix hb_in_range() for types smaller than int As exercised by hb-coretext .notdef code. src/hb-private.hh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 26a963b9cb4af3119177f277a2d48a5d537458fb Author: Behdad Esfahbod Date: Sun Aug 10 18:04:50 2014 -0400 [wince] Try to fix some stuff on Windows CE Based on errors seen here: http://testresults.qt-project.org/ci/QtBase_dev_Integration/build_03837/wince70embedded-armv4i-msvc2008_Windows_7/log.txt.gz Fully untested. src/hb-private.hh | 8 ++++++++ 1 file changed, 8 insertions(+) commit 92aeee3f040c2c32cbf70b27bd6954535388c870 Author: Behdad Esfahbod Date: Sun Aug 10 17:42:19 2014 -0400 Minor src/hb-coretext.cc | 4 ++-- src/hb-uniscribe.cc | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) commit b9993d8d6d332994dfbd29e99ff8043622003417 Author: Behdad Esfahbod Date: Sun Aug 10 17:40:24 2014 -0400 [coretext] Fix assert on Yosemite Apparently those functions documented as sometimes returning NULL actually exercise that right in OS X 10.10 Yosemite. The scratch was too small for that. I *think* I fixed it, but haven't tested as I don't have Yosemite. src/hb-coretext.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 087733dd66e17297ef0e53680fafe42c84884104 Author: Behdad Esfahbod Date: Fri Apr 18 11:21:08 2014 -0700 [coretext] Use CGFont as face_data src/hb-coretext.cc | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) commit d277c3d7eee1fd4fb41c38255e5c4df539353e89 Author: Behdad Esfahbod Date: Thu Aug 7 15:38:52 2014 -0400 [arabic] Bug 82306 - Mandaic had errors in its Unicode Joining_Type Fixes https://bugs.freedesktop.org/show_bug.cgi?id=82306 src/hb-ot-shape-complex-arabic-table.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 38fb30d7420a4b01f99cee31baa8c3990a1d1c5f Author: Behdad Esfahbod Date: Wed Aug 6 13:34:49 2014 -0400 Use atexit() only if it's safe to call from shared library Apparently they are not (advertised as?) safe on BSD systems. We ignore the case of static libraries. Whitelisted on glibc, Android, and MSVC / mingw. https://bugs.freedesktop.org/show_bug.cgi?id=82246 src/hb-common.cc | 4 ++-- src/hb-ft.cc | 2 +- src/hb-private.hh | 25 +++++++++++++++++++++++++ src/hb-shape.cc | 2 +- src/hb-shaper.cc | 2 +- src/hb-uniscribe.cc | 2 +- 6 files changed, 31 insertions(+), 6 deletions(-) commit d5e61470fa8e5046c35a79988e00e012ae4fff0f Author: Behdad Esfahbod Date: Tue Aug 5 14:19:01 2014 -0400 [arabic] Fix fallback shaping regression Was broken in 615d00ea252739da57edbd980ff27e573. Fixes https://github.com/behdad/harfbuzz/pull/48 Micro-test added. src/hb-ot-shape-complex-arabic.cc | 4 ++-- test/shaping/Makefile.am | 1 + test/shaping/fonts/sha1sum/MANIFEST | 1 + .../sha1sum/df768b9c257e0c9c35786c47cae15c46571d56be.ttf | Bin 0 -> 6332 bytes test/shaping/tests/MANIFEST | 1 + test/shaping/tests/arabic-fallback-shaping.tests | 1 + 6 files changed, 6 insertions(+), 2 deletions(-) commit 91c2c0fd2b0f660d79744b3dfaf39ab86883e96b Author: Behdad Esfahbod Date: Sat Aug 2 19:24:55 2014 -0400 0.9.34 NEWS | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 54 insertions(+), 1 deletion(-) commit d7c850f8037d2701366008eb8c2a527c9d40abde Author: Behdad Esfahbod Date: Sat Aug 2 17:46:38 2014 -0400 [uniscribe] Minor src/hb-uniscribe.cc | 1 + 1 file changed, 1 insertion(+) commit 8f3eebf7ee4005f9a8efaafcb7f4058cc0a3756e Author: Behdad Esfahbod Date: Sat Aug 2 17:18:46 2014 -0400 Make sure gsubgpos buffer vars are available during fallback_position Add buffer var allocation asserts to a few key places. src/hb-ot-layout-gpos-table.hh | 4 ++-- src/hb-ot-layout-gsub-table.hh | 2 +- src/hb-ot-layout-private.hh | 15 +++++++++++++++ src/hb-ot-shape-complex-arabic-fallback.hh | 2 +- src/hb-ot-shape-fallback.cc | 2 ++ src/hb-ot-shape-normalize.cc | 2 ++ src/hb-ot-shape.cc | 3 +++ 7 files changed, 26 insertions(+), 4 deletions(-) commit 2053f369f84676f197ac41ea654a318c48922abd Author: Behdad Esfahbod Date: Sat Aug 2 16:31:16 2014 -0400 Disable 'liga' for vertical text The reason we turned it on is because Kazuraki uses it. But that's not reason enough. Until the OpenType spec gets its act together re adding design-direction to lookups, this is better user experience. src/hb-ot-shape.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 763e5466c0a03a7c27020e1e2598e488612529a7 Author: Behdad Esfahbod Date: Sat Aug 2 16:17:44 2014 -0400 Make it easier to use HB_BUFFER_FLAG_BOT/EOT Previously, we expected users to provide BOT/EOT flags when the text *segment* was at paragraph boundaries. This meant that for clients that provide full paragraph to HarfBuzz (eg. Pango), they had code like this: hb_buffer_set_flags (hb_buffer, (item_offset == 0 ? HB_BUFFER_FLAG_BOT : 0) | (item_offset + item_length == paragraph_length ? HB_BUFFER_FLAG_EOT : 0)); hb_buffer_add_utf8 (hb_buffer, paragraph_text, paragraph_length, item_offset, item_length); After this change such clients can simply say: hb_buffer_set_flags (hb_buffer, HB_BUFFER_FLAG_BOT | HB_BUFFER_FLAG_EOT); hb_buffer_add_utf8 (hb_buffer, paragraph_text, paragraph_length, item_offset, item_length); Ie, HarfBuzz itself checks whether the segment is at the beginning/end of the paragraph. Clients that only pass item-at-a-time to HarfBuzz continue not setting any flags whatsoever. Another way to put it is: if there's pre-context text in the buffer, HarfBuzz ignores the BOT flag. If there's post-context, it ignores EOT flag. src/hb-ot-shape-complex-arabic.cc | 40 +++++++++++++++++++-------------------- src/hb-ot-shape.cc | 1 + 2 files changed, 20 insertions(+), 21 deletions(-) commit 0a5ae9336231c4d189e1682e4fd9c9c4552b8bbf Merge: ac53443f 6ab6be32 Author: Behdad Esfahbod Date: Sat Aug 2 15:00:34 2014 -0400 Merge branch 'win1256' commit 6ab6be32c5857ce3344021ad2996e80b2a8c8f99 Author: Behdad Esfahbod Date: Sat Aug 2 14:58:38 2014 -0400 [arabic/win1256] Remove unused MultipleSubst macros src/hb-ot-shape-complex-arabic-win1256.hh | 12 ------------ 1 file changed, 12 deletions(-) commit abfa4252cce1c56c472693dcd8400cd97ededd2f Author: Behdad Esfahbod Date: Fri Aug 1 19:05:33 2014 -0400 [arabic/win1256] Really fix lam-alef this time https://bugzilla.mozilla.org/show_bug.cgi?id=1045139#c26 https://github.com/behdad/harfbuzz/commit/b276e897d17519a2c28f79d024904ac2bdd86bcf#commitcomment-7243499 src/hb-ot-shape-complex-arabic-fallback.hh | 2 +- src/hb-ot-shape-complex-arabic-win1256.hh | 49 +++++++++--------------------- 2 files changed, 15 insertions(+), 36 deletions(-) commit 55977f2a462b7fa1248eab3787053dc82320d3e5 Author: Behdad Esfahbod Date: Fri Aug 1 16:14:33 2014 -0400 [arabic/win1256] Hook up lamMedi lookup Restructure lookup array to accommodate. https://bugzilla.mozilla.org/show_bug.cgi?id=1045139#c18 src/hb-ot-shape-complex-arabic-fallback.hh | 26 ++++++++++---------------- src/hb-ot-shape-complex-arabic-win1256.hh | 1 + 2 files changed, 11 insertions(+), 16 deletions(-) commit e839e2523e64fd0cf21929f6a45e2facd59c7917 Author: Behdad Esfahbod Date: Fri Aug 1 16:09:31 2014 -0400 [arabic/win1256] Fix TEH MARBUTA final form https://bugzilla.mozilla.org/show_bug.cgi?id=1045139#c18 src/hb-ot-shape-complex-arabic-win1256.hh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit a2de193220ee2839125594bd1a60b5b66ab4598e Author: Behdad Esfahbod Date: Thu Jul 31 18:21:05 2014 -0400 [arabic/win1256] Fix shaping of JEEM, HAH, and KHAH https://bugzilla.mozilla.org/show_bug.cgi?id=1045139#c16 src/hb-ot-shape-complex-arabic-win1256.hh | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) commit 1789ccb1dd56af6117eac00e633eff94860ba252 Author: Behdad Esfahbod Date: Thu Jul 31 11:04:00 2014 -0400 [arabic/win1256] Remove GCC'ism The table can now compile independently too. If we cannot make it work on MSVC, we can always generate the data and distribute it. The code now compiles cleanly with: gcc -c -xc -std=c99 -Werror -pedantic hb-ot-shape-complex-arabic-win1256.hh g++ -c -xc -std=c++1x -Werror -pedantic hb-ot-shape-complex-arabic-win1256.hh See: https://github.com/behdad/harfbuzz/commit/a97f537cec209649302899975d76ca2b2661da7a#commitcomment-7218736 src/hb-ot-shape-complex-arabic-fallback.hh | 4 +- src/hb-ot-shape-complex-arabic-win1256.hh | 123 +++++++++++++++++------------ 2 files changed, 75 insertions(+), 52 deletions(-) commit f28b1c823db2ad56fed356ef864a7508d23048b8 Author: Behdad Esfahbod Date: Wed Jul 30 02:15:44 2014 -0400 [arabic] Implement Windows-1256 private shaping Bug 1045139 - The Arabic text with "MS Sans Serif" font is rendered bad https://bugzilla.mozilla.org/show_bug.cgi?id=1045139 This is only enabled on Windows platforms, and requires support from Uniscribe to work. But for clients that do hook up to Uniscribe, this fixes shaping of Windows-1256-encoded bitmap fonts like "MS Sans Serif". The code and table together have just less than a 1kb footprint when enabled. UNTESTED. I might even have broken regular Arabic fallback shaping. src/Makefile.am | 1 + src/check-includes.sh | 2 +- src/hb-ot-shape-complex-arabic-fallback.hh | 125 +++++++++-- src/hb-ot-shape-complex-arabic-win1256.hh | 328 +++++++++++++++++++++++++++++ 4 files changed, 442 insertions(+), 14 deletions(-) commit ac53443f1cea83ed43a4e41a9fdb91902f7fae7b Author: Behdad Esfahbod Date: Thu Jul 31 18:51:37 2014 -0400 [hangul] Don't apply 'calt' See comments. Micro-test added. src/hb-ot-shape-complex-hangul.cc | 11 ++++++++++- test/shaping/Makefile.am | 1 + .../sha1sum/757ebd573617a24aa9dfbf0b885c54875c6fe06b.ttf | Bin 0 -> 1804 bytes .../sha1sum/7e14e7883ed152baa158b80e207b66114c823a8b.ttf | Bin 0 -> 1644 bytes test/shaping/fonts/sha1sum/MANIFEST | 2 ++ test/shaping/tests/MANIFEST | 1 + test/shaping/tests/hangul-jamo.tests | 11 +++++++++++ 7 files changed, 25 insertions(+), 1 deletion(-) commit 8292f96b2be173ebceb1b54426c271cfeaecd633 Author: Behdad Esfahbod Date: Thu Jul 31 18:33:11 2014 -0400 [test] Fix record-test.sh test/shaping/record-test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 88911e8cc765c26e502503a3a00ac7f17973f3d9 Author: Behdad Esfahbod Date: Tue Jul 29 19:47:26 2014 -0400 Minor src/hb-ot-shape-complex-arabic-fallback.hh | 1 + 1 file changed, 1 insertion(+) commit 9e834e29e0b657f0555df1ab9cea79ff7abcf08d Author: Behdad Esfahbod Date: Sat Jul 26 20:34:01 2014 -0400 [hebrew] Zero mark advance by GDEF late Seems to be what Uniscribe does. At this point I think it's work checking our default... Fixes Bug 76767 - Zeroing of advance of 2nd component of multiple substitution with SBL Hebrew https://bugs.freedesktop.org/show_bug.cgi?id=76767 Micro-test added. src/hb-ot-shape-complex-hebrew.cc | 2 +- .../sha1sum/8454d22037f892e76614e1645d066689a0200e61.ttf | Bin 0 -> 6068 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 + test/shaping/tests/zero-width-marks.tests | 1 + 4 files changed, 3 insertions(+), 1 deletion(-) commit 6f2d9ba52a6d1e3fc200da1ef0e85ba020fcd0dc Author: Behdad Esfahbod Date: Sat Jul 26 19:17:44 2014 -0400 Add old-Myanmar shaper Looks like Unsicribe responds to the 'mymr' tag by zeroing marks GDEF_LATE instead of generic-shaper UNICODE_LATE. Implement that. Fixes Bug 81775 - Incorrect Rendering with harfbuzz-ng myanmar unicode https://bugs.freedesktop.org/show_bug.cgi?id=81775 Micro-test added based on Padauk. src/hb-ot-shape-complex-myanmar.cc | 18 ++++++++++++++++++ src/hb-ot-shape-complex-private.hh | 5 +++-- test/shaping/Makefile.am | 1 + test/shaping/fonts/sha1sum/MANIFEST | 1 + .../bb9473d2403488714043bcfb946c9f78b86ad627.ttf | Bin 0 -> 3440 bytes test/shaping/tests/MANIFEST | 1 + test/shaping/tests/zero-width-marks.tests | 1 + 7 files changed, 25 insertions(+), 2 deletions(-) commit 595d2b96c37de8147489dc5e0ddcc4ab1ad3eea9 Author: Behdad Esfahbod Date: Sat Jul 26 18:44:15 2014 -0400 Minor src/hb-ot-shape-complex-indic.cc | 1 + src/hb-ot-shape.cc | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) commit fe6788bc570d77d5b3aafc68efd51ca6b80499b1 Author: Behdad Esfahbod Date: Fri Jul 25 12:40:56 2014 -0400 Typo src/hb-common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0de25d4184d2d92b1a2ebb6fa054275aaae4c316 Author: Behdad Esfahbod Date: Fri Jul 25 12:35:03 2014 -0400 [util] Note CSS compatibility in --help-features util/options.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 6e69200a2aadbc6bba35ffb4a058c14286b84f46 Author: Behdad Esfahbod Date: Fri Jul 25 12:30:47 2014 -0400 Fix snprintf() format Patch from Maks Naumov. Fixes https://github.com/behdad/harfbuzz/pull/22 src/hb-shape.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 5c5cdbbdf8be231c433e21b050a6c6991d327b61 Author: Behdad Esfahbod Date: Fri Jul 25 12:21:49 2014 -0400 Make sure broken feature strings are not partially parsed If user doesn't check hb_feature_from_string() return value, we don't want them to end up see the partially-parsed feature. src/hb-shape.cc | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) commit a795fe637846e0d9561d2f7cdd84cfafd58b23a7 Author: Behdad Esfahbod Date: Fri Jul 25 12:15:33 2014 -0400 Allow quotation marks around feature tag in hb_feature_from_string() With this, I believe we accept CSS feature strings completely. src/hb-shape.cc | 24 +++++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) commit 3f6461847412e78bcddc8eba97200f3afcde869a Author: Behdad Esfahbod Date: Fri Jul 25 12:04:27 2014 -0400 Allow space at the end of feature string with values, eg 'dlig=1 ' src/hb-shape.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit f31f7d2259dd8edffc070af55938cb7aa23514c1 Author: Behdad Esfahbod Date: Fri Jul 25 12:03:52 2014 -0400 Minor src/hb-shape.cc | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) commit 60cb18a5dea2d30793f89e80995bb729c014864a Author: Behdad Esfahbod Date: Fri Jul 25 12:01:22 2014 -0400 Allow on/off in hb_feature_from_string() We now allow things like "dlig on" / "dlig=on". src/hb-shape.cc | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) commit d9e618eca9e01c2eb6db65504af3f73be370a1e7 Author: Behdad Esfahbod Date: Fri Jul 25 11:56:01 2014 -0400 Remove duplicate definition of ISALNUM It's defined in hb-private.h already. src/hb-shape.cc | 2 -- 1 file changed, 2 deletions(-) commit 2ee5f665ded86147acedc400153c0b3a90fe07c6 Author: Behdad Esfahbod Date: Fri Jul 25 11:53:46 2014 -0400 Fix parsing of features like "- liga" (with the space) src/hb-shape.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit e15fa7a8cffbe6a67b1048d7b87b7df77d8b1686 Author: Behdad Esfahbod Date: Fri Jul 25 11:44:35 2014 -0400 Do not require the '=' in hb_feature_from_string() Towards accepting CSS font-feature-settings strings. src/hb-shape.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit f4fe9baefdb7e0ff9946f88b6f4b55738fa30cdf Author: Behdad Esfahbod Date: Fri Jul 25 11:39:55 2014 -0400 Reject tags longer than 4 chars in hb_feature_from_string() src/hb-shape.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7e8c38954649c0bf2e6051d84ca08dce090ec169 Author: Behdad Esfahbod Date: Fri Jul 25 11:18:11 2014 -0400 Minor warnings fixes Some systems insist on -Wmissing-field-initializers. We have too many, by design. Fix a few easy ones. src/hb-open-type-private.hh | 2 +- src/hb-ot-layout-private.hh | 2 +- src/hb-private.hh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) commit fc0daafab0336b847ac14682e581a8838f36a0bf Author: Behdad Esfahbod Date: Wed Jul 23 16:48:51 2014 -0400 [indic] Handle old-spec Malayalam reordering with final Halant See comment. Micro-tests added. src/hb-ot-shape-complex-indic.cc | 28 +++++++++++++++++---- test/shaping/Makefile.am | 1 + .../270b89df543a7e48e206a2d830c0e10e5265c630.ttf | Bin 0 -> 3428 bytes .../57a9d9f83020155cbb1d2be1f43d82388cbecc88.ttf | Bin 0 -> 2272 bytes test/shaping/fonts/sha1sum/MANIFEST | 2 ++ test/shaping/tests/MANIFEST | 1 + test/shaping/tests/indic-old-spec.tests | 2 ++ .../indic/script-malayalam/misc/misc.txt | 1 + 8 files changed, 30 insertions(+), 5 deletions(-) commit d6d349d17898529ecdf8217a54987a3e9f81ce05 Author: Behdad Esfahbod Date: Wed Jul 23 11:38:49 2014 -0400 Give CC to gir-scanner From: https://github.com/Alexpux/MINGW-packages/blob/master/mingw-w64-harfbuzz/0001-give-cc-to-gir-scanner.all.patch src/Makefile.am | 1 + 1 file changed, 1 insertion(+) commit 8c1bdb46facb79cfca5ebfea9a7e467b40337f47 Author: Behdad Esfahbod Date: Tue Jul 22 17:56:43 2014 -0400 0.9.33 NEWS | 10 ++++++++++ configure.ac | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) commit d218bdb26b226fbf68331eb586b24460c061313d Author: Behdad Esfahbod Date: Tue Jul 22 18:01:46 2014 -0400 Fix test runner under Windows test/shaping/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3f310dc0cae9015c45ba642b9b83d5695c807aad Author: Behdad Esfahbod Date: Tue Jul 22 16:26:27 2014 -0400 Disallow changing settings on immutable face Ouch! src/hb-face.cc | 8 ++++---- src/hb-font.cc | 4 ++-- src/hb-unicode.cc | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) commit 0fc0a1022854324261fea8893678a3e9fd9443eb Author: Behdad Esfahbod Date: Mon Jul 21 11:12:54 2014 -0400 [win] Fix Cygwin build https://github.com/behdad/harfbuzz/commit/db308280488c2ee11ba865a9922eb6a0c1abeef3#commitcomment-7077778 src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1132a7dd0ecf1c425078e39e5471330bace42659 Author: Behdad Esfahbod Date: Sun Jul 20 01:17:40 2014 -0400 Add HB_TAG_MAX_SIGNED / _HB_SCRIPT_MAX_VALUE_SIGNED To make C language police happy. src/hb-common.h | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) commit df99976398a53521e0228541055dcaee8f5ba87f Author: Behdad Esfahbod Date: Sat Jul 19 17:31:23 2014 -0400 [gobject] Skip _HB_SCRIPT_MAX_VALUE Fixes https://github.com/behdad/harfbuzz/pull/38 src/hb-common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f1a8d50a87edfb8147aa1bec732ed7ccbfef2877 Author: Behdad Esfahbod Date: Sat Jul 19 16:52:32 2014 -0400 [win] Don't define visibility attribtue under Cygwin src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9c77027d645142794c3ff1590a96bb151c3f2e91 Author: Behdad Esfahbod Date: Sat Jul 19 16:37:22 2014 -0400 [win] Turn STRICT on for including windows.h src/hb-private.hh | 1 + 1 file changed, 1 insertion(+) commit db308280488c2ee11ba865a9922eb6a0c1abeef3 Author: Behdad Esfahbod Date: Sat Jul 19 16:32:04 2014 -0400 [win] Consolidate windows.h include tips and tricks src/hb-atomic-private.hh | 4 ---- src/hb-mutex-private.hh | 1 - src/hb-private.hh | 12 ++++++++++++ src/hb-uniscribe.cc | 3 --- src/hb-uniscribe.h | 3 --- 5 files changed, 12 insertions(+), 11 deletions(-) commit f26d59d4684be3419c976d781b6dbc956248e3bb Author: Behdad Esfahbod Date: Sat Jul 19 16:10:21 2014 -0400 More fixing MemoryBarrier() on Mingw32 Set requested windows header to Vista. See discussion: https://github.com/behdad/harfbuzz/commit/fbb2847f541389f40718af71c4945024ae177ab2#commitcomment-7054700 src/hb-atomic-private.hh | 3 +++ 1 file changed, 3 insertions(+) commit 00a57eb4b50fd894dc68c6525a5bbebf0ebc30e4 Author: Behdad Esfahbod Date: Fri Jul 18 14:42:50 2014 -0400 [test] Remove unused micro-font .../9d64156923a1b9fed1e05f74599c16563eca42d9.ttf | Bin 81968 -> 0 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 - 2 files changed, 1 deletion(-) commit ed29b15f5d0d9e7b40143926ca7d40bf645f67e9 Author: Behdad Esfahbod Date: Fri Jul 18 14:37:49 2014 -0400 [test] Add more Mongolian variation selector tests From https://code.google.com/p/chromium/issues/detail?id=393896 .../9d64156923a1b9fed1e05f74599c16563eca42d9.ttf | Bin 0 -> 81968 bytes test/shaping/fonts/sha1sum/MANIFEST | 2 ++ .../bb29ce50df2bdba2d10726427c6b7609bf460e04.ttf | Bin 0 -> 74856 bytes test/shaping/tests/mongolian-variation-selector.tests | 1 + .../shaper-arabic/script-mongolian/misc/MANIFEST | 1 + .../script-mongolian/misc/variation-selectors.txt | 8 ++++++++ 6 files changed, 12 insertions(+) commit 385cf37cf084198e3aedb4354a7b025938a9f11b Author: Behdad Esfahbod Date: Thu Jul 17 18:22:07 2014 -0400 Fix hb_in_range() unused-var warning on Windows src/hb-private.hh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit e3b42f1af409c073b819bfc696024ccb1f1da63f Author: Behdad Esfahbod Date: Thu Jul 17 17:13:54 2014 -0400 [arabic] Disable 'cswh' again Ouch! src/hb-ot-shape-complex-arabic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 66f30915b185727a0041c998641edb550eb8a7fc Author: Behdad Esfahbod Date: Thu Jul 17 16:05:47 2014 -0400 0.9.32 NEWS | 12 ++++++++++++ configure.ac | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) commit 82f4d9d53f348f41b14b877c1ac77c0372c49caa Author: Behdad Esfahbod Date: Thu Jul 17 15:57:37 2014 -0400 [arabic] Add note re disabled 'cswh' src/hb-ot-shape-complex-arabic.cc | 9 +++++++++ 1 file changed, 9 insertions(+) commit 615d00ea252739da57edbd980ff27e573f88ee7e Author: Behdad Esfahbod Date: Thu Jul 17 13:36:09 2014 -0400 [arabic] Apply init/medi/isol/fini/... in separate stages Follows the order of the Arabic/Syriac specs. Also don't stop between rlig and calt in non-Arabic scripts. Micro-tests for Arabic and Mongolian added for the latter. src/hb-ot-shape-complex-arabic.cc | 56 +++++++++++++-------- test/shaping/Makefile.am | 2 + .../813c2f8e5512187fd982417a7fb4286728e6f4a8.ttf | Bin 0 -> 3428 bytes .../8a9fea2a7384f2116e5b84a9b31f83be7850ce21.ttf | Bin 0 -> 3428 bytes test/shaping/fonts/sha1sum/MANIFEST | 3 ++ .../a919b33197965846f21074b24e30250d67277bce.ttf | Bin 0 -> 12560 bytes test/shaping/tests/MANIFEST | 1 + test/shaping/tests/arabic-feature-order.tests | 3 ++ 8 files changed, 43 insertions(+), 22 deletions(-) commit d21e997035b16e9807dfb29c3605abb93f92f1ee Author: Behdad Esfahbod Date: Thu Jul 17 15:27:46 2014 -0400 [test] Make record_test understand cmdline args to hb-shape test/shaping/record-test.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 7cd33f230441093dbfb1fec48f8c580ee8d9ef71 Author: Behdad Esfahbod Date: Thu Jul 17 14:22:11 2014 -0400 Micro optimization src/hb-fallback-shape.cc | 36 +++++++++++++++++++----------------- src/hb-ot-shape-complex-arabic.cc | 19 +++++++++++-------- src/hb-ot-shape-complex-indic.cc | 15 ++++++++++----- src/hb-ot-shape-complex-myanmar.cc | 7 +++++-- src/hb-ot-shape-complex-sea.cc | 7 +++++-- src/hb-ot-shape-fallback.cc | 30 ++++++++++++++++-------------- src/hb-ot-shape.cc | 18 ++++++++++++------ 7 files changed, 78 insertions(+), 54 deletions(-) commit 164c13d73f67fdddba28e6409d76b4903e8ffab3 Author: Behdad Esfahbod Date: Thu Jul 17 14:16:38 2014 -0400 Another try to fix Mongolian free variation selectors This reverts bf029281 and fixes it properly. That commit was not enough as it was only inheriting the shaping_action for prev_action, but not curr_action. Micro-test added. https://code.google.com/p/chromium/issues/detail?id=393896 src/hb-ot-shape-complex-arabic.cc | 24 +++++++++++++++------ src/hb-unicode-private.hh | 3 ++- test/shaping/fonts/sha1sum/MANIFEST | 1 + .../ef86fe710cfea877bbe0dbb6946a1f88d0661031.ttf | Bin 0 -> 2748 bytes .../tests/mongolian-variation-selector.tests | 1 + 5 files changed, 22 insertions(+), 7 deletions(-) commit 5209c505061130854a2bfea8849928ade3ee92f3 Author: Behdad Esfahbod Date: Thu Jul 17 12:23:44 2014 -0400 Revert "Show U+FFFD REPLACEMENT CHARACTER for invalid Unicode codepoints" We now handle U+FFFD replacement in hb_buffer_add_utf*(). Any other manipulation can happen in user callbacks. No need for this. https://github.com/behdad/harfbuzz/commit/efe74214bbb68eaa3d7621e73869b5d58210107e#commitcomment-7039404 This reverts commit efe74214bbb68eaa3d7621e73869b5d58210107e. Conflicts: src/hb-ot-shape-normalize.cc src/hb-ot-shape-normalize.cc | 7 ------- 1 file changed, 7 deletions(-) commit 9e7c720100e432b43564ed5ff12f3175ca2ed74a Author: Dominik Röttsches Date: Thu Jul 17 14:40:34 2014 +0300 Fix CoreText build after a8b89a09f6d3a34 src/hb-private.hh | 1 + 1 file changed, 1 insertion(+) commit a4d643755a531c82ab91e1e43d6bb0b7bd46453a Author: Behdad Esfahbod Date: Wed Jul 16 20:15:45 2014 -0400 Minor src/hb-utf-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a18897f87ce2c6048c3a0339074924b2232e2b95 Author: Behdad Esfahbod Date: Wed Jul 16 16:02:15 2014 -0400 0.9.31 NEWS | 29 +++++++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 30 insertions(+), 1 deletion(-) commit 976c8f455221eb599d1c446eafd88d51d7d2aa65 Author: Behdad Esfahbod Date: Wed Jul 16 15:34:20 2014 -0400 New API: hb_buffer_[sg]et_replacement_codepoint() With this change, we now by default replace broken UTF-8/16/32 bits with U+FFFD. This can be changed by calling new API on the buffer. Previously the replacement value used to be (hb_codepoint_t)-1. Note that hb_buffer_clear_contents() does NOT reset the replacement character. See discussion here: https://github.com/behdad/harfbuzz/commit/6f13b6d62daae4989e3cc2fe4b168e5c59650964 New API: hb_buffer_set_replacement_codepoint() hb_buffer_get_replacement_codepoint() src/hb-buffer-private.hh | 1 + src/hb-buffer.cc | 45 ++++++++++++++++++++++++++++++++++++++++++--- src/hb-buffer.h | 15 ++++++++++++++- src/hb-utf-private.hh | 34 ++++++++++++++++++++-------------- test/api/test-buffer.c | 26 +++++++++++++++----------- 5 files changed, 92 insertions(+), 29 deletions(-) commit bcba8b45024e1eca8be77ca2657de1dc44dbf8fb Author: Behdad Esfahbod Date: Wed Jul 16 14:59:04 2014 -0400 New API hb_buffer_add_codepoints() Like hb_buffer_add_utf32, but doesn't do any Unicode validation. This is like what hb_buffer_add_utf32 used to be until a couple commits ago. src/hb-buffer.cc | 32 +++++++++++++++++++++++++++----- src/hb-buffer.h | 8 ++++++++ 2 files changed, 35 insertions(+), 5 deletions(-) commit 625dbf141a05f1ae81a7b8cbc529996370101284 Author: Behdad Esfahbod Date: Wed Jul 16 14:49:55 2014 -0400 [buffer] Templatize UTF-* functions src/hb-buffer.cc | 10 +- src/hb-utf-private.hh | 307 ++++++++++++++++++++++++++------------------------ 2 files changed, 166 insertions(+), 151 deletions(-) commit e634fed4285ce440d277345727ed01757df6d779 Author: Behdad Esfahbod Date: Wed Jul 16 14:17:26 2014 -0400 [buffer] Validate UTF-32 input Same as what we do for UTF-8 and UTF-16. src/hb-utf-private.hh | 13 +++++++++--- test/api/test-buffer.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 65 insertions(+), 3 deletions(-) commit b98c5db32d15fcfb27ce2f6737203ce1ad124319 Author: Behdad Esfahbod Date: Wed Jul 16 13:44:01 2014 -0400 Minor refactoring src/hb-ot-layout-gsubgpos-private.hh | 25 ++++++------------------- 1 file changed, 6 insertions(+), 19 deletions(-) commit 844f1a487d9c39724ebff20e89f6184c9a59be0b Author: Behdad Esfahbod Date: Wed Jul 16 13:32:51 2014 -0400 [tests] Add record-test.sh test/shaping/Makefile.am | 1 + test/shaping/record-test.sh | 49 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+) commit 3b861421a772f52eb232ff93bd74b5a8214801ec Author: Behdad Esfahbod Date: Wed Jul 16 13:22:05 2014 -0400 Fix Mongolian Variation Selectors for fonts without GDEF Originally we fixed those in 79d1007a501fd63c0ba4d51038c513e6b8b94740. However, fonts like MongolianWhite don't have GDEF, but have IgnoreMarks in their LigatureSubstitute init/etc features. We were synthesizing a GDEF class of mark for Mongolian Variation Selectors and as such the ligature lookups where not matching. Uniscribe doesn't do that. I tried with more sophisticated fixes, like, if there is no GDEF and a lookup-flag mismatch happens, instead of rejecting a match, try skipping that glyph. That surely produces some interesting behavior, but since we don't want to support fonts missing GDEF more than we have to, I went for this simpler fix which is to always mark default-ignorables as base when synthesizing GDEF. Micro-test added. Fixes rest of https://bugs.freedesktop.org/show_bug.cgi?id=65258 src/hb-ot-shape.cc | 13 +++++++++++-- .../sha1sum/37033cc5cf37bb223d7355153016b6ccece93b28.ttf | Bin 0 -> 2780 bytes test/shaping/fonts/sha1sum/MANIFEST | 1 + test/shaping/tests/MANIFEST | 1 + test/shaping/tests/mongolian-variation-selector.tests | 1 + 5 files changed, 14 insertions(+), 2 deletions(-) commit 878a25375b2fdf64cf0cc30c23fca9fcd58548e8 Author: Behdad Esfahbod Date: Wed Jul 16 13:21:26 2014 -0400 Minor src/hb-ot-shape.cc | 1 + src/hb-unicode-private.hh | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) commit ec181e50140fc65b32d6080e2f7f73bbe0269ba9 Author: Behdad Esfahbod Date: Wed Jul 16 13:10:03 2014 -0400 Minor moving around src/hb-ot-shape.cc | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) commit e7ce50d9eb6e3678f731b10dfeb308ffc478af8d Author: Behdad Esfahbod Date: Wed Jul 16 12:30:39 2014 -0400 [indic] Fix access past end of array src/hb-ot-shape-complex-indic.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) commit 73e23b0acfd2948d500321769035c56c9e072d77 Author: Behdad Esfahbod Date: Tue Jul 15 18:43:49 2014 -0400 Whitespace src/hb-ot-layout-gsubgpos-private.hh | 1 - 1 file changed, 1 deletion(-) commit f27be105afb86b337c7d940badc5a6462f0b58bb Author: Behdad Esfahbod Date: Fri Jul 11 18:15:34 2014 -0400 [Android.mk] Actually remove static library Android.mk | 26 -------------------------- 1 file changed, 26 deletions(-) commit 96b80e9bcc4796eedac09d284dc8cc0439ced6ba Author: Behdad Esfahbod Date: Fri Jul 11 17:00:12 2014 -0400 [Android.mk] Remove static library, add note re how to build Android.mk | 41 +++++++++++++++++++++++++++++++++++++---- 1 file changed, 37 insertions(+), 4 deletions(-) commit b7bc0b671d2d568cb64b647dad2ca866a4e0183b Author: Behdad Esfahbod Date: Fri Jul 11 16:20:28 2014 -0400 Simplify / speed up UTF-8 code src/hb-utf-private.hh | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) commit af2490c0959daa0fe7f32a8b3b3a3699c7fc5f48 Author: Behdad Esfahbod Date: Fri Jul 11 16:10:58 2014 -0400 Only accept well-formed UTF-8 sequences Enable tests that were disabled before, and adjust one test, and add more tests. src/hb-utf-private.hh | 93 +++++++++++++++++++++++++++++++++----------------- test/api/test-buffer.c | 9 +++-- 2 files changed, 68 insertions(+), 34 deletions(-) commit 7323d385cc758c06671cb38239d240eb517b28bc Author: Behdad Esfahbod Date: Fri Jul 11 15:10:05 2014 -0400 Simplify hb_utf_prev<16> to call hb_utf_next<16> src/hb-utf-private.hh | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) commit c09a607a842fdd7b33e2c57e8af96d21ff091acd Author: Behdad Esfahbod Date: Fri Jul 11 15:05:36 2014 -0400 Use hb_in_range() for arabic and indic tables Though, looks like gcc was smart enough to produce the same code before... src/gen-arabic-table.py | 18 +- src/gen-indic-table.py | 10 +- src/hb-ot-shape-complex-arabic-table.hh | 420 ++++++++++++++++---------------- src/hb-ot-shape-complex-indic-table.cc | 88 +++---- 4 files changed, 268 insertions(+), 268 deletions(-) commit 7627100f428ac0ec8509d961d368d2d25d8f0b6e Author: Behdad Esfahbod Date: Fri Jul 11 14:54:42 2014 -0400 Mark unsigned integer literals with the u suffix Simplifies hb_in_range() calls as the type can be inferred. The rest is obsessiveness, I admit. src/hb-buffer-serialize.cc | 2 +- src/hb-common.cc | 4 +- src/hb-coretext.cc | 16 +-- src/hb-open-file-private.hh | 4 +- src/hb-open-type-private.hh | 2 +- src/hb-ot-cmap-table.hh | 4 +- src/hb-ot-head-table.hh | 6 +- src/hb-ot-hhea-table.hh | 2 +- src/hb-ot-layout-common-private.hh | 14 +-- src/hb-ot-layout-gdef-table.hh | 8 +- src/hb-ot-layout-gpos-table.hh | 24 ++-- src/hb-ot-layout-gsub-table.hh | 6 +- src/hb-ot-layout-gsubgpos-private.hh | 2 +- src/hb-ot-layout-jstf-table.hh | 2 +- src/hb-ot-layout-private.hh | 4 +- src/hb-ot-layout.h | 6 +- src/hb-ot-map-private.hh | 8 +- src/hb-ot-maxp-table.hh | 4 +- src/hb-ot-shape-complex-arabic-fallback.hh | 2 +- src/hb-ot-shape-complex-hangul.cc | 36 +++--- src/hb-ot-shape-complex-hebrew.cc | 134 ++++++++++----------- src/hb-ot-shape-complex-indic.cc | 182 ++++++++++++++--------------- src/hb-ot-shape-complex-myanmar.cc | 56 ++++----- src/hb-ot-shape-complex-sea.cc | 8 +- src/hb-ot-shape-complex-thai.cc | 84 ++++++------- src/hb-ot-shape-fallback.cc | 40 +++---- src/hb-ot-shape-normalize.cc | 2 +- src/hb-ot-shape.cc | 6 +- src/hb-ot-tag.cc | 18 +-- src/hb-unicode-private.hh | 40 +++---- src/hb-uniscribe.cc | 14 +-- src/hb-utf-private.hh | 16 +-- 32 files changed, 378 insertions(+), 378 deletions(-) commit a8b89a09f6d3a3466282aae07fd65e143f9f8f83 Author: Behdad Esfahbod Date: Fri Jul 11 14:18:01 2014 -0400 Simplify hb_in_range() It's both faster and produces smaller code. Now I feel stupid for not writing it this way before. src/hb-private.hh | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) commit db8934faa1854dafaf4c4ce34d1818e12f67ef52 Author: Behdad Esfahbod Date: Fri Jul 11 13:58:36 2014 -0400 Simplify hb_utf_prev<8> to call hb_utf_next<8> src/hb-utf-private.hh | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-) commit efe74214bbb68eaa3d7621e73869b5d58210107e Author: Behdad Esfahbod Date: Fri Jul 11 11:59:48 2014 -0400 Show U+FFFD REPLACEMENT CHARACTER for invalid Unicode codepoints Only if the font doesn't support it. Ie, this gives the user to use non-Unicode codepoints as private values and return a meaningful glyph for them. But if it's invalid and font callback doesn't like it, and if font has U+FFFD, show that instead. Font functions that do not want this automatic replacement to happen should return true from get_glyph() if unicode > 0x10FFFF. Replaces https://github.com/behdad/harfbuzz/pull/27 src/hb-ot-shape-normalize.cc | 7 +++++++ 1 file changed, 7 insertions(+) commit 6f13b6d62daae4989e3cc2fe4b168e5c59650964 Author: Behdad Esfahbod Date: Thu Jul 10 19:31:40 2014 -0400 When parsing UTF-16, generate invalid codepoint for lonely low surrogate Test passes now. src/hb-utf-private.hh | 42 ++++++++++++++++++++++++++++-------------- 1 file changed, 28 insertions(+), 14 deletions(-) commit 24b2ba9dfa7c35769cd843a07079ef88fa594bf8 Author: Behdad Esfahbod Date: Thu Jul 10 19:31:16 2014 -0400 [test-buffer] Add test for lonely low-surrogate Currenty fails. Ouch! test/api/test-buffer.c | 1 + 1 file changed, 1 insertion(+) commit 6334495ac1ee0a86228e67794b7a41ee91146f3b Author: Behdad Esfahbod Date: Thu Jul 10 19:22:07 2014 -0400 Use zh-Hans / zh-Hant when converting OT language tag to hb_language_t src/hb-ot-tag.cc | 15 +++------------ test/api/test-ot-tag.c | 6 +++--- 2 files changed, 6 insertions(+), 15 deletions(-) commit f381e320df795a9d73ac81499f8ed8c311bcb2f0 Author: Behdad Esfahbod Date: Thu Jul 10 19:20:35 2014 -0400 Fix lang matching logic Previous code was broken logically, but harmless. src/hb-ot-tag.cc | 2 +- test/api/test-ot-tag.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) commit ee5350d667f3a9644667202597694581f2cf657d Author: Behdad Esfahbod Date: Thu Jul 10 19:06:45 2014 -0400 Accept BCP 47 zh-Hans / zh-Hant language tags src/hb-ot-tag.cc | 27 ++++++++++++++++++--------- test/api/test-ot-tag.c | 3 +++ 2 files changed, 21 insertions(+), 9 deletions(-) commit 431540286794e023ec5eafd5eeedc008d4f31b4c Author: Behdad Esfahbod Date: Thu Jul 10 17:37:26 2014 -0400 [Android.mk] Add note re static library Android.mk | 7 +++++++ 1 file changed, 7 insertions(+) commit 5b4131eb1c670c20fd9a45a5617c64060a505ef5 Author: Behdad Esfahbod Date: Wed Jul 9 19:09:08 2014 -0400 [Android.mk] Update for new ICU https://android-review.googlesource.com/#/c/100722/1/Android.mk Android.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ab28196c9557a63971a56915aa6f98bb5803bd1b Author: Behdad Esfahbod Date: Wed Jul 9 18:18:06 2014 -0400 [Android.mk] Re-enable ICU unicode funcs Android.mk | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) commit ea001374b86c4f1b24246c08a3d66d2a0e95a827 Author: Behdad Esfahbod Date: Wed Jul 9 17:28:43 2014 -0400 0.9.30 NEWS | 17 +++++++++++++++++ configure.ac | 2 +- 2 files changed, 18 insertions(+), 1 deletion(-) commit 8b16ff12590200afb08e8821e3f14d2fdf8efbda Author: Behdad Esfahbod Date: Wed Jul 9 17:40:52 2014 -0400 [uniscribe] Fix build after recent changes to Offset src/hb-ot-name-table.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 73f7f8919ea1f09b8c5b29f231ac84105cde2145 Author: Behdad Esfahbod Date: Wed Jul 9 17:17:18 2014 -0400 Define _POSIX_C_SOURCE only if it is not defined Fixes https://github.com/behdad/harfbuzz/pull/45 src/hb-blob.cc | 2 ++ 1 file changed, 2 insertions(+) commit 6bd5646f1b865a76304a67e03a6161afcfef293f Author: Behdad Esfahbod Date: Wed Jul 9 17:07:06 2014 -0400 [tests] Remove bash'ish Apparently on travis-ci, bash is linked to dash, which doesn't understand "let". Failing tests were not being noticed. See eg: https://travis-ci.org/behdad/harfbuzz/jobs/29544211 Don't rely on bash. test/shaping/run-tests.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 0afedaa96c81b63774a4a0ef9b4cb4995d24ec9e Author: Behdad Esfahbod Date: Wed Jul 9 17:00:48 2014 -0400 [util/hb-shape] Fix crash; oops util/hb-shape.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0cd94491b99aed438ad79a55cdfced8d1b657179 Author: Behdad Esfahbod Date: Wed Jul 9 16:51:38 2014 -0400 [ucdn] Update to Unicode 7.0.0 data From http://github.com/behdad/ucdn src/hb-ucdn.cc | 23 + src/hb-ucdn/README | 1 + src/hb-ucdn/ucdn.c | 2 +- src/hb-ucdn/ucdn.h | 27 + src/hb-ucdn/unicodedata_db.h | 3711 ++++++++++++++++++++++-------------------- 5 files changed, 2039 insertions(+), 1725 deletions(-) commit 9d4ede3a97fff544a5ec2a671e49a92a79645b61 Author: Behdad Esfahbod Date: Wed Jul 9 16:19:55 2014 -0400 [Android.mk] Update source list Android.mk | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit 7e1ab1f6d812a55f75d4844f7981d5604481049c Author: Behdad Esfahbod Date: Wed Jul 9 16:13:40 2014 -0400 [Android.mk] Whitespace Android.mk | 26 ++++++-------------------- 1 file changed, 6 insertions(+), 20 deletions(-) commit 5c6695c42470e0a15e9029ebe8ecbebf3fa4f95b Author: Behdad Esfahbod Date: Wed Jul 9 16:07:12 2014 -0400 [Android.mk] Remove -lpthread; we build with -DHB_NO_MT Android.mk | 3 --- 1 file changed, 3 deletions(-) commit 9109f1e944dd4bd4ae8057b75c8a31e9d31797aa Author: Behdad Esfahbod Date: Tue Jul 8 20:02:29 2014 -0400 [util/hb-shape] Accept an empty output-format that would skip output Useful for benchmarking, to avoid buffer serialization overhead (which seems to by far dominate shaping!) util/hb-shape.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 8656408572c2685f278a3b742ee69c767c29788c Author: Behdad Esfahbod Date: Tue Jul 8 18:10:20 2014 -0400 [util] Fix hb-view rendering with --font-funcs=ot util/helper-cairo.cc | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) commit 8650def73500204b79c651f58b1be3f94a41973d Author: Behdad Esfahbod Date: Sat Jul 5 15:50:18 2014 -0400 [util] Add option to set font function implementation to use Supports ft and ot right now. hb-view currently not rendering with ot. Will fix after some clean up. util/options.cc | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++------- util/options.hh | 21 ++++++++++++++++ 2 files changed, 88 insertions(+), 9 deletions(-) commit 2306ad46dce1c53b0b1bfabdc04d70e3b99eabb7 Author: Behdad Esfahbod Date: Fri Jul 4 18:09:29 2014 -0400 [util] Fix memory issue util/options.cc | 6 ++---- util/options.hh | 9 +++++++++ 2 files changed, 11 insertions(+), 4 deletions(-) commit 14a4a9d649798d32c31f79b4045a885626dffc7f Author: Behdad Esfahbod Date: Tue Jul 1 15:51:54 2014 -0400 Add Roozbeh to AUTHORS He's been my shadow for all Indic-related changes in the last few months. AUTHORS | 1 + 1 file changed, 1 insertion(+) commit 68f724484b1663255ee249481624e552d2e2313f Author: Behdad Esfahbod Date: Mon Jun 30 15:46:53 2014 -0400 [indic] Remove some more now-unused special-cases src/hb-ot-shape-complex-indic.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit e79c9489802f99dc7eb8b4c2765c4c71b5f80e60 Author: Behdad Esfahbod Date: Mon Jun 30 15:39:39 2014 -0400 [indic] Remove special-casing of U+1CF2,1CF3 These were introduced in a498565cedf0441ae723c5e5969f637d792a15e7, but IndicSyllabicCategory has had the correct value already, so the special code was never needed. src/hb-ot-shape-complex-indic.cc | 6 ------ 1 file changed, 6 deletions(-) commit d743ce78e10758b7dbaf0cfd191309e5ef646881 Author: Behdad Esfahbod Date: Mon Jun 30 15:24:02 2014 -0400 [indic-table] Update to Unicode 7.0 data Touch code just enough to preserve previous syllable structure and functionality as closely as possible. Many further cleanups coming later. src/gen-indic-table.py | 4 + src/hb-ot-shape-complex-indic-private.hh | 23 +- src/hb-ot-shape-complex-indic-table.cc | 468 ++++++++++++++++++++++--------- src/hb-ot-shape-complex-indic.cc | 21 -- src/hb-ot-shape-complex-myanmar.cc | 2 - 5 files changed, 355 insertions(+), 163 deletions(-) commit 5fa21b3ab7175f55f89cb194b544d5d4bd06a481 Author: Behdad Esfahbod Date: Mon Jun 30 14:30:54 2014 -0400 [indic-table] Fix category frequency counts in comments src/gen-indic-table.py | 2 +- src/hb-ot-shape-complex-indic-table.cc | 46 +++++++++++++++++----------------- 2 files changed, 24 insertions(+), 24 deletions(-) commit 5c4e3e9a57b6b735e7d72cbd5f4070cf024d7015 Author: Behdad Esfahbod Date: Mon Jun 30 14:25:18 2014 -0400 Whitespace src/hb-ot-shape-complex-indic-private.hh | 76 ++++++++++++++++---------------- 1 file changed, 38 insertions(+), 38 deletions(-) commit af528b6674bccac3efd13f8b33fcdc6aeb178f4c Author: Behdad Esfahbod Date: Fri Jun 27 18:07:00 2014 -0400 Fix typo; ouch! src/hb-ot-cmap-table.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7d4ada66c96a748ce92f8e8edac149361c3dc829 Author: Behdad Esfahbod Date: Fri Jun 27 17:30:59 2014 -0400 Mark unsed members with a "Z" suffix There may be more. There are members that are by definition redundant or reserved and not needed, NOT what we *currently* don't use. I'm sure there's more... src/hb-open-file-private.hh | 6 +++--- src/hb-ot-cmap-table.hh | 24 ++++++++++++------------ src/hb-ot-layout-common-private.hh | 2 +- 3 files changed, 16 insertions(+), 16 deletions(-) commit 23afcff1d14e57f5ce30a4100698d4f2dc530958 Author: Behdad Esfahbod Date: Fri Jun 27 17:22:36 2014 -0400 [ot-font] Implement Unicode variation selectors src/hb-ot-font.cc | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) commit a5a4736916b6035e6413d4619f9e7287e683d51b Author: Behdad Esfahbod Date: Fri Jun 27 17:03:22 2014 -0400 [cmap] Implement subtable format 14 src/hb-ot-cmap-table.hh | 147 +++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 133 insertions(+), 14 deletions(-) commit 586b60622c33878f9ca4826b4ef07369d32bf039 Author: Behdad Esfahbod Date: Fri Jun 27 15:39:47 2014 -0400 Minor: final bits of cleanup src/hb-open-type-private.hh | 1 + src/hb-ot-layout-common-private.hh | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) commit 51d9ba09bc78188ec87218aef5232e80568c1712 Author: Behdad Esfahbod Date: Fri Jun 27 15:27:15 2014 -0400 Minor src/hb-open-type-private.hh | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) commit 3084767e92483c669f38319f153c498e9a6b92c7 Author: Behdad Esfahbod Date: Fri Jun 27 15:24:35 2014 -0400 Minor: Remove LongArrayOf src/hb-open-file-private.hh | 2 +- src/hb-open-type-private.hh | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) commit 41ea59495032e712fa6f801350ee00d5f00b5724 Author: Behdad Esfahbod Date: Fri Jun 27 15:23:18 2014 -0400 Minor: Remove LongSortedArrayOf src/hb-open-type-private.hh | 4 ---- src/hb-ot-cmap-table.hh | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) commit bb6ecf2ce5c2679c298741af17836a22e1d68121 Author: Behdad Esfahbod Date: Fri Jun 27 15:13:44 2014 -0400 Minor: Remove LongOffsetArrayOf and LongOffsetLongArrayOf src/hb-open-file-private.hh | 2 +- src/hb-open-type-private.hh | 8 -------- src/hb-ot-layout-gdef-table.hh | 2 +- 3 files changed, 2 insertions(+), 10 deletions(-) commit 99d281712390fd54e523b2f0580d10445457ec2f Author: Behdad Esfahbod Date: Fri Jun 27 15:12:52 2014 -0400 Minor: Remove GenericOffset src/hb-open-type-private.hh | 13 +++++-------- src/hb-ot-layout-common-private.hh | 8 ++++---- 2 files changed, 9 insertions(+), 12 deletions(-) commit 9da552dcc5b89b3bbbe5a55fb7c543222382e12a Author: Behdad Esfahbod Date: Fri Jun 27 15:09:42 2014 -0400 Minor: Remove some GenericXXX templates src/hb-open-type-private.hh | 32 +++++++++++--------------------- src/hb-ot-cmap-table.hh | 4 ++-- src/hb-ot-layout-common-private.hh | 2 +- 3 files changed, 14 insertions(+), 24 deletions(-) commit 36073ede5b52bd1231622cbacd1bee6b82696d81 Author: Behdad Esfahbod Date: Fri Jun 27 14:48:54 2014 -0400 Minor: Reorder template parameter order src/hb-open-type-private.hh | 14 +++++++------- src/hb-ot-cmap-table.hh | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) commit 0394ec1bfbd7806cbe9fc809b34f96f8d12ffbf2 Author: Behdad Esfahbod Date: Fri Jun 27 14:40:35 2014 -0400 Minor: Introduce GenericOffset src/hb-open-type-private.hh | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) commit 0d1b3419a7bbfd18ab8fed1abd3a41dec11e8d97 Author: Behdad Esfahbod Date: Thu Jun 26 19:13:34 2014 -0400 Minor: Use template parameter default values for OffsetTo src/hb-open-type-private.hh | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) commit 546b1adcdce2d3592843938b0b81ff32e67b0b83 Author: Behdad Esfahbod Date: Thu Jun 26 19:10:21 2014 -0400 Minor: Use template parameter default values for hb_prealloced_array_t src/hb-private.hh | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) commit 911ca38645bd51764e7859bc482319e8f6d2f710 Author: Behdad Esfahbod Date: Tue Jun 24 10:20:36 2014 -0600 Add back API removed recently Add hb_ot_layout_language_get_required_feature_index() again, which is used in Pango. This was removed in da132937989acb4d8ca9bd41c79f98750e7dda30 in favor of hb_ot_layout_language_get_required_feature(). API changes: - Added hb_ot_layout_language_get_required_feature_index back. src/hb-ot-layout.cc | 15 +++++++++++++++ src/hb-ot-layout.h | 7 +++++++ 2 files changed, 22 insertions(+) commit 89e4946929a8cd2359c7d76fa9272d5604243002 Author: Behdad Esfahbod Date: Sun Jun 22 11:32:13 2014 -0600 Add new IndicSyllabicCategory short forms for Unicode 7.0 src/gen-indic-table.py | 4 ++++ 1 file changed, 4 insertions(+) commit dcee838e89c2863c2fda4e8f098e720637e02335 Author: Behdad Esfahbod Date: Sun Jun 22 11:29:59 2014 -0600 Minor src/gen-arabic-table.py | 2 +- src/gen-indic-table.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit f2ad86e6053fa87ab188c36edc3d98c92324c049 Author: Behdad Esfahbod Date: Sat Jun 21 15:31:10 2014 -0600 [indic-table-gen] Minor src/gen-indic-table.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 2ec62279aab8c2263f17ffbc7c6f74304674f9a8 Author: Behdad Esfahbod Date: Sat Jun 21 15:25:59 2014 -0600 [indic-table] Update to Unicode 6.3.0 Was from 6.2.0. It's a no-op. Committing for the record. src/hb-ot-shape-complex-indic-table.cc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit 5d4d7384efa97a30893ad28b9ad9a994722de12c Author: Behdad Esfahbod Date: Sat Jun 21 14:53:21 2014 -0600 Minor: format src/hb-ot-shape-complex-arabic.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) commit 44243ae5902cc420e6bf6ec2fca2584ba93ff2fb Author: Behdad Esfahbod Date: Sat Jun 21 14:19:34 2014 -0600 [arabic-table] Update to Unicode 7.0 Old table was from 6.2. Remove hard-coded Mongolian and Phags-pa data. This completes support for new scripts Manichian and Psaltar Pahlavi. src/hb-ot-shape-complex-arabic-table.hh | 72 ++++++++++++++++++++++++++++----- src/hb-ot-shape-complex-arabic.cc | 22 ---------- 2 files changed, 63 insertions(+), 31 deletions(-) commit cd86ab9b4f4d7bd4f563be64a83714fc8fb395d7 Author: Behdad Esfahbod Date: Sat Jun 21 14:10:38 2014 -0600 [arabic-table] Add ZWJ/ZWNJ now that table is segmented src/gen-arabic-table.py | 2 -- src/hb-ot-shape-complex-arabic-table.hh | 12 +++++++++++- src/hb-ot-shape-complex-arabic.cc | 5 ----- 3 files changed, 11 insertions(+), 8 deletions(-) commit 2390d9b67e1dfeccd3f0850d1304c52b54817ca0 Author: Behdad Esfahbod Date: Sat Jun 21 14:07:00 2014 -0600 [arabic-table] Further tune In anticipation of Unicode 7.0 data coming in the next commit. src/gen-arabic-table.py | 10 ++++++--- src/hb-ot-shape-complex-arabic-table.hh | 38 +++++++++++++++------------------ 2 files changed, 24 insertions(+), 24 deletions(-) commit a133e6067aaebc494c0156b5fac7f4a879e12dbe Author: Behdad Esfahbod Date: Fri Jun 20 18:01:34 2014 -0400 [indic-table] Minor src/gen-indic-table.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) commit b900fa2c8cc088dbcbdbf90bfdf8764f9ee1c96a Author: Behdad Esfahbod Date: Fri Jun 20 17:59:43 2014 -0400 [arabic-table] Use segmented table No functional change. src/gen-arabic-table.py | 82 +++++++++++++++++++++++---------- src/hb-ot-shape-complex-arabic-table.hh | 53 ++++++++++++++------- src/hb-ot-shape-complex-arabic.cc | 8 ++-- 3 files changed, 97 insertions(+), 46 deletions(-) commit c2e113404640bf9b8bac469d0803ac946e77964f Author: Behdad Esfahbod Date: Fri Jun 20 17:57:03 2014 -0400 [indic-table] Make output stable src/gen-indic-table.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 55abfbd2ac1626af16151298a0837b837d0796df Author: Behdad Esfahbod Date: Fri Jun 20 16:47:43 2014 -0400 [indic-table] Minor No output change. src/gen-indic-table.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) commit f88670749006991282bcc4e8b6218487295ca670 Author: Behdad Esfahbod Date: Fri Jun 20 16:30:10 2014 -0400 [arabic-table] Don't write comments No functional change. src/gen-arabic-table.py | 20 +- src/hb-ot-shape-complex-arabic-table.hh | 710 ++------------------------------ 2 files changed, 38 insertions(+), 692 deletions(-) commit 200dfe3eb10feda2ad25940338b08011f4757ca4 Author: Behdad Esfahbod Date: Fri Jun 20 16:20:59 2014 -0400 [arabic-table] Use short names for values No functional change. src/gen-arabic-table.py | 16 +- src/hb-ot-shape-complex-arabic-table.hh | 1386 ++++++++++++++++--------------- 2 files changed, 716 insertions(+), 686 deletions(-) commit 3f5327a41efcf50f64d9498ef3dfd6875ef6a5ab Author: Behdad Esfahbod Date: Fri Jun 20 16:17:42 2014 -0400 [arabic-table] Read Blocks.txt and shuffle code around No functional change. src/Makefile.am | 2 +- src/gen-arabic-table.py | 80 +++++++++++++++++++-------------- src/hb-ot-shape-complex-arabic-table.hh | 30 ++++++++----- 3 files changed, 67 insertions(+), 45 deletions(-) commit 171f970e4f72d9fe1af30eab32b96906ee4a14f5 Author: Behdad Esfahbod Date: Fri Jun 20 15:25:30 2014 -0400 [indic-table] Black-list Thai, Lao, and Tibetan We don't need Indic table for those. src/gen-indic-table.py | 3 ++ src/hb-ot-shape-complex-indic-table.cc | 94 +++++++--------------------------- 2 files changed, 21 insertions(+), 76 deletions(-) commit 65ac2dae4f284f563b2dc476a21e2b5a48124de8 Author: Behdad Esfahbod Date: Fri Jun 20 15:12:49 2014 -0400 [indic-table] Speed up lookup src/gen-indic-table.py | 22 +++++++++--- src/hb-ot-shape-complex-indic-table.cc | 61 +++++++++++++++++++++++----------- 2 files changed, 59 insertions(+), 24 deletions(-) commit 64442a3f4c5c7be08893454742cad6bfe73cb8d7 Author: Behdad Esfahbod Date: Fri Jun 20 14:58:53 2014 -0400 [indic-table] Fix compiler warning src/gen-indic-table.py | 4 +--- src/hb-ot-shape-complex-indic-table.cc | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) commit 0436e1d50527497ebe5053b51a34ce6590276249 Author: Behdad Esfahbod Date: Fri Jun 20 14:56:22 2014 -0400 [indic-table] Make table more compact by not covering full blocks -#define indic_offset_total 4416 +#define indic_offset_total 3816 -}; /* Table occupancy: 60% */ +}; /* Table occupancy: 69% */ src/gen-indic-table.py | 24 ++++-- src/hb-ot-shape-complex-indic-table.cc | 150 +++++++++------------------------ 2 files changed, 57 insertions(+), 117 deletions(-) commit 190a251479b3cfc68871ff1daf9a9d1abe3f86e6 Author: Behdad Esfahbod Date: Fri Jun 20 14:41:39 2014 -0400 [indic-table] Remove block range from data table No functional change. src/gen-indic-table.py | 4 +- src/hb-ot-shape-complex-indic-table.cc | 102 ++++++++++++++++----------------- 2 files changed, 54 insertions(+), 52 deletions(-) commit 2b051c6057920c564c13c5d6a3e6dca93446fa12 Author: Behdad Esfahbod Date: Fri Jun 20 14:09:57 2014 -0400 Rename HB_VERSION_CHECK and hb_version_check to "atleast" HB_VERSION_CHECK's comparison was originally written wrongly by mistake. When API tests were written, they were also written wrongly to pass given the wrong implementation... Sigh. Given the purpose of this API, there's no point in fixing it without renaming it. As such, rename. API changes: HB_VERSION_CHECK -> HB_VERSION_ATLEAST hb_version_check -> hb_version_atleast docs/reference/harfbuzz-sections.txt | 4 ++-- src/hb-common.cc | 10 +++++----- src/hb-version.h.in | 10 +++++----- test/api/test-version.c | 29 +++++++++++++++-------------- 4 files changed, 27 insertions(+), 26 deletions(-) commit cabfa538ed4b1355326fa8de05f7209dda1c1c7a Author: Behdad Esfahbod Date: Fri Jun 20 13:51:21 2014 -0400 Adjust unused doc symbols docs/reference/harfbuzz-sections.txt | 19 +++++++++++++++++-- src/hb-ot-shape.h | 21 ++++++++++----------- 2 files changed, 27 insertions(+), 13 deletions(-) commit da132937989acb4d8ca9bd41c79f98750e7dda30 Author: Jonathan Kew Date: Sun Apr 27 14:05:24 2014 +0100 Rework handling of requiredFeature to solve problem with rlig in arial.ttf from winxp https://bugzilla.mozilla.org/show_bug.cgi?id=986802 Fixes https://github.com/behdad/harfbuzz/pull/39 API Change: -hb_ot_layout_language_get_required_feature_index +hb_ot_layout_language_get_required_feature New API takes an extra pointer argument. Pass NULL in to get behavior of previous API. Reworked by behdad src/hb-ot-layout-gsubgpos-private.hh | 4 +-- src/hb-ot-layout.cc | 29 ++++++++++++--------- src/hb-ot-layout.h | 11 ++++---- src/hb-ot-map.cc | 50 ++++++++++++++++++++++++++---------- src/main.cc | 4 +-- 5 files changed, 64 insertions(+), 34 deletions(-) commit df554af99db390e42d378983bb3fcf583477a1d7 Author: Behdad Esfahbod Date: Thu Jun 19 15:39:18 2014 -0400 Rename search() to bsearch() and lsearch() Such that the complexity of the algorithm used is clear at call site. src/hb-open-type-private.hh | 4 ++-- src/hb-ot-cmap-table.hh | 14 +++++++------- src/hb-ot-layout-common-private.hh | 9 +++++---- 3 files changed, 14 insertions(+), 13 deletions(-) commit fb8cc86ff99c08064ac58a559bb66cc340693b92 Author: Behdad Esfahbod Date: Thu Jun 19 15:30:18 2014 -0400 Rename sort() to qsort() In an effort to make the algorithm used clear. src/hb-coretext.cc | 4 ++-- src/hb-ot-map.cc | 4 ++-- src/hb-private.hh | 8 ++++---- src/hb-uniscribe.cc | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) commit 577ca4814314c374824cac736996b9cdd4f9d11f Author: Behdad Esfahbod Date: Wed Jun 18 12:29:23 2014 -0400 [unicode7] Update list of Default_Ignorable codepoints src/hb-unicode-private.hh | 66 +++++++++++++++++++++-------------------------- 1 file changed, 30 insertions(+), 36 deletions(-) commit 7cfee3827636f0dff7df5c8975a4fadd1b4bfbd5 Author: Behdad Esfahbod Date: Mon Apr 28 15:09:30 2014 -0700 [unicode7] Route Manichaean and Psalter Pahlavi through Arabic shaper Still needs update to joining table to fully work. src/hb-ot-shape-complex-private.hh | 4 ++++ 1 file changed, 4 insertions(+) commit a4a7899cd93fb9d1bc2163a4bbabfa733ee5bd52 Author: Behdad Esfahbod Date: Mon Apr 28 15:06:42 2014 -0700 [unicode7] Mark right-to-left scripts src/hb-common.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit 62587bfc5178a447ef66d88eab7412a7efe84692 Author: Behdad Esfahbod Date: Mon Apr 28 15:07:21 2014 -0700 [unicode7] Declare Unicode 7 scripts src/hb-common.h | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) commit dc61294aa93d36d0c5d187d4a692560a7cb46444 Author: Behdad Esfahbod Date: Mon Apr 28 14:58:28 2014 -0700 [unicode7] Add missing ISO 15924 tags src/hb-common.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 7526373e70bc4c2e2072da36babf9399fcf483b8 Author: Behdad Esfahbod Date: Tue Jun 17 11:45:26 2014 -0400 [coretext] Remove unused var src/hb-coretext.cc | 2 -- 1 file changed, 2 deletions(-) commit 798e4185bc71b1a63528e6b0af236d4c964ec607 Author: Jonathan Kew Date: Tue Jun 10 13:10:30 2014 +0100 When zeroing mark widths for LTR, also adjust offset... ...so that they overstrike preceding glyph. https://github.com/behdad/harfbuzz/pull/43 src/hb-ot-shape.cc | 50 +++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 39 insertions(+), 11 deletions(-) commit 80f7405a5208f88b8615aa4ce4c54ffeb16f04f8 Author: Jonathan Kew Date: Tue Jun 10 13:10:02 2014 +0100 [Thai] set the correct general category on Nikhahit when decomposing Sara-Am. src/hb-ot-shape-complex-thai.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 1d634cbb4b0338e1c2841127a72c5fac3a2a5ca1 Author: Behdad Esfahbod Date: Fri Jun 6 17:55:02 2014 -0400 Fix base-position when 'pref' is NOT formed If pre-base reordering Ra is NOT formed (or formed and then broken up), we should consider that Ra as base. This is observable when there's a left matra or dotreph that positions before base. Now, it might be that we shouldn't do this if the Ra happend to form a below form. We can't quite deduce that right now... Micro test added. Also at: https://code.google.com/a/google.com/p/noto-alpha/issues/detail?id=186#c29 src/hb-ot-shape-complex-indic.cc | 28 +++++++++++++++++++-- test/shaping/fonts/sha1sum/MANIFEST | 5 ++++ .../e207635780b42f898d58654b65098763e340f5c7.ttf | Bin 0 -> 3000 bytes test/shaping/tests/indic-pref-blocking.tests | 3 ++- 4 files changed, 33 insertions(+), 3 deletions(-) commit 04dc52fa15f5b7f9eb5f448ea43e7ef1b2269e88 Author: Behdad Esfahbod Date: Fri Jun 6 17:28:38 2014 -0400 [indic] Recover OT_H undergone ligation and multiplication Sometimes font designers form half/pref/etc consonant forms unconditionally and then undo that conditionally. Try to recover the OT_H classification in those cases. No test number changes expected. src/hb-ot-layout-private.hh | 8 ++++++++ src/hb-ot-shape-complex-indic.cc | 21 +++++++++++++++++++++ 2 files changed, 29 insertions(+) commit 39c8201f8e361e8c0f23f07bf20124ccadc6086c Author: Behdad Esfahbod Date: Fri Jun 6 17:19:35 2014 -0400 [indic] Improve base re-finding No test numbers change. src/hb-ot-shape-complex-indic.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit c04d5f0dd24d0ed9560fb9aebb5561ce946743c3 Author: Behdad Esfahbod Date: Fri Jun 6 17:02:39 2014 -0400 [indic] Minor src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 824d00dce483d0f4030c0cac253f994810e10f32 Author: Behdad Esfahbod Date: Mon Jun 9 14:17:33 2014 -0400 Fix commit 3f38c1137b6219a646da141b08463ffa922d4e35 Previous commit was not compiling with clang. configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 3f38c1137b6219a646da141b08463ffa922d4e35 Author: Behdad Esfahbod Date: Fri Jun 6 16:03:40 2014 -0400 Don't use -mstructure-size-boundary=8 on clang arm As in building for Android / iPhone. Only set it if struct{char} alignment is not 1. NOT tested on an actual Arm architecture. Guess we'll know when this makes it to people's build bots. configure.ac | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) commit 0ff74b09d2ccf7a9ea0f0b463d8b6d819c86c837 Author: Behdad Esfahbod Date: Thu Jun 5 21:55:23 2014 -0400 Add missing test file. Oops test/shaping/tests/indic-pref-blocking.tests | 1 + 1 file changed, 1 insertion(+) commit 832a6f99b34f334b1e82b8e3a7ad137e823d203c Author: Behdad Esfahbod Date: Wed Jun 4 16:57:42 2014 -0400 [indic] Don't reorder reph/pref if ligature was expanded Normally if you want to, say, conditionally prevent a 'pref', you would use blocking contextual matching. Some designers instead form the 'pref' form, then undo it in context. To detect that we now also remember glyphs that went through MultipleSubst. In the only place that this is used, Uniscribe seems to only care about the "last" transformation between Ligature and Multiple substitions. Ie. if you ligate, expand, and ligate again, it moves the pref, but if you ligate and expand it doesn't. That's why we clear the MULTIPLIED bit when setting LIGATED. Micro-test added. Test: U+0D2F,0D4D,0D30 with font from: [1] https://code.google.com/a/google.com/p/noto-alpha/issues/detail?id=186#c29 src/hb-ot-layout-gsub-table.hh | 2 +- src/hb-ot-layout-gsubgpos-private.hh | 20 ++++++++++++++++---- src/hb-ot-layout-private.hh | 16 +++++++++++++++- src/hb-ot-shape-complex-indic.cc | 4 ++-- test/shaping/Makefile.am | 5 ++++- .../226bc2deab3846f1a682085f70c67d0421014144.ttf | Bin 0 -> 2828 bytes test/shaping/tests/MANIFEST | 1 + 7 files changed, 39 insertions(+), 9 deletions(-) commit b5be2317201774c84470167767ad83c8637cad5b Author: Behdad Esfahbod Date: Thu Jun 5 19:00:22 2014 -0400 [gsub] Adjust single-length ligature subst to act like single subst src/hb-ot-layout-gsub-table.hh | 8 ++++++++ 1 file changed, 8 insertions(+) commit aae69451dfbf2e3671c555c234f788c194302818 Author: Behdad Esfahbod Date: Thu Jun 5 18:54:44 2014 -0400 [gsub] Minor shuffling src/hb-ot-layout-gsub-table.hh | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) commit b6b304f12be917b7449b3ac9409069fcd4a27d95 Author: Behdad Esfahbod Date: Thu Jun 5 17:12:54 2014 -0400 [ot] Add TODO re zero-len MultipleSubst sequences src/hb-ot-layout-gsub-table.hh | 9 +++++++++ src/hb-ot-layout-gsubgpos-private.hh | 4 +++- 2 files changed, 12 insertions(+), 1 deletion(-) commit f1a72fe7bf863535ec09b559cc0bd878fd0799f2 Author: Behdad Esfahbod Date: Wed Jun 4 19:00:29 2014 -0400 [ot-font] Fix cmap EncodingRecord cmp order src/hb-ot-cmap-table.hh | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) commit ce34f0b07e5324ed52e6e2c43000c2b09ee010d4 Author: Behdad Esfahbod Date: Wed Jun 4 18:57:46 2014 -0400 [ot-font] Use binary search for format12 cmap subtable src/hb-open-type-private.hh | 4 ++++ src/hb-ot-cmap-table.hh | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) commit 257d1adfa1b3422c511c55e641840a6e31ec6008 Author: Behdad Esfahbod Date: Wed Jun 4 18:47:55 2014 -0400 [ot-font] Work around broken cmap subtable format 4 length Roboto was hitting this. FreeType also has pretty much the same code for this, in ttcmap.c:tt_cmap4_validate(): /* in certain fonts, the `length' field is invalid and goes */ /* out of bound. We try to correct this here... */ if ( table + length > valid->limit ) { if ( valid->level >= FT_VALIDATE_TIGHT ) FT_INVALID_TOO_SHORT; length = (FT_UInt)( valid->limit - table ); } src/hb-ot-cmap-table.hh | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) commit 51f563579b94e1ee23ced9bbcc7dd3341535ce72 Author: Behdad Esfahbod Date: Wed Jun 4 18:42:32 2014 -0400 Move try_set to sanitize context src/hb-open-type-private.hh | 22 ++++++++++------------ src/hb-ot-layout-common-private.hh | 2 +- 2 files changed, 11 insertions(+), 13 deletions(-) commit 500737e8e16dce5248aff394899bb3761a9c3bbf Author: Behdad Esfahbod Date: Wed Jun 4 18:17:29 2014 -0400 [ot-font] Don't select a Null cmap subtable Can happen either in broken fonts, or as a result of sanitize(). src/hb-ot-cmap-table.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dac86026a6bae5a8a03cfe885bf93f32e5f48614 Author: Behdad Esfahbod Date: Tue Jun 3 17:57:00 2014 -0400 Fix some cppcheck warnings Bug 77800 - cppcheck reports src/hb-common.cc | 4 +++- src/hb-ot-layout-common-private.hh | 2 +- src/hb-private.hh | 2 +- src/hb-shape-plan.cc | 4 ++-- 4 files changed, 7 insertions(+), 5 deletions(-) commit c306410cab368a27c1941a2625d3b475edeaac04 Author: Behdad Esfahbod Date: Tue Jun 3 16:59:41 2014 -0400 Bug 77732 - Fix unused typedef warning for ASSERT_STATIC with GCC 4.8 src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ae2b854eab7f1c48e56751c987a714c2c18d6eb6 Author: Behdad Esfahbod Date: Tue Jun 3 16:59:09 2014 -0400 Move code around src/hb-private.hh | 134 ++++++++++++++++++++++++++---------------------------- 1 file changed, 65 insertions(+), 69 deletions(-) commit 17c3b809f42aec34d83dba2e6229ad85804bebae Author: Behdad Esfahbod Date: Mon Jun 2 15:08:18 2014 -0400 [indic] Treat U+A8E0..A8F1 as OT_A instead of OT_VD Apparently they can intermix with other OT_A. Test: U+0915,A8E2,1CD0 src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6ae13f257c3986517c097fa666ab9f58bdc918b5 Author: Behdad Esfahbod Date: Fri May 30 17:38:14 2014 -0400 [graphite2] Fix cluster mapping Patch from Martin Hosken. I expect this to fix the following bugs: https://bugs.freedesktop.org/show_bug.cgi?id=75076 https://bugzilla.gnome.org/show_bug.cgi?id=723582 https://bugzilla.redhat.com/show_bug.cgi?id=998812 src/hb-graphite2.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 5875ad9c467b39d00ad4d98fd425179c701e6fd0 Author: Behdad Esfahbod Date: Thu May 29 15:48:16 2014 -0400 0.9.29 NEWS | 12 ++++++++++++ configure.ac | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) commit 7977ca17aac34b9ab10622928bed8afa2177f16a Author: Behdad Esfahbod Date: Thu May 29 15:34:26 2014 -0400 [indic] Allow decimal and Brahmi digits as placeholders Tests: U+0967,0951 U+0031,093F src/hb-ot-shape-complex-indic.cc | 4 ++++ .../texts/in-tree/shaper-indic/indic/script-devanagari/misc/misc.txt | 2 ++ 2 files changed, 6 insertions(+) commit e8b5d64039614ecce472eda1a7a603736da25d86 Author: Behdad Esfahbod Date: Thu May 29 15:18:27 2014 -0400 [indic] Do NOT allow reph formation on placeholders Only allow it on DOTTED CIRCLE. No effect on test numbers. Test: U+0930,094D,00A0 src/hb-ot-shape-complex-indic-machine.rl | 2 +- .../in-tree/shaper-indic/indic/script-devanagari/misc/dottedcircle.txt | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) commit 52b562a6a058131c0103aaa5404d053e6465bb23 Author: Behdad Esfahbod Date: Tue May 27 18:18:23 2014 -0400 [indic] Clean up a bit No functional change intended. src/hb-ot-shape-complex-indic.cc | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) commit 3bf652b90783e8244c153739585d95dc4162efb4 Author: Behdad Esfahbod Date: Tue May 27 18:07:26 2014 -0400 [indic] Treat U+002D and U+2010..2014 as placeholders src/hb-ot-shape-complex-indic.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit e0de95f40244924cb8f9f7abca7f53117044a0eb Author: Behdad Esfahbod Date: Tue May 27 17:58:34 2014 -0400 [indic] Treat U+00D7 MULTIPLICATION SIGN as placeholder src/hb-ot-shape-complex-indic.cc | 1 + 1 file changed, 1 insertion(+) commit cf78dd483cbe1759a8ecb731879e041a53ba9bb3 Author: Behdad Esfahbod Date: Tue May 27 17:53:37 2014 -0400 [indic/myanmar] Rename OT_NBSP to OT_PLACEHOLDER src/hb-ot-shape-complex-indic-machine.rl | 4 ++-- src/hb-ot-shape-complex-indic-private.hh | 6 +++--- src/hb-ot-shape-complex-indic.cc | 4 ++-- src/hb-ot-shape-complex-myanmar.cc | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) commit 186ece94c8838e95db240d3e7c3ce415da6be81e Author: Behdad Esfahbod Date: Tue May 27 17:49:45 2014 -0400 [myanmar] Use OT_NBSP instead of OT_DOTTEDCIRCLE for OT_GB No functional change. src/hb-ot-shape-complex-myanmar-machine.rl | 2 +- src/hb-ot-shape-complex-myanmar.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit cf71d28c380819cb0f7f0f22f6ff9e4aa881a2b8 Author: Behdad Esfahbod Date: Tue May 27 17:47:43 2014 -0400 [indic/myanmar] Refactor a few macros src/hb-ot-shape-complex-indic-private.hh | 12 ++++++++++++ src/hb-ot-shape-complex-indic.cc | 10 ---------- src/hb-ot-shape-complex-myanmar.cc | 6 ------ 3 files changed, 12 insertions(+), 16 deletions(-) commit 2307268e01d27a999b56a2f573dfcee8b2a7949b Author: Behdad Esfahbod Date: Tue May 27 17:39:01 2014 -0400 [indic] Treat U+0A72..0A73 like regular consonants Unicode 6.x IndicSyllableCategory categorizes them as placeholders, but they can subjoin. src/hb-ot-shape-complex-indic.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit e9b2a4cfe593bdbe9288571635ba26ac42ede987 Author: Behdad Esfahbod Date: Fri May 23 15:49:10 2014 -0400 [indic] Support U+1CED src/hb-ot-shape-complex-indic.cc | 5 +++++ 1 file changed, 5 insertions(+) commit d19f8e85702a1e473efe2f02027984dcc127602a Author: Behdad Esfahbod Date: Fri May 23 15:45:50 2014 -0400 [indic] Support U+A8F2..A8F7,1CE9..1CEC,1CEE..1CF1 src/hb-ot-shape-complex-indic.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit ddbdfcbf1c10eed0a7b81b29fee99f1bd22113e5 Author: Behdad Esfahbod Date: Fri May 23 15:39:55 2014 -0400 [indic] Simplify grammar No functional change. src/hb-ot-shape-complex-indic-machine.rl | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) commit 4e9b1f662b23966e67c548b86afeff2bec9b0eb7 Author: Behdad Esfahbod Date: Fri May 23 15:38:42 2014 -0400 [indic] Always start new syllable for Avagraha In fact, the previous grammar was ambigious. No functional change. src/hb-ot-shape-complex-indic-machine.rl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9f9bd9bf31161660214b8b39a78cdafbb79db1be Author: Behdad Esfahbod Date: Fri May 23 15:33:13 2014 -0400 [indic] Rename avagraha cluster to symbol cluster In anticipation of adding more characters to that class of clusters. src/hb-ot-shape-complex-indic-machine.rl | 10 +++++----- src/hb-ot-shape-complex-indic-private.hh | 4 ++-- src/hb-ot-shape-complex-indic.cc | 14 +++++++------- 3 files changed, 14 insertions(+), 14 deletions(-) commit a498565cedf0441ae723c5e5969f637d792a15e7 Author: Behdad Esfahbod Date: Thu May 22 19:39:56 2014 -0400 [indic] Support U+1CF2,U+1CF3 src/hb-ot-shape-complex-indic.cc | 6 ++++++ 1 file changed, 6 insertions(+) commit ecb98babbaa065940b40ca8954a454f0e2cdcff0 Author: Behdad Esfahbod Date: Thu May 22 19:36:21 2014 -0400 [indic] Support U+1CE2..U+1CE8 src/hb-ot-shape-complex-indic.cc | 4 ++++ 1 file changed, 4 insertions(+) commit 37bf2c9224e32fdc99c20158c6dc0a4602ec1292 Author: Behdad Esfahbod Date: Thu May 22 19:35:17 2014 -0400 Minor src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 131e17ff9ae792cafa7a500043acb373802ee872 Author: Behdad Esfahbod Date: Thu May 22 19:32:51 2014 -0400 [indic] Support U+1CF5,1CF6 src/hb-ot-shape-complex-indic.cc | 3 +++ 1 file changed, 3 insertions(+) commit 72ead0cc72dac4d1c985ead065bb820f93f14a1d Author: Behdad Esfahbod Date: Thu May 22 19:12:10 2014 -0400 [indic] Treat U+1CE1 as a tone-mark too It's spacing, but otherwise the same as the other ones. src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e848bfae7c975a6fae434daf8e3db4d69914df9f Author: Behdad Esfahbod Date: Thu May 22 18:50:34 2014 -0400 [indic] Recategorize U+A8E0..A8F1 as OT_VD Up to two of them come after all OT_A characters. src/hb-ot-shape-complex-indic-machine.rl | 2 +- src/hb-ot-shape-complex-indic.cc | 10 ++++++---- 2 files changed, 7 insertions(+), 5 deletions(-) commit c519536c34c842304da558dd4a9e3844fc261b20 Author: Behdad Esfahbod Date: Thu May 22 18:43:14 2014 -0400 [indic] Allow up to three tone marks According to Roozbeh, there are valid combinations in Unicode proposals for up to three. Previously we were allowing up to two. src/hb-ot-shape-complex-indic-machine.rl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c11fc6833980fce6d70c5ae0c6623de97a3eb30a Author: Behdad Esfahbod Date: Thu May 22 18:41:49 2014 -0400 [indic] Support more extended Devanagari tone marks Also adjust U+0953,0954 handling. src/hb-ot-shape-complex-indic.cc | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) commit 26c836e53d55a2e2d4c17fd9ea1884eec33ce015 Author: Behdad Esfahbod Date: Wed May 21 18:35:48 2014 -0400 [indic] Handle "Cantillation marks for the Samaveda" src/hb-ot-shape-complex-indic.cc | 3 +++ 1 file changed, 3 insertions(+) commit 29531128f2f4342d537817746863705df80efe4b Author: Behdad Esfahbod Date: Thu May 15 14:04:02 2014 -0600 [indic] Improve reph formation of Sinhala and Telugu Sinhala and Telugu use "explicit" reph. That is, the reph is formed by a Ra,H,ZWJ sequence. Previously, upon detecting this sequence, we were checking checking whether the 'rphf' feature applies to the first two glyphs of the sequence. This is how the Microsoft fonts are designed. However, testing with Noto shows that apparently Uniscribe also forms the reph if the lookup ligates all three glyphs. So, try both sequences. Doesn't affect test results for Sinhala or Telugu. https://code.google.com/a/google.com/p/noto-alpha/issues/detail?id=232 src/hb-ot-shape-complex-indic.cc | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) commit 8c703f13bf8b4b276093b1c42cd3759e34b6787f Author: Oleg Oshmyan Date: Wed May 14 22:10:09 2014 +0100 Fix build with --coretext on older OS X Fixes https://github.com/behdad/harfbuzz/pull/40 src/hb-coretext.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 439b05867c0856a81fa8f9bea3a7465b4b4bdd91 Author: Behdad Esfahbod Date: Wed May 14 16:44:39 2014 -0600 [myanmar] Allow MedialYa+Asat in the grammar The grammar in the OT spec, and the existing Windows implementation seem to be confused around where to allow Asat around the medial consonants. The previous grammar for medial group was allowing an Asat after the medial group only if there was a medial Wa or Ha, but not if there was only a medial Ya. This doesn't make sense to me and sounds reversed, as both medial Wa and Ha are below marks while Asat is an above mark. An Asat can come before the medial group already (in fact, multiple ones can. Why?!). The medial Ya however is a spacing mark and according to Roozbeh it's valid to want an Asat on the medial Ya instead of the base, so it looks to me like we want to allow an Asat after the medial group if there *was* a Ya but not if there wasn't any. Not wanting to produce dotted-circle where Windows is not, this commit changes the grammar to allow one Asat after the medial group no matter what comes in the group. Test: U+1002,103A,103B vs U+1002,103B,103A src/hb-ot-shape-complex-myanmar-machine.rl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0a017ce169d791c9aea56671fe5837961e0a3c09 Author: Behdad Esfahbod Date: Wed May 14 16:44:16 2014 -0600 Add tests for Myanmar Asat+MedialYa and MedialYa+Asat sequences One of them currently produces dotted-circle. Fix and detailed message coming. test/shaping/texts/in-tree/shaper-myanmar/script-myanmar/misc/misc.txt | 2 ++ 1 file changed, 2 insertions(+) commit c95587618c88d187be64f923033dae151cf820be Author: Behdad Esfahbod Date: Wed May 14 00:42:18 2014 -0400 [ot] Minor note re cmap subtable format 2 and 8 src/hb-ot-cmap-table.hh | 2 ++ 1 file changed, 2 insertions(+) commit b7878cd58ea9a67236e1e0228c35b5b03ec4ff9c Author: Behdad Esfahbod Date: Tue May 13 21:47:51 2014 -0400 [ot] Implement cmap subtable format 0 src/hb-open-type-private.hh | 3 ++- src/hb-ot-cmap-table.hh | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+), 1 deletion(-) commit ca7b77431d1e0aaa803722be8be85a368a385f47 Author: Behdad Esfahbod Date: Tue May 13 21:26:34 2014 -0400 [ot] Factor out code between cmap sutable format 12 and 13 src/hb-ot-cmap-table.hh | 43 +++++++++++++------------------------------ 1 file changed, 13 insertions(+), 30 deletions(-) commit 94759e8219ed08392573bae948a8135e16b8e0d0 Author: Behdad Esfahbod Date: Tue May 13 21:17:28 2014 -0400 [ot] Factor out code between cmap subtable format 6 and 10 src/hb-ot-cmap-table.hh | 49 ++++++++++--------------------------------------- 1 file changed, 10 insertions(+), 39 deletions(-) commit 1a8ffc512987c1ff1b4896549f80b145c85454a8 Author: Behdad Esfahbod Date: Tue May 13 21:06:39 2014 -0400 Minor src/hb-blob.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 91bbfca87527fa14d6ebec86b087f2a989381872 Author: Behdad Esfahbod Date: Mon May 12 18:19:29 2014 -0400 [ot] Implement cmap subtable formats 6 and 10 src/hb-ot-cmap-table.hh | 77 +++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 74 insertions(+), 3 deletions(-) commit d294a2cb165c4f20daa5624969067c51eb9aef58 Author: Behdad Esfahbod Date: Mon May 12 17:58:31 2014 -0400 [ot] Implement cmap subtable format 13 src/hb-ot-cmap-table.hh | 47 +++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 41 insertions(+), 6 deletions(-) commit 0d75793fae95ed9f6b8522ae3af4fcdf397d8c36 Author: Behdad Esfahbod Date: Mon May 12 17:51:15 2014 -0400 [ot] Implement cmap subtable format 12 src/hb-ot-cmap-table.hh | 63 +++++++++++++++++++++++++++++++++++++++++++++++-- src/hb-ot-font.cc | 5 ++++ 2 files changed, 66 insertions(+), 2 deletions(-) commit 3608a6847e7b7eb4206df049158513a085810afd Author: Behdad Esfahbod Date: Mon May 12 13:46:29 2014 -0400 [ot] Hook up cmap table to hb_ot_font_funcs() src/hb-ot-cmap-table.hh | 10 +++++++--- src/hb-ot-font.cc | 33 +++++++++++++++++++-------------- 2 files changed, 26 insertions(+), 17 deletions(-) commit c8a47452993b9dee6854bfc866aca4a20142696f Author: Behdad Esfahbod Date: Fri May 9 19:55:51 2014 -0400 [ot] Implement cmap subtable format 4 src/hb-ot-cmap-table.hh | 52 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) commit 4719621f20dfd6a0377c650a7b4df223c18dc143 Author: Behdad Esfahbod Date: Fri May 9 16:09:11 2014 -0400 Minor src/hb-open-type-private.hh | 1 - 1 file changed, 1 deletion(-) commit 41ca1fbebf61cf26e1e0e4b11f4a5b52fb7d88a9 Author: Behdad Esfahbod Date: Fri May 9 15:35:56 2014 -0400 [ot] Start implementing cmap table src/Makefile.am | 1 + src/hb-ot-cmap-table.hh | 171 ++++++++++++++++++++++++++++++++++++++++++++++++ src/hb-ot-font.cc | 1 + 3 files changed, 173 insertions(+) commit c7074b8798048324cb8850c55908ce77fc33d11e Author: Behdad Esfahbod Date: Thu May 8 18:24:31 2014 -0400 [otlayout] Add GenericArrayOf::search() src/hb-open-type-private.hh | 11 +++++++++++ 1 file changed, 11 insertions(+) commit 40a479797add42fa42b78d4267920ef75bfb6b9a Author: Behdad Esfahbod Date: Thu May 8 18:21:04 2014 -0400 [otlayout] Add GenericSortedArrayOf src/hb-open-type-private.hh | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) commit 0ddecabc6de205b121bec31fbf670f37cc9454ef Author: Behdad Esfahbod Date: Thu May 1 16:01:40 2014 -0700 [main] Minor improvement to output src/main.cc | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) commit 79ecdc3f9525212053d2bc88a5541c41697159da Author: Behdad Esfahbod Date: Mon Apr 28 14:24:23 2014 -0700 0.9.28 NEWS | 13 +++++++++++++ configure.ac | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) commit 6faff8e4132197ba06f0e685b82efe35b546cf64 Author: Behdad Esfahbod Date: Mon Apr 28 14:29:39 2014 -0700 Add static storage classifier to inline functions Before we were just relying on the compiler inlining them and not leaving a trace in our public API. Try to fix. Hopefully not breaking anyone's build. src/hb-open-type-private.hh | 22 +++++++++++----------- src/hb-ot-layout-gpos-table.hh | 4 ++-- src/hb-ot-layout-gsub-table.hh | 6 +++--- src/hb-ot-layout-private.hh | 36 ++++++++++++++++++------------------ src/hb-ot-map-private.hh | 10 +++++----- src/hb-private.hh | 2 +- 6 files changed, 40 insertions(+), 40 deletions(-) commit 9c9411839bb89d0a1a83120af0982c60e0e393d9 Author: Behdad Esfahbod Date: Mon Apr 28 12:38:25 2014 -0700 [tibetan] Reorder PADMA sign to occur after other below marks Based on suggestion from Andrew Glass. Test: U+0F40,0FC6,0F83 src/hb-unicode-private.hh | 4 ++++ 1 file changed, 4 insertions(+) commit 659cd3c5b470ff9724ce5e53fedd1fea3e7512c4 Author: Behdad Esfahbod Date: Mon Apr 28 12:43:42 2014 -0700 [test] Add test case for Tibetan sign PADMA Currently fails. test/shaping/texts/in-tree/shaper-tibetan/script-tibetan/misc/misc.txt | 1 + 1 file changed, 1 insertion(+) commit ee703bc3ef740c300718fca7a12c050c322dce19 Author: Behdad Esfahbod Date: Mon Apr 28 12:43:18 2014 -0700 Reshuffle test data test/shaping/texts/in-tree/MANIFEST | 3 +++ test/shaping/texts/in-tree/shaper-default/MANIFEST | 3 --- .../in-tree/{shaper-default => shaper-hangul}/script-hangul/MANIFEST | 0 .../{shaper-default => shaper-hangul}/script-hangul/misc/MANIFEST | 0 .../{shaper-default => shaper-hangul}/script-hangul/misc/misc.txt | 0 .../in-tree/{shaper-default => shaper-hebrew}/script-hebrew/MANIFEST | 0 .../{shaper-default => shaper-hebrew}/script-hebrew/misc/MANIFEST | 0 .../script-hebrew/misc/diacritics.txt | 0 .../in-tree/{shaper-default => shaper-tibetan}/script-tibetan/MANIFEST | 0 .../{shaper-default => shaper-tibetan}/script-tibetan/misc/MANIFEST | 0 .../{shaper-default => shaper-tibetan}/script-tibetan/misc/misc.txt | 0 11 files changed, 3 insertions(+), 3 deletions(-) commit b082ef373cefb35dd98b5f2f0b677ccc7806f51e Author: Behdad Esfahbod Date: Fri Apr 25 11:48:10 2014 -0700 Typo src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 828e109c7aac3389cc3b89ea1f13388aefb63804 Author: Behdad Esfahbod Date: Fri Apr 18 16:53:34 2014 -0700 [indic] Fix-up zero-context matching commit b5a0f69e47ace468b06e21cf069a18ddcfcf6064 Author: Behdad Esfahbod Date: Thu Oct 17 18:04:23 2013 +0200 [indic] Pass zero-context=false to would_substitute for newer scripts For scripts without an old/new spec distinction, use zero-context=false. This changes behavior in Sinhala / Khmer, but doesn't seem to regress. This will be useful and used in Javanese. The *intention* was to change zero-context from true to false for scripts that don't have old-vs-new specs. However, checking the code, looks like we essentially change zero-context to always be true; ie. we only changed things for old-spec, and we broke them. That's what causes this bug: https://bugs.freedesktop.org/show_bug.cgi?id=76705 The root of the bug is here: /* Use zero-context would_substitute() matching for new-spec of the main * Indic scripts, but not for old-spec or scripts with one spec only. */ bool zero_context = indic_plan->config->has_old_spec || !indic_plan->is_old_spec; Note that is_old_spec itself is: indic_plan->is_old_spec = indic_plan->config->has_old_spec && ((plan->map.chosen_script[0] & 0x000000FF) != '2'); It's easy to show that zero_context is now always true. What we really meant was: bool zero_context = indic_plan->config->has_old_spec && !indic_plan->is_old_spec; Ie, "&&" instead of "||". We made this change supposedly to make Javanese work. But apparently we got it working regardless! So I'm going to fix this to only change the logic for old-spec and not touch other cases. src/hb-ot-shape-complex-indic.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 66c6a48b6ce9dab6375ba1a23d7e450d6974852a Author: Behdad Esfahbod Date: Mon Apr 14 15:55:42 2014 -0700 Add HB_NO_MERGE_CLUSTERS Disables any cluster-merging. Added for testing purposes while we investigate what kind of API to add for this. src/hb-buffer.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit 897c7b804d6817470a364ba31b1719555b12f751 Author: Behdad Esfahbod Date: Thu Apr 10 16:27:13 2014 -0700 Add Khmer test for U+17DD .../shaper-indic/south-east-asian/script-khmer/misc/other-marks.txt | 1 + 1 file changed, 1 insertion(+) commit 50a00535ccac538bbf93358fd2d2442e4c12542f Author: Behdad Esfahbod Date: Thu Apr 10 16:03:29 2014 -0700 Require gobject-introspection 1.34.0 Fixes https://bugs.freedesktop.org/show_bug.cgi?id=75384 configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5fd996c4a4049a75c6d9e964f1a81c00ff191893 Author: Behdad Esfahbod Date: Wed Apr 9 16:38:26 2014 -0700 Further adjust check-defs and check-symbols for mipsel Fixes https://bugs.freedesktop.org/show_bug.cgi?id=74491 src/check-defs.sh | 2 +- src/check-symbols.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 75ec6d0bc5ca0170c73e4d1099a898d38d8f85c0 Author: Behdad Esfahbod Date: Wed Apr 9 16:33:32 2014 -0700 Tighten up check-static-inits.sh check Fixes https://bugs.freedesktop.org/show_bug.cgi?id=74490 src/check-static-inits.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 110ec0714a11b9417eed82f7d25b85c9dc7b6df4 Author: Behdad Esfahbod Date: Tue Apr 8 17:32:08 2014 -0700 Typo src/hb-blob.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0682ddd05c22a400ff5ce97d4ea4b52a18b845ae Author: Behdad Esfahbod Date: Tue Apr 8 16:03:35 2014 -0700 [indic] Support U+17DD KHMER SIGN ATTHACAN As requested by Martin Hosken on the list. src/hb-ot-shape-complex-indic.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 05870ed62edd8728d6d732f60d6b7e149d45e6f4 Author: Primiano Tucci Date: Wed Apr 2 11:35:27 2014 +0100 Use __aarch64__ for 64-bit ARM detection, not __arm64__ Many GCC versions don't define __arm64__ src/hb-atomic-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 04d894e89795041b2055dc172744a018644f2bca Author: Behdad Esfahbod Date: Tue Mar 25 12:11:32 2014 -0700 Minor src/hb-ot-layout-gsubgpos-private.hh | 1 + 1 file changed, 1 insertion(+) commit 903648437c180c7b039801cdb0672e0f8e14afd4 Author: Behdad Esfahbod Date: Mon Mar 24 14:26:36 2014 -0700 Start fleshing out builtin font functions src/Makefile.am | 3 +- src/hb-glib.cc | 2 +- src/hb-icu.cc | 2 +- src/hb-ot-font.cc | 260 ++++++++++++++++++++++++++++++++++++ src/{hb-tt-font.cc => hb-ot-font.h} | 56 ++------ src/hb-ot-hhea-table.hh | 2 +- src/hb-ot-hmtx-table.hh | 2 +- src/hb-ot.h | 1 + util/Makefile.am | 4 +- util/options.cc | 4 + 10 files changed, 283 insertions(+), 53 deletions(-) commit 343a0e4e747d93eeeb724c5d585f5ba036a0df84 Author: Behdad Esfahbod Date: Fri Mar 21 14:37:27 2014 -0700 Add "make built-sources" src/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit e9853f33d1f53d4d69ee0fa340ce9225a5ed17ca Author: Behdad Esfahbod Date: Fri Mar 21 12:53:08 2014 -0700 One more fix for build without gtk-doc Fixes https://github.com/behdad/harfbuzz/pull/35 autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b96af03c20e46105982b3608b608614403540661 Author: Konstantin Ritt Date: Thu Mar 20 16:01:30 2014 +0200 Fix build with --coretext on iOS On iOS CoreText and CoreGraphics are stand-alone frameworks configure.ac | 23 +++++++++++++++++++---- src/hb-coretext.h | 8 +++++++- 2 files changed, 26 insertions(+), 5 deletions(-) commit ea5e8a02eb83ad19f3009b0008893f77ce113118 Author: Behdad Esfahbod Date: Wed Mar 19 15:38:02 2014 -0700 [util] Plug minor leak util/hb-shape.cc | 6 +++--- util/helper-cairo.cc | 21 ++++++++++++--------- util/helper-cairo.hh | 2 +- util/options.cc | 6 +++++- util/options.hh | 6 +++--- 5 files changed, 24 insertions(+), 17 deletions(-) commit 09732cc6695b8e41ba6cdcd4058a4f7cad90167a Author: Behdad Esfahbod Date: Wed Mar 19 12:00:17 2014 -0700 Remove dead warning src/hb-unicode.cc | 9 +++++++-- src/hb-warning.cc | 11 ----------- 2 files changed, 7 insertions(+), 13 deletions(-) commit b934b0f9d1b39fc7a06c812bea3d79ca5424e278 Author: Behdad Esfahbod Date: Wed Mar 19 11:52:40 2014 -0700 Yet another try to make build without gtk-doc succeed autogen.sh | 1 + docs/reference/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) commit a7a5be090dd9cc39605853e8994eb417550939d4 Author: Behdad Esfahbod Date: Wed Mar 19 11:39:23 2014 -0700 Another try to make gtk-doc optional docs/reference/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ba8c9d92935ea351970a80d0d3441858ad4cf33f Author: Dominik Röttsches Date: Tue Mar 18 14:39:03 2014 +0200 0.9.27 NEWS | 16 ++++++++++++++++ configure.ac | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) commit a949cd329e49d2c0ad6f1e023f324790d886dafe Author: Behdad Esfahbod Date: Sun Mar 16 20:22:42 2014 -0700 Don't use "register" storage class specifier Fixes warnings. https://bugzilla.mozilla.org/show_bug.cgi?id=984081 src/hb-private.hh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 0082dbeae6c25a7859960b7e791a540ad04246d9 Author: jfkthame Date: Sun Mar 16 08:25:17 2014 +0000 wrap definition of free_langs() with HAVE_ATEXIT ...to avoid an unused function warning; see mozilla bug https://bugzilla.mozilla.org/show_bug.cgi?id=984081. src/hb-common.cc | 2 ++ 1 file changed, 2 insertions(+) commit a9e25e90a4ca05746fda4a598ad698db1d2c5c1a Author: Behdad Esfahbod Date: Fri Mar 14 19:55:46 2014 -0700 [coretext] Add hb_coretext_face_create() Not tested. src/hb-coretext.cc | 57 +++++++++++++++++++++++++++++++++++++++++++++--------- src/hb-coretext.h | 4 ++++ 2 files changed, 52 insertions(+), 9 deletions(-) commit c79865f90f62309dc64c8d3f2f503ec2aa4b7ec1 Author: Behdad Esfahbod Date: Fri Mar 14 19:37:55 2014 -0400 [coretext] Add coretext_aat shaper This is a higher-priority shaper than default shaper ("ot"), but only picks up fonts that have AAT "morx"/"mort" table. Note that for this to work the font face's get_table() implementation should know how to return the full font blob. Based on patch from Konstantin Ritt. src/hb-coretext.cc | 94 +++++++++++++++++++++++++++++++++++++++++++++++++++ src/hb-coretext.h | 4 +++ src/hb-shaper-list.hh | 4 +++ 3 files changed, 102 insertions(+) commit af1aa362cacc652ab8ffda05a5d98a3ff5430439 Author: Behdad Esfahbod Date: Fri Mar 14 15:52:47 2014 -0700 If HAVE_ICU_BUILTIN is defined, use hb-icu Unicode callbacks Useful for Android / Chrome / etc when ICU is built in the same library as harfbuzz itself. src/hb-unicode.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 853daf857f231c9ce0277a78abff1241150ea903 Author: Behdad Esfahbod Date: Fri Mar 14 15:49:18 2014 -0700 Remove old cruft src/hb-shaper-list.hh | 6 ------ 1 file changed, 6 deletions(-) commit 2a473338da1538efa4ff14ae9e4aba8dd50f9b0f Author: Behdad Esfahbod Date: Mon Mar 10 15:04:46 2014 -0700 Add Myanmar test case from OpenType Myanmar spec test/shaping/texts/in-tree/shaper-myanmar/script-myanmar/misc/MANIFEST | 1 + .../shaping/texts/in-tree/shaper-myanmar/script-myanmar/misc/otspec.txt | 2 ++ 2 files changed, 3 insertions(+) commit 158985908981189a2fd4d15275a641286fc770fe Author: Behdad Esfahbod Date: Mon Mar 10 14:57:55 2014 -0700 Minor test/shaping/texts/in-tree/shaper-myanmar/script-myanmar/misc/MANIFEST | 1 - test/shaping/texts/in-tree/shaper-sea/script-tai-tham/misc/MANIFEST | 1 + .../script-myanmar => shaper-sea/script-tai-tham}/misc/torture.txt | 0 3 files changed, 1 insertion(+), 1 deletion(-) commit bb8ffb581b89cf27fb8e0743b81bbda21654233e Author: Behdad Esfahbod Date: Tue Mar 4 13:03:51 2014 -0800 Use AM_MISSING_PROG for ragel and git Makefile.am | 4 ++-- configure.ac | 2 ++ src/Makefile.am | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) commit a82165248cddb720576464b8e59a986491d3f2e9 Author: Behdad Esfahbod Date: Tue Feb 18 15:53:56 2014 -0500 Only do fallback Hebrew composition if no GPOS 'mark' available Apparently some modern fonts have proper GPOS mark positioning tables, but undesirable precomposed forms! See thread "Hebrew composition to presentation forms" and: http://tex.stackexchange.com/questions/156775/having-trouble-with-vowel-positioning-in-ezra-sil-xelatex Test case: U+fb1d,05d9,05b4 src/hb-ot-shape-complex-hebrew.cc | 2 +- src/hb-ot-shape-private.hh | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) commit b456d42bf68c4374f71f09867e375a51c7f2b3ed Author: Behdad Esfahbod Date: Tue Feb 11 17:29:40 2014 -0500 Allow bootstrapping without gtk-doc Seems like configure.ac is already able to handle it. autogen.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit 1eacde00cc8c57a08fb74276e3530844ef463d67 Author: Luis de Bethencourt Date: Thu Feb 6 23:20:47 2014 -0500 check hb_set_is_emtpy in test-set.c test/api/test-set.c | 9 +++++++++ 1 file changed, 9 insertions(+) commit db068d81cda180a91638e5539984f8139aff49c6 Author: Werner Lemberg Date: Mon Feb 10 10:38:56 2014 -0500 typo in ucdn's Makefile.am src/hb-ucdn/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fbb2847f541389f40718af71c4945024ae177ab2 Author: Behdad Esfahbod Date: Wed Feb 5 08:22:06 2014 -0500 Improve MemoryBarrier() implementation See thread "[HarfBuzz] compilation error of 0.9.26 with MinGW" started by Werner. src/hb-atomic-private.hh | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) commit 189bf23bfc90405d8bdc70bf3d6d3ffec38b470c Author: Behdad Esfahbod Date: Thu Jan 30 15:14:58 2014 -0500 0.9.26 NEWS | 20 ++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 21 insertions(+), 1 deletion(-) commit 7691a154e50f8c8c77bbd94787686262955bf5d4 Author: Jonathan Kew Date: Wed Jan 29 14:07:58 2014 +0000 Ensure hb_script_t can safely hold any hb_tag_t value it's given. Fixes https://github.com/behdad/harfbuzz/pull/21 src/hb-common.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit c29993a181c2139eaec97b5f6225824040ca3ac9 Author: Behdad Esfahbod Date: Tue Jan 28 17:29:42 2014 -0500 [coretext] Handle surrogate pairs when generating notdef glyphs Fixes github.com/behdad/harfbuzz/pull/19 src/hb-coretext.cc | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) commit 748b2782e4898420003a3bbc041dcccbe9e3edc2 Author: Behdad Esfahbod Date: Tue Jan 28 17:10:05 2014 -0500 [coretext] Minor optimization src/hb-coretext.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 24e6b11f12788500182715a64d4771a22c5b7525 Author: Konstantin Ritt Date: Tue Jan 28 18:16:01 2014 +0200 Fix double destruction in case of OOM src/hb-graphite2.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 083225916a19f6d67017523af87386933bd9ecdc Author: Konstantin Ritt Date: Wed Jan 22 20:31:30 2014 +0200 Micro optimizations src/hb-ot-layout-gpos-table.hh | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) commit c9522de2335e4ef5fe65a72745c10943827a8da2 Author: Konstantin Ritt Date: Wed Jan 22 21:07:13 2014 +0200 Make it possible to disable the fallback shaper at configure time The OT shaper supersedes the fallback shaper in every case and the latter become an extra weight for 99.9% of users. configure.ac | 6 ++++++ src/Makefile.am | 5 ++++- src/hb-shaper-list.hh | 2 ++ 3 files changed, 12 insertions(+), 1 deletion(-) commit 6775da3a7c07db6c032cf429dc199d471948db56 Author: Behdad Esfahbod Date: Thu Jan 23 14:18:49 2014 -0500 Fix clang warning 'private field 'xxx' is not used Fixes https://github.com/behdad/harfbuzz/pull/16 src/hb-open-type-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 62299826f4905e080b9497bce335e093b287494e Author: Behdad Esfahbod Date: Thu Jan 23 14:11:03 2014 -0500 Fix typo in _hb_buffer_serialize_glyphs_text() Fixes https://github.com/behdad/harfbuzz/pull/17 src/hb-buffer-serialize.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ae23c24c32f474a34484ee78bc177ad31fa5e6d0 Author: Behdad Esfahbod Date: Wed Jan 22 11:03:02 2014 -0500 [arabic] Disable 'cswh' by default I believe Windows 8 disables it, and spec update dated Jan 2014 also clearly says it's disabled by default: http://www.microsoft.com/typography/OpenTypeDev/arabic/intro.htm#features src/hb-ot-shape-complex-arabic.cc | 1 - 1 file changed, 1 deletion(-) commit 08cf5d75ef0c75095173dec822ccb07defaaa6c2 Author: Behdad Esfahbod Date: Wed Jan 22 07:53:55 2014 -0500 [ot] Don't try to compose if normalization is off src/hb-ot-shape-normalize.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 0596343bfeb80ad6b19d459654edf7dfded6affe Merge: 62cb28df 83d7e791 Author: Behdad Esfahbod Date: Wed Jan 22 04:43:51 2014 -0800 Merge pull request #13 from jfkthame/hangul-shaper Tone-mark reordering and improved Old Hangul support commit 62cb28dfc668cae9cbff826229bde2271e157927 Author: Jonathan Kew Date: Mon Jan 20 14:23:08 2014 +0000 fixup for 64-bit windows build src/hb-uniscribe.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 83d7e7915a5eaa8ff4c7014c319844e7dffd8225 Author: Jonathan Kew Date: Mon Jan 20 19:49:47 2014 +0000 [hangul] Fix ordering of dotted circle with Hangul tone mark (reported by Dohyun Kim). src/hb-ot-shape-complex-hangul.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit deef1862657d55b7ae8d45f4eecbe45c80785c4e Author: Jonathan Kew Date: Mon Jan 20 10:38:27 2014 +0000 [hangul] Don't force zero-width for marks - this is not wanted for the Jamo Filler glyphs. src/hb-ot-shape-complex-hangul.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 391934db0a171aeb2057ebcd4a38ed81621e7393 Author: Jonathan Kew Date: Mon Jan 20 10:37:32 2014 +0000 [unicode] Exclude the Jamo Filler characters from Default_Ignorable, as some fonts want these to be visible/spacing glyphs. src/hb-unicode-private.hh | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) commit 7244b3fc3bf9757dd094709d36bea68682264e20 Author: Jonathan Kew Date: Mon Jan 20 10:35:51 2014 +0000 [hangul] Reorder Hangul tone mark to beginning of syllable, unless font implements it using a zero-width glyph. src/hb-ot-shape-complex-hangul.cc | 59 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 58 insertions(+), 1 deletion(-) commit 103436838df3a77552d3d33fc4bd80f09d9bf079 Author: Jonathan Kew Date: Mon Jan 20 10:35:07 2014 +0000 [hangul] Apply the appropriate *jmo features to decomposed syllables, including Old Hangul sequences that don't have Unicode compositions. Merge clusters in decomposed syllables. src/hb-ot-shape-complex-hangul.cc | 197 +++++++++++++++++++++++++++++++------- 1 file changed, 165 insertions(+), 32 deletions(-) commit 8fc1f7fe74a25bf8549f5edd79c7da6b720eb064 Author: Behdad Esfahbod Date: Thu Jan 2 17:04:04 2014 +0800 [ot/hangul] Don't decompose Hangul even when combining marks present As discussed on https://github.com/behdad/harfbuzz/pull/10#issuecomment-31442030 src/hb-ot-shape-complex-hangul.cc | 2 +- src/hb-ot-shape-normalize-private.hh | 1 + src/hb-ot-shape-normalize.cc | 24 +++++++++++++----------- 3 files changed, 15 insertions(+), 12 deletions(-) commit 64426ec73a987bfe1e71a293ee195f268897e8d6 Author: Behdad Esfahbod Date: Thu Jan 2 14:33:10 2014 +0800 [ot] Simplify composing Not tested. Ouch. src/hb-ot-shape-normalize.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 8de20b1e8a1c4d2081f64e695045e6e4da7ce144 Author: Behdad Esfahbod Date: Thu Jan 2 14:30:45 2014 +0800 Add font->has_glyph() src/hb-font-private.hh | 6 ++++++ src/hb-ot-shape-complex-hangul.cc | 14 ++++++-------- src/hb-ot-shape.cc | 3 +-- 3 files changed, 13 insertions(+), 10 deletions(-) commit f6298e55ae0f0f23f66935226f78afb98320ea78 Author: Behdad Esfahbod Date: Thu Jan 2 14:23:56 2014 +0800 [fallback] Minor src/hb-fallback-shape.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 29ea403d67e29c2d531c1f613ce3d69e60f078f6 Author: Behdad Esfahbod Date: Thu Jan 2 14:20:00 2014 +0800 [hangul] Fix decomposition logic Seems to be working now. src/hb-ot-shape-complex-hangul.cc | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) commit bdb20dafc3f737923da3dca0c832fdf4ab8daabc Author: Behdad Esfahbod Date: Thu Jan 2 14:04:30 2014 +0800 [hangul] Fix decomposition Part of https://github.com/behdad/harfbuzz/pull/10 src/hb-ot-shape-complex-hangul.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 32478656ce6e7926c3ad481511f02187ca743af6 Author: Behdad Esfahbod Date: Thu Jan 2 14:01:56 2014 +0800 [hangul] Tighten up character categories I had tried to expand to fill the blocks, but that sounds wrong in retrospect. src/hb-ot-shape-complex-hangul.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit f14bb7de631b20e2868fb62e5311cd0d9e24bb49 Author: Behdad Esfahbod Date: Tue Dec 31 16:49:15 2013 +0800 [ot] Separate out hebrew and tibetan shapers from default Now default shaper is truly no-op. src/Makefile.am | 2 + src/hb-ot-shape-complex-default.cc | 161 +--------------------------------- src/hb-ot-shape-complex-hebrew.cc | 172 +++++++++++++++++++++++++++++++++++++ src/hb-ot-shape-complex-private.hh | 17 +++- src/hb-ot-shape-complex-tibetan.cc | 61 +++++++++++++ 5 files changed, 251 insertions(+), 162 deletions(-) commit 6300cd72539284ca294ee8286bbbb7f9c72af320 Author: Behdad Esfahbod Date: Tue Dec 31 16:38:47 2013 +0800 [ot] Define HB_OT_SHAPE_ZERO_WIDTH_MARKS_DEFAULT src/hb-ot-shape-complex-default.cc | 2 +- src/hb-ot-shape-complex-hangul.cc | 2 +- src/hb-ot-shape-complex-private.hh | 4 +++- src/hb-ot-shape-complex-thai.cc | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) commit 3d6ca0d32e5c6597acfcf59301cb1905586ddb52 Author: Behdad Esfahbod Date: Tue Dec 31 16:04:35 2013 +0800 [ot] Simplify normalization_preference again No shaper has more than one behavior re this, so no need for a callback. src/hb-ot-shape-complex-arabic.cc | 2 +- src/hb-ot-shape-complex-default.cc | 8 +------- src/hb-ot-shape-complex-hangul.cc | 2 +- src/hb-ot-shape-complex-indic.cc | 8 +------- src/hb-ot-shape-complex-myanmar.cc | 9 +-------- src/hb-ot-shape-complex-private.hh | 7 +------ src/hb-ot-shape-complex-sea.cc | 9 +-------- src/hb-ot-shape-complex-thai.cc | 2 +- src/hb-ot-shape-normalize.cc | 4 +--- 9 files changed, 9 insertions(+), 42 deletions(-) commit c98b7183f7dc453d5bac1f2503017cded317a495 Author: Behdad Esfahbod Date: Tue Dec 31 15:55:40 2013 +0800 [ot] Add Hangul shaper Not exhaustively tested, but I think I got the intended logic right. The logic can perhaps be simplified. Maybe we should disabled normalization with this shaper. Then again, for now focusing on correctness. src/Makefile.am | 1 + src/hb-ot-shape-complex-default.cc | 13 --- src/hb-ot-shape-complex-hangul.cc | 232 +++++++++++++++++++++++++++++++++++++ src/hb-ot-shape-complex-private.hh | 10 +- src/hb-private.hh | 6 + 5 files changed, 240 insertions(+), 22 deletions(-) commit 15f67048e45853ad4069fd4334e132bc3db4d2c4 Author: Behdad Esfahbod Date: Fri Dec 27 19:33:28 2013 -0500 Reorder Tai Tham SAKOT to ensure it comes after any tone marks src/hb-unicode-private.hh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 3216e44feb7b97f44620b51e197425a80a41cdb7 Author: Behdad Esfahbod Date: Mon Dec 23 14:39:23 2013 -0500 [uniscribe] Fix scratch-buffer accounting src/hb-uniscribe.cc | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) commit beeb12c9af4e0e66378cd36cf3dbb1560763a8e3 Author: Behdad Esfahbod Date: Sun Dec 22 22:53:27 2013 -0500 Add TODO item src/hb-ot-shape.h | 1 + 1 file changed, 1 insertion(+) commit fbd4acc58a4bb501625b482bd318be9764ff8e02 Author: Luis de Bethencourt Date: Sun Dec 22 08:02:11 2013 -0500 Clean ht-ob headers src/Makefile.am | 1 + src/hb-ot-layout.h | 5 ----- src/hb-ot-shape.h | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ src/hb-ot.h | 9 +-------- 4 files changed, 55 insertions(+), 13 deletions(-) commit 5497a8a274a7066c0230c850baadef681785c8bb Author: Behdad Esfahbod Date: Sun Dec 22 20:48:53 2013 -0500 Cache various masks on the shape plan src/hb-ot-shape-fallback.cc | 6 ++---- src/hb-ot-shape-private.hh | 15 +++++++++++++++ src/hb-ot-shape.cc | 26 +++++++------------------- 3 files changed, 24 insertions(+), 23 deletions(-) commit 02f909664fa24a7ccf7cf73d75d1d3426aaaae7d Author: Behdad Esfahbod Date: Sun Dec 22 19:35:27 2013 -0500 Minor correction to kern mask checking src/hb-ot-shape-fallback.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit a7e8bbb080aef318b16750ca1771d0d3af3d0ae9 Author: Behdad Esfahbod Date: Sun Dec 22 19:33:35 2013 -0500 Minor fraction mask setting improvement src/hb-ot-map-private.hh | 2 -- src/hb-ot-shape.cc | 8 +++++--- 2 files changed, 5 insertions(+), 5 deletions(-) commit 76fff252a96b4357b5e71694d5201daef822aa60 Author: Behdad Esfahbod Date: Sun Dec 22 17:55:59 2013 -0500 Don't form fractions if only one of numr/dnom exist src/hb-ot-shape.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 3aeee519f0b82df5263974945ae852badc4dbded Author: Behdad Esfahbod Date: Sun Dec 22 16:17:54 2013 -0500 Bug 72698 - Automatically support frac / numr / dnom When seeing U+2044 FRACTION SLASH in the text, find decimal digits (Unicode General Category Decimal_Number) around it, and mark the pre-slash digits with 'numr' feature, the post-slash digits with 'dnom' feature, and the whole sequence with 'frac' feature. This beautifully renders fractions with major Windows fonts, and any other font that implements those features (numr/dnom is enough for most fonts.) Not the fastest way to do this, but good enough for a start. src/hb-ot-shape.cc | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) commit 014f369ec98fdbb3e7a2ef68aea2c4e017e7b680 Author: Behdad Esfahbod Date: Sun Dec 22 16:15:30 2013 -0500 Add XXX note src/hb-ot-map-private.hh | 2 ++ 1 file changed, 2 insertions(+) commit 739325178aba00ea5526c6a54ce588a79e5d45e2 Author: Behdad Esfahbod Date: Sat Dec 21 00:18:18 2013 -0500 Initialize masks before mirroring We were throwing away the rtlm feature mask set during mirroring... src/hb-ot-shape.cc | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) commit d507f6b5b7a052f4d0eb9ba4ec88fd2e3d6f64b4 Author: Luis de Bethencourt Date: Mon Dec 16 15:48:44 2013 -0500 Have Gtk-Doc ignore UCDN files docs/reference/Makefile.am | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) commit d688475ea9cd236bc9b9e0153489fac0025f07f0 Author: Behdad Esfahbod Date: Thu Dec 12 13:21:57 2013 -0500 Minor util/options.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 2a8c49ade07a0bd4f2c9543f4bd129da82083ea0 Author: Behdad Esfahbod Date: Wed Dec 11 20:22:28 2013 -0500 Remove unnecessary includes src/hb-blob.cc | 1 - src/hb-buffer-private.hh | 1 - src/hb-common.cc | 2 -- src/hb-face-private.hh | 1 - src/hb-face.cc | 1 - src/hb-font-private.hh | 1 - src/hb-font.cc | 1 - src/hb-graphite2.cc | 2 -- src/hb-open-type-private.hh | 2 -- src/hb-ot-layout-private.hh | 2 -- src/hb-ot-shape-normalize-private.hh | 2 -- src/hb-ot-tag.cc | 1 - src/hb-set-private.hh | 1 - src/hb-shape-plan-private.hh | 1 - src/hb-tt-font.cc | 2 -- src/hb-unicode-private.hh | 2 -- 16 files changed, 23 deletions(-) commit 2646aec1e67cd6e09f5f7859c9d5898917acc2d5 Author: Behdad Esfahbod Date: Thu Dec 5 18:19:35 2013 -0500 Drop required automake version back to 1.11.3 Work around broken automake-1.13 changes. configure.ac | 3 ++- test/shaping/Makefile.am | 7 +++++++ 2 files changed, 9 insertions(+), 1 deletion(-) commit 860fc9aa7b4c49a1d50e64cfdf4d4dffadb7aa8f Author: Behdad Esfahbod Date: Wed Dec 4 20:06:59 2013 -0500 0.9.25 NEWS | 12 ++++++++++++ configure.ac | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) commit adb039554de0c98a4121f26423bec8df09a62e61 Author: Behdad Esfahbod Date: Wed Dec 4 20:10:02 2013 -0500 Minor util/view-cairo.hh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 95d18a7cab480712d8c95a587ac2a8fdcbec5e71 Author: Behdad Esfahbod Date: Wed Dec 4 20:01:22 2013 -0500 [git.mk] Update git.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d913f98d88098fc0f4163dfbc54d8ca9ebe9dd81 Author: Behdad Esfahbod Date: Wed Dec 4 19:59:48 2013 -0500 Require automake 1.13 Fix tests build. https://bugs.freedesktop.org/show_bug.cgi?id=71353 configure.ac | 2 +- test/shaping/Makefile.am | 19 ++++++++++++++----- 2 files changed, 15 insertions(+), 6 deletions(-) commit 205bf834d80f81471f0c3da4f400e60ce3a533dc Author: Behdad Esfahbod Date: Mon Dec 2 20:41:41 2013 -0500 Revert "Karen" language mapping back to what it was before https://bugzilla.mozilla.org/show_bug.cgi?id=941470 src/hb-ot-tag.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit f47b9219546edcfdeb3991ee27f6d9ba455c3e08 Author: Behdad Esfahbod Date: Mon Dec 2 05:57:27 2013 -0500 Fix unsafe shape_plan->face dependency src/hb-ot-shape-private.hh | 2 +- src/hb-shape-plan-private.hh | 2 +- src/hb-shape-plan.cc | 12 +++--------- 3 files changed, 5 insertions(+), 11 deletions(-) commit c704a8700e169885f1d9cbab93544d85aa4358e9 Author: Behdad Esfahbod Date: Mon Dec 2 05:42:04 2013 -0500 [util] Fix uninitialized memory access util/view-cairo.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 260a3198f44a4ece60864b6f6caab2ee756ad762 Author: Behdad Esfahbod Date: Mon Dec 2 05:39:39 2013 -0500 [util] Plug leak util/options.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit ca8d96c8ba33ce581684cbc07936a3696b6c83d9 Author: Jonathan Kew Date: Mon Dec 2 05:22:00 2013 -0500 cache shape plans even if (global) user features are set src/hb-shape-plan-private.hh | 3 +++ src/hb-shape-plan.cc | 59 ++++++++++++++++++++++++++++++++++++++++---- 2 files changed, 57 insertions(+), 5 deletions(-) commit 8ffa528f28a24ae85952ad1c1b0206e736bcfeab Author: Behdad Esfahbod Date: Mon Dec 2 05:17:14 2013 -0500 Add note about unsafe shape_plan->face Will fix by removing shape_plan->face completely. src/hb-shape-plan.cc | 2 ++ 1 file changed, 2 insertions(+) commit aec468f01e866c99e65a8f764a792c74c96840d7 Author: Behdad Esfahbod Date: Fri Nov 29 19:21:58 2013 -0500 [coretext] Add TODO src/hb-coretext.cc | 2 ++ 1 file changed, 2 insertions(+) commit 58cc233e8b5fdc9dce603acc1b968540a2dea3e1 Author: Behdad Esfahbod Date: Fri Nov 29 19:17:42 2013 -0500 [coretext] Cleanup src/hb-coretext.cc | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) commit c8213c6198abff97822e29a6d565722cfbb43832 Author: Khaled Hosny Date: Fri Nov 29 19:01:56 2013 -0500 [coretext] Avoid font fallback with CoreText shaper CoreText does automatic font fallback (AKA "cascading") for characters not supported by the requested font, and provides no way to turn it off, so detect if the returned run uses a font other than the requested one and fill in the buffer with .notdef glyphs instead of random indices glyph from a different font. src/hb-coretext.cc | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) commit 63bae73aefb0e5988ef6975f1ed38e040e50e91d Author: Behdad Esfahbod Date: Tue Nov 26 22:57:24 2013 -0500 [fallback] Add TODO note src/hb-fallback-shape.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) commit e1ebf01d0cf3df55bb9137136e2d0c9630e7bd78 Author: Behdad Esfahbod Date: Tue Nov 26 18:00:35 2013 -0500 Minor src/hb-ot-layout-common-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a182dbc9e4e51fa7990c4aea3eaa425a061b29c7 Author: Behdad Esfahbod Date: Tue Nov 26 17:53:41 2013 -0500 Minor src/hb-ot-layout-common-private.hh | 1 + 1 file changed, 1 insertion(+) commit 9174a9db5c4e01284143ed8bd318ce9454535987 Author: Behdad Esfahbod Date: Mon Nov 25 18:10:38 2013 -0500 [myanmar] Allow punctuation clusters The spec and Uniscribe don't allow these, but UTN#11 specifically says the sequence U+104B,U+1038 is valid. As such, allow all "P V" sequences. There's about eight sequences that match that structure, but Roozbeh thinks it's fine to allow all of them. Test case: U+104B, U+1038 https://bugs.freedesktop.org/show_bug.cgi?id=71947 src/hb-ot-shape-complex-myanmar-machine.rl | 3 +++ src/hb-ot-shape-complex-myanmar.cc | 19 ++++++++++++++++++- 2 files changed, 21 insertions(+), 1 deletion(-) commit 096b71e8ef0c1443f3f86069d5416b887af6e9e7 Author: Behdad Esfahbod Date: Mon Nov 25 18:03:34 2013 -0500 [myanmar] Mark U+104E MYANMAR SYMBOL AFOREMENTIONED as Consonant The spec and Uniscribe treat it as consonant in the grammar, but it's not in IndicSyllableCategory.txt, so fix up. Test sequence: U+1004,U+103A,U+1039,U+104E https://bugs.freedesktop.org/show_bug.cgi?id=71948 src/hb-ot-shape-complex-myanmar.cc | 4 ++++ 1 file changed, 4 insertions(+) commit d2da5e0b4b4ffc1722403ffb90b8777cfa1cd174 Author: Behdad Esfahbod Date: Mon Nov 25 17:50:07 2013 -0500 [myanmar] Relax pwo-tone group a bit This is broken sequence according to OpenType spec, Uniscribe, and current HarfBuzz implementation. But Roozbeh says this is a valid sequence, so allow it. There are multiple "(DB As?)?" constructs in the grammar, but Roozbeh thinks only this one needs changing. Test case: 1014,1063,103A Fixes https://bugs.freedesktop.org/show_bug.cgi?id=71949 src/hb-ot-shape-complex-myanmar-machine.rl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9af91ca8ffee4a8d2804eff5d380b4f9749414d1 Author: Behdad Esfahbod Date: Mon Nov 25 17:47:19 2013 -0500 Add more Myanmar test cases All three are broken right now according to Roozbeh. https://bugs.freedesktop.org/show_bug.cgi?id=71947 https://bugs.freedesktop.org/show_bug.cgi?id=71948 https://bugs.freedesktop.org/show_bug.cgi?id=71949 .../shaping/texts/in-tree/shaper-myanmar/script-myanmar/misc/misc.txt | 4 ++++ 1 file changed, 4 insertions(+) commit 08c2d27d35093e07142168665139274ac99395e8 Author: Roozbeh Pournader Date: Sat Nov 23 21:39:31 2013 -0800 Added support for several new languages Based on research into latest SIL and Windows fonts, pulling in the latest OpenType language tag proposal from Microsoft, and updating to latest language tags and names from ISO 639. src/hb-ot-tag.cc | 314 +++++++++++++++++++++++++++++++++++++++++++------------ 1 file changed, 247 insertions(+), 67 deletions(-) commit 05511acd198d0c2157cdb41e1d36eac0b8075357 Author: Roozbeh Pournader Date: Sat Nov 23 15:19:07 2013 -0800 Added language tags for S'gaw Karen and Khamti Tags based on support in Windows 8.1's 'Myanmar Text' font. src/hb-ot-tag.cc | 2 ++ 1 file changed, 2 insertions(+) commit 0bb31e4497523442fbb26bbd55b194ab70205ca4 Author: Behdad Esfahbod Date: Wed Nov 20 14:21:07 2013 -0500 Bug 71845 - Use 64-bit cmpexch on ARM64 iOS src/hb-atomic-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 02c6c8cd6e8c93b63c75b25de6bf76bb45755bb4 Author: Behdad Esfahbod Date: Fri Nov 15 13:05:38 2013 -0500 Set buffer content type to INVALID in hb_buffer_set_length(0) Previously we were only setting this in hb_buffer_clear_contents(), but set_length(0) is a valid way to reinitialize buffer to use with new text. src/hb-buffer-private.hh | 2 +- src/hb-buffer.cc | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) commit 6300694f6e531593e7e932000f9540b0367940b8 Author: Behdad Esfahbod Date: Wed Nov 13 14:54:07 2013 -0500 0.9.24 NEWS | 8 ++++++++ configure.ac | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) commit 061cb4649342b005fb1de93abae25e889cc560bd Author: Behdad Esfahbod Date: Wed Nov 13 14:50:25 2013 -0500 Use long alignment for scratch buffer Fixes last of scratch alignment warnings in hb-coretext. src/hb-buffer-private.hh | 2 +- src/hb-buffer.cc | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) commit 68c372ed2eac76a6d347811293fe2ba2fd6a1eed Author: Behdad Esfahbod Date: Wed Nov 13 14:44:01 2013 -0500 More scratch-buffer cleanup src/hb-buffer-private.hh | 3 ++- src/hb-buffer.cc | 10 +++++----- src/hb-coretext.cc | 5 ++--- src/hb-graphite2.cc | 2 +- src/hb-uniscribe.cc | 30 ++++++++++++++---------------- 5 files changed, 24 insertions(+), 26 deletions(-) commit 8fcadb9cf9418345610e3f4e38c28c12b768b589 Author: Behdad Esfahbod Date: Wed Nov 13 14:33:57 2013 -0500 [coretext] More scratch buffer fixes src/hb-coretext.cc | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) commit 16f175cb2e081e605fe7f9cd01bbe8c24380278a Author: Behdad Esfahbod Date: Tue Nov 12 17:22:49 2013 -0500 Fix scratch-buffer alignment warnings src/hb-buffer-private.hh | 2 +- src/hb-buffer.cc | 9 +++++---- src/hb-coretext.cc | 17 ++++++++++------- src/hb-graphite2.cc | 28 +++++++++++++++++----------- src/hb-private.hh | 3 +++ src/hb-uniscribe.cc | 29 +++++++++++++++++------------ 6 files changed, 53 insertions(+), 35 deletions(-) commit c7c4ccf8a1e784b6f8798388a219dda9a26fbd93 Author: Behdad Esfahbod Date: Tue Nov 12 15:41:22 2013 -0500 [travis] Enable graphite2 .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 83408cf804a6908873c41b70bb7c43448e66ddd2 Author: Behdad Esfahbod Date: Wed Nov 6 14:46:04 2013 -0500 Fix llvm warnings on Mac Patch from Scott Fleischman. Warnings were: harfbuzz/src/hb-font-private.hh:121:42: Implicit conversion loses integer precision: 'long long' to 'hb_position_t' (aka 'int') harfbuzz/src/hb-font-private.hh:126:42: Implicit conversion loses integer precision: 'long long' to 'hb_position_t' (aka 'int') harfbuzz/src/hb-font-private.hh:400:85: Implicit conversion loses integer precision: 'long long' to 'hb_position_t' (aka 'int') harfbuzz/src/hb-ot-layout-common-private.hh:1115:37: Implicit conversion loses integer precision: 'long long' to 'int' harfbuzz/src/hb-ft.cc:421:97: Implicit conversion loses integer precision: 'unsigned long long' to 'int' harfbuzz/src/hb-ft.cc:422:97: Implicit conversion loses integer precision: 'unsigned long long' to 'int' src/hb-font-private.hh | 6 +++--- src/hb-ft.cc | 4 ++-- src/hb-ot-layout-common-private.hh | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) commit 333cc6e2d11831bcd2370723456e678574d570ec Author: Behdad Esfahbod Date: Wed Oct 30 17:30:11 2013 +0000 [otlayout] Remove unused is_inplace() Patch from Jonathan Kew. src/hb-ot-layout-gpos-table.hh | 6 -- src/hb-ot-layout-gsub-table.hh | 56 ------------ src/hb-ot-layout-gsubgpos-private.hh | 159 ----------------------------------- 3 files changed, 221 deletions(-) commit 176fd17d02ac183af32a0e710ec32d25c9322021 Author: Behdad Esfahbod Date: Wed Oct 30 17:27:24 2013 +0000 Bug 70971 - Signed/unsigned compiler warnings on windows Patch from Emil Eklund. src/hb-buffer-serialize.cc | 8 ++++---- src/hb-ot-map.cc | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) commit 3d436d325edccc0f3dd820e06e3d529cc8f3eca4 Author: Behdad Esfahbod Date: Mon Oct 28 21:00:37 2013 +0100 [otlayout] Reset ccc when marking glyph as letter src/hb-ot-layout-gsubgpos-private.hh | 3 +++ 1 file changed, 3 insertions(+) commit b9d0077ac1a8e8a62ee15c64ad302f7976e23bdd Author: Behdad Esfahbod Date: Mon Oct 28 20:44:03 2013 +0100 Fix win32 testing test/shaping/Makefile.am | 1 + test/shaping/run-tests.sh | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) commit dce79c2bd747d398bdf2f4b171b0ba9b5b951f72 Author: Behdad Esfahbod Date: Mon Oct 28 20:26:40 2013 +0100 0.9.23 NEWS | 10 ++++++++++ configure.ac | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) commit 2e990a3d722c10d1eefdc4c5ccbdaa384625c3fd Author: Behdad Esfahbod Date: Mon Oct 28 20:23:07 2013 +0100 Make "make distcheck" happy configure.ac | 2 +- test/shaping/Makefile.am | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) commit 6ffc007b61402c9d1d4de368deed4971a10ed00b Author: Behdad Esfahbod Date: Mon Oct 28 19:26:02 2013 +0100 [otlayout] Optimize inplace See thread started by Jonathan with subject "an optimization for complex fonts". src/hb-ot-layout.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 71b4c999a511bf018acaf48a45e070470c0daf12 Author: Behdad Esfahbod Date: Mon Oct 28 00:20:59 2013 +0100 Revert "Zero marks by GDEF for Tibetan" This reverts commit d5bd0590ae2fbc7b0dee86385a565aef00ffb835. The reasoning behind that logic was flawed and made under a misunderstanding of the original problem, and caused regressions as reported by Jonathan Kew in thread titled "tibetan marks" in Oct 2013. Apparently I have had fixed the original problem with this commit: 7e08f1258da229dfaf7e1c4b5c41e5bb83906cb0 So, revert the faulty commit and everything seems to be in good shape. src/hb-ot-layout-gsubgpos-private.hh | 4 ++-- src/hb-ot-shape-complex-arabic.cc | 10 +++------- src/hb-ot-shape-complex-default.cc | 17 +---------------- src/hb-ot-shape-complex-indic.cc | 8 +------- src/hb-ot-shape-complex-myanmar.cc | 15 +++++---------- src/hb-ot-shape-complex-private.hh | 8 ++------ src/hb-ot-shape-complex-sea.cc | 14 ++++---------- src/hb-ot-shape-complex-thai.cc | 9 +-------- src/hb-ot-shape.cc | 4 ++-- 9 files changed, 21 insertions(+), 68 deletions(-) commit 9596b2bf569dae6fbe268803e3cb248001f10954 Author: Behdad Esfahbod Date: Mon Oct 28 00:09:05 2013 +0100 Pass CPPFLAGS=-Werror to Travis-CI We want default gcc / clang warnings to fail the CI build. .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c77d1ade6898cea161f0709c5c5a912e14aff951 Author: Behdad Esfahbod Date: Sun Oct 27 23:52:26 2013 +0100 Fix warnings test/api/test-blob.c | 2 +- util/helper-cairo-ansi.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit c2bc818706df56022c8bb922df2b741cb120f7e4 Author: Behdad Esfahbod Date: Sun Oct 27 23:36:35 2013 +0100 Work with old and new glib Avoids "deprecated" warnings. src/test-buffer-serialize.cc | 7 +++++-- src/test-size-params.cc | 7 +++++-- src/test-would-substitute.cc | 7 +++++-- src/test.cc | 7 +++++-- util/options.cc | 4 ++-- util/options.hh | 4 ++++ util/view-cairo.hh | 4 ++++ 7 files changed, 30 insertions(+), 10 deletions(-) commit 46a863d91dbcc9a4c796e3715ea3828939f4d941 Author: Behdad Esfahbod Date: Sun Oct 27 23:24:50 2013 +0100 [indic] Adjust pref reordering logic For Javanese (pref_len == 1) only reorder if it didn't ligate. That's sensible, and what the spec says. For other Indic (pref_len > 1) only reorder if ligated. Doesn't change any test numbers. src/hb-ot-shape-complex-indic.cc | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) commit 6b03e3c724ec6cd255f4a323bf4aa7d8c93a056e Author: Behdad Esfahbod Date: Sun Oct 27 21:04:55 2013 +0100 Optimize fallback kerning Patch from Jonathan Kew. "These changes seem to yield a small but just-about-measurable improvement with old fonts that lack GPOS kerning." src/hb-ot-shape-fallback.cc | 47 ++++++++++++++++++++++++++++----------------- 1 file changed, 29 insertions(+), 18 deletions(-) commit 133eeba6a32769ec1a7520e7c8a0d2eb1ad986f8 Author: Behdad Esfahbod Date: Sun Oct 27 00:24:59 2013 +0200 Minor See: https://github.com/prezi/harfbuzz-js/pull/1/files#r7032397 src/hb-common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a74f0de225c403998212e2618dcf9452bc5b590d Author: Behdad Esfahbod Date: Thu Oct 24 11:46:33 2013 +0200 [indic] Fix CM2, really Followup from 6e613f3365bf4e9fd778758c53e7de00c64beca1. src/hb-ot-shape-complex-indic-machine.rl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6e613f3365bf4e9fd778758c53e7de00c64beca1 Author: Behdad Esfahbod Date: Wed Oct 23 23:34:13 2013 +0200 Fix "shift count >= width of type" issue src/hb-ot-shape-complex-indic-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ac8cd511911c7dca6222d14fa758bff75d601567 Author: Behdad Esfahbod Date: Fri Oct 18 19:33:09 2013 +0200 Refactor src/hb-ot-layout-gpos-table.hh | 120 ++++++++++++++++++++++------------------- src/hb-ot-layout.cc | 31 +++++------ src/hb-ot-shape-normalize.cc | 29 +++++----- src/hb-ot-shape.cc | 82 ++++++++++++++++------------ 4 files changed, 145 insertions(+), 117 deletions(-) commit 0f3fe37fccfb540437adf13dd580f2c5164a0b1f Author: Behdad Esfahbod Date: Fri Oct 18 19:14:22 2013 +0200 Comment src/hb-ot-layout-private.hh | 1 + 1 file changed, 1 insertion(+) commit ddce2d8df6fed9c033f1f13e235666680c5beb67 Author: Behdad Esfahbod Date: Fri Oct 18 18:07:11 2013 +0200 [indic] Improve positioning of post-base bells and whistles Bug 58714 - Kannada u+0cb0 u+200d u+0ccd u+0c95 u+0cbe does not provide same results as Windows8 https://bugs.freedesktop.org/show_bug.cgi?id=58714 Test with U+0CB0,U+200D,U+0CCD,U+0C95,U+0CBF and tunga.ttf. Improves some scripts. Improves Bengali too, but numbers are up because we produce better results than Uniscribe for some sequences now. New numbers: BENGALI: 353724 out of 354188 tests passed. 464 failed (0.131004%) DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%) GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%) GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%) KANNADA: 951190 out of 951913 tests passed. 723 failed (0.0759523%) KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%) MALAYALAM: 1048140 out of 1048334 tests passed. 194 failed (0.0185056%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) src/hb-ot-shape-complex-indic.cc | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) commit d5bd0590ae2fbc7b0dee86385a565aef00ffb835 Author: Behdad Esfahbod Date: Fri Oct 18 16:44:54 2013 +0200 Zero marks by GDEF for Tibetan See: http://lists.freedesktop.org/archives/harfbuzz/2013-April/003101.html src/hb-ot-layout-gsubgpos-private.hh | 4 ++-- src/hb-ot-shape-complex-arabic.cc | 10 +++++++--- src/hb-ot-shape-complex-default.cc | 17 ++++++++++++++++- src/hb-ot-shape-complex-indic.cc | 8 +++++++- src/hb-ot-shape-complex-myanmar.cc | 15 ++++++++++----- src/hb-ot-shape-complex-private.hh | 8 ++++++-- src/hb-ot-shape-complex-sea.cc | 14 ++++++++++---- src/hb-ot-shape-complex-thai.cc | 9 ++++++++- src/hb-ot-shape.cc | 4 ++-- 9 files changed, 68 insertions(+), 21 deletions(-) commit bf029281b1b0f854f671969ab40eac3046a111bd Author: Behdad Esfahbod Date: Fri Oct 18 16:20:13 2013 +0200 Bug 65258 - [...] Mongolian with free variation selector src/hb-ot-shape-complex-arabic.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 0193649ce4ca78b8e2835a50bd51ee594cffe34e Author: Behdad Esfahbod Date: Fri Oct 18 16:08:53 2013 +0200 [otfallback] Don't shift down above-marks too much This seems to generate much better, almost-perfect, positioning for Arabic as well as Latin above marks. src/hb-ot-shape-fallback.cc | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) commit dba9580237da788275b1ab5fe6be75c8a3f359b9 Author: Behdad Esfahbod Date: Fri Oct 18 15:57:36 2013 +0200 [otfallback] Never fallback-position a below-mark upwards Test with WinXP times.ttf and U+05D9,U+05B5. src/hb-ot-shape-fallback.cc | 6 ++++++ 1 file changed, 6 insertions(+) commit 8177da29ad07d8fa444ce07003fa65cd31a2776b Author: Behdad Esfahbod Date: Fri Oct 18 15:50:29 2013 +0200 Minor src/hb-ot-shape-fallback.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit c16012e9019ec59c2200a3cc29b8a37ea70eda70 Author: Behdad Esfahbod Date: Fri Oct 18 02:27:00 2013 +0200 [indic] Add Javanese support! Seems to be working just fine! src/hb-ot-shape-complex-indic-machine.rl | 14 ++++++------ src/hb-ot-shape-complex-indic-private.hh | 37 ++++++++++++++++---------------- src/hb-ot-shape-complex-indic.cc | 9 ++++++-- 3 files changed, 34 insertions(+), 26 deletions(-) commit 755b44cce6dc23376a3cf0212893609231fa4967 Author: Behdad Esfahbod Date: Fri Oct 18 11:17:42 2013 +0200 [ft] Round metrics instead of truncate Lohit-Punjabi has a upem of 769! We were losing one unit in our code, and FreeType is losing another one... Test with U+0A06. Has an advance of 854 in the font. We were producing 852. Now we do 853, which is what FreeType is telling us. src/hb-ft.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 9a49351cc2625de16a73e0e153d3097ef6c7cc0f Author: Behdad Esfahbod Date: Fri Oct 18 02:14:53 2013 +0200 [indic] Swith pref logic to use _hb_glyph_info_substituted() See comments from caveat! Seems to work fine. This is useful for Javanese which has an atomically encoded pre-base reordering Ra which should only be reordered if it was substituted by the pref feature. src/hb-ot-shape-complex-indic.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit f175aa33c5e94397c60648ac0697c80f5fe0dcb7 Author: Behdad Esfahbod Date: Fri Oct 18 02:07:44 2013 +0200 [indic] Fix compiler warnings src/hb-ot-shape-complex-indic.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 857027341423f15fd6084c7563cc355b06e7cbdd Author: Behdad Esfahbod Date: Fri Oct 18 01:11:05 2013 +0200 [otlayout] Add _hb_glyph_info_substituted() Currently unused. src/hb-ot-layout-private.hh | 6 ++++++ 1 file changed, 6 insertions(+) commit a1f7b2856184959e965c9c2b80363f9f46d486a7 Author: Behdad Esfahbod Date: Fri Oct 18 01:09:08 2013 +0200 [otlayout] Switch over from old is_a_ligature() to IS_LIGATED Impact should be minimal and positive. src/hb-ot-layout-gsubgpos-private.hh | 2 +- src/hb-ot-layout-private.hh | 12 +++++++++--- src/hb-ot-shape-complex-indic.cc | 4 ++-- src/hb-ot-shape-complex-myanmar.cc | 2 +- src/hb-ot-shape.cc | 2 +- 5 files changed, 14 insertions(+), 8 deletions(-) commit 09675a8115b9d77261c33940401aa919cede8662 Author: Behdad Esfahbod Date: Fri Oct 18 01:05:58 2013 +0200 [otlayout] Add HB_OT_LAYOUT_GLYPH_PROPS_LIGATED Currently unused. src/hb-ot-layout-gsubgpos-private.hh | 15 ++++++++++----- src/hb-ot-layout-private.hh | 5 ++++- 2 files changed, 14 insertions(+), 6 deletions(-) commit 05ad6b50ac0a1b9a8da10d2ee2238068b7811e7d Author: Behdad Esfahbod Date: Fri Oct 18 00:45:59 2013 +0200 [otlayout] Add HB_OT_LAYOUT_GLYPH_PROPS_SUBSTITUTED Currently unused. src/hb-ot-layout-gsubgpos-private.hh | 5 +++-- src/hb-ot-layout-private.hh | 10 ++++++---- 2 files changed, 9 insertions(+), 6 deletions(-) commit 101303dbf7cf15d044bf2518f14b3aec65970fea Author: Behdad Esfahbod Date: Fri Oct 18 00:42:39 2013 +0200 [otlayout] More shuffling around src/hb-ot-layout-gpos-table.hh | 16 +++---- src/hb-ot-layout-gsub-table.hh | 13 +++-- src/hb-ot-layout-gsubgpos-private.hh | 8 ++-- src/hb-ot-layout-private.hh | 92 ++++++++++++++++++++++++++++++++---- src/hb-ot-shape.cc | 8 ++-- 5 files changed, 102 insertions(+), 35 deletions(-) commit 91689de2603e4151e2a2d3a3852c61667f0c6264 Author: Behdad Esfahbod Date: Fri Oct 18 00:21:59 2013 +0200 [otlayout] Add _hb_glyph_info_set_glyph_props() No functional change. src/hb-ot-layout-gsub-table.hh | 2 +- src/hb-ot-layout-gsubgpos-private.hh | 4 ++-- src/hb-ot-layout-private.hh | 9 +++++++++ src/hb-ot-shape.cc | 8 +++++--- 4 files changed, 17 insertions(+), 6 deletions(-) commit a0161746589934e93c3b115814bbd81f56ab962f Author: Behdad Esfahbod Date: Fri Oct 18 00:06:30 2013 +0200 [otlayout] Simplify set_class() usage src/hb-ot-layout-gsubgpos-private.hh | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-) commit 3ddf892b5328b74afb6e7d9da727d8771ca5d288 Author: Behdad Esfahbod Date: Fri Oct 18 00:02:43 2013 +0200 [otlayout] Renaming src/hb-ot-layout-gpos-table.hh | 18 +++++++------- src/hb-ot-layout-gsub-table.hh | 2 +- src/hb-ot-layout-gsubgpos-private.hh | 36 +++++++++++++-------------- src/hb-ot-layout-private.hh | 48 +++++++++++++++++++++--------------- src/hb-ot-shape-complex-indic.cc | 5 ++-- src/hb-ot-shape-complex-myanmar.cc | 2 +- src/hb-ot-shape-fallback.cc | 8 +++--- src/hb-ot-shape.cc | 2 +- 8 files changed, 65 insertions(+), 56 deletions(-) commit 2e96d2c6ee34142375373be07217c9953e7822cc Author: Behdad Esfahbod Date: Thu Oct 17 21:16:20 2013 +0200 [otlayout] More shuffling src/hb-ot-layout-private.hh | 252 +++++++++++++++++++++++--------------------- 1 file changed, 130 insertions(+), 122 deletions(-) commit 469524692bd0a258b28e63294c984e677a9c2477 Author: Behdad Esfahbod Date: Thu Oct 17 21:01:57 2013 +0200 [otlayout] Code shuffling src/hb-ot-layout-private.hh | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) commit 11fb16cb849285a178d9e80991b1d60a960326ee Author: Behdad Esfahbod Date: Thu Oct 17 20:57:57 2013 +0200 Use unsigned enums for mask types src/hb-buffer.h | 16 ++++++++-------- src/hb-ot-layout-private.hh | 8 ++++---- 2 files changed, 12 insertions(+), 12 deletions(-) commit 03058c3d1e8c18858c1e0b0c738ce9d299f2787a Author: Behdad Esfahbod Date: Thu Oct 17 20:55:34 2013 +0200 [otlayout] Remove two unused HB_OT_LAYOUT_GLYPH_PROPS_* values src/hb-ot-layout-gdef-table.hh | 1 - src/hb-ot-layout-gsub-table.hh | 3 ++- src/hb-ot-layout-private.hh | 7 +++++-- 3 files changed, 7 insertions(+), 4 deletions(-) commit 941b6992042e7b73b3a2aab1448383adf33bef28 Author: Behdad Esfahbod Date: Thu Oct 17 20:47:33 2013 +0200 [otlayout] Remove unused HB_OT_LAYOUT_GLYPH_PROPS_UNCLASSIFIED src/hb-ot-layout-gdef-table.hh | 7 +++++-- src/hb-ot-layout-private.hh | 10 ++++------ 2 files changed, 9 insertions(+), 8 deletions(-) commit 8f9ec92dfce5c469fb85ad301296b5dde1b2ab0a Author: Behdad Esfahbod Date: Thu Oct 17 19:52:47 2013 +0200 [indic] Adjust Javanese base algorithm src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 49901862e36e1c153835877a9f1183729333bbbe Author: Behdad Esfahbod Date: Thu Oct 17 19:48:51 2013 +0200 [otlayout] Guard against use of ReverseChain through Context src/hb-ot-layout-gsub-table.hh | 4 +++- src/hb-ot-layout.cc | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) commit 74f4bbf0560a5fd2d295e100e96f0c6c7033e852 Author: Behdad Esfahbod Date: Thu Oct 17 19:07:53 2013 +0200 [indic] Towards supporting atomicly-encoded prebase-reorderings src/hb-ot-shape-complex-indic.cc | 65 ++++++++++++++++++++++++---------------- 1 file changed, 40 insertions(+), 25 deletions(-) commit efed40b975110d78c9c505441e7e17a8c13e85c8 Author: Behdad Esfahbod Date: Thu Oct 17 18:50:11 2013 +0200 [indic] Minor refactoring of reph handling src/hb-ot-shape-complex-indic.cc | 14 ++++++++------ src/hb-ot-shape-complex-sea.cc | 2 +- 2 files changed, 9 insertions(+), 7 deletions(-) commit 684fe59ff858a0ecba71b3ed80378afb0b8bbb48 Author: Behdad Esfahbod Date: Thu Oct 17 18:30:06 2013 +0200 [indic] Minor refactoring of would_substitute() src/hb-ot-shape-complex-indic.cc | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) commit 321df83fb4f0b8a5310888129cb70bfda8ae0c96 Author: Behdad Esfahbod Date: Thu Oct 17 18:16:14 2013 +0200 Route Buginese through the SEA shaper Both Indic and SEA seem to do it just fine, but SEA is much simpler. src/hb-ot-shape-complex-private.hh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit b5a0f69e47ace468b06e21cf069a18ddcfcf6064 Author: Behdad Esfahbod Date: Thu Oct 17 18:04:23 2013 +0200 [indic] Pass zero-context=false to would_substitute for newer scripts For scripts without an old/new spec distinction, use zero-context=false. This changes behavior in Sinhala / Khmer, but doesn't seem to regress. This will be useful and used in Javanese. src/hb-ot-shape-complex-indic.cc | 35 +++++++++++++++++++---------------- 1 file changed, 19 insertions(+), 16 deletions(-) commit c4e71ff36d1f86a6ea56539728a964d97217e2b6 Author: Behdad Esfahbod Date: Thu Oct 17 17:04:47 2013 +0200 [indic] Clean up Khmer and Sinhala base finding algorithm src/hb-ot-shape-complex-indic.cc | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) commit e10453e6fb2544724ccd7ddfdbb9de90ef9274ce Author: Behdad Esfahbod Date: Thu Oct 17 16:49:06 2013 +0200 [indic] Add BASE_POS_LAST_SINHALA Previously we planted this into the mode used for Khmer. There's not really much in common between the two, so separate again. src/hb-ot-shape-complex-indic.cc | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) commit 9ac6b01e0cd8e2d66dfc727157f45b615bc77109 Author: Behdad Esfahbod Date: Thu Oct 17 16:27:38 2013 +0200 [indic] Adjust Sinhala cluster merging under uniscribe Similar to 190c8f2b60af0851bf692f653c1604cfbf0561a5 but for Sinhala. src/hb-ot-shape-complex-indic.cc | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) commit 3c3df9cba13fec2c35e0e7ae587d9699ac0c37f5 Author: Behdad Esfahbod Date: Thu Oct 17 13:58:31 2013 +0200 [otlayout] Minor src/hb-ot-layout-gsubgpos-private.hh | 62 +++++++++++++++++++----------------- 1 file changed, 33 insertions(+), 29 deletions(-) commit 6cc136f7531a45e71ea08a7dc8a2187172cb813d Author: Behdad Esfahbod Date: Thu Oct 17 13:55:48 2013 +0200 [otlayout] Minor src/hb-ot-layout-gsubgpos-private.hh | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) commit ba6ddc421e5e440231c2ece2db1363f8e6d2ecbf Author: Behdad Esfahbod Date: Thu Oct 17 13:52:51 2013 +0200 [otlayout] Increase MAX_CONTEXT_LENGTH It's cheap. src/hb-ot-layout-common-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e714fe6d6a2633494cb1fa7170a32ca2638cbb51 Author: Behdad Esfahbod Date: Thu Oct 17 13:49:51 2013 +0200 [otlayout] Simplify ligate_input() Shouldn't change behavior at all, but is faster / more robust. src/hb-ot-layout-gsub-table.hh | 16 +++++++--------- src/hb-ot-layout-gsubgpos-private.hh | 17 +++++++---------- 2 files changed, 14 insertions(+), 19 deletions(-) commit 6b2abdcd203204131f3017ca85c91de9d43959cd Author: Behdad Esfahbod Date: Thu Oct 17 13:15:43 2013 +0200 [indic] Improve clusters in presence of reph src/hb-ot-shape-complex-indic.cc | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit 42d0f55cbc68285e22d713df7062e520af708c82 Author: Behdad Esfahbod Date: Thu Oct 17 13:05:05 2013 +0200 [indic] Apply calt,clig in the same stage as presentation features Whic means these twp are applied per-syllable now. Apparently in some Khmer fonts the clig interacts with presentation features. Test case: U+1781,U+17D2,U+1789,U+17BB,U+17C6 with Mondulkiri-R.ttf should produce one big ligature. src/hb-ot-shape-complex-indic.cc | 4 ++++ 1 file changed, 4 insertions(+) commit ae9a5834df477006686421d494b55a1569789327 Author: Behdad Esfahbod Date: Thu Oct 17 12:24:55 2013 +0200 [indic] Fix pref vs blwf interaction If a glyph can be both blwf and pref, we were wrongly sorting it in the post position instead of below position. src/hb-ot-shape-complex-indic.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit c7dacac02cfe8526eaf131ce6c5e7b6df7ca2ccd Author: Behdad Esfahbod Date: Thu Oct 17 12:20:24 2013 +0200 [indic] Don't apply blwf before base under old-spec mode Test case: U+09AC,U+09CD,U+09A6 with Lohit-Bengali 2.5.3. src/hb-ot-shape-complex-indic.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit da72042c52ed3cc0ee19d3eabb8db7c7dd34d3ed Author: Behdad Esfahbod Date: Thu Oct 17 12:01:50 2013 +0200 [otlayout] Fix up recent Context matching change Commit 6b65a76b40522a4f57a6fedcbdfc5a4d736f1d3c. "end" was becoming negative. Was trigerred by Lohit-Kannada 2.5.3 and the sequence: U+0CB0,U+200D,U+0CBE,U+0CB7,U+0CCD,U+0C9F,U+0CCD,U+0CB0,U+0C97,U+0CB3 Two glyphs were being duplicated. src/hb-buffer.cc | 7 ++++++- src/hb-ot-layout-gsubgpos-private.hh | 3 ++- 2 files changed, 8 insertions(+), 2 deletions(-) commit 1a7de1ba9876b0554c758acbc6459366d9d98a5d Author: Behdad Esfahbod Date: Wed Oct 16 19:55:06 2013 +0200 [indic] Improve Avagraha support in machine src/hb-ot-shape-complex-indic-machine.rl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 3756efaf4e14ec3b5b1def700a1b5985f162372b Author: Behdad Esfahbod Date: Wed Oct 16 19:06:29 2013 +0200 [indic] Misc harmless fixes! First, we were abusing OT_VD instead of OT_A. Fix that but moving OT_A in the grammar where it belongs (which is different from what the spec says). Also, only allow medial consonants after all other consonants. This doesn't affect any current character. Finally, fix Halant attachment in presence of medial consonants. Again, this currently doesn't affect any sequence. I lied. There's Gurmukhi U+0A75 which is Consonant_Medial. Uniscribe allows one of those in each of these positions: before matras, after matras and before syllable modifiers, and after syllable modifiers! We currently just allow unlimited numbers of it, before matras. src/hb-ot-shape-complex-indic-machine.rl | 8 ++++---- src/hb-ot-shape-complex-indic-private.hh | 2 +- src/hb-ot-shape-complex-indic.cc | 11 ++++++----- 3 files changed, 11 insertions(+), 10 deletions(-) commit c52ddab72e025d1bee8274c8f3416208b12f68f1 Author: Behdad Esfahbod Date: Wed Oct 16 13:42:38 2013 +0200 [arabic] Make ZWJ prevent ligatures instead of facilitating it Unicode 6.2.0 Section 16.2 / Figure 16.3 says: "For backward compatibility, between Arabic characters a ZWJ acts just like the sequence , preventing a ligature from forming instead of requesting the use of a ligature that would not normally be used. As a result, there is no plain text mechanism for requesting the use of a ligature in Arabic text." As such, we flip internal zwj to zwnj flags for GSUB matching, which means it will block ligation in all features, unless the font explicitly matches U+200D glyph. This doesn't affect joining behavior. src/hb-ot-layout-private.hh | 6 ++++++ src/hb-ot-shape-complex-arabic.cc | 18 ++++++++++++++++++ 2 files changed, 24 insertions(+) commit 1a31f9f820c4538015ddaf4ca2b790649c5997ed Author: Behdad Esfahbod Date: Wed Oct 16 13:42:18 2013 +0200 [otlayout] Minor src/hb-ot-layout-private.hh | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) commit 28d5daec948e1a24f13e492ce301aeb9abff37c8 Author: Behdad Esfahbod Date: Wed Oct 16 12:32:12 2013 +0200 [indic] More granular post-base cluster merging! src/hb-ot-shape-complex-indic.cc | 45 ++++++++++++++++++++++++++++++++++------ 1 file changed, 39 insertions(+), 6 deletions(-) commit 9cb59d460e80d769087045535a8d54ec9ed7985c Author: Behdad Esfahbod Date: Wed Oct 16 11:34:07 2013 +0200 [indic] Fix cluster merging of left matras The merge_clusters there was totally broken. src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 190c8f2b60af0851bf692f653c1604cfbf0561a5 Author: Behdad Esfahbod Date: Wed Oct 16 11:33:18 2013 +0200 [indic] Adjust cluster merging under uniscribe mode for Tamil Apparently Uniscribe Tamil shaper doesn't ship chubby clusters for Tamil. Adjust to that. src/hb-ot-shape-complex-indic.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 5c558877da5db8c734ba072f01e5e4797876619c Author: Behdad Esfahbod Date: Wed Oct 16 11:14:15 2013 +0200 [indic] Allow up to two syllable modifiers Bug 70509 - Candrabindu+Visarga doesn't work in Devanagari https://bugs.freedesktop.org/show_bug.cgi?id=70509 We categorize both bindus and visarga as syllable-modifiers. OT spec doesn't actually say what characters go in the syllable modifier category, and allows one. We just allow up to two now. Test case: U+0930,U+0941,U+0901,U+0903 Uniscribe currently doesn't support that and produces a dotted circle. src/hb-ot-shape-complex-indic-machine.rl | 2 +- .../texts/in-tree/shaper-indic/indic/script-devanagari/misc/misc.txt | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) commit f5299eff5c0065d6329cd536c0ac339abea085b0 Author: Behdad Esfahbod Date: Tue Oct 15 18:13:07 2013 +0200 [indic] Simplify reph logic *Shouldn't* break anything. src/hb-ot-shape-complex-indic.cc | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) commit 65a929b1c033e91919c931b495a775f76b6dcbb3 Author: Behdad Esfahbod Date: Tue Oct 15 18:08:05 2013 +0200 [indic] If Malayalam dot-reph formed a ligature, don't move it Rachana-0.6 implements dot-reph by ligation, so we shouldn't move it. Uniscribe doesn't either. Test case: U+0D4E,U+0D1A,U+0D4D,U+0D1A,U+0D4D src/hb-ot-shape-complex-indic.cc | 23 ++++++++++++++++------ .../indic/script-malayalam/misc/dot-reph.txt | 3 +++ 2 files changed, 20 insertions(+), 6 deletions(-) commit a01cbf6cbe0021722302cfb58fb638a0a2427b26 Author: Behdad Esfahbod Date: Tue Oct 15 16:37:53 2013 +0200 [indic] Harmless reordering of Khmer features! src/hb-ot-shape-complex-indic.cc | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) commit c46f406973024051877e867b93614942ff80c107 Author: Behdad Esfahbod Date: Tue Oct 15 16:24:21 2013 +0200 [tests] Remove Myanmar micro-font and test .../sha1sum/ceadd106a8205214fbe7337ef9de32a862b59762.ttf | Bin 3040 -> 0 bytes test/shaping/tests/context-matching.tests | 1 - 2 files changed, 1 deletion(-) commit eb10233b267909dee0245f126000e117f3b21c35 Author: Behdad Esfahbod Date: Tue Oct 15 15:26:44 2013 +0200 [indic] Apply 'kern' for all scripts except for Khmer in Uniscribe mode Seems to better match Uniscribe. Note: NotoSansTelugu-Regular has kern feature, so this fixes most of the positioning failures there, except for the kern pairs blocked by a (non-)joiner, in which case we (correctly) kern, but Uniscribe doesn't. src/hb-ot-shape-complex-indic.cc | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) commit 30145272a7d428bc62a903388bd7be43f4da7fc3 Author: Behdad Esfahbod Date: Tue Oct 15 13:47:27 2013 +0200 [indic] Don't apply presentation features across syllables More like Uniscribe... We still allow user-defined features to work across syllables, but not pres,blws,abs,psts,etc. This "regressed" Sinhala numbers by 11. These are cases were there's Consonant followed by Ra,Halant,ZWJ at the of text. The Ra,Halant,ZWJ ends up forming reph, which is wrong... But before we were also ligating that reph with the previous consonant. That's even more wrong. That's also what Uniscribe does. Current numbers: BENGALI: 353732 out of 354188 tests passed. 456 failed (0.128745%) DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%) GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%) GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%) KANNADA: 951030 out of 951913 tests passed. 883 failed (0.0927606%) KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%) MALAYALAM: 1048140 out of 1048334 tests passed. 194 failed (0.0185056%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271655 out of 271847 tests passed. 192 failed (0.070628%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) src/hb-ot-shape-complex-indic.cc | 21 +++++++++++++++++---- .../shaper-indic/indic/script-sinhala/misc/misc.txt | 1 + 2 files changed, 18 insertions(+), 4 deletions(-) commit 3c7b3641cfb00f2c4dcc0768b9854e4f4410d15f Author: Behdad Esfahbod Date: Tue Oct 15 11:21:01 2013 +0200 [indic] Handle Avagraha It can come either at the end(ish!) of the syllable, or independently. When independent, it accepts a few bits and pieces. src/hb-ot-shape-complex-indic-machine.rl | 5 ++++- src/hb-ot-shape-complex-indic-private.hh | 5 +++-- src/hb-ot-shape-complex-indic.cc | 14 +++++++++++++- .../shaper-indic/indic/script-devanagari/misc/misc.txt | 1 + .../in-tree/shaper-indic/indic/script-telugu/misc/misc.txt | 1 + 5 files changed, 22 insertions(+), 4 deletions(-) commit 5e7432b8172473aa4dda3d51a79add9e97c2d2c1 Author: Behdad Esfahbod Date: Tue Oct 15 12:28:23 2013 +0200 [myanmar] Apply abvm/blwm src/hb-ot-shape-complex-myanmar.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) commit 8acbb6be271817c12d2ee0066b355e2fb0f9a934 Author: Behdad Esfahbod Date: Tue Oct 15 12:15:49 2013 +0200 [indic] Some scripts like blwf applied to pre-base characters ...while some don't! Improved Bengali, Devanagari, Gurmukhi, Malayalam. Updated numbers: BENGALI: 353732 out of 354188 tests passed. 456 failed (0.128745%) DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%) GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%) GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%) KANNADA: 951030 out of 951913 tests passed. 883 failed (0.0927606%) KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%) MALAYALAM: 1048134 out of 1048334 tests passed. 200 failed (0.0190779%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271666 out of 271847 tests passed. 181 failed (0.0665816%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) src/hb-ot-shape-complex-indic.cc | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) commit 2c85a3df0983f28aed77a0ea3bf2417ef65d4b84 Author: Behdad Esfahbod Date: Mon Oct 14 19:41:52 2013 +0200 Fix issue with automake test/shaping/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6b65a76b40522a4f57a6fedcbdfc5a4d736f1d3c Author: Behdad Esfahbod Date: Mon Oct 14 18:51:39 2013 +0200 [otlayout] Fix (Chain)Context recursion! Previously we only supported recursive sublookups with ascending indices. We were also not correctly handling non-1-to-1 recursed lookups. Fix all that! Fixes the three tests in test/shaping/tests/context-matching.tests, which were derived from NotoSansBengali and NotoSansDevanagari among others. src/hb-buffer-private.hh | 4 + src/hb-buffer.cc | 46 ++++++++++ src/hb-ot-layout-common-private.hh | 1 + src/hb-ot-layout-gsub-table.hh | 1 + src/hb-ot-layout-gsubgpos-private.hh | 157 +++++++++++++++++------------------ 5 files changed, 127 insertions(+), 82 deletions(-) commit 841e20d083aec8d814cd8d90aa6ab60127c0d1f2 Author: Behdad Esfahbod Date: Mon Oct 14 18:47:51 2013 +0200 Add test suite for shaping results The new test suite runs tests included under hb/test/shaping/tests/*.tests, which themselves reference font files stored by sha1sum under hb/test/shaping/fonts/sha1sum. The fonts are produced using a subsetter to only include glyphs needed to run the test. Four initial tests are added for (Chain)Context matching, of which three currently fail. test/shaping/Makefile.am | 10 +++++- .../4cce528e99f600ed9c25a2b69e32eb94a03b4ae8.ttf | Bin 0 -> 1320 bytes .../ceadd106a8205214fbe7337ef9de32a862b59762.ttf | Bin 0 -> 3040 bytes .../d629e7fedc0b350222d7987345fe61613fa3929a.ttf | Bin 0 -> 1768 bytes .../f499fbc23865022234775c43503bba2e63978fe1.ttf | Bin 0 -> 3564 bytes test/shaping/run-tests.sh | 34 +++++++++++++++++++++ test/shaping/tests/MANIFEST | 1 + test/shaping/tests/context-matching.tests | 4 +++ 8 files changed, 48 insertions(+), 1 deletion(-) commit e2dab69291a5d86fc90a8c273c458c16574eafb5 Author: Behdad Esfahbod Date: Mon Oct 14 16:44:44 2013 +0200 Minor test/shaping/hb_test_tools.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4e6e53db5da0a5da87ae732c3f9d01babf4ae6c2 Author: Behdad Esfahbod Date: Mon Oct 14 13:06:36 2013 +0200 [otlayout] "Minor" src/hb-ot-layout.cc | 1 + 1 file changed, 1 insertion(+) commit 9326d48e4309901e7e0b0e15230936a21ee3df72 Author: Behdad Esfahbod Date: Thu Oct 10 20:04:42 2013 +0200 Don't use g_mapped_file_unref() Was introduced in glib 2.22. src/test-buffer-serialize.cc | 2 +- src/test-size-params.cc | 2 +- src/test-would-substitute.cc | 2 +- src/test.cc | 2 +- util/options.cc | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) commit e152d1a27891bd1d9d46a9c028c026843bad384a Author: Behdad Esfahbod Date: Thu Oct 3 15:09:37 2013 -0400 0.9.22 NEWS | 13 +++++++++++++ configure.ac | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) commit 27674b4bb351e501373bd9994e4ba6546e465cf7 Author: Behdad Esfahbod Date: Thu Oct 3 14:54:50 2013 -0400 [OTLayout] Protect against out-of-range lookup indices Filter them out when compiling map. src/hb-ot-layout.cc | 17 +++++++++++++++++ src/hb-ot-layout.h | 5 +++++ src/hb-ot-map.cc | 8 +++++++- 3 files changed, 29 insertions(+), 1 deletion(-) commit 6b4fdded94b7efb96c6e41cca4350878ed859ff1 Author: Behdad Esfahbod Date: Mon Sep 30 13:48:19 2013 -0400 Update git.mk git.mk | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) commit 2a2b5b89ef3a606ba2996bc89fd1c577a6c98f40 Author: M1cha Date: Mon Sep 30 08:55:52 2013 +0000 Cleanup Android.mk - use common src files for both static and shared libs - remove empty LOCAL_SHARED_LIBRARIES Android.mk | 58 +++++++++++++++++----------------------------------------- 1 file changed, 17 insertions(+), 41 deletions(-) commit 622bc3d829cab84c3a4148b88f2c91fee491ef39 Merge: 3d2c4f0c d583df1e Author: Behdad Esfahbod Date: Sun Sep 29 13:31:58 2013 -0700 Merge pull request #4 from amarullz/master Add build static library on Android.mk commit 3d2c4f0c2ff8fab4262988aad65b170e5b479b20 Author: Behdad Esfahbod Date: Fri Sep 27 17:06:29 2013 -0400 Fix hiding of default_ignorables if font doesn't have space glyph Based on patch from Jonathan Kew. See discussion on the list. src/hb-ot-shape.cc | 40 ++++++++++++++++++++++++++++++---------- 1 file changed, 30 insertions(+), 10 deletions(-) commit d583df1e78003f8f1039ad72331bf877b13d1ae5 Author: Ahmad Amarullah Date: Fri Sep 27 19:04:32 2013 +0700 Add build static library on Android.mk Use UCDN instead ICU HAVE Freetype Android.mk | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) commit 078de49ca10285f6cd1452abd40f831a17af5d1a Author: Behdad Esfahbod Date: Thu Sep 26 18:26:43 2013 -0400 [util] Don't use g_array_unref() Was introduced in glib 2.22. util/view-cairo.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 48360ec03b225dfec5f90bc5cb93122203d2dd6b Author: Behdad Esfahbod Date: Thu Sep 26 16:48:42 2013 -0400 Bug 68990 - test-common fails on i686-linux Fix use-after-end-of-scope. src/hb-common.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit b61f97d544ce43d85f5fe93e682c324e042c0770 Author: Behdad Esfahbod Date: Mon Sep 16 22:07:22 2013 -0400 0.9.21 NEWS | 12 ++++++++++++ configure.ac | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) commit 2af826296315d89f3a433952903c5968e56044ea Author: Behdad Esfahbod Date: Mon Sep 16 21:49:56 2013 -0400 Improve library checks src/Makefile.am | 1 + src/check-defs.sh | 44 ++++++++++++++++++++++++++++++++++++++++++++ src/check-symbols.sh | 37 ++++++++++++------------------------- 3 files changed, 57 insertions(+), 25 deletions(-) commit 882edce48e507a1c76c908ec2db04aac218b67d6 Author: Behdad Esfahbod Date: Fri Sep 13 20:36:43 2013 -0400 [graphite2] Fix include src/hb-graphite2.cc | 5 ++--- src/hb-graphite2.h | 2 ++ 2 files changed, 4 insertions(+), 3 deletions(-) commit ace5c7eb4c2302a6a7eb3576e6dbc3bc026e569c Author: Behdad Esfahbod Date: Fri Sep 13 20:34:42 2013 -0400 [introspection] hb-ft annotations src/hb-face.cc | 2 +- src/hb-ft.cc | 30 +++++++++++++++++++++++++++++- 2 files changed, 30 insertions(+), 2 deletions(-) commit a8949df48780e680e03b9afbbafb3628a0acef52 Author: Behdad Esfahbod Date: Fri Sep 13 20:23:51 2013 -0400 [introspection] Annotate Unicode / font callbacks Should move these out of the public header... We're "clean" of introspection warnings now. Remaining ones are about graphite2 / freetype types not being introspectable. src/hb-blob.cc | 4 +- src/hb-face.cc | 2 +- src/hb-font.cc | 4 +- src/hb-font.h | 132 +++++++++++++++++++++++++++++++++++++++++++++++++++++-- src/hb-unicode.h | 106 ++++++++++++++++++++++++++++++++++++++++---- 5 files changed, 231 insertions(+), 17 deletions(-) commit 4b011094d5e90cf93df2891e47aeab1bffad5bbf Author: Behdad Esfahbod Date: Fri Sep 13 20:17:42 2013 -0400 Move code around I believe I didn't break anything... src/hb-ot-shape.cc | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) commit 4878db218202ed804c9f76edb7e4aa220de8a8d8 Author: Behdad Esfahbod Date: Thu Sep 12 20:56:32 2013 -0400 Remove contrib/ Python hand-coded binding stuff gobject-introspection coming together. contrib/README | 2 - contrib/python/README | 10 -- contrib/python/lib/fontconfig.pyx | 47 --------- contrib/python/lib/harfbuzz.pyx | 213 -------------------------------------- contrib/python/scripts/hbtestfont | 116 --------------------- contrib/python/setup.py | 39 ------- 6 files changed, 427 deletions(-) commit e478ebe4d3f74dc271ffe88680fd29f6b1924c93 Author: Behdad Esfahbod Date: Thu Sep 12 20:53:07 2013 -0400 [introspection] Add sample.py src/sample.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) commit dfdbe7f932daffcf73911ff4e4a36f749164d960 Author: Behdad Esfahbod Date: Thu Sep 12 20:52:20 2013 -0400 [introspection] Make hb_blob_create() introspectable src/Makefile.am | 2 ++ src/hb-blob.cc | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) commit 085d4291a9f253a4b8e2eec8003ac11d02a9394f Author: Behdad Esfahbod Date: Thu Sep 12 17:14:33 2013 -0400 [introspection] Disable constructors for now Since our types are not associated with their methods, marking constructors makes them inaccessible from bindings. Undo for now. src/hb-blob.cc | 2 +- src/hb-buffer.cc | 2 +- src/hb-face.cc | 2 +- src/hb-font.cc | 4 ++-- src/hb-set.cc | 2 +- src/hb-shape-plan.cc | 2 +- src/hb-unicode.cc | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) commit 6c48f20eea22c6e686416ab4ec8388be3e8cd0b5 Author: Behdad Esfahbod Date: Mon Sep 9 15:43:10 2013 -0400 [otlayout] Add structs for JSTF table src/Makefile.am | 1 + src/hb-ot-head-table.hh | 2 +- src/hb-ot-hhea-table.hh | 2 +- src/hb-ot-hmtx-table.hh | 2 +- src/hb-ot-layout-gdef-table.hh | 2 +- src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-layout-gsub-table.hh | 2 +- src/hb-ot-layout-jstf-table.hh | 229 +++++++++++++++++++++++++++++++++++++++++ src/hb-ot-layout.cc | 1 + src/hb-ot-layout.h | 1 + src/hb-ot-maxp-table.hh | 2 +- src/hb-ot-name-table.hh | 2 +- src/main.cc | 2 +- 13 files changed, 241 insertions(+), 9 deletions(-) commit 70303cf23b22647bf641be22c8650310128322a9 Author: Behdad Esfahbod Date: Fri Sep 6 17:35:57 2013 -0400 [docs/introspection] Some more annotations src/hb-common.cc | 151 ++++++++++++++++++++++++++++++++++++++++++++++++++-- src/hb-font.cc | 16 +++--- src/hb-version.h.in | 19 ------- 3 files changed, 155 insertions(+), 31 deletions(-) commit 288f2899979bcc9e68f8115cb76e3271ed0e17bc Author: Behdad Esfahbod Date: Fri Sep 6 15:40:22 2013 -0400 [docs/introspection] More annotations src/hb-blob.cc | 63 +++--- src/hb-buffer-serialize.cc | 63 ++++++ src/hb-buffer.cc | 307 ++++++++++++++++++++++++++- src/hb-face.cc | 171 +++++++++++++++ src/hb-font-private.hh | 4 +- src/hb-font.cc | 504 ++++++++++++++++++++++++++++++++++++++++++++- src/hb-set.cc | 2 +- src/hb-shape-plan.cc | 104 ++++++++++ src/hb-shape.cc | 56 +++++ src/hb-unicode.cc | 128 ++++++++++++ 10 files changed, 1355 insertions(+), 47 deletions(-) commit 17905c54f1bab9e6dfe13f59f5ec208de12832f7 Author: Behdad Esfahbod Date: Fri Sep 6 16:57:01 2013 -0400 [introspection] Work around g-i limitation with hb_language_t src/hb-gobject-structs.cc | 15 +++++++++++---- src/hb-gobject-structs.h | 8 ++++++++ 2 files changed, 19 insertions(+), 4 deletions(-) commit cd361c3cbe4a288e3019b9a029f44e4c5f24436c Author: Behdad Esfahbod Date: Fri Sep 6 16:20:21 2013 -0400 Minor change to hb_language_t Let me know if this breaks anyone's anything. src/hb-common.cc | 2 +- src/hb-common.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 20cbc1f8eb0811e6cefa3be3550e80df9c372782 Author: Behdad Esfahbod Date: Fri Sep 6 15:29:22 2013 -0400 Annotate hb-set a bit; add HB_SET_VALUE_INVALID src/hb-set-private.hh | 20 +++-- src/hb-set.cc | 244 ++++++++++++++++++++++++++++++++++++++++++++++++++ src/hb-set.h | 2 + src/hb-version.h.in | 6 +- test/api/test-set.c | 26 +++--- 5 files changed, 276 insertions(+), 22 deletions(-) commit c44b81833d5bfb9a926d348a76463314c3ec2018 Author: Behdad Esfahbod Date: Fri Sep 6 15:13:16 2013 -0400 Whitespace src/hb-buffer.cc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit ae9dc717d37d58efdd3fabbe4a9c3c2bf9dc3568 Author: Behdad Esfahbod Date: Thu Sep 5 16:40:37 2013 -0400 [gtk-doc] Pass source files to gtk-doc docs/reference/Makefile.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 5f512017ba615ba6ac8e5da2ea0c57a72db2c26b Author: Behdad Esfahbod Date: Wed Sep 4 18:28:39 2013 -0400 [docs] Document a few symbols src/hb-blob.cc | 160 +++++++++++++++++++++++++++++++++++++++++++++++++++- src/hb-buffer.cc | 78 ++++++++++++++++++++++++- src/hb-version.h.in | 17 ++++++ 3 files changed, 251 insertions(+), 4 deletions(-) commit e0dbf99b4497be305d689a528282fd37214e7f1c Author: Behdad Esfahbod Date: Thu Sep 5 16:00:47 2013 -0400 [introspection] Pass source files to scanner src/Makefile.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 5a5350b39b81e0128d36ebc81307a6d698a4dc50 Author: Behdad Esfahbod Date: Tue Sep 3 20:11:01 2013 -0400 Revert "Round when scaling values" This reverts commit 10f964623f003c70f6bdd33423420abda3820ce0. See discussion with Khaled Hosny on mailing list. In short, since integers here can be negative, and int division is "round towards zero", proper rounding should take sign into account. Just skip doing it again, has been serving us well before. TODO | 2 ++ src/hb-font-private.hh | 6 +----- 2 files changed, 3 insertions(+), 5 deletions(-) commit 74ff41c3a573bdf74b60623065eb92a49f055893 Author: Behdad Esfahbod Date: Tue Sep 3 20:09:14 2013 -0400 Minor Makefile.am | 2 ++ 1 file changed, 2 insertions(+) commit 63dd4b0ac2076fe9cc3dfe5d31ef3616d4ed01e5 Author: Behdad Esfahbod Date: Tue Sep 3 20:01:40 2013 -0400 [gtk-doc] Remove hack for deleting tmpl/ This was introduced in 029f46bde7e39094d3decb46525e91a97c5cc02c and was in fact a bug in gtk-doc master: https://bugzilla.gnome.org/show_bug.cgi?id=707426 docs/reference/Makefile.am | 5 ----- 1 file changed, 5 deletions(-) commit 213001aa99003422199245e96878f9fe348c55b4 Author: Behdad Esfahbod Date: Tue Sep 3 20:00:16 2013 -0400 [build] Fix EXTRA_DIST I was under the impression that EXTRA_DISTs will happen regardless of automake conditionals. Apparently I was wrong. src/Makefile.am | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit 1e994a8fcc94dfea42a6cbfe23a401142d79a1a6 Author: Behdad Esfahbod Date: Tue Sep 3 18:11:47 2013 -0400 [gtk-doc] Copy makefile autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 81a007ffad683e53f12093a0c9e30112106f415d Author: Behdad Esfahbod Date: Fri Aug 30 19:45:13 2013 -0400 [TODO] Update TODO | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) commit a2a28235e8131a1e1d4b8c3d0933df5cf056bbc6 Author: Behdad Esfahbod Date: Fri Aug 30 19:38:47 2013 -0400 [gtk-doc] Generate version.xml from configure Even though this is not what autoconf recommends, it reduces doc rebuilds when version doesn't change but configure changes. configure.ac | 1 + docs/reference/Makefile.am | 11 +++-------- docs/reference/version.xml.in | 1 + 3 files changed, 5 insertions(+), 8 deletions(-) commit ac1b723917d9b8f247a350f8d3e1bc5d1e472073 Author: Behdad Esfahbod Date: Fri Aug 30 19:32:10 2013 -0400 Remove hb-old and hb-icu-le test shapers They've been disabled for a while and no one cared. We're past the point to need them for testing, and if we ever need to resurrect them again, well, they're in git graveyard somewhere. configure.ac | 23 +- src/Makefile.am | 28 +- src/hb-icu-le.cc | 265 -- src/hb-icu-le/COPYING | 2 - src/hb-icu-le/FontTableCache.cpp | 91 - src/hb-icu-le/FontTableCache.h | 48 - src/hb-icu-le/Makefile.am | 25 - src/hb-icu-le/PortableFontInstance.cpp | 275 -- src/hb-icu-le/PortableFontInstance.h | 119 - src/hb-icu-le/README | 3 - src/hb-icu-le/cmaps.cpp | 200 -- src/hb-icu-le/cmaps.h | 87 - src/hb-icu-le/letest.h | 63 - src/hb-icu-le/license.html | 51 - src/hb-icu-le/sfnt.h | 453 --- src/hb-old.cc | 410 --- src/hb-old/COPYING | 24 - src/hb-old/Makefile.am | 56 - src/hb-old/README | 7 - src/hb-old/harfbuzz-arabic.c | 1150 ------ src/hb-old/harfbuzz-buffer-private.h | 107 - src/hb-old/harfbuzz-buffer.c | 383 -- src/hb-old/harfbuzz-buffer.h | 102 - src/hb-old/harfbuzz-external.h | 106 - src/hb-old/harfbuzz-gdef-private.h | 135 - src/hb-old/harfbuzz-gdef.c | 1163 ------ src/hb-old/harfbuzz-gdef.h | 140 - src/hb-old/harfbuzz-global.h | 125 - src/hb-old/harfbuzz-gpos-private.h | 729 ---- src/hb-old/harfbuzz-gpos.c | 6094 -------------------------------- src/hb-old/harfbuzz-gpos.h | 155 - src/hb-old/harfbuzz-greek.c | 447 --- src/hb-old/harfbuzz-gsub-private.h | 483 --- src/hb-old/harfbuzz-gsub.c | 4329 ----------------------- src/hb-old/harfbuzz-gsub.h | 148 - src/hb-old/harfbuzz-hangul.c | 268 -- src/hb-old/harfbuzz-hebrew.c | 187 - src/hb-old/harfbuzz-impl.c | 84 - src/hb-old/harfbuzz-impl.h | 135 - src/hb-old/harfbuzz-indic.cpp | 1868 ---------- src/hb-old/harfbuzz-khmer.c | 642 ---- src/hb-old/harfbuzz-myanmar.c | 511 --- src/hb-old/harfbuzz-open-private.h | 102 - src/hb-old/harfbuzz-open.c | 1433 -------- src/hb-old/harfbuzz-open.h | 288 -- src/hb-old/harfbuzz-shaper-all.cpp | 37 - src/hb-old/harfbuzz-shaper-private.h | 159 - src/hb-old/harfbuzz-shaper.cpp | 996 ------ src/hb-old/harfbuzz-shaper.h | 265 -- src/hb-old/harfbuzz-stream-private.h | 81 - src/hb-old/harfbuzz-stream.c | 114 - src/hb-old/harfbuzz-stream.h | 51 - src/hb-old/harfbuzz-tibetan.c | 249 -- src/hb-old/harfbuzz.h | 38 - 54 files changed, 2 insertions(+), 25532 deletions(-) commit b94243d6a9457864ad8ef3ad47ad01985b138862 Author: Behdad Esfahbod Date: Fri Aug 30 18:41:33 2013 -0400 [g-i] Rename library from harfbuzz to HarfBuzz src/Makefile.am | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit f730b5d1e2369762952481f1a2d3db26a2b48015 Author: Behdad Esfahbod Date: Thu Aug 29 15:53:33 2013 -0400 0.9.20 NEWS | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 49 insertions(+), 1 deletion(-) commit b0e03508bad04d7dcf2c50ac81f6261425b34c5f Author: Behdad Esfahbod Date: Thu Aug 29 15:56:32 2013 -0400 Dist with gobject and introspection enabled Makefile.am | 2 ++ 1 file changed, 2 insertions(+) commit e4ce6745e15eab33ed693874e7a56981f4d6f79a Author: Behdad Esfahbod Date: Thu Aug 29 15:56:16 2013 -0400 [gtk-doc] Fix build without gobject docs/reference/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 263372f15ffdf4c0e4386133f64ff389ba73de33 Author: Behdad Esfahbod Date: Wed Aug 28 13:43:54 2013 -0400 Remove gtk-doc.make It's copied by gtk-docize. gtk-doc.make | 302 ----------------------------------------------------------- 1 file changed, 302 deletions(-) commit 79d754efeef89543d51775b110e8bd49cf7e699b Author: Behdad Esfahbod Date: Wed Aug 28 13:43:35 2013 -0400 Fix build configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 71ef22b04d466803076af1da6763fecab95ce5bb Author: Behdad Esfahbod Date: Wed Aug 28 12:52:55 2013 -0400 Turn hb-gobject, and introspection off by default Also enable bootstrapping without them. configure.ac | 39 ++++++++++++++++++++++++++++++++++----- src/Makefile.am | 5 +++-- 2 files changed, 37 insertions(+), 7 deletions(-) commit d8f507099b9ae5f0c643fb8dddbb069df6f62a94 Author: Behdad Esfahbod Date: Mon Aug 26 21:26:24 2013 -0400 Hookup harfbuzz-gobject to introspection src/Makefile.am | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) commit 71439a8c7ae9df25193bc3ad0f203117d2884a19 Author: Behdad Esfahbod Date: Mon Aug 26 20:56:58 2013 -0400 [gobject] Flesh out hb-gobject Move it to new harfbuzz-gobject library. Implement enums and boxed types for object-types. Still have to do boxed types for value types. configure.ac | 12 ++++- docs/reference/Makefile.am | 12 ++++- docs/reference/harfbuzz-docs.xml | 3 ++ docs/reference/harfbuzz-sections.txt | 48 +++++++++++++++++++- src/Makefile.am | 48 +++++++++++++------- src/harfbuzz-gobject.pc.in | 12 +++++ src/hb-gobject-enums.cc.tmpl | 11 +++-- src/hb-gobject-enums.h.tmpl | 55 +++++++++++++++++++++++ src/hb-gobject-structs.cc | 84 +++++++++++++++++++++++++++------- src/hb-gobject-structs.h | 87 ++++++++++++++++++++++++++++++++++++ src/hb-gobject.h | 38 ++-------------- 11 files changed, 333 insertions(+), 77 deletions(-) commit 23027f7611b53b594e4b4008e916e42b5154f6ac Author: Behdad Esfahbod Date: Thu Aug 22 19:03:21 2013 -0400 [introspection] Enable gobject-introspection again configure.ac | 7 ++++--- src/Makefile.am | 49 ++++++++++++++++++++++++++++--------------------- 2 files changed, 32 insertions(+), 24 deletions(-) commit 757a7a9018577dcc399be03dc45a59589585d2fb Author: Behdad Esfahbod Date: Wed Aug 28 12:35:13 2013 -0400 [uniscribe] Fixed build with wide chars https://github.com/blinkseb/harfbuzz/commit/f65dafa4138e1fb4395bf646fa33bb01a86a7e9a src/hb-uniscribe.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4dc798de19c767b91fd3025c85593fa6809d1340 Author: Behdad Esfahbod Date: Mon Aug 26 20:39:00 2013 -0400 Add hb-deprecated.h, and rename a couple enum values Add deprecated alias for old name. src/Makefile.am | 1 + src/hb-buffer.cc | 4 ++-- src/hb-buffer.h | 8 +++---- src/hb-common.h | 5 ----- src/hb-deprecated.h | 51 ++++++++++++++++++++++++++++++++++++++++++++ src/hb.h | 1 + src/test-buffer-serialize.cc | 2 +- test/api/test-buffer.c | 2 +- util/Makefile.am | 1 + util/hb-shape.cc | 2 +- util/options.hh | 2 +- 11 files changed, 64 insertions(+), 15 deletions(-) commit 2e3a07abdf97b0ad2105c3a52f3ff0e0b60b29c4 Author: Behdad Esfahbod Date: Mon Aug 26 18:49:07 2013 -0400 Separate face source code from font Makes documentation / introspection easier. Android.mk | 1 + docs/reference/harfbuzz-docs.xml | 1 + docs/reference/harfbuzz-sections.txt | 6 +- src/Makefile.am | 3 + src/hb-face-private.hh | 108 ++++++++++++ src/hb-face.cc | 311 +++++++++++++++++++++++++++++++++++ src/hb-face.h | 117 +++++++++++++ src/hb-font-private.hh | 67 +------- src/hb-font.cc | 269 ------------------------------ src/hb-font.h | 75 +-------- src/hb.h | 1 + 11 files changed, 549 insertions(+), 410 deletions(-) commit d3490761e11ae308fbd8aaf02059653f579035c5 Author: Behdad Esfahbod Date: Mon Aug 26 21:15:29 2013 -0400 Improve check-includes.sh src/check-includes.sh | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) commit 381f2fb5e664715d67ffc9a234b0fd8aa540fada Author: Behdad Esfahbod Date: Mon Aug 26 19:20:38 2013 -0400 Minor docs/reference/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ac1f09b53e2c5d14c874e4d9f1b25b03ea1d1c44 Author: Behdad Esfahbod Date: Mon Aug 26 18:50:12 2013 -0400 [gtk-doc] Fix maintainer-clean rule docs/reference/Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 38b8b40526a85f33521542e24d1e0c82588efc85 Author: Behdad Esfahbod Date: Tue Aug 27 11:44:09 2013 -0400 Fix possible snprintf OOM https://bugzilla.redhat.com/show_bug.cgi?id=1001645 src/hb-buffer-serialize.cc | 14 +++++++------- src/hb-font-private.hh | 3 ++- src/hb-shape.cc | 6 +++--- 3 files changed, 12 insertions(+), 11 deletions(-) commit d22548c0e362cc9447557440af9ecbb11badfa78 Author: Behdad Esfahbod Date: Mon Aug 26 18:46:21 2013 -0400 [check-*] Minor src/check-c-linkage-decls.sh | 4 ++-- src/check-header-guards.sh | 4 ++-- src/check-includes.sh | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) commit 029f46bde7e39094d3decb46525e91a97c5cc02c Author: Behdad Esfahbod Date: Mon Aug 26 18:11:07 2013 -0400 [gtk-doc] Remove tmpl in make maintainer-clean docs/reference/Makefile.am | 3 +++ 1 file changed, 3 insertions(+) commit dddf990c3687a47297eafc82b54fa96842e68003 Author: Behdad Esfahbod Date: Mon Aug 26 17:58:25 2013 -0400 [git.mk] Update git.mk | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) commit 700a15fe4b80da9c67befd85ae10a166f5b65962 Author: Behdad Esfahbod Date: Mon Aug 26 17:49:36 2013 -0400 Add HB_DISABLE_DEPRECATED That moment that you have to accept that you made API mistakes... docs/reference/Makefile.am | 2 +- docs/reference/harfbuzz-sections.txt | 8 +++++--- src/hb-common.h | 4 +++- 3 files changed, 9 insertions(+), 5 deletions(-) commit ddc456a519a9a59e96f9d7fcad988369e0a8842b Author: Behdad Esfahbod Date: Mon Aug 26 17:34:18 2013 -0400 [travis] Add graphite2 .travis.yml | 1 + 1 file changed, 1 insertion(+) commit f7c72b42efb8d42859023659fd2e3d589523436d Author: Anthony Carrico Date: Sun Feb 24 13:00:33 2013 -0500 [gtk-doc] Initial setup Initial setup of gtk-doc. Straight forward setup following the gtk-doc instructions. Ignore some troublesome types in src/hb-gobject.h. To build use "./autogen.sh --enable-gtk-doc" then "make". Docs are in harfbuzz/docs/reference/html/index.html. .travis.yml | 10 +- Makefile.am | 7 +- autogen.sh | 7 + configure.ac | 7 +- docs/Makefile.am | 1 + docs/reference/Makefile.am | 109 +++++++++ docs/reference/harfbuzz-docs.xml | 61 +++++ docs/reference/harfbuzz-overrides.txt | 0 docs/reference/harfbuzz-sections.txt | 431 ++++++++++++++++++++++++++++++++++ gtk-doc.make | 302 ++++++++++++++++++++++++ src/Makefile.am | 2 +- src/hb-gobject.h | 3 +- 12 files changed, 931 insertions(+), 9 deletions(-) commit 3409fb1c767118067cf7edfb97068936b6f4b717 Author: Behdad Esfahbod Date: Wed Aug 21 17:22:21 2013 -0400 [uniscribe] Ask Uniscribe to return shaping results in logical order See discussion on the list in the thread "Arabic presentation forms and the uniscribe backend". Based on patch from Jonathan Kew. src/hb-uniscribe.cc | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) commit 1d05fdd09fa271b641f30a2138171e6fafcd8db7 Author: Behdad Esfahbod Date: Tue Aug 20 13:22:21 2013 -0400 [uniscribe] Print run info src/hb-uniscribe.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit 3613696b57225111507a3f4263f5fa6937d0bc72 Author: Behdad Esfahbod Date: Mon Aug 12 00:33:28 2013 -0400 [coretext] Fully support user features Based on patch from Jonathan Kew and data from Apple. It's not working correctly though, and I suspect I'm hitting a bug in CoreText. When I do this: hb-shape /Library/Fonts/Zapfino.ttf ZapfinoZapfino --shaper coretext \ --features=-liga I expect both ligatures to turn off, but only the second one does: [Z_a_p_f_i_n_o=0+2333|Z=7+395|a=8+285|p_f=9+433|i=11+181|n=12+261|o=13+250] whereas if I disable 'dlig' instead of 'liga', both are turned off. Smells... Doesn't resolve conflicting feature settings. src/hb-coretext.cc | 446 +++++++++++++++++++++++++++++++++++++++++++++++----- src/hb-uniscribe.cc | 2 +- 2 files changed, 404 insertions(+), 44 deletions(-) commit 54e6f6c588a164f7de62ff88b3eff4f25adb8f17 Author: Behdad Esfahbod Date: Fri Aug 9 14:34:54 2013 -0400 Clean up list of Unicode scripts Rename HB_SCRIPT_CANADIAN_ABORIGINAL to HB_SCRIPT_CANADIAN_SYLLABICS and a macro for the old name. src/hb-common.h | 277 ++++++++++++++++++++----------------- src/hb-glib.cc | 2 +- src/hb-ot-shape-complex-private.hh | 2 + src/hb-ucdn.cc | 2 +- test/api/test-unicode.c | 2 +- 5 files changed, 153 insertions(+), 132 deletions(-) commit 7cd4a715848c44be9aec6b6b622cfc2a60b1a5a9 Author: Behdad Esfahbod Date: Fri Aug 9 09:41:48 2013 -0400 Update TODO TODO | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 515a0ac81e531c95b1bb7f1a3c5df73a9e64b14f Author: Behdad Esfahbod Date: Fri Aug 9 09:40:59 2013 -0400 Fix compiler warning src/hb-ot-layout-common-private.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 10f964623f003c70f6bdd33423420abda3820ce0 Author: Behdad Esfahbod Date: Fri Aug 9 09:40:01 2013 -0400 Round when scaling values Doesn't matter for most users since they should be working in a fixed sub-pixel scale anyway (ie. 22.10, 26.6, 16.16, etc). TODO | 2 -- src/hb-font-private.hh | 6 +++++- 2 files changed, 5 insertions(+), 3 deletions(-) commit df8f70ae5de6181d56efa3f076f14e4d52119a5e Author: Behdad Esfahbod Date: Fri Aug 9 09:35:10 2013 -0400 Minor src/hb-font-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ce8badf1808f9fbdd9a22e9215c7475d3afde5ed Author: Behdad Esfahbod Date: Fri Aug 9 09:31:06 2013 -0400 Minor src/hb-font-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d71c0df2d17f4590d5611239577a6cb532c26528 Author: Behdad Esfahbod Date: Fri Aug 9 09:28:32 2013 -0400 Remove vrt2, vkrn, vpal, and valt from default vertical features See thread by John Dagget on the list. TODO | 2 -- src/hb-ot-shape.cc | 9 --------- 2 files changed, 11 deletions(-) commit a782a5e9a37c8733ac2830410a514d38635b543a Author: Behdad Esfahbod Date: Wed Aug 7 21:08:54 2013 -0400 [coretext] Start adding support for features Unlike AAT, looks like with CoreText very few OT features can be mapped. :( src/hb-coretext.cc | 65 +++++++++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 54 insertions(+), 11 deletions(-) commit bdd8873fd8ae5c794018f6edac242b0a8b62ff31 Author: Behdad Esfahbod Date: Wed Aug 7 17:58:25 2013 -0400 Revert "[Indic] don't apply 'calt' by default in Indic shaper" This reverts commit 952121007c6f6f374e4cf1734ebcfe2d2d71c71c. In light of discussion on the mailing list... src/hb-ot-shape-complex-indic.cc | 4 ---- 1 file changed, 4 deletions(-) commit 9a175914d72187d0c3f50ddad50c9569649c3072 Author: Behdad Esfahbod Date: Wed Aug 7 17:26:13 2013 -0400 [uniscribe] Support feature ranges As Khaled pointed out, right now setting any features, turns kern and possibly other features off. src/hb-uniscribe.cc | 232 ++++++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 199 insertions(+), 33 deletions(-) commit 627af695e48ef10b6e634c34b723f7e7013467f6 Author: Behdad Esfahbod Date: Tue Aug 6 16:53:56 2013 -0400 More git.mk updates git.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 722252743d59e4cd53cb71720d823ea00b708ad8 Author: Behdad Esfahbod Date: Tue Aug 6 15:19:23 2013 -0400 Update git.mk git.mk | 37 +++++++++++++++++++++++-------------- 1 file changed, 23 insertions(+), 14 deletions(-) commit 38d5c58d23fce38221689cda98cea1c3e42ed615 Author: Behdad Esfahbod Date: Tue Aug 6 14:45:36 2013 -0400 [uniscribe] Half-support user features Turning features on globally works now. src/hb-uniscribe.cc | 54 ++++++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 43 insertions(+), 11 deletions(-) commit 639afdc690c681a302080239a1967ce735ba5be5 Author: Behdad Esfahbod Date: Tue Aug 6 14:28:12 2013 -0400 Minor src/hb-private.hh | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) commit 952121007c6f6f374e4cf1734ebcfe2d2d71c71c Author: Jonathan Kew Date: Tue Aug 6 10:36:14 2013 -0400 [Indic] don't apply 'calt' by default in Indic shaper src/hb-ot-shape-complex-indic.cc | 4 ++++ 1 file changed, 4 insertions(+) commit 625678436c29100eef82d87e635b251030a18f60 Author: Behdad Esfahbod Date: Mon Aug 5 22:44:18 2013 -0400 Fix glyph closure with class==0 As reported by cibu. Untested. src/hb-ot-layout-common-private.hh | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) commit 580d5eb93af5bbbc64994b626d5e011e2c256d74 Author: Behdad Esfahbod Date: Sun Aug 4 16:55:21 2013 -0400 Don't apply 'dlig' by default Windows 8 doesn't, and the spec will be fixed. src/hb-ot-shape-complex-arabic.cc | 1 - 1 file changed, 1 deletion(-) commit 48382e2f41499a91181bea0acc5792989d2485bb Author: Behdad Esfahbod Date: Tue Jul 30 18:25:39 2013 -0400 Minor src/hb-ot-layout-common-private.hh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit c461371419d186811d4bfc768e26535f48a807f4 Author: Behdad Esfahbod Date: Tue Jul 30 14:48:23 2013 -0400 [CoreText] Don't leak the CTLine object (and everything that hangs off it) Patch from Jonathan Kew. src/hb-coretext.cc | 2 ++ 1 file changed, 2 insertions(+) commit 5fbc952524ac8840f007dc0136823a4ab6e25f70 Author: Behdad Esfahbod Date: Mon Jul 29 14:34:40 2013 -0400 Fix glyph name printing in hb-ot-shape-closure util/hb-ot-shape-closure.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6fadd9dd7cc220f131c29946285831635afc8044 Author: Behdad Esfahbod Date: Fri Jul 26 10:33:06 2013 -0400 Apply 'mark' to Myanmar According to Andrew Glass: "The issue with Myanmar feature was fixed via a servicing patch as soon as Windows 8 became available." src/hb-ot-shape-complex-myanmar.cc | 11 ----------- 1 file changed, 11 deletions(-) commit 86522e493d071f395b5abf64289232bf8867ac29 Author: Behdad Esfahbod Date: Mon Jul 22 19:07:53 2013 -0400 Fix glyph closure recursion! src/hb-ot-layout-gsubgpos-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 74439d0aa10184451adc6c6469f5119be352ecbb Author: Behdad Esfahbod Date: Mon Jul 22 19:02:29 2013 -0400 Minor src/hb-ot-layout-gsubgpos-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8b427c78efa988ed27a2a394146d73f59688707b Author: Behdad Esfahbod Date: Mon Jul 22 10:57:05 2013 -0400 [uniscribe] Sanitize font file src/hb-uniscribe.cc | 4 ++++ 1 file changed, 4 insertions(+) commit 12ff69df21ac91ae21860db7000d9f9973d3da1a Author: Behdad Esfahbod Date: Mon Jul 22 10:52:12 2013 -0400 [uniscribe] Handle TTC when renaming font src/hb-uniscribe.cc | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-) commit 05bad3b8c25a89bc0f20f99f9215e492f48f03fe Author: Behdad Esfahbod Date: Sun Jul 21 17:05:02 2013 -0400 [uniscribe] Use OT::* types src/hb-open-type-private.hh | 10 ++++- src/hb-ot-name-table.hh | 4 +- src/hb-uniscribe.cc | 107 +++++++++++++++++++++++--------------------- 3 files changed, 66 insertions(+), 55 deletions(-) commit bdeea605fe597bff4430eaae3317189bb81ec76e Author: Behdad Esfahbod Date: Sun Jul 21 16:22:10 2013 -0400 [uniscribe] Move name generation into separate function src/hb-uniscribe.cc | 34 ++++++++++++++++++++++------------ 1 file changed, 22 insertions(+), 12 deletions(-) commit 73f947e2a7bc5b29d731da2e9d1fafe958be839e Author: Behdad Esfahbod Date: Sun Jul 21 16:16:35 2013 -0400 [uniscribe] Use blob to pass data around src/hb-uniscribe.cc | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) commit 8ac2e88deff3d069c19fd59d0fbbfb88a762b113 Author: Behdad Esfahbod Date: Sun Jul 21 16:06:49 2013 -0400 [uniscribe] Use unique font name When installing per-process fonts using AddFontMemResourceEx(), if a font with the same family name is already installed, sometimes that one gets used. Which is problematic for us. As such, we now mangle the font to install a new 'name' table with a unique name, which we then use to choose the font. Patch from Jonathan Kew. configure.ac | 2 +- src/hb-uniscribe.cc | 136 ++++++++++++++++++++++++++++++++++++++++++++-------- 2 files changed, 116 insertions(+), 22 deletions(-) commit 8751de50831338ce550601c34c17d152ad89c1fd Author: Behdad Esfahbod Date: Thu Jul 18 16:29:50 2013 -0400 Followup fix for 3f9e2dced298c3d00f31b2dfc38685bb071a3a22 During GSUB, if a ligation happens, subsequence context input matching matches the new indexing. During GPOS however, the indices never change. So just go one by one. Fixes 'dist' positioning with mmrtext.ttf and the following sequence: U+1014,U+1039,U+1011,U+1014,U+1039,U+1011,U+1014,U+1039,U+1011 Reported by Jonathan Kew. src/hb-ot-layout-gsubgpos-private.hh | 8 ++++++++ 1 file changed, 8 insertions(+) commit 2b78d67e9f38f77086fbd9c3fd6f1c8c73927a51 Author: Behdad Esfahbod Date: Tue Jul 16 16:06:27 2013 -0400 0.9.19 NEWS | 11 +++++++++++ configure.ac | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) commit e509d35cf1160f1449bc736b9445cdf61ab81d06 Author: Behdad Esfahbod Date: Thu Jul 11 14:56:45 2013 -0400 [ft] hb_ft_get_glyph_from_name fails for the name of glyph id 0 Based on patch from Jonathan Kew, as reported on the mailing list. src/hb-ft.cc | 9 +++++++++ 1 file changed, 9 insertions(+) commit 29b596ac67806c44441e65f3ece227df0fe2bb63 Author: Behdad Esfahbod Date: Mon Jul 8 08:37:15 2013 -0600 [uniscribe] Fix buffer allocation Email from Jonathan Kew: My cygwin build kept aborting on certain test words when run with the uniscribe backend. Turned out this was caused by a bug in the allocation of scratch buffers in hb-uniscribe.cc. Commit 2a17f9568d9724e045d2c1d660e007f3acd747d9 introduced a new line ALLOCATE_ARRAY (SCRIPT_VISATTR, vis_attr, glyphs_size); but it failed to account for this in the computation of glyphs_size (the number of glyphs for which scratch buffer space is available), with the result that the vis_clusters array ends up overrunning the end of the scratch buffer and clobbering the beginning of the buffer's info[]. AFAICS, the vis_attr array is not actually used, so the simple fix is to remove the line that allocates it. (If/when we -do- need to use vis_attr for something, we'll need to add another term to the earlier calculation of glyphs_size.) With this patch, the uniscribe backend runs reliably again. JK src/hb-uniscribe.cc | 1 - 1 file changed, 1 deletion(-) commit 9245e98742667dfffe06523e8051beda1bc04811 Author: Behdad Esfahbod Date: Wed Jun 26 20:57:58 2013 -0400 [Indic] Add Javanese config We should add for other scripts too, send me the virama codepoint and script name... src/hb-ot-shape-complex-indic.cc | 1 + 1 file changed, 1 insertion(+) commit 5f85c80a07dd2d18348824866bf4e984ac711a24 Author: Behdad Esfahbod Date: Wed Jun 26 20:14:18 2013 -0400 [OT] Collect requiredFeature only if features are not provided As per Werner's report on the list. src/hb-ot-layout.cc | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) commit 3f9e2dced298c3d00f31b2dfc38685bb071a3a22 Author: Behdad Esfahbod Date: Wed Jun 26 19:46:55 2013 -0400 Fix contextual lookup recursion indexing See email thread "Skipping Control for Attaching Marks using OpenType" from earlier this month. src/hb-ot-layout-gsubgpos-private.hh | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) commit f5da11e0fa5adf8f782883dc5c30d8faaafc9c27 Merge: 79d1007a 89312b74 Author: Behdad Esfahbod Date: Sat Jun 22 08:04:05 2013 -0700 Merge pull request #3 from LogosBible/master Destroy lookups before blobs. commit 89312b7417c0198a0635ca6b7e8ea11f6af2a4f8 Author: Bradley Grainger Date: Fri Jun 21 15:02:18 2013 -0700 Destroy lookups before blobs. 'layout->gsub' may depend on data owned by 'layout->gsub_blob', so it must be deinitialized before the blob is destroyed. src/hb-ot-layout.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 79d1007a501fd63c0ba4d51038c513e6b8b94740 Author: Behdad Esfahbod Date: Thu Jun 13 19:01:07 2013 -0400 If variation selector is not consumed by cmap, pass it on to GSUB This changes the semantics of get_glyph() callback and expect that callbacks return false if the requested variant is not available, and then we will call them back with variation_selector=0 and will retain the glyph for the selector in the glyph stream. Apparently most Mongolian fonts implement the Mongolian Variation Selectors using GSUB, not cmap. https://bugs.freedesktop.org/show_bug.cgi?id=65258 Note that this doesn't fix the Mongolian shaping yet, because the way that's implemented is that the, say, 'init' feature ligates the letter and the variation-selector. However, since currently the variation selector doesn't have the 'init' mask on, it will not be matched... src/hb-ft.cc | 3 +-- src/hb-ot-shape-normalize.cc | 14 ++++++++++++-- 2 files changed, 13 insertions(+), 4 deletions(-) commit c7a84917208528040aaf9ad0a9a0b26aabeabc9c Author: Behdad Esfahbod Date: Thu Jun 6 20:17:32 2013 -0400 Skip over multiple variation selectors in a row src/hb-ot-shape-normalize.cc | 6 ++++++ 1 file changed, 6 insertions(+) commit 7235f33f9e5e031622a00a84f4b2e98f16803579 Author: Behdad Esfahbod Date: Mon Jun 10 14:39:51 2013 -0400 Fix misc warnings reported by cppcheck https://bugs.freedesktop.org/show_bug.cgi?id=65544 src/hb-common.cc | 2 +- src/hb-coretext.cc | 3 --- src/hb-font-private.hh | 17 +++++++++++------ src/hb-private.hh | 2 +- src/hb-shape.cc | 2 +- test/api/test-font.c | 1 - util/ansi-print.cc | 1 + util/hb-ot-shape-closure.cc | 5 +++-- util/hb-shape.cc | 5 ++++- util/shape-consumer.hh | 6 ++++-- util/view-cairo.hh | 6 ++++-- 11 files changed, 30 insertions(+), 20 deletions(-) commit 570bcccd3f41b9aecd51765a401299833a6d8ebd Author: Behdad Esfahbod Date: Mon Jun 10 13:56:51 2013 -0400 Fix PKG_CHECK_MODULES usage Oops. Bug 65246 - Fix build without graphite2 configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 270cfd7a9c01dfb1b1789929f020943ad63aca99 Author: Behdad Esfahbod Date: Thu Jun 6 18:57:15 2013 -0400 Fix PKG_CHECK_MODULES usage Bug 65246 - Fix build without graphite2 If we don't provide ACTION-IF-NOT-FOUND, configure aborts if it can't find the libraries. We handle that ourselves so we don't want the macro to abort. configure.ac | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) commit 2fd0e02706857bcaf61bf5151657eac96cfa73b9 Author: Behdad Esfahbod Date: Thu Jun 6 17:16:01 2013 -0400 Minor src/Makefile.am | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) commit b4c5c52944a44ba863a22a53035ff561af7318ca Author: Chun-wei Fan Date: Mon Jun 3 17:55:29 2013 +0800 util/ansi-print.cc: Use fallback implementation for lround on MSVC Unfortuately Visual Studio (still) does not support the C99 function lround, so provide a fallback implementation for it. util/ansi-print.cc | 11 +++++++++++ 1 file changed, 11 insertions(+) commit a4446b10bfe0a9e7236bf941fa69a96697939e11 Author: Behdad Esfahbod Date: Mon Jun 3 18:39:14 2013 -0400 Fix build for C89 compilers test/api/test-buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4ddf937242048c4a044ada4559e26664a0c09b48 Author: Behdad Esfahbod Date: Mon Jun 3 18:36:26 2013 -0400 Remove unnecessary stdint.h include src/hb-ucdn/ucdn.c | 1 - 1 file changed, 1 deletion(-) commit 93a04b8b5e6d8067cb925fdf532aadc24c1d4861 Author: Chun-wei Fan Date: Mon Jun 3 17:49:37 2013 +0800 hb-uniscribe.cc: Re-enable build under Visual Studio -Declare hinstLib at the top of block -Fix the definitions of the typedefs of ScriptItemizeOpenType, ScriptShapeOpenType and ScriptPlaceOpenType src/hb-uniscribe.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) commit 280e52ae95df0cbee0bb305f5354381bc1d563f4 Author: Behdad Esfahbod Date: Thu May 30 18:04:24 2013 -0400 Fix ChangeLog regen Makefile.am | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit c1824daefa1253507636e4bfdf46374f835f10b3 Author: Behdad Esfahbod Date: Wed May 29 15:30:54 2013 -0400 Update TODO TODO | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) commit 2966d3603259430800cb5880491d28a1c5ea2314 Author: Behdad Esfahbod Date: Tue May 28 17:34:37 2013 -0400 Fix test build test/api/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 6873f6cc42aa1405e71be903bd0f39a7a15320ce Author: Behdad Esfahbod Date: Tue May 28 17:33:16 2013 -0400 Minor TODO | 2 -- 1 file changed, 2 deletions(-) commit 4014aa4e53bddb29d939a168bd733942d3683732 Author: Behdad Esfahbod Date: Tue May 28 17:28:59 2013 -0400 0.9.18 NEWS | 28 ++++++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 29 insertions(+), 1 deletion(-) commit d70be29831bb99e34fe18744129088f45d5b2023 Author: Behdad Esfahbod Date: Tue May 28 17:23:56 2013 -0400 Fix dist src/Makefile.am | 4 ++++ 1 file changed, 4 insertions(+) commit 22ce0961742df0a213f2cc86ca3d5a72453c00b1 Author: Behdad Esfahbod Date: Tue May 28 17:18:30 2013 -0400 Generate harfbuzz-icu.pc Currently it only works with ICU that has .pc files. I'll wait till someone complains before fixing it for icu-config systems. Makefile.am | 3 --- configure.ac | 5 ++--- harfbuzz.pc.in | 11 ----------- src/Makefile.am | 13 +++++++++++++ src/harfbuzz-icu.pc.in | 13 +++++++++++++ src/harfbuzz.pc.in | 11 +++++++++++ 6 files changed, 39 insertions(+), 17 deletions(-) commit d9afa111330771461b6182ada9f4edd68bcfce77 Author: Behdad Esfahbod Date: Tue May 28 15:27:40 2013 -0400 Build hb-icu into libharfbuzz-icu.so src/Makefile.am | 29 +++++++++++++++-------------- src/hb-unicode.cc | 2 +- test/api/Makefile.am | 1 + 3 files changed, 17 insertions(+), 15 deletions(-) commit 7d395c2a255a44fd0d65365ea9b525dba70c062c Author: Behdad Esfahbod Date: Tue May 28 15:25:06 2013 -0400 Minor test/api/test-c.c | 4 ++++ 1 file changed, 4 insertions(+) commit 2a17f9568d9724e045d2c1d660e007f3acd747d9 Author: Behdad Esfahbod Date: Tue May 28 13:10:51 2013 -0400 Bug 55494 - ScriptItemizeOpenType doesn't exists under Windows XP Fallback to older API if OpenType variants are not available. configure.ac | 14 +-- src/hb-uniscribe.cc | 322 +++++++++++++++++++++++++++++++++++++++++++--------- 2 files changed, 271 insertions(+), 65 deletions(-) commit f8087ffbadc83a15d59367ba82976eae675736a7 Author: Behdad Esfahbod Date: Mon May 27 19:43:48 2013 -0400 Add --with-cairo configure.ac | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) commit 82eddfe5d658ef791d6ef6a566401c50601dfb1c Author: Behdad Esfahbod Date: Mon May 27 19:33:36 2013 -0400 Add --with-freetype Defaults to auto. configure.ac | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit 5e25eb77a49e7f95b6a6d540b26d60d430f89d4c Author: Behdad Esfahbod Date: Mon May 27 19:30:48 2013 -0400 Default glib to auto again configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit eb63e786f37468867c81707504128cf8a4016e5b Author: Behdad Esfahbod Date: Mon May 27 19:29:09 2013 -0400 Add --with-coretext Defaults to no. configure.ac | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit ab2af17bc6faa8394656e6e82948dc3e9f437626 Author: Behdad Esfahbod Date: Mon May 27 19:27:43 2013 -0400 Add --with-uniscribe Defaults to no. configure.ac | 55 +++++++++++++++++++++++++++++++++++++++---------------- 1 file changed, 39 insertions(+), 16 deletions(-) commit 58db2c2542717858acbdf480b3f19a8aef4918cd Author: Behdad Esfahbod Date: Mon May 27 19:10:33 2013 -0400 Disable UCDN if glib is available We only want UCDN if we don't have any other Unicode provider. I'm going to remove ICU from the list of default Unicode providers as part of moving hb-icu into its own library. As such, the only providers will be UCDN and glib. configure.ac | 3 +++ 1 file changed, 3 insertions(+) commit ca65326cbd49b48792c4e3125af6c5006364f194 Author: Behdad Esfahbod Date: Mon May 27 19:09:50 2013 -0400 Minor configure.ac | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) commit 7ae14973ecb4614a83769d2bbd01f33d8474ffc0 Author: Behdad Esfahbod Date: Mon May 27 19:06:50 2013 -0400 Disable icu_le shaper Will add a way to enable it later. configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 7e6ebf76236cc5ea69302e68186bdf8166d04a98 Author: Behdad Esfahbod Date: Mon May 27 19:05:23 2013 -0400 Remove icu-config fallback for icu_le shaper Bug 64878 - compile error with ICU but not ICU configure.ac | 18 ------------------ 1 file changed, 18 deletions(-) commit 932b7471479c639244051b4dbae678e7d47ae99f Author: Behdad Esfahbod Date: Mon May 27 19:04:40 2013 -0400 Bug 65053 - Add configure option to enable/disable ICU support configure.ac | 46 ++++++++++++++++++++++++++++------------------ 1 file changed, 28 insertions(+), 18 deletions(-) commit cf2c1c7eb81b54a344ed5cf36d5fbd3cd297eed1 Author: Behdad Esfahbod Date: Mon May 27 18:54:30 2013 -0400 Disable hb-old shaper Will add proper way to enable it later. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5a78d23f255a649353044af8e5df315f62907b7f Author: Behdad Esfahbod Date: Mon May 27 18:47:58 2013 -0400 Bug 65054 - Add configure option to enable/disable Graphite2 Add --with-graphite2. Defaults to off. configure.ac | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) commit 61e7775fa75c7c1bdc29a6992c8c215897364600 Author: Behdad Esfahbod Date: Mon May 27 18:24:56 2013 -0400 Remove hb-icu dependency from hb-icu-le shaper src/hb-icu-le.cc | 33 +++++++++++++++++++++++++++++---- 1 file changed, 29 insertions(+), 4 deletions(-) commit 7e08f1258da229dfaf7e1c4b5c41e5bb83906cb0 Author: Behdad Esfahbod Date: Mon May 27 14:48:34 2013 -0400 Don't zero advance of mark-non-mark ligatures If there's a mark ligating forward with non-mark, they were inheriting the GC of the mark and later get advance-zeroed. Don't do that if there's any non-mark glyph in the ligature. Sample test: U+1780,U+17D2,U+179F with Kh-Metal-Chrieng.ttf Also: Bug 58922 - Issue with mark advance zeroing in generic shaper src/hb-ot-layout-gsubgpos-private.hh | 4 ++++ src/hb-ot-layout-private.hh | 6 ++++++ 2 files changed, 10 insertions(+) commit cf059ac69d10d9eb09f0d2a29b1bd989647bd800 Author: Behdad Esfahbod Date: Fri May 24 15:28:11 2013 -0400 [icu_le] Support non-BMP text src/hb-icu-le.cc | 35 ++++++++++++++++++++++++++++------- 1 file changed, 28 insertions(+), 7 deletions(-) commit a447c528e68cabc9ca6e24e2c436f3d605ef9aaa Author: Behdad Esfahbod Date: Thu May 23 17:05:39 2013 -0400 [icu_le] A bit better scaling src/hb-icu-le.cc | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) commit fb502a22787f4110472771ef771619342e64577a Merge: b9408d24 9d9e72e9 Author: Behdad Esfahbod Date: Thu May 23 15:54:52 2013 -0400 Merge commit '9d9e72e94e7914f82ce62a304e7242f79c13edaf' commit b9408d24f3029f5287b17779235b1c750ff5158a Author: Behdad Esfahbod Date: Thu May 23 15:43:02 2013 -0400 [icu_le] Fix scaling Seems to work... src/hb-icu-le.cc | 2 ++ src/hb-icu-le/PortableFontInstance.cpp | 23 +++++++++++++++-------- src/hb-icu-le/PortableFontInstance.h | 9 ++++++++- 3 files changed, 25 insertions(+), 9 deletions(-) commit 601526392dec5d8432f147c91658ba50ed6a4322 Author: Behdad Esfahbod Date: Tue May 21 17:22:13 2013 -0400 Copy stdint.h boilerplate to ucdn src/hb-ucdn/ucdn.h | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) commit f1b02f4f3c0db9fbfa6747188429df828b000010 Author: Behdad Esfahbod Date: Mon May 20 09:23:58 2013 -0400 0.9.17 NEWS | 8 ++++++++ configure.ac | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) commit d785fa0c45f7f25f5e5f352b933a5f6fa29be5c0 Author: Behdad Esfahbod Date: Mon May 20 09:18:52 2013 -0400 Minor refactoring src/hb-ot-shape.cc | 54 ++++++++++++++++++++++++++++-------------------------- 1 file changed, 28 insertions(+), 26 deletions(-) commit 127daf15e0b2f509ebd29a104236c8b38884efb0 Author: Behdad Esfahbod Date: Mon May 20 09:11:35 2013 -0400 Arabic mark width-zeroing regression Mozilla Bug 873902 - Display Arabic text with diacritics is bad https://bugzilla.mozilla.org/show_bug.cgi?id=873902 src/hb-ot-shape-complex-arabic.cc | 2 +- src/hb-ot-shape-complex-default.cc | 2 +- src/hb-ot-shape-complex-myanmar.cc | 2 +- src/hb-ot-shape-complex-private.hh | 6 ++++-- src/hb-ot-shape-complex-thai.cc | 2 +- src/hb-ot-shape.cc | 36 ++++++++++++++++++++++++++++-------- 6 files changed, 36 insertions(+), 14 deletions(-) commit fa3d0a0ce60a9fcf2b7f906dec916463b1319eda Author: Behdad Esfahbod Date: Tue May 14 15:30:55 2013 -0400 Bug 64476 - Typo in hb_set_t.get_min() Fixes previous commit's test. src/hb-set-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dfbd115e6c1a86a5f1b8d15200672f1e9410b5de Author: Behdad Esfahbod Date: Tue May 14 15:30:17 2013 -0400 [test] Add test for hb_set_get_min() bug Failing now. Bug 64476 - Typo in hb_set_t.get_min() test/api/test-set.c | 4 ++++ 1 file changed, 4 insertions(+) commit 9d9e72e94e7914f82ce62a304e7242f79c13edaf Author: Behdad Esfahbod Date: Fri May 3 18:10:10 2013 -0400 [OTLayout] Use is_inplace() when flipping buffers src/hb-ot-layout.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) commit 45f3d980c9503bd94e64f6e3f67f97688347d00c Author: Behdad Esfahbod Date: Fri May 3 17:49:44 2013 -0400 [OTLayout] Merge / templateize apply_string() src/hb-ot-layout-gpos-table.hh | 25 --------------- src/hb-ot-layout-gsub-table.hh | 48 ---------------------------- src/hb-ot-layout.cc | 72 ++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 69 insertions(+), 76 deletions(-) commit e015b8f2187d1102b9c34d1a63504e7b05ee20ee Author: Behdad Esfahbod Date: Fri May 3 17:34:29 2013 -0400 [OTLayout] Minor src/hb-ot-layout-gpos-table.hh | 5 +++++ 1 file changed, 5 insertions(+) commit 780cd930a974165d76dbf7a87701d11b7f15db06 Author: Behdad Esfahbod Date: Fri May 3 17:33:16 2013 -0400 [OTLayout] Minor src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-layout-gsub-table.hh | 2 +- src/hb-ot-layout.cc | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) commit 2e0c44f4bedd3e24c731c0e9e23358e9a4891a35 Author: Behdad Esfahbod Date: Wed Apr 24 16:42:05 2013 -0400 [OTLayout] Add is_inplace() method to GSUB src/hb-ot-layout-gpos-table.hh | 8 +- src/hb-ot-layout-gsub-table.hh | 58 ++++++++++++- src/hb-ot-layout-gsubgpos-private.hh | 158 +++++++++++++++++++++++++++++++++++ 3 files changed, 222 insertions(+), 2 deletions(-) commit bac1dd6a0ff4d4fae4254506d38ae662b7e9dda7 Author: Behdad Esfahbod Date: Thu May 2 18:52:24 2013 -0400 [OTLayout] Refactor a bit more src/hb-ot-layout-gsubgpos-private.hh | 10 +-- src/hb-ot-layout-private.hh | 26 ++++---- src/hb-ot-layout.cc | 100 ++++++++++++++--------------- src/hb-ot-map-private.hh | 7 +- src/hb-ot-shape-complex-arabic-fallback.hh | 7 +- src/hb-ot-shape-fallback.cc | 3 +- 6 files changed, 78 insertions(+), 75 deletions(-) commit d2c96819de9a7428b65ef0adf794416224221f36 Author: Behdad Esfahbod Date: Thu May 2 18:18:24 2013 -0400 Move code around src/hb-ot-layout.cc | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++ src/hb-ot-map.cc | 43 ------------------------------------------- 2 files changed, 52 insertions(+), 43 deletions(-) commit 45fd9424c723f115ca98995b8f8a25185a6fc71d Author: Behdad Esfahbod Date: Thu May 2 18:06:51 2013 -0400 [OTLayout] Add hb_ot_layout_lookup_accelerator_t src/hb-ot-layout-private.hh | 21 +++++++++++++++++-- src/hb-ot-layout.cc | 33 +++++++++++++++--------------- src/hb-ot-shape-complex-arabic-fallback.hh | 10 +++++---- 3 files changed, 41 insertions(+), 23 deletions(-) commit 76ea563673d24ae1673a5aa3a21da6014479d433 Author: Behdad Esfahbod Date: Sat May 4 16:01:20 2013 -0400 [OTLayout] Add note about collect_glyphs() and recursive lookups src/hb-ot-layout-gsubgpos-private.hh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit a8bf0e91f18341e1e20f4e3341fc7dcdd0c990e1 Author: Behdad Esfahbod Date: Fri May 3 14:45:04 2013 -0400 Add U+061C ARABIC LETTER MARK to Default_Ignorable src/hb-unicode-private.hh | 4 ++++ 1 file changed, 4 insertions(+) commit 5d59f999204aedfc433ab4989664d875f96b0364 Author: Behdad Esfahbod Date: Thu May 2 14:44:45 2013 -0400 [OTLayout] Make MultipleSubst in-place for sequences of len=1 src/hb-ot-layout-gsub-table.hh | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) commit 54f84a6b8571ac7aaaa66f3eff562d23d69d7552 Author: Behdad Esfahbod Date: Thu May 2 15:27:53 2013 -0400 [OTLayout] Whitespace src/hb-ot-layout-gsub-table.hh | 56 +++++++++++++++++++++--------------------- 1 file changed, 28 insertions(+), 28 deletions(-) commit 3276c354daaff3acabecff11f8e4b5c54d53fc25 Author: Behdad Esfahbod Date: Thu May 2 15:16:59 2013 -0400 [OTLayout] Minor refactoring src/hb-ot-map-private.hh | 4 ++++ src/hb-ot-map.cc | 46 +++++++++++++++++++++++++--------------------- 2 files changed, 29 insertions(+), 21 deletions(-) commit ea86efa486a5076e9bf844239bccf86d67577f88 Author: Behdad Esfahbod Date: Thu May 2 14:41:39 2013 -0400 Minor src/hb-ot-map-private.hh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 8b63efb6f80b2e9b2de5ec6ab24d6e15826565cb Author: Behdad Esfahbod Date: Thu May 2 14:29:32 2013 -0400 Minor src/hb-buffer-private.hh | 2 ++ 1 file changed, 2 insertions(+) commit 2265be0a620bc76ab65f12fedde67791beb51314 Author: Behdad Esfahbod Date: Thu May 2 14:25:09 2013 -0400 Minor src/hb-ot-map-private.hh | 17 ++++++++++------- src/hb-ot-map.cc | 2 ++ src/hb-ot-shape-private.hh | 3 +-- 3 files changed, 13 insertions(+), 9 deletions(-) commit e6f19af08717a6a63ad0b5bf4bf368778edc63f0 Author: Behdad Esfahbod Date: Thu May 2 13:59:46 2013 -0400 Minor src/hb-set-private.hh | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) commit 6c15ddfe2b45383824b64058ae69939d002183a6 Author: Behdad Esfahbod Date: Tue Apr 30 11:34:00 2013 -0400 Renamed DEBUG to something else Some infrastructures use DEBUG as a generic symbol. src/hb-buffer.cc | 6 +++--- src/hb-private.hh | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) commit 00b93f6610f36d8d14ca65fb99864be6d5bdb1ea Author: Behdad Esfahbod Date: Mon Apr 29 13:48:49 2013 -0400 Fix icu linking by requesting the library searchpath from icu-config This is not ideal as we don't like -L/usr/lib in our linker line. But this is only relevant to environments that don't have pkgconfig files for ICU... https://github.com/behdad/harfbuzz/pull/2 configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 03adf38b22a37216dffac50d075ea9c881f1a22d Author: Behdad Esfahbod Date: Mon Apr 29 13:40:52 2013 -0400 Make both old autoconf and new automake happy Sigh.. Bug 64039 - undefined macro AM_PROG_AR configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ed79dff517bacfc87279079d5d42d079c21a0373 Author: Behdad Esfahbod Date: Sun Apr 21 15:39:25 2013 -0400 Minor src/hb-ot-layout-gpos-table.hh | 5 ----- 1 file changed, 5 deletions(-) commit 893f57b32f01da3411b5596d59170bc340e9fa39 Author: Behdad Esfahbod Date: Sun Apr 21 15:21:49 2013 -0400 Minor renaming src/hb-ot-map-private.hh | 10 +++++----- src/hb-ot-map.cc | 22 +++++++++++----------- 2 files changed, 16 insertions(+), 16 deletions(-) commit 8ac3c9c0b6b8e76bce282825b9bb706c0c78c2a6 Author: Behdad Esfahbod Date: Sun Apr 21 15:19:38 2013 -0400 Rename "pause" to "stage" The compile() function is starting to become illegible... src/hb-ot-map-private.hh | 24 ++++++++++++------------ src/hb-ot-map.cc | 38 +++++++++++++++++++------------------- 2 files changed, 31 insertions(+), 31 deletions(-) commit dd0641a432691f9b6186b081c38053858c8bc5c1 Author: Behdad Esfahbod Date: Sun Apr 21 15:13:57 2013 -0400 Minor src/hb-ot-map.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 06a44e859328f5f1e2f6034e711b474116d22e22 Author: Behdad Esfahbod Date: Sun Apr 21 15:13:08 2013 -0400 Remove unneeded code We always push a pause at the end such that each lookup falls in exactly one pause_map_t. Now, only if I can find a better name for that... src/hb-ot-map-private.hh | 2 +- src/hb-ot-map.cc | 12 +----------- 2 files changed, 2 insertions(+), 12 deletions(-) commit a408d2375aa2ad96b58e56aef18e5000daf2516b Author: Behdad Esfahbod Date: Fri Apr 19 16:32:06 2013 -0400 0.9.16 NEWS | 13 ++++++++++++- configure.ac | 2 +- 2 files changed, 13 insertions(+), 2 deletions(-) commit 8659c636087e433f56da458351e8b4d85fdb347c Author: Behdad Esfahbod Date: Fri Apr 19 14:33:17 2013 -0400 Hand-code bsearch in the hot inner loop. Saves another 3 / 4 percent with Amiri. src/hb-open-type-private.hh | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) commit 797d76d07f80d796a825d850772087104e5a2575 Author: Behdad Esfahbod Date: Thu Apr 18 19:04:12 2013 -0400 Minor src/hb-ot-layout-common-private.hh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit e4046080c5d785c8dbf9ec9e3478ab9acc83e479 Author: Behdad Esfahbod Date: Wed Apr 17 23:49:54 2013 -0400 [util] Unbreak --show-text / --show-unicode util/shape-consumer.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 0dc3a4e0349d28f387a3b4c60a2f51962742738e Author: Behdad Esfahbod Date: Wed Apr 17 23:04:03 2013 -0400 Obssesive optimization Not measurable by any means, but conceptually this is faster since the mask matches more often than the digest. src/hb-ot-layout-gpos-table.hh | 4 ++-- src/hb-ot-layout-gsub-table.hh | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) commit f9a611026785a80baa4cbff31ad0847beb70ca9a Author: Behdad Esfahbod Date: Wed Apr 17 19:01:49 2013 -0400 Remove HB_DEBUG_SET_DIGESTS Wasn't correct with the new combiner. I should add it back somehow, but for now the digests seem to be working very well... src/hb-set-private.hh | 16 +--------------- src/hb-set.cc | 14 -------------- 2 files changed, 1 insertion(+), 29 deletions(-) commit f7466ee76f2bd3812209426e2c39fe517227406d Author: Behdad Esfahbod Date: Wed Apr 17 18:20:44 2013 -0400 Remove hb_set_digest_common_bits_t Was unused. src/hb-set-private.hh | 38 -------------------------------------- 1 file changed, 38 deletions(-) commit 0d5798a137b52d9be7ef88c79e59f9bf01d54f3b Author: Behdad Esfahbod Date: Wed Apr 17 18:19:21 2013 -0400 Improve hb_set_digest_t Make Amiri rendering faster a whopping 45% again! Speends up pretty much anything I tested. src/hb-set-private.hh | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) commit c7851efcd3a1e5317ab4ea57535cb755bace0848 Author: Behdad Esfahbod Date: Wed Apr 17 17:45:39 2013 -0400 Templatize hb_set_digest_lowest_bits_t filter src/hb-set-private.hh | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) commit 0edd0fd255790471118fae1fd7a1309a2b77cf62 Author: Behdad Esfahbod Date: Wed Apr 17 17:26:56 2013 -0400 Add comment src/hb-set-private.hh | 8 ++++++++ 1 file changed, 8 insertions(+) commit b40f2c0372acbc51b13be5cda7dd013e74e3e11a Author: Behdad Esfahbod Date: Tue Apr 16 23:21:38 2013 -0400 Add hb_set_digest_combiner_t src/hb-set-private.hh | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) commit 02e5e583688999c4dc04f11b3924da65f99af7e3 Author: Behdad Esfahbod Date: Tue Apr 16 23:13:10 2013 -0400 Speed up Speed up hb_set_digest_common_bits_t calcs Correctly this time. src/hb-set-private.hh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 893991fc9d2d3a57c4c148f3a9c3b98263cf3aed Author: Behdad Esfahbod Date: Tue Apr 16 21:50:33 2013 -0400 Initialize set digests We were not initializing the digests properly and as a result they were being initialized to zero, making digest1 to never do any useful work. Speeds up Amiri shaping significantly. src/hb-ot-layout.cc | 6 ++++++ src/hb-ot-shape-complex-arabic-fallback.hh | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) commit 4d2813d3e980c8e6150caafa604a78cc44bf62a2 Author: Behdad Esfahbod Date: Tue Apr 16 21:57:21 2013 -0400 Print set-digest hit ratio with HB_DEBUG_SET_DIGESTS src/hb-set-private.hh | 13 +++++++++++++ src/hb-set.cc | 13 +++++++++++++ 2 files changed, 26 insertions(+) commit 1357c2dd120d005ceecfa83ed328d05dc634d7bc Author: Behdad Esfahbod Date: Tue Apr 16 21:47:40 2013 -0400 Revert "Speed up hb_set_digest_common_bits_t calcs" This reverts commit 3d1b66a35e1ab3be19335705f310b278d76d66d2. The calculations were buggy. It's not worth optimizing right now. src/hb-set-private.hh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 2b712bba3f7c459653737dfa2f7d26f17f3b9f64 Author: Behdad Esfahbod Date: Tue Apr 16 16:11:09 2013 -0400 Fix typo in unused macro src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 50067e280f381918b8e90b26df9e7bf20f98f0bd Author: Behdad Esfahbod Date: Thu Apr 11 16:31:01 2013 -0400 [util] Add --num-iterations Useful for profiling shapers. util/options.cc | 1 + util/options.hh | 2 ++ util/shape-consumer.hh | 15 +++++++++------ 3 files changed, 12 insertions(+), 6 deletions(-) commit 08677c250767bfc2c0dd1fc934dea92984741291 Author: Behdad Esfahbod Date: Thu Apr 11 14:45:58 2013 -0400 [old] Speed up Unicode properties access in hb-old shaper Just to be sure it's not punishing the old shaper performance numbers. Doesn't seem to have a measurable effect. src/hb-old/harfbuzz-arabic.c | 44 +++++++++++++++++++++--------------------- src/hb-old/harfbuzz-external.h | 18 ++++++++--------- src/hb-old/harfbuzz-greek.c | 2 +- src/hb-old/harfbuzz-hebrew.c | 2 +- src/hb-old/harfbuzz-indic.cpp | 10 +++++----- src/hb-old/harfbuzz-shaper.cpp | 6 ++++-- src/hb-old/harfbuzz-shaper.h | 1 + 7 files changed, 43 insertions(+), 40 deletions(-) commit 36a661c0a03d958b95c9ea64a435b55bcd99c3d6 Author: Behdad Esfahbod Date: Thu Apr 11 13:38:37 2013 -0400 [git.mk] Update git.mk | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) commit ef9e02eddfc9a37d50723e96839635d79191d849 Author: Behdad Esfahbod Date: Tue Apr 9 14:06:54 2013 -0400 Minor src/test.cc | 1 + 1 file changed, 1 insertion(+) commit 22e47456154ca0b8173268486e56ef3a0e1e7150 Author: Behdad Esfahbod Date: Fri Apr 5 18:02:43 2013 -0400 0.9.15 NEWS | 10 ++++++++++ configure.ac | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) commit 4d4fc920496c95621d5bb4800282ea8c028cdde3 Author: Behdad Esfahbod Date: Fri Apr 5 17:58:25 2013 -0400 [git.mk] Ignore ar-lib git.mk | 1 + 1 file changed, 1 insertion(+) commit 587e5753e088b4d0b82c74ddbde790a8369a7517 Author: Behdad Esfahbod Date: Fri Apr 5 12:38:58 2013 -0400 Add note re Hangul shaping src/hb-ot-shape-complex-private.hh | 14 ++++++++++++++ 1 file changed, 14 insertions(+) commit 269de14dda7a86a20917fa9ea6a5864929c41364 Author: Behdad Esfahbod Date: Thu Apr 4 23:06:54 2013 -0400 Don't compose Hangul jamo See thread "an issue regarding discrepancy between Korean and Unicode standards" on the mailing list for the rationale. In short: Uniscribe doesn't, so fonts are designed to work without it. src/hb-ot-shape-complex-default.cc | 6 ------ src/hb-ot-shape-normalize-private.hh | 1 - src/hb-ot-shape-normalize.cc | 11 +++++------ 3 files changed, 5 insertions(+), 13 deletions(-) commit 1f970609850bb4999b94e1e11b764ab4279cbd38 Author: Behdad Esfahbod Date: Thu Apr 4 15:02:03 2013 -0400 Put back MemoryBarrier fallback implementation on MINGW32 This almost reverts 2761e8a632c14353f286708898be8df6ebad7407, but only if under MINGW32, so it doesn't affect MSVC. src/hb-atomic-private.hh | 8 ++++++++ 1 file changed, 8 insertions(+) commit f368ba4a9edec4e297616698097546e8e6c89e53 Author: Behdad Esfahbod Date: Thu Apr 4 14:25:36 2013 -0400 [Arabic] Zero marks by GDEF, not Unicode category Testing shows that this is closer to what Uniscribe does. Reported by Khaled Hosny: """ commit 568000274c8edb5f41bc4f876ce21fcc8bdaeed8 ... This commit is causing a regression with Amiri, the string “هَٰذ” with Uniscribe and HarfBuzz before this commit, gives: [uni0630.fina=3+965|uni0670.medi=0+600|uni064E=0@-256,0+0|uni0647.init=0+926] But now it gives: [uni0630.fina=3+965|uni0670.medi=0+0|uni064E=0@-256,0+0|uni0647.init=0+926] i.e. uni0670.medi is zeroed though it has a base glyph GDEF class. """ The test case is U+0647,U+064E,U+0670,U+0630 with Amiri. src/hb-ot-shape-complex-arabic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3b80674c50b8c3133848a4034f7106b2b9bfe224 Author: Behdad Esfahbod Date: Thu Apr 4 12:06:46 2013 -0400 Bug 63107 - FTBFS on ppc64: symbols marked with 'D' on powerpc64 instead src/check-symbols.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7148dc1a978610af25b4f490691a62d709c8c463 Author: Behdad Esfahbod Date: Tue Apr 2 14:08:53 2013 -0400 [graphite2] Don't crash if language is not set https://bugs.webkit.org/show_bug.cgi?id=113796 src/hb-graphite2.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a88a62f70f87563725d47b9b6824565e5d6b78ab Author: Behdad Esfahbod Date: Thu Mar 21 21:02:16 2013 -0400 Minor src/hb-ot-shape-normalize.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit 0a2b2a505b647f6b4802750c87cd9c5f0baaadef Author: Behdad Esfahbod Date: Thu Mar 21 16:26:39 2013 -0400 Remove gthread leftovers We don't use gthread anymore, remove leftovers. configure.ac | 6 ------ test/api/Makefile.am | 4 ++-- test/api/hb-test.h | 3 --- 3 files changed, 2 insertions(+), 11 deletions(-) commit b93de1ea085bfc0661ce3ad0e21fb5eba722c951 Author: Behdad Esfahbod Date: Thu Mar 21 16:25:20 2013 -0400 Minor configure.ac | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) commit f872a17462a75a3493623747bf3a3fbe54556c7b Author: Behdad Esfahbod Date: Thu Mar 21 13:38:06 2013 -0400 0.9.14 NEWS | 14 ++++++++++++++ configure.ac | 2 +- 2 files changed, 15 insertions(+), 1 deletion(-) commit cc50bf5b13bfe88137fa7a42782872c40fb9aefb Author: Behdad Esfahbod Date: Tue Mar 19 06:59:40 2013 -0400 Remove Hangul filler characters from Default_Ignorable chars See discussion on mailing list. src/hb-unicode-private.hh | 10 +++++++--- .../texts/in-tree/shaper-default/script-hangul/misc/misc.txt | 1 + 2 files changed, 8 insertions(+), 3 deletions(-) commit a8cf7b43fa795150ae3d42d64424bb6e0373d0b2 Author: Behdad Esfahbod Date: Tue Mar 19 05:53:26 2013 -0400 [Indic] Futher adjust ZWJ handling in Indic-like shapers After the Ngapi hackfest work, we were assuming that fonts won't use presentation features to choose specific forms (eg. conjuncts). As such, we were using auto-joiner behavior for such features. It proved to be troublesome as many fonts used presentation forms ('pres') for example to form conjuncts, which need to be disabled when a ZWJ is inserted. Two examples: U+0D2F,U+200D,U+0D4D,U+0D2F with kartika.ttf U+0995,U+09CD,U+200D,U+09B7 with vrinda.ttf What we do now is to never do magic to ZWJ during GSUB's main input match for Indic-style shapers. Note that backtrack/lookahead are still matched liberally, as is GPOS. This seems to be an acceptable compromise. As to the bug that initially started this work, that one needs to be fixed differently: Bug 58714 - Kannada u+0cb0 u+200d u+0ccd u+0c95 u+0cbe does not provide same results as Windows8 https://bugs.freedesktop.org/show_bug.cgi?id=58714 New numbers: BENGALI: 353689 out of 354188 tests passed. 499 failed (0.140886%) DEVANAGARI: 707305 out of 707394 tests passed. 89 failed (0.0125814%) GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%) GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%) KANNADA: 951030 out of 951913 tests passed. 883 failed (0.0927606%) KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1048102 out of 1048334 tests passed. 232 failed (0.0221304%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271666 out of 271847 tests passed. 181 failed (0.0665816%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%) src/hb-ot-layout-gsubgpos-private.hh | 30 ++++++++-------------- src/hb-ot-layout-private.hh | 4 +-- src/hb-ot-layout.cc | 8 +++--- src/hb-ot-map-private.hh | 8 +++--- src/hb-ot-map.cc | 18 ++++++------- src/hb-ot-shape-complex-arabic-fallback.hh | 2 +- src/hb-ot-shape-complex-indic.cc | 30 +++++++++++----------- src/hb-ot-shape-complex-myanmar.cc | 4 +-- src/hb-ot-shape-complex-sea.cc | 4 +-- src/hb-ot-shape-fallback.cc | 2 +- .../indic/script-bengali/misc/misc.txt | 1 + .../indic/script-malayalam/misc/misc.txt | 1 + 12 files changed, 53 insertions(+), 59 deletions(-) commit 8226fb56f131362db877dc4be6857c684b8fd022 Author: Behdad Esfahbod Date: Tue Mar 19 05:22:27 2013 -0400 Allow disabling ICU by using a fake icu-config script configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit a1f3e8ccbfad0d1148b905ae008ba63a26090cb9 Author: Behdad Esfahbod Date: Mon Mar 11 20:18:49 2013 -0400 [travis] Install libicu .travis.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 14cfab52daa8d22b843110f32ca09af5bbc855a6 Author: Behdad Esfahbod Date: Mon Mar 11 19:53:44 2013 -0400 Add build system fallback to icu-config Ubuntu doesn't (or didn't until recently?) ship icu pkg-config files. That's quite unfortunate. Work around it. Bug 57608 - ICU Detection fallback for non-pkgconfig systems configure.ac | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) commit 190e19e6842875c7a487c66235300ee6b42fb5da Author: Behdad Esfahbod Date: Sat Mar 9 20:30:22 2013 -0500 [ft] Remove TODO items that I'm not going to fix src/hb-ft.cc | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) commit 392ee97431b368ee74e1b521fd539b69d2efadfb Author: Behdad Esfahbod Date: Sat Mar 9 20:27:55 2013 -0500 [ft] Remove TODO item re FT_LOAD_IGNORE_GLOBAL_ADVANCE_WIDTH That flag is redundant, deprecated, and ignored since April 2011. From FreeType git log: commit 8c82ec5b17d0cfc9b0876a2d848acc207a62a25a Author: Behdad Esfahbod Date: Thu Apr 21 08:21:37 2011 +0200 Always ignore global advance. This makes FT_LOAD_IGNORE_GLOBAL_ADVANCE_WIDTH redundant, deprecated, and ignored. The new behavior is what every major user of FreeType has been requesting. Global advance is broken in many CJK fonts. Just ignoring it by default makes most sense. * src/truetype/ttdriver.c (tt_get_advances), src/truetype/ttgload.c (TT_Get_HMetrics, TT_Get_VMetrics, tt_get_metrics, compute_glyph_metrics, TT_Load_Glyph), src/truetype/ttgload.h: Implement it. * docs/CHANGES: Updated. src/hb-ft.cc | 2 -- 1 file changed, 2 deletions(-) commit c5d91f39802078fc6f6de71940739ec4d04eca07 Author: Behdad Esfahbod Date: Sat Mar 9 04:34:21 2013 -0500 Add hb_auto_array_t src/hb-private.hh | 8 ++++++++ 1 file changed, 8 insertions(+) commit ee5464d17fa4c59f5adaaa13dde70dd5264dbc64 Author: Behdad Esfahbod Date: Sat Mar 9 01:59:30 2013 -0500 [OTLayout] Move code around src/hb-ot-layout-gpos-table.hh | 33 ++++++------ src/hb-ot-layout-gsub-table.hh | 115 +++++++++++++++++++++-------------------- 2 files changed, 75 insertions(+), 73 deletions(-) commit 9c5a9ee967120c8a968a1160c420e03620d46c24 Author: Behdad Esfahbod Date: Sat Mar 9 01:55:04 2013 -0500 [OTLayout] Rename process() to dispatch() src/hb-open-type-private.hh | 2 +- src/hb-ot-layout-gpos-table.hh | 80 ++++++++++++++++++------------------ src/hb-ot-layout-gsub-table.hh | 78 +++++++++++++++++------------------ src/hb-ot-layout-gsubgpos-private.hh | 36 ++++++++-------- 4 files changed, 98 insertions(+), 98 deletions(-) commit 2761e8a632c14353f286708898be8df6ebad7407 Author: Behdad Esfahbod Date: Thu Mar 7 20:51:30 2013 -0500 [win32] Remove MemoryBarrier() fallback implementation I added these because the older mingw32 toolchain didn't have MemoryBarrier(). The newer mingw-w64 toolchain however has. As reported by John Emmas this was causing build failure with MSVC (on glib) because of inline issues. But that reminded me that we may be taking this path even if the system implements MemoryBarrier as a function, which is a waste. So, just remove it. src/hb-atomic-private.hh | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) commit ea11abfc5de8bc5cf651b37c9570593eed6a8f9b Author: Behdad Esfahbod Date: Wed Mar 6 20:21:11 2013 -0500 [build] Port to newer automake recommended syntax test/api/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit c39def9bc71559d59325a2c3282c1cec4286b2ae Author: Behdad Esfahbod Date: Wed Mar 6 20:20:45 2013 -0500 Move valgrind suppressions to the correct directory test/{ => api}/.valgrind-suppressions | 0 1 file changed, 0 insertions(+), 0 deletions(-) commit a8ac1d33c731f6200ee472ab6c37a80b72770564 Author: Behdad Esfahbod Date: Wed Mar 6 20:05:34 2013 -0500 [build] Add AM_PROG_AR Newer automake / libtools warns otherwise. configure.ac | 1 + 1 file changed, 1 insertion(+) commit 5594c2d112c295147ee69215a2ce9dfd99984aa0 Author: Behdad Esfahbod Date: Wed Mar 6 19:37:31 2013 -0500 [FT] Just return if glyph name not found The fallback happens in higher level already. No need to do here. src/hb-ft.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit fb7c182bf92142540bff1ad7fb82de0d115fb2b5 Author: Behdad Esfahbod Date: Wed Mar 6 00:53:24 2013 -0500 [Indic] Minor src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8144936d072f94104242edf9e7aaa31d315b4094 Author: Behdad Esfahbod Date: Tue Mar 5 20:08:59 2013 -0500 [Indic] Work around fonts with broken new-spec tables See comments, and this thread: http://lists.freedesktop.org/archives/harfbuzz/2013-March/002990.html Originally reported here: https://code.google.com/p/chromium/issues/detail?id=96143 Doesn't change test suite numbers. src/hb-ot-shape-complex-indic.cc | 42 +++++++++++++++++++++++++++------------- 1 file changed, 29 insertions(+), 13 deletions(-) commit dfb799f57572e8123035a42a30f93c7fc4d37692 Author: Behdad Esfahbod Date: Tue Mar 5 17:23:33 2013 -0500 [travis] Oops. Run make check, not make test! .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8bdce1cac1be9e79344c1f9a9811d98ed2e5c5fd Author: Behdad Esfahbod Date: Tue Mar 5 02:35:31 2013 -0500 Run autogen.sh, not configure, in travis-ci .travis.yml | 1 + 1 file changed, 1 insertion(+) commit 5f705b437cb116275a8c20366e694d740bce715c Author: Behdad Esfahbod Date: Tue Mar 5 01:37:44 2013 -0500 Add .travis.yml for continuous building with travis-ci.org Notifications sent to IRC channel and mailing list. .travis.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) commit cd54d505d1a2467a67e5ff96fe0eb101b953b265 Author: Behdad Esfahbod Date: Mon Mar 4 21:29:38 2013 -0500 Fix distcheck src/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) commit 22c625a490bbaac52ead2cd29ee49b170e6e9845 Author: Behdad Esfahbod Date: Mon Mar 4 20:56:15 2013 -0500 [git.mk] Update to commit efc928222179576270c5910416d8055dd7a97896 Move reusable list of files into variable definitions modules can reuse Makefile.am | 22 ++++------------------ git.mk | 59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- 2 files changed, 60 insertions(+), 21 deletions(-) commit 66f7b3509a121b8f3289ad4c4aed2b5b10a6de2e Author: Behdad Esfahbod Date: Mon Mar 4 18:52:12 2013 -0500 Add libtool m4 macros to MAINTAINERCLEANFILES Makefile.am | 5 +++++ 1 file changed, 5 insertions(+) commit 41732f1fe3ce856d8bb95850635034537b6ba047 Author: Behdad Esfahbod Date: Wed Feb 27 20:40:54 2013 -0500 [Indic] Help compiler put indic_features table in .rodata The overridden "or" operator was preventing the flag expression from being const, and putting the table in .data instead or .rodata. src/hb-ot-map-private.hh | 2 ++ src/hb-ot-shape-complex-indic.cc | 24 ++++++++++++------------ 2 files changed, 14 insertions(+), 12 deletions(-) commit 778d7f844cb330289830c95431269db06ba1c969 Author: Behdad Esfahbod Date: Wed Feb 27 18:47:26 2013 -0500 [buffer] Better parse glyph names src/hb-buffer-deserialize-json.rl | 9 ++++++--- src/hb-buffer-deserialize-text.rl | 5 ++++- 2 files changed, 10 insertions(+), 4 deletions(-) commit 20b817ac21147e0a8edbf23ef071c2f4ce6c2b95 Author: Behdad Esfahbod Date: Wed Feb 27 18:39:37 2013 -0500 [buffer] Implement buffer deserialization for format=json Using a ragel machine. src/Makefile.am | 2 + src/hb-buffer-deserialize-json.rl | 129 ++++++++++++++++++++++++++++++++++++++ src/hb-buffer-deserialize-text.rl | 52 +-------------- src/hb-buffer-serialize.cc | 45 +++++++++++-- src/hb-private.hh | 6 +- src/hb-shape.cc | 2 - src/test-buffer-serialize.cc | 4 +- 7 files changed, 179 insertions(+), 61 deletions(-) commit 847794e929831750e97525137ab5e285ccd1064e Author: Behdad Esfahbod Date: Wed Feb 27 17:59:28 2013 -0500 [buffer] Implement buffer deserialization for format=text Using a ragel machine. src/Makefile.am | 2 + src/hb-buffer-deserialize-text.rl | 169 ++++++++++++++++++++++++++++++++++++++ src/hb-buffer-private.hh | 3 +- src/hb-buffer-serialize.cc | 36 +++----- src/hb-buffer.cc | 13 ++- src/hb-buffer.h | 2 +- src/hb-private.hh | 5 +- src/hb-shape.cc | 9 +- src/test-buffer-serialize.cc | 16 +++- 9 files changed, 221 insertions(+), 34 deletions(-) commit 4ee803b42a3baae4b0f295a07cb7ad591a538e4c Author: Behdad Esfahbod Date: Wed Feb 27 16:09:55 2013 -0500 [buffer] Fix serializing of buffer with invalid direction src/hb-buffer-serialize.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e54dd26300f50eb19907a9d39269a363279b3e07 Author: Behdad Esfahbod Date: Wed Feb 27 13:01:02 2013 -0500 [buffer] Start implementing buffer deserialization src/Makefile.am | 12 ++++- src/hb-buffer-serialize.cc | 64 ++++++++++++++++++++++-- src/hb-buffer.h | 2 +- src/test-buffer-serialize.cc | 114 +++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 187 insertions(+), 5 deletions(-) commit bcc8f32b4c46cd73f591924c64a6f63df6eaf9e7 Author: Behdad Esfahbod Date: Wed Feb 27 12:02:42 2013 -0500 [buffer] Minor src/hb-buffer-serialize.cc | 10 +++++++--- src/hb-buffer.h | 4 ++-- 2 files changed, 9 insertions(+), 5 deletions(-) commit d3e14aafff60e1314d0ef66e42cdde6bf949bb66 Author: Behdad Esfahbod Date: Wed Feb 27 11:06:36 2013 -0500 [buffer] Move buffer serialization code to a new file Android.mk | 1 + src/Makefile.am | 1 + src/hb-buffer-serialize.cc | 251 +++++++++++++++++++++++++++++++++++++++++++++ src/hb-buffer.cc | 228 ---------------------------------------- 4 files changed, 253 insertions(+), 228 deletions(-) commit 8da51112696ec8641d7dd9184b7ab1dd48458813 Author: Behdad Esfahbod Date: Wed Feb 27 17:48:31 2013 -0500 Minor src/hb-shape.cc | 2 ++ 1 file changed, 2 insertions(+) commit 94789fd6012125acc8426dd88df97f03b0948ea5 Author: Behdad Esfahbod Date: Tue Feb 26 21:22:37 2013 -0500 [Indic] Sort pre-base reordering consonants with post-forms Before, we were marking them as below-form for initial reordering. However, there is a rule that says "post consonants should follow below consonsnts" for base determination purposes. Malayalam has port-form YA/VA, and RA is pre-base. As such, for a sequence like YA,Virama,YA,Virama,RA, the correct base is at index 0. But because the code was seeing RA as a below-base, it was stopping at the second YA as base, instead of jumping it as a post-base. By treating prebase-reordering consonants like post-forms, this is fixed. MALAYALAM went down from 351 to 265. Other numbers didn't change: BENGALI: 353686 out of 354188 tests passed. 502 failed (0.141733%) DEVANAGARI: 707305 out of 707394 tests passed. 89 failed (0.0125814%) GUJARATI: 366262 out of 366457 tests passed. 195 failed (0.0532122%) GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%) KANNADA: 950680 out of 951913 tests passed. 1233 failed (0.129529%) KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1048069 out of 1048334 tests passed. 265 failed (0.0252782%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271539 out of 271847 tests passed. 308 failed (0.113299%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%) src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6d69a2cec158061ef097c488d08813c9503824b8 Author: Behdad Esfahbod Date: Tue Feb 26 19:35:50 2013 -0500 [tests] Add Malayalam tests frim cibu .../indic/script-malayalam/misc/MANIFEST | 1 + .../indic/script-malayalam/misc/cibu.txt | 188 +++++++++++++++++++++ 2 files changed, 189 insertions(+) commit 1edc6b97b67363d55cfb5914c991ae54d42a6440 Author: Behdad Esfahbod Date: Tue Feb 26 15:01:45 2013 -0500 Update Android.mk Android.mk | 3 +++ 1 file changed, 3 insertions(+) commit 05d5d3cd63ba2fadfdb62190dd24ef80ee3df40c Author: Behdad Esfahbod Date: Mon Feb 25 23:57:51 2013 -0500 Fix "comparison between signed and unsigned" warnings Patch from Jonathan Kew. src/hb-open-type-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 07a52b62115f10caea5c2d174a4272eb9ddb2284 Author: Behdad Esfahbod Date: Mon Feb 25 19:09:57 2013 -0500 Give up sanitizing after 100 edit requests Such fonts are *definitely* really broken. Give up. Limits time spent in sanitize for extremely / deliberately broken fonts. For example, two fonts with these md5sum / names: 9343f0a1b8c84b8123e7d201cae62ffd.ttf eb8c978547f09d368fc204194fb34688.ttf were spending over a second in sanitize! Not anymore. src/hb-open-type-private.hh | 7 +++++++ 1 file changed, 7 insertions(+) commit 29ff25481584e20a2fa39195f295c8eb4bf3bad0 Author: Behdad Esfahbod Date: Mon Feb 25 19:04:56 2013 -0500 Add HB_DEBUG_VERBOSE Only affects the verbosity of function name printing right now. src/hb-private.hh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 05686b5f697ed40dd21b330d044c3c286461fb26 Author: Behdad Esfahbod Date: Mon Feb 25 18:19:20 2013 -0500 0.9.13 NEWS | 29 +++++++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 30 insertions(+), 1 deletion(-) commit 9e5ac7b8c02c86a4f28c79173a5237503eaa7115 Author: Behdad Esfahbod Date: Mon Feb 25 17:54:10 2013 -0500 Fix blob test to match c3ba49b6fa1865e8318926eaa6c0f2063d1053bb test/api/test-blob.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 51 insertions(+), 6 deletions(-) commit c3ba49b6fa1865e8318926eaa6c0f2063d1053bb Author: Behdad Esfahbod Date: Mon Feb 25 17:06:35 2013 -0500 Always create sub-blobs in MEMORY_MODE_READONLY This fixes a design bug with sanitize and sub-blobs that can cause crashes. Jonathan and I found and debugged this issue when we tested a corrupt font with the md5sum / filename: ea395483d37af0cb933f40689ff7b60a. Two hours of intense debugging we found out that the font has overlapping GSUB/GPOS tables, and as such, sanitizing the second table can modify the first one, which can cause all kinds of undefined behavior. The correct way to fix this is to make sure sub-blobs are always created readonly, since we consider the parent blob to be a shared resource and can't modify it, even if it *is* writable. This essentially makes the READONLY_MAY_MAKE_WRITABLE mode unused... Maybe we should simply remove / deprecate it. src/hb-blob.cc | 2 +- src/hb-blob.h | 26 ++++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) commit 57542d7f411c71d9b8110ce6f64090b2c0f6a925 Author: Behdad Esfahbod Date: Thu Feb 21 15:54:05 2013 -0500 Minor src/hb-ot-layout-private.hh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit d46606e119b48dcca375d6313abd0f93ba5d09c3 Author: Behdad Esfahbod Date: Thu Feb 21 15:39:57 2013 -0500 Port TrueType-kerning to use skippy iterator It skips joiners and default ignorables now. Skips marks too, but only if there is proper GDEF classes for marks. src/hb-ot-shape-fallback.cc | 50 +++++++++++++++++++++++++-------------------- 1 file changed, 28 insertions(+), 22 deletions(-) commit 722e8b857eafc52e07dee5d9b253b88ed5c5c8ed Author: Behdad Esfahbod Date: Thu Feb 21 15:37:51 2013 -0500 Fixup previous commit Was not decreasing num_items. Ouch! src/hb-ot-layout-gsubgpos-private.hh | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) commit ba87b8fc89bf745068ccd19264a2631ea0904846 Author: Behdad Esfahbod Date: Thu Feb 21 15:23:39 2013 -0500 Move code around src/hb-ot-shape-fallback-private.hh | 5 +++++ src/hb-ot-shape-fallback.cc | 40 +++++++++++++++++++++++++++++++++++++ src/hb-ot-shape.cc | 38 +---------------------------------- 3 files changed, 46 insertions(+), 37 deletions(-) commit 2b2a6e8944144755ab641f2842e36d9a847719f3 Author: Behdad Esfahbod Date: Thu Feb 21 15:07:03 2013 -0500 [OTLayout] Correctly skip Default_Ignorable when match_func not set When a match_func was not set on the matcher_t object (ie. from GPOS), then the Default_Ignorables (including joiners) were never skipped. This meant that they were not skipped as they should during GPOS matching. Fix that. A few Indic numbers have "regressed": BENGALI and DEVANAGARI went up from 290 and 58 respectively, but in both cases new results are superior to Uniscribe, as they apply GPOS when we weren't (and Uniscribe isn't) before. BENGALI: 353686 out of 354188 tests passed. 502 failed (0.141733%) DEVANAGARI: 707305 out of 707394 tests passed. 89 failed (0.0125814%) GUJARATI: 366262 out of 366457 tests passed. 195 failed (0.0532122%) GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%) KANNADA: 950680 out of 951913 tests passed. 1233 failed (0.129529%) KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1047983 out of 1048334 tests passed. 351 failed (0.0334817%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271539 out of 271847 tests passed. 308 failed (0.113299%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%) src/hb-ot-layout-gsubgpos-private.hh | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) commit ff93ac8cb24cbc3d9dc1a2bfb0faa88950f4a507 Author: Behdad Esfahbod Date: Thu Feb 21 14:51:40 2013 -0500 Minor src/hb-ot-layout-gsubgpos-private.hh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) commit e0486fc1affd3796fb8f664e2e7fc208f1d2106c Author: Behdad Esfahbod Date: Tue Feb 19 00:58:10 2013 -0500 [tests] Add Myanmar torture tests from Martin Hosken .../shaper-myanmar/script-myanmar/misc/MANIFEST | 1 + .../shaper-myanmar/script-myanmar/misc/torture.txt | 23 ++++++++++++++++++++++ 2 files changed, 24 insertions(+) commit a3df9a7bf87aeba7a3d6110cd5e01a65bd0b16d0 Author: Behdad Esfahbod Date: Tue Feb 19 00:50:46 2013 -0500 Minor Moving files around test/shaping/texts/in-tree/MANIFEST | 2 -- test/shaping/texts/in-tree/shaper-default/MANIFEST | 2 ++ .../in-tree/{script-default => shaper-default/script-hangul}/MANIFEST | 0 .../{script-default => shaper-default/script-hangul}/misc/MANIFEST | 0 .../{shaper-hangul => shaper-default}/script-hangul/misc/misc.txt | 0 .../script-hangul => shaper-default/script-tibetan}/MANIFEST | 0 .../script-hangul => shaper-default/script-tibetan}/misc/MANIFEST | 0 .../{script-default => shaper-default/script-tibetan}/misc/misc.txt | 0 test/shaping/texts/in-tree/shaper-hangul/MANIFEST | 1 - 9 files changed, 2 insertions(+), 3 deletions(-) commit b1f440759161cb5a54e1b1b910f3a8383b8e8472 Author: Behdad Esfahbod Date: Sun Feb 17 12:12:37 2013 -0500 [SEA] Fix order of pre-base reordering Ra and left matras The code was confused because it was expecting left matra to have POS_PRE_M, like we do in the Myanmar shaper, but that is not what we were doing in this shaper. Rewrite to rely on category only. Test case: U+AA06,U+AA34,U+AA2F src/hb-ot-shape-complex-sea.cc | 13 +++++++------ .../texts/in-tree/shaper-sea/script-cham/misc/misc.txt | 1 + 2 files changed, 8 insertions(+), 6 deletions(-) commit 99fa9ea020f26ed2697f38a7690ee1e1b5d946c4 Author: Behdad Esfahbod Date: Fri Feb 15 11:47:24 2013 -0500 Minor src/hb-ot-layout-gsub-table.hh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit 27589620ba2dcf356fd7fa21cd80221a07803202 Author: Behdad Esfahbod Date: Fri Feb 15 11:47:09 2013 -0500 [OTLayout] Remove unused code src/hb-open-type-private.hh | 5 ----- 1 file changed, 5 deletions(-) commit ebb77b9c5e357ff7c9badb0f4bf1c3a965c3e91d Author: Behdad Esfahbod Date: Fri Feb 15 09:33:10 2013 -0500 Remove TODO items that don't make sense The spec says those features need to be disabled by default. TODO | 2 -- 1 file changed, 2 deletions(-) commit c2a1cdc4c4cc51f4680ebc4ec2c462cb660f9492 Author: Behdad Esfahbod Date: Fri Feb 15 09:27:02 2013 -0500 [Arabic] Fix shaping of left-joining 'Phags-Pa U+A872 This is the first character in Unicode to have Arabic left-joining behavior. Update the machine to recognize that. Test case: U+A840,U+A872,U+A840. src/hb-ot-shape-complex-arabic.cc | 40 +++++++++++++++++++-------------------- 1 file changed, 19 insertions(+), 21 deletions(-) commit 05ac87813d17d9ebbfa315eee3f80f25b53135c5 Author: Behdad Esfahbod Date: Fri Feb 15 09:26:41 2013 -0500 [tests] Add Syriac Alaph shaping test cases .../shaper-arabic/script-syriac/misc/MANIFEST | 1 + .../shaper-arabic/script-syriac/misc/alaph.txt | 98 ++++++++++++++++++++++ 2 files changed, 99 insertions(+) commit c462b32dcb883a7aca066af24c4d28c7a2b7fa28 Author: Behdad Esfahbod Date: Fri Feb 15 07:51:47 2013 -0500 Disable automatic segment properties guessing Before, if one called hb_shape() without setting script, language, and direction on the buffer, hb_shape() was calling hb_buffer_guess_segment_properties() on the user's behalf to guess these. This is very dangerous, since any serious user of HarfBuzz must set these properly (specially important is direction). So now, we don't guess properties by default. People not setting direction will get an abort() now. If the old behavior is desired (fragile, good for simple testing only), users can call hb_buffer_guess_segment_properties() on the buffer just before calling hb_shape(). src/hb-fallback-shape.cc | 1 - src/hb-ot-shape.cc | 2 -- src/hb-shape.cc | 2 -- util/options.hh | 1 + 4 files changed, 1 insertion(+), 5 deletions(-) commit 7abddbb47a489aaac8e76ac6e700cd815739b1d2 Author: Behdad Esfahbod Date: Fri Feb 15 07:46:57 2013 -0500 Add assertions for a couple programmer errors src/hb-shape-plan.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit 038c98f6866fe1177b04bd2ae3bb461b2f0fd1ed Author: Behdad Esfahbod Date: Fri Feb 15 07:41:07 2013 -0500 Allow disabling of TrueType kerning Responds to the same feature tag that GPOS kerning does: 'kern' for horizontal and 'vkrn' for vertical. TODO | 2 -- src/hb-ot-shape.cc | 55 ++++++++++++++++++++++++++++++++++-------------------- 2 files changed, 35 insertions(+), 22 deletions(-) commit 398238a2526d322eb79e255c24634a275473920f Author: Behdad Esfahbod Date: Fri Feb 15 07:40:10 2013 -0500 Fix partial disabling of default-on features Surprisingly, if user ever tried to turn a default feature off partially (say, disable liga for a range), the feature was being turned off globally! Fixed now. src/hb-ot-map.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit cb90b1bbe6d27ca6968b70d2dbfea7ab7fb73293 Author: Behdad Esfahbod Date: Fri Feb 15 07:02:08 2013 -0500 [OTLayout] Respect syllable boundaries for backtrack/lookahead matching Originally we meant to match backtrack/lookahead across syllable boundaries. But a bug in the code meant that this was NOT done for backtrack. We "fixed" that in 2c7d0b6b80d412de3fddd443ed1a485ea1cbb03c, but that broke Myanmar shaping. We now believe that for Indic-like shapers (which is where syllables are used), all basic shaping forms should be fully contained within their syllables, so now we limit backtrack/lookahead matching to the syllable too. Unbreaks Myanmar. src/hb-ot-layout-gsubgpos-private.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit ee9c3a17d0bf263c5eee479fd778db97cff8e189 Author: Behdad Esfahbod Date: Fri Feb 15 06:22:26 2013 -0500 Minor refactoring src/hb-ot-shape-complex-myanmar.cc | 36 ++++++++++-------------------------- src/hb-ot-shape-complex-sea.cc | 37 ++++++++++--------------------------- src/hb-ot-shape.cc | 17 ++++++----------- 3 files changed, 26 insertions(+), 64 deletions(-) commit cfc507c5432e6327e8484b07b9e091212653bc92 Author: Behdad Esfahbod Date: Thu Feb 14 10:40:12 2013 -0500 [Indic-like] Disable automatic joiner handling for basic shaping features Not for Arabic, but for Indic-like scripts. ZWJ/ZWNJ have special meanings in those scripts, so let font lookups take full control. This undoes the regression caused by automatic-joiners handling introduced two commits ago. We only disable automatic joiner handling for the "basic shaping features" of Indic, Myanmar, and SEAsian shapers. The "presentation forms" and other features are still applied with automatic-joiner handling. This change also changes the test suite failure statistics, such that a few scripts show more "failures". The most affected is Kannada. However, upon inspection, we believe that in most, if not all, of the new failures, we are producing results superior to Uniscribe. Hard to count those! Here's an example of what is fixed by the recent joiner-handling changes: https://bugs.freedesktop.org/show_bug.cgi?id=58714 New numbers, for future reference: BENGALI: 353892 out of 354188 tests passed. 296 failed (0.0835714%) DEVANAGARI: 707336 out of 707394 tests passed. 58 failed (0.00819911%) GUJARATI: 366262 out of 366457 tests passed. 195 failed (0.0532122%) GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%) KANNADA: 950680 out of 951913 tests passed. 1233 failed (0.129529%) KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1047983 out of 1048334 tests passed. 351 failed (0.0334817%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271539 out of 271847 tests passed. 308 failed (0.113299%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%) src/hb-ot-layout-gsubgpos-private.hh | 35 +++++++++++++++++++----------- src/hb-ot-layout-private.hh | 6 +++-- src/hb-ot-layout.cc | 10 +++++---- src/hb-ot-map-private.hh | 12 ++++++---- src/hb-ot-map.cc | 32 +++++++++++++++++++++------ src/hb-ot-shape-complex-arabic-fallback.hh | 2 +- src/hb-ot-shape-complex-indic.cc | 29 +++++++++++++------------ src/hb-ot-shape-complex-myanmar.cc | 4 ++-- src/hb-ot-shape-complex-sea.cc | 4 ++-- 9 files changed, 85 insertions(+), 49 deletions(-) commit 0b45479198d61d5135dad771e9c68408eb13f930 Author: Behdad Esfahbod Date: Thu Feb 14 10:46:52 2013 -0500 [OTLayout] Add fine-grained control over ZWJ matching Not used yet. Next commit... src/hb-ot-layout-gsubgpos-private.hh | 10 ++++++++-- src/hb-ot-layout-private.hh | 11 +++++++++-- 2 files changed, 17 insertions(+), 4 deletions(-) commit 607feb7cff0e50f8738d2e49ca463fc9d7d494de Author: Behdad Esfahbod Date: Thu Feb 14 07:43:13 2013 -0500 [OTLayout] Ignore default-ignorables when matching GSUB/GPOS When matching lookups, be smart about default-ignorable characters. In particular: Do nothing specific about ZWNJ, but for the other default-ignorables: If the lookup in question uses the ignorable character in a sequence, then match it as we used to do. However, if the sequence match will fail because the default-ignorable blocked it, try skipping the ignorable character and continue. The most immediate thing it means is that if Lam-Alef forms a ligature, then Lam-ZWJ-Alef will do to. Finally! One exception: when matching for GPOS, or for backtrack/lookahead of GSUB, we ignore ZWNJ too. That's the right thing to do. It certainly is possible to build fonts that this feature will result in undesirable glyphs, but it's hard to think of a real-world case that that would happen. This *does* break Indic shaping right now, since Indic Unicode has specific rules for what ZWJ/ZWNJ mean, and skipping ZWJ is breaking those rules. That will be fixed in upcoming commits. src/hb-ot-layout-gpos-table.hh | 1 + src/hb-ot-layout-gsub-table.hh | 2 +- src/hb-ot-layout-gsubgpos-private.hh | 279 ++++++++++++++++++++++++----------- src/hb-ot-layout-private.hh | 45 ++++++ src/hb-ot-shape-private.hh | 44 ------ 5 files changed, 237 insertions(+), 134 deletions(-) commit ec5448667b30ad662401c2b4f5fc0da524c013fd Author: Behdad Esfahbod Date: Thu Feb 14 11:25:10 2013 -0500 Add hb_ot_map_feature_flags_t Code cleanup. No (intended) functional change. src/hb-ot-map-private.hh | 29 +++++++++++++++++--- src/hb-ot-map.cc | 24 ++++++++--------- src/hb-ot-shape-complex-arabic.cc | 4 +-- src/hb-ot-shape-complex-indic.cc | 55 +++++++++++++++++++------------------- src/hb-ot-shape-complex-myanmar.cc | 4 +-- src/hb-ot-shape-complex-sea.cc | 2 +- src/hb-ot-shape.cc | 6 +++-- 7 files changed, 74 insertions(+), 50 deletions(-) commit e7ffcfafb1108801ac504f18f820e497226bf07f Author: Behdad Esfahbod Date: Thu Feb 14 11:05:56 2013 -0500 Clean-up add_bool_feature src/hb-ot-map-private.hh | 4 ++-- src/hb-ot-shape-complex-arabic.cc | 16 ++++++++-------- src/hb-ot-shape-complex-default.cc | 2 +- src/hb-ot-shape-complex-indic.cc | 8 ++++---- src/hb-ot-shape-complex-myanmar.cc | 8 ++++---- src/hb-ot-shape-complex-sea.cc | 8 ++++---- src/hb-ot-shape.cc | 10 +++++----- 7 files changed, 28 insertions(+), 28 deletions(-) commit e7562f53fe6a506d2c6d59d6688e4fa468bba462 Author: Behdad Esfahbod Date: Thu Feb 14 11:05:36 2013 -0500 Fix compile warnings for ragel-generated machines src/hb-ot-shape-complex-indic-machine.rl | 2 +- src/hb-ot-shape-complex-myanmar-machine.rl | 2 +- src/hb-ot-shape-complex-sea-machine.rl | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) commit 4e51df73a337f7232a7dfa85df78a4f19b24771b Author: Behdad Esfahbod Date: Thu Feb 14 07:42:42 2013 -0500 [OTLayout] Remove unused function src/hb-ot-layout-gsubgpos-private.hh | 5 ----- 1 file changed, 5 deletions(-) commit 8820bb235b1f63e4d93c8a2f5c08b44d89e06b78 Author: Behdad Esfahbod Date: Thu Feb 14 07:41:03 2013 -0500 [OTLayout] Port apply_lookup to skippy_iter src/hb-ot-layout-gsubgpos-private.hh | 50 +++++++++++++++++++++++++----------- 1 file changed, 35 insertions(+), 15 deletions(-) commit dfca269f069dae2f99990dac24da15d316eccb9f Author: Behdad Esfahbod Date: Thu Feb 14 07:20:52 2013 -0500 [OTLayout] Port ligate_input to skippy_iter src/hb-ot-layout-gsubgpos-private.hh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 7e53415c2d8859e8b5948a2edb38c39a8f78b825 Author: Behdad Esfahbod Date: Thu Feb 14 06:24:30 2013 -0500 [OTLayout] Minor fix for apply_lookup() Should NOT change behavior, since first glyph is a match. src/hb-ot-layout-gsubgpos-private.hh | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) commit 6880f7e19d44c50e45ecb86d26381aad956d9acb Author: Behdad Esfahbod Date: Wed Feb 13 12:17:25 2013 -0500 [OTLayout] Make table type known to apply context src/hb-ot-layout-gsubgpos-private.hh | 5 ++++- src/hb-ot-layout.cc | 4 ++-- src/hb-ot-shape-complex-arabic-fallback.hh | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) commit 2c7d0b6b80d412de3fddd443ed1a485ea1cbb03c Author: Behdad Esfahbod Date: Wed Feb 13 12:10:08 2013 -0500 [OTLayou] Unbreak backtrack matching Was introduced by 28b9d502bb69a8045818d5f6113ded9c59a56bd7. src/hb-ot-layout-gsubgpos-private.hh | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) commit c074ebc466dcc9bcc0d8a5dd7e942dea974ff718 Author: Behdad Esfahbod Date: Wed Feb 13 11:22:42 2013 -0500 [OTLayout] Minor refactoring src/hb-ot-layout-gpos-table.hh | 9 ++++++--- src/hb-ot-layout-gsubgpos-private.hh | 30 +++++++++++++++++------------- 2 files changed, 23 insertions(+), 16 deletions(-) commit 407fc12466ef460d0edf11b89f0d04c4d724875f Author: Behdad Esfahbod Date: Wed Feb 13 11:13:06 2013 -0500 [OTLayout] Remove bogus caching of glyph property src/hb-ot-layout-gpos-table.hh | 21 ++++++++----------- src/hb-ot-layout-gsub-table.hh | 7 +++---- src/hb-ot-layout-gsubgpos-private.hh | 40 ++++++++++++++---------------------- 3 files changed, 26 insertions(+), 42 deletions(-) commit 6b1e3502e23c110dd810f854ba021f83baab1548 Author: Behdad Esfahbod Date: Wed Feb 13 11:02:54 2013 -0500 Remember ZWNJ To be used in upcoming changes. src/hb-ot-shape-private.hh | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) commit 1f91c39677f840a1f630696d16d083060069abf5 Author: Behdad Esfahbod Date: Wed Feb 13 09:38:40 2013 -0500 Indent src/hb-ot-shape-complex-indic.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit a0cb9f33ee064628debe8e848094dfd661334640 Author: Behdad Esfahbod Date: Wed Feb 13 09:26:55 2013 -0500 [Indic] Improve base finding in final_reordering Fixes 5 Malayalam failures! MALAYALAM: 1048016 out of 1048334 tests passed. 318 failed (0.0303338%) src/hb-ot-shape-complex-indic.cc | 7 +++++++ 1 file changed, 7 insertions(+) commit 126f39cd16cea87b2696f66467c83a585bd4c2cf Author: Behdad Esfahbod Date: Wed Feb 13 08:29:21 2013 -0500 Add more dot-reph tests .../shaper-indic/indic/script-malayalam/misc/dot-reph.txt | 10 ++++++++++ 1 file changed, 10 insertions(+) commit f22b7e77783fa2f44365e0fe6413c4474c07048d Author: Behdad Esfahbod Date: Wed Feb 13 07:32:46 2013 -0500 [Indic] Track base position when reordering things Ouch, how did things ever work without this?! The added test that has a dot-reph as well as a pre-base reordering Ra perfectly demonstrates the bug (tested with Nirmala font from Win8 for example). Testing suggests that Win8 shaper has the *exact* same bug / behavior that we used to have. Odd. src/hb-ot-shape-complex-indic.cc | 6 ++++++ .../in-tree/shaper-indic/indic/script-malayalam/misc/dot-reph.txt | 1 + 2 files changed, 7 insertions(+) commit bc11de144c0a7a95fa0945aa7f053d8117af282a Author: Behdad Esfahbod Date: Wed Feb 13 05:59:06 2013 -0500 [SEA] Don't zero any mark advances Keep the logic simple, easier to explain to font developers. src/hb-ot-shape-complex-sea.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0291a6528685f1f593707655943fb2360579cb9e Author: Behdad Esfahbod Date: Wed Feb 13 05:57:24 2013 -0500 Further adjust mark advance zeroing This is a followup to 568000274c8edb5f41bc4f876ce21fcc8bdaeed8. Looks like in the Latin shaper, Uniscribe zeroes all Unicode NSM advances *after* GPOS, not before. Match that. Can be tested using DejaVu Sans Mono, since that font has GPOS rules to zero the mark advances on its own. src/hb-ot-shape.cc | 33 +++++++++++++++++++++++---------- 1 file changed, 23 insertions(+), 10 deletions(-) commit 85c51ec2e1d518019e32801ae38659c74fc20d80 Author: Behdad Esfahbod Date: Tue Feb 12 18:17:39 2013 -0500 [Indic] Fix Eyelash Ra with old Devanagari spec src/hb-ot-shape-complex-indic.cc | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) commit cc5f24cde079b451799562b3af7ce06d932cbe6b Author: Behdad Esfahbod Date: Tue Feb 12 18:17:12 2013 -0500 [tests] Add tests for Devanagary Eyelash Ra Currently broken with Sanskrit 2003 font. .../texts/in-tree/shaper-indic/indic/script-devanagari/misc/MANIFEST | 1 + .../in-tree/shaper-indic/indic/script-devanagari/misc/eyelash.txt | 3 +++ 2 files changed, 4 insertions(+) commit 63e48bc33b68f940c351af623a55a4cf650db102 Author: Behdad Esfahbod Date: Tue Feb 12 17:57:49 2013 -0500 [Indic] Apply 'blwf' before 'half' This reverts 167b625d988b74572d6b2f646c285b666b650d49. It didn't matter before, but that's going to change with next commit. src/hb-ot-shape-complex-indic.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 70d656571194d2bd32671244530edbe159722cec Author: Behdad Esfahbod Date: Tue Feb 12 18:01:21 2013 -0500 [Indic] Apply 'vatu' before 'cjct' This essentially reverts 1d6846db9ebf84561bb30a4e48c6c43184914099, but that commit is from way back when. We should be better following the spec order now again. src/hb-ot-shape-complex-indic.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 64bb2ae857cfda35dd71c7f1e962722069674ec6 Author: Behdad Esfahbod Date: Tue Feb 12 16:29:25 2013 -0500 Didn't mean to push this out Ouch! test/shaping/hb_test_tools.py | 1 - 1 file changed, 1 deletion(-) commit f9b660534c269d2257d6b5e8ec2173ee71668f2f Author: Behdad Esfahbod Date: Tue Feb 12 16:13:56 2013 -0500 [Myanmar] Use master Indic table for syllable data src/hb-ot-shape-complex-myanmar.cc | 144 +++++++++---------------------------- test/shaping/hb_test_tools.py | 1 + 2 files changed, 35 insertions(+), 110 deletions(-) commit f60793e854393c32337a483c5d1700bf17d767fd Author: Behdad Esfahbod Date: Tue Feb 12 15:45:59 2013 -0500 [tests] Add Cham sample test/shaping/texts/in-tree/shaper-sea/script-cham/misc/misc.txt | 1 + 1 file changed, 1 insertion(+) commit e2aab4b5db88c368c11cee81368b9ad41399e585 Author: Behdad Esfahbod Date: Tue Feb 12 15:35:32 2013 -0500 Improve checks for setmode() As reported by Jonathan, OS X has setmode() that is something other than what setmode() is on Win32. So, limit invocation to Windows platforms only. configure.ac | 4 ++-- util/options.cc | 4 ++-- util/options.hh | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) commit a6c1e040e594faeefd61b456ef995c7886cdea78 Author: Behdad Esfahbod Date: Tue Feb 12 15:31:58 2013 -0500 Improve check for Windows platforms Instead of checking for compiler, check for platform. src/hb-atomic-private.hh | 2 +- src/hb-mutex-private.hh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 9e1f80ab3eea4a74cdaa6a390e4925a479ece1c5 Author: Behdad Esfahbod Date: Tue Feb 12 15:28:21 2013 -0500 [SEA] Treat Consonant_Final like Consonant_Medial src/hb-ot-shape-complex-indic-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bab02d339f39ed5168daaef9461227f78e596a2f Author: Behdad Esfahbod Date: Tue Feb 12 15:26:45 2013 -0500 Rename HB_OT_INDIC_OPTIONS env var to HB_OPTIONS The Myanmar shaper now respects the uniscribe-bug-compatibility option too. src/hb-common.cc | 20 ++++++++++++-- src/hb-ot-shape-complex-indic.cc | 53 ++++---------------------------------- src/hb-ot-shape-complex-myanmar.cc | 7 ++--- src/hb-private.hh | 29 +++++++++++++++++++++ 4 files changed, 54 insertions(+), 55 deletions(-) commit 3a83d33ec0b1be6f5992816ff5ebb0f43c8dff00 Author: Behdad Esfahbod Date: Tue Feb 12 12:14:10 2013 -0500 Add South-East Asian shaper Handles Tai Tham, Cham, and New Tai Lue for now. src/Makefile.am | 12 +- src/gen-indic-table.py | 9 +- src/hb-ot-shape-complex-indic-private.hh | 241 +------------ ...table.hh => hb-ot-shape-complex-indic-table.cc} | 9 +- src/hb-ot-shape-complex-indic.cc | 239 ++++++++++++ src/hb-ot-shape-complex-myanmar.cc | 2 +- src/hb-ot-shape-complex-private.hh | 28 +- src/hb-ot-shape-complex-sea-machine.rl | 102 ++++++ src/hb-ot-shape-complex-sea.cc | 400 +++++++++++++++++++++ test/shaping/texts/in-tree/MANIFEST | 1 + .../in-tree/shaper-indic/south-east-asian/MANIFEST | 1 - test/shaping/texts/in-tree/shaper-myanmar/MANIFEST | 1 + test/shaping/texts/in-tree/shaper-sea/MANIFEST | 3 + .../script-cham}/MANIFEST | 0 .../script-cham}/misc/MANIFEST | 0 .../in-tree/shaper-sea/script-cham/misc/misc.txt | 1 + .../in-tree/shaper-sea/script-new-tai-lue/MANIFEST | 1 + .../shaper-sea/script-new-tai-lue/misc/MANIFEST | 1 + .../script-new-tai-lue/misc/misc.txt | 0 .../in-tree/shaper-sea/script-tai-tham/MANIFEST | 1 + .../shaper-sea/script-tai-tham/misc/MANIFEST | 1 + .../shaper-sea/script-tai-tham/misc/misc.txt | 2 + 22 files changed, 792 insertions(+), 263 deletions(-) commit fb960212063016656dfaba83f072c81d1efc3202 Author: Behdad Esfahbod Date: Tue Feb 12 10:33:58 2013 -0500 Minor test reshufflings test/shaping/texts/in-tree/MANIFEST | 1 + .../{shaper-indic/south-asian/script-tibetan => script-default}/MANIFEST | 0 .../south-asian/script-tibetan => script-default}/misc/MANIFEST | 0 .../south-asian/script-tibetan => script-default}/misc/misc.txt | 0 test/shaping/texts/in-tree/shaper-indic/MANIFEST | 1 - test/shaping/texts/in-tree/shaper-indic/south-asian/MANIFEST | 1 - test/shaping/texts/in-tree/shaper-indic/south-east-asian/MANIFEST | 1 - .../texts/in-tree/shaper-indic/south-east-asian/script-thai/MANIFEST | 1 - .../in-tree/shaper-indic/south-east-asian/script-thai/misc/MANIFEST | 0 9 files changed, 1 insertion(+), 4 deletions(-) commit 5676d5d52784e16068ae483103d59111a8081854 Author: Behdad Esfahbod Date: Tue Feb 12 10:31:14 2013 -0500 [Indic] Make sure New Tai Lue works! src/hb-ot-shape-complex-private.hh | 12 ++++++++---- .../texts/in-tree/shaper-indic/south-east-asian/MANIFEST | 1 + .../south-east-asian/script-new-tai-lue/MANIFEST | 1 + .../south-east-asian/script-new-tai-lue/misc/MANIFEST | 1 + .../south-east-asian/script-new-tai-lue/misc/misc.txt | 1 + 5 files changed, 12 insertions(+), 4 deletions(-) commit 568000274c8edb5f41bc4f876ce21fcc8bdaeed8 Author: Behdad Esfahbod Date: Tue Feb 12 09:44:57 2013 -0500 Adjust mark advance-width zeroing logic for Myanmar Before, we were zeroing advance width of attached marks for non-Indic scripts, and not doing it for Indic. We have now three different behaviors, which seem to better reflect what Uniscribe is doing: - For Indic, no explicit zeroing happens whatsoever, which is the same as before, - For Myanmar, zero advance width of glyphs marked as marks *in GDEF*, and do that *before* applying GPOS. This seems to be what the new Win8 Myanmar shaper does, - For everything else, zero advance width of glyphs that are from General_Category=Mn Unicode characters, and do so before applying GPOS. This seems to be what Uniscribe does for Latin at least. With these changes, positioning of all tests matches for Myanmar, except for the glitch in Uniscribe not applying 'mark'. See preivous commit. src/hb-ot-layout-gpos-table.hh | 12 ++++-------- src/hb-ot-layout-private.hh | 3 +-- src/hb-ot-layout.cc | 4 ++-- src/hb-ot-shape-complex-arabic.cc | 2 +- src/hb-ot-shape-complex-default.cc | 2 +- src/hb-ot-shape-complex-indic.cc | 2 +- src/hb-ot-shape-complex-myanmar.cc | 2 +- src/hb-ot-shape-complex-private.hh | 9 ++++++++- src/hb-ot-shape-complex-thai.cc | 2 +- src/hb-ot-shape.cc | 31 +++++++++++++++++++++++++++++-- 10 files changed, 49 insertions(+), 20 deletions(-) commit 99749ca8e0c4c8dbea4620f07c4d0e6d1515cc65 Author: Behdad Esfahbod Date: Tue Feb 12 09:44:35 2013 -0500 [Myanmar] Add note re Uniscribe NOT applying 'mark' src/hb-ot-shape-complex-myanmar.cc | 14 ++++++++++++++ 1 file changed, 14 insertions(+) commit b8427801381180da9611b2e3e0f0b3514274de81 Author: Behdad Esfahbod Date: Mon Feb 11 17:02:17 2013 -0500 Minor src/hb-atomic-private.hh | 2 +- src/hb-mutex-private.hh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 419c933ed1b5d97c7561546536ef5810a7b0ebd0 Author: Behdad Esfahbod Date: Mon Feb 11 16:16:16 2013 -0500 [Myanmar] Fix handling of Punctuation and Symbol types Testing with "clusters" now on par with testing without them. 15 failures both. src/hb-ot-shape-complex-myanmar.cc | 12 ++++++++++++ 1 file changed, 12 insertions(+) commit 0572c1410a9cb0ac5dd5dc84a8034698cc5c4892 Author: Behdad Esfahbod Date: Mon Feb 11 16:06:02 2013 -0500 [Myanmar] Fixup handling of joiners and GB characters src/hb-ot-shape-complex-myanmar-machine.rl | 6 ++---- src/hb-ot-shape-complex-myanmar.cc | 19 +++++++++++++++++-- 2 files changed, 19 insertions(+), 6 deletions(-) commit 1c8654ead41ca746d577549c92d2a41c594ab639 Author: Behdad Esfahbod Date: Mon Feb 11 14:27:02 2013 -0500 [Myanmar] Prevent reordering between Asat and Dot below Implemented as a hack for now. Myanmar failures down from 23 to 15. MYANMAR: 1123868 out of 1123883 tests passed. 15 failed (0.00133466%) The remaining 15 cases are all where the syllable is wrong according to the OpenType spec. We insert dottedcircle. Uniscribe fails to do that, but it also fails to reorder the prebase-reordering medial-Ra. So it gets it wrong. src/hb-unicode-private.hh | 3 +++ 1 file changed, 3 insertions(+) commit bed687f886b8def06642ad986648e9149a935add Author: Behdad Esfahbod Date: Mon Feb 11 14:24:03 2013 -0500 Shuffle test data around test/shaping/texts/in-tree/MANIFEST | 1 + test/shaping/texts/in-tree/shaper-indic/south-east-asian/MANIFEST | 1 - .../in-tree/shaper-indic/south-east-asian/script-thai/misc/MANIFEST | 1 - .../south-east-asian => shaper-myanmar}/script-myanmar/MANIFEST | 0 .../south-east-asian => shaper-myanmar}/script-myanmar/misc/MANIFEST | 0 .../south-east-asian => shaper-myanmar}/script-myanmar/misc/misc.txt | 0 .../south-east-asian => shaper-myanmar}/script-myanmar/misc/utn11.txt | 0 test/shaping/texts/in-tree/shaper-thai/script-thai/misc/MANIFEST | 1 + .../south-east-asian => shaper-thai}/script-thai/misc/misc.txt | 0 9 files changed, 2 insertions(+), 2 deletions(-) commit 98628cac9f733f2674d6409954cddb7d0634c233 Author: Behdad Esfahbod Date: Mon Feb 11 13:36:23 2013 -0500 Add Win8-style Myanmar shaper Myanmar failures down from 51% to 0.00204648%! MYANMAR: 1123860 out of 1123883 tests passed. 23 failed (0.00204648%) src/Makefile.am | 14 +- src/hb-ot-shape-complex-indic.cc | 2 - src/hb-ot-shape-complex-myanmar-machine.rl | 127 ++++++ src/hb-ot-shape-complex-myanmar.cc | 599 +++++++++++++++++++++++++++++ src/hb-ot-shape-complex-private.hh | 5 +- 5 files changed, 740 insertions(+), 7 deletions(-) commit 1df56449586bd32275a6fa69dcadd5fb77a84f82 Author: Behdad Esfahbod Date: Mon Feb 11 14:17:54 2013 -0500 Minor src/hb-ot-shape-complex-indic.cc | 3 --- 1 file changed, 3 deletions(-) commit 54f7b4d9ec13f8454aa298534da318c023fa3c63 Author: Behdad Esfahbod Date: Mon Feb 11 13:27:17 2013 -0500 [OTLayout] Respect lookup-flags skipping over non-mark glyphs Before, when matching ligatures, we never skipping over base / liga glyphs even if that was what the LookupFlags asked for. Fixed now. We carefully reviewed all instances of this, and tested with Amiri as well as some Indic scripts, and are confident that this should NOT break anyone's fonts. It's also how Uniscribe does it, from what we can tell. src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-layout-gsubgpos-private.hh | 25 ++++++++++--------------- 2 files changed, 11 insertions(+), 16 deletions(-) commit 9082efc4aacb34de8574d6a4a3c037987df58bd8 Author: Behdad Esfahbod Date: Mon Feb 11 13:14:15 2013 -0500 [OTLayout] s/mark_skipping/skipping/ In aticipation of upcoming changes. src/hb-ot-layout-gpos-table.hh | 12 ++++++------ src/hb-ot-layout-gsubgpos-private.hh | 28 ++++++++++++++-------------- 2 files changed, 20 insertions(+), 20 deletions(-) commit 9621e0ba294c9cc6d458bbf632e63e92fda71e10 Author: Behdad Esfahbod Date: Mon Feb 11 06:58:27 2013 -0500 [Indic] Fix bug introduced in 8b217f5ac54aa0dcbba2dd6d59aa89dde33e56c2 Was breaking reph formation logic when the Ra is the only consonant. Devanagari regression fixed. Down to 57 failures again. Ouch. src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6e74c64211b6aaac48bae8c87f9420d8dc03fd93 Author: Behdad Esfahbod Date: Mon Feb 11 06:50:17 2013 -0500 Improve normalization heuristic Before, for most scripts, we were not trying to recompose two characters if the second one had ccc=0. That fails for Myanmar where U+1026 decomposes to U+1025,U+102E, both of which have ccc=0. However, we do want to try to recompose those. We now check whether the second is a mark, using general category instead. At the same time, remove optimization that was conflicting with this. [Let the Ngapi hackfest begin!] src/hb-ot-shape-normalize.cc | 39 +++++++++++++-------------------------- 1 file changed, 13 insertions(+), 26 deletions(-) commit 614242efb043f2ed78916377138d456279a20a54 Author: Behdad Esfahbod Date: Wed Feb 6 23:45:27 2013 -0500 Revert "Include config.h.in in tree" This reverts commit 01013a0f5c58d5d54a37e5b4d6692e0bbd4baf80. Conflicts: config.h.in Same argument as previous commit. Makefile.am | 1 + config.h.in | 153 ------------------------------------------------------------ 2 files changed, 1 insertion(+), 153 deletions(-) commit adff3778155facb7b149ce66ab7d573368e048de Author: Behdad Esfahbod Date: Wed Feb 6 23:43:27 2013 -0500 Revert "[Indic] Import ragel-generated Indic machine in git" This reverts commit fab7a71f110ed646745d54b23284537c50058c21. Conflicts: src/hb-ot-shape-complex-indic-machine.hh Keeping that generated file in-tree causes problems with processes like tinderbox that automatically fetch and build harfbuzz. It's harder to bootstrap harfbuzz now (as was previously), but I'm willing to give this another chance and see how it goes. autogen.sh | 6 + src/Makefile.am | 1 + src/hb-ot-shape-complex-indic-machine.hh | 1443 ------------------------------ 3 files changed, 7 insertions(+), 1443 deletions(-) commit 5898fa94d12b19686f649104bd6efe8daa1ba0c9 Author: Behdad Esfahbod Date: Wed Feb 6 15:29:07 2013 -0500 Don't use $(ENV) As reported by Peter Breitenlohner: I think this is a very bad idea because ENV is used to specify a startup file to be read by some/all shells. test/api/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 52d66c26a2102bd1a49463b8e8f04612598f8ac1 Author: Behdad Esfahbod Date: Mon Feb 4 23:31:24 2013 -0500 Add color-tests automake option configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9de5f98f363d96f308adc33f1c2286e5c33117de Author: Behdad Esfahbod Date: Mon Feb 4 23:28:22 2013 -0500 Bug 60035 - intermittent make install failure on hb-version.h src/Makefile.am | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) commit 6c1e8b614cfd6ed016fba6bf20af1e422e79eb71 Author: Behdad Esfahbod Date: Mon Feb 4 23:24:16 2013 -0500 Bug 59637 - check-exported-symbols.sh & check-internal-symbols.sh fail on mips/mipsel src/check-symbols.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bafdf3d983dcc277d6e7e322277c0bb25b41a173 Author: Behdad Esfahbod Date: Mon Feb 4 23:06:50 2013 -0500 Merge check-internal-symbols.sh and check-exported-symbols.sh src/Makefile.am | 3 +- src/check-internal-symbols.sh | 34 ---------------------- ...{check-exported-symbols.sh => check-symbols.sh} | 16 ++++++++-- 3 files changed, 14 insertions(+), 39 deletions(-) commit ceeae30f47b9d628484ae398bc38f3f60ee8eab4 Author: Behdad Esfahbod Date: Thu Jan 31 19:27:36 2013 -0500 Really fix setmode this time Thanks to Khaled for spotting it. util/options.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7cba8a673b4b436a737fc4ffe85dc84ddd2bf41f Author: Behdad Esfahbod Date: Thu Jan 31 18:37:10 2013 -0500 Fixup previous commit Now, it looks like this breaks Cygwin again. Have to figure out what's going on. util/options.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit bc76449f51f20491a4540b4f240f5a3e0dcb20fe Author: Behdad Esfahbod Date: Thu Jan 31 18:18:05 2013 -0500 Use setmode() instead of _setmode() Looks like Cygwin / MSVC declare it that way, and it still works on MinGW32 cross. config.h.in | 6 +++--- configure.ac | 2 +- util/options.cc | 2 +- util/options.hh | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) commit e9171af55cc6a402eb20db4ea74c86a0b1e70e85 Author: Behdad Esfahbod Date: Tue Jan 29 22:45:00 2013 -0500 Bug 60053 - hb-common.cc:181:6: warning: ‘void free_langs()’ defined but not used src/hb-common.cc | 2 +- src/hb-ft.cc | 2 +- src/hb-shape.cc | 2 +- src/hb-shaper.cc | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) commit 09b5393874e56fcfd63a92d28e6c1c2ddeee0942 Author: Behdad Esfahbod Date: Fri Jan 18 17:10:47 2013 -0600 0.9.12 NEWS | 7 +++++++ configure.ac | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) commit eb45c0a2fbaeeb34e77a2935934e8d1302728ec8 Author: Behdad Esfahbod Date: Wed Jan 16 22:07:50 2013 -0600 Minor src/hb-ot-layout.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit 52c8d1226f3509276b11a1fadbd29e5363c0ecd7 Author: Behdad Esfahbod Date: Mon Jan 14 13:51:46 2013 -0600 Minor src/hb-blob.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f88d3bd7e407d332bb04688344c54756d24128c9 Author: Behdad Esfahbod Date: Mon Jan 14 00:33:58 2013 -0600 Fix build with Sun compiler src/hb-blob.cc | 3 +++ 1 file changed, 3 insertions(+) commit 08b29c08094097f1c23ec53b10084bc390cea833 Author: Behdad Esfahbod Date: Mon Jan 14 00:32:12 2013 -0600 Revert "Minor" This reverts commit 0a492357016bc9a614d2a726f2006c10af68ca58. Enables code on more compilers. src/hb-warning.cc | 33 ++++++++++++++++++++++++++++++--- 1 file changed, 30 insertions(+), 3 deletions(-) commit e78463211e7d85f237bd55afab7e8e5dae42346c Author: Behdad Esfahbod Date: Mon Jan 14 00:27:21 2013 -0600 Fix linking with non-gcc compilers configure.ac | 2 ++ src/Makefile.am | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) commit de649f07f1f8fdeb998a0b049759f4f7363e25d2 Author: Behdad Esfahbod Date: Mon Jan 14 00:26:43 2013 -0600 Fix residuals from fontconfig changes src/hb-atomic-private.hh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit cf81fb3624466b9df2250b58b27a92187c5b5b5c Author: Behdad Esfahbod Date: Thu Jan 10 09:06:34 2013 -0600 0.9.11 NEWS | 14 ++++++++++++++ configure.ac | 2 +- 2 files changed, 15 insertions(+), 1 deletion(-) commit 2dcb333f52492018816f0d5d67a47634a612e49c Author: Behdad Esfahbod Date: Thu Jan 10 01:17:59 2013 -0600 Add atomic ops for Solaris Based on fontconfig patch from Raimund Steger. config.h.in | 5 ++++- configure.ac | 27 +++++++++++++++++++++++++-- src/hb-atomic-private.hh | 12 ++++++++++++ 3 files changed, 41 insertions(+), 3 deletions(-) commit 69fd6e157c7ec83a5d5d8731fc14675ce4509b09 Author: Behdad Esfahbod Date: Thu Jan 10 00:03:36 2013 -0600 Fix crasher during multi-thread shaper data creation Sample crash: 0 _hb_graphite2_shaper_face_data_destroy (data=0xffffffffffffffff) at ../../src/hb-graphite2.cc:129 1 0x00007ffff4271d7d in hb_graphite2_shaper_face_data_ensure ( face=) at ../../src/hb-shaper-list.hh:35 2 hb_shape_plan_plan (shaper_list=, num_user_features=0, user_features=0x0, shape_plan=0xf7b490) at ../../src/hb-shaper-list.hh:35 3 hb_shape_plan_create (face=, props=, user_features=0x0, num_user_features=0, shaper_list=) at ../../src/hb-shape-plan.cc:108 4 0x00007ffff4272c93 in hb_shape_plan_create_cached (face=0x10cf2b0, props=0x11980d8, user_features=0x0, num_user_features=, shaper_list=0x0) at ../../src/hb-shape-plan.cc:283 src/hb-shaper-private.hh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit ecd454b3cd75050e0c95e1d2aa55744559338ec8 Author: Behdad Esfahbod Date: Tue Jan 8 18:09:46 2013 -0600 [Indic] In old-spec shaping, don't move viramas around if seq ends with one For example: u0c9a u0ccd u0c9a u0ccd with Lohit. See: https://bugs.freedesktop.org/show_bug.cgi?id=59118 src/hb-ot-shape-complex-indic.cc | 7 ++++--- .../texts/in-tree/shaper-indic/indic/script-kannada/misc/misc.txt | 1 + 2 files changed, 5 insertions(+), 3 deletions(-) commit e95e031b5682809488cc965883e15404cb9cfb6a Author: Behdad Esfahbod Date: Tue Jan 8 16:15:46 2013 -0600 [GPOS] If an Anchor offset is NULL, return false If in a MarkPos table, a base has no anchor for a particular mark class, return NULL such that the subsequent subtables get a chance at it. Test case: hb-shape ./EBGaramond12-Regular.otf ἂ --features="ss20","smcp" src/hb-open-type-private.hh | 14 ++++++++++++-- src/hb-ot-layout-gpos-table.hh | 10 ++++++++-- 2 files changed, 20 insertions(+), 4 deletions(-) commit e5dbf39900fa63051f64cc447a6742665cbee339 Author: Behdad Esfahbod Date: Mon Jan 7 17:34:24 2013 -0600 Bug 58638 - Building fails with ICU due to not passing required flags configure.ac | 1 + 1 file changed, 1 insertion(+) commit 1172dc736280566426eb6dade1a886b2a0ca9aa4 Author: Behdad Esfahbod Date: Mon Jan 7 16:46:37 2013 -0600 Rename hb_buffer_clear() to hb_buffer_clear_contents() The previous name was clashing with harfbuzz.old. There are systems that need to link both... Clash-free now again. src/hb-buffer.cc | 2 +- src/hb-buffer.h | 2 +- test/api/test-buffer.c | 2 +- util/options.hh | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) commit 7b912c1936c3e8a7df27a30782ca127d0a83822d Author: Behdad Esfahbod Date: Fri Jan 4 01:25:27 2013 -0600 Remove a few unnecessary const's Apparently helps with MSVC compilation. src/hb-ot-layout-gsubgpos-private.hh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 34e6c3e3e452bdf6f93df565a70453a6e74d4c6e Author: Behdad Esfahbod Date: Thu Jan 3 00:14:24 2013 -0600 0.9.10 NEWS | 24 ++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 25 insertions(+), 1 deletion(-) commit f0c82410dbe800cb6429ba4aa7cfd9f5a11cc70c Author: Behdad Esfahbod Date: Thu Jan 3 00:07:16 2013 -0600 [OTLayout] Always collect default language system in collect_lookups Not sure if this is the most desired behavior. It's the most easily defined though. src/hb-ot-layout.cc | 7 +++++++ 1 file changed, 7 insertions(+) commit 15e9e4e1ddaad655988144e7a56a765e8adf8782 Author: Behdad Esfahbod Date: Thu Jan 3 00:04:40 2013 -0600 [OTLayout] Fix feature iteration in collect_lookups Previous logic was just wrong. src/hb-ot-layout.cc | 46 ++++++++++++++++++++++++++++++++-------------- 1 file changed, 32 insertions(+), 14 deletions(-) commit 733e8c0d7bf0765884f2cc953c8edcd7ab7fb49b Author: Behdad Esfahbod Date: Thu Jan 3 00:00:23 2013 -0600 [OTLayout] Whitespace src/hb-ot-layout.cc | 82 ++++++++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 68 insertions(+), 14 deletions(-) commit d37ae38047bee12639741af9bb083b857fab950d Author: Behdad Esfahbod Date: Wed Jan 2 23:57:36 2013 -0600 [OTLayout] Handle required_feature_index in collect_lookups src/hb-ot-layout.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit 11fba79ee9383eb995ddf7eb924dd64c67e2df63 Author: Behdad Esfahbod Date: Wed Jan 2 23:36:37 2013 -0600 [OTLayout] Fix various introspection issues with ClassDef's As reported by Jonathan Kew. src/hb-ot-layout-gsubgpos-private.hh | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) commit e81aff9ef785be28751aab1fcd484af550656181 Author: Behdad Esfahbod Date: Wed Jan 2 23:22:54 2013 -0600 [tests] Finish test-set.c All passing now. test/api/test-set.c | 373 +++++++++++++++++++++------------------------------- 1 file changed, 149 insertions(+), 224 deletions(-) commit 7b1b720a8da69b68b775ce17104a40d55401b7ef Author: Behdad Esfahbod Date: Wed Jan 2 23:02:59 2013 -0600 Protect sets in-error from further modication Fixes test-set.c src/hb-set-private.hh | 13 +++++++++++++ 1 file changed, 13 insertions(+) commit 8165f2765b93e99577ecc79b7956ae38c614bc78 Author: Behdad Esfahbod Date: Wed Jan 2 22:50:36 2013 -0600 [tests] Start adding tests for hb-set.h Fails now. Fixing. TODO | 2 - src/hb-set-private.hh | 6 + src/hb-set.cc | 9 +- src/hb-set.h | 3 + test/api/Makefile.am | 1 + test/api/test-set.c | 312 ++++++++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 330 insertions(+), 3 deletions(-) commit b9d28f696c433b94c5ffbad8d7c87cf3acff4056 Author: Behdad Esfahbod Date: Wed Jan 2 22:49:58 2013 -0600 [tests] Add set object to test-object.c test/api/test-object.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) commit 11d2956553f0d4a0086166a04ffc352fcfacf56e Author: Behdad Esfahbod Date: Wed Jan 2 17:41:27 2013 -0600 Minor src/hb-atomic-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 596740db04e7c1dadae0d8be6e401089fcaffc2d Author: Behdad Esfahbod Date: Fri Dec 21 19:41:04 2012 -0500 [Indic] Insert dottedcircle after a lone Malayalam dot-reph src/hb-ot-shape-complex-indic-machine.hh | 1617 ++++++++++++++++-------------- src/hb-ot-shape-complex-indic-machine.rl | 2 +- src/hb-ot-shape-complex-indic.cc | 13 +- 3 files changed, 881 insertions(+), 751 deletions(-) commit 3cdce6497b2b9aeb2841bf077daa9dd9b196429d Author: Behdad Esfahbod Date: Fri Dec 21 16:54:22 2012 -0500 Remove TODO that I don't intend to fix TODO | 1 - 1 file changed, 1 deletion(-) commit 6f69fa283e0a488da811df78bc83c41ed248b688 Author: Behdad Esfahbod Date: Fri Dec 21 16:51:15 2012 -0500 Minor src/hb-shape.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f4abcbfc628718bb276363746440df06e7658f6e Author: Behdad Esfahbod Date: Fri Dec 21 16:48:51 2012 -0500 Minor src/hb-buffer.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 4a765f092d71bb4adeb468c004987a9121d39db5 Author: Behdad Esfahbod Date: Fri Dec 21 16:48:47 2012 -0500 Minor util/hb-shape.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9815a88111072aa51e78e258c5f660993b47d4df Author: Behdad Esfahbod Date: Fri Dec 21 16:46:53 2012 -0500 [util] List supported output formats in --help output util/hb-shape.cc | 6 +++--- util/helper-cairo.cc | 2 +- util/helper-cairo.hh | 1 + util/options.cc | 9 ++++++++- util/options.hh | 5 ++++- util/view-cairo.hh | 2 +- 6 files changed, 18 insertions(+), 7 deletions(-) commit f95a87b7b813f588c7910ad4785ee68bb452e864 Author: Behdad Esfahbod Date: Fri Dec 21 16:35:28 2012 -0500 [util] List supported output formats in hb-view TODO | 1 - util/helper-cairo.cc | 30 +++++++++++++++++++++++++++++- 2 files changed, 29 insertions(+), 2 deletions(-) commit 6bad092aa87bc3e6bbf0b9faf07693e6ebbe55f2 Author: Behdad Esfahbod Date: Fri Dec 21 16:01:52 2012 -0500 [util] Default to "text" output format in hb-shape If you say: hb-shape font.ttf text --output-file out.txt This was previously failing: Unknown output format `txt'; supported formats are: TEXT / JSON Now we simply fallback to TEXT if no explicit format was requested. util/hb-shape.cc | 11 ++++++++--- util/options.hh | 5 +++++ 2 files changed, 13 insertions(+), 3 deletions(-) commit 8b217f5ac54aa0dcbba2dd6d59aa89dde33e56c2 Author: Behdad Esfahbod Date: Fri Dec 21 15:48:32 2012 -0500 [Indic] Reorder Malayalam dot-reph to after base Test sequence is simple: U+0D4E,U+0D15. The doth-reph should be reordered to after the Ka. https://bugzilla.redhat.com/show_bug.cgi?id=799565 src/hb-ot-shape-complex-indic.cc | 13 ++++++++++--- .../shaper-indic/indic/script-malayalam/misc/MANIFEST | 1 + .../shaper-indic/indic/script-malayalam/misc/dot-reph.txt | 1 + 3 files changed, 12 insertions(+), 3 deletions(-) commit 742c4ee97e1311e000ebcdf9f33361c4dc6400a4 Author: Behdad Esfahbod Date: Fri Dec 21 15:35:03 2012 -0500 Minor src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 94afeb6ebe27534fc80d7173cc6f67375c3aaca6 Author: Behdad Esfahbod Date: Fri Dec 21 11:54:50 2012 -0500 Add Android.mk Android.mk | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Makefile.am | 1 + 2 files changed, 75 insertions(+) commit d16ddbcbbee39b07a028776995c635119fe3cd98 Author: Behdad Esfahbod Date: Thu Dec 20 01:02:36 2012 -0500 Add build confirmation notice to configure configure.ac | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) commit e24d8dab749a1a796e7484e18572da5f7a733bd4 Author: Behdad Esfahbod Date: Wed Dec 19 15:23:02 2012 -0500 [TODO] Remove done items TODO | 7 ------- 1 file changed, 7 deletions(-) commit 044d38527664d933c18c751c38fcf6fb4b5f888e Author: Behdad Esfahbod Date: Wed Dec 19 13:00:16 2012 -0500 Bug 58498 - Tests fail with gold linker on ARM src/check-exported-symbols.sh | 2 +- src/check-internal-symbols.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit b68b86daf1a8478b86aeae44a8c39a606ed873cb Author: Behdad Esfahbod Date: Tue Dec 18 20:39:40 2012 -0500 Use C++ linker if ICU is disabled Bug 54948 - Undefined symbols: "operator delete(void*)" "operator new(unsigned long)" "___cxa_pure_virtual" src/Makefile.am | 4 ++++ 1 file changed, 4 insertions(+) commit 1ffd23cb47a61465d52a7aeebb9c1b676e7c9a7e Author: Behdad Esfahbod Date: Mon Dec 17 23:29:15 2012 -0500 [OTLayout] Limit alternate-location FeatureParams to 'size' feature src/hb-ot-layout-common-private.hh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit efe252e6000558f78075adadb2a3dba25ab67c04 Author: Behdad Esfahbod Date: Mon Dec 17 23:21:05 2012 -0500 [OTLayout] Fix 'size' featureParams implementation Looks at alternate location now. src/hb-ot-layout-common-private.hh | 133 ++++++++++++++++++++++++++++--------- src/hb-ot-layout.cc | 93 ++++---------------------- 2 files changed, 117 insertions(+), 109 deletions(-) commit e77b4425746ac9eb407ca4e742d962f1955971b4 Author: Behdad Esfahbod Date: Mon Dec 17 18:42:59 2012 -0500 [OTLayout] Fix tracing src/hb-open-type-private.hh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 9b54562d63f1a9e0e5b33d71c32bd1588759ebf1 Author: Behdad Esfahbod Date: Mon Dec 17 13:55:36 2012 -0500 [OTLayout] Towards correct FeatureParams handling src/hb-open-type-private.hh | 8 +++++++- src/hb-ot-layout-common-private.hh | 25 +++++++++++++++++++++++-- 2 files changed, 30 insertions(+), 3 deletions(-) commit 87e43b7f2be25840748f920ca33ff553833da45f Author: Behdad Esfahbod Date: Fri Dec 14 17:48:23 2012 -0500 [OTLayout] Wire tag and list start all the way to Feature To fix FeatureParam issues. No actual fix yet, just plumbing. src/hb-ot-layout-common-private.hh | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) commit 85bc44b90a19c6a669ed567a9cd8513448600afe Author: Behdad Esfahbod Date: Wed Dec 12 11:38:49 2012 -0500 [OTLayout] More 'size' feature sanity checking We still don't look for the old incorrect place of the featureParams. I'll wait till someone actually complains about it... src/hb-ot-layout.cc | 99 ++++++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 79 insertions(+), 20 deletions(-) commit 0bae50a36f3022f9bb6b2c001c191eeaaa4ef954 Author: Behdad Esfahbod Date: Tue Dec 11 16:01:31 2012 -0500 [OTLayout] Add FeatureParamsCharacterVariants struct No API yet. src/hb-ot-layout-common-private.hh | 52 +++++++++++++++++++++++++++++++++++--- 1 file changed, 49 insertions(+), 3 deletions(-) commit bd61bc13ea8ff350ada5449b2cfeb612e66ecafa Author: Behdad Esfahbod Date: Tue Dec 11 16:00:43 2012 -0500 [OTLayout] Add UINT24 type src/hb-open-type-private.hh | 33 ++++++++++++++++++++++----------- src/hb-private.hh | 4 ++++ 2 files changed, 26 insertions(+), 11 deletions(-) commit 9cf7f9d4f61741932570afbefdee5edf61f79ae4 Author: Behdad Esfahbod Date: Tue Dec 11 14:31:13 2012 -0500 Make test-size-params write size in points src/test-size-params.cc | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) commit 372fe2b67b1757e809bf33e1e9055a00c5bed304 Author: Behdad Esfahbod Date: Tue Dec 11 14:30:57 2012 -0500 [OTLayout] Make hb_ot_layout_get_size_params() do some checks src/hb-ot-layout.cc | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit 875a5cbc9c37f4264241c43b80afad2628eab749 Author: Behdad Esfahbod Date: Tue Dec 11 14:17:01 2012 -0500 [OTLayout] Change hb_ot_layout_get_params() API And add implementation for StylisticSet UINameID. No API yet. src/hb-ot-layout-common-private.hh | 85 ++++++++++++++++++++++++++++++++++++-- src/hb-ot-layout.cc | 28 +++++++++---- src/hb-ot-layout.h | 8 +++- src/test-size-params.cc | 9 +++- 4 files changed, 115 insertions(+), 15 deletions(-) commit 5e7e52ddf2b0c4fbc9d933d24336100368d39a5c Author: Behdad Esfahbod Date: Mon Dec 10 17:44:22 2012 -0500 [uniscribe] Enable Uniscribe backend only if it has ScriptShapeOpenType() Bug 55494 - ScriptItemizeOpenType doesn't exists under Windows XP config.h.in | 6 ------ configure.ac | 14 +++++++++++++- 2 files changed, 13 insertions(+), 7 deletions(-) commit d41c0c955b8ad9b52191ca47e1f3b1bfe606deb1 Author: Behdad Esfahbod Date: Mon Dec 10 16:41:20 2012 -0500 Update config template config.h.in | 4 ---- 1 file changed, 4 deletions(-) commit c48a04e5ea899b82465a0f3f2cfdcffb3bf38f61 Author: John Ralls Date: Mon Dec 10 16:24:24 2012 -0500 [coretext] Better test for CoreText Instead of checking for ApplicationServices.h, which is present in all versions of MacOSX, check for CTFontRef, a CoreText basic type. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0e9f0f3e5f16a45951423a1229af42dc2fd798c3 Author: Behdad Esfahbod Date: Mon Dec 10 15:25:21 2012 -0500 Fix atomic ops on iOS Patch from John Ralls. src/hb-atomic-private.hh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 5f9569c1391c65d7addff363ad6e5ec9b087f01a Author: Behdad Esfahbod Date: Mon Dec 10 13:38:42 2012 -0500 Make older MSVC happy src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 071d5b831e6de5f3b24160dc77b139cb040ab886 Author: Behdad Esfahbod Date: Mon Dec 10 00:57:00 2012 -0500 Work around missing OSAtomicCompareAndSwapPtrBarrier() on OS X 10.4 Not sure how to handle iOS. src/hb-atomic-private.hh | 11 +++++++++++ 1 file changed, 11 insertions(+) commit e923e6487b25ab86f6f629af480b291e8e5407b5 Author: Behdad Esfahbod Date: Sun Dec 9 19:39:40 2012 -0500 [coretext] Fixed typo Oops. Thanks Khaled for catching this. src/hb-coretext.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9a8395824bf51c2ff2cfe0887ecad52b3d2c02e2 Author: Behdad Esfahbod Date: Sun Dec 9 18:47:36 2012 -0500 [coretext] Add hb_coretext_face_get_cg_font() Not sure if it's useful, but it was missing. src/hb-coretext.cc | 20 ++++++++++++++------ src/hb-coretext.h | 3 +++ 2 files changed, 17 insertions(+), 6 deletions(-) commit 86112356885fde32163882b6c9dd19a494304f7a Author: Behdad Esfahbod Date: Sun Dec 9 18:47:09 2012 -0500 [coretext] Remove hack around GlyphID We not namespace our types, so the hack is not needed anymore. src/hb-coretext.cc | 4 ---- 1 file changed, 4 deletions(-) commit 8e58459aeb949591bb5bca340ef9bdd5cfd54e47 Author: Behdad Esfahbod Date: Sun Dec 9 18:45:47 2012 -0500 [graphite2] "Update to new API" Part of patch from Martin Hosken. I believe he knows what he's doing :). src/hb-graphite2.cc | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) commit a5a4ab3846ef06769784e6469d76eace35e68805 Author: Behdad Esfahbod Date: Sun Dec 9 18:44:41 2012 -0500 [graphite2] Add hb_graphite2_face_get_gr_face and hb_graphite2_font_get_gr_font Based on patch from Martin Hosken. I believe it returns NULL if the font doesn't have graphite tables, but have not tested. src/hb-graphite2.cc | 14 ++++++++++++++ src/hb-graphite2.h | 8 +++++++- 2 files changed, 21 insertions(+), 1 deletion(-) commit 737ba156442f723d126c7c58c73729786b67c17a Author: Behdad Esfahbod Date: Sun Dec 9 18:43:03 2012 -0500 [graphite2] Preload all tables Part of patch from Martin Hosken. src/hb-graphite2.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0ae6dbf1b4de8a0326b8a2f201597427cecfb6db Author: Behdad Esfahbod Date: Sun Dec 9 18:37:38 2012 -0500 Minor src/hb-uniscribe.cc | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) commit 3fe5c159d3532f8ce8a85d217a00681225dd8ed1 Author: Behdad Esfahbod Date: Sun Dec 9 18:20:19 2012 -0500 Remove excess return Oops! src/hb-uniscribe.cc | 1 - 1 file changed, 1 deletion(-) commit ba2d543004573e8e4e56df70b7fe2a66a42bc83f Author: Behdad Esfahbod Date: Sat Dec 8 19:28:41 2012 -0500 Update OT language tags Patch from Roozbeh Pournader. src/hb-ot-tag.cc | 212 +++++++++++++++++++++++++++++-------------------------- 1 file changed, 110 insertions(+), 102 deletions(-) commit aba38173c6b464c2884b73ef6cd4577d4efcebbc Author: Behdad Esfahbod Date: Wed Dec 5 19:54:48 2012 -0500 Minor src/hb-ot-tag.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 61865745e35eb60aeb59968e7826e37059090780 Author: Behdad Esfahbod Date: Wed Dec 5 19:42:10 2012 -0500 Fix test with gold linker Bug 57633 - Symbol tests should ignore __bss_start, _edata, _end src/check-exported-symbols.sh | 2 +- src/check-internal-symbols.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit b71b0bd9ee64feadd7289e195bc58f6361ce707a Author: Behdad Esfahbod Date: Wed Dec 5 19:20:31 2012 -0500 [Indic] Add link to Sinhala split matra section of the Sinhala spec src/hb-ot-shape-complex-indic.cc | 5 +++++ 1 file changed, 5 insertions(+) commit 9a34a50daac3563464e0031f377e85f0c704f2d6 Author: Behdad Esfahbod Date: Wed Dec 5 19:18:18 2012 -0500 Fix build with C++11 util/options.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 0beb66e3a61ae8bb1fa66e54b1ff1abb2f8711e9 Author: Behdad Esfahbod Date: Wed Dec 5 18:46:04 2012 -0500 Fix warnings src/hb-fallback-shape.cc | 10 +++++----- src/hb-glib.cc | 2 +- src/hb-icu-le.cc | 6 +++--- src/hb-old.cc | 14 +++++++------- src/hb-open-type-private.hh | 4 +--- src/hb-ot-layout-gsubgpos-private.hh | 24 ++++++++++++------------ src/hb-ot-shape-complex-arabic-fallback.hh | 4 ++-- src/hb-ot-shape-complex-arabic.cc | 2 +- src/hb-ot-shape-complex-indic-machine.hh | 2 +- src/hb-ot-shape-complex-indic-machine.rl | 2 +- src/hb-ot-shape-complex-indic.cc | 6 +++--- src/hb-ot-shape-complex-thai.cc | 2 +- src/hb-ot-shape-fallback.cc | 4 ++-- src/hb-private.hh | 8 ++++---- src/hb-ucdn.cc | 27 +++++++++++++++------------ src/hb-utf-private.hh | 4 ++-- 16 files changed, 61 insertions(+), 60 deletions(-) commit c6408a1009d2370fbdcfa694898819d99d53c3df Author: Behdad Esfahbod Date: Wed Dec 5 17:36:52 2012 -0500 0.9.9 NEWS | 8 ++++++++ configure.ac | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) commit 130bb3f6144afe5c88bb5b4e4c98e7cba03b1e26 Author: Behdad Esfahbod Date: Wed Dec 5 16:49:47 2012 -0500 Rename VOID and void_t to have HarfBuzz prefix Fixes build on Windows. Ouch! src/hb-ot-layout-gsubgpos-private.hh | 22 +++++++++++----------- src/hb-private.hh | 12 ++++++------ 2 files changed, 17 insertions(+), 17 deletions(-) commit 4a350d0eb25db60d95638664c892d4c8dacf050b Author: Behdad Esfahbod Date: Tue Dec 4 17:13:09 2012 -0500 [OTLayout] Reuse context in collect_glyphs() recursion src/hb-ot-layout-gsubgpos-private.hh | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) commit 8303593ba1db06e402eab52df47f21f13049112d Author: Behdad Esfahbod Date: Tue Dec 4 17:08:41 2012 -0500 Minor Use pointers instead of references, in preparation for upcoming change. src/hb-ot-layout-gpos-table.hh | 28 +++++++++++++------------- src/hb-ot-layout-gsub-table.hh | 30 ++++++++++++++-------------- src/hb-ot-layout-gsubgpos-private.hh | 38 ++++++++++++++++++------------------ 3 files changed, 48 insertions(+), 48 deletions(-) commit 1bcfa06d1173f219809542a7380ce77f1c907bec Author: Behdad Esfahbod Date: Tue Dec 4 16:58:09 2012 -0500 [OTLayout] Don't recurse in collect_glyphs() for GPOS src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-layout-gsubgpos-private.hh | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) commit b5e04c7dc6b78e311d1a14f1f808fac76a64c889 Author: Behdad Esfahbod Date: Tue Dec 4 15:57:02 2012 -0500 [ucdn] Match upstream changes src/hb-ucdn/ucdn.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) commit a52f51b21635c626f6e5ccdba505c4df19bcff2c Author: Behdad Esfahbod Date: Tue Dec 4 15:43:38 2012 -0500 0.9.8 NEWS | 16 ++++++++++++++++ configure.ac | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) commit 7babfe5a7904c26060c5b8441ca1bf23e1444f35 Author: Behdad Esfahbod Date: Tue Dec 4 00:35:54 2012 +0200 Move object mutext into the user-data array We are not using it for anything lse it seems. src/hb-common.cc | 12 ++---------- src/hb-object-private.hh | 24 ++++++++++-------------- 2 files changed, 12 insertions(+), 24 deletions(-) commit a1900114770952778563dd6f3bc79334b0ca8df5 Author: Behdad Esfahbod Date: Tue Dec 4 00:29:35 2012 +0200 Remove unused functions src/hb-object-private.hh | 20 -------------------- 1 file changed, 20 deletions(-) commit 88b7564183ae1cf59500b13c7e48756fe200c7cd Author: Behdad Esfahbod Date: Sun Dec 2 19:14:29 2012 +0200 "Update" to Unicode 6.2.0 tables Nothing changed... src/hb-ot-shape-complex-arabic-table.hh | 4 ++-- src/hb-ot-shape-complex-indic-table.hh | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) commit 4ab99fb8c363cfc6a4f5952e69a19757f0cab344 Author: Behdad Esfahbod Date: Fri Nov 30 15:02:04 2012 +0200 Minor src/hb-ot-layout.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6748b96d27477b35dd69129e55d861259d66bf9f Author: Behdad Esfahbod Date: Fri Nov 30 12:02:21 2012 +0200 Minor src/hb-ot-layout.cc | 1 - 1 file changed, 1 deletion(-) commit 624933f67642997ee0a46d5acea285362e837142 Author: Behdad Esfahbod Date: Fri Nov 30 11:46:35 2012 +0200 Add Persian test cases from Mehran Mehr test/shaping/texts/in-tree/shaper-arabic/script-arabic/MANIFEST | 1 + .../in-tree/shaper-arabic/script-arabic/language-persian/MANIFEST | 1 + .../shaper-arabic/script-arabic/language-persian/mehran.txt | 8 ++++++++ 3 files changed, 10 insertions(+) commit 0f3f5299047e3cfc4d1202fee83d484b871279ad Author: Behdad Esfahbod Date: Fri Nov 30 09:06:59 2012 +0200 Add test-size-params Eventually this will become part of a yet-to-be-written hb-ot cmdline tool. src/Makefile.am | 10 ++++- src/test-size-params.cc | 98 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 107 insertions(+), 1 deletion(-) commit 8465a05a89742295d4b009a9b4442eb0a899fd80 Author: Behdad Esfahbod Date: Fri Nov 30 08:46:43 2012 +0200 Fix hb_buffer_guess_segment_properties() for empty buffer Was causing assertion failure in shape_plan(). src/hb-buffer.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit e75943de803f571b7ad2cf2f777119753a209656 Author: Behdad Esfahbod Date: Fri Nov 30 08:38:24 2012 +0200 [OTLayout] Fix collect_glyphs() recursion in ContextFormat3 src/hb-ot-layout-gsubgpos-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3038ae6adbb61e55d6c665dea0c5271e0c9f0ed8 Author: Behdad Esfahbod Date: Fri Nov 30 08:24:13 2012 +0200 [OTLayout] Minor src/hb-ot-layout-gpos-table.hh | 4 ---- src/hb-ot-layout-gsub-table.hh | 4 ---- src/hb-ot-layout.cc | 4 ++-- 3 files changed, 2 insertions(+), 10 deletions(-) commit 0dff11f6bfbda444a153ca75ff2b947f94e9b3c5 Author: Behdad Esfahbod Date: Fri Nov 30 08:14:20 2012 +0200 [OTLayout] Look for any 'size' feature, not only in DFLT script The old code doesn't work with all fonts, as Khaled has reported. src/hb-ot-layout.cc | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) commit e9ad71dee845407da74ccacfbb53ad7ededf07fd Author: Behdad Esfahbod Date: Fri Nov 30 08:10:26 2012 +0200 [OTLayout] Rename hb_ot_layout_position_get_size() to hb_ot_layout_get_size_params() src/hb-ot-layout.cc | 4 ++-- src/hb-ot-layout.h | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-) commit f18ff5a84d9fe859c40a7a0c9a207cb40df0e84a Author: Behdad Esfahbod Date: Fri Nov 30 08:07:06 2012 +0200 [OTLayout] Return correct value from recursion Commit 4c4e8f0e754b79ac6190d21878eaaf0b790c7579 broke contextual lookups by making the recurse() function always return false. Reported by Khaled. Test case: لا in Amiri. src/hb-ot-layout-gsubgpos-private.hh | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) commit f54cce3c6a0432268ce159dbe6c5c6b7f583b87a Author: Behdad Esfahbod Date: Mon Nov 26 14:02:31 2012 +0200 [OTLayout] Implement 'size' feature src/hb-ot-layout-common-private.hh | 36 ++++++++++++++++++++++++++++++++++-- src/hb-ot-layout.cc | 31 +++++++++++++++++++++++++++++++ src/hb-ot-layout.h | 5 +++++ 3 files changed, 70 insertions(+), 2 deletions(-) commit 2dc1141d7d0a9f5818862b09d6b9cfe0a27f1fc1 Author: Behdad Esfahbod Date: Sat Nov 24 19:16:34 2012 -0500 [OTLayout] Remove operator() from ClassDef src/hb-ot-layout-common-private.hh | 2 -- src/hb-ot-layout-gpos-table.hh | 4 ++-- src/hb-ot-layout-gsubgpos-private.hh | 8 ++++---- 3 files changed, 6 insertions(+), 8 deletions(-) commit b67881b171a7cf865af58df146da52fc1e27b160 Author: Behdad Esfahbod Date: Sat Nov 24 19:13:55 2012 -0500 [OTLayout] Remove operator() from Coverage src/hb-ot-layout-common-private.hh | 2 -- src/hb-ot-layout-gdef-table.hh | 4 ++-- src/hb-ot-layout-gpos-table.hh | 24 ++++++++++++------------ src/hb-ot-layout-gsub-table.hh | 24 ++++++++++++------------ src/hb-ot-layout-gsubgpos-private.hh | 16 ++++++++-------- 5 files changed, 34 insertions(+), 36 deletions(-) commit a88e7160217b9f44e4e5b4b814d0ca98c457ee40 Author: Behdad Esfahbod Date: Sat Nov 24 02:31:02 2012 -0500 [OTLayout] Implement hb_ot_layout_collect_lookups() Untested. src/hb-ot-layout.cc | 97 +++++++++++++++++++++++++++++++++++++++++++++++++++++ src/hb-ot-layout.h | 4 +-- 2 files changed, 98 insertions(+), 3 deletions(-) commit 1ea375da446bf68f705a70ce4a480db9fb9d13f3 Author: Behdad Esfahbod Date: Sat Nov 24 02:05:52 2012 -0500 [OTLayout] Only collect output glyphs during recursion in collect_glyphs() src/hb-ot-layout-gsubgpos-private.hh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit f1b12781d279a73b5754afee31e930b5cd87aac6 Author: Behdad Esfahbod Date: Sat Nov 24 01:55:34 2012 -0500 [OTLayout] Implement ChainContext collect_glyphs() All of collect_glyphs() complete and untested now. src/hb-ot-layout-gsubgpos-private.hh | 103 ++++++++++++++++++++++++++++++++--- 1 file changed, 96 insertions(+), 7 deletions(-) commit cdd756b9f40665a201f5c4e65a87b9a27c390601 Author: Behdad Esfahbod Date: Sat Nov 24 01:38:41 2012 -0500 [OTLayout] Implement GPOS collect_glyphs() src/hb-ot-layout-gpos-table.hh | 95 +++++++++++++++++++++++++++++++++++++++++- src/hb-ot-layout.cc | 9 ++-- 2 files changed, 99 insertions(+), 5 deletions(-) commit 4c4e8f0e754b79ac6190d21878eaaf0b790c7579 Author: Behdad Esfahbod Date: Sat Nov 24 01:13:20 2012 -0500 [OTLayout] Reuse apply context for recursion src/hb-ot-layout-gpos-table.hh | 7 ++++++- src/hb-ot-layout-gsub-table.hh | 7 ++++++- src/hb-ot-layout-gsubgpos-private.hh | 8 ++++---- 3 files changed, 16 insertions(+), 6 deletions(-) commit 53a69f49e58ef4c4226958e0496fc22455ee6c87 Author: Behdad Esfahbod Date: Sat Nov 24 01:03:05 2012 -0500 [OTLayout] Remove unused members src/hb-ot-layout-gsubgpos-private.hh | 3 --- 1 file changed, 3 deletions(-) commit d0a5233785eb327c4080432f597fe470a1046af3 Author: Behdad Esfahbod Date: Fri Nov 23 18:54:59 2012 -0500 [OTLayout] Implement Context::collect_glyphs() src/hb-ot-layout-gsubgpos-private.hh | 122 +++++++++++++++++++++++++++++++---- 1 file changed, 111 insertions(+), 11 deletions(-) commit 26514d51b6669f092d9ccb7523443a5ece74169a Author: Behdad Esfahbod Date: Fri Nov 23 18:13:48 2012 -0500 [OTLayout] More collect_glyphs() src/hb-ot-layout-gpos-table.hh | 6 ++--- src/hb-ot-layout-gsub-table.hh | 32 +++++++++++++++------- src/hb-ot-layout-gsubgpos-private.hh | 51 ++++++++++++++++++++++++++++++++---- 3 files changed, 71 insertions(+), 18 deletions(-) commit c6fb843f2a1c26322c6f4c85d1589f01a9e7a2ef Author: Behdad Esfahbod Date: Fri Nov 23 18:04:08 2012 -0500 [OTLayout] Templatize process_recurse_func src/hb-ot-layout-gpos-table.hh | 10 ++++++++++ src/hb-ot-layout-gsub-table.hh | 8 +++++--- 2 files changed, 15 insertions(+), 3 deletions(-) commit 9b34677f362fb0ef5a7cb8a284a9e06d1a4cc03b Author: Behdad Esfahbod Date: Fri Nov 23 17:55:40 2012 -0500 [OTLayout] Clean up closure() a bit src/hb-ot-layout-gsub-table.hh | 29 ++++++++++++++--------------- src/hb-ot-layout-gsubgpos-private.hh | 7 ++++--- src/hb-ot-layout.cc | 6 +++++- 3 files changed, 23 insertions(+), 19 deletions(-) commit adf7758a27a11fb1a8a14a2673867589437d22a3 Author: Behdad Esfahbod Date: Fri Nov 23 17:32:00 2012 -0500 Improve debug log format in presence of templates src/hb-private.hh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 2c53bd3c3ec4f81eff126c5bf84b7f2ddf2f0fef Author: Behdad Esfahbod Date: Fri Nov 23 17:29:05 2012 -0500 [OTLayout] Start porting sanitize() to process() src/hb-open-type-private.hh | 12 +++++++++++- src/hb-ot-layout-gsubgpos-private.hh | 8 ++++---- 2 files changed, 15 insertions(+), 5 deletions(-) commit f48ec0e83432c038b50d9715a38ba1469e82e1e4 Author: Behdad Esfahbod Date: Fri Nov 23 17:23:41 2012 -0500 [OTLayout] Add process() tracing src/hb-ot-layout-gpos-table.hh | 60 ++++++++++++++++++++---------------- src/hb-ot-layout-gsub-table.hh | 51 +++++++++++++++++------------- src/hb-ot-layout-gsubgpos-private.hh | 17 +++++----- 3 files changed, 72 insertions(+), 56 deletions(-) commit ed2e13594479c6ed7909401509962ea2f03f9a6e Author: Behdad Esfahbod Date: Fri Nov 23 17:10:40 2012 -0500 [OTLayout] More Extension templatizing src/hb-ot-layout-gpos-table.hh | 11 ----------- src/hb-ot-layout-gsub-table.hh | 11 ----------- src/hb-ot-layout-gsubgpos-private.hh | 12 ++++++++++-- 3 files changed, 10 insertions(+), 24 deletions(-) commit 7dddd4e72bc35be962d93dc1b76c7e26c63aaa6d Author: Behdad Esfahbod Date: Fri Nov 23 17:04:55 2012 -0500 [OTLayout] More templatizing Extension src/hb-ot-layout-gpos-table.hh | 7 +------ src/hb-ot-layout-gsub-table.hh | 9 ++------- src/hb-ot-layout-gsubgpos-private.hh | 10 +++++++++- 3 files changed, 12 insertions(+), 14 deletions(-) commit 653eeb26450053b731b46346606931f5ae88db72 Author: Behdad Esfahbod Date: Fri Nov 23 16:57:36 2012 -0500 Make Extension a template src/hb-ot-layout-gpos-table.hh | 11 +---------- src/hb-ot-layout-gsub-table.hh | 11 +---------- src/hb-ot-layout-gsubgpos-private.hh | 7 +++++++ 3 files changed, 9 insertions(+), 20 deletions(-) commit 08f1eede1bbc01ece2adf89847614a0670e50443 Author: Behdad Esfahbod Date: Fri Nov 23 16:51:43 2012 -0500 Minor src/hb-ot-layout-gpos-table.hh | 19 ++----------------- src/hb-ot-layout-gsub-table.hh | 19 ++----------------- 2 files changed, 4 insertions(+), 34 deletions(-) commit 2c9d6485a1f89c11f84e720d3c7978dc11a5039a Author: Behdad Esfahbod Date: Fri Nov 23 16:49:19 2012 -0500 More tracing fixup src/hb-private.hh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit a1733db1c6ff40aae71fa142a12b1fea7b53dd37 Author: Behdad Esfahbod Date: Fri Nov 23 16:40:04 2012 -0500 [OTLayout] Start adding process() tracing src/hb-ot-layout-gsubgpos-private.hh | 44 +++++++++++++++++++++++++++--------- src/hb-private.hh | 6 +++-- 2 files changed, 37 insertions(+), 13 deletions(-) commit 73c18ae1b982a4e65086afe5177afa79e721e2c0 Author: Behdad Esfahbod Date: Fri Nov 23 15:34:11 2012 -0500 Cleanup src/hb-ot-layout-gsubgpos-private.hh | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) commit be218c688cbb037a99c8c64bb835f3c980040c0b Author: Behdad Esfahbod Date: Fri Nov 23 15:32:14 2012 -0500 Pass this object to trace macros src/hb-open-file-private.hh | 10 +-- src/hb-open-type-private.hh | 34 +++++----- src/hb-ot-head-table.hh | 2 +- src/hb-ot-hhea-table.hh | 2 +- src/hb-ot-hmtx-table.hh | 2 +- src/hb-ot-layout-common-private.hh | 36 +++++------ src/hb-ot-layout-gdef-table.hh | 20 +++--- src/hb-ot-layout-gpos-table.hh | 80 +++++++++++------------ src/hb-ot-layout-gsub-table.hh | 122 +++++++++++++++++------------------ src/hb-ot-layout-gsubgpos-private.hh | 100 ++++++++++++++-------------- src/hb-ot-maxp-table.hh | 2 +- src/hb-ot-name-table.hh | 6 +- 12 files changed, 208 insertions(+), 208 deletions(-) commit 902cc8aca0b3ff25eeee50b3a84d729e31731ef3 Author: Behdad Esfahbod Date: Fri Nov 23 15:06:59 2012 -0500 [OTLayout] Start unbreaking tracing src/hb-open-type-private.hh | 37 +++++++++++++++++++++--------------- src/hb-ot-layout-gsubgpos-private.hh | 37 +++++++++++++++++++++++++----------- src/hb-private.hh | 30 +++++++++++++++++++---------- 3 files changed, 68 insertions(+), 36 deletions(-) commit dabe698fcbeb02911128b17aa8e3b2d864795960 Author: Behdad Esfahbod Date: Fri Nov 23 14:21:35 2012 -0500 Minor src/hb-open-type-private.hh | 5 ----- src/hb-ot-layout-gsubgpos-private.hh | 10 ++++------ src/hb-private.hh | 27 +++++++++++++++++++++++++-- 3 files changed, 29 insertions(+), 13 deletions(-) commit c779d82b2fc801eec0d349a106c0e860448fcf4e Author: Behdad Esfahbod Date: Fri Nov 23 14:07:24 2012 -0500 Fix warnings src/hb-ot-layout-gpos-table.hh | 2 -- src/hb-ot-layout-gsub-table.hh | 8 +++----- src/hb-ot-layout-gsubgpos-private.hh | 2 +- src/hb-private.hh | 2 +- 4 files changed, 5 insertions(+), 9 deletions(-) commit 81822528efc63d867cb2343a8ff7af64fac1c70d Author: Behdad Esfahbod Date: Fri Nov 23 13:27:16 2012 -0500 Minor src/hb-open-type-private.hh | 6 ++++++ src/hb-ot-layout-gsubgpos-private.hh | 3 --- 2 files changed, 6 insertions(+), 3 deletions(-) commit 1d67ef980f35ae30d4f8975f65ee07b8cc5deeea Author: Behdad Esfahbod Date: Thu Nov 22 16:47:53 2012 -0500 Move code around src/hb-ot-layout-gsubgpos-private.hh | 44 ++++++++++++++++++------------------ 1 file changed, 22 insertions(+), 22 deletions(-) commit ec35a72a44301934b8f123ab2833f59d8c875a09 Author: Behdad Esfahbod Date: Thu Nov 22 16:05:59 2012 -0500 [OTLayout] Port apply() operator to process() template src/hb-ot-layout-gpos-table.hh | 117 ++++------------------------------- src/hb-ot-layout-gsub-table.hh | 108 +++----------------------------- src/hb-ot-layout-gsubgpos-private.hh | 99 +++++++++++++---------------- src/hb-ot-layout.cc | 2 +- 4 files changed, 65 insertions(+), 261 deletions(-) commit 2005fa5340fc528c32dc2af945ad2431964a47d2 Author: Behdad Esfahbod Date: Thu Nov 22 14:38:10 2012 -0500 [OTLayout] Port would_apply() and get_coverage() to process() templates src/hb-ot-layout-gpos-table.hh | 175 +++++++++++-------------------- src/hb-ot-layout-gsub-table.hh | 198 ++++++++++++----------------------- src/hb-ot-layout-gsubgpos-private.hh | 76 +++++--------- 3 files changed, 156 insertions(+), 293 deletions(-) commit 44fc237b53ebfbaf8a539de16ad735d2c6afc52b Author: Behdad Esfahbod Date: Wed Nov 21 23:33:13 2012 -0500 [OTLayout] Port closure() to process() template src/hb-ot-layout-gsub-table.hh | 297 ++++++++--------------------------- src/hb-ot-layout-gsubgpos-private.hh | 209 ++++++++++++------------ src/hb-ot-layout.cc | 10 +- 3 files changed, 171 insertions(+), 345 deletions(-) commit 5be86b1bb4fbb37b50a1e2798df0c9a3a528b6b2 Author: Behdad Esfahbod Date: Thu Nov 22 16:26:22 2012 -0500 [ucdn] Make data tables const! src/hb-ucdn/ucdn.c | 16 ++++++++-------- src/hb-ucdn/unicodedata_db.h | 28 ++++++++++++++-------------- 2 files changed, 22 insertions(+), 22 deletions(-) commit 7c5b7fe686c9163afe2f31fbeac6f8c8512f5516 Author: Behdad Esfahbod Date: Thu Nov 22 14:15:08 2012 -0500 Fix hb_shape_plan_get_shaper() src/hb-shape-plan.cc | 1 + 1 file changed, 1 insertion(+) commit 4c8963576573483269b327c6465f6ec99f489e05 Author: Behdad Esfahbod Date: Wed Nov 21 01:20:56 2012 -0500 0.9.7 NEWS | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 87 insertions(+), 1 deletion(-) commit ac064a2db2b7a010d99527e183145286215aea81 Author: Behdad Esfahbod Date: Wed Nov 21 01:14:19 2012 -0500 Rename hb_set_population() to hb_set_get_population() src/hb-set.cc | 2 +- src/hb-set.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 16c914c2a6efeb6999054333985b1f711e33cf94 Author: Behdad Esfahbod Date: Wed Nov 21 01:04:15 2012 -0500 [Indic] One more try at unbreaking Khmer fonts See comments and discussion on the list. src/hb-ot-shape-complex-private.hh | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) commit e8cfdd7fa8d0fb66e0a261f3547e5824897e5131 Author: Behdad Esfahbod Date: Fri Nov 16 19:07:06 2012 -0800 Start implementing collect_glyphs() operation Not functional yet. src/hb-ot-layout-gsub-table.hh | 185 +++++++++++++++++++++++++++++++++++ src/hb-ot-layout-gsubgpos-private.hh | 57 +++++++++++ src/hb-ot-layout.cc | 29 ++++++ src/hb-ot-layout.h | 4 +- 4 files changed, 272 insertions(+), 3 deletions(-) commit 7d52e6601f0e695690cd168a288466746cf25300 Author: Behdad Esfahbod Date: Fri Nov 16 18:49:54 2012 -0800 Whitespace src/hb-coretext.cc | 32 +++++----- src/hb-icu-le.cc | 2 +- src/hb-old.cc | 10 ++-- src/hb-open-file-private.hh | 2 +- src/hb-open-type-private.hh | 2 +- src/hb-ot-head-table.hh | 2 +- src/hb-ot-hhea-table.hh | 2 +- src/hb-ot-hmtx-table.hh | 2 +- src/hb-ot-layout-common-private.hh | 2 +- src/hb-ot-layout-gdef-table.hh | 2 +- src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-layout-gsub-table.hh | 2 +- src/hb-ot-layout-gsubgpos-private.hh | 2 +- src/hb-ot-maxp-table.hh | 2 +- src/hb-ot-name-table.hh | 2 +- src/hb-ot-shape-complex-default.cc | 109 ++++++++++++++++++----------------- src/hb-tt-font.cc | 2 +- 17 files changed, 87 insertions(+), 92 deletions(-) commit 51bb498b7b07bff4a447405b72f09b68d07a3e95 Author: Behdad Esfahbod Date: Fri Nov 16 14:08:05 2012 -0800 Minor src/hb-ot-shape.cc | 1 + 1 file changed, 1 insertion(+) commit 89ca8eeb83fedde06727d386369a0a39d410f12b Author: Behdad Esfahbod Date: Fri Nov 16 13:53:40 2012 -0800 Implement hb_ot_layout_get_glyphs_in_class() src/hb-ot-layout-common-private.hh | 24 ++++++++++++++++++++++++ src/hb-ot-layout-gdef-table.hh | 2 ++ src/hb-ot-layout.cc | 8 ++++++++ src/hb-ot-layout.h | 5 ++--- 4 files changed, 36 insertions(+), 3 deletions(-) commit 5a08ecf9200a6ac9b4ebb7ec5c13dcb42d8820ce Author: Behdad Esfahbod Date: Fri Nov 16 13:34:29 2012 -0800 Implement hb_ot_layout_get_glyph_class() src/hb-ot-layout-gdef-table.hh | 10 +++++----- src/hb-ot-layout-gpos-table.hh | 8 ++++---- src/hb-ot-layout-gsub-table.hh | 2 +- src/hb-ot-layout-gsubgpos-private.hh | 10 +++++----- src/hb-ot-layout-private.hh | 10 +++++++++- src/hb-ot-layout.cc | 6 ++++++ src/hb-ot-layout.h | 14 ++++++-------- src/hb-ot-shape.cc | 4 ++-- 8 files changed, 38 insertions(+), 26 deletions(-) commit f9edd5d56bd219625f5b16b23eac53b4c4a8b194 Author: Behdad Esfahbod Date: Fri Nov 16 13:23:37 2012 -0800 Implement hb_shape_plan_get_shaper() Untested. src/hb-shape-plan-private.hh | 1 + src/hb-shape-plan.cc | 7 +++++++ src/hb-shape-plan.h | 4 +--- 3 files changed, 9 insertions(+), 3 deletions(-) commit 43b653150081a2f9dc6b7481229ac4cd952575dc Author: Behdad Esfahbod Date: Fri Nov 16 13:12:35 2012 -0800 [Indic] Another try to unbreak Sinhala split matras Just read the comments... src/hb-ot-shape-complex-indic.cc | 43 ++++++++++++++++++---- .../indic/script-sinhala/misc/MANIFEST | 1 + .../indic/script-sinhala/misc/split-matras.txt | 4 ++ 3 files changed, 40 insertions(+), 8 deletions(-) commit 977f1740ace730dcdff8221a17f2a592c2ec7c74 Author: Behdad Esfahbod Date: Fri Nov 16 13:10:07 2012 -0800 Unbreak tests src/hb-ot-layout.h | 14 +++++++------- src/hb-shape-plan.h | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) commit eba312c8d1b2bbe8cb9b6414e843e78d2c521aa4 Author: Behdad Esfahbod Date: Fri Nov 16 12:39:23 2012 -0800 Plumbing to get shape plan and font into complex decompose function So we can handle Sinhala split matras smartly... Coming soon. src/hb-ot-shape-complex-default.cc | 6 ++-- src/hb-ot-shape-complex-indic.cc | 14 ++++----- src/hb-ot-shape-complex-private.hh | 16 +++++------ src/hb-ot-shape-normalize-private.hh | 22 ++++++++++++-- src/hb-ot-shape-normalize.cc | 56 ++++++++++++++---------------------- src/hb-ot-shape.cc | 2 +- 6 files changed, 61 insertions(+), 55 deletions(-) commit 3f82f8ff07a9d16a7c047129658c1bbedfdb5436 Author: Behdad Esfahbod Date: Thu Nov 15 18:45:31 2012 -0800 Rename hb_buffer_guess_properties() to hb_buffer_guess_segment_properties() src/hb-buffer-private.hh | 2 +- src/hb-buffer.cc | 6 +++--- src/hb-buffer.h | 2 +- src/hb-fallback-shape.cc | 2 +- src/hb-ot-shape.cc | 2 +- src/hb-shape.cc | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) commit f30641038ba96e83950729b1bd9d86d2e98e46c5 Author: Behdad Esfahbod Date: Thu Nov 15 18:39:46 2012 -0800 Bunch of independent changes (ouch) API additions: hb_segment_properties_t HB_SEGMENT_PROPERTIES_DEFAULT hb_segment_properties_equal() hb_segment_properties_hash() hb_buffer_set_segment_properties() hb_buffer_get_segment_properties() hb_ot_layout_glyph_class_t hb_shape_plan_t hb_shape_plan_create() hb_shape_plan_create_cached() hb_shape_plan_get_empty() hb_shape_plan_reference() hb_shape_plan_destroy() hb_shape_plan_set_user_data() hb_shape_plan_get_user_data() hb_shape_plan_execute() hb_ot_shape_plan_collect_lookups() API changes: Rename hb_ot_layout_feature_get_lookup_indexes() to hb_ot_layout_feature_get_lookups(). New header file: hb-shape-plan.h And a bunch of prototyped but not implemented stuff. Coming soon. (Tests fail because of the prototypes right now.) src/Makefile.am | 2 +- src/hb-buffer-private.hh | 37 --------------- src/hb-buffer.cc | 45 +++++++++++++++++- src/hb-buffer.h | 47 +++++++++++++++++-- src/hb-ot-layout-private.hh | 8 ---- src/hb-ot-layout.cc | 12 ++--- src/hb-ot-layout.h | 108 ++++++++++++++++++++++++++++++++++++++++--- src/hb-ot-map-private.hh | 2 +- src/hb-ot-map.cc | 15 +++--- src/hb-ot-shape-private.hh | 11 ++++- src/hb-ot-shape.cc | 52 ++++++++++++++------- src/hb-ot.h | 1 + src/hb-shape-plan-private.hh | 3 +- src/hb-shape-plan.cc | 23 +++++++-- src/hb-shape-plan.h | 50 +++++++++++++------- src/hb-shaper-private.hh | 2 - src/hb-shaper.cc | 2 +- src/hb.h | 1 + 18 files changed, 304 insertions(+), 117 deletions(-) commit 75da37dcb17aacc0be6bb006683a84aa31155938 Author: Behdad Esfahbod Date: Thu Nov 15 18:39:23 2012 -0800 Minor util/hb-ot-shape-closure.cc | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) commit e05a999495e6575f7cebd7f35db087d964f11ef6 Author: Behdad Esfahbod Date: Thu Nov 15 16:23:21 2012 -0800 Add hb_face_[sg]et_glyph_count() src/hb-font-private.hh | 9 +++++++++ src/hb-font.cc | 29 ++++++++++++++++++++++++++++- src/hb-font.h | 7 +++++++ 3 files changed, 44 insertions(+), 1 deletion(-) commit aec89de5641fbe1c3031d63dd5f40ec99bf2a538 Author: Behdad Esfahbod Date: Thu Nov 15 16:15:42 2012 -0800 Add / modify set API a bit src/hb-ot-shape.cc | 2 +- src/hb-set-private.hh | 35 ++++++++++++++++-- src/hb-set.cc | 86 ++++++++++++++++++++++++++++++--------------- src/hb-set.h | 55 +++++++++++++++++++---------- util/hb-ot-shape-closure.cc | 2 +- 5 files changed, 128 insertions(+), 52 deletions(-) commit c54599ad269380c7aa28d885fcfd660fc2c10a7b Author: Behdad Esfahbod Date: Thu Nov 15 16:14:23 2012 -0800 Minor src/hb-buffer.cc | 2 +- src/hb-buffer.h | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) commit d1aa143ca434fe272de21d2002768c83387b583b Author: Behdad Esfahbod Date: Thu Nov 15 15:38:08 2012 -0800 [Thai] Remove U+0E2C from "AC" consonants WinXP doesn't include it. src/hb-ot-shape-complex-thai.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 362a990b2246f5448ecb9d600761f710aea7d42d Author: Behdad Esfahbod Date: Thu Nov 15 14:57:31 2012 -0800 Rename hb_ot_layout_would_substitute_lookup() and hb_ot_layout_substitute_closure_lookup() To match upcoming API. src/hb-ot-layout-private.hh | 2 +- src/hb-ot-layout.cc | 8 ++++---- src/hb-ot-layout.h | 4 ++-- src/hb-ot-map.cc | 2 +- src/hb-ot-shape-complex-indic.cc | 2 +- src/test-would-substitute.cc | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) commit a4bef84e375b090c1bc7e4221b8e0ee435dfcbba Author: Behdad Esfahbod Date: Thu Nov 15 13:29:51 2012 -0800 [util] Make hb-shape err if output-format is not understood And list supported formats. util/hb-shape.cc | 6 ++++++ 1 file changed, 6 insertions(+) commit 3cec819d39e45470d03085bb6fa132882cc85943 Author: Behdad Esfahbod Date: Thu Nov 15 13:15:39 2012 -0800 Make the OT shaper default, even if CoreText or Uniscribe is enabled src/hb-shaper-list.hh | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) commit 072ae7a982bf640804eee0b41525e7c328806bf5 Author: Behdad Esfahbod Date: Thu Nov 15 13:14:12 2012 -0800 Add hb_buffer_serialize_list_formats() src/hb-buffer.cc | 6 ++++++ src/hb-buffer.h | 3 +++ 2 files changed, 9 insertions(+) commit f9edf1672511c3bcc3796cc79578ffea43b2bda1 Author: Behdad Esfahbod Date: Thu Nov 15 12:14:09 2012 -0800 Add buffer serialization / deserialization API Two output formats for now: TEXT, and JSON. For example: hb-shape --output-format=json Deserialization API is added, but not implemented yet. src/hb-buffer.cc | 222 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/hb-buffer.h | 42 +++++++++++ util/hb-shape.cc | 21 +++++- util/options.cc | 57 +++++--------- util/options.hh | 7 +- 5 files changed, 304 insertions(+), 45 deletions(-) commit fd0de881f4fc004da6f36d50a91d0e62f8eb4d8c Author: Behdad Esfahbod Date: Thu Nov 15 10:47:14 2012 -0800 Avoid C++ undefined behavior https://bugzilla.mozilla.org/show_bug.cgi?id=810823 src/hb-open-type-private.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit f41dc2d35b23220d59d38990bb66f1cbd66a55b3 Author: Behdad Esfahbod Date: Thu Nov 15 10:36:43 2012 -0800 Fix undefined behavior in Indic dottedcircle Chromium Issue 158998: Conditional jump in harfbuzz-ng http://code.google.com/p/chromium/issues/detail?id=158998 src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1eb3e94fe99a072ce422e60ac4d4d89ef489b08a Author: Behdad Esfahbod Date: Wed Nov 14 17:25:03 2012 -0800 [Thai] Implement PUA-based fallback shaping As explained here: http://linux.thai.net/~thep/th-otf/shaping.html Our output now matches Uniscribe for old fonts (eg. XP Tahoma) with no Thai GSUB table. src/hb-ot-shape-complex-thai.cc | 217 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 217 insertions(+) commit 851784f8372004e0a40b698c0cdc2d7db8629aa2 Author: Behdad Esfahbod Date: Wed Nov 14 16:24:05 2012 -0800 Improve shaper selection src/hb-ot-map-private.hh | 8 ++++---- src/hb-ot-map.cc | 6 ++++-- src/hb-ot-shape-complex-indic.cc | 2 +- src/hb-ot-shape-complex-private.hh | 13 ++++++++----- src/hb-ot-shape-complex-thai.cc | 24 ++++++++++++++++++++++-- 5 files changed, 39 insertions(+), 14 deletions(-) commit f3584d3a3a627e38dfd7769975a670db340d2a48 Author: Behdad Esfahbod Date: Wed Nov 14 15:55:17 2012 -0800 Add test cases for Thai PUA shaping .../texts/in-tree/shaper-thai/script-thai/misc/MANIFEST | 1 + .../in-tree/shaper-thai/script-thai/misc/pua-shaping.txt | 11 +++++++++++ 2 files changed, 12 insertions(+) commit 43f04a7456419153cb03e610a825056a47824780 Author: Behdad Esfahbod Date: Wed Nov 14 15:51:54 2012 -0800 Move Thai shaper into a separate file src/Makefile.am | 3 +- ...plex-misc.cc => hb-ot-shape-complex-default.cc} | 114 ----------------- src/hb-ot-shape-complex-thai.cc | 141 +++++++++++++++++++++ 3 files changed, 143 insertions(+), 115 deletions(-) commit ba82325b7a6311b787ae47f41a56964e2f2cba9f Author: Behdad Esfahbod Date: Wed Nov 14 15:36:53 2012 -0800 Add note re 'Phags-pa letter U+A872, which is Joining_Type=L src/hb-ot-shape-complex-arabic.cc | 1 + 1 file changed, 1 insertion(+) commit d469fadce8290c7dda559c5927dd19df65f91c1a Author: Behdad Esfahbod Date: Wed Nov 14 15:07:36 2012 -0800 [Indic] Exchange abort() for assert() src/hb-ot-shape-complex-indic.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) commit 0f80a89de99293ddbf0b8b815fe360677d057e38 Author: Behdad Esfahbod Date: Wed Nov 14 15:05:19 2012 -0800 Don't route Kharoshthi through the Indic shaper It's a simple, right-to-left, script. src/hb-ot-shape-complex-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e67072bb179a5c17db04075de74215597fb43c82 Author: Behdad Esfahbod Date: Wed Nov 14 15:00:53 2012 -0800 [Indic] Handle overstruck matra position src/hb-ot-shape-complex-indic-private.hh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 7e99e4f0740e47efda5882604954cb7d12700a4b Author: Behdad Esfahbod Date: Wed Nov 14 14:09:46 2012 -0800 Reposition Lao marks Lao marks are center-aligned, unlike Thai ones. src/hb-ot-shape-fallback.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 865745b5b87236651f5663cae3461db9cb505eed Author: Behdad Esfahbod Date: Wed Nov 14 13:48:26 2012 -0800 Don't do fallback positioning for Indic and Thai shapers src/hb-ot-shape-complex-arabic.cc | 1 + src/hb-ot-shape-complex-indic.cc | 1 + src/hb-ot-shape-complex-misc.cc | 2 ++ src/hb-ot-shape-complex-private.hh | 1 + src/hb-ot-shape.cc | 20 +++++--------------- 5 files changed, 10 insertions(+), 15 deletions(-) commit 981748cb2e9b48b77177b19ec1f972cab7afda89 Author: Behdad Esfahbod Date: Wed Nov 14 13:38:16 2012 -0800 [Indic] If Khmer fonts have a 'liga' feature, use generic shaper Seems to produce more coherent results than trying the Indic shaper on them. I'm looking at you, Kh-* fonts... src/hb-ot-shape-complex-private.hh | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) commit 6b19fa48621dbf36d471d5005f6ae20df350954f Author: Behdad Esfahbod Date: Wed Nov 14 11:38:50 2012 -0800 Adjust diff rule for the new hb-shape output format test/shaping/hb_test_tools.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dde5506fd963e3cec27c3389bb1fc092f86d1e06 Author: Behdad Esfahbod Date: Wed Nov 14 11:37:04 2012 -0800 [Indic] Don't move virama with left matra This is important for the Sinhala U+0DDA split matra since it decomposes to U+0DD9,U+0DCA where U+0DD9 is a left matra and U+0DCA is the virama. We don't want to move the virama with the left matra. TEST: U+0D9A,U+0DDA Note that we were already doing this in the Uniscribe bug compatibility mode. We now do it all the time. src/hb-ot-shape-complex-indic.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit 82c4d9880a2cd321f6426888511c5f0318f96ad5 Author: Behdad Esfahbod Date: Wed Nov 14 10:56:02 2012 -0800 Add Sinhala test case for split matra U+0DDA .../texts/in-tree/shaper-indic/indic/script-sinhala/misc/misc.txt | 1 + 1 file changed, 1 insertion(+) commit d04b12853167d756a8cccaf4154f0fd894bce6de Author: Behdad Esfahbod Date: Wed Nov 14 10:53:10 2012 -0800 Fix test test/api/test-buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 92f9bfed42f720c1fd78e795845542661aaf4f8a Author: Behdad Esfahbod Date: Tue Nov 13 16:50:45 2012 -0800 Minor src/hb-buffer.h | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) commit 66ac2ff32e24f0d5658ca172147613081a133847 Author: Behdad Esfahbod Date: Tue Nov 13 16:26:32 2012 -0800 API change: Remove "mask" from hb_buffer_add() I don't expect anybody using hb_buffer_add(), so this shouldn't break anyone's code. src/hb-buffer-private.hh | 1 - src/hb-buffer.cc | 8 +++----- src/hb-buffer.h | 1 - 3 files changed, 3 insertions(+), 7 deletions(-) commit 407f80d62589774f845ef1a6a0a7d841b09d57c6 Author: Behdad Esfahbod Date: Tue Nov 13 15:33:27 2012 -0800 [util] Add --bot / --eot / --preserve-default-ignorables util/options.cc | 3 +++ util/options.hh | 12 ++++++++++++ 2 files changed, 15 insertions(+) commit 78d41d8d69142ae95928b51215c0c0c5e3f5b3f0 Author: Behdad Esfahbod Date: Tue Nov 13 15:15:09 2012 -0800 Minor util/options.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 321f73c16efa0730c96e001d65268f4927a0f735 Author: Behdad Esfahbod Date: Tue Nov 13 15:12:24 2012 -0800 [util] Add --text-before and --text-after to hb-shape / hb-view Use with Arabic, for example, to see the effect on joining. util/hb-ot-shape-closure.cc | 4 +++- util/main-font-text.hh | 2 +- util/options.cc | 2 ++ util/options.hh | 18 ++++++++++++++++-- util/shape-consumer.hh | 6 ++++-- 5 files changed, 26 insertions(+), 6 deletions(-) commit e13f8d280bafc6a6b6e31e2eee587660b8333c56 Author: Behdad Esfahbod Date: Tue Nov 13 15:12:06 2012 -0800 Fix UTF-8 backward iteration Ouch! src/hb-utf-private.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 5669a6cf418f3a8b9281c36e9d662d843be80433 Author: Behdad Esfahbod Date: Tue Nov 13 15:11:51 2012 -0800 [Arabic] Fix post-context handling Ouch! src/hb-ot-shape-complex-arabic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0c7df2222862122ebbdc8665a21d6771ef5e0252 Author: Behdad Esfahbod Date: Tue Nov 13 14:42:35 2012 -0800 Add buffer flags New API: hb_buffer_flags_t HB_BUFFER_FLAGS_DEFAULT HB_BUFFER_FLAG_BOT HB_BUFFER_FLAG_EOT HB_BUFFER_FLAG_PRESERVE_DEFAULT_IGNORABLES hb_buffer_set_flags() hb_buffer_get_flags() We use the BOT flag to decide whether to insert dottedcircle if the first char in the buffer is a combining mark. The PRESERVE_DEFAULT_IGNORABLES flag prevents removal of characters like ZWNJ/ZWJ/... src/hb-buffer-private.hh | 1 + src/hb-buffer.cc | 18 ++++++++++++++++++ src/hb-buffer.h | 13 +++++++++++++ src/hb-ot-shape-complex-arabic.cc | 40 ++++++++++++++++++++------------------- src/hb-ot-shape.cc | 9 ++++++--- test/api/test-buffer.c | 9 +++++++++ 6 files changed, 68 insertions(+), 22 deletions(-) commit 1c7e55511a870f2689680ca8f977e00879f3b3e3 Author: Behdad Esfahbod Date: Tue Nov 13 14:42:22 2012 -0800 Minor fix Ouch src/hb-shape.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c8d4f8b0fe56ce909e3ca07f8a30cb4fb940868b Author: Behdad Esfahbod Date: Tue Nov 13 14:10:19 2012 -0800 Minor test/api/test-object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 82ecaff736e245e117d70b6ec1497508c6eb08d2 Author: Behdad Esfahbod Date: Tue Nov 13 13:57:52 2012 -0800 Add hb_buffer_clear() Which is like _reset(), but does NOT clear unicode-funcs. src/hb-buffer-private.hh | 1 + src/hb-buffer.cc | 15 +++++++++++++++ src/hb-buffer.h | 4 ++++ test/api/test-buffer.c | 22 +++++++++++++++++++++- 4 files changed, 41 insertions(+), 1 deletion(-) commit da43a92b04929e93356ae393803ef101154d2267 Author: Behdad Esfahbod Date: Tue Nov 13 13:48:26 2012 -0800 0.9.6 NEWS | 28 ++++++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 29 insertions(+), 1 deletion(-) commit 0736915b8ed789a209205fec762997af3a8af89c Author: Behdad Esfahbod Date: Tue Nov 13 12:35:35 2012 -0800 [Indic] Decompose Sinhala split matras the way old HarfBuzz / Pango did Had to do some refactoring to make this happen... Under uniscribe bug compatibility mode, we still plit them Uniscrie-style, but Jonathan and I convinced ourselves that there is no harm doing this the Unicode way. This change makes that happen, and unbreaks free Sinhala fonts. src/hb-ot-shape-complex-arabic.cc | 2 + src/hb-ot-shape-complex-indic.cc | 74 +++++++++- src/hb-ot-shape-complex-misc.cc | 133 ++++++++++++++++- src/hb-ot-shape-complex-private.hh | 28 +++- src/hb-ot-shape-normalize-private.hh | 6 +- src/hb-ot-shape-normalize.cc | 278 ++++++++++------------------------- src/hb-ot-shape.cc | 5 +- 7 files changed, 312 insertions(+), 214 deletions(-) commit c8149ca85ed97112778590bc9f090f3ee0254100 Author: Behdad Esfahbod Date: Tue Nov 13 11:07:20 2012 -0800 [hb-shape] Adjust postioning output format 1. If there is any offset (x or y), print out both x and y offsets. 2. Always print out the advance in the major direction of the buffer. Ie. even for zero-advance glyphs, print a "+0". This is more intuitive. util/options.cc | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) commit 6fd5335622087e87739684f581aa9f88635ff970 Author: Behdad Esfahbod Date: Mon Nov 12 18:42:18 2012 -0800 [Indic] Update auto-generated Indic machine to reflect previous commit src/hb-ot-shape-complex-indic-machine.hh | 1126 +++++++++++++++--------------- 1 file changed, 567 insertions(+), 559 deletions(-) commit 9cac1338c4bc3e9034cbfa104291ed0329debefe Author: Behdad Esfahbod Date: Mon Nov 12 18:41:22 2012 -0800 [Indic] Allow Consonant_Medial's after Consonant's Mostly affects Myanmar, but also Tai Tham, Javanese, and Cham. The latter three are untested (no fonts!). src/hb-ot-shape-complex-indic-machine.rl | 3 ++- src/hb-ot-shape-complex-indic-private.hh | 7 ++++--- 2 files changed, 6 insertions(+), 4 deletions(-) commit d187099cbab8e75f870a2bc9c23b6a1cf226905e Author: Behdad Esfahbod Date: Mon Nov 12 18:38:06 2012 -0800 [Indic] Categorize Myanmar "tone marks" as nuktas src/hb-ot-shape-complex-indic-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8173f23f3f16972c2e8e0a120724533100acfda2 Author: Behdad Esfahbod Date: Mon Nov 12 18:37:20 2012 -0800 [Indic] Add config for Myanmar src/hb-ot-shape-complex-indic.cc | 2 ++ 1 file changed, 2 insertions(+) commit 9e92978c8aa3d3cdab4d20c81698c56adbb3dbdd Author: Behdad Esfahbod Date: Mon Nov 12 18:36:10 2012 -0800 [Indic] Route "new" Myanmar tag through the Indic shaper Windows 8 adds a Myanmar shaper using the 'mym2' tag. Route that through the Indic shaper. It's still very broken, but at least this does NOT break old-style Myanmar shaping using the generic shaper. src/hb-ot-shape-complex-private.hh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) commit 5ab3855f8106158ee7e68797e8c35e63e9216e5d Author: Behdad Esfahbod Date: Mon Nov 12 18:27:42 2012 -0800 Choose shaper based on chosen OT script tag For Arabic and Indic shapers, if the font doesn't have a script system for the script, use default shaper. Make an exception for Arabic script since we have fallback logic for that one. src/hb-ot-map-private.hh | 4 ++++ src/hb-ot-shape-complex-private.hh | 11 +++++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) commit 9b37b4c5800b158f61602d2aba8a01349e24d251 Author: Behdad Esfahbod Date: Mon Nov 12 18:23:38 2012 -0800 Make planner available to complex shaper choosing logic src/hb-ot-shape-complex-private.hh | 4 ++-- src/hb-ot-shape.cc | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) commit 6fddf2d7397411bba8a23ac535e8b851495d3105 Author: Behdad Esfahbod Date: Mon Nov 12 17:57:24 2012 -0800 Refactoring ot-map building to make chosen script available earlier src/hb-ot-map-private.hh | 13 ++++++++---- src/hb-ot-map.cc | 51 ++++++++++++++++++++++++++-------------------- src/hb-ot-shape-private.hh | 4 ++-- 3 files changed, 40 insertions(+), 28 deletions(-) commit f17ed8116e7b6429af3fa60bb43d5f4fac66eae3 Author: Behdad Esfahbod Date: Mon Nov 12 17:48:26 2012 -0800 Minor TODO TODO | 2 ++ 1 file changed, 2 insertions(+) commit de796a6fb98f4deda276caa82266b7c830978e0b Author: Behdad Esfahbod Date: Mon Nov 12 17:27:51 2012 -0800 Add "new" Myanmar OT Script tag Windows 8 added support for Myanmar shaping using the "mym2" script tag, even though Windows never supported the old "mymr" tag. src/hb-ot-tag.cc | 2 ++ test/api/test-ot-tag.c | 1 + 2 files changed, 3 insertions(+) commit 27f52dc3f6bbb97594a44f27b180aed73d9e5608 Author: Behdad Esfahbod Date: Mon Nov 12 16:54:03 2012 -0800 Add Myanmar tests from UTN#11 .../south-east-asian/script-myanmar/misc/MANIFEST | 1 + .../south-east-asian/script-myanmar/misc/utn11.txt | 34 ++++++++++++++++++++++ 2 files changed, 35 insertions(+) commit e9334ce97bb7f1de87fb211bb5a8168033629b14 Author: Behdad Esfahbod Date: Mon Nov 12 14:57:02 2012 -0800 Break build when ragel is needed and missing src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dba186711e3f5e723f917b7104e849c4c525d3b8 Author: Behdad Esfahbod Date: Mon Nov 12 14:48:33 2012 -0800 [Indic] Make more room in the table To be used in upcoming commits. src/hb-ot-shape-complex-indic-private.hh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit c4be9917438c45b972ec76dc68409014110f0837 Author: Behdad Esfahbod Date: Mon Nov 12 14:27:33 2012 -0800 Typo src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 56be677781736bbedc80df6f6aaa2b5f0bc4041c Author: Behdad Esfahbod Date: Mon Nov 12 14:09:40 2012 -0800 [Indic] Port 'pref' logic to look into font tables ...instead of using a hardcoded list of Ra characters. src/hb-ot-shape-complex-indic.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) commit f2c0f59043c93c225274fc0c8177077d16c89d61 Author: Behdad Esfahbod Date: Mon Nov 12 14:02:02 2012 -0800 [Indic] Port reph handling logic to look into font features ...instead of using a hardcoded list of Ra characters. src/hb-ot-shape-complex-indic.cc | 48 +++++++++++++++++++++++++--------------- 1 file changed, 30 insertions(+), 18 deletions(-) commit 43149afbc0007ea075a7017c0e56056c3c0f3614 Author: Behdad Esfahbod Date: Mon Nov 12 13:34:17 2012 -0800 Route MEETEI_MAYEK through the Indic shaper Since it has a couple of left-"matras". src/hb-ot-shape-complex-private.hh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit d0905c3400085f9c0901c558ba1b81b5039510e4 Author: Behdad Esfahbod Date: Mon Nov 12 13:02:20 2012 -0800 Minor src/hb-ot-head-table.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 365f27ab5ba025bf1be6a882ed213c695cbfed7e Author: Behdad Esfahbod Date: Mon Nov 12 11:16:57 2012 -0800 Work around older compilers As reported on the list: I am seeing a similar problem building harfbuzz 0.9.5 with Apple gcc 4.0.1 on OS X 10.5 Leopard: hb-ot-layout-common-private.hh:406: error: 'struct OT::CoverageFormat1::Iter' is private hb-ot-layout-common-private.hh:646: error: within this context hb-ot-layout-common-private.hh:500: error: 'struct OT::CoverageFormat2::Iter' is private hb-ot-layout-common-private.hh:647: error: within this context make[4]: *** [libharfbuzz_la-hb-ot-layout.lo] Error 1 Also reported as happening with MSVC 2005. src/hb-ot-layout-common-private.hh | 6 ++++++ 1 file changed, 6 insertions(+) commit 6b389ddc3623d042ded4731f4d62dc354002fdd0 Author: Behdad Esfahbod Date: Mon Nov 12 11:02:56 2012 -0800 [Indic] Don't apply 'liga' Uniscribe doesn't. And some fonts abuse this feature to get Indic shaping working in non-complex applications like Adobe's apps. No change in numbers: BENGALI: 353897 out of 354188 tests passed. 291 failed (0.0821598%) DEVANAGARI: 707337 out of 707394 tests passed. 57 failed (0.00805774%) GUJARATI: 366440 out of 366457 tests passed. 17 failed (0.00463902%) GURMUKHI: 60704 out of 60747 tests passed. 43 failed (0.0707854%) KANNADA: 951046 out of 951913 tests passed. 867 failed (0.0910798%) KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1048011 out of 1048334 tests passed. 323 failed (0.0308108%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271666 out of 271847 tests passed. 181 failed (0.0665816%) TAMIL: 1091754 out of 1091754 tests passed. 0 failed (0%) TELUGU: 970557 out of 970573 tests passed. 16 failed (0.00164851%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%) src/hb-ot-shape-complex-indic.cc | 2 ++ 1 file changed, 2 insertions(+) commit d05ac7dc3f2949e85f1fe996315b31b7aae370fe Author: Behdad Esfahbod Date: Mon Nov 12 10:26:50 2012 -0800 Fix hb-ft glyph name for broken fonts that return empty glyph names src/hb-ft.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3bc22eb7b843c77706bb13fc332009097f247813 Author: Behdad Esfahbod Date: Mon Nov 12 10:07:28 2012 -0800 Minor util/options.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4899801155cc0fef7a8aa58c33ac2d30ba34bcc3 Author: Behdad Esfahbod Date: Thu Nov 8 15:08:26 2012 -0800 U+A872 PHAGS-PA SUPERFIXED LETTER RA is "Right"-Joining src/hb-ot-shape-complex-arabic.cc | 3 +++ 1 file changed, 3 insertions(+) commit 22a685836a59d1c02914761c02d3852810b83ec5 Author: Behdad Esfahbod Date: Mon Nov 5 15:20:10 2012 -0800 Adjust Mongolian shaping For U+1880..U+1886 Uniscribe thinks they are non-joining. For U+1887 Uniscribe thinks it's joining, but looks wrong to me. For now, match Uniscribe. src/hb-ot-shape-complex-arabic.cc | 3 +++ 1 file changed, 3 insertions(+) commit e6b86c8519f894bf7fe18d5c143276521fcacece Author: Behdad Esfahbod Date: Mon Nov 5 15:18:49 2012 -0800 Add test for non-joining Mongolian letters For U+1880..U+1886 Uniscribe thinks they are non-joining. For U+1887 Uniscribe thinks it's joining, but looks wrong to me. .../texts/in-tree/shaper-arabic/script-mongolian/misc/MANIFEST | 1 + .../in-tree/shaper-arabic/script-mongolian/misc/non-joining.txt | 8 ++++++++ 2 files changed, 9 insertions(+) commit c26a52fbe62e5ba4d0e1e2ba13bfb6ceb3f773dc Author: Behdad Esfahbod Date: Sun Nov 4 16:48:45 2012 -0800 Minor src/hb-ot-shape-fallback.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f60d3ed35d94f1adcfd73ca05d03d7e81fb5de03 Author: Behdad Esfahbod Date: Sun Nov 4 16:44:47 2012 -0800 Minor src/hb-set-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f5e55754f962184d2fb7dcab837cdba56e8c7731 Author: Behdad Esfahbod Date: Fri Nov 2 13:53:18 2012 -0700 Add Tifinagh test data test/shaping/texts/in-tree/shaper-default/MANIFEST | 2 ++ .../texts/in-tree/shaper-default/script-tifinagh/MANIFEST | 1 + .../in-tree/shaper-default/script-tifinagh/misc/MANIFEST | 1 + .../in-tree/shaper-default/script-tifinagh/misc/misc.txt | 11 +++++++++++ 4 files changed, 15 insertions(+) commit 10a33296e674ee84b9ed2df25cf373de7d020b8d Author: Behdad Esfahbod Date: Fri Nov 2 13:38:55 2012 -0700 Minor src/hb-ot-tag.cc | 2 ++ 1 file changed, 2 insertions(+) commit c21498afd857e78230f761ee5c9e73adece89dd0 Author: Behdad Esfahbod Date: Fri Nov 2 10:21:26 2012 -0700 Add Mongolian and 'Phags-pa joining test cases test/shaping/texts/in-tree/shaper-arabic/MANIFEST | 1 + .../in-tree/shaper-arabic/script-mongolian/misc/misc.txt | 3 +++ .../texts/in-tree/shaper-arabic/script-phags-pa/MANIFEST | 1 + .../in-tree/shaper-arabic/script-phags-pa/misc/MANIFEST | 1 + .../in-tree/shaper-arabic/script-phags-pa/misc/misc.txt | 14 ++++++++++++++ 5 files changed, 20 insertions(+) commit 3ba7bc14ea652d27639f34109e51a497a678a54a Author: Behdad Esfahbod Date: Thu Nov 1 20:05:04 2012 -0700 Implement 'Phags-pa shaping Through the Arabic shaper. It's similar to Mongolian. src/hb-ot-shape-complex-arabic.cc | 15 ++++++++++++--- src/hb-ot-shape-complex-private.hh | 4 +--- 2 files changed, 13 insertions(+), 6 deletions(-) commit 431bef2e16c7888ca3960f5797432d3a20903550 Author: Behdad Esfahbod Date: Thu Nov 1 16:26:01 2012 -0700 Minor build fix test/api/Makefile.am | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) commit da70111ab234e8b740ce6fb1789a1809fbec0c44 Author: Behdad Esfahbod Date: Wed Oct 31 13:45:30 2012 -0700 Don't clear buffer pre-context if no new context is being provided Patch from Jonathan Kew. Part of fixing: Mozilla Bug 801410 - avoid inserting dotted-circle for run-initial Unicode combining characters in "simple" scripts such as Latin https://bugzilla.mozilla.org/show_bug.cgi?id=801410 src/hb-buffer.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) commit 0bc7a38463bfb37f12efeb1b8cb2024cf4a347bc Author: Behdad Esfahbod Date: Mon Oct 29 22:02:45 2012 -0700 [OT] Fix ReverseChainingSubst We should make it clear that we don't want output buffer in this case, otherwise buffer->backtrack_len() would be wrong. src/hb-buffer-private.hh | 1 + src/hb-buffer.cc | 13 +++++++++++++ src/hb-ot-layout-gsub-table.hh | 1 + 3 files changed, 15 insertions(+) commit 2616689d159024d2b1cb1e68f9936b2129bf9be6 Author: Behdad Esfahbod Date: Mon Oct 29 21:51:56 2012 -0700 More tracing fixups src/hb-ot-layout-gsubgpos-private.hh | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) commit 937f8d3871863b8b1ed1d8900cf41999d92ba30f Author: Behdad Esfahbod Date: Mon Oct 29 21:49:33 2012 -0700 [Arabic] Enable dlig and mset for Arabic That's what the spec says, and what Uniscribe does. src/hb-ot-shape-complex-arabic.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 911ed096980630fd4a37bf2024036daae13a6056 Author: Behdad Esfahbod Date: Mon Oct 29 19:42:19 2012 -0700 Ignore gid0 in test results test/shaping/hb_test_tools.py | 1 + 1 file changed, 1 insertion(+) commit bc513add7999baf32f126ceebbd318105ee66985 Author: Behdad Esfahbod Date: Mon Oct 29 19:03:55 2012 -0700 Add missing TRACE_RETURN src/hb-ot-layout-gsubgpos-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 10b88d89ef1efcfddbbfabd3669399b472c8a900 Author: Behdad Esfahbod Date: Mon Oct 29 18:18:24 2012 -0700 Add Ethiopic test case This sequence: U+120B,U+135F,U+120B with the Nyala font from Win7 exposes a GPOS bug in Uniscribe, in that the positioned mark is wrongly moved as a result a following kern. This is the one "failure" in the Ethiopic test suite :-). ETHIOPIC: 118900 out of 118901 tests passed. 1 failed (0.000841036%) test/shaping/texts/in-tree/shaper-default/script-ethiopic/MANIFEST | 1 + test/shaping/texts/in-tree/shaper-default/script-ethiopic/misc/MANIFEST | 1 + test/shaping/texts/in-tree/shaper-default/script-ethiopic/misc/misc.txt | 1 + 3 files changed, 3 insertions(+) commit 88d3c98e309e14c3115825d1d8d40d0b3eec2d97 Author: Behdad Esfahbod Date: Mon Oct 29 16:27:02 2012 -0700 [Indic] Position pre-base reordering Ra after Chillus in Malayalam The logic for pre-base reordering follows the left matra logic. We had an exception for Malayalam/Tamil in the left matra repositioning which was not reflected in pre-base reordering. Malayalam failures down from 337 to 323. BENGALI: 353996 out of 354285 tests passed. 289 failed (0.0815727%) DEVANAGARI: 707339 out of 707394 tests passed. 55 failed (0.00777502%) GUJARATI: 366489 out of 366506 tests passed. 17 failed (0.0046384%) GURMUKHI: 60769 out of 60809 tests passed. 40 failed (0.0657797%) KANNADA: 951086 out of 951913 tests passed. 827 failed (0.0868777%) KHMER: 299106 out of 299124 tests passed. 18 failed (0.00601757%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1048011 out of 1048334 tests passed. 323 failed (0.0308108%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271726 out of 271847 tests passed. 121 failed (0.0445103%) TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%) TELUGU: 970558 out of 970573 tests passed. 15 failed (0.00154548%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%) src/hb-ot-shape-complex-indic.cc | 35 +++++++++++++++++++++-------------- 1 file changed, 21 insertions(+), 14 deletions(-) commit 21bf796954678d02f136709cade43adef6f8f42b Author: Behdad Esfahbod Date: Mon Oct 29 14:21:09 2012 -0700 Add missed file src/hb-ucdn/COPYING | 13 +++++++++++++ 1 file changed, 13 insertions(+) commit 01013a0f5c58d5d54a37e5b4d6692e0bbd4baf80 Author: Behdad Esfahbod Date: Mon Oct 29 10:56:04 2012 -0700 Include config.h.in in tree I typically don't like including generating files in tree. But like to make an exception for this, since this forms the canonical list of options one would need to go through when building with alternative build systems. Makefile.am | 1 - config.h.in | 160 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 160 insertions(+), 1 deletion(-) commit 02ed52169ad3bb48f4989f721b0c6572e064a712 Author: Behdad Esfahbod Date: Sun Oct 28 21:26:19 2012 -0700 Improve license information COPYING | 2 ++ src/hb-icu-le/COPYING | 2 ++ src/hb-icu-le/Makefile.am | 2 +- src/hb-ucdn/Makefile.am | 2 +- src/hb-ucdn/README | 7 +++++++ 5 files changed, 13 insertions(+), 2 deletions(-) commit 4c1d9244617e472464722e64d2cdbc1f9e8827f6 Author: Behdad Esfahbod Date: Sun Oct 28 20:27:25 2012 -0700 Minor src/hb-icu-le.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 38b015e57ffa75d3b078a368c23685beb7c3f946 Author: Behdad Esfahbod Date: Sun Oct 28 20:11:47 2012 -0700 Fix hb_buffer_set_length(buffer, 0) Was causing invalid realloc()s. src/hb-buffer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b7115b63be72e109b51f538ba581aed1017b2d55 Author: Behdad Esfahbod Date: Sun Oct 28 20:11:42 2012 -0700 Add XXX src/hb-icu-le.cc | 1 + 1 file changed, 1 insertion(+) commit 71ee1f24503cd066ffc1a36cc5dd9a3c1d1a6dfd Author: Behdad Esfahbod Date: Sun Oct 28 19:18:11 2012 -0700 Port to ICU LayoutEngine C API Incidentally, this makes it not crash with icu-le-hb anymore... I'm not smart / stupid enough to spend two more days debugging C++ linking issues, and this is ABI-stable at least. src/hb-icu-le.cc | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) commit 0144f05e57088b30ac894cdae8b04b265d4dfbe7 Author: Behdad Esfahbod Date: Fri Oct 26 13:48:06 2012 -0700 Remove unused members src/hb-icu-le/PortableFontInstance.h | 3 --- 1 file changed, 3 deletions(-) commit cf3afd8979b1db76d437f428cbd51cb363e0d18e Author: Behdad Esfahbod Date: Thu Oct 25 16:32:54 2012 -0700 Rename and revamp is_zero_width() to be is_default_ignorable() That's really the logic desired. Except that MONGOLIAN VOWEL SEPARATOR is not default_ignorable but it really should be. Reported to Unicode. Based on suggestion from Konstantin Ritt. src/hb-fallback-shape.cc | 2 +- src/hb-ot-shape-private.hh | 4 +-- src/hb-ot-shape.cc | 2 +- src/hb-unicode-private.hh | 90 +++++++++++++++++++++++++++++----------------- 4 files changed, 62 insertions(+), 36 deletions(-) commit a724139e641bf1592b1ff786a75a9de2ea8163cf Author: Behdad Esfahbod Date: Wed Oct 24 14:02:15 2012 -0700 Update TODO TODO | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) commit 13c058472913b7b6d689f9022226079da65420b0 Author: Behdad Esfahbod Date: Sun Oct 14 18:37:09 2012 -0500 0.9.5 NEWS | 23 +++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 24 insertions(+), 1 deletion(-) commit fecdfa95daf4916695f23e7dab89ab363be11b89 Author: Behdad Esfahbod Date: Sun Oct 7 17:19:58 2012 -0400 Fixup hb_ot_shape_closure() Broke it when merged cmap mapping and normalizer. Ouch! src/hb-ot-shape.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2d1dcb3ce3354c2d5e2b4d1d291beb8d23cdea22 Author: Behdad Esfahbod Date: Sun Oct 7 17:13:46 2012 -0400 Mark debug message functions static src/hb-private.hh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 9947bd6daffb5ec76b67536575e7617ba4f10b1e Author: Behdad Esfahbod Date: Tue Oct 2 20:44:43 2012 -0400 Update UCDN to upstream commit 3f159c87824230b59af56e40e2db32caf6afa51a - Unicode 6.2.0 goodness, - Unassigned codepoints now have correct properties. Passes test suite. src/hb-ucdn/unicodedata_db.h | 1966 ++++++++++++++++++++++-------------------- 1 file changed, 1036 insertions(+), 930 deletions(-) commit 32dbfcf763d1ae497d3c95de986a83441331678f Author: Behdad Esfahbod Date: Tue Oct 2 17:42:13 2012 -0400 Fix visibility of UCDN symbols src/hb-ucdn.cc | 2 -- src/hb-ucdn/ucdn.h | 19 +++++++++++++++++++ 2 files changed, 19 insertions(+), 2 deletions(-) commit 3f33f0d1f2603f22e86adffe3c3836136ba5e5fd Author: Behdad Esfahbod Date: Tue Oct 2 16:03:18 2012 -0400 Import UCDN into source tree https://github.com/grigorig/ucdn configure.ac | 11 +- src/Makefile.am | 7 + src/hb-ucdn.cc | 207 ++ src/hb-ucdn/Makefile.am | 18 + src/hb-ucdn/README | 33 + src/hb-ucdn/ucdn.c | 282 +++ src/hb-ucdn/ucdn.h | 290 +++ src/hb-ucdn/unicodedata_db.h | 4648 ++++++++++++++++++++++++++++++++++++++++++ src/hb-unicode.cc | 3 + 9 files changed, 5498 insertions(+), 1 deletion(-) commit 0e292eb2a2abbac152eeea2060e58b7a66449745 Author: Behdad Esfahbod Date: Tue Oct 2 14:59:00 2012 -0400 Remove Glib thread-safety support Now that we have pthread detection in configure, we don't need Glib anymore. Glib will only be a Unicode data provider. configure.ac | 8 ++++---- src/hb-atomic-private.hh | 13 ------------- src/hb-mutex-private.hh | 20 -------------------- 3 files changed, 4 insertions(+), 37 deletions(-) commit 66efe896483c58f3ef9bd218c02bb7ea604f68ee Author: Behdad Esfahbod Date: Tue Oct 2 14:55:32 2012 -0400 Check for pthreads configure.ac | 7 +++++++ src/Makefile.am | 5 +++++ 2 files changed, 12 insertions(+) commit 10a8162dddb8b39ae130fe5bb7d1819471fa7e06 Author: Behdad Esfahbod Date: Tue Oct 2 14:46:34 2012 -0400 Add ax_pthread.m4 m4/ax_pthread.m4 | 309 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 309 insertions(+) commit 8ac34bc6ff1d0646503a45659b1846d8cf9c0603 Author: Behdad Esfahbod Date: Tue Oct 2 14:46:04 2012 -0400 Add pkg.m4 to git repo m4/pkg.m4 | 157 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 157 insertions(+) commit c7afac0aa6e51e6a49ebf13f72537398698c9e49 Author: Behdad Esfahbod Date: Tue Oct 2 14:44:47 2012 -0400 Add AC_CONFIG_MACRODIR Makefile.am | 2 ++ configure.ac | 2 ++ 2 files changed, 4 insertions(+) commit f2eb3fa9dca8d21fae20c9b9dddad3245df74a05 Author: Behdad Esfahbod Date: Tue Sep 25 21:35:35 2012 -0400 [OT] Only insert dottedcircle if at the beginning of paragraph If the first char in the run is a combining mark, but there is text before the run, don't insert dottedcircle. Part of addressing: https://bugzilla.redhat.com/show_bug.cgi?id=858736 src/hb-ot-shape.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) commit bdc2fc8294da7f374701aafe9f5a82d60633946f Author: Behdad Esfahbod Date: Tue Sep 25 21:32:35 2012 -0400 [Arabic] Respect Arabic joining from neighboring context Now we respect Arabic joining across runs. src/hb-ot-shape-complex-arabic.cc | 31 +++++++++++++++++++++++++++++-- 1 file changed, 29 insertions(+), 2 deletions(-) commit 05207a79e0ae1769c5feaebe3fd99bdf9cfcf834 Author: Behdad Esfahbod Date: Tue Sep 25 17:44:53 2012 -0400 [buffer] Save pre/post textual context To be used for a variety of purposes. We save up to five characters in each direction. No public API changes, everything is taken care of already. All clients need to do is to call hb_buffer_add_utf* with the full text + segment info (or at least some context) instead of just passing in the segment. Various operations (hb_buffer_reset, hb_buffer_set_length, hb_buffer_add*) automatically reset the relevant contexts. src/hb-buffer-private.hh | 13 ++++++++++++- src/hb-buffer.cc | 44 ++++++++++++++++++++++++++++++++++++++++---- src/hb-buffer.h | 2 +- 3 files changed, 53 insertions(+), 6 deletions(-) commit 89ac39dbbe028e6379f64392f2e590e3f1fdd847 Author: Behdad Esfahbod Date: Tue Sep 25 13:59:24 2012 -0400 Add hb_utf_prev() src/hb-utf-private.hh | 71 +++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 69 insertions(+), 2 deletions(-) commit 70ea4ac6887c7057113d714a98e55738b6196562 Author: Behdad Esfahbod Date: Tue Sep 25 12:30:16 2012 -0400 Slightly optimize UTF-8 parsing src/hb-utf-private.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 4445e5e2ecc257a5d0fa2f2715bb7181a47346da Author: Behdad Esfahbod Date: Tue Sep 25 12:26:12 2012 -0400 [buffer] Cleanup / optimize UTF-16 parsing a bit src/hb-utf-private.hh | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) commit 1f66c3c1a0eb869c0d85a015235313177e0cec62 Author: Behdad Esfahbod Date: Tue Sep 25 11:42:16 2012 -0400 Add hb_utf_strlen() Speeds up UTF-8 parsing by calling strlen(). src/hb-buffer.cc | 13 ++----------- src/hb-utf-private.hh | 22 ++++++++++++++++++++++ 2 files changed, 24 insertions(+), 11 deletions(-) commit 7f19ae7b9f806a2e35206b2ad41651c5f80b2537 Author: Behdad Esfahbod Date: Tue Sep 25 11:22:28 2012 -0400 [buffer] Templatize UTF handling Also move UTF routines into a separate file, to be reused from shapers that need it. src/Makefile.am | 1 + src/hb-buffer.cc | 157 +++++++++++++------------------------------------- src/hb-utf-private.hh | 113 ++++++++++++++++++++++++++++++++++++ 3 files changed, 155 insertions(+), 116 deletions(-) commit 0e0a4da9b7677a09e00d27313236e1f333864dd6 Author: Behdad Esfahbod Date: Tue Sep 25 11:09:04 2012 -0400 [buffer] Towards template'izing different UTF adders src/hb-buffer.cc | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) commit 7d37280600c157f3c4eae8746e99511702a58e8f Author: Behdad Esfahbod Date: Tue Sep 25 11:04:41 2012 -0400 Minor src/hb-buffer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 54d5da4ee9d902ff36473cec558137eef8f23825 Author: Behdad Esfahbod Date: Tue Sep 25 10:50:41 2012 -0400 Remove unused indic.cc src/Makefile.am | 6 +----- src/indic.cc | 51 --------------------------------------------------- 2 files changed, 1 insertion(+), 56 deletions(-) commit fab7a71f110ed646745d54b23284537c50058c21 Author: Behdad Esfahbod Date: Mon Sep 24 21:51:13 2012 -0400 [Indic] Import ragel-generated Indic machine in git I don't expect ragel to be creating too much noise in its generated output, and including this in-tree helps users right now. We can revisit this later if it proved to be too much trouble. autogen.sh | 6 - src/Makefile.am | 1 - src/hb-ot-shape-complex-indic-machine.hh | 1314 ++++++++++++++++++++++++++++++ 3 files changed, 1314 insertions(+), 7 deletions(-) commit 20a840c7cd08069720050782b4533cde505df09a Author: Behdad Esfahbod Date: Mon Sep 24 20:23:00 2012 -0400 Use a C++ linker on Windows On Windows we don't care whether or not we link to libstdc++. Seems to fix build with mingw32 on msys, as reported by Werner. src/Makefile.am | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit eb7669a38072b66eef3bd905a93c4815bef3f0e5 Author: Behdad Esfahbod Date: Tue Sep 18 19:42:06 2012 -0400 Better autofoo src/Makefile.am | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit d00f7d83750258eff915a3826700c4819e63e481 Author: Behdad Esfahbod Date: Mon Sep 17 20:59:09 2012 -0400 Fix dependencies src/Makefile.am | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 811eefe225d20b20f1de20c6e62a0ebd6d89102a Author: Behdad Esfahbod Date: Mon Sep 10 09:56:27 2012 -0400 Return NULL, not false Oh well... src/hb-open-type-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 166b5cf7ec2d37fb54a909c437ccdec1edaf37aa Author: Behdad Esfahbod Date: Fri Sep 7 14:55:07 2012 -0400 [Indic] Find syllables before any features are applied With FreeSerif, it seems that the 'ccmp' feature does ligature substituttions. That was then causing syllable match failures. We now find syllables before any features have been applied. Test sequence: U+0D9A,U+0DCA,U+200D,U+0DBB,U+0DCF src/hb-ot-shape-complex-indic-machine.rl | 4 +- src/hb-ot-shape-complex-indic.cc | 56 +++++++++++++++------- .../indic/script-sinhala/misc/misc.txt | 1 + 3 files changed, 43 insertions(+), 18 deletions(-) commit 96fdc04e5c6daafce3d45e7508418e4db94df44c Author: Behdad Esfahbod Date: Thu Sep 6 22:26:16 2012 -0400 Add hb_buffer_[sg]et_content_type And hb_buffer_content_type_t and enum values. TODO | 1 + src/hb-buffer-private.hh | 2 ++ src/hb-buffer.cc | 34 ++++++++++++++++++++++++++++++++++ src/hb-buffer.h | 14 ++++++++++++++ src/hb-shape.cc | 5 +++++ 5 files changed, 56 insertions(+) commit e30ebd2794b37bd8ec716a258d5cb017fb1dfadc Author: Behdad Esfahbod Date: Thu Sep 6 22:09:06 2012 -0400 Add hb_feature_to/from_string() TODO | 4 +- src/hb-common.cc | 9 +++ src/hb-common.h | 6 +- src/hb-shape.cc | 168 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/hb-shape.h | 13 +++++ util/options.cc | 132 ++----------------------------------------- 6 files changed, 201 insertions(+), 131 deletions(-) commit f67917161bbe317a33d6407fbc62ebffcafe7154 Author: Behdad Esfahbod Date: Thu Sep 6 17:22:31 2012 -0400 [OT] Do per-ligature-component fallback mark positioning With this in place, you can remove GDEF/GSUB/GPOS tables from Arabic fonts and still get per-component marks positioned on oh-yeah-fallback-formed LAM-ALEF ligatures with marks in between the LAM and ALEF. Now *that*'s pretty cool, if a bit anachronistic... src/hb-ot-shape-fallback.cc | 43 ++++++++++++++++++++++++++++++++++++------- 1 file changed, 36 insertions(+), 7 deletions(-) commit 525c6855783a018d52867b9ece2ee90868ff1f91 Author: Behdad Esfahbod Date: Thu Sep 6 16:02:07 2012 -0400 [OT] Make fallback mark positioning more robust ...with clusters spanning multiple base characters. src/hb-ot-shape-fallback.cc | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) commit 5d502443f5a07cbd0aa860dd71a0fa4ea8b6ff9f Author: Behdad Esfahbod Date: Thu Sep 6 15:29:29 2012 -0400 [old] Clear offset array src/hb-old.cc | 3 +++ 1 file changed, 3 insertions(+) commit 9433c218b4853442dd9ad53d0588a837a33dbf1e Author: Behdad Esfahbod Date: Thu Sep 6 14:27:15 2012 -0400 [OT] Simplify fallback positioning condition src/hb-ot-shape-fallback.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 028a1706f898bfcee0d14acfba47ebe1de09f0c4 Author: Behdad Esfahbod Date: Thu Sep 6 14:25:48 2012 -0400 Refactor common macro src/hb-ot-shape-fallback.cc | 5 +---- src/hb-ot-shape-normalize.cc | 5 +---- src/hb-ot-shape.cc | 5 +---- src/hb-unicode-private.hh | 9 +++++++++ 4 files changed, 12 insertions(+), 12 deletions(-) commit 07cfbe21b511056d5c3c75cbfe84e4e982c3e8fb Author: Behdad Esfahbod Date: Thu Sep 6 01:16:39 2012 -0400 [OT] Streamline Arabic fallback shaping table src/gen-arabic-table.py | 6 +- src/hb-ot-shape-complex-arabic-fallback.hh | 2 +- src/hb-ot-shape-complex-arabic-table.hh | 266 ++++++++++++++--------------- 3 files changed, 137 insertions(+), 137 deletions(-) commit 82f6b6f388b801a1483854cb56a2cadbb94e0f2b Author: Behdad Esfahbod Date: Thu Sep 6 01:12:50 2012 -0400 Minor src/hb-ot-shape-complex-arabic-fallback.hh | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) commit fabd3113a98c5f4114f48920fa7ea38bd65a8d32 Author: Behdad Esfahbod Date: Wed Sep 5 22:19:28 2012 -0400 [OT] Port Arabic fallback shaping to synthetic GSUB All of init/medi/fina/isol and rlig implemented. Let there be dragons... ⻯ src/Makefile.am | 1 + src/hb-open-type-private.hh | 69 +++++--- src/hb-ot-layout-common-private.hh | 9 +- src/hb-ot-layout-gsub-table.hh | 11 +- src/hb-ot-map-private.hh | 6 + src/hb-ot-map.cc | 1 + src/hb-ot-shape-complex-arabic-fallback.hh | 252 +++++++++++++++++++++++++++++ src/hb-ot-shape-complex-arabic.cc | 158 ++++++------------ src/hb-ot-shape.cc | 7 +- src/hb-private.hh | 11 +- 10 files changed, 369 insertions(+), 156 deletions(-) commit f0b8ed1b6dd9f1d2b9084c101a6fc5dee0cc22a8 Author: Behdad Esfahbod Date: Wed Sep 5 17:32:57 2012 -0400 [Indic] Allow "H,ZWJ,M" Uniscribe accepts a Halant,ZWJ before matras. Allow that. BENGALI down from 295 to 291 DEVANAGARI down from 69 to 57 GUJARATI down from 19 to 17 KANNADA down from 871 to 867 MALAYALAM down from 340 to 337 TELUGU down from 20 to 16 Currently at: BENGALI: 353897 out of 354188 tests passed. 291 failed (0.0821598%) DEVANAGARI: 707337 out of 707394 tests passed. 57 failed (0.00805774%) GUJARATI: 366440 out of 366457 tests passed. 17 failed (0.00463902%) GURMUKHI: 60704 out of 60747 tests passed. 43 failed (0.0707854%) KANNADA: 951046 out of 951913 tests passed. 867 failed (0.0910798%) KHMER: 299077 out of 299124 tests passed. 47 failed (0.0157125%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1047997 out of 1048334 tests passed. 337 failed (0.0321462%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271666 out of 271847 tests passed. 181 failed (0.0665816%) TAMIL: 1091754 out of 1091754 tests passed. 0 failed (0%) TELUGU: 970557 out of 970573 tests passed. 16 failed (0.00164851%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%) src/hb-ot-shape-complex-indic-machine.rl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4ed717ef61813fa16cf74f2874848e9feb81568f Author: Behdad Esfahbod Date: Wed Sep 5 17:21:17 2012 -0400 [Indic] Relax grammar Now that we insert dotted-circle, tests break more easily when our indic machine breaks. In particular, a few Devanagari tests were having sequences like "C,H,ZWJ,N", and because of the ZWJ the Nukta does NOT get reordered to before the Halant as the grammar used to expect... Fixup. Another case is as simple as "C,ZWJ,SM". Fixes 10 out of 79 failures: DEVANAGARI: 707325 out of 707394 tests passed. 69 failed (0.00975411%) src/hb-ot-shape-complex-indic-machine.rl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit aa7141efe49991a1160489106984e95163fe2ab8 Author: Behdad Esfahbod Date: Wed Sep 5 15:54:21 2012 -0400 [Indic] Fix Khmer syllable-final coeng-consonant Brings down Khmer failures from 162 to 47. KHMER: 299077 out of 299124 tests passed. 47 failed (0.0157125%) Also rebaselined some of the test files that had only-inherited lines. Removing those, the stats are: BENGALI: 353893 out of 354188 tests passed. 295 failed (0.0832891%) DEVANAGARI: 707315 out of 707394 tests passed. 79 failed (0.0111678%) GUJARATI: 366438 out of 366457 tests passed. 19 failed (0.00518478%) GURMUKHI: 60704 out of 60747 tests passed. 43 failed (0.0707854%) KANNADA: 951042 out of 951913 tests passed. 871 failed (0.0915%) KHMER: 299077 out of 299124 tests passed. 47 failed (0.0157125%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1047994 out of 1048334 tests passed. 340 failed (0.0324324%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271666 out of 271847 tests passed. 181 failed (0.0665816%) TAMIL: 1091754 out of 1091754 tests passed. 0 failed (0%) TELUGU: 970553 out of 970573 tests passed. 20 failed (0.00206064%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%) Still some regressions, but some of the more egregious cases are addressed. src/hb-ot-shape-complex-indic-machine.rl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit efb8d3eb713bca7cbfca41380a012bdb4d380e5c Author: Behdad Esfahbod Date: Wed Sep 5 15:50:47 2012 -0400 Fixup test failure reporting After we implemented dotted-circle, we were still ignoring any tests that had dottedcircle in it for any of the shapers. That meant that if we wrongly outputted dottedcircle, the test was being ignored. Ouch! Fixing that shows regressions across the board. Most are Uniscribe bugs: NOT inserting dotted-circle when it should. Some are arou machine bugs. This is in fact a nice way to catch Indic-machine deficiencies and when I fix the regressions, our clusters should be much closer to Uniscribe. For now, we regressed from: BENGALI: 353997 out of 354285 tests passed. 288 failed (0.0812905%) DEVANAGARI: 707339 out of 707394 tests passed. 55 failed (0.00777502%) GUJARATI: 366489 out of 366506 tests passed. 17 failed (0.0046384%) GURMUKHI: 60769 out of 60809 tests passed. 40 failed (0.0657797%) KANNADA: 951086 out of 951913 tests passed. 827 failed (0.0868777%) KHMER: 299106 out of 299124 tests passed. 18 failed (0.00601757%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1048104 out of 1048416 tests passed. 312 failed (0.0297592%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271747 out of 271847 tests passed. 100 failed (0.0367854%) TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%) TELUGU: 970558 out of 970573 tests passed. 15 failed (0.00154548%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%) To: BENGALI: 353990 out of 354285 tests passed. 295 failed (0.0832663%) DEVANAGARI: 707315 out of 707394 tests passed. 79 failed (0.0111678%) GUJARATI: 366447 out of 366506 tests passed. 59 failed (0.016098%) GURMUKHI: 60707 out of 60809 tests passed. 102 failed (0.167738%) KANNADA: 951042 out of 951913 tests passed. 871 failed (0.0915%) KHMER: 298962 out of 299124 tests passed. 162 failed (0.0541581%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1048074 out of 1048416 tests passed. 342 failed (0.0326206%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271666 out of 271847 tests passed. 181 failed (0.0665816%) TAMIL: 1091835 out of 1091837 tests passed. 2 failed (0.000183178%) TELUGU: 970553 out of 970573 tests passed. 20 failed (0.00206064%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%) Investigating. test/shaping/hb_test_tools.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 27bd55bd2ca599d501f10c2fae81861137517e46 Author: Behdad Esfahbod Date: Wed Sep 5 15:11:14 2012 -0400 [Indic] Tamil does not have half-forms either The Win7 Tamil font does not realy on this behavior, but the WinXP version does. Handle Tamil like Malayalam: Matras always move to before base. WinXP Tamil failures went down from 168964 (15.4752%) to 167 (0.0152953%) (two orders of magnitude reduction!). Included in this is a minor fixup that actually fixed a few tests with non-Tamil too. Numbers at: BENGALI: 353997 out of 354285 tests passed. 288 failed (0.0812905%) DEVANAGARI: 707339 out of 707394 tests passed. 55 failed (0.00777502%) GUJARATI: 366489 out of 366506 tests passed. 17 failed (0.0046384%) GURMUKHI: 60769 out of 60809 tests passed. 40 failed (0.0657797%) KANNADA: 951086 out of 951913 tests passed. 827 failed (0.0868777%) KHMER: 299106 out of 299124 tests passed. 18 failed (0.00601757%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1048104 out of 1048416 tests passed. 312 failed (0.0297592%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271747 out of 271847 tests passed. 100 failed (0.0367854%) TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%) TELUGU: 970558 out of 970573 tests passed. 15 failed (0.00154548%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%) src/hb-ot-shape-complex-indic.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit 87b75d0a4aa03fe7a03e3bf7baf8ece131aec1bb Author: Behdad Esfahbod Date: Tue Sep 4 23:06:38 2012 -0400 [OT] Allow adding features with fallback implementation src/hb-ot-map-private.hh | 7 ++++--- src/hb-ot-map.cc | 6 ++++-- 2 files changed, 8 insertions(+), 5 deletions(-) commit 1d3947a6bda6986c9c7d993589053051c119cc81 Author: Behdad Esfahbod Date: Tue Sep 4 22:42:17 2012 -0400 Minor src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-layout-gsub-table.hh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit b3b89b66586897a69b410ef02e7434691de84ae6 Author: Behdad Esfahbod Date: Tue Sep 4 21:13:17 2012 -0400 [OT] Add SubstLookup serialize API src/hb-ot-layout-common-private.hh | 2 +- src/hb-ot-layout-gsub-table.hh | 65 +++++++++++++++++++++++++++++++++++++- 2 files changed, 65 insertions(+), 2 deletions(-) commit 715e03bc21d6adaa8e1f647235843839dc47dad1 Author: Behdad Esfahbod Date: Tue Sep 4 20:10:17 2012 -0400 Minor src/hb-open-type-private.hh | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) commit 652d1e0d64e47313ead2fc8318d1236f0e0d80ca Author: Behdad Esfahbod Date: Tue Sep 4 20:00:44 2012 -0400 [OT] Start adding Lookup-level serialize API src/hb-ot-layout-common-private.hh | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) commit a930c68e9c50aade78c1eb0eef075c9c117e4ef6 Author: Behdad Esfahbod Date: Tue Sep 4 18:17:57 2012 -0400 [OT] More serialize. Implements all basic GSUB subtables src/hb-open-type-private.hh | 53 +++++++++++++++- src/hb-ot-layout-common-private.hh | 8 ++- src/hb-ot-layout-gsub-table.hh | 125 +++++++++++++++++++++++++++++-------- 3 files changed, 156 insertions(+), 30 deletions(-) commit 1b38b4e817d871b9549be65af6030bd0eea7f775 Author: Behdad Esfahbod Date: Tue Sep 4 18:17:21 2012 -0400 Minor src/hb-ot-layout-gsub-table.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit f7e81ce0b882aa942ae33c787e741c5e8e5a0173 Author: Behdad Esfahbod Date: Tue Sep 4 15:32:37 2012 -0400 0.9.4 NEWS | 18 ++++++++++++++++++ configure.ac | 2 +- 2 files changed, 19 insertions(+), 1 deletion(-) commit 2bd9fe359839a653f7caae534bf768af1735f155 Author: Behdad Esfahbod Date: Tue Sep 4 15:15:19 2012 -0400 Refactor src/hb-ot-layout-gpos-table.hh | 7 ++----- src/hb-ot-layout-gsub-table.hh | 16 +++++----------- src/hb-ot-layout-gsubgpos-private.hh | 13 +++---------- src/hb-ot-layout.cc | 23 +++++++++++++++++------ src/hb-ot-shape-complex-arabic.cc | 4 +--- 5 files changed, 28 insertions(+), 35 deletions(-) commit a5ddd9e31cd7906c4b559aa5b2fafdae4b9c8935 Author: Behdad Esfahbod Date: Tue Sep 4 14:55:00 2012 -0400 [OT] Really fix possible NULL dereference this time src/hb-ot-layout-gsubgpos-private.hh | 8 ++++---- src/hb-ot-layout.cc | 6 +++--- src/hb-ot-shape-complex-arabic.cc | 4 +++- 3 files changed, 10 insertions(+), 8 deletions(-) commit 29416833584d7831ece84aaeada6f5ebba7828c0 Author: Behdad Esfahbod Date: Mon Sep 3 23:31:14 2012 -0400 [OT] Implement serialize() for AlternateSubst src/hb-ot-layout-gsub-table.hh | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) commit 1f07e3382a1608b054cbf88b89fef74f6c485434 Author: Behdad Esfahbod Date: Mon Sep 3 23:28:34 2012 -0400 [OT] Implement serialize() for MultiSubst src/hb-open-type-private.hh | 10 ++++++++++ src/hb-ot-layout-gsub-table.hh | 43 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 53 insertions(+) commit 4912030dfba740c822e200d33cbb5c6dbbeaf79e Author: Behdad Esfahbod Date: Mon Sep 3 20:58:03 2012 -0400 Minor src/hb-open-type-private.hh | 4 ++-- src/hb-ot-layout-gsub-table.hh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) commit f8fa2b5cf67b02d74514dec7885d03de73ec7349 Author: Behdad Esfahbod Date: Mon Sep 3 20:19:46 2012 -0400 Fix possible NULL dereference As reported by Kenichi Ishibashi. src/hb-ot-layout-gsubgpos-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4b312fb288faa383a2c5bd3be0428f0e58e02699 Author: Behdad Esfahbod Date: Sat Sep 1 21:56:06 2012 -0400 [OT] Remove serialize alignment Will reintroduce in a different way when we actually need it. src/hb-open-type-private.hh | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) commit c61be03d6df122f18eebda3b29e42c9e768d45b9 Author: Behdad Esfahbod Date: Sat Sep 1 21:43:38 2012 -0400 [OT] A bit more serialize src/hb-open-type-private.hh | 14 +++++++++++++ src/hb-ot-layout-common-private.hh | 2 +- src/hb-ot-layout-gsub-table.hh | 43 ++++++++++++++++++++++++++++++++++++-- 3 files changed, 56 insertions(+), 3 deletions(-) commit abcc5ac1fde1c493e4055dd2f27b8aade7713156 Author: Behdad Esfahbod Date: Sat Sep 1 21:30:17 2012 -0400 [OT] Improve serialize syntax For some definition of improvement... src/hb-open-type-private.hh | 6 ++++-- src/hb-ot-layout-gsub-table.hh | 3 +-- 2 files changed, 5 insertions(+), 4 deletions(-) commit bc5be24014371ceb811b9ffd37062ede63d87bb1 Author: Behdad Esfahbod Date: Sat Sep 1 20:48:22 2012 -0400 [OT] Restart work on serialize() src/hb-open-type-private.hh | 39 ++++++++++++++++++------ src/hb-ot-layout-common-private.hh | 61 +++++++++++++++++++------------------- src/hb-ot-layout-gsub-table.hh | 13 ++++++++ 3 files changed, 73 insertions(+), 40 deletions(-) commit 6912e476dd92639c3ddf07ca51c8d4a262c8b3a5 Author: Behdad Esfahbod Date: Sat Sep 1 20:38:45 2012 -0400 [OT] Insert dotted-circle for run-initial marks Unfortunately if the font has GPOS and 'mark' feature does not position mark on dotted-circle, our inserted dotted-circle will not get the mark repositioned to itself. Uniscribe cheats here. If there is no GPOS however, the fallback positioning kicks in and sorts this out. I'm not willing to address the first case. src/hb-ot-shape.cc | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) commit 1d581ec384bc1780995e32e1c44103af57596eda Author: Behdad Esfahbod Date: Sat Sep 1 20:06:26 2012 -0400 [OT] Fallback-position ccc=0 Thai / Lao marks Not perfect, but so is fallback positioning in 2012... src/hb-ot-shape-fallback.cc | 56 +++++++++++++++++++++++++++++++++++++-------- 1 file changed, 46 insertions(+), 10 deletions(-) commit 3992b5ec4cb43d114d87ff7ee2b992bcf819c9cd Author: Behdad Esfahbod Date: Sat Sep 1 19:20:41 2012 -0400 Move code around src/hb-ot-shape-fallback-private.hh | 5 ++++ src/hb-ot-shape-fallback.cc | 46 +++++++++++++++++++++++++------------ src/hb-ot-shape-private.hh | 6 +++++ src/hb-ot-shape.cc | 4 ++++ 4 files changed, 46 insertions(+), 15 deletions(-) commit b85800f9de8976a7418ef9df467d3080c6ab0199 Author: Behdad Esfahbod Date: Fri Aug 31 18:12:01 2012 -0400 [Indic] Implement dotted-circle insertion for broken clusters No panic, we reeally insert dotted circle when it's absolutely broken. Fixes most of the dotted-circle cases against Uniscribe. (for Devanagari fixes 80% of them, for Khmer 70%; the rest look like Uniscribe being really bogus...) I had to make a decision. Apparently Uniscribe adds one dotted circle to each broken character. I tried that, but that goes wrong easily with split matras. So I made it add only one dotted circle to an entire broken syllable tail. As in: "if there was a dotted circle here, this would have formed a correct cluster." That works better for split stuff, and I like it more. src/hb-buffer-private.hh | 1 + src/hb-buffer.cc | 10 +++++ src/hb-ot-shape-complex-indic-machine.rl | 4 +- src/hb-ot-shape-complex-indic-private.hh | 2 +- src/hb-ot-shape-complex-indic.cc | 67 +++++++++++++++++++++++++++++--- src/hb-ot-shape-normalize-private.hh | 1 + src/hb-ot-shape-normalize.cc | 11 +++--- 7 files changed, 83 insertions(+), 13 deletions(-) commit 327d14ef188396006d54af976506ab6f8bb2869a Author: Behdad Esfahbod Date: Fri Aug 31 16:49:34 2012 -0400 [Indic] Start adding dotted-circle instrastructure src/hb-ot-shape-complex-indic-machine.rl | 19 +++++++------ src/hb-ot-shape-complex-indic.cc | 46 +++++++++++++++++++++++++++++--- 2 files changed, 51 insertions(+), 14 deletions(-) commit 1be368e96fb7de8c77bf992874e0d5bd6b272ebe Author: Behdad Esfahbod Date: Fri Aug 31 16:29:17 2012 -0400 Minor src/hb-buffer-private.hh | 16 +++++++++++++++- src/hb-buffer.cc | 15 --------------- 2 files changed, 15 insertions(+), 16 deletions(-) commit 784f29d061a2939562eca0c4943feb01174aee00 Author: Behdad Esfahbod Date: Fri Aug 31 14:06:26 2012 -0400 Minor src/hb-ot-shape.cc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) commit 5a7f18767a87a3f07269d0814f984a98f86ab852 Author: Behdad Esfahbod Date: Thu Aug 30 22:53:29 2012 -0400 [OT] Better fallback-position Thai / Lao ccc!=0 marks src/hb-ot-shape-fallback.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 9f2348de58f0f85593027378169bc03c4dd64e59 Author: Behdad Esfahbod Date: Wed Aug 29 21:08:59 2012 -0400 [OT] Add serialize() for Coverage src/hb-open-type-private.hh | 34 +++++++++++++++++---- src/hb-ot-layout-common-private.hh | 62 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 90 insertions(+), 6 deletions(-) commit e901b954c6ec44ac3ae7fb3c326e6e7a40718e4b Author: Behdad Esfahbod Date: Wed Aug 29 20:26:08 2012 -0400 [OT] Start adding serialize() API src/hb-open-type-private.hh | 77 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 77 insertions(+) commit 965c280de09b49d711cb78d629da321c802084de Author: Behdad Esfahbod Date: Wed Aug 29 13:59:16 2012 -0400 Add HB_BUFFER_ASSERT_VAR To be used in places we access buffer vars... src/hb-buffer-private.hh | 3 +++ src/hb-buffer.cc | 16 ++++++++++++++++ 2 files changed, 19 insertions(+) commit 0ccf9b64736559a230425fd131c9eb8aa3048221 Author: Behdad Esfahbod Date: Wed Aug 29 11:53:26 2012 -0400 Move code around src/hb-ot-shape.cc | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) commit 2fcbbdb41a322f54b61d9ce983ab54434504c5ed Author: Behdad Esfahbod Date: Wed Aug 29 11:11:54 2012 -0400 Port Arabic fallback ligating to share code with GSUB This will eventually allow us to skip marks, as well as (fallback) attach marks to ligature components of fallback-shaped Arabic. That would be pretty cool. I kludged GDEF props in, so mark-skipping works, but the produced ligature id/components will be cleared later by substitute_start() et al. Perhaps using a synthetic table for Arabic fallback shaping was a better idea. The current approach has way too many layering violations... src/hb-ot-layout-gsubgpos-private.hh | 4 ++ src/hb-ot-shape-complex-arabic.cc | 72 ++++++++++++++++++++++++------------ src/hb-ot-shape.cc | 4 +- 3 files changed, 56 insertions(+), 24 deletions(-) commit 5e399a8a45bddb49e06e2ca39df1ed04398c0aff Author: Behdad Esfahbod Date: Wed Aug 29 10:40:49 2012 -0400 Minor src/hb-ot-layout-gsub-table.hh | 1 - src/hb-ot-layout-gsubgpos-private.hh | 1 - 2 files changed, 2 deletions(-) commit a177d027d1d0ad9539e30ed75d8652e0e8da20ff Author: Behdad Esfahbod Date: Tue Aug 28 23:18:22 2012 -0400 [GSUB] Move ligation logic over src/hb-ot-layout-gsub-table.hh | 78 ++++------------------------------- src/hb-ot-layout-gsubgpos-private.hh | 80 ++++++++++++++++++++++++++++++++++++ 2 files changed, 89 insertions(+), 69 deletions(-) commit 191fa885d9e0a2dce92dd8727cddd18495e62409 Author: Behdad Esfahbod Date: Tue Aug 28 22:58:55 2012 -0400 [GSUB] Merge Ligature and context input matching Looks better now... TODO | 4 -- src/hb-ot-layout-gsub-table.hh | 71 +++++++----------------------------- src/hb-ot-layout-gsubgpos-private.hh | 29 ++++++++++++++- 3 files changed, 40 insertions(+), 64 deletions(-) commit 93814ca7dc2a7251f861c1c47ba155ba6e6bdf19 Author: Behdad Esfahbod Date: Tue Aug 28 22:24:51 2012 -0400 Start converging Ligature and match_input src/hb-ot-layout-gsub-table.hh | 58 +++++++++++++++++---------------- src/hb-ot-layout-gsubgpos-private.hh | 62 ++++++++++++++++++++++++++++-------- 2 files changed, 78 insertions(+), 42 deletions(-) commit 2eef71737ea29ffadbb5a2be4a898b44f53f66ac Author: Behdad Esfahbod Date: Tue Aug 28 19:16:38 2012 -0400 [hb-icu-le] Add visbility src/hb-icu-le/FontTableCache.h | 6 +++++- src/hb-icu-le/PortableFontInstance.cpp | 39 ---------------------------------- src/hb-icu-le/PortableFontInstance.h | 7 ++++-- src/hb-icu-le/cmaps.cpp | 2 +- src/hb-icu-le/cmaps.h | 5 ++++- src/hb-icu-le/letest.h | 14 ++++++++++++ src/hb-icu-le/sfnt.h | 6 +++++- 7 files changed, 34 insertions(+), 45 deletions(-) commit d59e28e49204ed609d8a1bf3c0f21ab5fc178337 Author: Behdad Esfahbod Date: Tue Aug 28 19:08:36 2012 -0400 Minor src/Makefile.am | 6 +++++- src/check-libstdc++.sh | 2 +- src/check-static-inits.sh | 4 ++-- 3 files changed, 8 insertions(+), 4 deletions(-) commit af169d2813ff8075288cd4a7811f0715e4fea3da Author: Behdad Esfahbod Date: Tue Aug 28 19:08:22 2012 -0400 Minor src/hb-icu-le/PortableFontInstance.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 52ff2681d88886e2165ced397966ba29c2073583 Author: Behdad Esfahbod Date: Tue Aug 28 18:03:35 2012 -0400 Use VisualStudio-style atomic intrinsics on mingw32 src/hb-atomic-private.hh | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) commit 7c8e844d92aa604fc4b396343721ea90eb83adb8 Author: Behdad Esfahbod Date: Tue Aug 28 17:57:49 2012 -0400 Use namespace for OpenType tables Avoids USHORT, SHORT, ULONG, LONG clashes with Windows API. src/hb-font.cc | 12 ++--- src/hb-open-file-private.hh | 4 ++ src/hb-open-type-private.hh | 9 ++-- src/hb-ot-head-table.hh | 4 ++ src/hb-ot-hhea-table.hh | 5 ++ src/hb-ot-hmtx-table.hh | 6 +++ src/hb-ot-layout-common-private.hh | 5 ++ src/hb-ot-layout-gdef-table.hh | 4 ++ src/hb-ot-layout-gpos-table.hh | 4 ++ src/hb-ot-layout-gsub-table.hh | 4 ++ src/hb-ot-layout-gsubgpos-private.hh | 4 ++ src/hb-ot-layout-private.hh | 12 +++-- src/hb-ot-layout.cc | 91 ++++++++++++++++++------------------ src/hb-ot-maxp-table.hh | 4 ++ src/hb-ot-name-table.hh | 4 ++ src/hb-uniscribe.cc | 8 ++-- src/main.cc | 2 + 17 files changed, 117 insertions(+), 65 deletions(-) commit dc5df5af6b349c3d9e4ab876864d9dec8096401f Author: Behdad Esfahbod Date: Tue Aug 28 16:31:23 2012 -0400 Revert "Minor" This reverts commit 3e0a03978b91994bb7fa7922593cbdfc50878dfc. I know remember why that line is there :). src/hb-ot-shape-complex-arabic.cc | 1 + 1 file changed, 1 insertion(+) commit 3e0a03978b91994bb7fa7922593cbdfc50878dfc Author: Behdad Esfahbod Date: Mon Aug 27 17:10:02 2012 -0400 Minor src/hb-ot-shape-complex-arabic.cc | 1 - 1 file changed, 1 deletion(-) commit 667218a5b134728863a318c73070f4e323590bbd Author: Behdad Esfahbod Date: Mon Aug 27 17:00:44 2012 -0400 Minor src/hb-ot-shape-fallback.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit 30dd62251fcd04c2cbaa9b979d47ddbf62c6d460 Author: Behdad Esfahbod Date: Mon Aug 27 16:54:34 2012 -0400 Only fallback-position glyphs if we have the ccc Previously, ccc=0 Thai / Lao marks were being mispositioned. Don't touch them. src/hb-ot-shape-fallback.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e1ba62811a61afb046d349e578cd141363c7fb34 Author: Behdad Esfahbod Date: Mon Aug 27 16:28:05 2012 -0400 Center unknown marks horizontally src/hb-ot-shape-fallback.cc | 1 + 1 file changed, 1 insertion(+) commit a4e75e4128751bb902117abc1a59dce4f2147672 Author: Behdad Esfahbod Date: Mon Aug 27 15:54:15 2012 -0400 Minor test/shaping/hb_test_tools.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 23b0e9d7dc801e11640979af3c2b00649a519bb1 Author: Behdad Esfahbod Date: Sun Aug 26 14:30:18 2012 -0400 [Indic] Fix switch D'oh. Was working by pure chance :)). src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ae4d4e1de6b4512576080e95896383887b30982f Author: Behdad Esfahbod Date: Sun Aug 26 14:27:44 2012 -0400 Bug 53815 - CoreText backend doesn't link configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ec0e46376a2afec4ff7606f95582b0ec49c2a44a Author: Behdad Esfahbod Date: Fri Aug 24 00:44:53 2012 -0400 Remove TODO items TODO | 4 ---- 1 file changed, 4 deletions(-) commit 56e878ab875ff06d74702145e380e198be967bd6 Author: Behdad Esfahbod Date: Fri Aug 24 00:41:51 2012 -0400 [graphite2] Cleanup scratch buffer allocation src/hb-graphite2.cc | 77 ++++++++++++++++++++++++++++++----------------------- 1 file changed, 44 insertions(+), 33 deletions(-) commit 2f7586c6229096143ca0a96712a27416ee0d3c85 Author: Behdad Esfahbod Date: Thu Aug 23 23:59:55 2012 -0400 [icu-le] Implement icu layout engine shaper configure.ac | 2 +- src/hb-icu-le.cc | 113 +++++++++++++++++++++++++++++++++++++++++++++----- src/hb-icu-le/cmaps.h | 1 - src/hb-shaper-list.hh | 4 ++ 4 files changed, 108 insertions(+), 12 deletions(-) commit ba7f6c3797e5b440557bacd9b666bf09713dca76 Author: Behdad Esfahbod Date: Thu Aug 23 21:52:44 2012 -0400 [icu-le] Hook up to hb_face_t src/hb-icu-le.cc | 17 +++- src/hb-icu-le/FontTableCache.cpp | 34 ++++---- src/hb-icu-le/FontTableCache.h | 9 ++- src/hb-icu-le/PortableFontInstance.cpp | 144 +++------------------------------ src/hb-icu-le/PortableFontInstance.h | 21 ++--- src/hb-icu-le/README | 1 + 6 files changed, 57 insertions(+), 169 deletions(-) commit e96bb36995b2a5321b4d32bb11906e1701aaf115 Author: Behdad Esfahbod Date: Thu Aug 23 21:37:51 2012 -0400 [icu-le] Actually use the FontTableCache src/hb-icu-le/PortableFontInstance.cpp | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) commit 7d242364ea647f655a7092bda25f9a10774c57f5 Author: Behdad Esfahbod Date: Thu Aug 23 21:23:41 2012 -0400 [icu-le] Start adding a icu-layout-engine backend Import PortableFontInstance and add shaper stub. configure.ac | 9 + src/Makefile.am | 8 + src/hb-icu-le.cc | 111 ++++++++ src/hb-icu-le/FontTableCache.cpp | 91 +++++++ src/hb-icu-le/FontTableCache.h | 41 +++ src/hb-icu-le/Makefile.am | 25 ++ src/hb-icu-le/PortableFontInstance.cpp | 436 ++++++++++++++++++++++++++++++++ src/hb-icu-le/PortableFontInstance.h | 117 +++++++++ src/hb-icu-le/README | 2 + src/hb-icu-le/cmaps.cpp | 200 +++++++++++++++ src/hb-icu-le/cmaps.h | 85 +++++++ src/hb-icu-le/letest.h | 49 ++++ src/hb-icu-le/license.html | 51 ++++ src/hb-icu-le/sfnt.h | 449 +++++++++++++++++++++++++++++++++ 14 files changed, 1674 insertions(+) commit b5584ee4be46b47e1678acf28426970a6d670b4f Author: Behdad Esfahbod Date: Thu Aug 23 16:26:07 2012 -0400 [Indic] For old-spec, match non-zero context Fixes consonant-position with old-spec Malayalam. Uniscribe seem to be doing this. Fixes below-base La (eg. Pa,H,La) with AnjaliNewLipi.ttf. Doesn't regress new-spec or other scripts. src/hb-ot-shape-complex-indic.cc | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) commit d9b204d3d24cde165167714728bf380267903d6a Author: Behdad Esfahbod Date: Thu Aug 23 16:22:28 2012 -0400 [GSUB] Allow non-zero-context matching in would_apply() To be used in the next patch. src/hb-ot-layout-gsubgpos-private.hh | 6 ++++-- src/hb-ot-layout-private.hh | 3 ++- src/hb-ot-layout.cc | 14 ++++++++------ src/hb-ot-layout.h | 7 ++++--- src/hb-ot-map.cc | 12 ++---------- src/hb-ot-shape-complex-indic.cc | 2 +- src/test-would-substitute.cc | 2 +- 7 files changed, 22 insertions(+), 24 deletions(-) commit 1f2bb172fe9a173ecfd61054f1fdd850943ef059 Author: Behdad Esfahbod Date: Thu Aug 23 16:10:37 2012 -0400 Revert "[Indic/GSUB] Ignore context when matching would_apply()" This reverts commit 24dd4e56743c6ce5e01cb710ca9e01b3e527af58. Oops. My bad. The change _regressed_ Malayalam test suite, not improved it. I'll redo it, differentiating between old-spec and new-spec cases. src/hb-ot-layout-gsubgpos-private.hh | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) commit 24dd4e56743c6ce5e01cb710ca9e01b3e527af58 Author: Behdad Esfahbod Date: Thu Aug 23 15:47:10 2012 -0400 [Indic/GSUB] Ignore context when matching would_apply() The MS Indic specs say "...all classifications are determined ... using context-free substitutions." However, testing shows that MS's Malayalam shapers (both old and new), "match" even if there is no zero-context rule. We follow. Fixes below-base La (eg. Pa,H,La) with AnjaliNewLipi.ttf (old spec). Moreover, test suite Malayalam failures are down to 312 from 875! No change in other scripts. Current numbers: BENGALI: 353996 out of 354285 tests passed. 289 failed (0.0815727%) DEVANAGARI: 707339 out of 707394 tests passed. 55 failed (0.00777502%) GUJARATI: 366489 out of 366506 tests passed. 17 failed (0.0046384%) GURMUKHI: 60769 out of 60809 tests passed. 40 failed (0.0657797%) KANNADA: 951086 out of 951913 tests passed. 827 failed (0.0868777%) KHMER: 299106 out of 299124 tests passed. 18 failed (0.00601757%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1047541 out of 1048416 tests passed. 875 failed (0.0834592%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271726 out of 271847 tests passed. 121 failed (0.0445103%) TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%) TELUGU: 970558 out of 970573 tests passed. 15 failed (0.00154548%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%) src/hb-ot-layout-gsubgpos-private.hh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 6732d62e78b13842ead9549c97bede25c73976cb Author: Behdad Esfahbod Date: Thu Aug 23 15:19:45 2012 -0400 [Indic] Implement pre-base reordering Ra for old-spec Malayalam Fixes Pa,H,Ra sequence with AnjaliNewLipi.ttf. src/hb-ot-shape-complex-indic.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 80cd92326f8a3f48a7821e720e8ecb2072e73286 Author: Behdad Esfahbod Date: Thu Aug 23 12:06:14 2012 -0400 [Indic] Only apply basic features per-syllable Free up syllables and let features work across syllables for the presentation forms features and GPOS. Fixed: - 1 GURMUKHI test (remains 40) - 12 KHMER tests (remains 18) - 11 SINHALA tests (remains 121) Regresses: - 5 MALAYALAM tests (up to 312) Current numbers: BENGALI: 353996 out of 354285 tests passed. 289 failed (0.0815727%) DEVANAGARI: 707339 out of 707394 tests passed. 55 failed (0.00777502%) GUJARATI: 366489 out of 366506 tests passed. 17 failed (0.0046384%) GURMUKHI: 60769 out of 60809 tests passed. 40 failed (0.0657797%) KANNADA: 951086 out of 951913 tests passed. 827 failed (0.0868777%) KHMER: 299106 out of 299124 tests passed. 18 failed (0.00601757%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1048104 out of 1048416 tests passed. 312 failed (0.0297592%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271726 out of 271847 tests passed. 121 failed (0.0445103%) TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%) TELUGU: 970558 out of 970573 tests passed. 15 failed (0.00154548%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%) src/hb-ot-shape-complex-indic.cc | 4 ++++ 1 file changed, 4 insertions(+) commit df5d5c68f3a5cab17bf4a429802a1a1a834c3456 Author: Behdad Esfahbod Date: Thu Aug 23 09:33:30 2012 -0400 Whitespace src/hb-ot-layout-gpos-table.hh | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) commit 7fe00d15da20193ca94a8ead9aee60df24074a9e Author: Behdad Esfahbod Date: Sat Aug 18 13:59:46 2012 -0400 Release 0.9.3 NEWS | 16 ++++++++++++++++ configure.ac | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) commit 7068e534c4ef7ed2eb7ef8e1370fd4a449556ce8 Author: Behdad Esfahbod Date: Sat Aug 18 13:56:10 2012 -0400 Fix ChangeLog generation rule Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2f1747ed7d28148807ad07eb8e22db3ab5c54966 Author: Behdad Esfahbod Date: Thu Aug 16 11:46:46 2012 -0400 Add comment src/hb-ot-shape-complex-arabic.cc | 4 ++++ 1 file changed, 4 insertions(+) commit bd08d5d126aa878d1dbf7bfd4b1a764c170cd9ad Author: Behdad Esfahbod Date: Thu Aug 16 11:35:50 2012 -0400 [OT] Fix Arabic shaper OOB access https://bugzilla.mozilla.org/show_bug.cgi?id=782908 src/hb-ot-shape-complex-arabic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b161bfc4f6f2db0edea780b95b798ff7b559cf33 Author: Behdad Esfahbod Date: Thu Aug 16 08:09:44 2012 -0400 [configure] Cleanup check for ICU Check for upstream-provided 'icu-uc' pkgconfig package. configure.ac | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) commit daf0731865f91da960446928667d4095bde471ea Author: Behdad Esfahbod Date: Thu Aug 16 07:32:59 2012 -0400 [ICU] Fix includes As reported by Steven Loomis, including uversion.h works everywhere. src/hb-icu.cc | 6 ------ 1 file changed, 6 deletions(-) commit a67ba9c0fe6798a3500af9f4acee8d678f5144ee Author: Behdad Esfahbod Date: Wed Aug 15 18:52:17 2012 -0400 Whitespace src/hb-old/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 9fe76051f7003d6b6a10486c5595bf1a4dbf5fe6 Author: Behdad Esfahbod Date: Wed Aug 15 17:24:28 2012 -0400 [NEWS] Fix date Oops! NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 45c1383cc7315f89c23c0ed388b99e87224884e7 Author: Behdad Esfahbod Date: Tue Aug 14 09:33:18 2012 -0400 Minor src/hb-coretext.cc | 8 ++++---- src/hb-fallback-shape.cc | 8 ++++---- src/hb-graphite2.cc | 8 ++++---- src/hb-uniscribe.cc | 8 ++++---- 4 files changed, 16 insertions(+), 16 deletions(-) commit 4ac4c6f2e12ddc8bf5e750671321458218b6e0c8 Author: Behdad Esfahbod Date: Mon Aug 13 10:52:52 2012 -0400 Fix ICU build with older ICUs src/hb-icu.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit 883cbf5ed79d2b60191f803a5ee3f3e4496f3441 Author: Behdad Esfahbod Date: Sun Aug 12 17:11:27 2012 -0400 Minor contrib/README | 2 ++ 1 file changed, 2 insertions(+) commit b7a4d37d0b162f2222b65d09b9271b8c636086f8 Author: Behdad Esfahbod Date: Sat Aug 11 21:32:23 2012 -0400 minor configure.ac | 2 ++ 1 file changed, 2 insertions(+) commit d5045a5f4017631a4660f985fe451c5a64c42ca0 Author: Behdad Esfahbod Date: Sat Aug 11 21:26:25 2012 -0400 [ICU] Use new normalizer2 compose/decompose API It's considerably faster than the fallback implementation we had previously! src/hb-buffer.cc | 9 +++--- src/hb-glib.cc | 26 +++++++--------- src/hb-icu.cc | 75 +++++++++++++++++++++++++++++++++++++---------- src/hb-unicode-private.hh | 13 ++------ src/hb-unicode.cc | 35 ++++++++++++++++++++-- src/hb-warning.cc | 8 ----- 6 files changed, 110 insertions(+), 56 deletions(-) commit 2b73a1f112c489c2553743c08dc03cd89f60cb2d Author: Behdad Esfahbod Date: Sat Aug 11 19:17:54 2012 -0400 Add TODO TODO | 1 + 1 file changed, 1 insertion(+) commit 9f9f04c2229227bb0712166e824157bbbf5cef80 Author: Behdad Esfahbod Date: Sat Aug 11 18:34:13 2012 -0400 [OT] Unbreak Thai shaping and fallback Arabic shaping The merger of normalizer and glyph-mapping broke shapers that modified text stream. Unbreak them by adding a new preprocess_text shaping stage that happens before normalizing/cmap and disallow setup_mask modification of actual text. src/hb-ot-shape-complex-arabic.cc | 42 ++++++++++++++++++++++++++++---------- src/hb-ot-shape-complex-indic.cc | 1 + src/hb-ot-shape-complex-misc.cc | 12 ++++++----- src/hb-ot-shape-complex-private.hh | 15 +++++++++++--- src/hb-ot-shape.cc | 3 +++ 5 files changed, 54 insertions(+), 19 deletions(-) commit e9f28a38f54b98fa59f9159ccaaa3be6027e1378 Author: Behdad Esfahbod Date: Sat Aug 11 18:20:28 2012 -0400 [OT] Add shape_plan to Arabic shaper src/hb-ot-shape-complex-arabic.cc | 82 +++++++++++++++++++++++++-------------- 1 file changed, 53 insertions(+), 29 deletions(-) commit 344cc56698a8c84c4c1a05a71d829e5171aa3a60 Author: Behdad Esfahbod Date: Sat Aug 11 17:36:23 2012 -0400 Add TODO TODO | 4 ++++ 1 file changed, 4 insertions(+) commit daf13afb0801740dcc7900c4af190e24b80a05c0 Author: Behdad Esfahbod Date: Fri Aug 10 16:38:44 2012 -0400 [OT] Implement fallback mark positioning for "double" combining marks src/hb-ot-shape-fallback.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) commit d345313104d9e3c8a8533ccdebd74e0648d0bee3 Author: Behdad Esfahbod Date: Fri Aug 10 16:34:04 2012 -0400 [OT] Fix fallback mark positioning with left-to-right text Ouch! src/hb-ot-shape-fallback.cc | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) commit e297ee4acd6f9d950f8542fc6ad71fd580b69284 Author: Behdad Esfahbod Date: Fri Aug 10 14:49:37 2012 -0400 Bump version to 0.9.2 A *real* release this time, with NEWS, ChangeLog, etc. AUTHORS | 8 ++++ COPYING | 9 ++-- Makefile.am | 13 +++--- NEWS | 136 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ THANKS | 7 +++ configure.ac | 4 +- 6 files changed, 165 insertions(+), 12 deletions(-) commit 6efe1200b97cefe019857b0b5951a4a87deeb02b Author: Behdad Esfahbod Date: Fri Aug 10 13:49:32 2012 -0400 Bump version to 0.9.1 configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 206ab6057303273590a3d005660e075bdcee0f5f Author: Behdad Esfahbod Date: Fri Aug 10 09:06:30 2012 -0400 [test] Move around test/shaping/texts/in-tree/shaper-arabic/script-arabic/MANIFEST | 2 +- .../texts/in-tree/shaper-arabic/script-arabic/language-urdu/MANIFEST | 1 + .../shaper-arabic/script-arabic/{ => language-urdu}/crulp/MANIFEST | 0 .../script-arabic/{ => language-urdu}/crulp/ligatures/2grams.txt | 0 .../script-arabic/{ => language-urdu}/crulp/ligatures/3grams.txt | 0 .../script-arabic/{ => language-urdu}/crulp/ligatures/4grams.txt | 0 .../script-arabic/{ => language-urdu}/crulp/ligatures/5grams.txt | 0 .../script-arabic/{ => language-urdu}/crulp/ligatures/6grams.txt | 0 .../script-arabic/{ => language-urdu}/crulp/ligatures/7grams.txt | 0 .../script-arabic/{ => language-urdu}/crulp/ligatures/8grams.txt | 0 .../script-arabic/{ => language-urdu}/crulp/ligatures/LICENSE | 0 .../script-arabic/{ => language-urdu}/crulp/ligatures/MANIFEST | 0 .../script-arabic/{ => language-urdu}/crulp/ligatures/README | 0 .../script-arabic/{ => language-urdu}/crulp/ligatures/SOURCES | 0 14 files changed, 2 insertions(+), 1 deletion(-) commit 7a484c601e0958533eb85a6902296733c39537fe Author: Behdad Esfahbod Date: Fri Aug 10 09:05:29 2012 -0400 [test] Add Urdu ligature sequences from CRULP .../in-tree/shaper-arabic/script-arabic/MANIFEST | 1 + .../shaper-arabic/script-arabic/crulp/MANIFEST | 1 + .../script-arabic/crulp/ligatures/2grams.txt | 601 ++ .../script-arabic/crulp/ligatures/3grams.txt | 3415 +++++++++++ .../script-arabic/crulp/ligatures/4grams.txt | 6316 ++++++++++++++++++++ .../script-arabic/crulp/ligatures/5grams.txt | 5029 ++++++++++++++++ .../script-arabic/crulp/ligatures/6grams.txt | 1542 +++++ .../script-arabic/crulp/ligatures/7grams.txt | 354 ++ .../script-arabic/crulp/ligatures/8grams.txt | 26 + .../script-arabic/crulp/ligatures/LICENSE | 3 + .../script-arabic/crulp/ligatures/MANIFEST | 7 + .../script-arabic/crulp/ligatures/README | 16 + .../script-arabic/crulp/ligatures/SOURCES | 4 + 13 files changed, 17315 insertions(+) commit f4cb4762986a28634fa7de9b706f9d37859b881e Author: Behdad Esfahbod Date: Fri Aug 10 03:51:44 2012 -0400 [OT] Slightly adjust normalizer The change is very subtle. If we have a single-char cluster that decomposes to three or more characters, then try recomposition, in case the farther mark may compose with the base. src/hb-ot-shape-normalize.cc | 81 +++++++++++++++++++++++++++++--------------- 1 file changed, 54 insertions(+), 27 deletions(-) commit 07d682806349aee81f53114778ce0beb23909ed7 Author: Behdad Esfahbod Date: Fri Aug 10 03:28:50 2012 -0400 Minor src/hb-ot-shape-normalize.cc | 25 ++++++++----------------- src/hb-ot-shape.cc | 2 +- 2 files changed, 9 insertions(+), 18 deletions(-) commit b00321ea78793d9b3592b5173a9800e6322424fe Author: Behdad Esfahbod Date: Thu Aug 9 22:33:32 2012 -0400 [OT] Avoid calling get_glyph() twice Essentially move the glyph mapping to normalization process. The effect on Devanagari is small (but observable). Should be more observable in simple text, like ASCII. src/hb-ot-shape-normalize-private.hh | 2 + src/hb-ot-shape-normalize.cc | 76 +++++++++++++++++++++++++----------- src/hb-ot-shape.cc | 44 ++++++++++----------- 3 files changed, 77 insertions(+), 45 deletions(-) commit 12c0875eafa4bd92db650e5acca046d99594d1e6 Author: Behdad Esfahbod Date: Thu Aug 9 22:00:53 2012 -0400 [OT] Remove redundant check src/hb-ot-shape.cc | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit 5c60b70c89b4e0a6512d9fd1ab5394dd76feb742 Author: Behdad Esfahbod Date: Thu Aug 9 21:58:07 2012 -0400 [OT] More code shuffling around Preparing for merging map_glyphs() and normalize(). src/hb-ot-shape.cc | 167 +++++++++++++++++++++++++++-------------------------- 1 file changed, 86 insertions(+), 81 deletions(-) commit cd0c6e148f6d078b364370cb2f808b793b921be2 Author: Behdad Esfahbod Date: Thu Aug 9 21:48:55 2012 -0400 Shuffle buffer variable allocations around To room for more allocations, coming. src/hb-ot-layout-private.hh | 6 +++--- src/hb-ot-shape-complex-arabic.cc | 2 +- src/hb-ot-shape-complex-indic-private.hh | 4 ++-- src/hb-ot-shape-complex-private.hh | 5 ++--- src/hb-ot-shape-private.hh | 4 ++-- 5 files changed, 10 insertions(+), 11 deletions(-) commit 8d1eef3f32fb539de2a72804fa3834acc18daab5 Author: Behdad Esfahbod Date: Thu Aug 9 21:31:52 2012 -0400 Minor src/hb-ot-shape-normalize.cc | 50 +++++++++++++++++++++++++++----------------- 1 file changed, 31 insertions(+), 19 deletions(-) commit 56c9e7c004e802ddcb8c704346026f1d7a812f9f Author: Behdad Esfahbod Date: Thu Aug 9 21:12:30 2012 -0400 Fill out combining class resetting for fallback shaping Thai/Lao/Tibetan src/hb-ot-shape-fallback.cc | 38 +++++++++++++++++++++++++++++++++++++- src/hb-unicode-private.hh | 7 ++++--- src/hb-unicode.cc | 2 +- 3 files changed, 42 insertions(+), 5 deletions(-) commit a321e1d51e0e7fa02738410e8d6e77c841bc6b13 Author: Behdad Esfahbod Date: Thu Aug 9 18:30:34 2012 -0400 Revert "Reject lookups with no subTable" This reverts commit 30ec9002d84e8b49290e782e6192069821ffa942. See previous commit. src/hb-ot-layout-common-private.hh | 1 - 1 file changed, 1 deletion(-) commit 2eaf482b371034ce6ebfaedee98049b036fd3493 Author: Behdad Esfahbod Date: Thu Aug 9 18:30:05 2012 -0400 Revert "[GSUB/GPOS] Reject Context/ChainContext lookups with zero input" This reverts commit 0981068b75710397f08e0d2d776a0a2ea68d7117. I was confused. Even if we access coverage[0] unconditionally, we don't need bound checks since the array machinary already handles that. src/hb-ot-layout-gsubgpos-private.hh | 2 -- 1 file changed, 2 deletions(-) commit a02d86484be870615297abfc7be9f94645434762 Author: Behdad Esfahbod Date: Wed Aug 8 18:04:29 2012 -0400 Add check-exported-symbols.sh And misc linking fixes. src/Makefile.am | 1 + src/check-exported-symbols.sh | 40 ++++++++++++++++++++++++++++++++++++++++ src/check-internal-symbols.sh | 2 +- src/hb-ot-shape-complex-indic.cc | 2 +- src/hb-ot-shape.cc | 6 +++--- 5 files changed, 46 insertions(+), 5 deletions(-) commit 4c8ac4f47e95d2b266b2f64e75c55af8233b6b91 Author: Behdad Esfahbod Date: Wed Aug 8 17:44:19 2012 -0400 Misc minor fixes src/check-internal-symbols.sh | 10 +-- src/hb-font-private.hh | 29 +++++++- src/hb-font.cc | 63 +++++++--------- src/hb-font.h | 2 +- src/hb-graphite2.cc | 4 +- src/hb-old.cc | 2 +- src/hb-ot-layout.cc | 6 +- src/hb-ot-shape-fallback.cc | 10 +-- src/hb-ot-shape.cc | 2 +- src/hb-shape-plan.cc | 2 +- src/hb-shape-plan.h | 2 +- src/hb-tt-font.cc | 166 +----------------------------------------- 12 files changed, 72 insertions(+), 226 deletions(-) commit 560d68af8168d1baff607b9616a3590af70fe9ec Author: Behdad Esfahbod Date: Wed Aug 8 17:16:01 2012 -0400 Use a export-file for Windows builds Apparently even that doesn't make check-internal-symbols.sh happy with mingw32. Going to disable that for DLLs again, but hopefully the export-file is doing *something*. configure.ac | 14 +++++++++++++- src/Makefile.am | 22 +++++++++++++++++++++- src/hb-buffer.h | 4 ++-- 3 files changed, 36 insertions(+), 4 deletions(-) commit f8751cf8e0a16125d63a88da65fdbfa76a19453f Author: Behdad Esfahbod Date: Wed Aug 8 17:15:44 2012 -0400 [hb-old] speed-up build src/hb-old/harfbuzz-external.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 5f4c52867ce67faa15f5d26b59c18c8d068e9261 Author: Behdad Esfahbod Date: Wed Aug 8 16:53:37 2012 -0400 Minor src/hb-ot-layout.h | 1 - 1 file changed, 1 deletion(-) commit fe2b8a7777ab1c84980424ede713cb0d6701f987 Author: Behdad Esfahbod Date: Wed Aug 8 15:27:14 2012 -0400 Minor TODO | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 7e7d245b332306949a19c628bacd920717434769 Author: Behdad Esfahbod Date: Wed Aug 8 15:23:48 2012 -0400 Make default_language threadsafe src/hb-common.cc | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) commit 06b192c458010c847362d809673209c87ea29949 Author: Behdad Esfahbod Date: Wed Aug 8 15:23:45 2012 -0400 Minor src/hb-common.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 37191ede7583fdb864db32a8f4d90956657926c7 Author: Behdad Esfahbod Date: Wed Aug 8 14:59:09 2012 -0400 Minor src/hb-common.h | 4 ++-- src/hb-icu.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) commit 6d9a329a8a0f11f4b175e407de59c55924de1ef6 Author: Behdad Esfahbod Date: Wed Aug 8 14:48:41 2012 -0400 Adjust a couple source checks src/check-internal-symbols.sh | 4 ++-- src/check-static-inits.sh | 10 ++++++++-- 2 files changed, 10 insertions(+), 4 deletions(-) commit 9c929abdcfef44c0193a2917b20981df37ade21c Author: Behdad Esfahbod Date: Wed Aug 8 14:33:37 2012 -0400 Minor renaming src/Makefile.am | 4 ++-- ...sition-fallback-private.hh => hb-ot-shape-fallback-private.hh} | 8 ++++---- src/{hb-ot-shape-position-fallback.cc => hb-ot-shape-fallback.cc} | 4 ++-- src/hb-ot-shape.cc | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) commit 801298b590effd768607bb532dc83c73ba65d16b Author: Behdad Esfahbod Date: Wed Aug 8 14:26:36 2012 -0400 Fix cast https://bugs.freedesktop.org/show_bug.cgi?id=53233 src/hb-buffer-private.hh | 10 ++++++---- src/hb-shape-plan.cc | 4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-) commit 21756934a15e31dc243e2b6d80adec5752477652 Author: Behdad Esfahbod Date: Wed Aug 8 01:20:45 2012 -0400 [OT] Implement fallback positioning Implemented for Arabic, Hebrew, and generic marks. Activated if no GPOS table present. src/hb-font.h | 3 +- src/hb-ft.cc | 3 +- src/hb-old.cc | 2 +- src/hb-ot-shape-position-fallback.cc | 237 ++++++++++++++++++++++++++++++++++- src/hb-unicode-private.hh | 81 ++++++++++++ src/hb-unicode.cc | 107 ++++++---------- 6 files changed, 356 insertions(+), 77 deletions(-) commit fb56e7628362a73e20f7f0b49fe31e802dc01f4f Author: Behdad Esfahbod Date: Tue Aug 7 23:44:47 2012 -0400 [hb-old] Fix warnings src/hb-old/harfbuzz-shaper.cpp | 2 ++ 1 file changed, 2 insertions(+) commit affaf8a0e5aa38e5820455f789eebf916e02eb7b Author: Behdad Esfahbod Date: Tue Aug 7 22:41:38 2012 -0400 [OT] Start adding fallback positioning Used when there is no GPOS. src/Makefile.am | 2 ++ src/hb-ot-shape-position-fallback-private.hh | 39 +++++++++++++++++++++++ src/hb-ot-shape-position-fallback.cc | 47 ++++++++++++++++++++++++++++ src/hb-ot-shape.cc | 23 +++----------- 4 files changed, 93 insertions(+), 18 deletions(-) commit 7e4920fd1577987bf6804f67765e22a84983e057 Author: Behdad Esfahbod Date: Tue Aug 7 22:32:23 2012 -0400 Minor src/hb-ot-shape.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 472f229a63f0d1bb21b02179ef430b7698df8f12 Author: Behdad Esfahbod Date: Tue Aug 7 22:25:24 2012 -0400 [GSUB] Generalize would_apply() Fixes logic also, where before we were always matching if glyphs_len==1 and a ligature started with the glyph. src/hb-ot-layout-gsub-table.hh | 26 ++++++++++++++++++++----- src/hb-ot-layout-gsubgpos-private.hh | 37 ++++++++++++++++++------------------ src/hb-ot-layout.cc | 3 +-- 3 files changed, 40 insertions(+), 26 deletions(-) commit 6f3a300138f659020c21c3e08b7981c78df5f332 Author: Behdad Esfahbod Date: Tue Aug 7 22:13:25 2012 -0400 Add hb_font_glyph_from/to_string src/hb-font-private.hh | 43 +++++++++++++++++++++++++++++++++++++++++++ src/hb-font.cc | 24 ++++++++++++++++++++---- src/hb-font.h | 11 +++++++++++ src/hb-private.hh | 16 ++++++++++++++++ src/test-would-substitute.cc | 11 ++++++++++- util/options.cc | 2 +- 6 files changed, 101 insertions(+), 6 deletions(-) commit eb56f6ae96260c5b4bcd4e1dfb7ab733a230f3a8 Author: Behdad Esfahbod Date: Tue Aug 7 21:44:25 2012 -0400 Minor src/hb-mutex-private.hh | 1 + src/hb-uniscribe.cc | 1 + src/hb-uniscribe.h | 2 ++ 3 files changed, 4 insertions(+) commit f4e48adcdd4315ce09e755f87a0f801d88194f42 Author: Behdad Esfahbod Date: Tue Aug 7 21:12:49 2012 -0400 [OT] Apply 'rclt' feature in horizontal mode 'rclt' is "Required Contextual Forms" being proposed by Microsoft. It's like 'calt', but supposedly always on. We apply 'calt' anyway, and now apply this too. src/hb-ot-shape.cc | 1 + 1 file changed, 1 insertion(+) commit b1914b8bd08ecdea79930dda7e3bb2ae9e6134a1 Author: Behdad Esfahbod Date: Tue Aug 7 16:57:48 2012 -0400 Fix warnings src/hb-icu.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 0f8881d6bbf6cd59938315eeff9b71cfc736aa4e Author: Behdad Esfahbod Date: Tue Aug 7 16:57:02 2012 -0400 More refactoring src/hb-ot-shape-normalize.cc | 161 +++++++++++++++++++++++++++++++++++++++++- src/hb-unicode-private.hh | 164 +------------------------------------------ 2 files changed, 162 insertions(+), 163 deletions(-) commit 428dfcab6634ff264570a0a5d715efb8048c3db5 Author: Behdad Esfahbod Date: Tue Aug 7 16:51:48 2012 -0400 Minor refactoring src/hb-ot-shape-normalize.cc | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) commit 61f41849af6ff9edf8b55cf9610066d1bfb4a8df Author: Behdad Esfahbod Date: Tue Aug 7 16:45:27 2012 -0400 Add Hebrew presentation forms shaping Lifted from https://bugzilla.mozilla.org/show_bug.cgi?id=728866 src/hb-unicode-private.hh | 121 +++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 120 insertions(+), 1 deletion(-) commit 32d71dc13317b322e2c5de00d767b2cb15fddd8b Author: Behdad Esfahbod Date: Tue Aug 7 14:11:16 2012 -0400 [Graphite] Minor src/hb-graphite2.cc | 60 +++++++++++++++++++++++++---------------------------- 1 file changed, 28 insertions(+), 32 deletions(-) commit 030ac5022e8a43b9329c26e72527bafc582ef44b Author: Behdad Esfahbod Date: Tue Aug 7 13:01:12 2012 -0400 Remove enum trailing comma ...again. src/hb-ot-shape-normalize-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 368b4e7649f9bc8c6bebf7c7ff03c9b9ec425a25 Author: Behdad Esfahbod Date: Mon Aug 6 23:06:04 2012 -0400 Minor src/hb-font.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit ade7459ea7c75b4f33f7cfa43dd5bdfa0c18d6d5 Author: Behdad Esfahbod Date: Mon Aug 6 19:42:47 2012 -0700 [util] Fix leaks src/hb-graphite2.cc | 18 ++++++++++++++---- util/options.cc | 2 +- util/options.hh | 2 +- 3 files changed, 16 insertions(+), 6 deletions(-) commit 2fef993460dcfd94c92ab35413bdde18ad2b0ceb Author: Behdad Esfahbod Date: Mon Aug 6 19:35:04 2012 -0700 [Graphite] Fix graphite2 backend with RTL text Patch from Martin Hosken. src/hb-graphite2.cc | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) commit e4992e13e19877a73ea05fc1d31005a262c685ad Author: Behdad Esfahbod Date: Mon Aug 6 19:25:39 2012 -0700 [Graphite] Port graphite2 backend to new shaper infrastructure src/hb-graphite2.cc | 234 +++++++++++++++++++++++--------------------------- src/hb-graphite2.h | 2 +- src/hb-shaper-list.hh | 2 +- 3 files changed, 109 insertions(+), 129 deletions(-) commit 66591ececfba9791de06c814f5f30131e95e5fd2 Author: Behdad Esfahbod Date: Mon Aug 6 17:07:19 2012 -0700 Remove unnecessary lifecycle bits We already set recount to INVALID when destroying. This block was not necessary. src/hb-font.cc | 3 --- 1 file changed, 3 deletions(-) commit e3320ecc1b5a7eaccc7c9370b2d1b76850f054be Author: Behdad Esfahbod Date: Mon Aug 6 11:44:10 2012 -0700 Fix compiler warnings configure.ac | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) commit 167b625d988b74572d6b2f646c285b666b650d49 Author: Behdad Esfahbod Date: Sun Aug 5 21:16:26 2012 -0700 [Indic] Minor, move 'blwf' after 'half' We don't apply them together anyway. Should not make any difference right now. src/hb-ot-shape-complex-indic.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 048e3b596fb7fccd3fb5f48de98b6b67788f774a Author: Behdad Esfahbod Date: Sat Aug 4 18:04:57 2012 -0700 Speed up hb_set_digest_lowest_bits_t calcs src/hb-set-private.hh | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) commit 3d1b66a35e1ab3be19335705f310b278d76d66d2 Author: Behdad Esfahbod Date: Sat Aug 4 17:42:28 2012 -0700 Speed up hb_set_digest_common_bits_t calcs src/hb-set-private.hh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit bdc48a879a1900138d8caaa8d90fb9fe1e768d1d Author: Behdad Esfahbod Date: Sat Aug 4 17:08:38 2012 -0700 Enlarge glyph_name buffer Lohit Devanagari has a glyph named: u0924_u094D.half_u0930_u094D.blwf.vatu util/options.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 25326c2359b0a3e25222b94acd142bc36eff78a4 Author: Behdad Esfahbod Date: Sat Aug 4 16:43:18 2012 -0700 Rewrite ARRAY_LENGTH as a template function Such it wouldn't apply to pointers accidentally. src/hb-ot-shape-complex-arabic-table.hh | 4 ++-- src/hb-private.hh | 9 ++++++--- 2 files changed, 8 insertions(+), 5 deletions(-) commit 8ba8042821e4581fe4e87419e58c823520441205 Author: Behdad Esfahbod Date: Fri Aug 3 18:54:54 2012 -0700 [Indic] Fix consonant position font lookup logic Oops. I broken this badly and the test suite did not notice. That worries me. Have to investigate. src/hb-ot-shape-complex-indic.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit abd0c05f1f7f0546593bb2f1c4d59db12cb32e46 Author: Behdad Esfahbod Date: Fri Aug 3 18:45:05 2012 -0700 Minor src/test-would-substitute.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 46ee108ef80f5d4675899862698a8c34d8fcfab5 Author: Behdad Esfahbod Date: Fri Aug 3 18:21:13 2012 -0700 Fix leak src/hb-shape-plan.cc | 2 ++ 1 file changed, 2 insertions(+) commit 71baea0062da4d7f143d62da38492a0813814e49 Author: Behdad Esfahbod Date: Fri Aug 3 17:40:07 2012 -0700 [OT] Use general-category, not GDEF class, to decide to zero mark advances At this point, the GDEF glyph synthesis looks pointless. Not that I have many fonts without GDEF lying around. As for mark advance zeroing when GPOS not available, that also is being replaced by proper fallback mark positioning soon. src/hb-ot-shape.cc | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) commit 3a7e137a68ec8f723dc3afa89c918ca2df7ff6bf Author: Behdad Esfahbod Date: Fri Aug 3 17:23:40 2012 -0700 Dn't use gint src/hb-glib.cc | 4 ++-- src/hb-icu.cc | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) commit 11b0e20ba42bf0b17133c3e1087732802bb4f230 Author: Behdad Esfahbod Date: Thu Aug 2 14:21:40 2012 -0400 [Indic] Add per-script configuration tables This concludes the Indic shape_plan work. May do for Arabic also... src/hb-ot-shape-complex-indic-private.hh | 16 +- src/hb-ot-shape-complex-indic.cc | 309 +++++++++++++++---------------- 2 files changed, 159 insertions(+), 166 deletions(-) commit 85fc6c483f6d734febbe39270e84701a651f01f1 Author: Behdad Esfahbod Date: Thu Aug 2 12:21:44 2012 -0400 [Indic] Move more stuff to the shape_plan Almost done. Need to add per-script static tables. src/hb-ot-shape-complex-indic-machine.rl | 4 +- src/hb-ot-shape-complex-indic.cc | 216 ++++++++++++++++--------------- 2 files changed, 116 insertions(+), 104 deletions(-) commit 914ffaa40fcca020f65bacdd709421e9047afd83 Author: Behdad Esfahbod Date: Thu Aug 2 11:03:39 2012 -0400 [Indic] Move more repeated work into shape_plan src/hb-ot-shape-complex-indic.cc | 63 ++++++++++++++++++++++++++-------------- 1 file changed, 42 insertions(+), 21 deletions(-) commit a8c6da90f4c6e8d27a3a1b758a55476776d9f750 Author: Behdad Esfahbod Date: Thu Aug 2 10:46:34 2012 -0400 [OT] Add per-complex-shaper shape_plan data Hookup some Indic data to it. More to come. src/hb-ot-shape-complex-arabic.cc | 2 + src/hb-ot-shape-complex-indic.cc | 128 ++++++++++++++++++++++--------------- src/hb-ot-shape-complex-misc.cc | 4 ++ src/hb-ot-shape-complex-private.hh | 16 ++++- src/hb-ot-shape-private.hh | 1 + src/hb-ot-shape.cc | 23 +++++-- 6 files changed, 113 insertions(+), 61 deletions(-) commit 8bb5deba9630d35878eb6edb4643ecfabf99f15f Author: Behdad Esfahbod Date: Thu Aug 2 10:07:58 2012 -0400 [OT] Pipe shape_plan down to pause_callbacks src/hb-ot-map-private.hh | 8 ++--- src/hb-ot-map.cc | 11 ++++--- src/hb-ot-shape-complex-indic-machine.rl | 4 +-- src/hb-ot-shape-complex-indic.cc | 50 +++++++++++++++----------------- src/hb-ot-shape-private.hh | 6 ++++ src/hb-ot-shape.cc | 28 ++++++++++-------- 6 files changed, 57 insertions(+), 50 deletions(-) commit 3e38c0f2886c38d2f0a9d80a97a36edf2479d2c7 Author: Behdad Esfahbod Date: Thu Aug 2 09:44:18 2012 -0400 More massaging src/hb-ot-map-private.hh | 20 ++++++++------------ src/hb-ot-map.cc | 17 ++++++++--------- src/hb-ot-shape-complex-arabic.cc | 8 ++++---- src/hb-ot-shape-complex-indic.cc | 18 +++++++----------- 4 files changed, 27 insertions(+), 36 deletions(-) commit 16c6a27b4bffc19026944c7bea9cf0a3a8ff1d8f Author: Behdad Esfahbod Date: Thu Aug 2 09:38:28 2012 -0400 [OT] Port complex_shaper to planner/plan src/hb-ot-shape-complex-arabic.cc | 17 ++++++++--------- src/hb-ot-shape-complex-indic.cc | 19 ++++++++----------- src/hb-ot-shape-complex-misc.cc | 20 ++++++++------------ src/hb-ot-shape-complex-private.hh | 32 +++++++++++--------------------- src/hb-ot-shape-private.hh | 14 +++++++++++--- src/hb-ot-shape.cc | 9 +++++---- 6 files changed, 51 insertions(+), 60 deletions(-) commit 5393e3a62ba09fd7bcf3767b36225c8f49badb9d Author: Behdad Esfahbod Date: Thu Aug 2 09:24:35 2012 -0400 [OT] Minor refactoring src/hb-ot-map.cc | 4 ---- src/hb-ot-shape-private.hh | 26 ++++++++++++++++++++++++++ src/hb-ot-shape.cc | 26 ++------------------------ src/hb-shape-plan.cc | 2 ++ src/hb-shape.cc | 2 -- 5 files changed, 30 insertions(+), 30 deletions(-) commit 24eacf17c801c66a2d466e8ae02b73f501a26b25 Author: Behdad Esfahbod Date: Thu Aug 2 08:42:11 2012 -0400 [Indic] Move consonant-position-setting into initial_reordering() src/hb-ot-shape-complex-indic.cc | 65 +++++++++++++++++++++------------------- 1 file changed, 35 insertions(+), 30 deletions(-) commit afbcc24be01a64bdb5c05c63880269145fa1d3c8 Author: Behdad Esfahbod Date: Thu Aug 2 08:36:40 2012 -0400 [GSUB] Wire the font, not just the face, down to substitute() We need the font for glyph lookup during GSUB pauses in Indic shaper. Could perhaps be avoided, but at this point, we don't mean to support separate substitute()/position() entry points (anymore), so there is no point in not providing the font to GSUB. src/hb-ot-layout-gsub-table.hh | 13 +++++-------- src/hb-ot-layout-gsubgpos-private.hh | 7 ++----- src/hb-ot-layout-private.hh | 6 +++--- src/hb-ot-layout.cc | 18 +++++++++--------- src/hb-ot-map-private.hh | 15 ++++++--------- src/hb-ot-map.cc | 8 ++++---- src/hb-ot-shape-complex-indic.cc | 8 ++++---- src/hb-ot-shape.cc | 6 +++--- 8 files changed, 36 insertions(+), 45 deletions(-) commit b0e6a26a10ccca70ebc88a9e158a89ccfab0add5 Author: Behdad Esfahbod Date: Thu Aug 2 08:11:14 2012 -0400 [OT] Hide some API It was impossible to meaningfully use them from the outside these days. src/hb-ot-layout-private.hh | 40 ++++++++++++++++++++++++++++++++-------- src/hb-ot-layout.cc | 20 -------------------- src/hb-ot-layout.h | 34 ---------------------------------- src/hb-ot-map.cc | 8 ++++---- 4 files changed, 36 insertions(+), 66 deletions(-) commit 305246744ed178f116e01498b7f9d1af6950ca30 Author: Behdad Esfahbod Date: Thu Aug 2 08:08:04 2012 -0400 Minor src/hb-ot-layout-gsubgpos-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8ef3d53255ae9fbb0e46c22909e50009d1e7eeb0 Author: Behdad Esfahbod Date: Thu Aug 2 07:53:18 2012 -0400 [Indic] More refactoring of consonant position peeking in the font To be moved to initial_reordering next... src/hb-ot-shape-complex-indic.cc | 59 ++++++++++++++++++++++++++++------------ 1 file changed, 41 insertions(+), 18 deletions(-) commit 3eb6f81fd3f1e56679eec10d08f5e2303121753f Author: Behdad Esfahbod Date: Thu Aug 2 07:37:46 2012 -0400 [Indic] Refactor Move all the logic that needs to eventually move into the indic table into hb-ot-shape-complex-indic-private.hh. src/hb-ot-shape-complex-indic-private.hh | 210 ++++++++++++++++++++++++++++ src/hb-ot-shape-complex-indic.cc | 227 ++----------------------------- 2 files changed, 218 insertions(+), 219 deletions(-) commit 3614ba242fc7d338761acdda365a134706035b6d Author: Behdad Esfahbod Date: Thu Aug 2 07:13:55 2012 -0400 [Indic] Rename src/hb-ot-shape-complex-indic.cc | 40 +++++++++++++++++++++------------------- 1 file changed, 21 insertions(+), 19 deletions(-) commit 610e5e8f713bb2a68939b72cb2b801a7aaede4f9 Author: Behdad Esfahbod Date: Thu Aug 2 05:27:46 2012 -0400 [Indic] Streamline feature would_apply() Comes with some 10% speedup for Devanagari even! src/hb-ot-map-private.hh | 85 +++++++++++++++++++++++++--------------- src/hb-ot-map.cc | 18 ++++----- src/hb-ot-shape-complex-indic.cc | 85 +++++++++++++++++++++++----------------- 3 files changed, 110 insertions(+), 78 deletions(-) commit 1d002048d5afcd45abbb09fdf0419f13b2e2265c Author: Behdad Esfahbod Date: Thu Aug 2 05:01:11 2012 -0400 [Indic] Minor src/hb-ot-shape-complex-indic-private.hh | 16 -------- src/hb-ot-shape-complex-indic.cc | 64 +++++++++++++++++++++----------- 2 files changed, 43 insertions(+), 37 deletions(-) commit 6f7611375521c6d285a9aa763f2ea5cb44cd0d39 Author: Behdad Esfahbod Date: Thu Aug 2 04:00:31 2012 -0400 [GSUB/GPOS] Check array size before accessing digests src/hb-ot-layout-private.hh | 3 +++ src/hb-ot-layout.cc | 32 ++++++++++++++++---------------- 2 files changed, 19 insertions(+), 16 deletions(-) commit 22148b8c4af3ed296d96e969cdd47bac97b32307 Author: Behdad Esfahbod Date: Thu Aug 2 03:51:51 2012 -0400 Use Coverage digests in would_apply src/hb-ot-layout-gsub-table.hh | 1 + src/hb-ot-layout-gsubgpos-private.hh | 6 +++++- src/hb-ot-layout.cc | 4 ++-- 3 files changed, 8 insertions(+), 3 deletions(-) commit 6c459c8fef85bc44f45d7b58c28a34abfb2c33fc Author: Behdad Esfahbod Date: Thu Aug 2 03:45:53 2012 -0400 Minor src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-layout-gsub-table.hh | 4 ++-- src/hb-ot-layout-gsubgpos-private.hh | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) commit e2b8d75fa6e847ecf5c040f4e1e16a565c5d8aaf Author: Behdad Esfahbod Date: Wed Aug 1 22:17:48 2012 -0400 Use wider set digests on 64-bit archs src/hb-set-private.hh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 0120ce9679aab3ac936aeb18f6709529eef000a4 Author: Behdad Esfahbod Date: Wed Aug 1 21:56:35 2012 -0400 [GSUB/GPOS] Remove unused get_coverage() methods src/hb-ot-layout-gpos-table.hh | 11 ----------- src/hb-ot-layout-gsub-table.hh | 11 ----------- 2 files changed, 22 deletions(-) commit 1336ecdf8e4e9879b96b26ecfbf5c9ba6c49e2b9 Author: Behdad Esfahbod Date: Wed Aug 1 21:46:36 2012 -0400 [GSUB/GPOS] Use Coverage digests as gatekeeper Gives me a good 10% speedup for the Devanagari test case. Less so for less lookup-intensive tests. For the Devanagari test case, the false positive rate of the GSUB digest is 4%. src/hb-ot-layout-gpos-table.hh | 30 +++++++++--------------------- src/hb-ot-layout-gsub-table.hh | 35 ++++++++++++----------------------- src/hb-ot-layout-gsubgpos-private.hh | 8 ++++++-- src/hb-ot-layout-private.hh | 4 ++++ src/hb-ot-layout.cc | 29 +++++++++++++++++++++++++---- 5 files changed, 56 insertions(+), 50 deletions(-) commit a878c58a8fc1500986d713b2bcedfeb90a0087b0 Author: Behdad Esfahbod Date: Wed Aug 1 21:18:54 2012 -0400 [GSUB/GPOS] Add add_coverage() src/hb-ot-layout-gpos-table.hh | 18 ++++++++++++++++++ src/hb-ot-layout-gsub-table.hh | 18 ++++++++++++++++++ 2 files changed, 36 insertions(+) commit 60a3035ac5ec8227e4cc0e6708732bb139c9e0b8 Author: Behdad Esfahbod Date: Wed Aug 1 21:06:27 2012 -0400 Add hb_set_digest_t Implement two set digests, and one that combines the two. src/hb-set-private.hh | 95 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 95 insertions(+) commit c8accf1dd2d92cc4f714393eb0ea46f69bb182a6 Author: Behdad Esfahbod Date: Wed Aug 1 21:05:57 2012 -0400 [OT] Templatize Coverage::add_coverage() src/hb-ot-layout-common-private.hh | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) commit 8fbfda920e0b3bb4ab7afb732826026964b79be9 Author: Behdad Esfahbod Date: Wed Aug 1 19:03:46 2012 -0400 Inline font getters src/hb-fallback-shape.cc | 21 ++-- src/hb-font-private.hh | 204 ++++++++++++++++++++++++++++++++++++++ src/hb-font.cc | 129 ++++-------------------- src/hb-graphite2.cc | 6 +- src/hb-old.cc | 10 +- src/hb-ot-layout-gdef-table.hh | 2 +- src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-shape-complex-arabic.cc | 4 +- src/hb-ot-shape-complex-indic.cc | 6 +- src/hb-ot-shape-normalize.cc | 12 +-- src/hb-ot-shape.cc | 47 +++++---- 11 files changed, 277 insertions(+), 166 deletions(-) commit 6adf417bc15d4524e280b284e3accd1ae647662e Author: Behdad Esfahbod Date: Wed Aug 1 18:07:42 2012 -0400 Use a lookup table for modified_combining_class src/hb-unicode-private.hh | 10 ++- src/hb-unicode.cc | 213 +++++++++++++++++++++++++++++++--------------- src/hb-unicode.h | 4 + 3 files changed, 157 insertions(+), 70 deletions(-) commit 208f70f0553d73d2908b21b9552298029482a8b9 Author: Behdad Esfahbod Date: Wed Aug 1 17:13:10 2012 -0400 Inline Unicode callbacks internally src/hb-buffer.cc | 2 +- src/hb-fallback-shape.cc | 2 +- src/hb-old.cc | 2 +- src/hb-ot-shape-complex-misc.cc | 2 +- src/hb-ot-shape-normalize.cc | 13 +++-- src/hb-ot-shape-private.hh | 6 +-- src/hb-ot-shape.cc | 4 +- src/hb-unicode-private.hh | 112 ++++++++++++++++++++-------------------- src/hb-unicode.cc | 5 +- 9 files changed, 73 insertions(+), 75 deletions(-) commit 7470315a3e782aa6192bbe64f7a3944266fb1521 Author: Behdad Esfahbod Date: Wed Aug 1 17:01:59 2012 -0400 Move unicode accessors around src/hb-unicode-private.hh | 73 ++++++++++++++++++++++++++++++++++++++++++++++- src/hb-unicode.cc | 65 ++++------------------------------------- 2 files changed, 78 insertions(+), 60 deletions(-) commit 21fdcee00125b6e1c09f0bed3064d16ccd3a7a5d Author: Behdad Esfahbod Date: Wed Aug 1 16:23:44 2012 -0400 Add hb_unicode_combining_class_t src/hb-common.h | 38 +------------- src/hb-glib.cc | 4 +- src/hb-icu.cc | 4 +- src/hb-unicode-private.hh | 2 +- src/hb-unicode.cc | 11 ++-- src/hb-unicode.h | 124 +++++++++++++++++++++++++++++++++++++++++++++- 6 files changed, 134 insertions(+), 49 deletions(-) commit 84186a64004e5dcd2ce98b564d0e0a09aa5d68b2 Author: Behdad Esfahbod Date: Wed Aug 1 13:32:39 2012 -0400 Add commentary on the compatibility decomposition in the normalizer src/hb-ot-shape-normalize.cc | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) commit 0834d952017a04c6f4599e574cb75ecf3ca27d3b Author: Behdad Esfahbod Date: Wed Aug 1 00:21:09 2012 -0400 [hb-old] Adjust mark positioning parameters Fallback mark positioning works now... With hb-ft and hb-view / hb-shape at least. src/hb-old.cc | 10 +++++----- src/hb-old/harfbuzz-shaper.cpp | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) commit 4ca743dfb8e09f9fa525061c7f1144d55f72effb Author: Behdad Esfahbod Date: Wed Aug 1 00:03:41 2012 -0400 [old] Implement fontMetrics src/hb-old.cc | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) commit 1e7d860613032e40a3f90e2caa2ee5ac44ab8c8c Author: Behdad Esfahbod Date: Tue Jul 31 23:41:06 2012 -0400 [GPOS] Adjust mark advance-width zeroing logic If there is no GPOS, zero mark advances. If there *is* GPOS and the shaper requests so, zero mark advances for attached marks. Fixes regression with Tibetan, where the font has GPOS, and marks a glyph as mark where it shouldn't get zero advance. src/hb-ot-layout-gpos-table.hh | 14 ++++++++------ src/hb-ot-layout.cc | 4 ++-- src/hb-ot-layout.h | 3 ++- src/hb-ot-shape-complex-arabic.cc | 2 +- src/hb-ot-shape-complex-indic.cc | 2 +- src/hb-ot-shape-complex-misc.cc | 4 ++-- src/hb-ot-shape-complex-private.hh | 2 +- src/hb-ot-shape.cc | 6 ++---- 8 files changed, 19 insertions(+), 18 deletions(-) commit a8842e4a448efb30f3f2f3c628d6dc4824829726 Author: Behdad Esfahbod Date: Tue Jul 31 23:10:11 2012 -0400 Remove some TODO items TODO | 27 --------------------------- src/hb-shape.cc | 2 ++ 2 files changed, 2 insertions(+), 27 deletions(-) commit 2bc3b9a616cedbc56ff4a915f9e3439ff3a6bf13 Author: Behdad Esfahbod Date: Tue Jul 31 23:08:25 2012 -0400 [OT] Zero mark advances if the shaper desires so Enabled for all shapers except for Indic. src/hb-ot-shape-complex-arabic.cc | 1 + src/hb-ot-shape-complex-indic.cc | 1 + src/hb-ot-shape-complex-misc.cc | 2 ++ src/hb-ot-shape-complex-private.hh | 2 ++ src/hb-ot-shape.cc | 15 +++++++++++++++ 5 files changed, 21 insertions(+) commit 5fecd8b0355894ceda14b3d3c654f20c3d5e77f4 Author: Behdad Esfahbod Date: Tue Jul 31 22:48:38 2012 -0400 [OT] Synthesize glyph classes TODO | 2 -- src/hb-ot-shape.cc | 20 ++++++++++++++++++-- 2 files changed, 18 insertions(+), 4 deletions(-) commit 03b09214c073ce37eeb8af5218942c85b2d393df Author: Behdad Esfahbod Date: Tue Jul 31 22:43:58 2012 -0400 [GSUB] Minor src/hb-ot-layout-gsub-table.hh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit f0fc1df8fc949739b68d55948741016081b69c3a Author: Behdad Esfahbod Date: Tue Jul 31 22:43:32 2012 -0400 [hb-old] Implement getGlyphMetrics() Still working on it. src/hb-old.cc | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) commit 378d279bbf692195c4654e312dae854ab3be04cf Author: Behdad Esfahbod Date: Tue Jul 31 21:36:16 2012 -0400 Implement Unicode compatibility decompositions Based on patch from Philip Withnall. https://bugs.freedesktop.org/show_bug.cgi?id=41095 src/hb-glib.cc | 30 +++++++++++++++++++++++++ src/hb-icu.cc | 36 +++++++++++++++++++++++++++++- src/hb-ot-shape-normalize.cc | 53 +++++++++++++++++++++++++++++--------------- src/hb-unicode-private.hh | 1 + src/hb-unicode.cc | 27 +++++++++++++++++++++- src/hb-unicode.h | 37 ++++++++++++++++++++++++++++++- test/api/hb-test.h | 1 + test/api/test-unicode.c | 50 +++++++++++++++++++++++++++++++++++++++++ 8 files changed, 214 insertions(+), 21 deletions(-) commit 321ec29cc270e7e66a529696b70b2caac553c95f Author: Behdad Esfahbod Date: Tue Jul 31 21:10:16 2012 -0400 Remove unused function src/hb-ot-shape-complex-indic.cc | 7 ------- 1 file changed, 7 deletions(-) commit 69cc492dc120847ed00cae65ec958593ebf550c5 Author: Behdad Esfahbod Date: Tue Jul 31 14:51:36 2012 -0400 [buffer] Minor src/hb-buffer-private.hh | 3 ++- src/hb-buffer.cc | 24 ++++++++++++------------ 2 files changed, 14 insertions(+), 13 deletions(-) commit 693918ef8541014a5ef7dfb91c6ea0ae36d9c368 Author: Behdad Esfahbod Date: Mon Jul 30 21:08:51 2012 -0400 [OT] Streamline complex shaper enumeration Add a shaper class struct. src/hb-ot-shape-complex-arabic.cc | 37 ++++---- src/hb-ot-shape-complex-indic.cc | 47 ++++++--- src/hb-ot-shape-complex-misc.cc | 67 ++++++------- src/hb-ot-shape-complex-private.hh | 179 ++++++++++------------------------- src/hb-ot-shape-normalize-private.hh | 4 +- src/hb-ot-shape-private.hh | 2 +- src/hb-ot-shape.cc | 16 ++-- 7 files changed, 143 insertions(+), 209 deletions(-) commit c2e42c3db691515f3a458eb4c71fe1e6439d5620 Author: Behdad Esfahbod Date: Mon Jul 30 19:54:50 2012 -0400 Minor src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-layout-gsub-table.hh | 4 ++-- src/hb-ot-layout-gsubgpos-private.hh | 8 ++++---- src/hb-ot-layout-private.hh | 4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-) commit 03f67bc012f42131b36083a23efc78e1b04b828c Author: Behdad Esfahbod Date: Mon Jul 30 19:47:53 2012 -0400 More refactoring glyph class access src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-layout-gsub-table.hh | 2 +- src/hb-ot-layout-gsubgpos-private.hh | 154 +++++++++++++++++------------------ 3 files changed, 76 insertions(+), 82 deletions(-) commit 300c7307eb7943ba7416b672345506be1e27c6ba Author: Behdad Esfahbod Date: Mon Jul 30 19:37:44 2012 -0400 [OT] Don't crash if no GDEF available src/hb-ot-layout-gsubgpos-private.hh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 3dcbdc2125c04c173f29f04922fc031929893f4e Author: Behdad Esfahbod Date: Mon Jul 30 19:31:17 2012 -0400 Minor src/hb-ot-layout.cc | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) commit 05bd1b63426e07d1df7a1b40bf845dc94ab995a8 Author: Behdad Esfahbod Date: Mon Jul 30 19:30:01 2012 -0400 [GSUB/GPOS] Move glyph props matching around src/hb-ot-layout-gpos-table.hh | 11 ++-- src/hb-ot-layout-gsub-table.hh | 18 +++--- src/hb-ot-layout-gsubgpos-private.hh | 99 +++++++++++++++++++++++++++++---- src/hb-ot-layout-private.hh | 12 ---- src/hb-ot-layout.cc | 104 +++-------------------------------- src/hb-ot-layout.h | 12 ++-- src/hb-ot-shape.cc | 10 ++-- 7 files changed, 127 insertions(+), 139 deletions(-) commit 2fca1426ca06cabbe8f027f2dc9dee9c27560c76 Author: Behdad Esfahbod Date: Mon Jul 30 18:46:41 2012 -0400 [GSUB] Don't erase glyph classes if GDEF does not have glyph classes src/hb-ot-layout-gsubgpos-private.hh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit fd42257f8c45ff8e036e1c3eb1a788a101be7ead Author: Behdad Esfahbod Date: Mon Jul 30 18:40:27 2012 -0400 Minor src/hb-ot-layout.cc | 29 +++++------------------------ 1 file changed, 5 insertions(+), 24 deletions(-) commit 7fbbf86efe675e4c038dfc5985c24bbc544620cd Author: Behdad Esfahbod Date: Mon Jul 30 18:36:42 2012 -0400 [GSUB] Minor src/hb-ot-layout-gsub-table.hh | 2 +- src/hb-ot-layout-gsubgpos-private.hh | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) commit 713914d3203109a8e9213f5a1d3b384730703ce9 Author: Behdad Esfahbod Date: Mon Jul 30 17:54:38 2012 -0400 [Uniscribe] Clean up a bit src/hb-uniscribe.cc | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) commit 301168dae77a63ee25adfb26ce2b54a708f83791 Author: Behdad Esfahbod Date: Mon Jul 30 17:48:04 2012 -0400 [CoreText] Port to shape_plan infrastructure src/hb-coretext.cc | 161 ++++++++++++++++++++++++++--------------------------- 1 file changed, 80 insertions(+), 81 deletions(-) commit 6cdfd14bb19d60ac3d6b20ff611408432254f273 Author: Behdad Esfahbod Date: Mon Jul 30 17:22:17 2012 -0400 Fix build on Mac src/hb-ot-layout-gsub-table.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 7e34601dededd521bcef15111e39293df3d0d13d Author: Behdad Esfahbod Date: Mon Jul 30 14:53:41 2012 -0400 Unbreak Hangul jamo composition When we removed the separate Hangul shaper, the specific normalization preference of Hangul was lost. Fix that. Also, the Thai shaper was copied from Hangul, so had the fully-composed normalization behavior, which was unnecessary. So, fix that too. src/hb-ot-shape-complex-arabic.cc | 2 +- src/hb-ot-shape-complex-indic.cc | 4 +--- src/hb-ot-shape-complex-misc.cc | 12 +++++++++--- src/hb-ot-shape-complex-private.hh | 9 ++++----- src/hb-ot-shape.cc | 4 +++- 5 files changed, 18 insertions(+), 13 deletions(-) commit 7afb14407e59dfeaa79c33aca1ffa60e7982e349 Author: Behdad Esfahbod Date: Mon Jul 30 13:54:46 2012 -0400 [Indic] Recategorize Telugu length marks Fixes 8 more Telugu tests. Failures at 15 (0.00154548%). src/hb-unicode.cc | 8 ++++++++ src/indic.cc | 11 ++++++++--- 2 files changed, 16 insertions(+), 3 deletions(-) commit 70b3dc327232b20051b36397aa2b196ab8c62397 Author: Behdad Esfahbod Date: Mon Jul 30 12:40:18 2012 -0400 Add Hebrew test .../texts/in-tree/shaper-default/script-hebrew/misc/diacritics.txt | 1 + 1 file changed, 1 insertion(+) commit f2377155e35c15919af4d7db21b6edc6783146b6 Author: Behdad Esfahbod Date: Mon Jul 30 10:50:57 2012 -0400 [hb-old] Fix misc leaks Backport (forward-port?!) from upstream: commit 3ab7b37bdebf0f8773493a1fee910b151c4de30f Author: Behdad Esfahbod Date: Mon Jul 30 10:50:22 2012 -0400 Fix misc leaks https://bugs.freedesktop.org/show_bug.cgi?id=31992 https://bugs.freedesktop.org/show_bug.cgi?id=31993 https://bugs.freedesktop.org/show_bug.cgi?id=31994 https://bugs.freedesktop.org/show_bug.cgi?id=31995 src/hb-old/harfbuzz-arabic.c | 12 +++++++++--- src/hb-old/harfbuzz-gpos.c | 6 +++--- src/hb-old/harfbuzz-gsub.c | 6 +++--- src/hb-old/harfbuzz-tibetan.c | 1 + 4 files changed, 16 insertions(+), 9 deletions(-) commit 3f4764bb56bb7e42ba8859f1905810bd2f998838 Author: Behdad Esfahbod Date: Mon Jul 30 10:06:42 2012 -0400 Don't lock user_data set during destruction if empty src/hb-private.hh | 5 +++++ 1 file changed, 5 insertions(+) commit 4ba647eecf0f70917ac4229af1f2dd3c62fcb7d5 Author: Behdad Esfahbod Date: Mon Jul 30 09:53:06 2012 -0400 Fix leak src/hb-ot-shape.cc | 2 ++ 1 file changed, 2 insertions(+) commit f860366456d9e59b139a940da6d89c3c4fb9e96e Author: Behdad Esfahbod Date: Mon Jul 30 02:38:39 2012 -0400 [OT] Gain back some lost speed src/hb-ot-layout-private.hh | 27 +++++++++++++++- src/hb-ot-layout.cc | 63 ++++++++++++++++++++++++++++++++++---- src/hb-ot-map-private.hh | 26 +++------------- src/hb-ot-map.cc | 35 +++++++++++++++------ src/hb-ot-shape-complex-indic.cc | 2 +- src/hb-ot-shape-complex-private.hh | 5 --- 6 files changed, 114 insertions(+), 44 deletions(-) commit 11f4c87d01924cac43bf40044f67838440e19e42 Author: Behdad Esfahbod Date: Mon Jul 30 02:36:46 2012 -0400 [OT] Remove hb_ot_layout_ensure() I didn't like it from the beginning. src/hb-ot-layout.cc | 9 +++++---- src/hb-ot-layout.h | 5 ----- 2 files changed, 5 insertions(+), 9 deletions(-) commit 578e42182b9b9cf15b4c5426fae36e224160cbd7 Author: Behdad Esfahbod Date: Mon Jul 30 02:35:07 2012 -0400 Minor src/hb-ot-layout-private.hh | 2 -- src/hb-ot-layout.cc | 1 - 2 files changed, 3 deletions(-) commit a973b5ce86051e8ef0d20df362db1a50488842ab Author: Behdad Esfahbod Date: Mon Jul 30 01:46:34 2012 -0400 [GSUB] Further adjustments to mark-attachment vs ligation interaction The d1d69ec52e75a78575b620a1c456d528b6078170 change broke Kannada badly, since it was ligating consonants, pushing matra out, and then ligating with the matra. Adjust for that. See comments. src/hb-ot-layout-gsub-table.hh | 11 ++++++++--- .../in-tree/shaper-indic/indic/script-kannada/misc/misc.txt | 1 + 2 files changed, 9 insertions(+), 3 deletions(-) commit 0aef425e25e2c58445157057f17ef18f695c5240 Author: Behdad Esfahbod Date: Mon Jul 30 00:55:15 2012 -0400 [GSUB] Minor src/hb-ot-layout-gpos-table.hh | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) commit d1d69ec52e75a78575b620a1c456d528b6078170 Author: Behdad Esfahbod Date: Mon Jul 30 00:51:47 2012 -0400 [GSUB] Don't ligate glyphs attached to different components of ligatures This concludes the mark-attachment vs ligating interaction fixes (for now). src/hb-ot-layout-gsub-table.hh | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) commit 4751dec8be05883483fd5f6b474ebd22583ae566 Author: Behdad Esfahbod Date: Mon Jul 30 00:42:07 2012 -0400 Minor src/hb-ot-layout-private.hh | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) commit f24bcfbed1f3b4f4f6311246bd870f73ad6ba750 Author: Behdad Esfahbod Date: Mon Jul 30 00:39:00 2012 -0400 Minor src/hb-ot-layout-gsub-table.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fe20c0f84f5ff518dc471bf22ac5a83ef079eb69 Author: Behdad Esfahbod Date: Mon Jul 30 00:00:59 2012 -0400 [GSUB] Fix mark component stuff when ligatures form ligatures! See comments. Fixes https://bugzilla.gnome.org/show_bug.cgi?id=437633 src/hb-ot-layout-gsub-table.hh | 117 +++++++++++++++++++++++------------ src/hb-ot-layout-gsubgpos-private.hh | 8 --- src/hb-ot-layout-private.hh | 8 +-- 3 files changed, 79 insertions(+), 54 deletions(-) commit 2ec3ba46a3c24469096e901750e38f6ee555479a Author: Behdad Esfahbod Date: Sun Jul 29 22:02:24 2012 -0400 [GSUB/GPOS] Minor Start squeezing more out of lig_id/lig_comp. src/hb-ot-layout-gsub-table.hh | 6 +++--- src/hb-ot-layout-private.hh | 35 +++++++++++++++++++++++++++++++---- 2 files changed, 34 insertions(+), 7 deletions(-) commit ef6e9cec3399e4f63f4b662abd77cf6d4683e8a3 Author: Behdad Esfahbod Date: Sun Jul 29 21:35:22 2012 -0400 Fixup bb0e4ba3e9c5a407fc5d73c914e429d24d336380 src/hb-shape-plan.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cb3d34063154bf164c61eeba41c6166b0bd304fb Author: Behdad Esfahbod Date: Sun Jul 29 20:37:38 2012 -0400 [GSUB] Don't set new lig_id on mark ligatures If two marks form a ligature, retain their previous lig_id, such that the mark ligature can attach to ligature components... Fixes https://bugzilla.gnome.org/show_bug.cgi?id=676343 In fact, I noticed that we should not let ligatures form between glyphs coming from different components of a previous ligature. For example, if the sequence is: LAM,SHADDA,LAM,FATHA,HEH, the LAM,LAM,HEH form a ligature, putting SHADDA and FATHA next to eachother. However, it would be wrong to ligate them. Uniscribe has this bug also. src/hb-ot-layout-gsub-table.hh | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) commit 97a201becf936f62046914b568e5763e27ee936e Author: Behdad Esfahbod Date: Sun Jul 29 20:31:36 2012 -0400 Add Arabic tests for mark ligature component attachments .../script-arabic/misc/diacritics/MANIFEST | 1 + .../misc/diacritics/ligature-components.txt | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+) commit a15b70a81a609f024083cb04f9819483f4d5cab7 Author: Behdad Esfahbod Date: Sun Jul 29 20:09:22 2012 -0400 [hb-old] Fix cluster formation in RTL Unlike Uniscribe, hb-old returns glyphs in logical order, so the logic does not need to duplicated for RTL. src/hb-old.cc | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) commit 8a7e70ef65952fc16b8c1d5f1126c94d9d81e755 Author: Behdad Esfahbod Date: Sun Jul 29 19:56:54 2012 -0400 [Minor] src/test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bb0e4ba3e9c5a407fc5d73c914e429d24d336380 Author: Behdad Esfahbod Date: Sun Jul 29 17:34:14 2012 -0400 Minor src/hb-shape-plan.cc | 2 +- src/test-would-substitute.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit a00ad60bc0fe74bf0e11d73da563239f3392f351 Author: Behdad Esfahbod Date: Sat Jul 28 21:16:08 2012 -0400 [Uniscribe] Remove hb_uniscribe_font_ensure() Wasn't a huge fan of putting the burden on the user. Just remove it and do what we've got to do transparently. src/hb-uniscribe.cc | 6 +++++- src/hb-uniscribe.h | 4 ---- 2 files changed, 5 insertions(+), 5 deletions(-) commit 5d874d566fe5d2cc4cfaf02c79b663d8a626ca1e Author: Behdad Esfahbod Date: Sat Jul 28 21:05:25 2012 -0400 [GPOS] Fix mark-to-mark positioning when one of the marks is a ligature This commit: a3313e54008167e415b72c780ca7b9cda958d07e broke MarkMarkPos when one of the marks itself is a ligature. That regressed 26 Tibetan tests (up from zero!). Fix that. Tibetan back to zero. src/hb-ot-layout-gpos-table.hh | 27 ++++++++++++++++------ src/hb-ot-layout-private.hh | 5 ++-- test/shaping/texts/in-tree/shaper-indic/MANIFEST | 1 + .../indic/script-sinhala/misc/MANIFEST | 1 + .../in-tree/shaper-indic/south-asian/MANIFEST | 1 + .../south-asian/script-tibetan/MANIFEST | 1 + .../south-asian/script-tibetan/misc/MANIFEST | 1 + .../south-asian/script-tibetan/misc/misc.txt | 1 + 8 files changed, 29 insertions(+), 9 deletions(-) commit 338fe662b50f9309bf0050dd99becb644874195b Author: Behdad Esfahbod Date: Sat Jul 28 18:53:01 2012 -0400 [GSUB] Minor src/hb-ot-layout-gsub-table.hh | 33 ++++++++++++++++----------------- 1 file changed, 16 insertions(+), 17 deletions(-) commit e6f7479fe34fb4a7cada61d84c2ed70d1fd565c8 Author: Behdad Esfahbod Date: Sat Jul 28 18:34:58 2012 -0400 [GSUB] Simplify would-apply src/hb-ot-layout-gsub-table.hh | 71 +++--------------------------------- src/hb-ot-layout-gsubgpos-private.hh | 24 +++--------- 2 files changed, 11 insertions(+), 84 deletions(-) commit dadede012e4841f9fcb70d514fdc752f3ea4663d Author: Behdad Esfahbod Date: Sat Jul 28 18:03:20 2012 -0400 Minor src/hb-ot-layout-common-private.hh | 7 +++---- src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-layout-gsub-table.hh | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) commit 0b99429ead05ae32b3c210cb499af401b02770a9 Author: Behdad Esfahbod Date: Sat Jul 28 17:31:01 2012 -0400 [GSUB/GPOS] Add get_coverage() and use it to speed up main loop And use it to speed up the hotspot by checking coverage directly in the main loop, not 10 functions deep in. Gives me a solid 20% boost with Indic test suite. Less so for less lookup-intensive scenarios. Remove the "fast_path" hack from before. src/hb-ot-layout-gpos-table.hh | 179 ++++++++++++++++++++++++++++++----- src/hb-ot-layout-gsub-table.hh | 166 ++++++++++++++++++++++++++------ src/hb-ot-layout-gsubgpos-private.hh | 26 +++++ 3 files changed, 321 insertions(+), 50 deletions(-) commit 30ec9002d84e8b49290e782e6192069821ffa942 Author: Behdad Esfahbod Date: Sat Jul 28 17:25:20 2012 -0400 Reject lookups with no subTable src/hb-ot-layout-common-private.hh | 1 + 1 file changed, 1 insertion(+) commit 0981068b75710397f08e0d2d776a0a2ea68d7117 Author: Behdad Esfahbod Date: Sat Jul 28 17:01:59 2012 -0400 [GSUB/GPOS] Reject Context/ChainContext lookups with zero input src/hb-ot-layout-gsubgpos-private.hh | 2 ++ 1 file changed, 2 insertions(+) commit 2f87cebe1062c7007021ebd05c1664e60da80825 Author: Behdad Esfahbod Date: Fri Jul 27 04:02:38 2012 -0400 Implement shape_plan caching Should give us some performance boost. TODO | 4 ++ src/hb-buffer-private.hh | 30 ++++++++++++++ src/hb-font-private.hh | 6 +++ src/hb-font.cc | 15 ++++++- src/hb-shape-plan.cc | 100 +++++++++++++++++++++++++++++++++++++++++++++++ src/hb-shape-plan.h | 7 ++++ src/hb-shape.cc | 2 +- 7 files changed, 162 insertions(+), 2 deletions(-) commit e9eb9503e97044222f843daacfa47e26e51312b7 Author: Behdad Esfahbod Date: Fri Jul 27 03:16:22 2012 -0400 Add default_shaper_list to shape_plan src/hb-shape-plan-private.hh | 1 + src/hb-shape-plan.cc | 2 ++ 2 files changed, 3 insertions(+) commit 3b7c4e270694ed962e2a2839e44f2a59c26b326c Author: Behdad Esfahbod Date: Fri Jul 27 03:12:23 2012 -0400 Don't fail choosing shaper on planning failure Shapers have a chance to reject a font in face shaper_data creation. No need to allow failing during planning. src/hb-shape-plan.cc | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) commit cfe9882610489e1b917e09a74dfbf6bbba2e4a57 Author: Behdad Esfahbod Date: Fri Jul 27 03:06:30 2012 -0400 Add hb_ot_layout_ensure() and hb_uniscribe_font_ensure() src/hb-ot-layout.cc | 7 +++++++ src/hb-ot-layout.h | 6 ++++++ src/hb-shape-plan.cc | 22 ++-------------------- src/hb-shaper-private.hh | 18 ++++++++++++++++++ src/hb-uniscribe.cc | 11 +++++++++++ src/hb-uniscribe.h | 4 ++++ 6 files changed, 48 insertions(+), 20 deletions(-) commit c5b668fb9239c912d2448280a7176e331ebc9181 Author: Behdad Esfahbod Date: Fri Jul 27 02:49:39 2012 -0400 Choose one shaper per plan src/hb-shape-plan-private.hh | 2 +- src/hb-shape-plan.cc | 19 +++++++++---------- 2 files changed, 10 insertions(+), 11 deletions(-) commit e82061e8db922f0ddbefd5a184ee2f9f967b9a05 Author: Behdad Esfahbod Date: Fri Jul 27 02:29:32 2012 -0400 Move ot shaper completely to shape_plan src/hb-ot-shape-private.hh | 6 -- src/hb-ot-shape.cc | 181 +++++++++++++++++++++------------------------ src/hb-uniscribe.cc | 2 +- 3 files changed, 84 insertions(+), 105 deletions(-) commit ea278d3895fe0c92801d692cd71d8d9f1de7c048 Author: Behdad Esfahbod Date: Fri Jul 27 02:12:28 2012 -0400 Partially switch ot shaper to shape_plan src/hb-buffer-private.hh | 1 + src/hb-buffer.cc | 1 - src/hb-font-private.hh | 2 -- src/hb-font.cc | 22 ++++++++++++++-------- src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-layout-gsub-table.hh | 4 ++-- src/hb-ot-layout-private.hh | 1 + src/hb-ot-layout.cc | 9 ++++++--- src/hb-ot-shape.cc | 3 ++- src/hb-shape-plan.cc | 11 +++++++++++ src/hb-shaper-private.hh | 3 ++- 11 files changed, 40 insertions(+), 19 deletions(-) commit b6b7ba1313bf686e6ed567183466104c90504a67 Author: Behdad Esfahbod Date: Fri Jul 27 01:26:11 2012 -0400 Switch old and uniscribe backends to shape_plan src/hb-old.cc | 80 ++------------------------ src/hb-shape.cc | 5 ++ src/hb-shaper-impl-private.hh | 3 +- src/hb-shaper-private.hh | 4 -- src/hb-uniscribe.cc | 130 ++++++++++++------------------------------ 5 files changed, 48 insertions(+), 174 deletions(-) commit c32c096a429da3e64896cf42ff5ab8c775d3c2ec Author: Behdad Esfahbod Date: Fri Jul 27 01:13:53 2012 -0400 Switch to shape_plan Not optimized yet. Eats babies. And no shaper uses the shape_plan. src/hb-shape-plan.cc | 37 +++++++++++++++++++++++++++++++++++-- src/hb-shape-plan.h | 8 ++++++++ src/hb-shape.cc | 27 ++++----------------------- 3 files changed, 47 insertions(+), 25 deletions(-) commit 5b95c148cc485f79fd7018bc4520b4cb5f728a18 Author: Behdad Esfahbod Date: Thu Jul 26 23:46:53 2012 -0400 Start implementing shape_plan src/hb-fallback-shape.cc | 4 ++- src/hb-font-private.hh | 4 +++ src/hb-old.cc | 4 ++- src/hb-ot-shape.cc | 4 ++- src/hb-shape-plan-private.hh | 7 ++++ src/hb-shape-plan.cc | 76 ++++++++++++++++++++++++++++++++++++++++++-- src/hb-shape.cc | 4 +++ src/hb-shaper-private.hh | 4 +-- src/hb-uniscribe.cc | 4 ++- 9 files changed, 103 insertions(+), 8 deletions(-) commit bd26b4d21f59312805d294f46f15182adbcc47da Author: Behdad Esfahbod Date: Thu Jul 26 22:05:39 2012 -0400 Minor src/Makefile.am | 1 + src/hb-fallback-shape.cc | 3 +- src/hb-old.cc | 3 +- src/hb-ot-shape.cc | 3 +- src/hb-shape-plan-private.hh | 2 +- src/hb-shape-plan.cc | 2 + src/hb-shape.cc | 98 ++++---------------------------------- src/hb-shaper-private.hh | 16 ++++++- src/hb-shaper.cc | 109 +++++++++++++++++++++++++++++++++++++++++++ src/hb-uniscribe.cc | 3 +- 10 files changed, 145 insertions(+), 95 deletions(-) commit 027857d0412477fb4427dcb8a8c45287c272e143 Author: Behdad Esfahbod Date: Thu Jul 26 17:34:25 2012 -0400 Start adding a unified shaper access infrastructure Add global shape_plan. Unused so far. src/Makefile.am | 15 +- src/hb-coretext-private.hh | 42 ----- src/hb-coretext.cc | 6 +- src/hb-fallback-shape.cc | 62 ++++++- src/hb-font-private.hh | 12 ++ src/hb-font.cc | 15 +- src/hb-old.cc | 109 +++++++++--- src/hb-ot-shape-private.hh | 8 - src/hb-ot-shape.cc | 60 ++++++- ...aphite2-private.hh => hb-shape-plan-private.hh} | 28 +++- src/hb-shape-plan.cc | 85 ++++++++++ ...b-fallback-shape-private.hh => hb-shape-plan.h} | 39 +++-- src/hb-shape.cc | 48 +----- ...scribe-private.hh => hb-shaper-impl-private.hh} | 20 ++- src/{hb-old-private.hh => hb-shaper-list.hh} | 30 ++-- src/hb-shaper-private.hh | 81 +++++++++ src/hb-uniscribe.cc | 186 +++++++++++++-------- 17 files changed, 608 insertions(+), 238 deletions(-) commit fa2dfcd560444d8c54b6349ee106134d3536f79b Author: Behdad Esfahbod Date: Thu Jul 26 16:06:16 2012 -0400 Fix visibility warnings with MinGW32 src/hb-old/harfbuzz-global.h | 17 +++++++++++------ src/hb-old/harfbuzz-impl.h | 6 +++++- 2 files changed, 16 insertions(+), 7 deletions(-) commit ac2085d4b391b0a72473ecac3dd6c22efe66833f Author: Jonathan Kew Date: Thu Jul 26 15:58:45 2012 -0400 [CoreText] Ensure cluster indices in output buffer are non-decreasing. Does not provide Uniscribe-compatible results, but should at least avoid breaking hb-view due to out-of-order cluster values. For RTL runs, ensure cluster values are non-increasing (instead of non-decreasing). src/hb-coretext.cc | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) commit 441d3bb7de311d54b9f0a5210344f9a96e97e153 Author: Behdad Esfahbod Date: Thu Jul 26 12:01:12 2012 -0400 Minor src/hb-coretext.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 2e7f223054d310695bdb3498b2b2b5d17b6cce78 Author: Behdad Esfahbod Date: Wed Jul 25 19:30:15 2012 -0400 [hb-old] Fix Arabic cursive positioning Backporting from upstream: commit b847f24ce855d24f6822bcd9c0006905e81b94d8 Author: Behdad Esfahbod Date: Wed Jul 25 19:29:16 2012 -0400 [arabic] Fix Arabic cursive positioning This was clearly broken in testing. Who knows... Fixes for me. Test with a Nastaleeq font, or with Arabic Typesetting. Backporting from Chromium. src/hb-old/harfbuzz-shaper.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9550a8c4e8b4e28be60d38c27d59253846ff9569 Author: Behdad Esfahbod Date: Wed Jul 25 19:22:57 2012 -0400 [hb-old] Fixup not-enough-space handling src/hb-old.cc | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) commit 91e721ea8693205f4f738bca97a5055ee75cf463 Author: Behdad Esfahbod Date: Wed Jul 25 19:20:34 2012 -0400 [hb-old] Fix clusters Unlike its "documentation", hb-old's log_clusters are, well, indeed logical, not visual. Fixup. Adapted / copied from hb-uniscribe. src/hb-old.cc | 51 ++++++++++++++++++++++++++++++++++---------- src/hb-old/harfbuzz-shaper.h | 1 + src/hb-uniscribe.cc | 5 +++-- 3 files changed, 44 insertions(+), 13 deletions(-) commit a3313e54008167e415b72c780ca7b9cda958d07e Author: Behdad Esfahbod Date: Wed Jul 25 18:37:51 2012 -0400 [GPOS] Fix MarkMarkPos applied to results of MultipleSubst This was broken as a result of 7b84c536c10ab90ed96a033d88e9ad232d46c5b8. As Khaled reported, MarkMark positioning was broken with glyphs resulting from a MultipleSubst. Fixed. Test with the ALLAH character in Amiri. src/hb-ot-layout-gpos-table.hh | 10 +++++----- src/hb-ot-layout-private.hh | 23 +++++++++++++++++++++-- 2 files changed, 26 insertions(+), 7 deletions(-) commit 35bdab3cf1f0836807160e3ce93766c321b32e8c Author: Behdad Esfahbod Date: Wed Jul 25 11:59:52 2012 -0400 Minor src/hb-unicode-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8fe4c7405b922cf0f936a46a9baedf4885b05254 Author: Behdad Esfahbod Date: Tue Jul 24 21:05:12 2012 -0400 [hb-old] Add HarfBuzz.old shaper Choose using shaper name "old". configure.ac | 8 + src/Makefile.am | 14 +- src/hb-old-private.hh | 40 +++ src/hb-old.cc | 369 ++++++++++++++++++++++++ src/hb-old/.gitignore | 7 - src/hb-old/Makefile.am | 2 + src/hb-old/Makefile.in | 762 ------------------------------------------------- src/hb-shape.cc | 8 +- 8 files changed, 436 insertions(+), 774 deletions(-) commit 5e1987005eb1b9af7a4d3d9f90c5768d8cc80015 Author: Behdad Esfahbod Date: Tue Jul 24 19:53:55 2012 -0400 [hb-old] Define Unicode funcs in terms of new HarfBuzz src/hb-old/Makefile.am | 4 + src/hb-old/Makefile.in | 182 ++++++++++++++++++++++++++++++++++++----- src/hb-old/harfbuzz-external.h | 100 +++++++++++++--------- 3 files changed, 224 insertions(+), 62 deletions(-) commit 4a31166b2853c1ec052844140e114158f47c2355 Author: Behdad Esfahbod Date: Tue Jul 24 19:49:48 2012 -0400 [hb-old] Shovel out the line-breaking / word-segmentation stuff src/hb-old/Makefile.am | 10 +- src/hb-old/Makefile.in | 13 +- src/hb-old/harfbuzz-external.h | 66 ------ src/hb-old/harfbuzz-indic.cpp | 26 --- src/hb-old/harfbuzz-khmer.c | 25 --- src/hb-old/harfbuzz-myanmar.c | 28 --- src/hb-old/harfbuzz-shaper-private.h | 12 -- src/hb-old/harfbuzz-shaper.cpp | 403 +++-------------------------------- src/hb-old/harfbuzz-shaper.h | 31 --- src/hb-old/harfbuzz-thai.c | 111 ---------- src/hb-old/harfbuzz-tibetan.c | 26 --- src/hb-old/harfbuzz.c | 32 --- 12 files changed, 33 insertions(+), 750 deletions(-) commit 0bcbe88cf313117f739b98a11dbe698b75784e9d Author: Behdad Esfahbod Date: Tue Jul 24 19:38:24 2012 -0400 [hb-old] Add visibility attributes src/hb-old/harfbuzz-global.h | 10 ++++++---- src/hb-old/harfbuzz-impl.h | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) commit 6a9d43c3178c920672a84382ca3797e3c478b2b0 Author: Behdad Esfahbod Date: Tue Jul 24 19:21:22 2012 -0400 [hb-old] Remove unused header file src/hb-old/harfbuzz-shape.h | 199 -------------------------------------------- 1 file changed, 199 deletions(-) commit fb47209c5b3aa992faf18d1a3f78b9d7682cf62f Author: Behdad Esfahbod Date: Tue Jul 24 19:20:19 2012 -0400 [hb-old] Rename hb_buffer_* to HB_Buffer_* src/hb-old/harfbuzz-buffer.c | 22 +++++++++++----------- src/hb-old/harfbuzz-buffer.h | 8 ++++---- src/hb-old/harfbuzz-shaper.cpp | 8 ++++---- 3 files changed, 19 insertions(+), 19 deletions(-) commit 1512a7357513b72e2a07dda706a176bb23d694e9 Author: Behdad Esfahbod Date: Tue Jul 24 19:16:56 2012 -0400 [hb-old] Start adding HarfBuzz-old as a new backend configure.ac | 1 + src/Makefile.am | 5 + src/hb-old/.gitignore | 7 + src/hb-old/COPYING | 24 + src/hb-old/Makefile.am | 56 + src/hb-old/Makefile.in | 631 ++++ src/hb-old/README | 7 + src/hb-old/harfbuzz-arabic.c | 1144 +++++++ src/hb-old/harfbuzz-buffer-private.h | 107 + src/hb-old/harfbuzz-buffer.c | 383 +++ src/hb-old/harfbuzz-buffer.h | 102 + src/hb-old/harfbuzz-external.h | 151 + src/hb-old/harfbuzz-gdef-private.h | 135 + src/hb-old/harfbuzz-gdef.c | 1163 +++++++ src/hb-old/harfbuzz-gdef.h | 140 + src/hb-old/harfbuzz-global.h | 118 + src/hb-old/harfbuzz-gpos-private.h | 729 ++++ src/hb-old/harfbuzz-gpos.c | 6094 ++++++++++++++++++++++++++++++++++ src/hb-old/harfbuzz-gpos.h | 155 + src/hb-old/harfbuzz-greek.c | 447 +++ src/hb-old/harfbuzz-gsub-private.h | 483 +++ src/hb-old/harfbuzz-gsub.c | 4329 ++++++++++++++++++++++++ src/hb-old/harfbuzz-gsub.h | 148 + src/hb-old/harfbuzz-hangul.c | 268 ++ src/hb-old/harfbuzz-hebrew.c | 187 ++ src/hb-old/harfbuzz-impl.c | 84 + src/hb-old/harfbuzz-impl.h | 131 + src/hb-old/harfbuzz-indic.cpp | 1894 +++++++++++ src/hb-old/harfbuzz-khmer.c | 667 ++++ src/hb-old/harfbuzz-myanmar.c | 539 +++ src/hb-old/harfbuzz-open-private.h | 102 + src/hb-old/harfbuzz-open.c | 1433 ++++++++ src/hb-old/harfbuzz-open.h | 288 ++ src/hb-old/harfbuzz-shape.h | 199 ++ src/hb-old/harfbuzz-shaper-all.cpp | 37 + src/hb-old/harfbuzz-shaper-private.h | 171 + src/hb-old/harfbuzz-shaper.cpp | 1338 ++++++++ src/hb-old/harfbuzz-shaper.h | 294 ++ src/hb-old/harfbuzz-stream-private.h | 81 + src/hb-old/harfbuzz-stream.c | 114 + src/hb-old/harfbuzz-stream.h | 51 + src/hb-old/harfbuzz-thai.c | 111 + src/hb-old/harfbuzz-tibetan.c | 274 ++ src/hb-old/harfbuzz.c | 32 + src/hb-old/harfbuzz.h | 38 + 45 files changed, 24892 insertions(+) commit 478fd0529b868b22905a9dedf331ac7cc9721723 Author: Behdad Esfahbod Date: Tue Jul 24 17:09:01 2012 -0400 Minor src/hb-unicode-private.hh | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) commit 8979a7f6f2b44ade4c0198a31ae08561b35ce009 Author: Behdad Esfahbod Date: Tue Jul 24 17:03:55 2012 -0400 [Mongolian] Remove Mongolian Vowel Separator at the end of shaping Results match Uniscribe now. src/hb-unicode-private.hh | 3 +++ 1 file changed, 3 insertions(+) commit aa6d849838d5231465ae1a25a4dd5ea1e9380ff9 Author: Jonathan Kew Date: Tue Jul 24 15:52:32 2012 -0400 [CoreText] Add basic Core Text backend for comparison with our native shaping Does not attempt to handle clusters in a Uniscribe- or HarfBuzz-compatible way; just returns the original string indexes that CT maintains. These may even be out-of-order in the case of reordrant glyphs. configure.ac | 12 ++ src/Makefile.am | 7 + src/hb-coretext-private.hh | 42 ++++++ src/hb-coretext.cc | 323 +++++++++++++++++++++++++++++++++++++++++++++ src/hb-coretext.h | 43 ++++++ src/hb-shape.cc | 6 + 6 files changed, 433 insertions(+) commit ec8d2494694275dfbbac2dd0d33ca2894b0463d6 Author: Behdad Esfahbod Date: Tue Jul 24 15:40:37 2012 -0400 Make data members of various OpenType structs protected instead of private Should fix warnings generated when building with -Wunused-private-field. Based on patch from Jonathan Kew. src/hb-open-file-private.hh | 8 +++--- src/hb-ot-head-table.hh | 2 +- src/hb-ot-hhea-table.hh | 2 +- src/hb-ot-hmtx-table.hh | 2 +- src/hb-ot-layout-common-private.hh | 14 ++++++----- src/hb-ot-layout-gdef-table.hh | 20 +++++++-------- src/hb-ot-layout-gpos-table.hh | 48 ++++++++++++++++++------------------ src/hb-ot-layout-gsub-table.hh | 30 +++++++++++----------- src/hb-ot-layout-gsubgpos-private.hh | 32 ++++++++++++------------ src/hb-ot-maxp-table.hh | 2 +- src/hb-ot-name-table.hh | 2 +- 11 files changed, 82 insertions(+), 80 deletions(-) commit 97aa0b738a33b73a3f9763dd2950f2dd39f596ed Author: Behdad Esfahbod Date: Tue Jul 24 15:02:34 2012 -0400 Minor const correctness shuffling src/hb-shape.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 6411e74caf23af7b0545f1fe54d19a1c8da895e8 Author: Behdad Esfahbod Date: Tue Jul 24 13:48:49 2012 -0400 [Indic] Reposition Gurmukhi top matras to after post The font is forming a post-base consonant in some samples, and Uniscribe positions top matra on the post-base. Do the same. Gurmukhi failures down from 59 to 41 (0.0674242%). src/hb-ot-shape-complex-indic.cc | 2 +- .../texts/in-tree/shaper-indic/indic/script-gurmukhi/misc/misc.txt | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) commit c3f769ba09df319fa69d04f68c57444f95eceee6 Author: Behdad Esfahbod Date: Tue Jul 24 13:26:32 2012 -0400 [Indic] Ignore Uniscribe output containing two zero-width space glyphs Uniscribe is buggy and sometimes /eats/ a mark next to a non-joiner. Most of Malayalam failures where actually hitting this bug. Ignore test output with two zero-width space glyphs. This is a hack until we build up the test suite infrastructure better. Bengali went down by 9, Devanagari by 2, Kannada by 130, Malayalm down from 1197 to 307, Sinhala down by 16, Telugu down by 26. New stats: BENGALI: 353996 out of 354285 tests passed. 289 failed (0.0815727%) DEVANAGARI: 693573 out of 693628 tests passed. 55 failed (0.00792932%) GUJARATI: 366489 out of 366506 tests passed. 17 failed (0.0046384%) GURMUKHI: 60750 out of 60809 tests passed. 59 failed (0.0970251%) KANNADA: 951086 out of 951913 tests passed. 827 failed (0.0868777%) KHMER: 299094 out of 299124 tests passed. 30 failed (0.0100293%) MALAYALAM: 1048109 out of 1048416 tests passed. 307 failed (0.0292823%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271715 out of 271847 tests passed. 132 failed (0.0485567%) TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%) TELUGU: 970550 out of 970573 tests passed. 23 failed (0.00236973%) test/shaping/hb_test_tools.py | 1 + .../texts/in-tree/shaper-indic/indic/script-malayalam/misc/misc.txt | 2 ++ 2 files changed, 3 insertions(+) commit 65c43accdc4d2082282d5cedba8514b8df0c18a2 Author: Behdad Esfahbod Date: Tue Jul 24 03:36:47 2012 -0400 [Indic] Better position left-matra in Malayalam Just put it before base, which is what's expected. Malayalam failures down from 1559 to 1197 (0.114172%). BENGALI: 353988 out of 354285 tests passed. 297 failed (0.0838308%) DEVANAGARI: 693571 out of 693628 tests passed. 57 failed (0.00821766%) GUJARATI: 366489 out of 366506 tests passed. 17 failed (0.0046384%) GURMUKHI: 60750 out of 60809 tests passed. 59 failed (0.0970251%) KANNADA: 950956 out of 951913 tests passed. 957 failed (0.100534%) KHMER: 299094 out of 299124 tests passed. 30 failed (0.0100293%) MALAYALAM: 1047219 out of 1048416 tests passed. 1197 failed (0.114172%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271699 out of 271847 tests passed. 148 failed (0.0544424%) TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%) TELUGU: 970524 out of 970573 tests passed. 49 failed (0.00504856%) src/hb-ot-shape-complex-indic.cc | 41 +++++++++++++++------- .../indic/script-malayalam/misc/misc.txt | 1 + 2 files changed, 29 insertions(+), 13 deletions(-) commit 88f413b56f2858d149e2fc067685aeecaea779ca Author: Behdad Esfahbod Date: Tue Jul 24 03:04:36 2012 -0400 [Indic] Implement Reph+Ya-Phalaa interaction The sequence Ra,H,Ya in Bengali is ambigious and Unicode encoded that to get Ya-Phalaa, one would place ZWJ before Halant. Ie. a ZWJ,H sequence requests subjoining, while a H,ZWJ requests Half form. Implement that. Bengali failures go down from 377 to 297 (0.0838308%). Gujarati is down by 4 to 17 (0.0046384%). Kannada is down by 226 to 957 (0.100534%). Current status: BENGALI: 353988 out of 354285 tests passed. 297 failed (0.0838308%) DEVANAGARI: 693571 out of 693628 tests passed. 57 failed (0.00821766%) GUJARATI: 366489 out of 366506 tests passed. 17 failed (0.0046384%) GURMUKHI: 60750 out of 60809 tests passed. 59 failed (0.0970251%) KANNADA: 950956 out of 951913 tests passed. 957 failed (0.100534%) KHMER: 299094 out of 299124 tests passed. 30 failed (0.0100293%) MALAYALAM: 1046857 out of 1048416 tests passed. 1559 failed (0.148701%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271699 out of 271847 tests passed. 148 failed (0.0544424%) TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%) TELUGU: 970524 out of 970573 tests passed. 49 failed (0.00504856%) src/hb-ot-shape-complex-indic.cc | 10 ++++++++-- .../in-tree/shaper-indic/indic/script-bengali/misc/reph.txt | 4 ++++ 2 files changed, 12 insertions(+), 2 deletions(-) commit dff0ece11d61978c04e839501f179a5c3077f340 Author: Behdad Esfahbod Date: Tue Jul 24 02:30:38 2012 -0400 [Indic] Limit matras to 4 per syllable Also limit joiners. This limits our syllable length to a constant, and is closer to what Uniscribe does anyway. Two Devanagari tests regressed, but who cares about tests with 20 joiners in a row?! Devanagari at 57 (0.00821766%) now. src/hb-ot-shape-complex-indic-machine.rl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 330b329c8905a37ca88c556dea82c70d74c77458 Author: Behdad Esfahbod Date: Tue Jul 24 02:25:26 2012 -0400 [Indic] Unmark U+17D1 KHMER SIGN VIRIAM to NOT be a Virama Fixes another 1 Khmer failure. Down to 30 (0.0100293%) now. src/hb-ot-shape-complex-indic.cc | 2 ++ .../in-tree/shaper-indic/south-east-asian/script-khmer/misc/misc.txt | 1 + 2 files changed, 3 insertions(+) commit 6824a7194e01b77eddb95bd95a9b32e219140912 Author: Behdad Esfahbod Date: Tue Jul 24 02:22:18 2012 -0400 [Indic] Recategorize Khmer various signs as top matras Khmer failures down from 39 to 31 (0.0103636%). src/hb-ot-shape-complex-indic.cc | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) commit d90b8e841e0068a601c96ab184d18b0f48eec9d1 Author: Behdad Esfahbod Date: Tue Jul 24 02:10:20 2012 -0400 [Indic] Reposition Khmer prebase-reordering Ra around split matras In Khmer coeng model, a V,Ra can go *after* matras. If it goes after a split matra, it should be reordered to *before* the left part of such matra. Khmer failures down from 136 to 39 (0.0130381%). src/hb-ot-shape-complex-indic.cc | 13 +++++++++++++ .../south-east-asian/script-khmer/misc/misc.txt | 4 ++++ 2 files changed, 17 insertions(+) commit 0afb84c12567ac35adac657bf8be29999b8c5a50 Author: Behdad Esfahbod Date: Tue Jul 24 01:44:47 2012 -0400 [Indic] Fix minor bug in pre-base Ra positioning src/hb-ot-shape-complex-indic.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 7573799126e812a047daa5f64121ec959866b3c8 Author: Behdad Esfahbod Date: Tue Jul 24 01:32:07 2012 -0400 [Indic] Position Khmer U+17CE Fixes another 6 Khmer failures. Now at 136 (0.0454661%). src/hb-ot-shape-complex-indic.cc | 6 ++++++ .../shaper-indic/south-east-asian/script-khmer/misc/misc.txt | 1 + 2 files changed, 7 insertions(+) commit 8d00e8d0e7d10f823e6975fecaffb9d557b1a99a Author: Behdad Esfahbod Date: Tue Jul 24 01:04:18 2012 -0400 [Indic] Don't reposition Khmer Bindu Khmer Bindu doesn't like to move to syllable end. Leave it where it was. Brings down Khmer failures from 510 to 142 (0.047572%). src/hb-ot-shape-complex-indic.cc | 2 ++ 1 file changed, 2 insertions(+) commit 2278eefcdb3dd0d492b9d07176fbecc1f0516bb7 Author: Behdad Esfahbod Date: Tue Jul 24 00:26:43 2012 -0400 [Indic] In Sinhala, form forced Reph even if no other consonant found Fixes another 10 Sinhala failures. Down to 148 (0.0544424%). src/hb-ot-shape-complex-indic.cc | 10 +++++----- .../in-tree/shaper-indic/indic/script-sinhala/misc/misc.txt | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) commit 71fd5e80ad06c8e85a1112cc89e129d6cd03f82c Author: Behdad Esfahbod Date: Tue Jul 24 00:21:16 2012 -0400 [Indic] Further adjust base algorithm for Sinhala Apparently if there is C,V,ZWJ,C, the first C will be base, but if it's C,ZWJ,V,C, the second one will be. Note that Uniscribe implements this differently, by breaking syllable in the case of C,ZWJ,V,C and putting the first consonant in one syllable and the rest in the next syllable. Sinhala failures down from 208 to 158 (0.0581209%). No changes to Khmer. src/hb-ot-shape-complex-indic.cc | 11 +++++++---- .../in-tree/shaper-indic/indic/script-sinhala/misc/misc.txt | 3 +++ 2 files changed, 10 insertions(+), 4 deletions(-) commit 73d71cc527d28fd5519c5d965c272ea1fb149a0e Author: Behdad Esfahbod Date: Tue Jul 24 00:09:12 2012 -0400 [Indic] End Vowel-based syllable at ZWJ One Devanagari test regressed, plus 10 Malayalam (at 1545 now). Fixed 120 Sinhala failures. Now at 208 (0.0765136%). src/hb-ot-shape-complex-indic-machine.rl | 2 +- .../texts/in-tree/shaper-indic/indic/script-sinhala/misc/misc.txt | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) commit 34c215036f5fcdc7599b1ab0591b56dbb3811902 Author: Behdad Esfahbod Date: Mon Jul 23 23:51:29 2012 -0400 [Indic] Improve Sinhala base algorithm and reph positioning Sinhala does not have half forms. And most (all?) consonants can be base, except when preceded by ZWJ, which would request a subjoined form. Hence switch the base algorithm to categorize with Khmer, start search at start, and stop at a ZWJ. Also, mark all pos=base consonants after base to be subjoined. Mark base itself to have pos=base. Finally, adjust Sinhala's reph position to after-main. Brings down Sinhala failures from 455 to 328 (0.120656%). src/hb-ot-shape-complex-indic.cc | 18 +++++++++++++++++- .../shaper-indic/indic/script-sinhala/misc/misc.txt | 1 + 2 files changed, 18 insertions(+), 1 deletion(-) commit 2ec934c6c25423e7af20d909a9c698a149808ea9 Author: Behdad Esfahbod Date: Mon Jul 23 23:49:04 2012 -0400 [Indic] Change "unknown" position to end of syllable src/hb-ot-shape-complex-indic-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b70021f7c81a0ed08475b14b07291f662cd9f905 Author: Behdad Esfahbod Date: Mon Jul 23 20:18:17 2012 -0400 When removing zero-width marks, don't remove ligatures If a mark ligated, it probably should NOT be removed. src/hb-ot-shape.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 49c5ec51444f27f33e1eb6aa1959c61b08fa89c0 Author: Behdad Esfahbod Date: Mon Jul 23 20:14:13 2012 -0400 Minor refactoring src/hb-ot-layout-gsubgpos-private.hh | 32 -------------------------------- src/hb-ot-layout-private.hh | 35 +++++++++++++++++++++++++++++++++++ src/hb-ot-shape-complex-indic.cc | 2 +- 3 files changed, 36 insertions(+), 33 deletions(-) commit c3e6fdc3791168cf2b4c9412e751f187d58faa42 Author: Behdad Esfahbod Date: Mon Jul 23 20:11:42 2012 -0400 [Indic] Improve check on ligatures Only skip actual ligatures, not marks in-between ligature components. src/hb-ot-layout-gsubgpos-private.hh | 5 +++++ src/hb-ot-shape-complex-indic.cc | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) commit 771a8f50289e8fa458cfc3cd84f73a380ce98077 Author: Behdad Esfahbod Date: Mon Jul 23 20:07:50 2012 -0400 [Indic] exclude ligatures when matching on Indic category If, say, a H,ZWJ,C ligature was formed, we don't want the code to detec that as a Halant. So, ignore ligatures when matching category in final_reordering. Sinhala failures down from 514 to 455 (0.167374%). src/hb-ot-shape-complex-indic.cc | 41 ++++++++++++---------- .../indic/script-sinhala/misc/misc.txt | 1 + 2 files changed, 23 insertions(+), 19 deletions(-) commit d1af9e82e5309158ed334ab8e21f3a3b64b9540f Author: Behdad Esfahbod Date: Mon Jul 23 19:55:35 2012 -0400 [GSUB/GPOS] Const correctness src/hb-ot-layout-gsubgpos-private.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit baacd090df97610e3f6d1b2a110dc67b6c6f9f5c Author: Behdad Esfahbod Date: Mon Jul 23 19:51:48 2012 -0400 [Indic] Minor refactoring src/hb-ot-shape-complex-indic.cc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) commit c7c4de2fb9bba216e37875d79815eef55c0acc01 Author: Behdad Esfahbod Date: Mon Jul 23 18:25:02 2012 -0400 [Indic] Remove syllable length check before sorting We now limit syllable lengths in the machine. No need to match here. src/hb-ot-shape-complex-indic.cc | 2 -- 1 file changed, 2 deletions(-) commit 9fa052733eb93a3ce1205f63ff8f74cb295cbe99 Author: Behdad Esfahbod Date: Mon Jul 23 18:19:17 2012 -0400 [Indic] Limit syllables to at most five consonants Seems to be about what Uniscribe does. Not exactly. But close enough. More consonants will start a new cluster. A few scripts went way down in failures. In particular: - Devanagari failures went down from 490 to 56. - Telugu went down from 113 to 49. Other scripts went down slightly or didn't change. New numbers: BENGALI: 353908 out of 354285 tests passed. 377 failed (0.106412%) DEVANAGARI: 693572 out of 693628 tests passed. 56 failed (0.00807349%) GUJARATI: 366485 out of 366506 tests passed. 21 failed (0.00572978%) GURMUKHI: 60750 out of 60809 tests passed. 59 failed (0.0970251%) KANNADA: 950730 out of 951913 tests passed. 1183 failed (0.124276%) KHMER: 298613 out of 299124 tests passed. 511 failed (0.170832%) MALAYALAM: 1046881 out of 1048416 tests passed. 1535 failed (0.146411%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271333 out of 271847 tests passed. 514 failed (0.189077%) TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%) TELUGU: 970524 out of 970573 tests passed. 49 failed (0.00504856%) Some of the remaining Telugu and Devanagari issues seem to be Uniscribe eating Anusvara when placed before a non-joiner. Ouch! src/hb-ot-shape-complex-indic-machine.rl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 093cd583263a5d427e3377b31585043fb55d2557 Author: Behdad Esfahbod Date: Mon Jul 23 14:04:42 2012 -0400 [Thai] Fix SARA AM handling Oops, thinko. src/hb-ot-shape-complex-misc.cc | 6 +++--- src/hb-private.hh | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) commit 42848453bf260b456b46a07f066e31b8c3aac2f1 Author: Behdad Esfahbod Date: Mon Jul 23 13:52:07 2012 -0400 [Thai] Reorder U+0E3A THAI VOWEL SIGN PHINTHU Uniscribe reorders U+0E3A to be after U+0E38 and U+0E39. We do that by modifying the ccc for U+0E3A. Fixes the two remaining Thai failures (see previous commit). src/hb-ot-shape-complex-misc.cc | 7 +++++++ src/hb-unicode.cc | 6 ++++++ .../texts/in-tree/shaper-thai/script-thai/misc/MANIFEST | 1 + .../in-tree/shaper-thai/script-thai/misc/phinthu.txt | 16 ++++++++++++++++ 4 files changed, 30 insertions(+) commit 4a7f4f3e56f8f7640ae7337aa1b3324f31e0d4ab Author: Behdad Esfahbod Date: Mon Jul 23 13:15:33 2012 -0400 [Thai] Adjust SARA AM reordering to match Uniscribe Adjust the list of marks before SARA AM that get the reordering treatment. Also adjust cluster formation to match Uniscribe. With Wikipedia test data, now I see: - For Thai, with the Angsana New font from Win7, I see 54 failures out of over 4M tests (0.00129107%). Of the 54, two are legitimate reordering issues (fix coming soon), and the other 52 are simply Uniscribe using a zero-width space char instead of an unknown character for missing glyphs. No idea why. The missing-glyph sequences include one that is a Thai character followed by an Arabic Sokun. Someone confused it with Nikhahit I assume! - For Lao, with the Dokchampa font from Win7, 33 tests fail out of 54k (0.0615167%). All seem to be insignificant mark positioning with two marks on a base. Have to investigate. src/hb-ot-shape-complex-misc.cc | 42 +++++++++++++--------- src/hb-private.hh | 6 ++++ test/shaping/texts/in-tree/shaper-thai/MANIFEST | 1 + .../texts/in-tree/shaper-thai/script-lao/MANIFEST | 1 + .../in-tree/shaper-thai/script-lao/misc/MANIFEST | 1 + .../shaper-thai/script-lao/misc/sara-am.txt | 20 +++++++++++ .../shaper-thai/script-thai/misc/sara-am.txt | 18 +++++++++- 7 files changed, 72 insertions(+), 17 deletions(-) commit 2cc933aff97916e5d0fe42883f40f0879f848e25 Author: Behdad Esfahbod Date: Mon Jul 23 08:22:55 2012 -0400 [Indic] Fix cluster formation with left-matras and conjunct forms Test case was: . src/hb-ot-shape-complex-indic.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit e6b01a878cd2e63cb675e7e0c6ac4d83a8c10f37 Author: Behdad Esfahbod Date: Mon Jul 23 00:11:26 2012 -0400 [Indic] Further streamline cluster formation This should address all possible cluster misformations that I had in mind. src/hb-ot-shape-complex-indic.cc | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) commit 7b2a7dadd6c616bbfe1d8358700cab9cee88e584 Author: Behdad Esfahbod Date: Sun Jul 22 23:58:55 2012 -0400 [Indic] Merge clusters before sorting This should fix any instabilities in cluster formation that we were speculating may happen with surrounding syllables. Or most of it perhaps. src/hb-ot-shape-complex-indic.cc | 4 ++++ 1 file changed, 4 insertions(+) commit abb3239ef92cc5dccb4638806d7ae9868b9ac9b3 Author: Behdad Esfahbod Date: Sun Jul 22 23:55:19 2012 -0400 [Indic] Update clusters for left-matra even if matra didn't move Fixes crashes reported with left matra under non-uniscribe-bug-compatibilty mode. src/hb-ot-shape-complex-indic.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) commit 60554f14d8dca208721f0da8b69d84b92819c54f Author: Behdad Esfahbod Date: Sun Jul 22 23:23:56 2012 -0400 [Indic] Merge in Malayalam tests From: http://silpa.org.in/pub/tests/hb/ml/ml-harfbuzz-testdata.txt .../indic/script-malayalam/misc/misc.txt | 94 +++++++++++----------- 1 file changed, 46 insertions(+), 48 deletions(-) commit 5c7081770c7a611bbe79b451b7b86dec4fa6395d Author: Behdad Esfahbod Date: Sun Jul 22 23:20:27 2012 -0400 [Indic] Add extensive Sinhala tests Generated by: http://git.savannah.gnu.org/cgit/sinhala.git/plain/utils/gen-unicode-sinhala.py .../indic/script-sinhala/misc/extensive.txt | 4390 ++++++++++++++++++++ 1 file changed, 4390 insertions(+) commit 2efe4707b1b449962f6e161716477d9775456c46 Author: Behdad Esfahbod Date: Sun Jul 22 23:17:59 2012 -0400 [Indic] Add Sinhala tests Merge tests from: http://git.savannah.gnu.org/cgit/sinhala.git/plain/patches/icu-sinhala-rendering.txt .../indic/script-sinhala/misc/misc.txt | 26 ++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) commit 3d4c111b7a13700b2f7a0b087eb3992283295f21 Author: Behdad Esfahbod Date: Fri Jul 20 19:34:39 2012 -0400 Add a test case .../texts/in-tree/shaper-indic/indic/script-bengali/misc/misc.txt | 1 + 1 file changed, 1 insertion(+) commit 92a1ad7bef9efb456ab87bd63818cfbed7da3f6f Author: Behdad Esfahbod Date: Fri Jul 20 18:38:27 2012 -0400 [Indic] Stop searching for base if a post form is found before below form Improves Bengali and Gurmukhi. Malayalam regressed a bit. We will deal with that later. src/hb-ot-shape-complex-indic.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 4c450c703f8e4618c587bcd7ef46dcc1f2c7947b Author: Behdad Esfahbod Date: Fri Jul 20 18:13:04 2012 -0400 [Indic] Recompose Bengali Ya,Nukta This is a bunch of hacks for now. Improves Bengali a bit. src/hb-ot-shape-complex-indic.cc | 4 ++-- src/hb-unicode.cc | 8 ++++++++ 2 files changed, 10 insertions(+), 2 deletions(-) commit e9c0f152a38cb2e76650a3e43f7fdcda266af696 Author: Behdad Esfahbod Date: Fri Jul 20 17:05:46 2012 -0400 [Uniscribe] Fix script fallback Gurmukhi failures half now. Others changed slightly. src/hb-uniscribe.cc | 34 ++++++++++++++-------------------- 1 file changed, 14 insertions(+), 20 deletions(-) commit 5791f329159c9863317e2b507514c29321be31a7 Author: Behdad Esfahbod Date: Fri Jul 20 16:26:55 2012 -0400 [Indic] Allow a ZWNJ after SM's Malayalam failures go way down. Other scripts benefitted slightly too. Sinhala had one or two test regressions, but... src/hb-ot-shape-complex-indic-machine.rl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 34ae336f3fae93ef9372881d545c817bce383041 Author: Behdad Esfahbod Date: Fri Jul 20 16:17:28 2012 -0400 [Indic] Improve Reph AfterMain positioning Fixes 20 out of 48 failing Oriya tests. Failure rate down to 0.066% now. src/hb-ot-shape-complex-indic.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit bdd080431a40bc941ece3230f338b94a46bd12a2 Author: Behdad Esfahbod Date: Fri Jul 20 16:03:09 2012 -0400 [Indic] Reposition Oriya Candrabindu Oriya failures down from 0.65% to 0.20%. src/hb-ot-shape-complex-indic.cc | 1 + .../shaping/texts/in-tree/shaper-indic/indic/script-oriya/misc/MANIFEST | 1 + .../texts/in-tree/shaper-indic/indic/script-oriya/misc/bindu.txt | 2 ++ 3 files changed, 4 insertions(+) commit 5f0eaaad129ff04d56b8756bebf19fbc242718c9 Author: Behdad Esfahbod Date: Fri Jul 20 15:47:24 2012 -0400 [Indic] Fix base search in final_reordering Fixes most Malayalam failures. Down from 1.6% to 0.38% now. Fixes a few more in other scripts too. src/hb-ot-shape-complex-indic.cc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) commit 81202bd860e4034c18d9f80c5a4f33d9f48463a3 Author: Behdad Esfahbod Date: Fri Jul 20 15:10:02 2012 -0400 [Indic] Don't attach SM/VD to other characters src/hb-ot-shape-complex-indic-private.hh | 3 +++ src/hb-ot-shape-complex-indic.cc | 38 ++++++++++++++++++-------------- 2 files changed, 24 insertions(+), 17 deletions(-) commit efb4ad735691837a52447bedc1a66a87d0d9af51 Author: Behdad Esfahbod Date: Fri Jul 20 14:27:38 2012 -0400 Fix compiler warnings If x is not constant, we cannot ASSERT_STATIC on it. src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f31d97e44eeb6fb141f3de928e27e033fc7b1f47 Author: Behdad Esfahbod Date: Fri Jul 20 14:13:35 2012 -0400 [Indic] Form Telugu Reph out of Ra,Virama,ZWJ Apparently this was approved in Feb 2012. No font yet. src/hb-ot-shape-complex-indic-private.hh | 2 +- src/hb-ot-shape-complex-indic.cc | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) commit 2e193b240ec85cab0d4e2f8a375c5a7f0ef99985 Author: Behdad Esfahbod Date: Fri Jul 20 14:02:35 2012 -0400 [Indic] Don't split U+0AC9 Althought IndicMatraCategory.txt classifies it as Top_And_Right matra, it does not have Unicode decomposition, and Uniscribe does not do anything special about it either. Gujarati failures down from 0.672% to 0.0130966%. src/hb-unicode.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 30c3d5e9fc61b49c2c6ad4e744300edd6f3e0261 Author: Behdad Esfahbod Date: Fri Jul 20 13:56:32 2012 -0400 [Indic] Simplify Uniscribe cluster emulation Now that we break syllables on Halant,ZWNJ, this code can be simplified. src/hb-ot-shape-complex-indic.cc | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) commit decf6ffca475fe01ff3151b7641f629f031137d2 Author: Behdad Esfahbod Date: Fri Jul 20 13:51:31 2012 -0400 [Indic] Minor! src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9e4f94a72cea6d65a6a7ba5a47db92e00dbfbb91 Author: Behdad Esfahbod Date: Fri Jul 20 13:48:03 2012 -0400 [Indic] Break syllables at Halant,ZWNJ That's really what Uniscribe does, and explains a lot of pecularities of Halant,ZWNJ before the base. Sent Telugu from 1% failures to 0.03%. Improved Kannada and Malayalam slightly. Fixed half of Bengali, and did NOT break anything! src/hb-ot-shape-complex-indic-machine.rl | 5 +++-- src/hb-ot-shape-complex-indic.cc | 5 ++--- 2 files changed, 5 insertions(+), 5 deletions(-) commit 2c372b80f6befad69e216e3f218b38640b8cc044 Author: Behdad Esfahbod Date: Fri Jul 20 13:37:48 2012 -0400 [Indic] Better check for applying 'init' Specifically, don't apply 'init' if previous char is a joiner. Fixes some more of Bengali. src/hb-ot-shape-complex-indic.cc | 9 +-------- src/hb-private.hh | 3 ++- 2 files changed, 3 insertions(+), 9 deletions(-) commit 34a7440b7c6c6e53394ddbdbedaad57b23f85105 Author: Behdad Esfahbod Date: Fri Jul 20 12:32:59 2012 -0400 [GPOS] Don't zero mark advances Fixes more of Telugu, Kannada, and Oriya. May break things (outside Indic...), but we cannot think of any font relying on this immediately. src/hb-ot-layout-gpos-table.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 8ed248de77e5d2ed978e55c0ce1a11727bc9e34c Author: Behdad Esfahbod Date: Fri Jul 20 11:42:24 2012 -0400 [Indic] Minor src/hb-ot-shape-complex-indic.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit d0e68dbd0b9fc9a42c4280d01c8ffd9c5015d550 Author: Behdad Esfahbod Date: Fri Jul 20 11:25:41 2012 -0400 [Indic] Implement reph positioning step 5 Not tuned, just copied from step 2. Fixes another 0.5% of Kannada failures. 1% to go. src/hb-ot-shape-complex-indic.cc | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit a9e45c32e4a0d6da33c52f8427aa694e57f52eb9 Author: Behdad Esfahbod Date: Fri Jul 20 11:04:15 2012 -0400 [Indic] Don't let ZWNJ at the end of syllable affect base search Fixes a few Devanagari, half of remaining Kannada failures, quarter for Telugu, and others slightly improved or unchanged. src/hb-ot-shape-complex-indic.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 20b68e699f73e6ce046c0ec143d40b3d6d48e06b Author: Behdad Esfahbod Date: Fri Jul 20 10:47:46 2012 -0400 [Indic] Apply 'cjct' globally Fixes 5 Devanagari failures, and no regressions. src/hb-ot-shape-complex-indic.cc | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) commit 51e764de441072e7c9f67de23e8ed717b9b8957d Author: Behdad Esfahbod Date: Fri Jul 20 10:30:24 2012 -0400 [Indic] Unbreak old scriptures Brings down failures with Lohit-Telugu from 57% to 1.40%. src/hb-ot-shape-complex-indic.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 900cf3d449bf36d4f8b1474590cae925fef48fc8 Author: Behdad Esfahbod Date: Fri Jul 20 10:18:23 2012 -0400 Minor src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 87cd63266e73af316b250573ef57388a0bcc9133 Author: Behdad Esfahbod Date: Thu Jul 19 21:17:48 2012 -0400 [Indic] Recategorize some Kannada right matras Kannada failures down from 3.5% to 2.93%. src/hb-ot-shape-complex-indic.cc | 2 +- .../texts/in-tree/shaper-indic/indic/script-kannada/misc/MANIFEST | 1 + .../shaper-indic/indic/script-kannada/misc/right-matras.txt | 7 +++++++ 3 files changed, 9 insertions(+), 1 deletion(-) commit 3604d64ced909ade91998d294a7b4b2ee14d47aa Author: Behdad Esfahbod Date: Thu Jul 19 21:13:04 2012 -0400 [Indic] Recategorize GURMUKHI ADDAK It's not in IndicSyllabicCategory.txt. Fixes most of Gurmukhi failures. Failures down from 7.7% to 0.222%! src/hb-ot-shape-complex-indic.cc | 1 + 1 file changed, 1 insertion(+) commit 89328581236a53ec16508b95db54c7e5315b178f Author: Behdad Esfahbod Date: Thu Jul 19 21:02:38 2012 -0400 Minor src/hb-ot-layout-gsubgpos-private.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 47ef931f13778b894090139a64238a5ab9ac1154 Author: Behdad Esfahbod Date: Thu Jul 19 20:52:44 2012 -0400 [buffer] Make sure out_info = info during GPOS src/hb-buffer.cc | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) commit ae63cf206291befe3920adfe015e6cd0961580e5 Author: Behdad Esfahbod Date: Thu Jul 19 20:45:41 2012 -0400 Print line number during return when tracing src/hb-private.hh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 5249f3aee108b0f41770d137e63a625f594418e7 Author: Behdad Esfahbod Date: Thu Jul 19 20:30:22 2012 -0400 [Indic] Unbreak Khmer For Khmer, all consonants are subjoining. No need to look in the font. We were looking in the wrong order anyway. src/hb-ot-shape-complex-indic.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit e0475345d5d7db8dbc8b554beedfa2435c5d7fd1 Author: Behdad Esfahbod Date: Thu Jul 19 20:24:14 2012 -0400 [Indic] Apply 'akhn' globally Fixes 1.5% more failures for Telugu, 2% for Kannada. Breaks one test in Devanagari. src/hb-ot-shape-complex-indic.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit c87bcddb10752b407c0471ee5ac4de6f1b00b711 Author: Behdad Esfahbod Date: Thu Jul 19 20:03:25 2012 -0400 [Indic] Add failing test for Kannada .../texts/in-tree/shaper-indic/indic/script-kannada/misc/misc.txt | 1 + 1 file changed, 1 insertion(+) commit fa247ebe524f92fa95d344ba912f704262879c13 Author: Behdad Esfahbod Date: Thu Jul 19 19:52:19 2012 -0400 [Indic] Better position U+0CD5 Fixes another 5% of Kannada failures. src/hb-ot-shape-complex-indic.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit f055442716ec7543ed156d4789955b19c11a5255 Author: Behdad Esfahbod Date: Thu Jul 19 16:20:21 2012 -0400 [Indic] Lookup consonant position in the font Fixes most failures of Oriya, and improves others a bit. src/hb-ot-map-private.hh | 13 ++-- src/hb-ot-shape-complex-indic-private.hh | 105 ------------------------------- src/hb-ot-shape-complex-indic.cc | 63 +++++++++++++------ 3 files changed, 54 insertions(+), 127 deletions(-) commit 74d1d88781e91866a52e27f391e34df03b313442 Author: Behdad Esfahbod Date: Thu Jul 19 16:14:23 2012 -0400 [GSUB] Fix would_apply() for LigatureSubst src/hb-ot-layout-gsub-table.hh | 1 + 1 file changed, 1 insertion(+) commit 787f7d1e9ba9ad038f24e5a1063d12c7d169ad37 Author: Behdad Esfahbod Date: Thu Jul 19 15:29:13 2012 -0400 [TODO] Minor TODO | 2 ++ 1 file changed, 2 insertions(+) commit be73a5f9368136ecbdb211b96516ad0c554c8201 Author: Behdad Esfahbod Date: Thu Jul 19 14:59:15 2012 -0400 Add src/test-would-substitute tool src/Makefile.am | 6 +- src/test-would-substitute.cc | 94 ++++++++++++++++++++++++++++++ src/test.cc | 132 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 231 insertions(+), 1 deletion(-) commit e72b360ac6381b549249b8836fa3e70b909d3437 Author: Behdad Esfahbod Date: Thu Jul 19 14:35:23 2012 -0400 Refactor / finish would_apply() operation Untested. src/hb-ot-layout-gpos-table.hh | 6 +- src/hb-ot-layout-gsub-table.hh | 126 +++++++++---------- src/hb-ot-layout-gsubgpos-private.hh | 233 ++++++++++++++++++++++++++++++++++- src/hb-ot-layout.cc | 11 ++ src/hb-ot-layout.h | 7 ++ 5 files changed, 308 insertions(+), 75 deletions(-) commit 8c973ebf0f59abb5ee920edd5d64e23d8e47ad75 Author: Behdad Esfahbod Date: Thu Jul 19 13:25:08 2012 -0400 [Indic] Implement per-script matra positioning Following what the spec says. Brings down Telugu failures from 40% to 3.75%, and Kannada failures from 44% to 10%. Does NOT affect other scripts' test results. src/hb-ot-shape-complex-indic-private.hh | 2 +- src/hb-ot-shape-complex-indic.cc | 40 +++++++++++++++++++++++++++++--- src/hb-unicode.cc | 2 +- 3 files changed, 39 insertions(+), 5 deletions(-) commit 8bb32458f95f13f66688e0811cc91f1bfffb867d Author: Behdad Esfahbod Date: Thu Jul 19 12:59:06 2012 -0400 [Indic] More refactoring src/hb-ot-shape-complex-indic-private.hh | 9 ++--- src/hb-ot-shape-complex-indic.cc | 65 ++++++++++++++++++++++++-------- 2 files changed, 54 insertions(+), 20 deletions(-) commit 9ccc6382ba43760167c134c18c1c4ada4b8c3f22 Author: Behdad Esfahbod Date: Thu Jul 19 12:32:16 2012 -0400 [Indic] Minor refactoring src/hb-ot-shape-complex-indic.cc | 127 ++++++++++++++++++++++----------------- 1 file changed, 71 insertions(+), 56 deletions(-) commit f83aaa3133de5d807be267a100d6a200e8db9017 Author: Behdad Esfahbod Date: Thu Jul 19 12:23:23 2012 -0400 [Indic] Minor src/hb-ot-shape-complex-indic-private.hh | 42 ++++++++++++++++++++------------ 1 file changed, 26 insertions(+), 16 deletions(-) commit be8b9f5f715f6fb36b98bd33c3303f79cc068f8a Author: Behdad Esfahbod Date: Thu Jul 19 12:11:12 2012 -0400 [Indic] Start refactoring different matra positions per script src/hb-ot-shape-complex-indic-private.hh | 36 +++++++++++++++++++------------- src/hb-ot-shape-complex-indic.cc | 4 ++-- 2 files changed, 24 insertions(+), 16 deletions(-) commit deeb540a74f8d394db273145b17bf385d14d01bb Author: Behdad Esfahbod Date: Thu Jul 19 11:30:48 2012 -0400 [test] Ignore tests with DOTTED CIRCLE in the output test/shaping/hb_test_tools.py | 4 ++++ 1 file changed, 4 insertions(+) commit b01d9b3d90e892341ee4463f2eda4600850b97d8 Author: Behdad Esfahbod Date: Thu Jul 19 11:25:49 2012 -0400 [Indic] Disallow decomposition of a couple characters This is a hack for now. Will be fixed when we do complex-shaper-driven normalization properly. The results with or without decomposition are the same, but Uniscribe does not normalize, so this matches better. src/hb-unicode.cc | 3 +++ 1 file changed, 3 insertions(+) commit 422ecd2d3c198a36d07d409341cb82ea57c7ad6b Author: Behdad Esfahbod Date: Wed Jul 18 23:25:58 2012 -0400 [Indic] Accept a forced Rakar sequence at the end of syllable In Sinhala, Rakar is formed by Al-Lakuna,ZWJ,Ra. If you put that at the end of a Consonant,Matra syllable, you get a dotted-circle from Uniscribe. Apparently adding a ZWJ before the Al-Lakuna "fixes" that. And people have been encoding that sequence... So, allow a forced "ZWJ,Virama,ZWJ,Ra" sequence at the of syllables. Fixes some 100 or more of Sinhala failures. Now at 622 only (0.23%). src/hb-ot-shape-complex-indic-machine.rl | 3 ++- .../texts/in-tree/shaper-indic/indic/script-sinhala/misc/misc.txt | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) commit 6fc1732003d71cf90d37247482772c3da884687f Author: Behdad Esfahbod Date: Wed Jul 18 17:49:19 2012 -0400 [Indic] Allow joiners on both sides of Halant at the same time The sequence is used in Sinhala to explicitly ask for Rakar. Fixes two-thousand Sinhala tests. Not many left. src/hb-ot-shape-complex-indic-machine.rl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 10cdc94eee2225f14c198c015256a5a0063eecad Author: Behdad Esfahbod Date: Wed Jul 18 17:42:34 2012 -0400 [Indic] In final reordering, find base, even if it disappeared POS_BASE can disappear if base ligated backward. Define base as last with position not after base. Fixes a few hundred of Sinhala failures with Iskoola Pota. src/hb-ot-shape-complex-indic.cc | 7 ++----- .../texts/in-tree/shaper-indic/indic/script-sinhala/misc/misc.txt | 1 + 2 files changed, 3 insertions(+), 5 deletions(-) commit 9c4d24a3a677a58ec59c7fb0f8b70b8aad30a032 Author: Behdad Esfahbod Date: Wed Jul 18 17:29:10 2012 -0400 [Indic] Minor src/hb-ot-shape-complex-indic.cc | 1 + 1 file changed, 1 insertion(+) commit 3285e107c9a83aeb552e67f9460680ff6d167d88 Author: Behdad Esfahbod Date: Wed Jul 18 17:22:14 2012 -0400 [Indic] Implement Sinhala "Al Lakuna" Reph behavior In Sinhala, Reph is formed only explicitly, by the presence of a ZWJ. src/hb-ot-shape-complex-indic-private.hh | 2 ++ src/hb-ot-shape-complex-indic.cc | 7 ++++++- .../texts/in-tree/shaper-indic/indic/script-sinhala/misc/MANIFEST | 1 + .../texts/in-tree/shaper-indic/indic/script-sinhala/misc/reph.txt | 3 +++ 4 files changed, 12 insertions(+), 1 deletion(-) commit 91cade755534c42bb826a6aefcbca8a543d94387 Author: Behdad Esfahbod Date: Wed Jul 18 16:50:41 2012 -0400 [Indic/Unicode] Decompose Sinhala split matras the way Uniscribe likes Makes no visual difference. Fixes most of the failures. Down from 15% to 1.3%! src/hb-unicode.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit d8942dcbb4e3249a2d78a6455c119294ed4390bc Author: Behdad Esfahbod Date: Wed Jul 18 16:34:10 2012 -0400 Apply Tibetan (global) features. Fixes all Tibetan failures. All 180k of them! Merges back Hangul into the default shaper. src/hb-ot-shape-complex-misc.cc | 82 +++++++++++++++++--------------------- src/hb-ot-shape-complex-private.hh | 7 ---- 2 files changed, 37 insertions(+), 52 deletions(-) commit 552d19b7a11f7dff888587fce4d56d9f8e47e819 Author: Behdad Esfahbod Date: Wed Jul 18 16:00:49 2012 -0400 [Indic] Treat Register Shifters like Nukta Really this time. Fixes another 18 Khmer tests. src/hb-ot-shape-complex-indic-machine.rl | 2 +- src/hb-ot-shape-complex-indic.cc | 2 -- .../in-tree/shaper-indic/south-east-asian/script-khmer/misc/misc.txt | 1 + 3 files changed, 2 insertions(+), 3 deletions(-) commit e8cd81f76d159f3ecf808952dab24bc07782497a Author: Behdad Esfahbod Date: Wed Jul 18 16:00:20 2012 -0400 [Indic] Minor src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 69f26bf39c824d6bf5b1c0d410380cc5462ad5ca Author: Behdad Esfahbod Date: Wed Jul 18 15:45:43 2012 -0400 [Indic] Fix Matra reordering when base is at end of syllable For example: U+915,U+200c,U+93f Fixes last Tamil failure! src/hb-ot-shape-complex-indic.cc | 2 +- .../texts/in-tree/shaper-indic/indic/script-devanagari/misc/misc.txt | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) commit d16ccc4ae7aa8be460881042413fa2637929fede Author: Behdad Esfahbod Date: Wed Jul 18 15:43:55 2012 -0400 Leave one extra item at the end of buffer allocation Just in case, for the times we do out-of-bounds access. jk src/hb-buffer-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 075d671f1093d2e3c58f7f45568696030f1b3efd Author: Behdad Esfahbod Date: Wed Jul 18 15:41:53 2012 -0400 [Indic] Fix out-of-bounds array access src/hb-ot-shape-complex-indic.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit dcb527242b1eca4db1e190a7802f9cd132aaf46e Author: Behdad Esfahbod Date: Wed Jul 18 15:28:25 2012 -0400 [Indic] Allow joiners before matras Fixes 1 more Devanagari test! src/hb-ot-shape-complex-indic-machine.rl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 391cc0331749e263bdfe83a8f5f6d76f2360ee7a Author: Behdad Esfahbod Date: Wed Jul 18 15:10:05 2012 -0400 [Indic] Allow halant group in Vowel and placeholder syllables Fixes 2 out of 560 Devanagari failures. AND: Fixes 1 out of 2 Tamil failures. src/hb-ot-shape-complex-indic-machine.rl | 7 ++++--- .../in-tree/shaper-indic/indic/script-devanagari/misc/misc.txt | 1 + 2 files changed, 5 insertions(+), 3 deletions(-) commit ca4e3d3eab7b738c2b8e2a81696a28bca1b81495 Author: Behdad Esfahbod Date: Wed Jul 18 15:05:40 2012 -0400 [Indic] Streamline halant/joiner in grammar src/hb-ot-shape-complex-indic-machine.rl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 418d00dffddd95a1f27e9be15752d494c627d45e Author: Behdad Esfahbod Date: Wed Jul 18 14:57:28 2012 -0400 [Indic] Minor src/hb-ot-shape-complex-indic-machine.rl | 3 ++- .../texts/in-tree/shaper-indic/indic/script-devanagari/misc/misc.txt | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) commit 4c3691d2a32ca7e54a54f7c08098fd96fa7af39e Author: Behdad Esfahbod Date: Wed Jul 18 14:23:55 2012 -0400 [Indic] Hopefully minor! Refactoring Indic machin. No semantic change. src/hb-ot-shape-complex-indic-machine.rl | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) commit e092c556fb1cf38be3cea1f4b75a0d879372dfa2 Author: Behdad Esfahbod Date: Wed Jul 18 14:09:25 2012 -0400 [Indic] Minor src/hb-ot-shape-complex-indic-private.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 14dbdd9e39d3a869fd1521000c889c347433d22b Author: Behdad Esfahbod Date: Wed Jul 18 13:13:03 2012 -0400 [Indic] Unbreak Tamil Tamil has only about 150 failures now! src/hb-ot-shape-complex-indic.cc | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) commit db8981f1e0e8625714568c6d0f11f0b317b11d0a Author: Behdad Esfahbod Date: Tue Jul 17 18:17:30 2012 -0400 [Indic] Position Khmer Robat It's a visual Repha. Still not positioning logical Repha as occurs in Malayalam. Another 200 Khmer failures fixed. 547 to go. That's better than Devanagari! src/hb-ot-shape-complex-indic-machine.rl | 36 +++++++++++++++++--------------- src/hb-ot-shape-complex-indic-private.hh | 7 ++++--- src/hb-ot-shape-complex-indic.cc | 13 ++++++++++++ 3 files changed, 36 insertions(+), 20 deletions(-) commit 25bc489498ef7d0beb8fe9ab663e3f0b2f52c9c2 Author: Behdad Esfahbod Date: Tue Jul 17 17:53:03 2012 -0400 [Indic] Better categorize Register Shifters and Khmer Various signs Down another 500 or so Khmer failures! src/hb-ot-shape-complex-indic-machine.rl | 14 +++++++------- src/hb-ot-shape-complex-indic-private.hh | 2 +- src/hb-ot-shape-complex-indic.cc | 8 ++++---- .../south-east-asian/script-khmer/misc/MANIFEST | 2 ++ .../script-khmer/misc/other-marks-invalid.txt | 4 ++++ .../south-east-asian/script-khmer/misc/other-marks.txt | 6 ++++++ 6 files changed, 24 insertions(+), 12 deletions(-) commit 39b17837b4064d59c18cebb49c1c0b5b8cc0c117 Author: Behdad Esfahbod Date: Tue Jul 17 17:09:29 2012 -0400 Add hb_buffer_normalize_glyphs() and hb-shape --normalize-glyphs This reorders glyphs within the cluster to a nominal order. This should have no visible effect on the output, but helps with testing, for getting the same hb-shape output for visually-equal glyphs for each cluster. src/hb-buffer.cc | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/hb-buffer.h | 13 ++++++++++ src/hb-private.hh | 29 ++++++++++++++++----- util/options.cc | 1 + util/options.hh | 7 ++++- 5 files changed, 118 insertions(+), 8 deletions(-) commit 25e302da9a712e6f1d63b0d243a8df0d326ddba3 Author: Behdad Esfahbod Date: Tue Jul 17 14:25:14 2012 -0400 [Indic] Minor src/hb-ot-shape-complex-indic.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 5d32690a3428fa86eb26fe5fcec943a10aa95881 Author: Behdad Esfahbod Date: Tue Jul 17 14:23:28 2012 -0400 [Indic] For scripts without Half forms, always choose first consonant as base In such scripts (ie. Khmer), a ZWJ/ZWNJ shouldn't stop the search for base. So, instead just choose the first consonant as base directly. Test sequence: U+1798,200c,U+17C9,U+17D2,U+179B,U+17C1,U+17C7 src/hb-ot-shape-complex-indic.cc | 59 ++++++++++++++++++++++++---------------- 1 file changed, 35 insertions(+), 24 deletions(-) commit 34b57149065d96f7528aaccaa7654e956ce27e93 Author: Behdad Esfahbod Date: Tue Jul 17 14:09:32 2012 -0400 [Indic] Treat Khmer Register Shifters more like Nuktas Except that there may be a ZWNJ before a Register Shifter. src/hb-ot-shape-complex-indic-machine.rl | 2 +- .../in-tree/shaper-indic/south-east-asian/script-khmer/misc/misc.txt | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) commit 11e2a601b19861b05dbb2051d2d078c3cfd75b29 Author: Behdad Esfahbod Date: Tue Jul 17 14:02:28 2012 -0400 [Indic] Minor src/hb-ot-shape-complex-indic-machine.rl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 0201e0a4649ad5b607e50bcb9605e7a5b7143812 Author: Behdad Esfahbod Date: Tue Jul 17 13:55:10 2012 -0400 [Indic] Apply 'cfar' for Khmer Mark stuff after a pre-base reordering Ro 'cfar'. Used in Khmer. This allows distinguishing the following cases with MS Khmer fonts: U+1784,U+17D2,U+179A,U+17D2,U+1782 U+1784,U+17D2,U+1782,U+17D2,U+179A src/hb-ot-shape-complex-indic.cc | 16 ++++++++++++++-- .../south-east-asian/script-khmer/misc/misc.txt | 2 ++ 2 files changed, 16 insertions(+), 2 deletions(-) commit 55f70ebfb95083f515d9b0044a2a65ab11484bb5 Author: Behdad Esfahbod Date: Tue Jul 17 12:50:13 2012 -0400 [Indic] Position final subjoined consonants (and vowels) after matras In Khmer, a final subjoined consonant or independent vowel can occur after matras. This final subjoined thing should NOT be reordered to before the matra even though it's subjoined. Fixes another 1k of the Khmer failures. Not much left really. src/hb-ot-shape-complex-indic-private.hh | 1 + src/hb-ot-shape-complex-indic.cc | 13 +++++++++++++ .../south-east-asian/script-khmer/misc/misc.txt | 2 ++ 3 files changed, 16 insertions(+) commit c50ed71e9a3df1844f564de66d54b46a696c1356 Author: Behdad Esfahbod Date: Tue Jul 17 11:54:28 2012 -0400 [Indic] Recategorize Khmer coeng sign as a separate category OT_Coeng Amend the syllable structure to allow a final subscripted consonant (Coeng+C) and a final subscripted independent vowel (Coeng+V). Fixes another 2k of Khmer failures. src/hb-ot-shape-complex-indic-machine.rl | 7 ++++--- src/hb-ot-shape-complex-indic.cc | 6 +++++- .../shaper-indic/south-east-asian/script-khmer/misc/misc.txt | 1 + 3 files changed, 10 insertions(+), 4 deletions(-) commit deb521dee4fdca8c2124cfb39a205e6269d4a70d Author: Behdad Esfahbod Date: Tue Jul 17 11:37:32 2012 -0400 [Indic] Add a separate Coeng class No characters recategorized yet. No semantic change. src/hb-ot-shape-complex-indic-machine.rl | 1 + src/hb-ot-shape-complex-indic-private.hh | 3 ++- src/hb-ot-shape-complex-indic.cc | 26 ++++++++++++++++---------- 3 files changed, 19 insertions(+), 11 deletions(-) commit 74ccc6a1322f8c48c5f2a05f04821783c4b87a14 Author: Behdad Esfahbod Date: Tue Jul 17 11:16:19 2012 -0400 [Indic] Move Halant with after-base consonants Normally, we attach the Halant to the previous character and move it with it. For after-base consonants however, the Halant "belongs" to the consonant after, so attach it so. This fixes Bengali sequences involving post-base consonant Ya, which should ligate with the Halant to form Ya Phala, but previously a reordered matras was blocking the ligation. src/hb-ot-shape-complex-indic.cc | 11 +++++++++++ .../in-tree/shaper-indic/indic/script-bengali/misc/misc.txt | 1 + 2 files changed, 12 insertions(+) commit d5c4edcdd6df32f2f23aca44f14838b4baab4d7a Author: Behdad Esfahbod Date: Tue Jul 17 10:40:59 2012 -0400 [Indic] Apply presentation-forms features all at once Seems like this is what Uniscribe is doing, and does not break any fonts we tested (with Devanagari, Malayalam, Khmer, and Bengali), while fixing some Ra Phala sequences for Bengali with Vrinda. Fixes another 2% of Bengali failures (a couple more to go). src/hb-ot-shape-complex-indic.cc | 6 +++--- .../texts/in-tree/shaper-indic/indic/script-bengali/misc/misc.txt | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) commit 559f70667891a3ceeffb36f40de38a4f85868945 Author: Behdad Esfahbod Date: Mon Jul 16 22:43:17 2012 -0400 Fix MarkAttachmentType matching Fixes issue reported by Khaled Hosny with his Hussaini Nastaleeq font and sequences like those added in the previous commit. src/hb-ot-layout.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6de103547e4a7fb34c833861713ea373cd912261 Author: Behdad Esfahbod Date: Mon Jul 16 22:46:06 2012 -0400 [test/arabic] Add Arabic tests for mark skipping Expose a bug with Khaled's Hussaini Nastaleeq font. .../shaper-arabic/script-arabic/misc/diacritics/MANIFEST | 1 + .../script-arabic/misc/diacritics/mark-skipping.txt | 10 ++++++++++ 2 files changed, 11 insertions(+) commit ad4494759fa8bfd2497800c24fa414075ed1aa61 Author: Behdad Esfahbod Date: Mon Jul 16 22:40:21 2012 -0400 Minor src/hb-ot-layout.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit af92b4cc90e4184d5bdd8037c551ed482700114f Author: Behdad Esfahbod Date: Mon Jul 16 20:31:24 2012 -0400 [Indic] Disable 'kern' in Uniscribe bug compatibility mode Uniscribe does not apply 'kern' in the Indic module. Some of the Khmer fonts they ship have small adjustments in the 'kern' table. Disable 'kern' in the Indic module under Uniscribe bug compatibility mode. Fixes some 10% of the Khmer failures. Remains under 3% (excluding dotted-circle ones). src/hb-ot-shape-complex-indic.cc | 3 +++ 1 file changed, 3 insertions(+) commit d96838ef951ce6170eb2dc576ebcba2262cf7008 Author: Behdad Esfahbod Date: Mon Jul 16 20:26:57 2012 -0400 Allow complex shapers overriding common features In a new callback... Currently unused by all complex shapers. src/hb-ot-shape-complex-arabic.cc | 6 ++++++ src/hb-ot-shape-complex-indic.cc | 6 ++++++ src/hb-ot-shape-complex-misc.cc | 18 ++++++++++++++++++ src/hb-ot-shape-complex-private.hh | 30 ++++++++++++++++++++++++++++++ src/hb-ot-shape.cc | 2 ++ 5 files changed, 62 insertions(+) commit df50b8474094f0563ccfdae12c4425a51b72add6 Author: Behdad Esfahbod Date: Mon Jul 16 19:56:29 2012 -0400 [Indic] Categorize other Khmer marks Mark them the same as the Register Shifters for now. Need to rename that category to something more sensible after all is settled. Fixes another percent of Khmer failures. Down to under 3%! src/hb-ot-shape-complex-indic.cc | 4 ++++ 1 file changed, 4 insertions(+) commit 8e7b5882fb4c1921c9d030d354a9b998115cdb8c Author: Behdad Esfahbod Date: Mon Jul 16 17:04:46 2012 -0400 [Indic] Recognize pre-base reordering Ra anywhere in the syllable We were doing that only immediately after base. Fixes another percent in the Khmer failures. About three more to go... src/hb-ot-shape-complex-indic.cc | 84 ++++++++++++++++++++++------------------ 1 file changed, 46 insertions(+), 38 deletions(-) commit 7d09c98a1fff97127e48eae48d380dc9fcff288e Author: Behdad Esfahbod Date: Mon Jul 16 16:45:22 2012 -0400 [Indic] Recognizer Register Shifter marks Fixes another 6% of the Khmer failures. src/hb-ot-shape-complex-indic-machine.rl | 3 ++- src/hb-ot-shape-complex-indic-private.hh | 5 +++-- src/hb-ot-shape-complex-indic.cc | 2 ++ 3 files changed, 7 insertions(+), 3 deletions(-) commit 60da763dfac96a7931d6e6bdef8b9973bd5209ab Author: Behdad Esfahbod Date: Mon Jul 16 16:13:32 2012 -0400 [GSUB/GDEF] Guess glyph classes after substitution only if no GDEF Brings down Khmer failures with Daun Penh font from 36% to 20%. src/hb-ot-layout-gsubgpos-private.hh | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) commit fcdc5f1c8849a7f38d9f34f64d60c6d95d7501f7 Author: Behdad Esfahbod Date: Mon Jul 16 15:52:54 2012 -0400 [Indic] Categorize Khmer Ro Khmer failures down from 58% to 36%. src/hb-ot-shape-complex-indic-private.hh | 2 ++ 1 file changed, 2 insertions(+) commit 78818124b17691ec2c647142fdb9ae743aa03dee Author: Behdad Esfahbod Date: Mon Jul 16 15:49:08 2012 -0400 [Indic] Reoder pre-base reordering Ra Brings down Malayalam failures from 14% down to 3%. src/hb-ot-shape-complex-indic.cc | 42 +++++++++++++++++++++++++++------------- 1 file changed, 29 insertions(+), 13 deletions(-) commit 1a1dbe9a2787f226f3e43063da8eb6633438b0a0 Author: Behdad Esfahbod Date: Mon Jul 16 15:40:33 2012 -0400 [Indic] Rename src/hb-ot-shape-complex-indic.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 46e645ec4b59f0a278347be11f40c7df700d5bb6 Author: Behdad Esfahbod Date: Mon Jul 16 15:30:05 2012 -0400 [Indic] Start implementing pre-base reordering src/hb-ot-shape-complex-indic.cc | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) commit 921ce5b17daf06af8e17989a3e335b9f5df20483 Author: Behdad Esfahbod Date: Mon Jul 16 15:26:56 2012 -0400 [Indic] Rename No semantic change. src/hb-ot-shape-complex-indic.cc | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) commit b504e060f008e95b1ba36c06600c9fea4f5d4808 Author: Behdad Esfahbod Date: Mon Jul 16 15:21:12 2012 -0400 [Indic] Implement After-Main Reph positioning Almost... src/hb-ot-shape-complex-indic.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit 17d7de91d76406d3e92db37d9eef2fc615f06e68 Author: Behdad Esfahbod Date: Mon Jul 16 15:20:15 2012 -0400 [Indic] Apply 'pref' to pre-base reodering Ra No reordering yet. src/hb-ot-shape-complex-indic.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) commit 362d3db8d3527d0fef260a17d2466e92a4a25425 Author: Behdad Esfahbod Date: Mon Jul 16 15:15:28 2012 -0400 [Indic] Minor Should not be any semantic change. In preparation for implementing pre-base reordering Ra. src/hb-ot-shape-complex-indic.cc | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) commit 70fe77bb9a25922bd34f206826d8731d901fb451 Author: Behdad Esfahbod Date: Mon Jul 16 14:52:18 2012 -0400 Minor src/hb-ot-shape-complex-indic.cc | 44 ++++++++++++++++++++-------------------- 1 file changed, 22 insertions(+), 22 deletions(-) commit 2f903215c5da2330a37abe489a3f45f7c3fd5a09 Author: Behdad Esfahbod Date: Mon Jul 16 13:54:43 2012 -0400 Minor src/hb-ot-shape-complex-indic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a3e04bee2c2fa648759a87e460db6b4f1b685586 Author: Behdad Esfahbod Date: Mon Jul 16 13:47:19 2012 -0400 [Indic] Reorder virama only for old Indic spec src/hb-ot-shape-complex-indic.cc | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) commit 0de771b72da6b342b015e3556190821547a4011d Author: Behdad Esfahbod Date: Mon Jul 16 13:39:36 2012 -0400 [Indic] Categorize Khmer consonants src/hb-ot-shape-complex-indic.cc | 4 ++++ 1 file changed, 4 insertions(+) commit d487fff266258eb1af056e9704cfb09d04251ddc Author: Behdad Esfahbod Date: Mon Jul 16 13:25:17 2012 -0400 Split matras without a Unicode decomposition This is a hack for now, to get us going with Khmer. This will be refactored properly later to move the complex logic into complex shapers. src/hb-unicode.cc | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) commit 8aa801a6fd1a737fa20b851edf7528bdd6635b8b Author: Behdad Esfahbod Date: Mon Jul 16 13:24:26 2012 -0400 [Indic] Adjust position for split matras We are going to split matras without a Unicode decompositions in a way that the second half takes the codepoint of the whole matra. So, position them where the second half is supposed to end up. src/hb-ot-shape-complex-indic-private.hh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 1feb8345a5fd92297eb6796e6dce633bafa0c76e Author: Behdad Esfahbod Date: Mon Jul 16 13:23:40 2012 -0400 [GSUB] Allow 1-to-1 ligature substitutions! Apparently Uniscribe allows these, and they are used in some Khmer fonts shipped with Windows, namely, Daun Penh. src/hb-ot-layout-gsub-table.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 29f106d7fba25e1464debd3a4831a7380d75c4c9 Author: Behdad Esfahbod Date: Mon Jul 16 12:05:35 2012 -0400 [Indic] Apply Above Forms src/hb-ot-shape-complex-indic.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit fa2bd9fb63d83b657373764d4b657084d8327fc9 Author: Behdad Esfahbod Date: Sat Jul 14 12:15:54 2012 -0400 Further simplify atomic ops on Visual Studio src/hb-atomic-private.hh | 5 ----- 1 file changed, 5 deletions(-) commit 0a492357016bc9a614d2a726f2006c10af68ca58 Author: Behdad Esfahbod Date: Fri Jul 13 13:20:49 2012 -0400 Minor src/hb-warning.cc | 29 +++++------------------------ 1 file changed, 5 insertions(+), 24 deletions(-) commit 11c4ad439ef2b39a840f397a693b1ba643f52c21 Author: Behdad Esfahbod Date: Fri Jul 13 11:29:31 2012 -0400 Add -Wcast-align configure.ac | 3 +++ src/Makefile.am | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) commit a98d0ab18624501ee60551304f2715361ac643da Author: Behdad Esfahbod Date: Fri Jul 13 10:19:10 2012 -0400 Make sure HB_BEGIN_DECLS / HB_END_DECLS is only used in public headers So we can use them to switch default visibility to internal if desired, and use these to make only declared symbols public. src/check-c-linkage-decls.sh | 10 +++++++++- src/hb-fallback-shape-private.hh | 6 ------ src/hb-ot-shape-complex-indic-machine.rl | 4 ---- 3 files changed, 9 insertions(+), 11 deletions(-) commit 5c5bc96216c9ad58243eb3ed27b253e237f08ebe Author: Behdad Esfahbod Date: Fri Jul 13 10:15:37 2012 -0400 Allow overriding HB_BEGIN_DECLS / HB_END_DECLS src/hb-common.h | 2 ++ 1 file changed, 2 insertions(+) commit ec5f5f0f8a1d5b3ff98452175bb4450a59897620 Author: Behdad Esfahbod Date: Fri Jul 13 10:00:42 2012 -0400 Don't export inline methods configure.ac | 3 +++ 1 file changed, 3 insertions(+) commit 50a4e78b530563917eb606ff3b96dcc9eed5b3ee Author: Behdad Esfahbod Date: Fri Jul 13 09:48:39 2012 -0400 Check for exported weak symbols Ouch, all our C++ inline functions are being exported (weakly) already. Fix coming. src/check-internal-symbols.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit b5aeb95afeb13a66177caada9f5d5ad4cddbd35f Author: Behdad Esfahbod Date: Fri Jul 13 09:45:54 2012 -0400 Make hb_in_range() static src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 271c8f89075607c689938b4f5e60323d9a1acd70 Author: Behdad Esfahbod Date: Fri Jul 13 09:32:30 2012 -0400 Minor src/hb-ft.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 391f1ff5d894b60bfe0f606be436ffe7e43f7455 Author: Behdad Esfahbod Date: Fri Jul 13 09:04:07 2012 -0400 Fix _InterlockedCompareExchangePointer on x86 src/hb-atomic-private.hh | 6 ++++++ 1 file changed, 6 insertions(+) commit 2023e2b54d91924dddfd228ffdbb46021135b068 Author: Behdad Esfahbod Date: Wed Jul 11 19:00:30 2012 -0400 [ft] Disable ppem setting The calculations were wrong. FreeType makes it really hard to set size and ppem independently. For now, disable it. Need to come up with a fix later. src/hb-ft.cc | 3 +++ 1 file changed, 3 insertions(+) commit cdf7444505a7ae49d20f9ba6776dea92c1fde2a6 Author: Behdad Esfahbod Date: Wed Jul 11 18:52:39 2012 -0400 [ft] Use unfitted kerning if x_ppem is zero src/hb-ft.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 6d08c7f1b3601095f9a12630045331dd0fe75380 Author: Behdad Esfahbod Date: Wed Jul 11 18:01:27 2012 -0400 Revert "Towards templatizing common Lookup types" This reverts commit 727135f3a9938c1ebd5b9f5015a46c7ccc8573c5. This is work-in-progress. Didn't mean to push it out just yet. src/hb-ot-layout-gpos-table.hh | 16 ++++++---------- src/hb-ot-layout-gsub-table.hh | 24 ++++++++++-------------- src/hb-ot-layout-gsubgpos-private.hh | 33 ++------------------------------- 3 files changed, 18 insertions(+), 55 deletions(-) commit 552bf3a9f9651311084b7979805dbdc18c0335ca Author: Behdad Esfahbod Date: Wed Jul 11 16:44:51 2012 -0400 Bump WINNT version requested from 500 to 600 Since we use the OpenType versions of Uniscribe functions, we are relying on that version of the WINNT API. Otherwise, usp10.h will hide those symbols. src/hb-uniscribe.cc | 2 +- src/hb-uniscribe.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 9a5b421a64db1bb23d5c6ebbc3bf3f3a5513dc36 Author: Behdad Esfahbod Date: Wed Jul 11 16:35:04 2012 -0400 Fix build with no Unicode funcs implementations provided src/hb-unicode-private.hh | 1 + 1 file changed, 1 insertion(+) commit 6efe1eca660135096f05987ac0ef9b635de6cdfd Author: Behdad Esfahbod Date: Wed Jul 11 15:30:08 2012 -0400 Update git.mk to upstream git.mk | 58 ++++++++++++++++++++++++++++++++++++++-------------------- 1 file changed, 38 insertions(+), 20 deletions(-) commit 727135f3a9938c1ebd5b9f5015a46c7ccc8573c5 Author: Behdad Esfahbod Date: Tue Jul 3 22:15:35 2012 -0400 Towards templatizing common Lookup types src/hb-ot-layout-gpos-table.hh | 16 ++++++++++------ src/hb-ot-layout-gsub-table.hh | 24 ++++++++++++++---------- src/hb-ot-layout-gsubgpos-private.hh | 33 +++++++++++++++++++++++++++++++-- 3 files changed, 55 insertions(+), 18 deletions(-) commit 1167c7bfc9e61f145e11da4881968293a4d3c0a9 Author: Behdad Esfahbod Date: Tue Jul 3 11:38:46 2012 -0400 Minor test/shaping/texts/in-tree/shaper-thai/MANIFEST | 2 +- test/shaping/texts/in-tree/shaper-thai/misc/MANIFEST | 1 - test/shaping/texts/in-tree/shaper-thai/script-thai/MANIFEST | 1 + test/shaping/texts/in-tree/shaper-thai/script-thai/misc/MANIFEST | 1 + .../shaper-thai/{misc/misc.txt => script-thai/misc/sara-am.txt} | 6 ++---- 5 files changed, 5 insertions(+), 6 deletions(-) commit aa116582e69d18777448e7993078e5d6335ddfed Author: Behdad Esfahbod Date: Fri Jun 29 10:50:12 2012 -0400 Minor .../texts/in-tree/shaper-indic/indic/script-malayalam/misc/misc.txt | 1 + 1 file changed, 1 insertion(+) commit 1f13c7185f02ea18d4fadd2ea8ad444bea863c39 Author: Behdad Esfahbod Date: Wed Jun 27 10:07:27 2012 -0400 Add TODO item TODO | 2 ++ 1 file changed, 2 insertions(+) commit 12f5c0a222a2f0aebe63c0d367937a0ff985474a Author: Behdad Esfahbod Date: Tue Jun 26 11:16:13 2012 -0400 Fix check for Intel atomic ops configure.ac | 9 +++++---- src/hb-atomic-private.hh | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) commit 6932a41fb61ffc2901c260587b1e98ed9c2a7ea1 Author: Behdad Esfahbod Date: Tue Jun 26 10:46:31 2012 -0400 Use octal-escaped UTF-8 characters instead of plain text https://bugs.freedesktop.org/show_bug.cgi?id=50970 src/hb-private.hh | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) commit 8c0ea7bcb4409aaf8c96ad641f2db30003228ad0 Author: Behdad Esfahbod Date: Sun Jun 24 13:20:56 2012 -0400 Disable introspection again Until I figure out the build issues. Sigh... configure.ac | 2 +- src/Makefile.am | 42 +++++++++++++++++++++--------------------- 2 files changed, 22 insertions(+), 22 deletions(-) commit 8c5f5e6f5ec2b6a219fbdfc955f6299325a0adde Author: Behdad Esfahbod Date: Sun Jun 17 14:58:59 2012 -0400 Minor configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 49f8e0cd9a5493ae26857c43bac0711cdf47c80d Author: Behdad Esfahbod Date: Sat Jun 16 15:40:03 2012 -0400 GStaticMutex is deprecated src/hb-mutex-private.hh | 9 +++++++++ 1 file changed, 9 insertions(+) commit 5e113a4b7921ced6af2d53460a7a2f1d0185c02a Author: Behdad Esfahbod Date: Sat Jun 16 15:26:13 2012 -0400 g_thread_init() is deprecated test/api/hb-test.h | 2 ++ 1 file changed, 2 insertions(+) commit 1bc1cb3603167f5da309336f7018c8b0608ac104 Author: Behdad Esfahbod Date: Sat Jun 16 15:21:55 2012 -0400 Make source more digestable for gobject-introspection src/hb-blob.cc | 2 +- src/hb-blob.h | 2 +- src/hb-buffer-private.hh | 4 ++-- src/hb-buffer.h | 6 +++--- src/hb-common.cc | 2 +- src/hb-common.h | 4 ++-- src/hb-font-private.hh | 6 +++--- src/hb-font.cc | 2 +- src/hb-font.h | 8 ++++---- src/hb-set-private.hh | 2 +- src/hb-set.h | 2 +- src/hb-shape.h | 2 +- src/hb-unicode-private.hh | 2 +- src/hb-unicode.h | 2 +- 14 files changed, 23 insertions(+), 23 deletions(-) commit 84d781e54cc75c81a06ba43fd7b1a74b8c7d9591 Author: Behdad Esfahbod Date: Sat Jun 16 15:21:41 2012 -0400 Flesh out gobject-introspection stuff a bit configure.ac | 1 + src/Makefile.am | 23 +++++++++++++++++++++-- 2 files changed, 22 insertions(+), 2 deletions(-) commit 49ee12ccd00870d4976339dc546c74eaf08a8fc0 Author: Behdad Esfahbod Date: Sat Jun 16 14:53:51 2012 -0400 Add TODO item TODO | 1 + 1 file changed, 1 insertion(+) commit d3c8115d1ad09404b8970b98e6b5ab74510a35f6 Author: Behdad Esfahbod Date: Tue Jun 12 09:52:57 2012 -0400 Minor TODO | 2 ++ 1 file changed, 2 insertions(+) commit 2cf301968cb8c1150cead0ab909457cdd3ee2d01 Author: Behdad Esfahbod Date: Sat Jun 9 14:58:01 2012 -0400 Add hb_object_lock/unlock() src/hb-object-private.hh | 32 ++++++++++++++++++++++++++------ 1 file changed, 26 insertions(+), 6 deletions(-) commit 6a5661f1e69c937083e8d976cb12429b99180d54 Author: Behdad Esfahbod Date: Sat Jun 9 03:26:16 2012 -0400 Ugh util/shape-consumer.hh | 2 -- 1 file changed, 2 deletions(-) commit f211d5c291b4c947cfd732e873627567173057e4 Author: Behdad Esfahbod Date: Sat Jun 9 03:11:22 2012 -0400 More Oops! Fix fast-path with sub-type==0 src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-layout-gsub-table.hh | 2 +- util/shape-consumer.hh | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) commit b1de6aa1f33b228afe231c8209aef90a5fa1ee5d Author: Behdad Esfahbod Date: Sat Jun 9 03:07:59 2012 -0400 Oops! src/hb-ot-layout-gpos-table.hh | 2 +- src/hb-ot-layout-gsub-table.hh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit b12e2549cbcd4f1ef46e66c75533686ee560f59b Author: Behdad Esfahbod Date: Sat Jun 9 03:05:20 2012 -0400 Minor src/hb-ot-layout-gsubgpos-private.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit faf0f20253d954cc4cfa4c967ece7573a5ddae3b Author: Behdad Esfahbod Date: Sat Jun 9 03:02:36 2012 -0400 Add sanitize() logic for fast-paths src/hb-ot-layout-gpos-table.hh | 15 ++++++++++++--- src/hb-ot-layout-gsub-table.hh | 20 ++++++++++++++------ 2 files changed, 26 insertions(+), 9 deletions(-) commit 4e766ff28d1fb831ded20666799787478129c07c Author: Behdad Esfahbod Date: Sat Jun 9 02:53:57 2012 -0400 Add fast-path for GPOS too Shaves another 3% for DejaVu Sans long Latin strings. src/hb-ot-layout-gpos-table.hh | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) commit 993c51915f503f74ee00eee646b67bf2e3f73596 Author: Behdad Esfahbod Date: Sat Jun 9 02:48:16 2012 -0400 Add fast-path to GSUB to check coverage Shaves a good 10% off DejaVu Sans with simple Latin text for me. Now, DejaVu is very ChainContext-intensive, but it's also a very popular font! src/hb-ot-layout-gsub-table.hh | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) commit f19e0b0099ec73b8fedccacff4902403f5eabc42 Author: Behdad Esfahbod Date: Sat Jun 9 02:26:57 2012 -0400 Match input before backtrack Makes more sense, optimization-wise. src/hb-ot-layout-gsubgpos-private.hh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 67bb9e8cea49a44be6996515e1c7d8cdc95a77e6 Author: Behdad Esfahbod Date: Sat Jun 9 02:02:46 2012 -0400 Add set add_coverage() to Coverage() src/hb-ot-layout-common-private.hh | 24 ++++++++++++++++++++++++ src/hb-set-private.hh | 5 +++++ 2 files changed, 29 insertions(+) commit 4952f0aa5b2f4368d9e3418252e0a1b9294cd5ee Author: Behdad Esfahbod Date: Sat Jun 9 01:39:11 2012 -0400 Minor src/hb-ot-layout-gsub-table.hh | 2 ++ 1 file changed, 2 insertions(+) commit ad6a6f22401d6256e34521d0f52e91348c5ed4c9 Author: Behdad Esfahbod Date: Sat Jun 9 01:21:02 2012 -0400 Minor src/hb-ot-layout.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 46617a42133fbab151de4111a74dcbdc4e769c74 Author: Behdad Esfahbod Date: Sat Jun 9 01:18:58 2012 -0400 Fix cache implementation src/hb-cache-private.hh | 2 ++ 1 file changed, 2 insertions(+) commit ce47613889aa3ff9b0067d3e51ba63cfdb139adb Author: Behdad Esfahbod Date: Sat Jun 9 01:10:26 2012 -0400 Micro-optimize I know... src/hb-ot-layout-gsubgpos-private.hh | 3 ++- src/hb-ot-layout.cc | 46 ++++++++++++++++++++++-------------- 2 files changed, 30 insertions(+), 19 deletions(-) commit 70416de298b811ab6be53a1c67f0d2531d99cd46 Author: Behdad Esfahbod Date: Sat Jun 9 00:56:41 2012 -0400 Minor src/hb-open-type-private.hh | 2 -- 1 file changed, 2 deletions(-) commit 99159e52a3c9d5ae6c0fbdec64e7ed684fa70b61 Author: Behdad Esfahbod Date: Sat Jun 9 00:50:40 2012 -0400 Use linear search for small counts I see about 8% speedup with long strings with DejaVu Sans. src/hb-open-type-private.hh | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) commit caf0412690542e58e23246dccc4b2fb83bd652ec Author: Behdad Esfahbod Date: Sat Jun 9 00:26:32 2012 -0400 Minor src/