Blame tests/diff/racediffiter.c

Packit ae9e2a
/* This test exercises the problem described in
Packit ae9e2a
** https://github.com/libgit2/libgit2/pull/3568
Packit ae9e2a
** where deleting a directory during a diff/status
Packit ae9e2a
** operation can cause an access violation.
Packit ae9e2a
**
Packit ae9e2a
** The "test_diff_racediffiter__basic() test confirms
Packit ae9e2a
** the normal operation of diff on the given repo.
Packit ae9e2a
**
Packit ae9e2a
** The "test_diff_racediffiter__racy_rmdir() test
Packit ae9e2a
** uses the new diff progress callback to delete
Packit ae9e2a
** a directory (after the initial readdir() and
Packit ae9e2a
** before the directory itself is visited) causing
Packit ae9e2a
** the recursion and iteration to fail.
Packit ae9e2a
*/
Packit ae9e2a
Packit ae9e2a
#include "clar_libgit2.h"
Packit ae9e2a
#include "diff_helpers.h"
Packit ae9e2a
Packit ae9e2a
#define ARRAY_LEN(a) (sizeof(a) / sizeof(a[0]))
Packit ae9e2a
Packit ae9e2a
void test_diff_racediffiter__initialize(void)
Packit ae9e2a
{
Packit ae9e2a
}
Packit ae9e2a
Packit ae9e2a
void test_diff_racediffiter__cleanup(void)
Packit ae9e2a
{
Packit ae9e2a
	cl_git_sandbox_cleanup();
Packit ae9e2a
}
Packit ae9e2a
Packit ae9e2a
typedef struct
Packit ae9e2a
{
Packit ae9e2a
	const char *path;
Packit ae9e2a
	git_delta_t t;
Packit ae9e2a
Packit ae9e2a
} basic_payload;
Packit ae9e2a
Packit ae9e2a
static int notify_cb__basic(
Packit ae9e2a
	const git_diff *diff_so_far,
Packit ae9e2a
	const git_diff_delta *delta_to_add,
Packit ae9e2a
	const char *matched_pathspec,
Packit ae9e2a
	void *payload)
Packit ae9e2a
{
Packit ae9e2a
	basic_payload *exp = (basic_payload *)payload;
Packit ae9e2a
	basic_payload *e;
Packit ae9e2a
Packit ae9e2a
	GIT_UNUSED(diff_so_far);
Packit ae9e2a
	GIT_UNUSED(matched_pathspec);
Packit ae9e2a
Packit ae9e2a
	for (e = exp; e->path; e++) {
Packit ae9e2a
		if (strcmp(e->path, delta_to_add->new_file.path) == 0) {
Packit ae9e2a
			cl_assert_equal_i(e->t, delta_to_add->status);
Packit ae9e2a
			return 0;
Packit ae9e2a
		}
Packit ae9e2a
	}
Packit ae9e2a
	cl_assert(0);
Packit ae9e2a
	return GIT_ENOTFOUND;
Packit ae9e2a
}
Packit ae9e2a
Packit ae9e2a
void test_diff_racediffiter__basic(void)
Packit ae9e2a
{
Packit ae9e2a
	git_diff_options opts = GIT_DIFF_OPTIONS_INIT;
Packit ae9e2a
	git_repository *repo = cl_git_sandbox_init("diff");
Packit ae9e2a
	git_diff *diff;
Packit ae9e2a
Packit ae9e2a
	basic_payload exp_a[] = {
Packit ae9e2a
		{ "another.txt", GIT_DELTA_MODIFIED },
Packit ae9e2a
		{ "readme.txt", GIT_DELTA_MODIFIED },
Packit ae9e2a
		{ "zzzzz/", GIT_DELTA_IGNORED },
Packit ae9e2a
		{ NULL, 0 }
Packit ae9e2a
	};
Packit ae9e2a
Packit ae9e2a
	cl_must_pass(p_mkdir("diff/zzzzz", 0777));
Packit ae9e2a
Packit ae9e2a
	opts.flags |= GIT_DIFF_INCLUDE_IGNORED | GIT_DIFF_RECURSE_UNTRACKED_DIRS;
Packit ae9e2a
	opts.notify_cb = notify_cb__basic;
Packit ae9e2a
	opts.payload = exp_a;
Packit ae9e2a
Packit ae9e2a
	cl_git_pass(git_diff_index_to_workdir(&diff, repo, NULL, &opts));
Packit ae9e2a
Packit ae9e2a
	git_diff_free(diff);
Packit ae9e2a
}
Packit ae9e2a
Packit ae9e2a
Packit ae9e2a
typedef struct {
Packit ae9e2a
	bool first_time;
Packit ae9e2a
	const char *dir;
Packit ae9e2a
	basic_payload *basic_payload;
Packit ae9e2a
} racy_payload;
Packit ae9e2a
Packit ae9e2a
static int notify_cb__racy_rmdir(
Packit ae9e2a
	const git_diff *diff_so_far,
Packit ae9e2a
	const git_diff_delta *delta_to_add,
Packit ae9e2a
	const char *matched_pathspec,
Packit ae9e2a
	void *payload)
Packit ae9e2a
{
Packit ae9e2a
	racy_payload *pay = (racy_payload *)payload;
Packit ae9e2a
Packit ae9e2a
	if (pay->first_time) {
Packit ae9e2a
		cl_must_pass(p_rmdir(pay->dir));
Packit ae9e2a
		pay->first_time = false;
Packit ae9e2a
	}
Packit ae9e2a
Packit ae9e2a
	return notify_cb__basic(diff_so_far, delta_to_add, matched_pathspec, pay->basic_payload);
Packit ae9e2a
}
Packit ae9e2a
Packit ae9e2a
void test_diff_racediffiter__racy(void)
Packit ae9e2a
{
Packit ae9e2a
	git_diff_options opts = GIT_DIFF_OPTIONS_INIT;
Packit ae9e2a
	git_repository *repo = cl_git_sandbox_init("diff");
Packit ae9e2a
	git_diff *diff;
Packit ae9e2a
Packit ae9e2a
	basic_payload exp_a[] = {
Packit ae9e2a
		{ "another.txt", GIT_DELTA_MODIFIED },
Packit ae9e2a
		{ "readme.txt", GIT_DELTA_MODIFIED },
Packit ae9e2a
		{ NULL, 0 }
Packit ae9e2a
	};
Packit ae9e2a
Packit ae9e2a
	racy_payload pay = { true, "diff/zzzzz", exp_a };
Packit ae9e2a
Packit ae9e2a
	cl_must_pass(p_mkdir("diff/zzzzz", 0777));
Packit ae9e2a
Packit ae9e2a
	opts.flags |= GIT_DIFF_INCLUDE_IGNORED | GIT_DIFF_RECURSE_UNTRACKED_DIRS;
Packit ae9e2a
	opts.notify_cb = notify_cb__racy_rmdir;
Packit ae9e2a
	opts.payload = &pay;
Packit ae9e2a
Packit ae9e2a
	cl_git_pass(git_diff_index_to_workdir(&diff, repo, NULL, &opts));
Packit ae9e2a
Packit ae9e2a
	git_diff_free(diff);
Packit ae9e2a
}