Blame libarchive/test/test_write_disk_secure.c

Packit Service 1d0348
/*-
Packit Service 1d0348
 * Copyright (c) 2003-2007 Tim Kientzle
Packit Service 1d0348
 * All rights reserved.
Packit Service 1d0348
 *
Packit Service 1d0348
 * Redistribution and use in source and binary forms, with or without
Packit Service 1d0348
 * modification, are permitted provided that the following conditions
Packit Service 1d0348
 * are met:
Packit Service 1d0348
 * 1. Redistributions of source code must retain the above copyright
Packit Service 1d0348
 *    notice, this list of conditions and the following disclaimer.
Packit Service 1d0348
 * 2. Redistributions in binary form must reproduce the above copyright
Packit Service 1d0348
 *    notice, this list of conditions and the following disclaimer in the
Packit Service 1d0348
 *    documentation and/or other materials provided with the distribution.
Packit Service 1d0348
 *
Packit Service 1d0348
 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR(S) ``AS IS'' AND ANY EXPRESS OR
Packit Service 1d0348
 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
Packit Service 1d0348
 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
Packit Service 1d0348
 * IN NO EVENT SHALL THE AUTHOR(S) BE LIABLE FOR ANY DIRECT, INDIRECT,
Packit Service 1d0348
 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
Packit Service 1d0348
 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
Packit Service 1d0348
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
Packit Service 1d0348
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
Packit Service 1d0348
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
Packit Service 1d0348
 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
Packit Service 1d0348
 */
Packit Service 1d0348
#include "test.h"
Packit Service 1d0348
__FBSDID("$FreeBSD: head/lib/libarchive/test/test_write_disk_secure.c 201247 2009-12-30 05:59:21Z kientzle $");
Packit Service 1d0348
Packit Service 1d0348
#define UMASK 022
Packit Service 1d0348
Packit Service 1d0348
/*
Packit Service 1d0348
 * Exercise security checks that should prevent certain
Packit Service 1d0348
 * writes.
Packit Service 1d0348
 */
Packit Service 1d0348
Packit Service 1d0348
DEFINE_TEST(test_write_disk_secure)
Packit Service 1d0348
{
Packit Service 1d0348
#if defined(_WIN32) && !defined(__CYGWIN__)
Packit Service 1d0348
	skipping("archive_write_disk security checks not supported on Windows");
Packit Service 1d0348
#else
Packit Service 1d0348
	struct archive *a;
Packit Service 1d0348
	struct archive_entry *ae;
Packit Service 1d0348
	struct stat st;
Packit Service 1d0348
Packit Service 1d0348
	/* Start with a known umask. */
Packit Service 1d0348
	assertUmask(UMASK);
Packit Service 1d0348
Packit Service 1d0348
	/* Create an archive_write_disk object. */
Packit Service 1d0348
	assert((a = archive_write_disk_new()) != NULL);
Packit Service 1d0348
Packit Service 1d0348
	/* Write a regular dir to it. */
Packit Service 1d0348
	assert((ae = archive_entry_new()) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "dir");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFDIR | 0777);
Packit Service 1d0348
	assert(0 == archive_write_header(a, ae));
Packit Service 1d0348
	archive_entry_free(ae);
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
Packit Service 1d0348
	/* Write a symlink to the dir above. */
Packit Service 1d0348
	assert((ae = archive_entry_new()) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "link_to_dir");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFLNK | 0777);
Packit Service 1d0348
	archive_entry_set_symlink(ae, "dir");
Packit Service 1d0348
	archive_write_disk_set_options(a, 0);
Packit Service 1d0348
	assert(0 == archive_write_header(a, ae));
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
Packit Service 1d0348
	/*
Packit Service 1d0348
	 * Without security checks, we should be able to
Packit Service 1d0348
	 * extract a file through the link.
Packit Service 1d0348
	 */
Packit Service 1d0348
	assert(archive_entry_clear(ae) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "link_to_dir/filea");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFREG | 0777);
Packit Service 1d0348
	assert(0 == archive_write_header(a, ae));
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
Packit Service 1d0348
	/* But with security checks enabled, this should fail. */
Packit Service 1d0348
	assert(archive_entry_clear(ae) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "link_to_dir/fileb");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFREG | 0777);
Packit Service 1d0348
	archive_write_disk_set_options(a, ARCHIVE_EXTRACT_SECURE_SYMLINKS);
Packit Service 1d0348
	failure("Extracting a file through a symlink should fail here.");
Packit Service 1d0348
	assertEqualInt(ARCHIVE_FAILED, archive_write_header(a, ae));
Packit Service 1d0348
	archive_entry_free(ae);
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
Packit Service 1d0348
	/* Write an absolute symlink to /tmp. */
Packit Service 1d0348
	assert((ae = archive_entry_new()) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "/tmp/libarchive_test-test_write_disk_secure-absolute_symlink");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFLNK | 0777);
Packit Service 1d0348
	archive_entry_set_symlink(ae, "/tmp");
Packit Service 1d0348
	archive_write_disk_set_options(a, 0);
Packit Service 1d0348
	assert(0 == archive_write_header(a, ae));
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
Packit Service 1d0348
	/* With security checks enabled, this should fail. */
Packit Service 1d0348
	assert(archive_entry_clear(ae) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "/tmp/libarchive_test-test_write_disk_secure-absolute_symlink/libarchive_test-test_write_disk_secure-absolute_symlink_path.tmp");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFREG | 0777);
Packit Service 1d0348
	archive_write_disk_set_options(a, ARCHIVE_EXTRACT_SECURE_SYMLINKS);
Packit Service 1d0348
	failure("Extracting a file through an absolute symlink should fail here.");
Packit Service 1d0348
	assertEqualInt(ARCHIVE_FAILED, archive_write_header(a, ae));
Packit Service 1d0348
	archive_entry_free(ae);
Packit Service 1d0348
	assertFileNotExists("/tmp/libarchive_test-test_write_disk_secure-absolute_symlink/libarchive_test-test_write_disk_secure-absolute_symlink_path.tmp");
Packit Service 1d0348
	assert(0 == unlink("/tmp/libarchive_test-test_write_disk_secure-absolute_symlink"));
Packit Service 1d0348
	unlink("/tmp/libarchive_test-test_write_disk_secure-absolute_symlink_path.tmp");
Packit Service 1d0348
Packit Service 1d0348
	/* Create another link. */
Packit Service 1d0348
	assert((ae = archive_entry_new()) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "link_to_dir2");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFLNK | 0777);
Packit Service 1d0348
	archive_entry_set_symlink(ae, "dir");
Packit Service 1d0348
	archive_write_disk_set_options(a, 0);
Packit Service 1d0348
	assert(0 == archive_write_header(a, ae));
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
Packit Service 1d0348
	/*
Packit Service 1d0348
	 * With symlink check and unlink option, it should remove
Packit Service 1d0348
	 * the link and create the dir.
Packit Service 1d0348
	 */
Packit Service 1d0348
	assert(archive_entry_clear(ae) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "link_to_dir2/filec");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFREG | 0777);
Packit Service 1d0348
	archive_write_disk_set_options(a, ARCHIVE_EXTRACT_SECURE_SYMLINKS | ARCHIVE_EXTRACT_UNLINK);
Packit Service 1d0348
	assertEqualIntA(a, ARCHIVE_OK, archive_write_header(a, ae));
Packit Service 1d0348
	archive_entry_free(ae);
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
Packit Service 1d0348
	/* Create a nested symlink. */
Packit Service 1d0348
	assert((ae = archive_entry_new()) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "dir/nested_link_to_dir");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFLNK | 0777);
Packit Service 1d0348
	archive_entry_set_symlink(ae, "../dir");
Packit Service 1d0348
	archive_write_disk_set_options(a, 0);
Packit Service 1d0348
	assert(0 == archive_write_header(a, ae));
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
Packit Service 1d0348
	/* But with security checks enabled, this should fail. */
Packit Service 1d0348
	assert(archive_entry_clear(ae) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "dir/nested_link_to_dir/filed");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFREG | 0777);
Packit Service 1d0348
	archive_write_disk_set_options(a, ARCHIVE_EXTRACT_SECURE_SYMLINKS);
Packit Service 1d0348
	failure("Extracting a file through a symlink should fail here.");
Packit Service 1d0348
	assertEqualInt(ARCHIVE_FAILED, archive_write_header(a, ae));
Packit Service 1d0348
	archive_entry_free(ae);
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
Packit Service 1d0348
	/*
Packit Service 1d0348
	 * Without security checks, extracting a dir over a link to a
Packit Service 1d0348
	 * dir should follow the link.
Packit Service 1d0348
	 */
Packit Service 1d0348
	/* Create a symlink to a dir. */
Packit Service 1d0348
	assert((ae = archive_entry_new()) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "link_to_dir3");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFLNK | 0777);
Packit Service 1d0348
	archive_entry_set_symlink(ae, "dir");
Packit Service 1d0348
	archive_write_disk_set_options(a, 0);
Packit Service 1d0348
	assert(0 == archive_write_header(a, ae));
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
	/* Extract a dir whose name matches the symlink. */
Packit Service 1d0348
	assert(archive_entry_clear(ae) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "link_to_dir3");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFDIR | 0777);
Packit Service 1d0348
	assert(0 == archive_write_header(a, ae));
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
	/* Verify link was followed. */
Packit Service 1d0348
	assertEqualInt(0, lstat("link_to_dir3", &st);;
Packit Service 1d0348
	assert(S_ISLNK(st.st_mode));
Packit Service 1d0348
	archive_entry_free(ae);
Packit Service 1d0348
Packit Service 1d0348
	/*
Packit Service 1d0348
	 * As above, but a broken link, so the link should get replaced.
Packit Service 1d0348
	 */
Packit Service 1d0348
	/* Create a symlink to a dir. */
Packit Service 1d0348
	assert((ae = archive_entry_new()) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "link_to_dir4");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFLNK | 0777);
Packit Service 1d0348
	archive_entry_set_symlink(ae, "nonexistent_dir");
Packit Service 1d0348
	archive_write_disk_set_options(a, 0);
Packit Service 1d0348
	assert(0 == archive_write_header(a, ae));
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
	/* Extract a dir whose name matches the symlink. */
Packit Service 1d0348
	assert(archive_entry_clear(ae) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "link_to_dir4");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFDIR | 0777);
Packit Service 1d0348
	assert(0 == archive_write_header(a, ae));
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
	/* Verify link was replaced. */
Packit Service 1d0348
	assertEqualInt(0, lstat("link_to_dir4", &st);;
Packit Service 1d0348
	assert(S_ISDIR(st.st_mode));
Packit Service 1d0348
	archive_entry_free(ae);
Packit Service 1d0348
Packit Service 1d0348
	/*
Packit Service 1d0348
	 * As above, but a link to a non-dir, so the link should get replaced.
Packit Service 1d0348
	 */
Packit Service 1d0348
	/* Create a regular file and a symlink to it */
Packit Service 1d0348
	assert((ae = archive_entry_new()) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "non_dir");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFREG | 0777);
Packit Service 1d0348
	archive_write_disk_set_options(a, 0);
Packit Service 1d0348
	assert(0 == archive_write_header(a, ae));
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
	/* Create symlink to the file. */
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "link_to_dir5");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFLNK | 0777);
Packit Service 1d0348
	archive_entry_set_symlink(ae, "non_dir");
Packit Service 1d0348
	archive_write_disk_set_options(a, 0);
Packit Service 1d0348
	assert(0 == archive_write_header(a, ae));
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
	/* Extract a dir whose name matches the symlink. */
Packit Service 1d0348
	assert(archive_entry_clear(ae) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "link_to_dir5");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFDIR | 0777);
Packit Service 1d0348
	assert(0 == archive_write_header(a, ae));
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
	/* Verify link was replaced. */
Packit Service 1d0348
	assertEqualInt(0, lstat("link_to_dir5", &st);;
Packit Service 1d0348
	assert(S_ISDIR(st.st_mode));
Packit Service 1d0348
	archive_entry_free(ae);
Packit Service 1d0348
Packit Service 1d0348
	/*
Packit Service 1d0348
	 * Without security checks, we should be able to
Packit Service 1d0348
	 * extract an absolute path.
Packit Service 1d0348
	 */
Packit Service 1d0348
	assert((ae = archive_entry_new()) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "/tmp/libarchive_test-test_write_disk_secure-absolute_path.tmp");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFREG | 0777);
Packit Service 1d0348
	assert(0 == archive_write_header(a, ae));
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
	assertFileExists("/tmp/libarchive_test-test_write_disk_secure-absolute_path.tmp");
Packit Service 1d0348
	assert(0 == unlink("/tmp/libarchive_test-test_write_disk_secure-absolute_path.tmp"));
Packit Service 1d0348
Packit Service 1d0348
	/* But with security checks enabled, this should fail. */
Packit Service 1d0348
	assert(archive_entry_clear(ae) != NULL);
Packit Service 1d0348
	archive_entry_copy_pathname(ae, "/tmp/libarchive_test-test_write_disk_secure-absolute_path.tmp");
Packit Service 1d0348
	archive_entry_set_mode(ae, S_IFREG | 0777);
Packit Service 1d0348
	archive_write_disk_set_options(a, ARCHIVE_EXTRACT_SECURE_NOABSOLUTEPATHS);
Packit Service 1d0348
	failure("Extracting an absolute path should fail here.");
Packit Service 1d0348
	assertEqualInt(ARCHIVE_FAILED, archive_write_header(a, ae));
Packit Service 1d0348
	archive_entry_free(ae);
Packit Service 1d0348
	assert(0 == archive_write_finish_entry(a));
Packit Service 1d0348
	assertFileNotExists("/tmp/libarchive_test-test_write_disk_secure-absolute_path.tmp");
Packit Service 1d0348
Packit Service 1d0348
	assertEqualInt(ARCHIVE_OK, archive_write_free(a));
Packit Service 1d0348
Packit Service 1d0348
	/* Test the entries on disk. */
Packit Service 1d0348
	assert(0 == lstat("dir", &st);;
Packit Service 1d0348
	failure("dir: st.st_mode=%o", st.st_mode);
Packit Service 1d0348
	assert((st.st_mode & 0777) == 0755);
Packit Service 1d0348
Packit Service 1d0348
	assert(0 == lstat("link_to_dir", &st);;
Packit Service 1d0348
	failure("link_to_dir: st.st_mode=%o", st.st_mode);
Packit Service 1d0348
	assert(S_ISLNK(st.st_mode));
Packit Service 1d0348
#if HAVE_LCHMOD
Packit Service 1d0348
	/* Systems that lack lchmod() can't set symlink perms, so skip this. */
Packit Service 1d0348
	failure("link_to_dir: st.st_mode=%o", st.st_mode);
Packit Service 1d0348
	assert((st.st_mode & 07777) == 0755);
Packit Service 1d0348
#endif
Packit Service 1d0348
Packit Service 1d0348
	assert(0 == lstat("dir/filea", &st);;
Packit Service 1d0348
	failure("dir/filea: st.st_mode=%o", st.st_mode);
Packit Service 1d0348
	assert((st.st_mode & 07777) == 0755);
Packit Service 1d0348
Packit Service 1d0348
	failure("dir/fileb: This file should not have been created");
Packit Service 1d0348
	assert(0 != lstat("dir/fileb", &st);;
Packit Service 1d0348
Packit Service 1d0348
	assert(0 == lstat("link_to_dir2", &st);;
Packit Service 1d0348
	failure("link_to_dir2 should have been re-created as a true dir");
Packit Service 1d0348
	assert(S_ISDIR(st.st_mode));
Packit Service 1d0348
	failure("link_to_dir2: Implicit dir creation should obey umask, but st.st_mode=%o", st.st_mode);
Packit Service 1d0348
	assert((st.st_mode & 0777) == 0755);
Packit Service 1d0348
Packit Service 1d0348
	assert(0 == lstat("link_to_dir2/filec", &st);;
Packit Service 1d0348
	assert(S_ISREG(st.st_mode));
Packit Service 1d0348
	failure("link_to_dir2/filec: st.st_mode=%o", st.st_mode);
Packit Service 1d0348
	assert((st.st_mode & 07777) == 0755);
Packit Service 1d0348
Packit Service 1d0348
	failure("dir/filed: This file should not have been created");
Packit Service 1d0348
	assert(0 != lstat("dir/filed", &st);;
Packit Service 1d0348
#endif
Packit Service 1d0348
}