Blame nss/bug17079.c

Packit 6c4009
/* Test for bug 17079: heap overflow in NSS with small buffers.
Packit 6c4009
   Copyright (C) 2015-2018 Free Software Foundation, Inc.
Packit 6c4009
   This file is part of the GNU C Library.
Packit 6c4009
Packit 6c4009
   The GNU C Library is free software; you can redistribute it and/or
Packit 6c4009
   modify it under the terms of the GNU Lesser General Public
Packit 6c4009
   License as published by the Free Software Foundation; either
Packit 6c4009
   version 2.1 of the License, or (at your option) any later version.
Packit 6c4009
Packit 6c4009
   The GNU C Library is distributed in the hope that it will be useful,
Packit 6c4009
   but WITHOUT ANY WARRANTY; without even the implied warranty of
Packit 6c4009
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
Packit 6c4009
   Lesser General Public License for more details.
Packit 6c4009
Packit 6c4009
   You should have received a copy of the GNU Lesser General Public
Packit 6c4009
   License along with the GNU C Library; if not, see
Packit 6c4009
   <http://www.gnu.org/licenses/>.  */
Packit 6c4009
Packit 6c4009
#include <errno.h>
Packit 6c4009
#include <nss.h>
Packit 6c4009
#include <pwd.h>
Packit 6c4009
#include <stdbool.h>
Packit 6c4009
#include <stdio.h>
Packit 6c4009
#include <stdlib.h>
Packit 6c4009
#include <string.h>
Packit 6c4009
Packit 6c4009
#include <support/support.h>
Packit 6c4009
Packit 6c4009
/* Check if two passwd structs contain the same data.  */
Packit 6c4009
static bool
Packit 6c4009
equal (const struct passwd *a, const struct passwd *b)
Packit 6c4009
{
Packit 6c4009
  return strcmp (a->pw_name, b->pw_name) == 0
Packit 6c4009
    && strcmp (a->pw_passwd, b->pw_passwd) == 0
Packit 6c4009
    && a->pw_uid == b->pw_uid
Packit 6c4009
    && a->pw_gid == b->pw_gid
Packit 6c4009
    && strcmp (a->pw_gecos, b->pw_gecos) == 0
Packit 6c4009
    && strcmp (a->pw_dir, b->pw_dir) == 0
Packit 6c4009
    && strcmp (a->pw_shell, b->pw_shell) == 0;
Packit 6c4009
}
Packit 6c4009
Packit 6c4009
enum { MAX_TEST_ITEMS = 10 };
Packit 6c4009
static struct passwd test_items[MAX_TEST_ITEMS];
Packit 6c4009
static int test_count;
Packit 6c4009
Packit 6c4009
/* Initialize test_items and test_count above, with data from the
Packit 6c4009
   passwd database.  */
Packit 6c4009
static bool
Packit 6c4009
init_test_items (void)
Packit 6c4009
{
Packit 6c4009
  setpwent ();
Packit 6c4009
  do
Packit 6c4009
    {
Packit 6c4009
      struct passwd *pwd = getpwent ();
Packit 6c4009
      if (pwd == NULL)
Packit 6c4009
        break;
Packit 6c4009
      struct passwd *target = test_items + test_count;
Packit 6c4009
      target->pw_name = xstrdup (pwd->pw_name);
Packit 6c4009
      target->pw_passwd = xstrdup (pwd->pw_passwd);
Packit 6c4009
      target->pw_uid = pwd->pw_uid;
Packit 6c4009
      target->pw_gid = pwd->pw_gid;
Packit 6c4009
      target->pw_gecos = xstrdup (pwd->pw_gecos);
Packit 6c4009
      target->pw_dir = xstrdup (pwd->pw_dir);
Packit 6c4009
      target->pw_shell = xstrdup (pwd->pw_shell);
Packit 6c4009
    }
Packit 6c4009
  while (++test_count < MAX_TEST_ITEMS);
Packit 6c4009
  endpwent ();
Packit 6c4009
Packit 6c4009
  /* Filter out those test items which cannot be looked up by name or
Packit 6c4009
     UID.  */
Packit 6c4009
  bool found = false;
Packit 6c4009
  for (int i = 0; i < test_count; ++i)
Packit 6c4009
    {
Packit 6c4009
      struct passwd *pwd1 = getpwnam (test_items[i].pw_name);
Packit 6c4009
      struct passwd *pwd2 = getpwuid (test_items[i].pw_uid);
Packit 6c4009
      if (pwd1 == NULL || !equal (pwd1, test_items + i)
Packit 6c4009
          || pwd2 == NULL || !equal (pwd2, test_items + i))
Packit 6c4009
        {
Packit 6c4009
          printf ("info: skipping user \"%s\", UID %ld due to inconsistency\n",
Packit 6c4009
                  test_items[i].pw_name, (long) test_items[i].pw_uid);
Packit 6c4009
          test_items[i].pw_name = NULL;
Packit 6c4009
        }
Packit 6c4009
      else
Packit 6c4009
        found = true;
Packit 6c4009
    }
Packit 6c4009
Packit 6c4009
  if (!found)
Packit 6c4009
    puts ("error: no accounts found which can be looked up by name and UID.");
Packit 6c4009
  return found;
Packit 6c4009
}
Packit 6c4009
Packit 6c4009
/* Set to true if an error is encountered.  */
Packit 6c4009
static bool errors;
Packit 6c4009
Packit 6c4009
/* Return true if the padding has not been tampered with.  */
Packit 6c4009
static bool
Packit 6c4009
check_padding (char *buffer, size_t size, char pad)
Packit 6c4009
{
Packit 6c4009
  char *end = buffer + size;
Packit 6c4009
  while (buffer < end)
Packit 6c4009
    {
Packit 6c4009
      if (*buffer != pad)
Packit 6c4009
        return false;
Packit 6c4009
      ++buffer;
Packit 6c4009
    }
Packit 6c4009
  return true;
Packit 6c4009
}
Packit 6c4009
Packit 6c4009
/* Test one buffer size and padding combination.  */
Packit 6c4009
static void
Packit 6c4009
test_one (const struct passwd *item, size_t buffer_size,
Packit 6c4009
           char pad, size_t padding_size)
Packit 6c4009
{
Packit 6c4009
  char *buffer = xmalloc (buffer_size + padding_size);
Packit 6c4009
Packit 6c4009
  struct passwd pwd;
Packit 6c4009
  struct passwd *result;
Packit 6c4009
  int ret;
Packit 6c4009
Packit 6c4009
  /* Test getpwname_r.  */
Packit 6c4009
  memset (buffer, pad, buffer_size + padding_size);
Packit 6c4009
  pwd = (struct passwd) {};
Packit 6c4009
  ret = getpwnam_r (item->pw_name, &pwd, buffer, buffer_size, &result);
Packit 6c4009
  if (!check_padding (buffer + buffer_size, padding_size, pad))
Packit 6c4009
    {
Packit 6c4009
      printf ("error: padding change: "
Packit 6c4009
              "name \"%s\", buffer size %zu, padding size %zu, pad 0x%02x\n",
Packit 6c4009
              item->pw_name, buffer_size, padding_size, (unsigned char) pad);
Packit 6c4009
      errors = true;
Packit 6c4009
    }
Packit 6c4009
  if (ret == 0)
Packit 6c4009
    {
Packit 6c4009
      if (result == NULL)
Packit 6c4009
        {
Packit 6c4009
          printf ("error: no data: name \"%s\", buffer size %zu\n",
Packit 6c4009
                  item->pw_name, buffer_size);
Packit 6c4009
          errors = true;
Packit 6c4009
        }
Packit 6c4009
      else if (!equal (item, result))
Packit 6c4009
        {
Packit 6c4009
          printf ("error: lookup mismatch: name \"%s\", buffer size %zu\n",
Packit 6c4009
                  item->pw_name, buffer_size);
Packit 6c4009
          errors = true;
Packit 6c4009
        }
Packit 6c4009
    }
Packit 6c4009
  else if (ret != ERANGE)
Packit 6c4009
    {
Packit 6c4009
      errno = ret;
Packit 6c4009
      printf ("error: lookup failure for name \"%s\": %m (%d)\n",
Packit 6c4009
              item->pw_name, ret);
Packit 6c4009
      errors = true;
Packit 6c4009
    }
Packit 6c4009
Packit 6c4009
  /* Test getpwuid_r.  */
Packit 6c4009
  memset (buffer, pad, buffer_size + padding_size);
Packit 6c4009
  pwd = (struct passwd) {};
Packit 6c4009
  ret = getpwuid_r (item->pw_uid, &pwd, buffer, buffer_size, &result);
Packit 6c4009
  if (!check_padding (buffer + buffer_size, padding_size, pad))
Packit 6c4009
    {
Packit 6c4009
      printf ("error: padding change: "
Packit 6c4009
              "UID %ld, buffer size %zu, padding size %zu, pad 0x%02x\n",
Packit 6c4009
              (long) item->pw_uid, buffer_size, padding_size,
Packit 6c4009
              (unsigned char) pad);
Packit 6c4009
      errors = true;
Packit 6c4009
    }
Packit 6c4009
  if (ret == 0)
Packit 6c4009
    {
Packit 6c4009
      if (result == NULL)
Packit 6c4009
        {
Packit 6c4009
          printf ("error: no data: UID %ld, buffer size %zu\n",
Packit 6c4009
                  (long) item->pw_uid, buffer_size);
Packit 6c4009
          errors = true;
Packit 6c4009
        }
Packit 6c4009
      else if (!equal (item, result))
Packit 6c4009
        {
Packit 6c4009
          printf ("error: lookup mismatch: UID %ld, buffer size %zu\n",
Packit 6c4009
                  (long) item->pw_uid, buffer_size);
Packit 6c4009
          errors = true;
Packit 6c4009
        }
Packit 6c4009
    }
Packit 6c4009
  else if (ret != ERANGE)
Packit 6c4009
    {
Packit 6c4009
      errno = ret;
Packit 6c4009
      printf ("error: lookup failure for UID \"%ld\": %m (%d)\n",
Packit 6c4009
              (long) item->pw_uid, ret);
Packit 6c4009
      errors = true;
Packit 6c4009
    }
Packit 6c4009
Packit 6c4009
  free (buffer);
Packit 6c4009
}
Packit 6c4009
Packit 6c4009
/* Test one buffer size with different paddings.  */
Packit 6c4009
static void
Packit 6c4009
test_buffer_size (size_t buffer_size)
Packit 6c4009
{
Packit 6c4009
  for (int i = 0; i < test_count; ++i)
Packit 6c4009
    for (size_t padding_size = 0; padding_size < 3; ++padding_size)
Packit 6c4009
      {
Packit 6c4009
        /* Skip entries with inconsistent name/UID lookups.  */
Packit 6c4009
        if (test_items[i].pw_name == NULL)
Packit 6c4009
          continue;
Packit 6c4009
Packit 6c4009
        test_one (test_items + i, buffer_size, '\0', padding_size);
Packit 6c4009
        if (padding_size > 0)
Packit 6c4009
          {
Packit 6c4009
            test_one (test_items + i, buffer_size, ':', padding_size);
Packit 6c4009
            test_one (test_items + i, buffer_size, '\n', padding_size);
Packit 6c4009
            test_one (test_items + i, buffer_size, '\xff', padding_size);
Packit 6c4009
            test_one (test_items + i, buffer_size, '@', padding_size);
Packit 6c4009
          }
Packit 6c4009
      }
Packit 6c4009
}
Packit 6c4009
Packit 6c4009
int
Packit 6c4009
do_test (void)
Packit 6c4009
{
Packit 6c4009
  __nss_configure_lookup ("passwd", "files");
Packit 6c4009
Packit 6c4009
  if (!init_test_items ())
Packit 6c4009
    return 1;
Packit 6c4009
  printf ("info: %d test items\n", test_count);
Packit 6c4009
Packit 6c4009
  for (size_t buffer_size = 0; buffer_size <= 65; ++buffer_size)
Packit 6c4009
    test_buffer_size (buffer_size);
Packit 6c4009
  for (size_t buffer_size = 64 + 4; buffer_size < 256; buffer_size += 4)
Packit 6c4009
    test_buffer_size (buffer_size);
Packit 6c4009
  test_buffer_size (255);
Packit 6c4009
  test_buffer_size (257);
Packit 6c4009
  for (size_t buffer_size = 256; buffer_size < 512; buffer_size += 8)
Packit 6c4009
    test_buffer_size (buffer_size);
Packit 6c4009
  test_buffer_size (511);
Packit 6c4009
  test_buffer_size (513);
Packit 6c4009
  test_buffer_size (1024);
Packit 6c4009
  test_buffer_size (2048);
Packit 6c4009
Packit 6c4009
  if (errors)
Packit 6c4009
    return 1;
Packit 6c4009
  else
Packit 6c4009
    return 0;
Packit 6c4009
}
Packit 6c4009
Packit 6c4009
#include <support/test-driver.c>