|
Packit |
6ef888 |
Contributing to gfs2-utils
|
|
Packit |
6ef888 |
--------------------------
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
Here are some brief guidelines to follow when contributing to gfs2-utils.
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
Translations
|
|
Packit |
6ef888 |
------------
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
We use the Zanata translation service:
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
https://fedora.zanata.org/project/view/gfs2-utils
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
See the documentation there for submitting translations.
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
Patches
|
|
Packit |
6ef888 |
-------
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
We don't dictate any particular coding style but please try to use a style
|
|
Packit |
6ef888 |
consistent with the existing code. If in doubt, the Linux kernel coding style
|
|
Packit |
6ef888 |
document is a good guideline:
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
http://www.kernel.org/doc/Documentation/CodingStyle
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
We use git for managing our source code and we assume here that you're familiar
|
|
Packit |
6ef888 |
with git. Patches should apply cleanly to the latest master branch of
|
|
Packit |
6ef888 |
gfs2-utils.git
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
https://pagure.io/gfs2-utils
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
For ease of review and maintenance each of your patches should address a single
|
|
Packit |
6ef888 |
issue and if there are multiple issues please consider spreading your work over
|
|
Packit |
6ef888 |
several patches. Ideally none of the individual patches should break the build.
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
We value good commit logs, which should be of the form:
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
component: short patch summary
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
Longer description wrapped at approx. 72 columns explaining the problem the
|
|
Packit |
6ef888 |
patch addresses and how the patch addresses it.
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
Signed-off-by: Your Name <youremail@example.com>
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
The "component" should be the name of the tool or the part of the code which
|
|
Packit |
6ef888 |
the patch touches. As we share a mailing list with several projects it should
|
|
Packit |
6ef888 |
make clear that it's a gfs2-utils patch. Some examples:
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
Bad short logs:
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
Fix a bug
|
|
Packit |
6ef888 |
Add a test
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
Good short logs:
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
fsck.gfs2: Fix a null pointer dereference in foo
|
|
Packit |
6ef888 |
gfs2-utils: Add a test for lgfs2_do_stuff
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
Be sure to reference any relevant bug reports in your long description, e.g.
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
Ref: rhbz#012345
|
|
Packit |
6ef888 |
Fixes: rhbz#98765
|
|
Packit |
6ef888 |
|
|
Packit |
6ef888 |
Please send patches to <cluster-devel@redhat.com>. We recommend using
|
|
Packit |
6ef888 |
`git format-patch' to generate patch emails from your commits and `git
|
|
Packit |
6ef888 |
send-email' for sending them to the list. See the git documentation for
|
|
Packit |
6ef888 |
details.
|