Blame doc/README.contributing

Packit Service 360c39
Contributing to gfs2-utils
Packit Service 360c39
--------------------------
Packit Service 360c39
Packit Service 360c39
Here are some brief guidelines to follow when contributing to gfs2-utils.
Packit Service 360c39
Packit Service 360c39
Translations
Packit Service 360c39
------------
Packit Service 360c39
Packit Service 360c39
We use the Zanata translation service:
Packit Service 360c39
Packit Service 360c39
    https://fedora.zanata.org/project/view/gfs2-utils
Packit Service 360c39
Packit Service 360c39
See the documentation there for submitting translations.
Packit Service 360c39
Packit Service 360c39
Patches
Packit Service 360c39
-------
Packit Service 360c39
Packit Service 360c39
We don't dictate any particular coding style but please try to use a style
Packit Service 360c39
consistent with the existing code. If in doubt, the Linux kernel coding style
Packit Service 360c39
document is a good guideline:
Packit Service 360c39
Packit Service 360c39
    http://www.kernel.org/doc/Documentation/CodingStyle
Packit Service 360c39
Packit Service 360c39
We use git for managing our source code and we assume here that you're familiar
Packit Service 360c39
with git. Patches should apply cleanly to the latest master branch of
Packit Service 360c39
gfs2-utils.git
Packit Service 360c39
Packit Service 360c39
    https://pagure.io/gfs2-utils
Packit Service 360c39
Packit Service 360c39
For ease of review and maintenance each of your patches should address a single
Packit Service 360c39
issue and if there are multiple issues please consider spreading your work over
Packit Service 360c39
several patches. Ideally none of the individual patches should break the build.
Packit Service 360c39
Packit Service 360c39
We value good commit logs, which should be of the form:
Packit Service 360c39
Packit Service 360c39
    component: short patch summary
Packit Service 360c39
Packit Service 360c39
    Longer description wrapped at approx. 72 columns explaining the problem the
Packit Service 360c39
    patch addresses and how the patch addresses it.
Packit Service 360c39
Packit Service 360c39
    Signed-off-by: Your Name <youremail@example.com>
Packit Service 360c39
Packit Service 360c39
The "component" should be the name of the tool or the part of the code which
Packit Service 360c39
the patch touches. As we share a mailing list with several projects it should
Packit Service 360c39
make clear that it's a gfs2-utils patch. Some examples:
Packit Service 360c39
Packit Service 360c39
Bad short logs:
Packit Service 360c39
Packit Service 360c39
    Fix a bug
Packit Service 360c39
    Add a test
Packit Service 360c39
Packit Service 360c39
Good short logs:
Packit Service 360c39
Packit Service 360c39
    fsck.gfs2: Fix a null pointer dereference in foo
Packit Service 360c39
    gfs2-utils: Add a test for lgfs2_do_stuff
Packit Service 360c39
Packit Service 360c39
Be sure to reference any relevant bug reports in your long description, e.g.
Packit Service 360c39
Packit Service 360c39
    Ref: rhbz#012345
Packit Service 360c39
    Fixes: rhbz#98765
Packit Service 360c39
Packit Service 360c39
Please send patches to <cluster-devel@redhat.com>. We recommend using
Packit Service 360c39
`git format-patch' to generate patch emails from your commits and `git
Packit Service 360c39
send-email' for sending them to the list. See the git documentation for
Packit Service 360c39
details.