|
Packit |
15f964 |
1 Patch guidelines
|
|
Packit |
15f964 |
|
|
Packit |
15f964 |
Procedures that should be followed when submitting patches for
|
|
Packit |
15f964 |
Evolution are available on
|
|
Packit |
15f964 |
http://projects.gnome.org/evolution/patch.shtml
|
|
Packit |
15f964 |
|
|
Packit |
15f964 |
Further information:
|
|
Packit |
15f964 |
|
|
Packit |
15f964 |
1.1 Subject Lines
|
|
Packit |
15f964 |
|
|
Packit |
15f964 |
If the patch addresses a specific bug in bugzilla.gnome.org, then the
|
|
Packit |
15f964 |
bug number must be included in the subject line, preferably near the
|
|
Packit |
15f964 |
beginning of the subject line. A concise summary of the bug(s) being
|
|
Packit |
15f964 |
addressed, should be the remainder of the subject.
|
|
Packit |
15f964 |
|
|
Packit |
15f964 |
It is unnecessary to add "[PATCH]", "patch" or similar to the subject
|
|
Packit |
15f964 |
line, unless it is being cross-posted to other non-patch lists.
|
|
Packit |
15f964 |
|
|
Packit |
15f964 |
It is absolutely unnecessary to add "please consider", "please review",
|
|
Packit |
15f964 |
or "seeking review", or similar, to the subject line. Please do not do
|
|
Packit |
15f964 |
this.
|
|
Packit |
15f964 |
|
|
Packit |
15f964 |
Where the patch does not address a specific bug number, then the subject
|
|
Packit |
15f964 |
line should simply be a concise summary of the problem/feature it
|
|
Packit |
15f964 |
addresses.
|
|
Packit |
15f964 |
|
|
Packit |
15f964 |
In all cases the subject line should include the module(s) to which the
|
|
Packit |
15f964 |
patch applies, and would generally match the component on the bug or
|
|
Packit |
15f964 |
the top-level module directory (e.g. camel, mail, addressbook, use 'all'
|
|
Packit |
15f964 |
for more than 3 or 4 modules).
|
|
Packit |
15f964 |
|
|
Packit |
15f964 |
2.2 Message Body
|
|
Packit |
15f964 |
|
|
Packit |
15f964 |
Patches should be attached as attachments, preferably as a single
|
|
Packit |
15f964 |
diff, when possible, and the changes are related. The diff must be in
|
|
Packit |
15f964 |
unified diff format, "-up" is a suitable argument to give to "cvs
|
|
Packit |
15f964 |
diff" (-p may be dropped if not supported by your diff). If you have
|
|
Packit |
15f964 |
added files, then -N should also be used, but if you are using cvs,
|
|
Packit |
15f964 |
"cvs add" is needed, and requires write access to the repository.
|
|
Packit |
15f964 |
|
|
Packit |
15f964 |
If the patch does not address a specific bug, then the patch email
|
|
Packit |
15f964 |
should describe which feature or problem it addresses. If it does
|
|
Packit |
15f964 |
address a specific bug, then further explanation beyond the bug
|
|
Packit |
15f964 |
commentary is optional, although often convenient.
|
|
Packit |
15f964 |
|
|
Packit |
15f964 |
It would also be helpful to summarise the module to which it applies
|
|
Packit |
15f964 |
in the message body.
|
|
Packit |
15f964 |
|
|
Packit |
15f964 |
In all cases you should include which branch, or branches, the patch
|
|
Packit |
15f964 |
is intended to apply to. If this is not given it will be assumed to
|
|
Packit |
15f964 |
be the trunk (HEAD), and such patches will and must not be applied to
|
|
Packit |
15f964 |
any stable branch without further approval.
|
|
Packit |
15f964 |
|
|
Packit |
15f964 |
2.3 Stable branches
|
|
Packit |
15f964 |
|
|
Packit |
15f964 |
Generally, any patch to the stable branch from non-core developers
|
|
Packit |
15f964 |
must address a specific bug in bugzilla.gnome.org. The patch should
|
|
Packit |
15f964 |
also be attached to the bug in question. The patch must not be
|
|
Packit |
15f964 |
applied until reviewed.
|