Blame checks.c

Packit Service 87beb7
// SPDX-License-Identifier: GPL-2.0-or-later
Packit Service 87beb7
/*
Packit Service 87beb7
 * (C) Copyright David Gibson <dwg@au1.ibm.com>, IBM Corporation.  2007.
Packit Service 87beb7
 */
Packit Service 87beb7
Packit Service 87beb7
#include "dtc.h"
Packit Service 87beb7
#include "srcpos.h"
Packit Service 87beb7
Packit Service 87beb7
#ifdef TRACE_CHECKS
Packit Service 87beb7
#define TRACE(c, ...) \
Packit Service 87beb7
	do { \
Packit Service 87beb7
		fprintf(stderr, "=== %s: ", (c)->name); \
Packit Service 87beb7
		fprintf(stderr, __VA_ARGS__); \
Packit Service 87beb7
		fprintf(stderr, "\n"); \
Packit Service 87beb7
	} while (0)
Packit Service 87beb7
#else
Packit Service 87beb7
#define TRACE(c, fmt, ...)	do { } while (0)
Packit Service 87beb7
#endif
Packit Service 87beb7
Packit Service 87beb7
enum checkstatus {
Packit Service 87beb7
	UNCHECKED = 0,
Packit Service 87beb7
	PREREQ,
Packit Service 87beb7
	PASSED,
Packit Service 87beb7
	FAILED,
Packit Service 87beb7
};
Packit Service 87beb7
Packit Service 87beb7
struct check;
Packit Service 87beb7
Packit Service 87beb7
typedef void (*check_fn)(struct check *c, struct dt_info *dti, struct node *node);
Packit Service 87beb7
Packit Service 87beb7
struct check {
Packit Service 87beb7
	const char *name;
Packit Service 87beb7
	check_fn fn;
Packit Service 87beb7
	void *data;
Packit Service 87beb7
	bool warn, error;
Packit Service 87beb7
	enum checkstatus status;
Packit Service 87beb7
	bool inprogress;
Packit Service 87beb7
	int num_prereqs;
Packit Service 87beb7
	struct check **prereq;
Packit Service 87beb7
};
Packit Service 87beb7
Packit Service 87beb7
#define CHECK_ENTRY(nm_, fn_, d_, w_, e_, ...)	       \
Packit Service 87beb7
	static struct check *nm_##_prereqs[] = { __VA_ARGS__ }; \
Packit Service 87beb7
	static struct check nm_ = { \
Packit Service 87beb7
		.name = #nm_, \
Packit Service 87beb7
		.fn = (fn_), \
Packit Service 87beb7
		.data = (d_), \
Packit Service 87beb7
		.warn = (w_), \
Packit Service 87beb7
		.error = (e_), \
Packit Service 87beb7
		.status = UNCHECKED, \
Packit Service 87beb7
		.num_prereqs = ARRAY_SIZE(nm_##_prereqs), \
Packit Service 87beb7
		.prereq = nm_##_prereqs, \
Packit Service 87beb7
	};
Packit Service 87beb7
#define WARNING(nm_, fn_, d_, ...) \
Packit Service 87beb7
	CHECK_ENTRY(nm_, fn_, d_, true, false, __VA_ARGS__)
Packit Service 87beb7
#define ERROR(nm_, fn_, d_, ...) \
Packit Service 87beb7
	CHECK_ENTRY(nm_, fn_, d_, false, true, __VA_ARGS__)
Packit Service 87beb7
#define CHECK(nm_, fn_, d_, ...) \
Packit Service 87beb7
	CHECK_ENTRY(nm_, fn_, d_, false, false, __VA_ARGS__)
Packit Service 87beb7
Packit Service 87beb7
static inline void  PRINTF(5, 6) check_msg(struct check *c, struct dt_info *dti,
Packit Service 87beb7
					   struct node *node,
Packit Service 87beb7
					   struct property *prop,
Packit Service 87beb7
					   const char *fmt, ...)
Packit Service 87beb7
{
Packit Service 87beb7
	va_list ap;
Packit Service 87beb7
	char *str = NULL;
Packit Service 87beb7
	struct srcpos *pos = NULL;
Packit Service 87beb7
	char *file_str;
Packit Service 87beb7
Packit Service 87beb7
	if (!(c->warn && (quiet < 1)) && !(c->error && (quiet < 2)))
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (prop && prop->srcpos)
Packit Service 87beb7
		pos = prop->srcpos;
Packit Service 87beb7
	else if (node && node->srcpos)
Packit Service 87beb7
		pos = node->srcpos;
Packit Service 87beb7
Packit Service 87beb7
	if (pos) {
Packit Service 87beb7
		file_str = srcpos_string(pos);
Packit Service 87beb7
		xasprintf(&str, "%s", file_str);
Packit Service 87beb7
		free(file_str);
Packit Service 87beb7
	} else if (streq(dti->outname, "-")) {
Packit Service 87beb7
		xasprintf(&str, "<stdout>");
Packit Service 87beb7
	} else {
Packit Service 87beb7
		xasprintf(&str, "%s", dti->outname);
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	xasprintf_append(&str, ": %s (%s): ",
Packit Service 87beb7
			(c->error) ? "ERROR" : "Warning", c->name);
Packit Service 87beb7
Packit Service 87beb7
	if (node) {
Packit Service 87beb7
		if (prop)
Packit Service 87beb7
			xasprintf_append(&str, "%s:%s: ", node->fullpath, prop->name);
Packit Service 87beb7
		else
Packit Service 87beb7
			xasprintf_append(&str, "%s: ", node->fullpath);
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	va_start(ap, fmt);
Packit Service 87beb7
	xavsprintf_append(&str, fmt, ap);
Packit Service 87beb7
	va_end(ap);
Packit Service 87beb7
Packit Service 87beb7
	xasprintf_append(&str, "\n");
Packit Service 87beb7
Packit Service 87beb7
	if (!prop && pos) {
Packit Service 87beb7
		pos = node->srcpos;
Packit Service 87beb7
		while (pos->next) {
Packit Service 87beb7
			pos = pos->next;
Packit Service 87beb7
Packit Service 87beb7
			file_str = srcpos_string(pos);
Packit Service 87beb7
			xasprintf_append(&str, "  also defined at %s\n", file_str);
Packit Service 87beb7
			free(file_str);
Packit Service 87beb7
		}
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	fputs(str, stderr);
Packit Service 87beb7
}
Packit Service 87beb7
Packit Service 87beb7
#define FAIL(c, dti, node, ...)						\
Packit Service 87beb7
	do {								\
Packit Service 87beb7
		TRACE((c), "\t\tFAILED at %s:%d", __FILE__, __LINE__);	\
Packit Service 87beb7
		(c)->status = FAILED;					\
Packit Service 87beb7
		check_msg((c), dti, node, NULL, __VA_ARGS__);		\
Packit Service 87beb7
	} while (0)
Packit Service 87beb7
Packit Service 87beb7
#define FAIL_PROP(c, dti, node, prop, ...)				\
Packit Service 87beb7
	do {								\
Packit Service 87beb7
		TRACE((c), "\t\tFAILED at %s:%d", __FILE__, __LINE__);	\
Packit Service 87beb7
		(c)->status = FAILED;					\
Packit Service 87beb7
		check_msg((c), dti, node, prop, __VA_ARGS__);		\
Packit Service 87beb7
	} while (0)
Packit Service 87beb7
Packit Service 87beb7
Packit Service 87beb7
static void check_nodes_props(struct check *c, struct dt_info *dti, struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct node *child;
Packit Service 87beb7
Packit Service 87beb7
	TRACE(c, "%s", node->fullpath);
Packit Service 87beb7
	if (c->fn)
Packit Service 87beb7
		c->fn(c, dti, node);
Packit Service 87beb7
Packit Service 87beb7
	for_each_child(node, child)
Packit Service 87beb7
		check_nodes_props(c, dti, child);
Packit Service 87beb7
}
Packit Service 87beb7
Packit Service 87beb7
static bool run_check(struct check *c, struct dt_info *dti)
Packit Service 87beb7
{
Packit Service 87beb7
	struct node *dt = dti->dt;
Packit Service 87beb7
	bool error = false;
Packit Service 87beb7
	int i;
Packit Service 87beb7
Packit Service 87beb7
	assert(!c->inprogress);
Packit Service 87beb7
Packit Service 87beb7
	if (c->status != UNCHECKED)
Packit Service 87beb7
		goto out;
Packit Service 87beb7
Packit Service 87beb7
	c->inprogress = true;
Packit Service 87beb7
Packit Service 87beb7
	for (i = 0; i < c->num_prereqs; i++) {
Packit Service 87beb7
		struct check *prq = c->prereq[i];
Packit Service 87beb7
		error = error || run_check(prq, dti);
Packit Service 87beb7
		if (prq->status != PASSED) {
Packit Service 87beb7
			c->status = PREREQ;
Packit Service 87beb7
			check_msg(c, dti, NULL, NULL, "Failed prerequisite '%s'",
Packit Service 87beb7
				  c->prereq[i]->name);
Packit Service 87beb7
		}
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	if (c->status != UNCHECKED)
Packit Service 87beb7
		goto out;
Packit Service 87beb7
Packit Service 87beb7
	check_nodes_props(c, dti, dt);
Packit Service 87beb7
Packit Service 87beb7
	if (c->status == UNCHECKED)
Packit Service 87beb7
		c->status = PASSED;
Packit Service 87beb7
Packit Service 87beb7
	TRACE(c, "\tCompleted, status %d", c->status);
Packit Service 87beb7
Packit Service 87beb7
out:
Packit Service 87beb7
	c->inprogress = false;
Packit Service 87beb7
	if ((c->status != PASSED) && (c->error))
Packit Service 87beb7
		error = true;
Packit Service 87beb7
	return error;
Packit Service 87beb7
}
Packit Service 87beb7
Packit Service 87beb7
/*
Packit Service 87beb7
 * Utility check functions
Packit Service 87beb7
 */
Packit Service 87beb7
Packit Service 87beb7
/* A check which always fails, for testing purposes only */
Packit Service 87beb7
static inline void check_always_fail(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				     struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	FAIL(c, dti, node, "always_fail check");
Packit Service 87beb7
}
Packit Service 87beb7
CHECK(always_fail, check_always_fail, NULL);
Packit Service 87beb7
Packit Service 87beb7
static void check_is_string(struct check *c, struct dt_info *dti,
Packit Service 87beb7
			    struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
	char *propname = c->data;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, propname);
Packit Service 87beb7
	if (!prop)
Packit Service 87beb7
		return; /* Not present, assumed ok */
Packit Service 87beb7
Packit Service 87beb7
	if (!data_is_one_string(prop->val))
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "property is not a string");
Packit Service 87beb7
}
Packit Service 87beb7
#define WARNING_IF_NOT_STRING(nm, propname) \
Packit Service 87beb7
	WARNING(nm, check_is_string, (propname))
Packit Service 87beb7
#define ERROR_IF_NOT_STRING(nm, propname) \
Packit Service 87beb7
	ERROR(nm, check_is_string, (propname))
Packit Service 87beb7
Packit Service 87beb7
static void check_is_string_list(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				 struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	int rem, l;
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
	char *propname = c->data;
Packit Service 87beb7
	char *str;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, propname);
Packit Service 87beb7
	if (!prop)
Packit Service 87beb7
		return; /* Not present, assumed ok */
Packit Service 87beb7
Packit Service 87beb7
	str = prop->val.val;
Packit Service 87beb7
	rem = prop->val.len;
Packit Service 87beb7
	while (rem > 0) {
Packit Service 87beb7
		l = strnlen(str, rem);
Packit Service 87beb7
		if (l == rem) {
Packit Service 87beb7
			FAIL_PROP(c, dti, node, prop, "property is not a string list");
Packit Service 87beb7
			break;
Packit Service 87beb7
		}
Packit Service 87beb7
		rem -= l + 1;
Packit Service 87beb7
		str += l + 1;
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
#define WARNING_IF_NOT_STRING_LIST(nm, propname) \
Packit Service 87beb7
	WARNING(nm, check_is_string_list, (propname))
Packit Service 87beb7
#define ERROR_IF_NOT_STRING_LIST(nm, propname) \
Packit Service 87beb7
	ERROR(nm, check_is_string_list, (propname))
Packit Service 87beb7
Packit Service 87beb7
static void check_is_cell(struct check *c, struct dt_info *dti,
Packit Service 87beb7
			  struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
	char *propname = c->data;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, propname);
Packit Service 87beb7
	if (!prop)
Packit Service 87beb7
		return; /* Not present, assumed ok */
Packit Service 87beb7
Packit Service 87beb7
	if (prop->val.len != sizeof(cell_t))
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "property is not a single cell");
Packit Service 87beb7
}
Packit Service 87beb7
#define WARNING_IF_NOT_CELL(nm, propname) \
Packit Service 87beb7
	WARNING(nm, check_is_cell, (propname))
Packit Service 87beb7
#define ERROR_IF_NOT_CELL(nm, propname) \
Packit Service 87beb7
	ERROR(nm, check_is_cell, (propname))
Packit Service 87beb7
Packit Service 87beb7
/*
Packit Service 87beb7
 * Structural check functions
Packit Service 87beb7
 */
Packit Service 87beb7
Packit Service 87beb7
static void check_duplicate_node_names(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				       struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct node *child, *child2;
Packit Service 87beb7
Packit Service 87beb7
	for_each_child(node, child)
Packit Service 87beb7
		for (child2 = child->next_sibling;
Packit Service 87beb7
		     child2;
Packit Service 87beb7
		     child2 = child2->next_sibling)
Packit Service 87beb7
			if (streq(child->name, child2->name))
Packit Service 87beb7
				FAIL(c, dti, child2, "Duplicate node name");
Packit Service 87beb7
}
Packit Service 87beb7
ERROR(duplicate_node_names, check_duplicate_node_names, NULL);
Packit Service 87beb7
Packit Service 87beb7
static void check_duplicate_property_names(struct check *c, struct dt_info *dti,
Packit Service 87beb7
					   struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop, *prop2;
Packit Service 87beb7
Packit Service 87beb7
	for_each_property(node, prop) {
Packit Service 87beb7
		for (prop2 = prop->next; prop2; prop2 = prop2->next) {
Packit Service 87beb7
			if (prop2->deleted)
Packit Service 87beb7
				continue;
Packit Service 87beb7
			if (streq(prop->name, prop2->name))
Packit Service 87beb7
				FAIL_PROP(c, dti, node, prop, "Duplicate property name");
Packit Service 87beb7
		}
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
ERROR(duplicate_property_names, check_duplicate_property_names, NULL);
Packit Service 87beb7
Packit Service 87beb7
#define LOWERCASE	"abcdefghijklmnopqrstuvwxyz"
Packit Service 87beb7
#define UPPERCASE	"ABCDEFGHIJKLMNOPQRSTUVWXYZ"
Packit Service 87beb7
#define DIGITS		"0123456789"
Packit Service 87beb7
#define PROPNODECHARS	LOWERCASE UPPERCASE DIGITS ",._+*#?-"
Packit Service 87beb7
#define PROPNODECHARSSTRICT	LOWERCASE UPPERCASE DIGITS ",-"
Packit Service 87beb7
Packit Service 87beb7
static void check_node_name_chars(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				  struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	int n = strspn(node->name, c->data);
Packit Service 87beb7
Packit Service 87beb7
	if (n < strlen(node->name))
Packit Service 87beb7
		FAIL(c, dti, node, "Bad character '%c' in node name",
Packit Service 87beb7
		     node->name[n]);
Packit Service 87beb7
}
Packit Service 87beb7
ERROR(node_name_chars, check_node_name_chars, PROPNODECHARS "@");
Packit Service 87beb7
Packit Service 87beb7
static void check_node_name_chars_strict(struct check *c, struct dt_info *dti,
Packit Service 87beb7
					 struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	int n = strspn(node->name, c->data);
Packit Service 87beb7
Packit Service 87beb7
	if (n < node->basenamelen)
Packit Service 87beb7
		FAIL(c, dti, node, "Character '%c' not recommended in node name",
Packit Service 87beb7
		     node->name[n]);
Packit Service 87beb7
}
Packit Service 87beb7
CHECK(node_name_chars_strict, check_node_name_chars_strict, PROPNODECHARSSTRICT);
Packit Service 87beb7
Packit Service 87beb7
static void check_node_name_format(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				   struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	if (strchr(get_unitname(node), '@'))
Packit Service 87beb7
		FAIL(c, dti, node, "multiple '@' characters in node name");
Packit Service 87beb7
}
Packit Service 87beb7
ERROR(node_name_format, check_node_name_format, NULL, &node_name_chars);
Packit Service 87beb7
Packit Service 87beb7
static void check_unit_address_vs_reg(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				      struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	const char *unitname = get_unitname(node);
Packit Service 87beb7
	struct property *prop = get_property(node, "reg");
Packit Service 87beb7
Packit Service 87beb7
	if (get_subnode(node, "__overlay__")) {
Packit Service 87beb7
		/* HACK: Overlay fragments are a special case */
Packit Service 87beb7
		return;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	if (!prop) {
Packit Service 87beb7
		prop = get_property(node, "ranges");
Packit Service 87beb7
		if (prop && !prop->val.len)
Packit Service 87beb7
			prop = NULL;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	if (prop) {
Packit Service 87beb7
		if (!unitname[0])
Packit Service 87beb7
			FAIL(c, dti, node, "node has a reg or ranges property, but no unit name");
Packit Service 87beb7
	} else {
Packit Service 87beb7
		if (unitname[0])
Packit Service 87beb7
			FAIL(c, dti, node, "node has a unit name, but no reg property");
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(unit_address_vs_reg, check_unit_address_vs_reg, NULL);
Packit Service 87beb7
Packit Service 87beb7
static void check_property_name_chars(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				      struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	for_each_property(node, prop) {
Packit Service 87beb7
		int n = strspn(prop->name, c->data);
Packit Service 87beb7
Packit Service 87beb7
		if (n < strlen(prop->name))
Packit Service 87beb7
			FAIL_PROP(c, dti, node, prop, "Bad character '%c' in property name",
Packit Service 87beb7
				  prop->name[n]);
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
ERROR(property_name_chars, check_property_name_chars, PROPNODECHARS);
Packit Service 87beb7
Packit Service 87beb7
static void check_property_name_chars_strict(struct check *c,
Packit Service 87beb7
					     struct dt_info *dti,
Packit Service 87beb7
					     struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	for_each_property(node, prop) {
Packit Service 87beb7
		const char *name = prop->name;
Packit Service 87beb7
		int n = strspn(name, c->data);
Packit Service 87beb7
Packit Service 87beb7
		if (n == strlen(prop->name))
Packit Service 87beb7
			continue;
Packit Service 87beb7
Packit Service 87beb7
		/* Certain names are whitelisted */
Packit Service 87beb7
		if (streq(name, "device_type"))
Packit Service 87beb7
			continue;
Packit Service 87beb7
Packit Service 87beb7
		/*
Packit Service 87beb7
		 * # is only allowed at the beginning of property names not counting
Packit Service 87beb7
		 * the vendor prefix.
Packit Service 87beb7
		 */
Packit Service 87beb7
		if (name[n] == '#' && ((n == 0) || (name[n-1] == ','))) {
Packit Service 87beb7
			name += n + 1;
Packit Service 87beb7
			n = strspn(name, c->data);
Packit Service 87beb7
		}
Packit Service 87beb7
		if (n < strlen(name))
Packit Service 87beb7
			FAIL_PROP(c, dti, node, prop, "Character '%c' not recommended in property name",
Packit Service 87beb7
				  name[n]);
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
CHECK(property_name_chars_strict, check_property_name_chars_strict, PROPNODECHARSSTRICT);
Packit Service 87beb7
Packit Service 87beb7
#define DESCLABEL_FMT	"%s%s%s%s%s"
Packit Service 87beb7
#define DESCLABEL_ARGS(node,prop,mark)		\
Packit Service 87beb7
	((mark) ? "value of " : ""),		\
Packit Service 87beb7
	((prop) ? "'" : ""), \
Packit Service 87beb7
	((prop) ? (prop)->name : ""), \
Packit Service 87beb7
	((prop) ? "' in " : ""), (node)->fullpath
Packit Service 87beb7
Packit Service 87beb7
static void check_duplicate_label(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				  const char *label, struct node *node,
Packit Service 87beb7
				  struct property *prop, struct marker *mark)
Packit Service 87beb7
{
Packit Service 87beb7
	struct node *dt = dti->dt;
Packit Service 87beb7
	struct node *othernode = NULL;
Packit Service 87beb7
	struct property *otherprop = NULL;
Packit Service 87beb7
	struct marker *othermark = NULL;
Packit Service 87beb7
Packit Service 87beb7
	othernode = get_node_by_label(dt, label);
Packit Service 87beb7
Packit Service 87beb7
	if (!othernode)
Packit Service 87beb7
		otherprop = get_property_by_label(dt, label, &othernode);
Packit Service 87beb7
	if (!othernode)
Packit Service 87beb7
		othermark = get_marker_label(dt, label, &othernode,
Packit Service 87beb7
					       &otherprop);
Packit Service 87beb7
Packit Service 87beb7
	if (!othernode)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if ((othernode != node) || (otherprop != prop) || (othermark != mark))
Packit Service 87beb7
		FAIL(c, dti, node, "Duplicate label '%s' on " DESCLABEL_FMT
Packit Service 87beb7
		     " and " DESCLABEL_FMT,
Packit Service 87beb7
		     label, DESCLABEL_ARGS(node, prop, mark),
Packit Service 87beb7
		     DESCLABEL_ARGS(othernode, otherprop, othermark));
Packit Service 87beb7
}
Packit Service 87beb7
Packit Service 87beb7
static void check_duplicate_label_node(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				       struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct label *l;
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	for_each_label(node->labels, l)
Packit Service 87beb7
		check_duplicate_label(c, dti, l->label, node, NULL, NULL);
Packit Service 87beb7
Packit Service 87beb7
	for_each_property(node, prop) {
Packit Service 87beb7
		struct marker *m = prop->val.markers;
Packit Service 87beb7
Packit Service 87beb7
		for_each_label(prop->labels, l)
Packit Service 87beb7
			check_duplicate_label(c, dti, l->label, node, prop, NULL);
Packit Service 87beb7
Packit Service 87beb7
		for_each_marker_of_type(m, LABEL)
Packit Service 87beb7
			check_duplicate_label(c, dti, m->ref, node, prop, m);
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
ERROR(duplicate_label, check_duplicate_label_node, NULL);
Packit Service 87beb7
Packit Service 87beb7
static cell_t check_phandle_prop(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				 struct node *node, const char *propname)
Packit Service 87beb7
{
Packit Service 87beb7
	struct node *root = dti->dt;
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
	struct marker *m;
Packit Service 87beb7
	cell_t phandle;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, propname);
Packit Service 87beb7
	if (!prop)
Packit Service 87beb7
		return 0;
Packit Service 87beb7
Packit Service 87beb7
	if (prop->val.len != sizeof(cell_t)) {
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "bad length (%d) %s property",
Packit Service 87beb7
			  prop->val.len, prop->name);
Packit Service 87beb7
		return 0;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	m = prop->val.markers;
Packit Service 87beb7
	for_each_marker_of_type(m, REF_PHANDLE) {
Packit Service 87beb7
		assert(m->offset == 0);
Packit Service 87beb7
		if (node != get_node_by_ref(root, m->ref))
Packit Service 87beb7
			/* "Set this node's phandle equal to some
Packit Service 87beb7
			 * other node's phandle".  That's nonsensical
Packit Service 87beb7
			 * by construction. */ {
Packit Service 87beb7
			FAIL(c, dti, node, "%s is a reference to another node",
Packit Service 87beb7
			     prop->name);
Packit Service 87beb7
		}
Packit Service 87beb7
		/* But setting this node's phandle equal to its own
Packit Service 87beb7
		 * phandle is allowed - that means allocate a unique
Packit Service 87beb7
		 * phandle for this node, even if it's not otherwise
Packit Service 87beb7
		 * referenced.  The value will be filled in later, so
Packit Service 87beb7
		 * we treat it as having no phandle data for now. */
Packit Service 87beb7
		return 0;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	phandle = propval_cell(prop);
Packit Service 87beb7
Packit Service 87beb7
	if ((phandle == 0) || (phandle == -1)) {
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "bad value (0x%x) in %s property",
Packit Service 87beb7
		     phandle, prop->name);
Packit Service 87beb7
		return 0;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	return phandle;
Packit Service 87beb7
}
Packit Service 87beb7
Packit Service 87beb7
static void check_explicit_phandles(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				    struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct node *root = dti->dt;
Packit Service 87beb7
	struct node *other;
Packit Service 87beb7
	cell_t phandle, linux_phandle;
Packit Service 87beb7
Packit Service 87beb7
	/* Nothing should have assigned phandles yet */
Packit Service 87beb7
	assert(!node->phandle);
Packit Service 87beb7
Packit Service 87beb7
	phandle = check_phandle_prop(c, dti, node, "phandle");
Packit Service 87beb7
Packit Service 87beb7
	linux_phandle = check_phandle_prop(c, dti, node, "linux,phandle");
Packit Service 87beb7
Packit Service 87beb7
	if (!phandle && !linux_phandle)
Packit Service 87beb7
		/* No valid phandles; nothing further to check */
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (linux_phandle && phandle && (phandle != linux_phandle))
Packit Service 87beb7
		FAIL(c, dti, node, "mismatching 'phandle' and 'linux,phandle'"
Packit Service 87beb7
		     " properties");
Packit Service 87beb7
Packit Service 87beb7
	if (linux_phandle && !phandle)
Packit Service 87beb7
		phandle = linux_phandle;
Packit Service 87beb7
Packit Service 87beb7
	other = get_node_by_phandle(root, phandle);
Packit Service 87beb7
	if (other && (other != node)) {
Packit Service 87beb7
		FAIL(c, dti, node, "duplicated phandle 0x%x (seen before at %s)",
Packit Service 87beb7
		     phandle, other->fullpath);
Packit Service 87beb7
		return;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	node->phandle = phandle;
Packit Service 87beb7
}
Packit Service 87beb7
ERROR(explicit_phandles, check_explicit_phandles, NULL);
Packit Service 87beb7
Packit Service 87beb7
static void check_name_properties(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				  struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property **pp, *prop = NULL;
Packit Service 87beb7
Packit Service 87beb7
	for (pp = &node->proplist; *pp; pp = &((*pp)->next))
Packit Service 87beb7
		if (streq((*pp)->name, "name")) {
Packit Service 87beb7
			prop = *pp;
Packit Service 87beb7
			break;
Packit Service 87beb7
		}
Packit Service 87beb7
Packit Service 87beb7
	if (!prop)
Packit Service 87beb7
		return; /* No name property, that's fine */
Packit Service 87beb7
Packit Service 87beb7
	if ((prop->val.len != node->basenamelen+1)
Packit Service 87beb7
	    || (memcmp(prop->val.val, node->name, node->basenamelen) != 0)) {
Packit Service 87beb7
		FAIL(c, dti, node, "\"name\" property is incorrect (\"%s\" instead"
Packit Service 87beb7
		     " of base node name)", prop->val.val);
Packit Service 87beb7
	} else {
Packit Service 87beb7
		/* The name property is correct, and therefore redundant.
Packit Service 87beb7
		 * Delete it */
Packit Service 87beb7
		*pp = prop->next;
Packit Service 87beb7
		free(prop->name);
Packit Service 87beb7
		data_free(prop->val);
Packit Service 87beb7
		free(prop);
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
ERROR_IF_NOT_STRING(name_is_string, "name");
Packit Service 87beb7
ERROR(name_properties, check_name_properties, NULL, &name_is_string);
Packit Service 87beb7
Packit Service 87beb7
/*
Packit Service 87beb7
 * Reference fixup functions
Packit Service 87beb7
 */
Packit Service 87beb7
Packit Service 87beb7
static void fixup_phandle_references(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				     struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct node *dt = dti->dt;
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	for_each_property(node, prop) {
Packit Service 87beb7
		struct marker *m = prop->val.markers;
Packit Service 87beb7
		struct node *refnode;
Packit Service 87beb7
		cell_t phandle;
Packit Service 87beb7
Packit Service 87beb7
		for_each_marker_of_type(m, REF_PHANDLE) {
Packit Service 87beb7
			assert(m->offset + sizeof(cell_t) <= prop->val.len);
Packit Service 87beb7
Packit Service 87beb7
			refnode = get_node_by_ref(dt, m->ref);
Packit Service 87beb7
			if (! refnode) {
Packit Service 87beb7
				if (!(dti->dtsflags & DTSF_PLUGIN))
Packit Service 87beb7
					FAIL(c, dti, node, "Reference to non-existent node or "
Packit Service 87beb7
							"label \"%s\"\n", m->ref);
Packit Service 87beb7
				else /* mark the entry as unresolved */
Packit Service 87beb7
					*((fdt32_t *)(prop->val.val + m->offset)) =
Packit Service 87beb7
						cpu_to_fdt32(0xffffffff);
Packit Service 87beb7
				continue;
Packit Service 87beb7
			}
Packit Service 87beb7
Packit Service 87beb7
			phandle = get_node_phandle(dt, refnode);
Packit Service 87beb7
			*((fdt32_t *)(prop->val.val + m->offset)) = cpu_to_fdt32(phandle);
Packit Service 87beb7
Packit Service 87beb7
			reference_node(refnode);
Packit Service 87beb7
		}
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
ERROR(phandle_references, fixup_phandle_references, NULL,
Packit Service 87beb7
      &duplicate_node_names, &explicit_phandles);
Packit Service 87beb7
Packit Service 87beb7
static void fixup_path_references(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				  struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct node *dt = dti->dt;
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	for_each_property(node, prop) {
Packit Service 87beb7
		struct marker *m = prop->val.markers;
Packit Service 87beb7
		struct node *refnode;
Packit Service 87beb7
		char *path;
Packit Service 87beb7
Packit Service 87beb7
		for_each_marker_of_type(m, REF_PATH) {
Packit Service 87beb7
			assert(m->offset <= prop->val.len);
Packit Service 87beb7
Packit Service 87beb7
			refnode = get_node_by_ref(dt, m->ref);
Packit Service 87beb7
			if (!refnode) {
Packit Service 87beb7
				FAIL(c, dti, node, "Reference to non-existent node or label \"%s\"\n",
Packit Service 87beb7
				     m->ref);
Packit Service 87beb7
				continue;
Packit Service 87beb7
			}
Packit Service 87beb7
Packit Service 87beb7
			path = refnode->fullpath;
Packit Service 87beb7
			prop->val = data_insert_at_marker(prop->val, m, path,
Packit Service 87beb7
							  strlen(path) + 1);
Packit Service 87beb7
Packit Service 87beb7
			reference_node(refnode);
Packit Service 87beb7
		}
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
ERROR(path_references, fixup_path_references, NULL, &duplicate_node_names);
Packit Service 87beb7
Packit Service 87beb7
static void fixup_omit_unused_nodes(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				    struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	if (generate_symbols && node->labels)
Packit Service 87beb7
		return;
Packit Service 87beb7
	if (node->omit_if_unused && !node->is_referenced)
Packit Service 87beb7
		delete_node(node);
Packit Service 87beb7
}
Packit Service 87beb7
ERROR(omit_unused_nodes, fixup_omit_unused_nodes, NULL, &phandle_references, &path_references);
Packit Service 87beb7
Packit Service 87beb7
/*
Packit Service 87beb7
 * Semantic checks
Packit Service 87beb7
 */
Packit Service 87beb7
WARNING_IF_NOT_CELL(address_cells_is_cell, "#address-cells");
Packit Service 87beb7
WARNING_IF_NOT_CELL(size_cells_is_cell, "#size-cells");
Packit Service 87beb7
WARNING_IF_NOT_CELL(interrupt_cells_is_cell, "#interrupt-cells");
Packit Service 87beb7
Packit Service 87beb7
WARNING_IF_NOT_STRING(device_type_is_string, "device_type");
Packit Service 87beb7
WARNING_IF_NOT_STRING(model_is_string, "model");
Packit Service 87beb7
WARNING_IF_NOT_STRING(status_is_string, "status");
Packit Service 87beb7
WARNING_IF_NOT_STRING(label_is_string, "label");
Packit Service 87beb7
Packit Service 87beb7
WARNING_IF_NOT_STRING_LIST(compatible_is_string_list, "compatible");
Packit Service 87beb7
Packit Service 87beb7
static void check_names_is_string_list(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				       struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	for_each_property(node, prop) {
Packit Service 87beb7
		const char *s = strrchr(prop->name, '-');
Packit Service 87beb7
		if (!s || !streq(s, "-names"))
Packit Service 87beb7
			continue;
Packit Service 87beb7
Packit Service 87beb7
		c->data = prop->name;
Packit Service 87beb7
		check_is_string_list(c, dti, node);
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(names_is_string_list, check_names_is_string_list, NULL);
Packit Service 87beb7
Packit Service 87beb7
static void check_alias_paths(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				    struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	if (!streq(node->name, "aliases"))
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	for_each_property(node, prop) {
Packit Service 87beb7
		if (streq(prop->name, "phandle")
Packit Service 87beb7
		    || streq(prop->name, "linux,phandle")) {
Packit Service 87beb7
			continue;
Packit Service 87beb7
		}
Packit Service 87beb7
Packit Service 87beb7
		if (!prop->val.val || !get_node_by_path(dti->dt, prop->val.val)) {
Packit Service 87beb7
			FAIL_PROP(c, dti, node, prop, "aliases property is not a valid node (%s)",
Packit Service 87beb7
				  prop->val.val);
Packit Service 87beb7
			continue;
Packit Service 87beb7
		}
Packit Service 87beb7
		if (strspn(prop->name, LOWERCASE DIGITS "-") != strlen(prop->name))
Packit Service 87beb7
			FAIL(c, dti, node, "aliases property name must include only lowercase and '-'");
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(alias_paths, check_alias_paths, NULL);
Packit Service 87beb7
Packit Service 87beb7
static void fixup_addr_size_cells(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				  struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	node->addr_cells = -1;
Packit Service 87beb7
	node->size_cells = -1;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "#address-cells");
Packit Service 87beb7
	if (prop)
Packit Service 87beb7
		node->addr_cells = propval_cell(prop);
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "#size-cells");
Packit Service 87beb7
	if (prop)
Packit Service 87beb7
		node->size_cells = propval_cell(prop);
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(addr_size_cells, fixup_addr_size_cells, NULL,
Packit Service 87beb7
	&address_cells_is_cell, &size_cells_is_cell);
Packit Service 87beb7
Packit Service 87beb7
#define node_addr_cells(n) \
Packit Service 87beb7
	(((n)->addr_cells == -1) ? 2 : (n)->addr_cells)
Packit Service 87beb7
#define node_size_cells(n) \
Packit Service 87beb7
	(((n)->size_cells == -1) ? 1 : (n)->size_cells)
Packit Service 87beb7
Packit Service 87beb7
static void check_reg_format(struct check *c, struct dt_info *dti,
Packit Service 87beb7
			     struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
	int addr_cells, size_cells, entrylen;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "reg");
Packit Service 87beb7
	if (!prop)
Packit Service 87beb7
		return; /* No "reg", that's fine */
Packit Service 87beb7
Packit Service 87beb7
	if (!node->parent) {
Packit Service 87beb7
		FAIL(c, dti, node, "Root node has a \"reg\" property");
Packit Service 87beb7
		return;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	if (prop->val.len == 0)
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "property is empty");
Packit Service 87beb7
Packit Service 87beb7
	addr_cells = node_addr_cells(node->parent);
Packit Service 87beb7
	size_cells = node_size_cells(node->parent);
Packit Service 87beb7
	entrylen = (addr_cells + size_cells) * sizeof(cell_t);
Packit Service 87beb7
Packit Service 87beb7
	if (!entrylen || (prop->val.len % entrylen) != 0)
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "property has invalid length (%d bytes) "
Packit Service 87beb7
			  "(#address-cells == %d, #size-cells == %d)",
Packit Service 87beb7
			  prop->val.len, addr_cells, size_cells);
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(reg_format, check_reg_format, NULL, &addr_size_cells);
Packit Service 87beb7
Packit Service 87beb7
static void check_ranges_format(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
	int c_addr_cells, p_addr_cells, c_size_cells, p_size_cells, entrylen;
Packit Service 87beb7
	const char *ranges = c->data;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, ranges);
Packit Service 87beb7
	if (!prop)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (!node->parent) {
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "Root node has a \"%s\" property",
Packit Service 87beb7
			  ranges);
Packit Service 87beb7
		return;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	p_addr_cells = node_addr_cells(node->parent);
Packit Service 87beb7
	p_size_cells = node_size_cells(node->parent);
Packit Service 87beb7
	c_addr_cells = node_addr_cells(node);
Packit Service 87beb7
	c_size_cells = node_size_cells(node);
Packit Service 87beb7
	entrylen = (p_addr_cells + c_addr_cells + c_size_cells) * sizeof(cell_t);
Packit Service 87beb7
Packit Service 87beb7
	if (prop->val.len == 0) {
Packit Service 87beb7
		if (p_addr_cells != c_addr_cells)
Packit Service 87beb7
			FAIL_PROP(c, dti, node, prop, "empty \"%s\" property but its "
Packit Service 87beb7
				  "#address-cells (%d) differs from %s (%d)",
Packit Service 87beb7
				  ranges, c_addr_cells, node->parent->fullpath,
Packit Service 87beb7
				  p_addr_cells);
Packit Service 87beb7
		if (p_size_cells != c_size_cells)
Packit Service 87beb7
			FAIL_PROP(c, dti, node, prop, "empty \"%s\" property but its "
Packit Service 87beb7
				  "#size-cells (%d) differs from %s (%d)",
Packit Service 87beb7
				  ranges, c_size_cells, node->parent->fullpath,
Packit Service 87beb7
				  p_size_cells);
Packit Service 87beb7
	} else if ((prop->val.len % entrylen) != 0) {
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "\"%s\" property has invalid length (%d bytes) "
Packit Service 87beb7
			  "(parent #address-cells == %d, child #address-cells == %d, "
Packit Service 87beb7
			  "#size-cells == %d)", ranges, prop->val.len,
Packit Service 87beb7
			  p_addr_cells, c_addr_cells, c_size_cells);
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(ranges_format, check_ranges_format, "ranges", &addr_size_cells);
Packit Service 87beb7
WARNING(dma_ranges_format, check_ranges_format, "dma-ranges", &addr_size_cells);
Packit Service 87beb7
Packit Service 87beb7
static const struct bus_type pci_bus = {
Packit Service 87beb7
	.name = "PCI",
Packit Service 87beb7
};
Packit Service 87beb7
Packit Service 87beb7
static void check_pci_bridge(struct check *c, struct dt_info *dti, struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
	cell_t *cells;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "device_type");
Packit Service 87beb7
	if (!prop || !streq(prop->val.val, "pci"))
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	node->bus = &pci_bus;
Packit Service 87beb7
Packit Service 87beb7
	if (!strprefixeq(node->name, node->basenamelen, "pci") &&
Packit Service 87beb7
	    !strprefixeq(node->name, node->basenamelen, "pcie"))
Packit Service 87beb7
		FAIL(c, dti, node, "node name is not \"pci\" or \"pcie\"");
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "ranges");
Packit Service 87beb7
	if (!prop)
Packit Service 87beb7
		FAIL(c, dti, node, "missing ranges for PCI bridge (or not a bridge)");
Packit Service 87beb7
Packit Service 87beb7
	if (node_addr_cells(node) != 3)
Packit Service 87beb7
		FAIL(c, dti, node, "incorrect #address-cells for PCI bridge");
Packit Service 87beb7
	if (node_size_cells(node) != 2)
Packit Service 87beb7
		FAIL(c, dti, node, "incorrect #size-cells for PCI bridge");
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "bus-range");
Packit Service 87beb7
	if (!prop)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (prop->val.len != (sizeof(cell_t) * 2)) {
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "value must be 2 cells");
Packit Service 87beb7
		return;
Packit Service 87beb7
	}
Packit Service 87beb7
	cells = (cell_t *)prop->val.val;
Packit Service 87beb7
	if (fdt32_to_cpu(cells[0]) > fdt32_to_cpu(cells[1]))
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "1st cell must be less than or equal to 2nd cell");
Packit Service 87beb7
	if (fdt32_to_cpu(cells[1]) > 0xff)
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "maximum bus number must be less than 256");
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(pci_bridge, check_pci_bridge, NULL,
Packit Service 87beb7
	&device_type_is_string, &addr_size_cells);
Packit Service 87beb7
Packit Service 87beb7
static void check_pci_device_bus_num(struct check *c, struct dt_info *dti, struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
	unsigned int bus_num, min_bus, max_bus;
Packit Service 87beb7
	cell_t *cells;
Packit Service 87beb7
Packit Service 87beb7
	if (!node->parent || (node->parent->bus != &pci_bus))
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "reg");
Packit Service 87beb7
	if (!prop)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	cells = (cell_t *)prop->val.val;
Packit Service 87beb7
	bus_num = (fdt32_to_cpu(cells[0]) & 0x00ff0000) >> 16;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node->parent, "bus-range");
Packit Service 87beb7
	if (!prop) {
Packit Service 87beb7
		min_bus = max_bus = 0;
Packit Service 87beb7
	} else {
Packit Service 87beb7
		cells = (cell_t *)prop->val.val;
Packit Service 87beb7
		min_bus = fdt32_to_cpu(cells[0]);
Packit Service 87beb7
		max_bus = fdt32_to_cpu(cells[0]);
Packit Service 87beb7
	}
Packit Service 87beb7
	if ((bus_num < min_bus) || (bus_num > max_bus))
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "PCI bus number %d out of range, expected (%d - %d)",
Packit Service 87beb7
			  bus_num, min_bus, max_bus);
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(pci_device_bus_num, check_pci_device_bus_num, NULL, &reg_format, &pci_bridge);
Packit Service 87beb7
Packit Service 87beb7
static void check_pci_device_reg(struct check *c, struct dt_info *dti, struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
	const char *unitname = get_unitname(node);
Packit Service 87beb7
	char unit_addr[5];
Packit Service 87beb7
	unsigned int dev, func, reg;
Packit Service 87beb7
	cell_t *cells;
Packit Service 87beb7
Packit Service 87beb7
	if (!node->parent || (node->parent->bus != &pci_bus))
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "reg");
Packit Service 87beb7
	if (!prop) {
Packit Service 87beb7
		FAIL(c, dti, node, "missing PCI reg property");
Packit Service 87beb7
		return;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	cells = (cell_t *)prop->val.val;
Packit Service 87beb7
	if (cells[1] || cells[2])
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "PCI reg config space address cells 2 and 3 must be 0");
Packit Service 87beb7
Packit Service 87beb7
	reg = fdt32_to_cpu(cells[0]);
Packit Service 87beb7
	dev = (reg & 0xf800) >> 11;
Packit Service 87beb7
	func = (reg & 0x700) >> 8;
Packit Service 87beb7
Packit Service 87beb7
	if (reg & 0xff000000)
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "PCI reg address is not configuration space");
Packit Service 87beb7
	if (reg & 0x000000ff)
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "PCI reg config space address register number must be 0");
Packit Service 87beb7
Packit Service 87beb7
	if (func == 0) {
Packit Service 87beb7
		snprintf(unit_addr, sizeof(unit_addr), "%x", dev);
Packit Service 87beb7
		if (streq(unitname, unit_addr))
Packit Service 87beb7
			return;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	snprintf(unit_addr, sizeof(unit_addr), "%x,%x", dev, func);
Packit Service 87beb7
	if (streq(unitname, unit_addr))
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	FAIL(c, dti, node, "PCI unit address format error, expected \"%s\"",
Packit Service 87beb7
	     unit_addr);
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(pci_device_reg, check_pci_device_reg, NULL, &reg_format, &pci_bridge);
Packit Service 87beb7
Packit Service 87beb7
static const struct bus_type simple_bus = {
Packit Service 87beb7
	.name = "simple-bus",
Packit Service 87beb7
};
Packit Service 87beb7
Packit Service 87beb7
static bool node_is_compatible(struct node *node, const char *compat)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
	const char *str, *end;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "compatible");
Packit Service 87beb7
	if (!prop)
Packit Service 87beb7
		return false;
Packit Service 87beb7
Packit Service 87beb7
	for (str = prop->val.val, end = str + prop->val.len; str < end;
Packit Service 87beb7
	     str += strnlen(str, end - str) + 1) {
Packit Service 87beb7
		if (streq(str, compat))
Packit Service 87beb7
			return true;
Packit Service 87beb7
	}
Packit Service 87beb7
	return false;
Packit Service 87beb7
}
Packit Service 87beb7
Packit Service 87beb7
static void check_simple_bus_bridge(struct check *c, struct dt_info *dti, struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	if (node_is_compatible(node, "simple-bus"))
Packit Service 87beb7
		node->bus = &simple_bus;
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(simple_bus_bridge, check_simple_bus_bridge, NULL,
Packit Service 87beb7
	&addr_size_cells, &compatible_is_string_list);
Packit Service 87beb7
Packit Service 87beb7
static void check_simple_bus_reg(struct check *c, struct dt_info *dti, struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
	const char *unitname = get_unitname(node);
Packit Service 87beb7
	char unit_addr[17];
Packit Service 87beb7
	unsigned int size;
Packit Service 87beb7
	uint64_t reg = 0;
Packit Service 87beb7
	cell_t *cells = NULL;
Packit Service 87beb7
Packit Service 87beb7
	if (!node->parent || (node->parent->bus != &simple_bus))
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "reg");
Packit Service 87beb7
	if (prop)
Packit Service 87beb7
		cells = (cell_t *)prop->val.val;
Packit Service 87beb7
	else {
Packit Service 87beb7
		prop = get_property(node, "ranges");
Packit Service 87beb7
		if (prop && prop->val.len)
Packit Service 87beb7
			/* skip of child address */
Packit Service 87beb7
			cells = ((cell_t *)prop->val.val) + node_addr_cells(node);
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	if (!cells) {
Packit Service 87beb7
		if (node->parent->parent && !(node->bus == &simple_bus))
Packit Service 87beb7
			FAIL(c, dti, node, "missing or empty reg/ranges property");
Packit Service 87beb7
		return;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	size = node_addr_cells(node->parent);
Packit Service 87beb7
	while (size--)
Packit Service 87beb7
		reg = (reg << 32) | fdt32_to_cpu(*(cells++));
Packit Service 87beb7
Packit Service 87beb7
	snprintf(unit_addr, sizeof(unit_addr), "%"PRIx64, reg);
Packit Service 87beb7
	if (!streq(unitname, unit_addr))
Packit Service 87beb7
		FAIL(c, dti, node, "simple-bus unit address format error, expected \"%s\"",
Packit Service 87beb7
		     unit_addr);
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(simple_bus_reg, check_simple_bus_reg, NULL, &reg_format, &simple_bus_bridge);
Packit Service 87beb7
Packit Service 87beb7
static const struct bus_type i2c_bus = {
Packit Service 87beb7
	.name = "i2c-bus",
Packit Service 87beb7
};
Packit Service 87beb7
Packit Service 87beb7
static void check_i2c_bus_bridge(struct check *c, struct dt_info *dti, struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	if (strprefixeq(node->name, node->basenamelen, "i2c-bus") ||
Packit Service 87beb7
	    strprefixeq(node->name, node->basenamelen, "i2c-arb")) {
Packit Service 87beb7
		node->bus = &i2c_bus;
Packit Service 87beb7
	} else if (strprefixeq(node->name, node->basenamelen, "i2c")) {
Packit Service 87beb7
		struct node *child;
Packit Service 87beb7
		for_each_child(node, child) {
Packit Service 87beb7
			if (strprefixeq(child->name, node->basenamelen, "i2c-bus"))
Packit Service 87beb7
				return;
Packit Service 87beb7
		}
Packit Service 87beb7
		node->bus = &i2c_bus;
Packit Service 87beb7
	} else
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (!node->children)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (node_addr_cells(node) != 1)
Packit Service 87beb7
		FAIL(c, dti, node, "incorrect #address-cells for I2C bus");
Packit Service 87beb7
	if (node_size_cells(node) != 0)
Packit Service 87beb7
		FAIL(c, dti, node, "incorrect #size-cells for I2C bus");
Packit Service 87beb7
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(i2c_bus_bridge, check_i2c_bus_bridge, NULL, &addr_size_cells);
Packit Service 87beb7
Packit Service 87beb7
static void check_i2c_bus_reg(struct check *c, struct dt_info *dti, struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
	const char *unitname = get_unitname(node);
Packit Service 87beb7
	char unit_addr[17];
Packit Service 87beb7
	uint32_t reg = 0;
Packit Service 87beb7
	int len;
Packit Service 87beb7
	cell_t *cells = NULL;
Packit Service 87beb7
Packit Service 87beb7
	if (!node->parent || (node->parent->bus != &i2c_bus))
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "reg");
Packit Service 87beb7
	if (prop)
Packit Service 87beb7
		cells = (cell_t *)prop->val.val;
Packit Service 87beb7
Packit Service 87beb7
	if (!cells) {
Packit Service 87beb7
		FAIL(c, dti, node, "missing or empty reg property");
Packit Service 87beb7
		return;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	reg = fdt32_to_cpu(*cells);
Packit Service 87beb7
	snprintf(unit_addr, sizeof(unit_addr), "%x", reg);
Packit Service 87beb7
	if (!streq(unitname, unit_addr))
Packit Service 87beb7
		FAIL(c, dti, node, "I2C bus unit address format error, expected \"%s\"",
Packit Service 87beb7
		     unit_addr);
Packit Service 87beb7
Packit Service 87beb7
	for (len = prop->val.len; len > 0; len -= 4) {
Packit Service 87beb7
		reg = fdt32_to_cpu(*(cells++));
Packit Service 87beb7
		if (reg > 0x3ff)
Packit Service 87beb7
			FAIL_PROP(c, dti, node, prop, "I2C address must be less than 10-bits, got \"0x%x\"",
Packit Service 87beb7
				  reg);
Packit Service 87beb7
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(i2c_bus_reg, check_i2c_bus_reg, NULL, &reg_format, &i2c_bus_bridge);
Packit Service 87beb7
Packit Service 87beb7
static const struct bus_type spi_bus = {
Packit Service 87beb7
	.name = "spi-bus",
Packit Service 87beb7
};
Packit Service 87beb7
Packit Service 87beb7
static void check_spi_bus_bridge(struct check *c, struct dt_info *dti, struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	int spi_addr_cells = 1;
Packit Service 87beb7
Packit Service 87beb7
	if (strprefixeq(node->name, node->basenamelen, "spi")) {
Packit Service 87beb7
		node->bus = &spi_bus;
Packit Service 87beb7
	} else {
Packit Service 87beb7
		/* Try to detect SPI buses which don't have proper node name */
Packit Service 87beb7
		struct node *child;
Packit Service 87beb7
Packit Service 87beb7
		if (node_addr_cells(node) != 1 || node_size_cells(node) != 0)
Packit Service 87beb7
			return;
Packit Service 87beb7
Packit Service 87beb7
		for_each_child(node, child) {
Packit Service 87beb7
			struct property *prop;
Packit Service 87beb7
			for_each_property(child, prop) {
Packit Service 87beb7
				if (strprefixeq(prop->name, 4, "spi-")) {
Packit Service 87beb7
					node->bus = &spi_bus;
Packit Service 87beb7
					break;
Packit Service 87beb7
				}
Packit Service 87beb7
			}
Packit Service 87beb7
			if (node->bus == &spi_bus)
Packit Service 87beb7
				break;
Packit Service 87beb7
		}
Packit Service 87beb7
Packit Service 87beb7
		if (node->bus == &spi_bus && get_property(node, "reg"))
Packit Service 87beb7
			FAIL(c, dti, node, "node name for SPI buses should be 'spi'");
Packit Service 87beb7
	}
Packit Service 87beb7
	if (node->bus != &spi_bus || !node->children)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (get_property(node, "spi-slave"))
Packit Service 87beb7
		spi_addr_cells = 0;
Packit Service 87beb7
	if (node_addr_cells(node) != spi_addr_cells)
Packit Service 87beb7
		FAIL(c, dti, node, "incorrect #address-cells for SPI bus");
Packit Service 87beb7
	if (node_size_cells(node) != 0)
Packit Service 87beb7
		FAIL(c, dti, node, "incorrect #size-cells for SPI bus");
Packit Service 87beb7
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(spi_bus_bridge, check_spi_bus_bridge, NULL, &addr_size_cells);
Packit Service 87beb7
Packit Service 87beb7
static void check_spi_bus_reg(struct check *c, struct dt_info *dti, struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
	const char *unitname = get_unitname(node);
Packit Service 87beb7
	char unit_addr[9];
Packit Service 87beb7
	uint32_t reg = 0;
Packit Service 87beb7
	cell_t *cells = NULL;
Packit Service 87beb7
Packit Service 87beb7
	if (!node->parent || (node->parent->bus != &spi_bus))
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (get_property(node->parent, "spi-slave"))
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "reg");
Packit Service 87beb7
	if (prop)
Packit Service 87beb7
		cells = (cell_t *)prop->val.val;
Packit Service 87beb7
Packit Service 87beb7
	if (!cells) {
Packit Service 87beb7
		FAIL(c, dti, node, "missing or empty reg property");
Packit Service 87beb7
		return;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	reg = fdt32_to_cpu(*cells);
Packit Service 87beb7
	snprintf(unit_addr, sizeof(unit_addr), "%x", reg);
Packit Service 87beb7
	if (!streq(unitname, unit_addr))
Packit Service 87beb7
		FAIL(c, dti, node, "SPI bus unit address format error, expected \"%s\"",
Packit Service 87beb7
		     unit_addr);
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(spi_bus_reg, check_spi_bus_reg, NULL, &reg_format, &spi_bus_bridge);
Packit Service 87beb7
Packit Service 87beb7
static void check_unit_address_format(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				      struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	const char *unitname = get_unitname(node);
Packit Service 87beb7
Packit Service 87beb7
	if (node->parent && node->parent->bus)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (!unitname[0])
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (!strncmp(unitname, "0x", 2)) {
Packit Service 87beb7
		FAIL(c, dti, node, "unit name should not have leading \"0x\"");
Packit Service 87beb7
		/* skip over 0x for next test */
Packit Service 87beb7
		unitname += 2;
Packit Service 87beb7
	}
Packit Service 87beb7
	if (unitname[0] == '0' && isxdigit(unitname[1]))
Packit Service 87beb7
		FAIL(c, dti, node, "unit name should not have leading 0s");
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(unit_address_format, check_unit_address_format, NULL,
Packit Service 87beb7
	&node_name_format, &pci_bridge, &simple_bus_bridge);
Packit Service 87beb7
Packit Service 87beb7
/*
Packit Service 87beb7
 * Style checks
Packit Service 87beb7
 */
Packit Service 87beb7
static void check_avoid_default_addr_size(struct check *c, struct dt_info *dti,
Packit Service 87beb7
					  struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *reg, *ranges;
Packit Service 87beb7
Packit Service 87beb7
	if (!node->parent)
Packit Service 87beb7
		return; /* Ignore root node */
Packit Service 87beb7
Packit Service 87beb7
	reg = get_property(node, "reg");
Packit Service 87beb7
	ranges = get_property(node, "ranges");
Packit Service 87beb7
Packit Service 87beb7
	if (!reg && !ranges)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (node->parent->addr_cells == -1)
Packit Service 87beb7
		FAIL(c, dti, node, "Relying on default #address-cells value");
Packit Service 87beb7
Packit Service 87beb7
	if (node->parent->size_cells == -1)
Packit Service 87beb7
		FAIL(c, dti, node, "Relying on default #size-cells value");
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(avoid_default_addr_size, check_avoid_default_addr_size, NULL,
Packit Service 87beb7
	&addr_size_cells);
Packit Service 87beb7
Packit Service 87beb7
static void check_avoid_unnecessary_addr_size(struct check *c, struct dt_info *dti,
Packit Service 87beb7
					      struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
	struct node *child;
Packit Service 87beb7
	bool has_reg = false;
Packit Service 87beb7
Packit Service 87beb7
	if (!node->parent || node->addr_cells < 0 || node->size_cells < 0)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (get_property(node, "ranges") || !node->children)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	for_each_child(node, child) {
Packit Service 87beb7
		prop = get_property(child, "reg");
Packit Service 87beb7
		if (prop)
Packit Service 87beb7
			has_reg = true;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	if (!has_reg)
Packit Service 87beb7
		FAIL(c, dti, node, "unnecessary #address-cells/#size-cells without \"ranges\" or child \"reg\" property");
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(avoid_unnecessary_addr_size, check_avoid_unnecessary_addr_size, NULL, &avoid_default_addr_size);
Packit Service 87beb7
Packit Service 87beb7
static bool node_is_disabled(struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "status");
Packit Service 87beb7
	if (prop) {
Packit Service 87beb7
		char *str = prop->val.val;
Packit Service 87beb7
		if (streq("disabled", str))
Packit Service 87beb7
			return true;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	return false;
Packit Service 87beb7
}
Packit Service 87beb7
Packit Service 87beb7
static void check_unique_unit_address_common(struct check *c,
Packit Service 87beb7
						struct dt_info *dti,
Packit Service 87beb7
						struct node *node,
Packit Service 87beb7
						bool disable_check)
Packit Service 87beb7
{
Packit Service 87beb7
	struct node *childa;
Packit Service 87beb7
Packit Service 87beb7
	if (node->addr_cells < 0 || node->size_cells < 0)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (!node->children)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	for_each_child(node, childa) {
Packit Service 87beb7
		struct node *childb;
Packit Service 87beb7
		const char *addr_a = get_unitname(childa);
Packit Service 87beb7
Packit Service 87beb7
		if (!strlen(addr_a))
Packit Service 87beb7
			continue;
Packit Service 87beb7
Packit Service 87beb7
		if (disable_check && node_is_disabled(childa))
Packit Service 87beb7
			continue;
Packit Service 87beb7
Packit Service 87beb7
		for_each_child(node, childb) {
Packit Service 87beb7
			const char *addr_b = get_unitname(childb);
Packit Service 87beb7
			if (childa == childb)
Packit Service 87beb7
				break;
Packit Service 87beb7
Packit Service 87beb7
			if (disable_check && node_is_disabled(childb))
Packit Service 87beb7
				continue;
Packit Service 87beb7
Packit Service 87beb7
			if (streq(addr_a, addr_b))
Packit Service 87beb7
				FAIL(c, dti, childb, "duplicate unit-address (also used in node %s)", childa->fullpath);
Packit Service 87beb7
		}
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
Packit Service 87beb7
static void check_unique_unit_address(struct check *c, struct dt_info *dti,
Packit Service 87beb7
					      struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	check_unique_unit_address_common(c, dti, node, false);
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(unique_unit_address, check_unique_unit_address, NULL, &avoid_default_addr_size);
Packit Service 87beb7
Packit Service 87beb7
static void check_unique_unit_address_if_enabled(struct check *c, struct dt_info *dti,
Packit Service 87beb7
					      struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	check_unique_unit_address_common(c, dti, node, true);
Packit Service 87beb7
}
Packit Service 87beb7
CHECK_ENTRY(unique_unit_address_if_enabled, check_unique_unit_address_if_enabled,
Packit Service 87beb7
	    NULL, false, false, &avoid_default_addr_size);
Packit Service 87beb7
Packit Service 87beb7
static void check_obsolete_chosen_interrupt_controller(struct check *c,
Packit Service 87beb7
						       struct dt_info *dti,
Packit Service 87beb7
						       struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct node *dt = dti->dt;
Packit Service 87beb7
	struct node *chosen;
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	if (node != dt)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
Packit Service 87beb7
	chosen = get_node_by_path(dt, "/chosen");
Packit Service 87beb7
	if (!chosen)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(chosen, "interrupt-controller");
Packit Service 87beb7
	if (prop)
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop,
Packit Service 87beb7
			  "/chosen has obsolete \"interrupt-controller\" property");
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(obsolete_chosen_interrupt_controller,
Packit Service 87beb7
	check_obsolete_chosen_interrupt_controller, NULL);
Packit Service 87beb7
Packit Service 87beb7
static void check_chosen_node_is_root(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				      struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	if (!streq(node->name, "chosen"))
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (node->parent != dti->dt)
Packit Service 87beb7
		FAIL(c, dti, node, "chosen node must be at root node");
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(chosen_node_is_root, check_chosen_node_is_root, NULL);
Packit Service 87beb7
Packit Service 87beb7
static void check_chosen_node_bootargs(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				       struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	if (!streq(node->name, "chosen"))
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "bootargs");
Packit Service 87beb7
	if (!prop)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	c->data = prop->name;
Packit Service 87beb7
	check_is_string(c, dti, node);
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(chosen_node_bootargs, check_chosen_node_bootargs, NULL);
Packit Service 87beb7
Packit Service 87beb7
static void check_chosen_node_stdout_path(struct check *c, struct dt_info *dti,
Packit Service 87beb7
					  struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	if (!streq(node->name, "chosen"))
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "stdout-path");
Packit Service 87beb7
	if (!prop) {
Packit Service 87beb7
		prop = get_property(node, "linux,stdout-path");
Packit Service 87beb7
		if (!prop)
Packit Service 87beb7
			return;
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop, "Use 'stdout-path' instead");
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	c->data = prop->name;
Packit Service 87beb7
	check_is_string(c, dti, node);
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(chosen_node_stdout_path, check_chosen_node_stdout_path, NULL);
Packit Service 87beb7
Packit Service 87beb7
struct provider {
Packit Service 87beb7
	const char *prop_name;
Packit Service 87beb7
	const char *cell_name;
Packit Service 87beb7
	bool optional;
Packit Service 87beb7
};
Packit Service 87beb7
Packit Service 87beb7
static void check_property_phandle_args(struct check *c,
Packit Service 87beb7
					  struct dt_info *dti,
Packit Service 87beb7
				          struct node *node,
Packit Service 87beb7
				          struct property *prop,
Packit Service 87beb7
				          const struct provider *provider)
Packit Service 87beb7
{
Packit Service 87beb7
	struct node *root = dti->dt;
Packit Service 87beb7
	int cell, cellsize = 0;
Packit Service 87beb7
Packit Service 87beb7
	if (prop->val.len % sizeof(cell_t)) {
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop,
Packit Service 87beb7
			  "property size (%d) is invalid, expected multiple of %zu",
Packit Service 87beb7
			  prop->val.len, sizeof(cell_t));
Packit Service 87beb7
		return;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	for (cell = 0; cell < prop->val.len / sizeof(cell_t); cell += cellsize + 1) {
Packit Service 87beb7
		struct node *provider_node;
Packit Service 87beb7
		struct property *cellprop;
Packit Service 87beb7
		int phandle;
Packit Service 87beb7
Packit Service 87beb7
		phandle = propval_cell_n(prop, cell);
Packit Service 87beb7
		/*
Packit Service 87beb7
		 * Some bindings use a cell value 0 or -1 to skip over optional
Packit Service 87beb7
		 * entries when each index position has a specific definition.
Packit Service 87beb7
		 */
Packit Service 87beb7
		if (phandle == 0 || phandle == -1) {
Packit Service 87beb7
			/* Give up if this is an overlay with external references */
Packit Service 87beb7
			if (dti->dtsflags & DTSF_PLUGIN)
Packit Service 87beb7
				break;
Packit Service 87beb7
Packit Service 87beb7
			cellsize = 0;
Packit Service 87beb7
			continue;
Packit Service 87beb7
		}
Packit Service 87beb7
Packit Service 87beb7
		/* If we have markers, verify the current cell is a phandle */
Packit Service 87beb7
		if (prop->val.markers) {
Packit Service 87beb7
			struct marker *m = prop->val.markers;
Packit Service 87beb7
			for_each_marker_of_type(m, REF_PHANDLE) {
Packit Service 87beb7
				if (m->offset == (cell * sizeof(cell_t)))
Packit Service 87beb7
					break;
Packit Service 87beb7
			}
Packit Service 87beb7
			if (!m)
Packit Service 87beb7
				FAIL_PROP(c, dti, node, prop,
Packit Service 87beb7
					  "cell %d is not a phandle reference",
Packit Service 87beb7
					  cell);
Packit Service 87beb7
		}
Packit Service 87beb7
Packit Service 87beb7
		provider_node = get_node_by_phandle(root, phandle);
Packit Service 87beb7
		if (!provider_node) {
Packit Service 87beb7
			FAIL_PROP(c, dti, node, prop,
Packit Service 87beb7
				  "Could not get phandle node for (cell %d)",
Packit Service 87beb7
				  cell);
Packit Service 87beb7
			break;
Packit Service 87beb7
		}
Packit Service 87beb7
Packit Service 87beb7
		cellprop = get_property(provider_node, provider->cell_name);
Packit Service 87beb7
		if (cellprop) {
Packit Service 87beb7
			cellsize = propval_cell(cellprop);
Packit Service 87beb7
		} else if (provider->optional) {
Packit Service 87beb7
			cellsize = 0;
Packit Service 87beb7
		} else {
Packit Service 87beb7
			FAIL(c, dti, node, "Missing property '%s' in node %s or bad phandle (referred from %s[%d])",
Packit Service 87beb7
			     provider->cell_name,
Packit Service 87beb7
			     provider_node->fullpath,
Packit Service 87beb7
			     prop->name, cell);
Packit Service 87beb7
			break;
Packit Service 87beb7
		}
Packit Service 87beb7
Packit Service 87beb7
		if (prop->val.len < ((cell + cellsize + 1) * sizeof(cell_t))) {
Packit Service 87beb7
			FAIL_PROP(c, dti, node, prop,
Packit Service 87beb7
				  "property size (%d) too small for cell size %d",
Packit Service 87beb7
				  prop->val.len, cellsize);
Packit Service 87beb7
		}
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
Packit Service 87beb7
static void check_provider_cells_property(struct check *c,
Packit Service 87beb7
					  struct dt_info *dti,
Packit Service 87beb7
				          struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct provider *provider = c->data;
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, provider->prop_name);
Packit Service 87beb7
	if (!prop)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	check_property_phandle_args(c, dti, node, prop, provider);
Packit Service 87beb7
}
Packit Service 87beb7
#define WARNING_PROPERTY_PHANDLE_CELLS(nm, propname, cells_name, ...) \
Packit Service 87beb7
	static struct provider nm##_provider = { (propname), (cells_name), __VA_ARGS__ }; \
Packit Service 87beb7
	WARNING(nm##_property, check_provider_cells_property, &nm##_provider, &phandle_references);
Packit Service 87beb7
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(clocks, "clocks", "#clock-cells");
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(cooling_device, "cooling-device", "#cooling-cells");
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(dmas, "dmas", "#dma-cells");
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(hwlocks, "hwlocks", "#hwlock-cells");
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(interrupts_extended, "interrupts-extended", "#interrupt-cells");
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(io_channels, "io-channels", "#io-channel-cells");
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(iommus, "iommus", "#iommu-cells");
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(mboxes, "mboxes", "#mbox-cells");
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(msi_parent, "msi-parent", "#msi-cells", true);
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(mux_controls, "mux-controls", "#mux-control-cells");
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(phys, "phys", "#phy-cells");
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(power_domains, "power-domains", "#power-domain-cells");
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(pwms, "pwms", "#pwm-cells");
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(resets, "resets", "#reset-cells");
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(sound_dai, "sound-dai", "#sound-dai-cells");
Packit Service 87beb7
WARNING_PROPERTY_PHANDLE_CELLS(thermal_sensors, "thermal-sensors", "#thermal-sensor-cells");
Packit Service 87beb7
Packit Service 87beb7
static bool prop_is_gpio(struct property *prop)
Packit Service 87beb7
{
Packit Service 87beb7
	char *str;
Packit Service 87beb7
Packit Service 87beb7
	/*
Packit Service 87beb7
	 * *-gpios and *-gpio can appear in property names,
Packit Service 87beb7
	 * so skip over any false matches (only one known ATM)
Packit Service 87beb7
	 */
Packit Service 87beb7
	if (strstr(prop->name, "nr-gpio"))
Packit Service 87beb7
		return false;
Packit Service 87beb7
Packit Service 87beb7
	str = strrchr(prop->name, '-');
Packit Service 87beb7
	if (str)
Packit Service 87beb7
		str++;
Packit Service 87beb7
	else
Packit Service 87beb7
		str = prop->name;
Packit Service 87beb7
	if (!(streq(str, "gpios") || streq(str, "gpio")))
Packit Service 87beb7
		return false;
Packit Service 87beb7
Packit Service 87beb7
	return true;
Packit Service 87beb7
}
Packit Service 87beb7
Packit Service 87beb7
static void check_gpios_property(struct check *c,
Packit Service 87beb7
					  struct dt_info *dti,
Packit Service 87beb7
				          struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	/* Skip GPIO hog nodes which have 'gpios' property */
Packit Service 87beb7
	if (get_property(node, "gpio-hog"))
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	for_each_property(node, prop) {
Packit Service 87beb7
		struct provider provider;
Packit Service 87beb7
Packit Service 87beb7
		if (!prop_is_gpio(prop))
Packit Service 87beb7
			continue;
Packit Service 87beb7
Packit Service 87beb7
		provider.prop_name = prop->name;
Packit Service 87beb7
		provider.cell_name = "#gpio-cells";
Packit Service 87beb7
		provider.optional = false;
Packit Service 87beb7
		check_property_phandle_args(c, dti, node, prop, &provider);
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(gpios_property, check_gpios_property, NULL, &phandle_references);
Packit Service 87beb7
Packit Service 87beb7
static void check_deprecated_gpio_property(struct check *c,
Packit Service 87beb7
					   struct dt_info *dti,
Packit Service 87beb7
				           struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	for_each_property(node, prop) {
Packit Service 87beb7
		char *str;
Packit Service 87beb7
Packit Service 87beb7
		if (!prop_is_gpio(prop))
Packit Service 87beb7
			continue;
Packit Service 87beb7
Packit Service 87beb7
		str = strstr(prop->name, "gpio");
Packit Service 87beb7
		if (!streq(str, "gpio"))
Packit Service 87beb7
			continue;
Packit Service 87beb7
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop,
Packit Service 87beb7
			  "'[*-]gpio' is deprecated, use '[*-]gpios' instead");
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
}
Packit Service 87beb7
CHECK(deprecated_gpio_property, check_deprecated_gpio_property, NULL);
Packit Service 87beb7
Packit Service 87beb7
static bool node_is_interrupt_provider(struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "interrupt-controller");
Packit Service 87beb7
	if (prop)
Packit Service 87beb7
		return true;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "interrupt-map");
Packit Service 87beb7
	if (prop)
Packit Service 87beb7
		return true;
Packit Service 87beb7
Packit Service 87beb7
	return false;
Packit Service 87beb7
}
Packit Service 87beb7
static void check_interrupts_property(struct check *c,
Packit Service 87beb7
				      struct dt_info *dti,
Packit Service 87beb7
				      struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct node *root = dti->dt;
Packit Service 87beb7
	struct node *irq_node = NULL, *parent = node;
Packit Service 87beb7
	struct property *irq_prop, *prop = NULL;
Packit Service 87beb7
	int irq_cells, phandle;
Packit Service 87beb7
Packit Service 87beb7
	irq_prop = get_property(node, "interrupts");
Packit Service 87beb7
	if (!irq_prop)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (irq_prop->val.len % sizeof(cell_t))
Packit Service 87beb7
		FAIL_PROP(c, dti, node, irq_prop, "size (%d) is invalid, expected multiple of %zu",
Packit Service 87beb7
		     irq_prop->val.len, sizeof(cell_t));
Packit Service 87beb7
Packit Service 87beb7
	while (parent && !prop) {
Packit Service 87beb7
		if (parent != node && node_is_interrupt_provider(parent)) {
Packit Service 87beb7
			irq_node = parent;
Packit Service 87beb7
			break;
Packit Service 87beb7
		}
Packit Service 87beb7
Packit Service 87beb7
		prop = get_property(parent, "interrupt-parent");
Packit Service 87beb7
		if (prop) {
Packit Service 87beb7
			phandle = propval_cell(prop);
Packit Service 87beb7
			if ((phandle == 0) || (phandle == -1)) {
Packit Service 87beb7
				/* Give up if this is an overlay with
Packit Service 87beb7
				 * external references */
Packit Service 87beb7
				if (dti->dtsflags & DTSF_PLUGIN)
Packit Service 87beb7
					return;
Packit Service 87beb7
				FAIL_PROP(c, dti, parent, prop, "Invalid phandle");
Packit Service 87beb7
				continue;
Packit Service 87beb7
			}
Packit Service 87beb7
Packit Service 87beb7
			irq_node = get_node_by_phandle(root, phandle);
Packit Service 87beb7
			if (!irq_node) {
Packit Service 87beb7
				FAIL_PROP(c, dti, parent, prop, "Bad phandle");
Packit Service 87beb7
				return;
Packit Service 87beb7
			}
Packit Service 87beb7
			if (!node_is_interrupt_provider(irq_node))
Packit Service 87beb7
				FAIL(c, dti, irq_node,
Packit Service 87beb7
				     "Missing interrupt-controller or interrupt-map property");
Packit Service 87beb7
Packit Service 87beb7
			break;
Packit Service 87beb7
		}
Packit Service 87beb7
Packit Service 87beb7
		parent = parent->parent;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	if (!irq_node) {
Packit Service 87beb7
		FAIL(c, dti, node, "Missing interrupt-parent");
Packit Service 87beb7
		return;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(irq_node, "#interrupt-cells");
Packit Service 87beb7
	if (!prop) {
Packit Service 87beb7
		FAIL(c, dti, irq_node, "Missing #interrupt-cells in interrupt-parent");
Packit Service 87beb7
		return;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	irq_cells = propval_cell(prop);
Packit Service 87beb7
	if (irq_prop->val.len % (irq_cells * sizeof(cell_t))) {
Packit Service 87beb7
		FAIL_PROP(c, dti, node, prop,
Packit Service 87beb7
			  "size is (%d), expected multiple of %d",
Packit Service 87beb7
			  irq_prop->val.len, (int)(irq_cells * sizeof(cell_t)));
Packit Service 87beb7
	}
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(interrupts_property, check_interrupts_property, &phandle_references);
Packit Service 87beb7
Packit Service 87beb7
static const struct bus_type graph_port_bus = {
Packit Service 87beb7
	.name = "graph-port",
Packit Service 87beb7
};
Packit Service 87beb7
Packit Service 87beb7
static const struct bus_type graph_ports_bus = {
Packit Service 87beb7
	.name = "graph-ports",
Packit Service 87beb7
};
Packit Service 87beb7
Packit Service 87beb7
static void check_graph_nodes(struct check *c, struct dt_info *dti,
Packit Service 87beb7
			      struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct node *child;
Packit Service 87beb7
Packit Service 87beb7
	for_each_child(node, child) {
Packit Service 87beb7
		if (!(strprefixeq(child->name, child->basenamelen, "endpoint") ||
Packit Service 87beb7
		      get_property(child, "remote-endpoint")))
Packit Service 87beb7
			continue;
Packit Service 87beb7
Packit Service 87beb7
		node->bus = &graph_port_bus;
Packit Service 87beb7
Packit Service 87beb7
		/* The parent of 'port' nodes can be either 'ports' or a device */
Packit Service 87beb7
		if (!node->parent->bus &&
Packit Service 87beb7
		    (streq(node->parent->name, "ports") || get_property(node, "reg")))
Packit Service 87beb7
			node->parent->bus = &graph_ports_bus;
Packit Service 87beb7
Packit Service 87beb7
		break;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(graph_nodes, check_graph_nodes, NULL);
Packit Service 87beb7
Packit Service 87beb7
static void check_graph_child_address(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				      struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	int cnt = 0;
Packit Service 87beb7
	struct node *child;
Packit Service 87beb7
Packit Service 87beb7
	if (node->bus != &graph_ports_bus && node->bus != &graph_port_bus)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	for_each_child(node, child) {
Packit Service 87beb7
		struct property *prop = get_property(child, "reg");
Packit Service 87beb7
Packit Service 87beb7
		/* No error if we have any non-zero unit address */
Packit Service 87beb7
		if (prop && propval_cell(prop) != 0)
Packit Service 87beb7
			return;
Packit Service 87beb7
Packit Service 87beb7
		cnt++;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	if (cnt == 1 && node->addr_cells != -1)
Packit Service 87beb7
		FAIL(c, dti, node, "graph node has single child node '%s', #address-cells/#size-cells are not necessary",
Packit Service 87beb7
		     node->children->name);
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(graph_child_address, check_graph_child_address, NULL, &graph_nodes);
Packit Service 87beb7
Packit Service 87beb7
static void check_graph_reg(struct check *c, struct dt_info *dti,
Packit Service 87beb7
			    struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	char unit_addr[9];
Packit Service 87beb7
	const char *unitname = get_unitname(node);
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(node, "reg");
Packit Service 87beb7
	if (!prop || !unitname)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (!(prop->val.val && prop->val.len == sizeof(cell_t))) {
Packit Service 87beb7
		FAIL(c, dti, node, "graph node malformed 'reg' property");
Packit Service 87beb7
		return;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	snprintf(unit_addr, sizeof(unit_addr), "%x", propval_cell(prop));
Packit Service 87beb7
	if (!streq(unitname, unit_addr))
Packit Service 87beb7
		FAIL(c, dti, node, "graph node unit address error, expected \"%s\"",
Packit Service 87beb7
		     unit_addr);
Packit Service 87beb7
Packit Service 87beb7
	if (node->parent->addr_cells != 1)
Packit Service 87beb7
		FAIL_PROP(c, dti, node, get_property(node, "#address-cells"),
Packit Service 87beb7
			  "graph node '#address-cells' is %d, must be 1",
Packit Service 87beb7
			  node->parent->addr_cells);
Packit Service 87beb7
	if (node->parent->size_cells != 0)
Packit Service 87beb7
		FAIL_PROP(c, dti, node, get_property(node, "#size-cells"),
Packit Service 87beb7
			  "graph node '#size-cells' is %d, must be 0",
Packit Service 87beb7
			  node->parent->size_cells);
Packit Service 87beb7
}
Packit Service 87beb7
Packit Service 87beb7
static void check_graph_port(struct check *c, struct dt_info *dti,
Packit Service 87beb7
			     struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	if (node->bus != &graph_port_bus)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (!strprefixeq(node->name, node->basenamelen, "port"))
Packit Service 87beb7
		FAIL(c, dti, node, "graph port node name should be 'port'");
Packit Service 87beb7
Packit Service 87beb7
	check_graph_reg(c, dti, node);
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(graph_port, check_graph_port, NULL, &graph_nodes);
Packit Service 87beb7
Packit Service 87beb7
static struct node *get_remote_endpoint(struct check *c, struct dt_info *dti,
Packit Service 87beb7
					struct node *endpoint)
Packit Service 87beb7
{
Packit Service 87beb7
	int phandle;
Packit Service 87beb7
	struct node *node;
Packit Service 87beb7
	struct property *prop;
Packit Service 87beb7
Packit Service 87beb7
	prop = get_property(endpoint, "remote-endpoint");
Packit Service 87beb7
	if (!prop)
Packit Service 87beb7
		return NULL;
Packit Service 87beb7
Packit Service 87beb7
	phandle = propval_cell(prop);
Packit Service 87beb7
	/* Give up if this is an overlay with external references */
Packit Service 87beb7
	if (phandle == 0 || phandle == -1)
Packit Service 87beb7
		return NULL;
Packit Service 87beb7
Packit Service 87beb7
	node = get_node_by_phandle(dti->dt, phandle);
Packit Service 87beb7
	if (!node)
Packit Service 87beb7
		FAIL_PROP(c, dti, endpoint, prop, "graph phandle is not valid");
Packit Service 87beb7
Packit Service 87beb7
	return node;
Packit Service 87beb7
}
Packit Service 87beb7
Packit Service 87beb7
static void check_graph_endpoint(struct check *c, struct dt_info *dti,
Packit Service 87beb7
				 struct node *node)
Packit Service 87beb7
{
Packit Service 87beb7
	struct node *remote_node;
Packit Service 87beb7
Packit Service 87beb7
	if (!node->parent || node->parent->bus != &graph_port_bus)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (!strprefixeq(node->name, node->basenamelen, "endpoint"))
Packit Service 87beb7
		FAIL(c, dti, node, "graph endpoint node name should be 'endpoint'");
Packit Service 87beb7
Packit Service 87beb7
	check_graph_reg(c, dti, node);
Packit Service 87beb7
Packit Service 87beb7
	remote_node = get_remote_endpoint(c, dti, node);
Packit Service 87beb7
	if (!remote_node)
Packit Service 87beb7
		return;
Packit Service 87beb7
Packit Service 87beb7
	if (get_remote_endpoint(c, dti, remote_node) != node)
Packit Service 87beb7
		FAIL(c, dti, node, "graph connection to node '%s' is not bidirectional",
Packit Service 87beb7
		     remote_node->fullpath);
Packit Service 87beb7
}
Packit Service 87beb7
WARNING(graph_endpoint, check_graph_endpoint, NULL, &graph_nodes);
Packit Service 87beb7
Packit Service 87beb7
static struct check *check_table[] = {
Packit Service 87beb7
	&duplicate_node_names, &duplicate_property_names,
Packit Service 87beb7
	&node_name_chars, &node_name_format, &property_name_chars,
Packit Service 87beb7
	&name_is_string, &name_properties,
Packit Service 87beb7
Packit Service 87beb7
	&duplicate_label,
Packit Service 87beb7
Packit Service 87beb7
	&explicit_phandles,
Packit Service 87beb7
	&phandle_references, &path_references,
Packit Service 87beb7
	&omit_unused_nodes,
Packit Service 87beb7
Packit Service 87beb7
	&address_cells_is_cell, &size_cells_is_cell, &interrupt_cells_is_cell,
Packit Service 87beb7
	&device_type_is_string, &model_is_string, &status_is_string,
Packit Service 87beb7
	&label_is_string,
Packit Service 87beb7
Packit Service 87beb7
	&compatible_is_string_list, &names_is_string_list,
Packit Service 87beb7
Packit Service 87beb7
	&property_name_chars_strict,
Packit Service 87beb7
	&node_name_chars_strict,
Packit Service 87beb7
Packit Service 87beb7
	&addr_size_cells, &reg_format, &ranges_format, &dma_ranges_format,
Packit Service 87beb7
Packit Service 87beb7
	&unit_address_vs_reg,
Packit Service 87beb7
	&unit_address_format,
Packit Service 87beb7
Packit Service 87beb7
	&pci_bridge,
Packit Service 87beb7
	&pci_device_reg,
Packit Service 87beb7
	&pci_device_bus_num,
Packit Service 87beb7
Packit Service 87beb7
	&simple_bus_bridge,
Packit Service 87beb7
	&simple_bus_reg,
Packit Service 87beb7
Packit Service 87beb7
	&i2c_bus_bridge,
Packit Service 87beb7
	&i2c_bus_reg,
Packit Service 87beb7
Packit Service 87beb7
	&spi_bus_bridge,
Packit Service 87beb7
	&spi_bus_reg,
Packit Service 87beb7
Packit Service 87beb7
	&avoid_default_addr_size,
Packit Service 87beb7
	&avoid_unnecessary_addr_size,
Packit Service 87beb7
	&unique_unit_address,
Packit Service 87beb7
	&unique_unit_address_if_enabled,
Packit Service 87beb7
	&obsolete_chosen_interrupt_controller,
Packit Service 87beb7
	&chosen_node_is_root, &chosen_node_bootargs, &chosen_node_stdout_path,
Packit Service 87beb7
Packit Service 87beb7
	&clocks_property,
Packit Service 87beb7
	&cooling_device_property,
Packit Service 87beb7
	&dmas_property,
Packit Service 87beb7
	&hwlocks_property,
Packit Service 87beb7
	&interrupts_extended_property,
Packit Service 87beb7
	&io_channels_property,
Packit Service 87beb7
	&iommus_property,
Packit Service 87beb7
	&mboxes_property,
Packit Service 87beb7
	&msi_parent_property,
Packit Service 87beb7
	&mux_controls_property,
Packit Service 87beb7
	&phys_property,
Packit Service 87beb7
	&power_domains_property,
Packit Service 87beb7
	&pwms_property,
Packit Service 87beb7
	&resets_property,
Packit Service 87beb7
	&sound_dai_property,
Packit Service 87beb7
	&thermal_sensors_property,
Packit Service 87beb7
Packit Service 87beb7
	&deprecated_gpio_property,
Packit Service 87beb7
	&gpios_property,
Packit Service 87beb7
	&interrupts_property,
Packit Service 87beb7
Packit Service 87beb7
	&alias_paths,
Packit Service 87beb7
Packit Service 87beb7
	&graph_nodes, &graph_child_address, &graph_port, &graph_endpoint,
Packit Service 87beb7
Packit Service 87beb7
	&always_fail,
Packit Service 87beb7
};
Packit Service 87beb7
Packit Service 87beb7
static void enable_warning_error(struct check *c, bool warn, bool error)
Packit Service 87beb7
{
Packit Service 87beb7
	int i;
Packit Service 87beb7
Packit Service 87beb7
	/* Raising level, also raise it for prereqs */
Packit Service 87beb7
	if ((warn && !c->warn) || (error && !c->error))
Packit Service 87beb7
		for (i = 0; i < c->num_prereqs; i++)
Packit Service 87beb7
			enable_warning_error(c->prereq[i], warn, error);
Packit Service 87beb7
Packit Service 87beb7
	c->warn = c->warn || warn;
Packit Service 87beb7
	c->error = c->error || error;
Packit Service 87beb7
}
Packit Service 87beb7
Packit Service 87beb7
static void disable_warning_error(struct check *c, bool warn, bool error)
Packit Service 87beb7
{
Packit Service 87beb7
	int i;
Packit Service 87beb7
Packit Service 87beb7
	/* Lowering level, also lower it for things this is the prereq
Packit Service 87beb7
	 * for */
Packit Service 87beb7
	if ((warn && c->warn) || (error && c->error)) {
Packit Service 87beb7
		for (i = 0; i < ARRAY_SIZE(check_table); i++) {
Packit Service 87beb7
			struct check *cc = check_table[i];
Packit Service 87beb7
			int j;
Packit Service 87beb7
Packit Service 87beb7
			for (j = 0; j < cc->num_prereqs; j++)
Packit Service 87beb7
				if (cc->prereq[j] == c)
Packit Service 87beb7
					disable_warning_error(cc, warn, error);
Packit Service 87beb7
		}
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	c->warn = c->warn && !warn;
Packit Service 87beb7
	c->error = c->error && !error;
Packit Service 87beb7
}
Packit Service 87beb7
Packit Service 87beb7
void parse_checks_option(bool warn, bool error, const char *arg)
Packit Service 87beb7
{
Packit Service 87beb7
	int i;
Packit Service 87beb7
	const char *name = arg;
Packit Service 87beb7
	bool enable = true;
Packit Service 87beb7
Packit Service 87beb7
	if ((strncmp(arg, "no-", 3) == 0)
Packit Service 87beb7
	    || (strncmp(arg, "no_", 3) == 0)) {
Packit Service 87beb7
		name = arg + 3;
Packit Service 87beb7
		enable = false;
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	for (i = 0; i < ARRAY_SIZE(check_table); i++) {
Packit Service 87beb7
		struct check *c = check_table[i];
Packit Service 87beb7
Packit Service 87beb7
		if (streq(c->name, name)) {
Packit Service 87beb7
			if (enable)
Packit Service 87beb7
				enable_warning_error(c, warn, error);
Packit Service 87beb7
			else
Packit Service 87beb7
				disable_warning_error(c, warn, error);
Packit Service 87beb7
			return;
Packit Service 87beb7
		}
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	die("Unrecognized check name \"%s\"\n", name);
Packit Service 87beb7
}
Packit Service 87beb7
Packit Service 87beb7
void process_checks(bool force, struct dt_info *dti)
Packit Service 87beb7
{
Packit Service 87beb7
	int i;
Packit Service 87beb7
	int error = 0;
Packit Service 87beb7
Packit Service 87beb7
	for (i = 0; i < ARRAY_SIZE(check_table); i++) {
Packit Service 87beb7
		struct check *c = check_table[i];
Packit Service 87beb7
Packit Service 87beb7
		if (c->warn || c->error)
Packit Service 87beb7
			error = error || run_check(c, dti);
Packit Service 87beb7
	}
Packit Service 87beb7
Packit Service 87beb7
	if (error) {
Packit Service 87beb7
		if (!force) {
Packit Service 87beb7
			fprintf(stderr, "ERROR: Input tree has errors, aborting "
Packit Service 87beb7
				"(use -f to force output)\n");
Packit Service 87beb7
			exit(2);
Packit Service 87beb7
		} else if (quiet < 3) {
Packit Service 87beb7
			fprintf(stderr, "Warning: Input tree has errors, "
Packit Service 87beb7
				"output forced\n");
Packit Service 87beb7
		}
Packit Service 87beb7
	}
Packit Service 87beb7
}