Blame lib/checkstring.h

Packit 2035a7
/*
Packit 2035a7
 * Cppcheck - A tool for static C/C++ code analysis
Packit 2035a7
 * Copyright (C) 2007-2018 Cppcheck team.
Packit 2035a7
 *
Packit 2035a7
 * This program is free software: you can redistribute it and/or modify
Packit 2035a7
 * it under the terms of the GNU General Public License as published by
Packit 2035a7
 * the Free Software Foundation, either version 3 of the License, or
Packit 2035a7
 * (at your option) any later version.
Packit 2035a7
 *
Packit 2035a7
 * This program is distributed in the hope that it will be useful,
Packit 2035a7
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
Packit 2035a7
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
Packit 2035a7
 * GNU General Public License for more details.
Packit 2035a7
 *
Packit 2035a7
 * You should have received a copy of the GNU General Public License
Packit 2035a7
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
Packit 2035a7
 */
Packit 2035a7
Packit 2035a7
Packit 2035a7
//---------------------------------------------------------------------------
Packit 2035a7
#ifndef checkstringH
Packit 2035a7
#define checkstringH
Packit 2035a7
//---------------------------------------------------------------------------
Packit 2035a7
Packit 2035a7
#include "check.h"
Packit 2035a7
#include "config.h"
Packit 2035a7
Packit 2035a7
#include <string>
Packit 2035a7
Packit 2035a7
class ErrorLogger;
Packit 2035a7
class Settings;
Packit 2035a7
class Token;
Packit 2035a7
class Tokenizer;
Packit 2035a7
Packit 2035a7
/// @addtogroup Checks
Packit 2035a7
/// @{
Packit 2035a7
Packit 2035a7
Packit 2035a7
/** @brief Detect misusage of C-style strings and related standard functions */
Packit 2035a7
Packit 2035a7
class CPPCHECKLIB CheckString : public Check {
Packit 2035a7
public:
Packit 2035a7
    /** @brief This constructor is used when registering the CheckClass */
Packit 2035a7
    CheckString() : Check(myName()) {
Packit 2035a7
    }
Packit 2035a7
Packit 2035a7
    /** @brief This constructor is used when running checks. */
Packit 2035a7
    CheckString(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger)
Packit 2035a7
        : Check(myName(), tokenizer, settings, errorLogger) {
Packit 2035a7
    }
Packit 2035a7
Packit 2035a7
    /** @brief Run checks against the normal token list */
Packit 2035a7
    void runChecks(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger) {
Packit 2035a7
        CheckString checkString(tokenizer, settings, errorLogger);
Packit 2035a7
Packit 2035a7
        // Checks
Packit 2035a7
        checkString.strPlusChar();
Packit 2035a7
        checkString.checkSuspiciousStringCompare();
Packit 2035a7
        checkString.stringLiteralWrite();
Packit 2035a7
        checkString.overlappingStrcmp();
Packit 2035a7
    }
Packit 2035a7
Packit 2035a7
    /** @brief Run checks against the simplified token list */
Packit 2035a7
    void runSimplifiedChecks(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger) {
Packit 2035a7
        CheckString checkString(tokenizer, settings, errorLogger);
Packit 2035a7
Packit 2035a7
        // Checks
Packit 2035a7
        checkString.checkIncorrectStringCompare();
Packit 2035a7
        checkString.checkAlwaysTrueOrFalseStringCompare();
Packit 2035a7
        checkString.sprintfOverlappingData();
Packit 2035a7
    }
Packit 2035a7
Packit 2035a7
    /** @brief undefined behaviour, writing string literal */
Packit 2035a7
    void stringLiteralWrite();
Packit 2035a7
Packit 2035a7
    /** @brief str plus char (unusual pointer arithmetic) */
Packit 2035a7
    void strPlusChar();
Packit 2035a7
Packit 2035a7
    /** @brief %Check for using bad usage of strncmp and substr */
Packit 2035a7
    void checkIncorrectStringCompare();
Packit 2035a7
Packit 2035a7
    /** @brief %Check for comparison of a string literal with a char* variable */
Packit 2035a7
    void checkSuspiciousStringCompare();
Packit 2035a7
Packit 2035a7
    /** @brief %Check for suspicious code that compares string literals for equality */
Packit 2035a7
    void checkAlwaysTrueOrFalseStringCompare();
Packit 2035a7
Packit 2035a7
    /** @brief %Check for overlapping strcmp() */
Packit 2035a7
    void overlappingStrcmp();
Packit 2035a7
Packit 2035a7
    /** @brief %Check for overlapping source and destination passed to sprintf() */
Packit 2035a7
    void sprintfOverlappingData();
Packit 2035a7
Packit 2035a7
private:
Packit 2035a7
    void stringLiteralWriteError(const Token *tok, const Token *strValue);
Packit 2035a7
    void sprintfOverlappingDataError(const Token *tok, const std::string &varname);
Packit 2035a7
    void strPlusCharError(const Token *tok);
Packit 2035a7
    void incorrectStringCompareError(const Token *tok, const std::string& func, const std::string &string);
Packit 2035a7
    void incorrectStringBooleanError(const Token *tok, const std::string& string);
Packit 2035a7
    void alwaysTrueFalseStringCompareError(const Token *tok, const std::string& str1, const std::string& str2);
Packit 2035a7
    void alwaysTrueStringVariableCompareError(const Token *tok, const std::string& str1, const std::string& str2);
Packit 2035a7
    void suspiciousStringCompareError(const Token* tok, const std::string& var);
Packit 2035a7
    void suspiciousStringCompareError_char(const Token* tok, const std::string& var);
Packit 2035a7
    void overlappingStrcmpError(const Token* eq0, const Token *ne0);
Packit 2035a7
Packit 2035a7
    void getErrorMessages(ErrorLogger *errorLogger, const Settings *settings) const {
Packit 2035a7
        CheckString c(nullptr, settings, errorLogger);
Packit 2035a7
Packit 2035a7
        c.stringLiteralWriteError(nullptr, nullptr);
Packit 2035a7
        c.sprintfOverlappingDataError(nullptr, "varname");
Packit 2035a7
        c.strPlusCharError(nullptr);
Packit 2035a7
        c.incorrectStringCompareError(nullptr, "substr", "\"Hello World\"");
Packit 2035a7
        c.suspiciousStringCompareError(nullptr, "foo");
Packit 2035a7
        c.suspiciousStringCompareError_char(nullptr, "foo");
Packit 2035a7
        c.incorrectStringBooleanError(nullptr, "\"Hello World\"");
Packit 2035a7
        c.alwaysTrueFalseStringCompareError(nullptr, "str1", "str2");
Packit 2035a7
        c.alwaysTrueStringVariableCompareError(nullptr, "varname1", "varname2");
Packit 2035a7
        c.overlappingStrcmpError(nullptr, nullptr);
Packit 2035a7
    }
Packit 2035a7
Packit 2035a7
    static std::string myName() {
Packit 2035a7
        return "String";
Packit 2035a7
    }
Packit 2035a7
Packit 2035a7
    std::string classInfo() const {
Packit 2035a7
        return "Detect misusage of C-style strings:\n"
Packit 2035a7
               "- overlapping buffers passed to sprintf as source and destination\n"
Packit 2035a7
               "- incorrect length arguments for 'substr' and 'strncmp'\n"
Packit 2035a7
               "- suspicious condition (runtime comparison of string literals)\n"
Packit 2035a7
               "- suspicious condition (string literals as boolean)\n"
Packit 2035a7
               "- suspicious comparison of a string literal with a char* variable\n"
Packit 2035a7
               "- suspicious comparison of '\\0' with a char* variable\n"
Packit 2035a7
               "- overlapping strcmp() expression\n";
Packit 2035a7
    }
Packit 2035a7
};
Packit 2035a7
/// @}
Packit 2035a7
//---------------------------------------------------------------------------
Packit 2035a7
#endif // checkstringH