Blame SPECS/0069-shellcheck-Check-exit-code-directly-with-if-mycmd.patch
|
Packit |
8ea169 |
From 58d1e4fa0a0f6fc2fc3ee773665de70a073ae759 Mon Sep 17 00:00:00 2001
|
|
Packit |
8ea169 |
From: Martin Kutlak <mkutlak@redhat.com>
|
|
Packit |
8ea169 |
Date: Wed, 12 Dec 2018 16:16:55 +0100
|
|
Packit |
8ea169 |
Subject: [PATCH] shellcheck: Check exit code directly with if mycmd
|
|
Packit |
8ea169 |
|
|
Packit |
8ea169 |
Running a command and then checking its exit status $? against 0 is redundant.
|
|
Packit |
8ea169 |
|
|
Packit |
8ea169 |
Fixes ShellCheck warning SC2181.
|
|
Packit |
8ea169 |
|
|
Packit |
8ea169 |
Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
|
|
Packit |
8ea169 |
---
|
|
Packit |
8ea169 |
src/plugins/abrt-action-analyze-ccpp-local.in | 8 +++-----
|
|
Packit |
8ea169 |
1 file changed, 3 insertions(+), 5 deletions(-)
|
|
Packit |
8ea169 |
|
|
Packit |
8ea169 |
diff --git a/src/plugins/abrt-action-analyze-ccpp-local.in b/src/plugins/abrt-action-analyze-ccpp-local.in
|
|
Packit |
8ea169 |
index 9144c0e6..d2453c19 100644
|
|
Packit |
8ea169 |
--- a/src/plugins/abrt-action-analyze-ccpp-local.in
|
|
Packit |
8ea169 |
+++ b/src/plugins/abrt-action-analyze-ccpp-local.in
|
|
Packit |
8ea169 |
@@ -36,9 +36,7 @@ if $INSTALL_DI; then
|
|
Packit |
8ea169 |
fi
|
|
Packit |
8ea169 |
done
|
|
Packit |
8ea169 |
|
|
Packit |
8ea169 |
- ${EXECUTABLE} ${EXTRA_ARGS} --size_mb=4096
|
|
Packit |
8ea169 |
-fi
|
|
Packit |
8ea169 |
-
|
|
Packit |
8ea169 |
-if [ $? = 0 ]; then
|
|
Packit |
8ea169 |
- abrt-action-generate-backtrace && abrt-action-analyze-backtrace
|
|
Packit |
8ea169 |
+ if ${EXECUTABLE} "${EXTRA_ARGS}" --size_mb=4096; then
|
|
Packit |
8ea169 |
+ abrt-action-generate-backtrace && abrt-action-analyze-backtrace
|
|
Packit |
8ea169 |
+ fi
|
|
Packit |
8ea169 |
fi
|
|
Packit |
8ea169 |
--
|
|
Packit |
8ea169 |
2.26.2
|
|
Packit |
8ea169 |
|