From a92d0708fa5755e2c66943c7827c538824473596 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 6 Mar 2012 02:06:29 +0100 Subject: [PATCH] nspawn: be less cryptic when clone() fails Based on a patch suggested by Shawn Landden. (cherry picked from commit 52af21063b365f231ee6ae8bac18d690fff85799) --- src/nspawn.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/nspawn.c b/src/nspawn.c index 3ea603f..52b4aa8 100644 --- a/src/nspawn.c +++ b/src/nspawn.c @@ -705,8 +705,13 @@ int main(int argc, char *argv[]) { sigset_add_many(&mask, SIGCHLD, SIGWINCH, SIGTERM, SIGINT, -1); assert_se(sigprocmask(SIG_BLOCK, &mask, NULL) == 0); - if ((pid = syscall(__NR_clone, SIGCHLD|CLONE_NEWIPC|CLONE_NEWNS|CLONE_NEWPID|CLONE_NEWUTS|(arg_private_network ? CLONE_NEWNET : 0), NULL)) < 0) { - log_error("clone() failed: %m"); + pid = syscall(__NR_clone, SIGCHLD|CLONE_NEWIPC|CLONE_NEWNS|CLONE_NEWPID|CLONE_NEWUTS|(arg_private_network ? CLONE_NEWNET : 0), NULL); + if (pid < 0) { + if (errno == EINVAL) + log_error("clone() failed, do you have namespace support enabled in your kernel? (You need UTS, IPC, PID and NET namespacing built in): %m"); + else + log_error("clone() failed: %m"); + goto finish; }