|
 |
e2ec8a |
From 04326c02ca80666e66a5da8e6a46c2fc4476000c Mon Sep 17 00:00:00 2001
|
|
|
e2ec8a |
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
|
|
|
e2ec8a |
Date: Wed, 5 Dec 2018 21:34:24 +0100
|
|
|
e2ec8a |
Subject: [PATCH] coredump: fix message when we fail to save a journald
|
|
|
e2ec8a |
coredump
|
|
|
e2ec8a |
|
|
|
e2ec8a |
If creation of the message failed, we'd write a bogus entry:
|
|
|
e2ec8a |
systemd-coredump[1400]: Cannot store coredump of 416 (systemd-journal): No space left on device
|
|
|
e2ec8a |
systemd-coredump[1400]: MESSAGE=Process 416 (systemd-journal) of user 0 dumped core.
|
|
|
e2ec8a |
systemd-coredump[1400]: Coredump diverted to
|
|
|
e2ec8a |
|
|
|
e2ec8a |
(cherry-picked from commit f0136e09221364f931c3a3b715da4e4d3ee9f2ac)
|
|
|
e2ec8a |
|
|
|
e2ec8a |
Related: #1664976
|
|
|
e2ec8a |
---
|
|
|
e2ec8a |
src/coredump/coredump.c | 4 ++--
|
|
|
e2ec8a |
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
e2ec8a |
|
|
|
e2ec8a |
diff --git a/src/coredump/coredump.c b/src/coredump/coredump.c
|
|
|
e2ec8a |
index ffa88f612d..2a130e8838 100644
|
|
|
e2ec8a |
--- a/src/coredump/coredump.c
|
|
|
e2ec8a |
+++ b/src/coredump/coredump.c
|
|
|
e2ec8a |
@@ -783,8 +783,8 @@ log:
|
|
|
e2ec8a |
core_message = strjoin("MESSAGE=Process ", context[CONTEXT_PID],
|
|
|
e2ec8a |
" (", context[CONTEXT_COMM], ") of user ",
|
|
|
e2ec8a |
context[CONTEXT_UID], " dumped core.",
|
|
|
e2ec8a |
- journald_crash ? "\nCoredump diverted to " : NULL,
|
|
|
e2ec8a |
- journald_crash ? filename : NULL);
|
|
|
e2ec8a |
+ journald_crash && filename ? "\nCoredump diverted to " : NULL,
|
|
|
e2ec8a |
+ journald_crash && filename ? filename : NULL);
|
|
|
e2ec8a |
if (!core_message)
|
|
|
e2ec8a |
return log_oom();
|
|
|
e2ec8a |
|