Jonathan G. Underwood e76d57
diff -up emacs-23.1/lib-src/movemail.c.movemail emacs-23.1/lib-src/movemail.c
Jonathan G. Underwood e76d57
--- emacs-23.1/lib-src/movemail.c.movemail	2010-03-31 19:18:05.611899443 +0200
Jonathan G. Underwood e76d57
+++ emacs-23.1/lib-src/movemail.c	2010-03-31 19:24:29.738754553 +0200
Jonathan G. Underwood e76d57
@@ -176,7 +176,9 @@ main (argc, argv)
Jonathan G. Underwood e76d57
   int nread;
Jonathan G. Underwood e76d57
   int status;
Jonathan G. Underwood e76d57
   int c, preserve_mail = 0;
Jonathan G. Underwood e76d57
-
Jonathan G. Underwood e76d57
+  uid_t real_gid, priv_gid;
Jonathan G. Underwood e76d57
+  real_gid = getgid();
Jonathan G. Underwood e76d57
+  priv_gid = getegid();
Jonathan G. Underwood e76d57
 #ifndef MAIL_USE_SYSTEM_LOCK
Jonathan G. Underwood e76d57
   struct stat st;
Jonathan G. Underwood e76d57
   long now;
Jonathan G. Underwood e76d57
@@ -247,25 +249,6 @@ main (argc, argv)
Jonathan G. Underwood e76d57
   if (*outname == 0)
Jonathan G. Underwood e76d57
     fatal ("Destination file name is empty", 0, 0);
Jonathan G. Underwood e76d57
 
Jonathan G. Underwood e76d57
-  /* Check access to output file.  */
Jonathan G. Underwood e76d57
-  if (access (outname, F_OK) == 0 && access (outname, W_OK) != 0)
Jonathan G. Underwood e76d57
-    pfatal_with_name (outname);
Jonathan G. Underwood e76d57
-
Jonathan G. Underwood e76d57
-  /* Also check that outname's directory is writable to the real uid.  */
Jonathan G. Underwood e76d57
-  {
Jonathan G. Underwood e76d57
-    char *buf = (char *) xmalloc (strlen (outname) + 1);
Jonathan G. Underwood e76d57
-    char *p;
Jonathan G. Underwood e76d57
-    strcpy (buf, outname);
Jonathan G. Underwood e76d57
-    p = buf + strlen (buf);
Jonathan G. Underwood e76d57
-    while (p > buf && !IS_DIRECTORY_SEP (p[-1]))
Jonathan G. Underwood e76d57
-      *--p = 0;
Jonathan G. Underwood e76d57
-    if (p == buf)
Jonathan G. Underwood e76d57
-      *p++ = '.';
Jonathan G. Underwood e76d57
-    if (access (buf, W_OK) != 0)
Jonathan G. Underwood e76d57
-      pfatal_with_name (buf);
Jonathan G. Underwood e76d57
-    free (buf);
Jonathan G. Underwood e76d57
-  }
Jonathan G. Underwood e76d57
-
Jonathan G. Underwood e76d57
 #ifdef MAIL_USE_POP
Jonathan G. Underwood e76d57
   if (!strncmp (inname, "po:", 3))
Jonathan G. Underwood e76d57
     {
Jonathan G. Underwood e76d57
@@ -277,15 +260,11 @@ main (argc, argv)
Jonathan G. Underwood e76d57
       exit (status);
Jonathan G. Underwood e76d57
     }
Jonathan G. Underwood e76d57
 
Jonathan G. Underwood e76d57
-  setuid (getuid ());
Jonathan G. Underwood e76d57
+  if (setuid (getuid ()) < 0)
Jonathan G. Underwood e76d57
+    fatal ("Failed to drop privileges", 0, 0);
Jonathan G. Underwood e76d57
 #endif /* MAIL_USE_POP */
Jonathan G. Underwood e76d57
 
Jonathan G. Underwood e76d57
 #ifndef DISABLE_DIRECT_ACCESS
Jonathan G. Underwood e76d57
-
Jonathan G. Underwood e76d57
-  /* Check access to input file.  */
Jonathan G. Underwood e76d57
-  if (access (inname, R_OK | W_OK) != 0)
Jonathan G. Underwood e76d57
-    pfatal_with_name (inname);
Jonathan G. Underwood e76d57
-
Jonathan G. Underwood e76d57
 #ifndef MAIL_USE_MMDF
Jonathan G. Underwood e76d57
 #ifndef MAIL_USE_SYSTEM_LOCK
Jonathan G. Underwood e76d57
 #ifdef MAIL_USE_MAILLOCK
Jonathan G. Underwood e76d57
@@ -379,7 +358,8 @@ main (argc, argv)
Jonathan G. Underwood e76d57
       time_t touched_lock, now;
Jonathan G. Underwood e76d57
 #endif
Jonathan G. Underwood e76d57
 
Jonathan G. Underwood e76d57
-      setuid (getuid ());
Jonathan G. Underwood e76d57
+      if (setuid (getuid ()) < 0 || setegid (real_gid) < 0)
Jonathan G. Underwood e76d57
+	fatal("Failed to drop privileges", 0, 0);
Jonathan G. Underwood e76d57
 
Jonathan G. Underwood e76d57
 #ifndef MAIL_USE_MMDF
Jonathan G. Underwood e76d57
 #ifdef MAIL_USE_SYSTEM_LOCK
Jonathan G. Underwood e76d57
@@ -405,6 +385,9 @@ main (argc, argv)
Jonathan G. Underwood e76d57
       if (outdesc < 0)
Jonathan G. Underwood e76d57
 	pfatal_with_name (outname);
Jonathan G. Underwood e76d57
 
Jonathan G. Underwood e76d57
+      if (setegid (priv_gid) < 0)
Jonathan G. Underwood e76d57
+        fatal("Failed to regain privileges", 0, 0);
Jonathan G. Underwood e76d57
+
Jonathan G. Underwood e76d57
       /* This label exists so we can retry locking
Jonathan G. Underwood e76d57
 	 after a delay, if it got EAGAIN or EBUSY.  */
Jonathan G. Underwood e76d57
     retry_lock:
Jonathan G. Underwood e76d57
@@ -502,6 +485,10 @@ main (argc, argv)
Jonathan G. Underwood e76d57
       if (close (outdesc) != 0)
Jonathan G. Underwood e76d57
 	pfatal_and_delete (outname);
Jonathan G. Underwood e76d57
 
Jonathan G. Underwood e76d57
+      /* Prevent symlink attacks truncating other users' mailboxes */
Jonathan G. Underwood e76d57
+      if (setegid (real_gid) < 0)
Jonathan G. Underwood e76d57
+	fatal("Failed to drop privileges", 0, 0);
Jonathan G. Underwood e76d57
+
Jonathan G. Underwood e76d57
 #ifdef MAIL_USE_SYSTEM_LOCK
Jonathan G. Underwood e76d57
       if (! preserve_mail)
Jonathan G. Underwood e76d57
 	{
Jonathan G. Underwood e76d57
@@ -529,6 +516,10 @@ main (argc, argv)
Jonathan G. Underwood e76d57
 	}
Jonathan G. Underwood e76d57
 #endif /* not MAIL_USE_SYSTEM_LOCK */
Jonathan G. Underwood e76d57
 
Jonathan G. Underwood e76d57
+      /* End of mailbox truncation */
Jonathan G. Underwood e76d57
+      if (setegid (priv_gid) < 0)
Jonathan G. Underwood e76d57
+	fatal("Failed to regain privileges", 0, 0);
Jonathan G. Underwood e76d57
+
Jonathan G. Underwood e76d57
 #ifdef MAIL_USE_MAILLOCK
Jonathan G. Underwood e76d57
       /* This has to occur in the child, i.e., in the process that
Jonathan G. Underwood e76d57
          acquired the lock! */