Tim Waugh df5058
diff -up cups-1.3.5/scheduler/log.c.logrotate cups-1.3.5/scheduler/log.c
Tim Waugh df5058
--- cups-1.3.5/scheduler/log.c.logrotate	2008-02-14 12:21:25.000000000 +0000
Tim Waugh df5058
+++ cups-1.3.5/scheduler/log.c	2008-02-14 12:24:16.000000000 +0000
Tim Waugh df5058
@@ -29,6 +29,9 @@
Tim Waugh df5058
 #include "cupsd.h"
Tim Waugh df5058
 #include <stdarg.h>
Tim Waugh df5058
 #include <syslog.h>
Tim Waugh df5058
+#include <sys/types.h>
Tim Waugh df5058
+#include <sys/stat.h>
Tim Waugh df5058
+#include <unistd.h>
Tim Waugh df5058
 
Tim Waugh df5058
 
Tim Waugh df5058
 /*
Tim Waugh df5058
@@ -467,12 +470,10 @@ check_log_file(cups_file_t **lf,	/* IO -
Tim Waugh df5058
     return (1);
Tim Waugh df5058
 
Tim Waugh df5058
  /*
Tim Waugh df5058
-  * Format the filename as needed...
Tim Waugh df5058
+  * Format the filename...
Tim Waugh df5058
   */
Tim Waugh df5058
 
Tim Waugh df5058
-  if (!*lf ||
Tim Waugh df5058
-      (strncmp(logname, "/dev/", 5) && cupsFileTell(*lf) > MaxLogSize &&
Tim Waugh df5058
-       MaxLogSize > 0))
Tim Waugh df5058
+  if (strncmp(logname, "/dev/", 5))
Tim Waugh df5058
   {
Tim Waugh df5058
    /*
Tim Waugh df5058
     * Handle format strings...
Tim Waugh df5058
@@ -565,6 +566,34 @@ check_log_file(cups_file_t **lf,	/* IO -
Tim Waugh df5058
   }
Tim Waugh df5058
 
Tim Waugh df5058
  /*
Tim Waugh df5058
+  * Has someone else (i.e. logrotate) already rotated the log for us?
Tim Waugh df5058
+  */
Tim Waugh df5058
+  else if (strncmp(filename, "/dev/", 5))
Tim Waugh df5058
+  {
Tim Waugh df5058
+    struct stat st;
Tim Waugh df5058
+    if (stat(filename, &st) || st.st_size == 0)
Tim Waugh df5058
+    {
Tim Waugh df5058
+      /* File is either missing or has zero size. */
Tim Waugh df5058
+
Tim Waugh df5058
+      cupsFileClose(*lf);
Tim Waugh df5058
+      if ((*lf = cupsFileOpen(filename, "a")) == NULL)
Tim Waugh df5058
+      {
Tim Waugh df5058
+	syslog(LOG_ERR, "Unable to open log file \"%s\" - %s", filename,
Tim Waugh df5058
+             strerror(errno));
Tim Waugh df5058
+
Tim Waugh df5058
+	return (0);
Tim Waugh df5058
+      }
Tim Waugh df5058
+
Tim Waugh df5058
+     /*
Tim Waugh df5058
+      * Change ownership and permissions of non-device logs...
Tim Waugh df5058
+      */
Tim Waugh df5058
+
Tim Waugh df5058
+      fchown(cupsFileNumber(*lf), RunUser, Group);
Tim Waugh df5058
+      fchmod(cupsFileNumber(*lf), LogFilePerm);
Tim Waugh df5058
+    }
Tim Waugh df5058
+  }
Tim Waugh df5058
+
Tim Waugh df5058
+ /*
Tim Waugh df5058
   * Do we need to rotate the log?
Tim Waugh df5058
   */
Tim Waugh df5058