Tim Waugh 611ccc
diff -up cups-1.6.1/notifier/dbus.c.dbus-utf8 cups-1.6.1/notifier/dbus.c
Tim Waugh 611ccc
--- cups-1.6.1/notifier/dbus.c.dbus-utf8	2012-01-20 19:00:32.000000000 +0000
Tim Waugh 65ecaf
+++ cups-1.6.1/notifier/dbus.c	2012-10-31 11:04:47.686973616 +0000
Tim Waugh 65ecaf
@@ -31,6 +31,9 @@
Tim Waugh 611ccc
 #include <sys/stat.h>
Tim Waugh 611ccc
 #include <sys/types.h>
Tim Waugh 611ccc
 #include <unistd.h>
Tim Waugh 611ccc
+#include <assert.h>
Tim Waugh 65ecaf
+#include <locale.h>
Tim Waugh 611ccc
+#include <wchar.h>
Tim Waugh 611ccc
 
Tim Waugh 611ccc
 #ifdef HAVE_DBUS
Tim Waugh 611ccc
 #  include <dbus/dbus.h>
Tim Waugh 65ecaf
@@ -157,10 +160,82 @@ enum
Tim Waugh 611ccc
  * Local functions...
Tim Waugh 611ccc
  */
Tim Waugh 611ccc
 
Tim Waugh 611ccc
-static int	acquire_lock(int *fd, char *lockfile, size_t locksize);
Tim Waugh 611ccc
+static int		acquire_lock(int *fd, char *lockfile, size_t locksize);
Tim Waugh 611ccc
+static const char	*validate_utf8(const char *str);
Tim Waugh 611ccc
 
Tim Waugh 611ccc
 
Tim Waugh 611ccc
 /*
Tim Waugh 611ccc
+ * 'validate_utf8()' - Convert to valid UTF-8
Tim Waugh 611ccc
+ */
Tim Waugh 611ccc
+
Tim Waugh 611ccc
+static const char *
Tim Waugh 611ccc
+validate_utf8 (const char *str)
Tim Waugh 611ccc
+{
Tim Waugh 611ccc
+  static char *buffer = NULL;
Tim Waugh 611ccc
+  static size_t buflen = 0;
Tim Waugh 611ccc
+  char *p;
Tim Waugh 611ccc
+  size_t str_len;
Tim Waugh 611ccc
+  unsigned int i;
Tim Waugh 611ccc
+  mbstate_t instate, outstate;
Tim Waugh 611ccc
+
Tim Waugh 611ccc
+  if (str == NULL)
Tim Waugh 611ccc
+  {
Tim Waugh 611ccc
+    free (buffer);
Tim Waugh 611ccc
+    return (NULL);
Tim Waugh 611ccc
+  }
Tim Waugh 611ccc
+
Tim Waugh 611ccc
+  /* Is it already valid? */
Tim Waugh 611ccc
+  if (mbstowcs (NULL, str, 0) != (size_t) -1)
Tim Waugh 611ccc
+    return str;
Tim Waugh 611ccc
+
Tim Waugh 611ccc
+  /* Make sure our buffer is at least as large as the input string */
Tim Waugh 611ccc
+  str_len = strlen (str);
Tim Waugh 611ccc
+  if (str_len > buflen)
Tim Waugh 611ccc
+  {
Tim Waugh 65ecaf
+    if (buffer == NULL)
Tim Waugh 65ecaf
+      /* Set encoding type to UTF-8 the first time we need to */
Tim Waugh 65ecaf
+      setlocale (LC_CTYPE, "en_US.UTF-8");
Tim Waugh 65ecaf
+
Tim Waugh 611ccc
+    buflen = str_len + 1;
Tim Waugh 611ccc
+    buffer = realloc (buffer, buflen);
Tim Waugh 611ccc
+  }
Tim Waugh 611ccc
+
Tim Waugh 611ccc
+  memset (&instate, '\0', sizeof (mbstate_t));
Tim Waugh 611ccc
+  memset (&outstate, '\0', sizeof (mbstate_t));
Tim Waugh 611ccc
+  p = buffer;
Tim Waugh 611ccc
+  i = 0;
Tim Waugh 611ccc
+  while (i < str_len)
Tim Waugh 611ccc
+  {
Tim Waugh 611ccc
+    wchar_t wc;
Tim Waugh 611ccc
+    size_t used, written;
Tim Waugh 611ccc
+    mbstate_t orig_instate = instate;
Tim Waugh 611ccc
+    used = mbrtowc (&wc, str + i, str_len - i, &instate);
Tim Waugh 611ccc
+    switch (used)
Tim Waugh 611ccc
+    {
Tim Waugh 611ccc
+    case (size_t) -2:
Tim Waugh 611ccc
+    case (size_t) -1:
Tim Waugh 611ccc
+      wc = L'?'; /* so replacement is never longer than original char */
Tim Waugh 611ccc
+      instate = orig_instate;
Tim Waugh 611ccc
+      /* fallthru */
Tim Waugh 611ccc
+    case 0:
Tim Waugh 611ccc
+      used = 1;
Tim Waugh 611ccc
+    }
Tim Waugh 611ccc
+
Tim Waugh 611ccc
+    written = wcrtomb (p, wc, &outstate);
Tim Waugh 611ccc
+    if (written != -1)
Tim Waugh 611ccc
+    {
Tim Waugh 611ccc
+      p += written;
Tim Waugh 611ccc
+      assert (p - buffer < buflen);
Tim Waugh 611ccc
+    }
Tim Waugh 611ccc
+
Tim Waugh 611ccc
+    i += used;
Tim Waugh 611ccc
+  }
Tim Waugh 611ccc
+
Tim Waugh 611ccc
+  *p = '\0';
Tim Waugh 65ecaf
+  return buffer;
Tim Waugh 611ccc
+}
Tim Waugh 611ccc
+
Tim Waugh 611ccc
+/*
Tim Waugh 611ccc
  * 'main()' - Read events and send DBUS notifications.
Tim Waugh 611ccc
  */
Tim Waugh 611ccc
 
Tim Waugh 65ecaf
@@ -366,7 +441,7 @@ main(int  argc,				/* I - Number of comm
Tim Waugh 611ccc
     attr = ippFindAttribute(msg, "notify-text", IPP_TAG_TEXT);
Tim Waugh 611ccc
     if (attr)
Tim Waugh 611ccc
     {
Tim Waugh 611ccc
-      const char *val = ippGetString(attr, 0, NULL);
Tim Waugh 611ccc
+      const char *val = validate_utf8 (ippGetString(attr, 0, NULL));
Tim Waugh 611ccc
       if (!dbus_message_iter_append_string(&iter, &val))
Tim Waugh 611ccc
         goto bail;
Tim Waugh 611ccc
     }