Tomas Mraz 345a73
diff -up cracklib-2.9.6/lib/fascist.c.overflow cracklib-2.9.6/lib/fascist.c
Tomas Mraz 345a73
--- cracklib-2.9.6/lib/fascist.c.overflow	2015-10-23 16:58:38.403319225 +0200
Tomas Mraz 345a73
+++ cracklib-2.9.6/lib/fascist.c	2016-12-08 17:28:41.490101358 +0100
Tomas Mraz 345a73
@@ -515,7 +515,7 @@ FascistGecosUser(char *password, const c
Tomas Mraz 345a73
     char gbuffer[STRINGSIZE];
Tomas Mraz 345a73
     char tbuffer[STRINGSIZE];
Tomas Mraz 345a73
     char *uwords[STRINGSIZE];
Tomas Mraz 345a73
-    char longbuffer[STRINGSIZE * 2];
Tomas Mraz 345a73
+    char longbuffer[STRINGSIZE];
Tomas Mraz 345a73
 
Tomas Mraz 345a73
     if (gecos == NULL)
Tomas Mraz 345a73
 	gecos = "";
Tomas Mraz 345a73
@@ -596,38 +596,47 @@ FascistGecosUser(char *password, const c
Tomas Mraz 345a73
     {
Tomas Mraz 345a73
 	for (i = 0; i < j; i++)
Tomas Mraz 345a73
 	{
Tomas Mraz 345a73
-	    strcpy(longbuffer, uwords[i]);
Tomas Mraz 345a73
-	    strcat(longbuffer, uwords[j]);
Tomas Mraz 345a73
-
Tomas Mraz 345a73
-	    if (GTry(longbuffer, password))
Tomas Mraz 345a73
+	    if (strlen(uwords[i]) + strlen(uwords[j]) < STRINGSIZE)
Tomas Mraz 345a73
 	    {
Tomas Mraz 345a73
-		return _("it is derived from your password entry");
Tomas Mraz 345a73
-	    }
Tomas Mraz 345a73
-
Tomas Mraz 345a73
-	    strcpy(longbuffer, uwords[j]);
Tomas Mraz 345a73
-	    strcat(longbuffer, uwords[i]);
Tomas Mraz 345a73
+		strcpy(longbuffer, uwords[i]);
Tomas Mraz 345a73
+		strcat(longbuffer, uwords[j]);
Tomas Mraz 345a73
 
Tomas Mraz 345a73
-	    if (GTry(longbuffer, password))
Tomas Mraz 345a73
-	    {
Tomas Mraz 345a73
-		return _("it's derived from your password entry");
Tomas Mraz 345a73
+		if (GTry(longbuffer, password))
Tomas Mraz 345a73
+		{
Tomas Mraz 345a73
+		    return _("it is derived from your password entry");
Tomas Mraz 345a73
+		}
Tomas Mraz 345a73
+
Tomas Mraz 345a73
+		strcpy(longbuffer, uwords[j]);
Tomas Mraz 345a73
+		strcat(longbuffer, uwords[i]);
Tomas Mraz 345a73
+
Tomas Mraz 345a73
+		if (GTry(longbuffer, password))
Tomas Mraz 345a73
+		{
Tomas Mraz 345a73
+		   return _("it's derived from your password entry");
Tomas Mraz 345a73
+		}
Tomas Mraz 345a73
 	    }
Tomas Mraz 345a73
 
Tomas Mraz 345a73
-	    longbuffer[0] = uwords[i][0];
Tomas Mraz 345a73
-	    longbuffer[1] = '\0';
Tomas Mraz 345a73
-	    strcat(longbuffer, uwords[j]);
Tomas Mraz 345a73
-
Tomas Mraz 345a73
-	    if (GTry(longbuffer, password))
Tomas Mraz 345a73
+	    if (strlen(uwords[j]) < STRINGSIZE - 1)
Tomas Mraz 345a73
 	    {
Tomas Mraz 345a73
-		return _("it is derivable from your password entry");
Tomas Mraz 345a73
+		longbuffer[0] = uwords[i][0];
Tomas Mraz 345a73
+		longbuffer[1] = '\0';
Tomas Mraz 345a73
+		strcat(longbuffer, uwords[j]);
Tomas Mraz 345a73
+
Tomas Mraz 345a73
+		if (GTry(longbuffer, password))
Tomas Mraz 345a73
+		{
Tomas Mraz 345a73
+		    return _("it is derivable from your password entry");
Tomas Mraz 345a73
+		}
Tomas Mraz 345a73
 	    }
Tomas Mraz 345a73
 
Tomas Mraz 345a73
-	    longbuffer[0] = uwords[j][0];
Tomas Mraz 345a73
-	    longbuffer[1] = '\0';
Tomas Mraz 345a73
-	    strcat(longbuffer, uwords[i]);
Tomas Mraz 345a73
-
Tomas Mraz 345a73
-	    if (GTry(longbuffer, password))
Tomas Mraz 345a73
+	    if (strlen(uwords[i]) < STRINGSIZE - 1)
Tomas Mraz 345a73
 	    {
Tomas Mraz 345a73
-		return _("it's derivable from your password entry");
Tomas Mraz 345a73
+		longbuffer[0] = uwords[j][0];
Tomas Mraz 345a73
+		longbuffer[1] = '\0';
Tomas Mraz 345a73
+		strcat(longbuffer, uwords[i]);
Tomas Mraz 345a73
+
Tomas Mraz 345a73
+		if (GTry(longbuffer, password))
Tomas Mraz 345a73
+		{
Tomas Mraz 345a73
+		    return _("it's derivable from your password entry");
Tomas Mraz 345a73
+		}
Tomas Mraz 345a73
 	    }
Tomas Mraz 345a73
 	}
Tomas Mraz 345a73
     }
Tomas Mraz 345a73
diff -up cracklib-2.9.6/lib/rules.c.overflow cracklib-2.9.6/lib/rules.c
Tomas Mraz 345a73
--- cracklib-2.9.6/lib/rules.c.overflow	2015-10-23 16:58:38.000000000 +0200
Tomas Mraz 345a73
+++ cracklib-2.9.6/lib/rules.c	2016-12-08 18:03:27.041941297 +0100
Tomas Mraz 345a73
@@ -158,6 +158,8 @@ Pluralise(string, area)		/* returns a po
Tomas Mraz 345a73
     register int length;
Tomas Mraz 345a73
     length = strlen(string);
Tomas Mraz 345a73
     strcpy(area, string);
Tomas Mraz 345a73
+    if (length > STRINGSIZE - 3) /* we add 2 characters at worst */
Tomas Mraz 345a73
+	return (area);
Tomas Mraz 345a73
 
Tomas Mraz 345a73
     if (!Suffix(string, "ch") ||
Tomas Mraz 345a73
 	!Suffix(string, "ex") ||
Tomas Mraz 345a73
@@ -462,11 +464,11 @@ Mangle(input, control, area)		/* returns
Tomas Mraz 345a73
 	    Pluralise(area2, area);
Tomas Mraz 345a73
 	    break;
Tomas Mraz 345a73
 	case RULE_REFLECT:
Tomas Mraz 345a73
-	    strcat(area, Reverse(area, area2));
Tomas Mraz 345a73
+	    strncat(area, Reverse(area, area2), STRINGSIZE - strlen(area) - 1);
Tomas Mraz 345a73
 	    break;
Tomas Mraz 345a73
 	case RULE_DUPLICATE:
Tomas Mraz 345a73
 	    strcpy(area2, area);
Tomas Mraz 345a73
-	    strcat(area, area2);
Tomas Mraz 345a73
+	    strncat(area, area2, STRINGSIZE - strlen(area) - 1);
Tomas Mraz 345a73
 	    break;
Tomas Mraz 345a73
 	case RULE_GT:
Tomas Mraz 345a73
 	    if (!ptr[1])
Tomas Mraz 345a73
@@ -514,7 +516,8 @@ Mangle(input, control, area)		/* returns
Tomas Mraz 345a73
 	    } else
Tomas Mraz 345a73
 	    {
Tomas Mraz 345a73
 		area2[0] = *(++ptr);
Tomas Mraz 345a73
-		strcpy(area2 + 1, area);
Tomas Mraz 345a73
+		strncpy(area2 + 1, area, STRINGSIZE - 2);
Tomas Mraz 345a73
+		area2[STRINGSIZE - 1] = '\0';
Tomas Mraz 345a73
 		strcpy(area, area2);
Tomas Mraz 345a73
 	    }
Tomas Mraz 345a73
 	    break;
Tomas Mraz 345a73
@@ -528,8 +531,10 @@ Mangle(input, control, area)		/* returns
Tomas Mraz 345a73
 		register char *string;
Tomas Mraz 345a73
 		string = area;
Tomas Mraz 345a73
 		while (*(string++));
Tomas Mraz 345a73
-		string[-1] = *(++ptr);
Tomas Mraz 345a73
-		*string = '\0';
Tomas Mraz 345a73
+		if (string < area + STRINGSIZE) {
Tomas Mraz 345a73
+			string[-1] = *(++ptr);
Tomas Mraz 345a73
+			*string = '\0';
Tomas Mraz 345a73
+		}
Tomas Mraz 345a73
 	    }
Tomas Mraz 345a73
 	    break;
Tomas Mraz 345a73
 	case RULE_EXTRACT:
Tomas Mraz 345a73
@@ -600,6 +605,10 @@ Mangle(input, control, area)		/* returns
Tomas Mraz 345a73
 		}
Tomas Mraz 345a73
 		p1 = area;
Tomas Mraz 345a73
 		p2 = area2;
Tomas Mraz 345a73
+		if (strlen(p1) > STRINGSIZE - 2) {
Tomas Mraz 345a73
+			/* truncate */
Tomas Mraz 345a73
+			p1[STRINGSIZE - 2] = '\0';
Tomas Mraz 345a73
+		}
Tomas Mraz 345a73
 		while (i && *p1)
Tomas Mraz 345a73
 		{
Tomas Mraz 345a73
 		    i--;