Paul Wouters 5ea965
From 832166dc4780e259424ebab07b42ecf42cde6fe3 Mon Sep 17 00:00:00 2001
Paul Wouters 5ea965
From: Kevin Cernekee <cernekee@chromium.org>
Paul Wouters 5ea965
Date: Fri, 27 Jan 2017 12:38:46 -0800
Paul Wouters 5ea965
Subject: conntrackd: cthelper: Free pktb after use
Paul Wouters 5ea965
Paul Wouters 5ea965
According to valgrind, this currently leaks ~512B to 2kB for each
Paul Wouters 5ea965
packet sent to the userspace helper.
Paul Wouters 5ea965
Paul Wouters 5ea965
Signed-off-by: Kevin Cernekee <cernekee@chromium.org>
Paul Wouters 5ea965
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Paul Wouters 5ea965
---
Paul Wouters 5ea965
 src/cthelper.c | 1 +
Paul Wouters 5ea965
 1 file changed, 1 insertion(+)
Paul Wouters 5ea965
Paul Wouters 5ea965
diff --git a/src/cthelper.c b/src/cthelper.c
Paul Wouters 5ea965
index 54eb830..f01c509 100644
Paul Wouters 5ea965
--- a/src/cthelper.c
Paul Wouters 5ea965
+++ b/src/cthelper.c
Paul Wouters 5ea965
@@ -325,6 +325,7 @@ static int nfq_queue_cb(const struct nlmsghdr *nlh, void *data)
Paul Wouters 5ea965
 	if (pkt_verdict_issue(helper, myct, queue_num, id, verdict, pktb) < 0)
Paul Wouters 5ea965
 		goto err4;
Paul Wouters 5ea965
 
Paul Wouters 5ea965
+	pktb_free(pktb);
Paul Wouters 5ea965
 	nfct_destroy(ct);
Paul Wouters 5ea965
 	if (myct->exp != NULL)
Paul Wouters 5ea965
 		nfexp_destroy(myct->exp);
Paul Wouters 5ea965
-- 
Paul Wouters 5ea965
cgit v0.12
Paul Wouters 5ea965