Nick Clifton b877ba
diff -rup binutils.orig/bfd/dwarf2.c binutils-2.27/bfd/dwarf2.c
Nick Clifton b877ba
--- binutils.orig/bfd/dwarf2.c	2017-01-09 10:55:15.558436986 +0000
Nick Clifton b877ba
+++ binutils-2.27/bfd/dwarf2.c	2017-01-09 13:40:38.642944116 +0000
Nick Clifton b877ba
@@ -1,5 +1,5 @@
Nick Clifton b877ba
 /* DWARF 2 support.
Nick Clifton b877ba
-   Copyright (C) 1994-2016 Free Software Foundation, Inc.
Nick Clifton b877ba
+   Copyright (C) 1994-2017 Free Software Foundation, Inc.
Nick Clifton b877ba
 
Nick Clifton b877ba
    Adapted from gdb/dwarf2read.c by Gavin Koch of Cygnus Solutions
Nick Clifton b877ba
    (gavin@cygnus.com).
Nick Clifton b877ba
@@ -144,16 +144,16 @@ struct dwarf2_debug
Nick Clifton b877ba
   /* Length of the loaded .debug_str section.  */
Nick Clifton b877ba
   bfd_size_type dwarf_str_size;
Nick Clifton b877ba
 
Nick Clifton b877ba
-  /* Pointer to the .debug_ranges section loaded into memory. */
Nick Clifton b877ba
+  /* Pointer to the .debug_ranges section loaded into memory.  */
Nick Clifton b877ba
   bfd_byte *dwarf_ranges_buffer;
Nick Clifton b877ba
 
Nick Clifton b877ba
-  /* Length of the loaded .debug_ranges section. */
Nick Clifton b877ba
+  /* Length of the loaded .debug_ranges section.  */
Nick Clifton b877ba
   bfd_size_type dwarf_ranges_size;
Nick Clifton b877ba
 
Nick Clifton b877ba
   /* If the most recent call to bfd_find_nearest_line was given an
Nick Clifton b877ba
      address in an inlined function, preserve a pointer into the
Nick Clifton b877ba
      calling chain for subsequent calls to bfd_find_inliner_info to
Nick Clifton b877ba
-     use. */
Nick Clifton b877ba
+     use.  */
Nick Clifton b877ba
   struct funcinfo *inliner_chain;
Nick Clifton b877ba
 
Nick Clifton b877ba
   /* Section VMAs at the time the stash was built.  */
Nick Clifton b877ba
@@ -212,9 +212,12 @@ struct comp_unit
Nick Clifton b877ba
   /* Keep the bfd convenient (for memory allocation).  */
Nick Clifton b877ba
   bfd *abfd;
Nick Clifton b877ba
 
Nick Clifton b877ba
-  /* The lowest and highest addresses contained in this compilation
Nick Clifton b877ba
-     unit as specified in the compilation unit header.  */
Nick Clifton b877ba
+  /* Linked list of the low and high address ranges contained in this
Nick Clifton b877ba
+     compilation unit as specified in the compilation unit header.  */
Nick Clifton b877ba
   struct arange arange;
Nick Clifton b877ba
+  /* A single arange containing the lowest and highest
Nick Clifton b877ba
+     addresses covered by the compilation unit.  */
Nick Clifton b877ba
+  struct arange minmax;
Nick Clifton b877ba
 
Nick Clifton b877ba
   /* The DW_AT_name attribute (for error messages).  */
Nick Clifton b877ba
   char *name;
Nick Clifton b877ba
@@ -396,7 +399,7 @@ struct info_hash_table
Nick Clifton b877ba
   struct bfd_hash_table base;
Nick Clifton b877ba
 };
Nick Clifton b877ba
 
Nick Clifton b877ba
-/* Function to create a new entry in info hash table. */
Nick Clifton b877ba
+/* Function to create a new entry in info hash table.  */
Nick Clifton b877ba
 
Nick Clifton b877ba
 static struct bfd_hash_entry *
Nick Clifton b877ba
 info_hash_table_newfunc (struct bfd_hash_entry *entry,
Nick Clifton b877ba
@@ -482,7 +485,7 @@ insert_info_hash_table (struct info_hash
Nick Clifton b877ba
 }
Nick Clifton b877ba
 
Nick Clifton b877ba
 /* Look up an info entry list from an info hash table.  Return NULL
Nick Clifton b877ba
-   if there is none. */
Nick Clifton b877ba
+   if there is none.  */
Nick Clifton b877ba
 
Nick Clifton b877ba
 static struct info_list_node *
Nick Clifton b877ba
 lookup_info_hash_table (struct info_hash_table *hash_table, const char *key)
Nick Clifton b877ba
@@ -523,8 +526,8 @@ read_section (bfd *           abfd,
Nick Clifton b877ba
 	}
Nick Clifton b877ba
       if (! msec)
Nick Clifton b877ba
 	{
Nick Clifton b877ba
-	  (*_bfd_error_handler) (_("Dwarf Error: Can't find %s section."),
Nick Clifton b877ba
-				 sec->uncompressed_name);
Nick Clifton b877ba
+	  _bfd_error_handler (_("Dwarf Error: Can't find %s section."),
Nick Clifton b877ba
+			      sec->uncompressed_name);
Nick Clifton b877ba
 	  bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
 	  return FALSE;
Nick Clifton b877ba
 	}
Nick Clifton b877ba
@@ -552,9 +555,10 @@ read_section (bfd *           abfd,
Nick Clifton b877ba
      that the client wants.  Validate it here to avoid trouble later.  */
Nick Clifton b877ba
   if (offset != 0 && offset >= *section_size)
Nick Clifton b877ba
     {
Nick Clifton b877ba
-      (*_bfd_error_handler) (_("Dwarf Error: Offset (%lu)"
Nick Clifton b877ba
-			       " greater than or equal to %s size (%lu)."),
Nick Clifton b877ba
-			     (long) offset, section_name, *section_size);
Nick Clifton b877ba
+      /* xgettext: c-format */
Nick Clifton b877ba
+      _bfd_error_handler (_("Dwarf Error: Offset (%lu)"
Nick Clifton b877ba
+			    " greater than or equal to %s size (%lu)."),
Nick Clifton b877ba
+			  (long) offset, section_name, *section_size);
Nick Clifton b877ba
       bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
       return FALSE;
Nick Clifton b877ba
     }
Nick Clifton b877ba
@@ -1011,7 +1015,7 @@ read_attribute_value (struct attribute *
Nick Clifton b877ba
 
Nick Clifton b877ba
   if (info_ptr >= info_ptr_end && form != DW_FORM_flag_present)
Nick Clifton b877ba
     {
Nick Clifton b877ba
-      (*_bfd_error_handler) (_("Dwarf Error: Info pointer extends beyond end of attributes"));
Nick Clifton b877ba
+      _bfd_error_handler (_("Dwarf Error: Info pointer extends beyond end of attributes"));
Nick Clifton b877ba
       bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
       return info_ptr;
Nick Clifton b877ba
     }
Nick Clifton b877ba
@@ -1163,8 +1167,8 @@ read_attribute_value (struct attribute *
Nick Clifton b877ba
       info_ptr = read_attribute_value (attr, form, unit, info_ptr, info_ptr_end);
Nick Clifton b877ba
       break;
Nick Clifton b877ba
     default:
Nick Clifton b877ba
-      (*_bfd_error_handler) (_("Dwarf Error: Invalid or unhandled FORM value: %#x."),
Nick Clifton b877ba
-			     form);
Nick Clifton b877ba
+      _bfd_error_handler (_("Dwarf Error: Invalid or unhandled FORM value: %#x."),
Nick Clifton b877ba
+			  form);
Nick Clifton b877ba
       bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
       return NULL;
Nick Clifton b877ba
     }
Nick Clifton b877ba
@@ -1219,22 +1223,22 @@ non_mangled (int lang)
Nick Clifton b877ba
 
Nick Clifton b877ba
 struct line_info
Nick Clifton b877ba
 {
Nick Clifton b877ba
-  struct line_info* prev_line;
Nick Clifton b877ba
-  bfd_vma address;
Nick Clifton b877ba
-  char *filename;
Nick Clifton b877ba
-  unsigned int line;
Nick Clifton b877ba
-  unsigned int column;
Nick Clifton b877ba
-  unsigned int discriminator;
Nick Clifton b877ba
-  unsigned char op_index;
Nick Clifton b877ba
-  unsigned char end_sequence;		/* End of (sequential) code sequence.  */
Nick Clifton b877ba
+  struct line_info *	prev_line;
Nick Clifton b877ba
+  bfd_vma		address;
Nick Clifton b877ba
+  char *		filename;
Nick Clifton b877ba
+  unsigned int		line;
Nick Clifton b877ba
+  unsigned int		column;
Nick Clifton b877ba
+  unsigned int		discriminator;
Nick Clifton b877ba
+  unsigned char		op_index;
Nick Clifton b877ba
+  unsigned char		end_sequence;		/* End of (sequential) code sequence.  */
Nick Clifton b877ba
 };
Nick Clifton b877ba
 
Nick Clifton b877ba
 struct fileinfo
Nick Clifton b877ba
 {
Nick Clifton b877ba
-  char *name;
Nick Clifton b877ba
-  unsigned int dir;
Nick Clifton b877ba
-  unsigned int time;
Nick Clifton b877ba
-  unsigned int size;
Nick Clifton b877ba
+  char *		name;
Nick Clifton b877ba
+  unsigned int		dir;
Nick Clifton b877ba
+  unsigned int		time;
Nick Clifton b877ba
+  unsigned int		size;
Nick Clifton b877ba
 };
Nick Clifton b877ba
 
Nick Clifton b877ba
 struct line_sequence
Nick Clifton b877ba
@@ -1248,7 +1252,7 @@ struct line_sequence
Nick Clifton b877ba
 
Nick Clifton b877ba
 struct line_info_table
Nick Clifton b877ba
 {
Nick Clifton b877ba
-  bfd*                  abfd;
Nick Clifton b877ba
+  bfd *                 abfd;
Nick Clifton b877ba
   unsigned int          num_files;
Nick Clifton b877ba
   unsigned int          num_dirs;
Nick Clifton b877ba
   unsigned int          num_sequences;
Nick Clifton b877ba
@@ -1267,37 +1271,37 @@ struct line_info_table
Nick Clifton b877ba
 struct funcinfo
Nick Clifton b877ba
 {
Nick Clifton b877ba
   /* Pointer to previous function in list of all functions.  */
Nick Clifton b877ba
-  struct funcinfo *prev_func;
Nick Clifton b877ba
+  struct funcinfo *	prev_func;
Nick Clifton b877ba
   /* Pointer to function one scope higher.  */
Nick Clifton b877ba
-  struct funcinfo *caller_func;
Nick Clifton b877ba
+  struct funcinfo *	caller_func;
Nick Clifton b877ba
   /* Source location file name where caller_func inlines this func.  */
Nick Clifton b877ba
-  char *caller_file;
Nick Clifton b877ba
+  char *		caller_file;
Nick Clifton b877ba
   /* Source location file name.  */
Nick Clifton b877ba
-  char *file;
Nick Clifton b877ba
+  char *		file;
Nick Clifton b877ba
   /* Source location line number where caller_func inlines this func.  */
Nick Clifton b877ba
-  int caller_line;
Nick Clifton b877ba
+  int			caller_line;
Nick Clifton b877ba
   /* Source location line number.  */
Nick Clifton b877ba
-  int line;
Nick Clifton b877ba
-  int tag;
Nick Clifton b877ba
-  bfd_boolean is_linkage;
Nick Clifton b877ba
-  const char *name;
Nick Clifton b877ba
-  struct arange arange;
Nick Clifton b877ba
+  int			line;
Nick Clifton b877ba
+  int			tag;
Nick Clifton b877ba
+  bfd_boolean		is_linkage;
Nick Clifton b877ba
+  const char *		name;
Nick Clifton b877ba
+  struct arange		arange;
Nick Clifton b877ba
   /* Where the symbol is defined.  */
Nick Clifton b877ba
-  asection *sec;
Nick Clifton b877ba
+  asection *		sec;
Nick Clifton b877ba
 };
Nick Clifton b877ba
 
Nick Clifton b877ba
 struct lookup_funcinfo
Nick Clifton b877ba
 {
Nick Clifton b877ba
   /* Function information corresponding to this lookup table entry.  */
Nick Clifton b877ba
-  struct funcinfo *funcinfo;
Nick Clifton b877ba
+  struct funcinfo *	funcinfo;
Nick Clifton b877ba
 
Nick Clifton b877ba
   /* The lowest address for this specific function.  */
Nick Clifton b877ba
-  bfd_vma low_addr;
Nick Clifton b877ba
+  bfd_vma 		low_addr;
Nick Clifton b877ba
 
Nick Clifton b877ba
   /* The highest address of this function before the lookup table is sorted.
Nick Clifton b877ba
-  The highest address of all prior functions after the lookup table is sorted,
Nick Clifton b877ba
-  which is used for binary search.  */
Nick Clifton b877ba
-  bfd_vma high_addr;
Nick Clifton b877ba
+     The highest address of all prior functions after the lookup table is
Nick Clifton b877ba
+     sorted, which is used for binary search.  */
Nick Clifton b877ba
+  bfd_vma 		high_addr;
Nick Clifton b877ba
 };
Nick Clifton b877ba
 
Nick Clifton b877ba
 struct varinfo
Nick Clifton b877ba
@@ -1468,7 +1472,7 @@ concat_filename (struct line_info_table
Nick Clifton b877ba
     {
Nick Clifton b877ba
       /* FILE == 0 means unknown.  */
Nick Clifton b877ba
       if (file)
Nick Clifton b877ba
-	(*_bfd_error_handler)
Nick Clifton b877ba
+	_bfd_error_handler
Nick Clifton b877ba
 	  (_("Dwarf Error: mangled line number section (bad file number)."));
Nick Clifton b877ba
       return strdup ("<unknown>");
Nick Clifton b877ba
     }
Nick Clifton b877ba
@@ -1524,7 +1528,7 @@ concat_filename (struct line_info_table
Nick Clifton b877ba
 }
Nick Clifton b877ba
 
Nick Clifton b877ba
 static bfd_boolean
Nick Clifton b877ba
-arange_add (const struct comp_unit *unit, struct arange *first_arange,
Nick Clifton b877ba
+arange_add (struct comp_unit *unit, struct arange *first_arange,
Nick Clifton b877ba
 	    bfd_vma low_pc, bfd_vma high_pc)
Nick Clifton b877ba
 {
Nick Clifton b877ba
   struct arange *arange;
Nick Clifton b877ba
@@ -1536,11 +1540,16 @@ arange_add (const struct comp_unit *unit
Nick Clifton b877ba
   /* If the first arange is empty, use it.  */
Nick Clifton b877ba
   if (first_arange->high == 0)
Nick Clifton b877ba
     {
Nick Clifton b877ba
-      first_arange->low = low_pc;
Nick Clifton b877ba
-      first_arange->high = high_pc;
Nick Clifton b877ba
+      unit->minmax.low = first_arange->low = low_pc;
Nick Clifton b877ba
+      unit->minmax.high = first_arange->high = high_pc;
Nick Clifton b877ba
       return TRUE;
Nick Clifton b877ba
     }
Nick Clifton b877ba
 
Nick Clifton b877ba
+  if (unit->minmax.low > low_pc)
Nick Clifton b877ba
+    unit->minmax.low = low_pc;
Nick Clifton b877ba
+  if (unit->minmax.high < high_pc)
Nick Clifton b877ba
+    unit->minmax.high = high_pc;
Nick Clifton b877ba
+  
Nick Clifton b877ba
   /* Next see if we can cheaply extend an existing range.  */
Nick Clifton b877ba
   arange = first_arange;
Nick Clifton b877ba
   do
Nick Clifton b877ba
@@ -1560,7 +1569,7 @@ arange_add (const struct comp_unit *unit
Nick Clifton b877ba
   while (arange);
Nick Clifton b877ba
 
Nick Clifton b877ba
   /* Need to allocate a new arange and insert it into the arange list.
Nick Clifton b877ba
-     Order isn't significant, so just insert after the first arange. */
Nick Clifton b877ba
+     Order isn't significant, so just insert after the first arange.  */
Nick Clifton b877ba
   arange = (struct arange *) bfd_alloc (unit->abfd, sizeof (*arange));
Nick Clifton b877ba
   if (arange == NULL)
Nick Clifton b877ba
     return FALSE;
Nick Clifton b877ba
@@ -1603,20 +1612,22 @@ compare_sequences (const void* a, const
Nick Clifton b877ba
 /* Construct the line information table for quick lookup.  */
Nick Clifton b877ba
 
Nick Clifton b877ba
 static bfd_boolean
Nick Clifton b877ba
-build_line_info_table (struct line_info_table* table, struct line_sequence *seq)
Nick Clifton b877ba
+build_line_info_table (struct line_info_table *  table,
Nick Clifton b877ba
+		       struct line_sequence *    seq)
Nick Clifton b877ba
 {
Nick Clifton b877ba
-  bfd_size_type amt;
Nick Clifton b877ba
+  bfd_size_type      amt;
Nick Clifton b877ba
   struct line_info** line_info_lookup;
Nick Clifton b877ba
-  struct line_info* each_line;
Nick Clifton b877ba
-  unsigned int num_lines;
Nick Clifton b877ba
-  unsigned int index;
Nick Clifton b877ba
+  struct line_info*  each_line;
Nick Clifton b877ba
+  unsigned int       num_lines;
Nick Clifton b877ba
+  unsigned int       line_index;
Nick Clifton b877ba
 
Nick Clifton b877ba
   if (seq->line_info_lookup != NULL)
Nick Clifton b877ba
     return TRUE;
Nick Clifton b877ba
 
Nick Clifton b877ba
   /* Count the number of line information entries.  We could do this while
Nick Clifton b877ba
-     scanning the debug information, but some entries may be added via lcl_head
Nick Clifton b877ba
-     without having a sequence handy to increment the number of lines.  */
Nick Clifton b877ba
+     scanning the debug information, but some entries may be added via
Nick Clifton b877ba
+     lcl_head without having a sequence handy to increment the number of
Nick Clifton b877ba
+     lines.  */
Nick Clifton b877ba
   num_lines = 0;
Nick Clifton b877ba
   for (each_line = seq->last_line; each_line; each_line = each_line->prev_line)
Nick Clifton b877ba
     num_lines++;
Nick Clifton b877ba
@@ -1631,11 +1642,11 @@ build_line_info_table (struct line_info_
Nick Clifton b877ba
     return FALSE;
Nick Clifton b877ba
 
Nick Clifton b877ba
   /* Create the line information lookup table.  */
Nick Clifton b877ba
-  index = num_lines;
Nick Clifton b877ba
+  line_index = num_lines;
Nick Clifton b877ba
   for (each_line = seq->last_line; each_line; each_line = each_line->prev_line)
Nick Clifton b877ba
-    line_info_lookup[--index] = each_line;
Nick Clifton b877ba
+    line_info_lookup[--line_index] = each_line;
Nick Clifton b877ba
 
Nick Clifton b877ba
-  BFD_ASSERT (index == 0);
Nick Clifton b877ba
+  BFD_ASSERT (line_index == 0);
Nick Clifton b877ba
 
Nick Clifton b877ba
   seq->num_lines = num_lines;
Nick Clifton b877ba
   seq->line_info_lookup = line_info_lookup;
Nick Clifton b877ba
@@ -1648,12 +1659,12 @@ build_line_info_table (struct line_info_
Nick Clifton b877ba
 static bfd_boolean
Nick Clifton b877ba
 sort_line_sequences (struct line_info_table* table)
Nick Clifton b877ba
 {
Nick Clifton b877ba
-  bfd_size_type amt;
Nick Clifton b877ba
-  struct line_sequence* sequences;
Nick Clifton b877ba
-  struct line_sequence* seq;
Nick Clifton b877ba
-  unsigned int n = 0;
Nick Clifton b877ba
-  unsigned int num_sequences = table->num_sequences;
Nick Clifton b877ba
-  bfd_vma last_high_pc;
Nick Clifton b877ba
+  bfd_size_type          amt;
Nick Clifton b877ba
+  struct line_sequence*  sequences;
Nick Clifton b877ba
+  struct line_sequence*  seq;
Nick Clifton b877ba
+  unsigned int           n = 0;
Nick Clifton b877ba
+  unsigned int           num_sequences = table->num_sequences;
Nick Clifton b877ba
+  bfd_vma                last_high_pc;
Nick Clifton b877ba
 
Nick Clifton b877ba
   if (num_sequences == 0)
Nick Clifton b877ba
     return TRUE;
Nick Clifton b877ba
@@ -1754,7 +1765,7 @@ decode_line_info (struct comp_unit *unit
Nick Clifton b877ba
 
Nick Clifton b877ba
   if (stash->dwarf_line_size < 16)
Nick Clifton b877ba
     {
Nick Clifton b877ba
-      (*_bfd_error_handler)
Nick Clifton b877ba
+      _bfd_error_handler
Nick Clifton b877ba
 	(_("Dwarf Error: Line info section is too small (%ld)"),
Nick Clifton b877ba
 	 (long) stash->dwarf_line_size);
Nick Clifton b877ba
       bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
@@ -1783,7 +1794,8 @@ decode_line_info (struct comp_unit *unit
Nick Clifton b877ba
 
Nick Clifton b877ba
   if (lh.total_length > stash->dwarf_line_size)
Nick Clifton b877ba
     {
Nick Clifton b877ba
-      (*_bfd_error_handler)
Nick Clifton b877ba
+      _bfd_error_handler
Nick Clifton b877ba
+	/* xgettext: c-format */
Nick Clifton b877ba
 	(_("Dwarf Error: Line info data is bigger (0x%lx) than the section (0x%lx)"),
Nick Clifton b877ba
 	 (long) lh.total_length, (long) stash->dwarf_line_size);
Nick Clifton b877ba
       bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
@@ -1795,7 +1807,7 @@ decode_line_info (struct comp_unit *unit
Nick Clifton b877ba
   lh.version = read_2_bytes (abfd, line_ptr, line_end);
Nick Clifton b877ba
   if (lh.version < 2 || lh.version > 4)
Nick Clifton b877ba
     {
Nick Clifton b877ba
-      (*_bfd_error_handler)
Nick Clifton b877ba
+      _bfd_error_handler
Nick Clifton b877ba
 	(_("Dwarf Error: Unhandled .debug_line version %d."), lh.version);
Nick Clifton b877ba
       bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
       return NULL;
Nick Clifton b877ba
@@ -1804,7 +1816,7 @@ decode_line_info (struct comp_unit *unit
Nick Clifton b877ba
 
Nick Clifton b877ba
   if (line_ptr + offset_size + (lh.version >=4 ? 6 : 5) >= line_end)
Nick Clifton b877ba
     {
Nick Clifton b877ba
-      (*_bfd_error_handler)
Nick Clifton b877ba
+      _bfd_error_handler
Nick Clifton b877ba
 	(_("Dwarf Error: Ran out of room reading prologue"));
Nick Clifton b877ba
       bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
       return NULL;
Nick Clifton b877ba
@@ -1829,7 +1841,7 @@ decode_line_info (struct comp_unit *unit
Nick Clifton b877ba
 
Nick Clifton b877ba
   if (lh.maximum_ops_per_insn == 0)
Nick Clifton b877ba
     {
Nick Clifton b877ba
-      (*_bfd_error_handler)
Nick Clifton b877ba
+      _bfd_error_handler
Nick Clifton b877ba
 	(_("Dwarf Error: Invalid maximum operations per instruction."));
Nick Clifton b877ba
       bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
       return NULL;
Nick Clifton b877ba
@@ -1849,7 +1861,7 @@ decode_line_info (struct comp_unit *unit
Nick Clifton b877ba
 
Nick Clifton b877ba
   if (line_ptr + (lh.opcode_base - 1) >= line_end)
Nick Clifton b877ba
     {
Nick Clifton b877ba
-      (*_bfd_error_handler) (_("Dwarf Error: Ran out of room reading opcodes"));
Nick Clifton b877ba
+      _bfd_error_handler (_("Dwarf Error: Ran out of room reading opcodes"));
Nick Clifton b877ba
       bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
       return NULL;
Nick Clifton b877ba
     }
Nick Clifton b877ba
@@ -2036,7 +2048,7 @@ decode_line_info (struct comp_unit *unit
Nick Clifton b877ba
 		  line_ptr += exop_len - 1;
Nick Clifton b877ba
 		  break;
Nick Clifton b877ba
 		default:
Nick Clifton b877ba
-		  (*_bfd_error_handler)
Nick Clifton b877ba
+		  _bfd_error_handler
Nick Clifton b877ba
 		    (_("Dwarf Error: mangled line number section."));
Nick Clifton b877ba
 		  bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
 		line_fail:
Nick Clifton b877ba
@@ -2218,45 +2230,44 @@ fail:
Nick Clifton b877ba
 /* Read in the .debug_ranges section for future reference.  */
Nick Clifton b877ba
 
Nick Clifton b877ba
 static bfd_boolean
Nick Clifton b877ba
-read_debug_ranges (struct comp_unit *unit)
Nick Clifton b877ba
+read_debug_ranges (struct comp_unit * unit)
Nick Clifton b877ba
 {
Nick Clifton b877ba
-  struct dwarf2_debug *stash = unit->stash;
Nick Clifton b877ba
+  struct dwarf2_debug * stash = unit->stash;
Nick Clifton b877ba
+
Nick Clifton b877ba
   return read_section (unit->abfd, &stash->debug_sections[debug_ranges],
Nick Clifton b877ba
 		       stash->syms, 0,
Nick Clifton b877ba
-		       &stash->dwarf_ranges_buffer, &stash->dwarf_ranges_size);
Nick Clifton b877ba
+		       &stash->dwarf_ranges_buffer,
Nick Clifton b877ba
+		       &stash->dwarf_ranges_size);
Nick Clifton b877ba
 }
Nick Clifton b877ba
 
Nick Clifton b877ba
 /* Function table functions.  */
Nick Clifton b877ba
 
Nick Clifton b877ba
 static int
Nick Clifton b877ba
-compare_lookup_funcinfos (const void* a, const void* b)
Nick Clifton b877ba
+compare_lookup_funcinfos (const void * a, const void * b)
Nick Clifton b877ba
 {
Nick Clifton b877ba
-  const struct lookup_funcinfo *lookup1 = a;
Nick Clifton b877ba
-  const struct lookup_funcinfo *lookup2 = b;
Nick Clifton b877ba
-  int result;
Nick Clifton b877ba
+  const struct lookup_funcinfo * lookup1 = a;
Nick Clifton b877ba
+  const struct lookup_funcinfo * lookup2 = b;
Nick Clifton b877ba
 
Nick Clifton b877ba
   if (lookup1->low_addr < lookup2->low_addr)
Nick Clifton b877ba
-    result = -1;
Nick Clifton b877ba
-  else if (lookup1->low_addr > lookup2->low_addr)
Nick Clifton b877ba
-    result = 1;
Nick Clifton b877ba
-  else if (lookup1->high_addr < lookup2->high_addr)
Nick Clifton b877ba
-    result = -1;
Nick Clifton b877ba
-  else if (lookup1->high_addr > lookup1->high_addr)
Nick Clifton b877ba
-    result = 1;
Nick Clifton b877ba
-  else
Nick Clifton b877ba
-    result = 0;
Nick Clifton b877ba
+    return -1;
Nick Clifton b877ba
+  if (lookup1->low_addr > lookup2->low_addr)
Nick Clifton b877ba
+    return 1;
Nick Clifton b877ba
+  if (lookup1->high_addr < lookup2->high_addr)
Nick Clifton b877ba
+    return -1;
Nick Clifton b877ba
+  if (lookup1->high_addr > lookup2->high_addr)
Nick Clifton b877ba
+    return 1;
Nick Clifton b877ba
 
Nick Clifton b877ba
-  return result;
Nick Clifton b877ba
+  return 0;
Nick Clifton b877ba
 }
Nick Clifton b877ba
 
Nick Clifton b877ba
 static bfd_boolean
Nick Clifton b877ba
-build_lookup_funcinfo_table (struct comp_unit *unit)
Nick Clifton b877ba
+build_lookup_funcinfo_table (struct comp_unit * unit)
Nick Clifton b877ba
 {
Nick Clifton b877ba
   struct lookup_funcinfo *lookup_funcinfo_table = unit->lookup_funcinfo_table;
Nick Clifton b877ba
   unsigned int number_of_functions = unit->number_of_functions;
Nick Clifton b877ba
   struct funcinfo *each;
Nick Clifton b877ba
   struct lookup_funcinfo *entry;
Nick Clifton b877ba
-  size_t index;
Nick Clifton b877ba
+  size_t func_index;
Nick Clifton b877ba
   struct arange *range;
Nick Clifton b877ba
   bfd_vma low_addr, high_addr;
Nick Clifton b877ba
 
Nick Clifton b877ba
@@ -2270,10 +2281,10 @@ build_lookup_funcinfo_table (struct comp
Nick Clifton b877ba
     return FALSE;
Nick Clifton b877ba
 
Nick Clifton b877ba
   /* Populate the function info lookup table.  */
Nick Clifton b877ba
-  index = number_of_functions;
Nick Clifton b877ba
+  func_index = number_of_functions;
Nick Clifton b877ba
   for (each = unit->function_table; each; each = each->prev_func)
Nick Clifton b877ba
     {
Nick Clifton b877ba
-      entry = &lookup_funcinfo_table[--index];
Nick Clifton b877ba
+      entry = &lookup_funcinfo_table[--func_index];
Nick Clifton b877ba
       entry->funcinfo = each;
Nick Clifton b877ba
 
Nick Clifton b877ba
       /* Calculate the lowest and highest address for this function entry.  */
Nick Clifton b877ba
@@ -2281,30 +2292,30 @@ build_lookup_funcinfo_table (struct comp
Nick Clifton b877ba
       high_addr = entry->funcinfo->arange.high;
Nick Clifton b877ba
 
Nick Clifton b877ba
       for (range = entry->funcinfo->arange.next; range; range = range->next)
Nick Clifton b877ba
-      {
Nick Clifton b877ba
-	if (range->low < low_addr)
Nick Clifton b877ba
-	  low_addr = range->low;
Nick Clifton b877ba
-	if (range->high > high_addr)
Nick Clifton b877ba
-	  high_addr = range->high;
Nick Clifton b877ba
-      }
Nick Clifton b877ba
+	{
Nick Clifton b877ba
+	  if (range->low < low_addr)
Nick Clifton b877ba
+	    low_addr = range->low;
Nick Clifton b877ba
+	  if (range->high > high_addr)
Nick Clifton b877ba
+	    high_addr = range->high;
Nick Clifton b877ba
+	}
Nick Clifton b877ba
 
Nick Clifton b877ba
       entry->low_addr = low_addr;
Nick Clifton b877ba
       entry->high_addr = high_addr;
Nick Clifton b877ba
     }
Nick Clifton b877ba
 
Nick Clifton b877ba
-  BFD_ASSERT (index == 0);
Nick Clifton b877ba
+  BFD_ASSERT (func_index == 0);
Nick Clifton b877ba
 
Nick Clifton b877ba
   /* Sort the function by address.  */
Nick Clifton b877ba
   qsort (lookup_funcinfo_table,
Nick Clifton b877ba
-	number_of_functions,
Nick Clifton b877ba
-	sizeof (struct lookup_funcinfo),
Nick Clifton b877ba
-	compare_lookup_funcinfos);
Nick Clifton b877ba
+	 number_of_functions,
Nick Clifton b877ba
+	 sizeof (struct lookup_funcinfo),
Nick Clifton b877ba
+	 compare_lookup_funcinfos);
Nick Clifton b877ba
 
Nick Clifton b877ba
   /* Calculate the high watermark for each function in the lookup table.  */
Nick Clifton b877ba
   high_addr = lookup_funcinfo_table[0].high_addr;
Nick Clifton b877ba
-  for (index = 1; index < number_of_functions; index++)
Nick Clifton b877ba
+  for (func_index = 1; func_index < number_of_functions; func_index++)
Nick Clifton b877ba
     {
Nick Clifton b877ba
-      entry = &lookup_funcinfo_table[index];
Nick Clifton b877ba
+      entry = &lookup_funcinfo_table[func_index];
Nick Clifton b877ba
       if (entry->high_addr > high_addr)
Nick Clifton b877ba
 	high_addr = entry->high_addr;
Nick Clifton b877ba
       else
Nick Clifton b877ba
@@ -2333,9 +2344,15 @@ lookup_address_in_function_table (struct
Nick Clifton b877ba
   bfd_size_type low, high, mid, first;
Nick Clifton b877ba
   struct arange *arange;
Nick Clifton b877ba
 
Nick Clifton b877ba
+  if (number_of_functions == 0)
Nick Clifton b877ba
+    return FALSE;
Nick Clifton b877ba
+
Nick Clifton b877ba
   if (!build_lookup_funcinfo_table (unit))
Nick Clifton b877ba
     return FALSE;
Nick Clifton b877ba
 
Nick Clifton b877ba
+  if (unit->lookup_funcinfo_table[number_of_functions - 1].high_addr < addr)
Nick Clifton b877ba
+    return FALSE;
Nick Clifton b877ba
+  
Nick Clifton b877ba
   /* Find the first function in the lookup table which may contain the
Nick Clifton b877ba
      specified address.  */
Nick Clifton b877ba
   low = 0;
Nick Clifton b877ba
@@ -2474,8 +2491,8 @@ lookup_symbol_in_variable_table (struct
Nick Clifton b877ba
       *linenumber_ptr = each->line;
Nick Clifton b877ba
       return TRUE;
Nick Clifton b877ba
     }
Nick Clifton b877ba
-  else
Nick Clifton b877ba
-    return FALSE;
Nick Clifton b877ba
+
Nick Clifton b877ba
+  return FALSE;
Nick Clifton b877ba
 }
Nick Clifton b877ba
 
Nick Clifton b877ba
 static char *
Nick Clifton b877ba
@@ -2531,7 +2548,7 @@ find_abstract_instance_name (struct comp
Nick Clifton b877ba
       info_ptr = read_alt_indirect_ref (unit, die_ref);
Nick Clifton b877ba
       if (info_ptr == NULL)
Nick Clifton b877ba
 	{
Nick Clifton b877ba
-	  (*_bfd_error_handler)
Nick Clifton b877ba
+	  _bfd_error_handler
Nick Clifton b877ba
 	    (_("Dwarf Error: Unable to read alt ref %u."), die_ref);
Nick Clifton b877ba
 	  bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
 	  return NULL;
Nick Clifton b877ba
@@ -2555,7 +2572,7 @@ find_abstract_instance_name (struct comp
Nick Clifton b877ba
       abbrev = lookup_abbrev (abbrev_number, unit->abbrevs);
Nick Clifton b877ba
       if (! abbrev)
Nick Clifton b877ba
 	{
Nick Clifton b877ba
-	  (*_bfd_error_handler)
Nick Clifton b877ba
+	  _bfd_error_handler
Nick Clifton b877ba
 	    (_("Dwarf Error: Could not find abbrev number %u."), abbrev_number);
Nick Clifton b877ba
 	  bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
 	}
Nick Clifton b877ba
@@ -2699,7 +2716,7 @@ scan_unit_for_symbols (struct comp_unit
Nick Clifton b877ba
       abbrev = lookup_abbrev (abbrev_number,unit->abbrevs);
Nick Clifton b877ba
       if (! abbrev)
Nick Clifton b877ba
 	{
Nick Clifton b877ba
-	  (*_bfd_error_handler)
Nick Clifton b877ba
+	  _bfd_error_handler
Nick Clifton b877ba
 	    (_("Dwarf Error: Could not find abbrev number %u."),
Nick Clifton b877ba
 	     abbrev_number);
Nick Clifton b877ba
 	  bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
@@ -2969,7 +2986,7 @@ parse_comp_unit (struct dwarf2_debug *st
Nick Clifton b877ba
 	 an error, just return a NULL.  */
Nick Clifton b877ba
       if (version)
Nick Clifton b877ba
 	{
Nick Clifton b877ba
-	  (*_bfd_error_handler)
Nick Clifton b877ba
+	  _bfd_error_handler
Nick Clifton b877ba
 	    (_("Dwarf Error: found dwarf version '%u', this reader"
Nick Clifton b877ba
 	       " only handles version 2, 3 and 4 information."), version);
Nick Clifton b877ba
 	  bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
@@ -2979,7 +2996,8 @@ parse_comp_unit (struct dwarf2_debug *st
Nick Clifton b877ba
 
Nick Clifton b877ba
   if (addr_size > sizeof (bfd_vma))
Nick Clifton b877ba
     {
Nick Clifton b877ba
-      (*_bfd_error_handler)
Nick Clifton b877ba
+      _bfd_error_handler
Nick Clifton b877ba
+	/* xgettext: c-format */
Nick Clifton b877ba
 	(_("Dwarf Error: found address size '%u', this reader"
Nick Clifton b877ba
 	   " can not handle sizes greater than '%u'."),
Nick Clifton b877ba
 	 addr_size,
Nick Clifton b877ba
@@ -2990,7 +3008,7 @@ parse_comp_unit (struct dwarf2_debug *st
Nick Clifton b877ba
 
Nick Clifton b877ba
   if (addr_size != 2 && addr_size != 4 && addr_size != 8)
Nick Clifton b877ba
     {
Nick Clifton b877ba
-      (*_bfd_error_handler)
Nick Clifton b877ba
+      _bfd_error_handler
Nick Clifton b877ba
 	("Dwarf Error: found address size '%u', this reader"
Nick Clifton b877ba
 	 " can only handle address sizes '2', '4' and '8'.", addr_size);
Nick Clifton b877ba
       bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
@@ -3016,8 +3034,8 @@ parse_comp_unit (struct dwarf2_debug *st
Nick Clifton b877ba
   abbrev = lookup_abbrev (abbrev_number, abbrevs);
Nick Clifton b877ba
   if (! abbrev)
Nick Clifton b877ba
     {
Nick Clifton b877ba
-      (*_bfd_error_handler) (_("Dwarf Error: Could not find abbrev number %u."),
Nick Clifton b877ba
-			     abbrev_number);
Nick Clifton b877ba
+      _bfd_error_handler (_("Dwarf Error: Could not find abbrev number %u."),
Nick Clifton b877ba
+			  abbrev_number);
Nick Clifton b877ba
       bfd_set_error (bfd_error_bad_value);
Nick Clifton b877ba
       return NULL;
Nick Clifton b877ba
     }
Nick Clifton b877ba
@@ -3059,7 +3077,7 @@ parse_comp_unit (struct dwarf2_debug *st
Nick Clifton b877ba
 	  low_pc = attr.u.val;
Nick Clifton b877ba
 	  /* If the compilation unit DIE has a DW_AT_low_pc attribute,
Nick Clifton b877ba
 	     this is the base address to use when reading location
Nick Clifton b877ba
-	     lists or range lists. */
Nick Clifton b877ba
+	     lists or range lists.  */
Nick Clifton b877ba
 	  if (abbrev->tag == DW_TAG_compile_unit)
Nick Clifton b877ba
 	    unit->base_address = low_pc;
Nick Clifton b877ba
 	  break;
Nick Clifton b877ba
@@ -3081,7 +3099,7 @@ parse_comp_unit (struct dwarf2_debug *st
Nick Clifton b877ba
 	    /* PR 17512: file: 1fe726be.  */
Nick Clifton b877ba
 	    if (! is_str_attr (attr.form))
Nick Clifton b877ba
 	      {
Nick Clifton b877ba
-		(*_bfd_error_handler)
Nick Clifton b877ba
+		_bfd_error_handler
Nick Clifton b877ba
 		  (_("Dwarf Error: DW_AT_comp_dir attribute encountered with a non-string form."));
Nick Clifton b877ba
 		comp_dir = NULL;
Nick Clifton b877ba
 	      }
Nick Clifton b877ba
@@ -3133,6 +3151,11 @@ comp_unit_contains_address (struct comp_
Nick Clifton b877ba
   if (unit->error)
Nick Clifton b877ba
     return FALSE;
Nick Clifton b877ba
 
Nick Clifton b877ba
+  if (unit->minmax.high < addr || unit->minmax.low > addr)
Nick Clifton b877ba
+    return FALSE;
Nick Clifton b877ba
+
Nick Clifton b877ba
+  /* We know that the address *might* be contained within this comp
Nick Clifton b877ba
+     unit, but we cannot be sure until we check the specific ranges.  */
Nick Clifton b877ba
   arange = &unit->arange;
Nick Clifton b877ba
   do
Nick Clifton b877ba
     {
Nick Clifton b877ba
@@ -3330,7 +3353,7 @@ comp_unit_hash_info (struct dwarf2_debug
Nick Clifton b877ba
        each_func && okay;
Nick Clifton b877ba
        each_func = each_func->prev_func)
Nick Clifton b877ba
     {
Nick Clifton b877ba
-      /* Skip nameless functions. */
Nick Clifton b877ba
+      /* Skip nameless functions.  */
Nick Clifton b877ba
       if (each_func->name)
Nick Clifton b877ba
 	/* There is no need to copy name string into hash table as
Nick Clifton b877ba
 	   name string is either in the dwarf string buffer or
Nick Clifton b877ba
@@ -3712,7 +3735,7 @@ stash_maybe_update_info_hash_tables (str
Nick Clifton b877ba
   return TRUE;
Nick Clifton b877ba
 }
Nick Clifton b877ba
 
Nick Clifton b877ba
-/* Check consistency of info hash tables.  This is for debugging only. */
Nick Clifton b877ba
+/* Check consistency of info hash tables.  This is for debugging only.  */
Nick Clifton b877ba
 
Nick Clifton b877ba
 static void ATTRIBUTE_UNUSED
Nick Clifton b877ba
 stash_verify_info_hash_table (struct dwarf2_debug *stash)
Nick Clifton b877ba
@@ -4146,7 +4169,7 @@ _bfd_dwarf2_find_nearest_line (bfd *abfd
Nick Clifton b877ba
 	stash_maybe_enable_info_hash_tables (abfd, stash);
Nick Clifton b877ba
 
Nick Clifton b877ba
       /* Keep info hash table up to date if they are available.  Note that we
Nick Clifton b877ba
-	 may disable the hash tables if there is any error duing update. */
Nick Clifton b877ba
+	 may disable the hash tables if there is any error duing update.  */
Nick Clifton b877ba
       if (stash->info_hash_status == STASH_INFO_HASH_ON)
Nick Clifton b877ba
 	stash_maybe_update_info_hash_tables (stash);
Nick Clifton b877ba
 
Nick Clifton b877ba
diff -rup binutils.orig/binutils/objdump.c binutils-2.27/binutils/objdump.c
Nick Clifton b877ba
--- binutils.orig/binutils/objdump.c	2017-01-09 10:55:15.771433447 +0000
Nick Clifton b877ba
+++ binutils-2.27/binutils/objdump.c	2017-01-09 13:36:45.936970981 +0000
Nick Clifton b877ba
@@ -3603,7 +3603,7 @@ display_any_bfd (bfd *file, int level)
Nick Clifton b877ba
 }
Nick Clifton b877ba
 
Nick Clifton b877ba
 static void
Nick Clifton b877ba
-display_file (char *filename, char *target)
Nick Clifton b877ba
+display_file (char *filename, char *target, bfd_boolean last_file)
Nick Clifton b877ba
 {
Nick Clifton b877ba
   bfd *file;
Nick Clifton b877ba
 
Nick Clifton b877ba
@@ -3622,7 +3622,14 @@ display_file (char *filename, char *targ
Nick Clifton b877ba
 
Nick Clifton b877ba
   display_any_bfd (file, 0);
Nick Clifton b877ba
 
Nick Clifton b877ba
-  bfd_close (file);
Nick Clifton b877ba
+  /* This is an optimization to improve the speed of objdump, especially when
Nick Clifton b877ba
+     dumping a file with lots of associated debug informatiom.  Closing such
Nick Clifton b877ba
+     a file can take a non-trivial amount of time as there are lots of lists
Nick Clifton b877ba
+     to walk and buffers to free.  This is only really necessary however if
Nick Clifton b877ba
+     we are about to load another file.  Otherwise, if we are about to exit,
Nick Clifton b877ba
+     then we can save (a lot of) time by not bothering to do any tidying up.  */
Nick Clifton b877ba
+  if (! last_file)
Nick Clifton b877ba
+    bfd_close (file);
Nick Clifton b877ba
 }
Nick Clifton b877ba
 
Nick Clifton b877ba
 int
Nick Clifton b877ba
@@ -3900,10 +3907,13 @@ main (int argc, char **argv)
Nick Clifton b877ba
   else
Nick Clifton b877ba
     {
Nick Clifton b877ba
       if (optind == argc)
Nick Clifton b877ba
-	display_file ("a.out", target);
Nick Clifton b877ba
+	display_file ("a.out", target, TRUE);
Nick Clifton b877ba
       else
Nick Clifton b877ba
 	for (; optind < argc;)
Nick Clifton b877ba
-	  display_file (argv[optind++], target);
Nick Clifton b877ba
+	  {
Nick Clifton b877ba
+	    display_file (argv[optind], target, optind == argc - 1);
Nick Clifton b877ba
+	    optind++;
Nick Clifton b877ba
+	  }
Nick Clifton b877ba
     }
Nick Clifton b877ba
 
Nick Clifton b877ba
   free_only_list ();