Ian Kent 890377
autofs-5.0.6 - fix ipv6 name for lookup fix
Ian Kent 890377
Ian Kent 890377
From: Ian Kent <ikent@redhat.com>
Ian Kent 890377
Ian Kent 890377
Fix an error in the recent ipv6 name for lookup patch.
Ian Kent 890377
Ian Kent 890377
Reported by Leonardo Chiquitto who provided a patch to resolve the
Ian Kent 890377
problem. The patch below is a slightly modified version of his patch.
Ian Kent 890377
---
Ian Kent 890377
Ian Kent 890377
 CHANGELOG            |    4 ++++
Ian Kent 890377
 modules/replicated.c |   13 ++++++++-----
Ian Kent 890377
 2 files changed, 12 insertions(+), 5 deletions(-)
Ian Kent 890377
Ian Kent 890377
Ian Kent 890377
diff --git a/CHANGELOG b/CHANGELOG
Ian Kent 890377
index 849a38c..e5dfa83 100644
Ian Kent 890377
--- a/CHANGELOG
Ian Kent 890377
+++ b/CHANGELOG
Ian Kent 890377
@@ -1,3 +1,7 @@
Ian Kent 890377
+??/??/20?? autofs-5.0.7
Ian Kent 890377
+=======================
Ian Kent 890377
+- fix ipv6 name for lookup fix.
Ian Kent 890377
+
Ian Kent 890377
 28/06/2011 autofs-5.0.6
Ian Kent 890377
 -----------------------
Ian Kent 890377
 - fix included map read fail handling.
Ian Kent 890377
diff --git a/modules/replicated.c b/modules/replicated.c
Ian Kent 890377
index 7f2b892..a10a817 100644
Ian Kent 890377
--- a/modules/replicated.c
Ian Kent 890377
+++ b/modules/replicated.c
Ian Kent 890377
@@ -1111,7 +1111,8 @@ static int add_host_addrs(struct host **list, const char *host,
Ian Kent 890377
 			  unsigned int weight, unsigned int options)
Ian Kent 890377
 {
Ian Kent 890377
 	struct addrinfo hints, *ni, *this;
Ian Kent 890377
-	char *name = strdup(host);
Ian Kent 890377
+	char *n_ptr;
Ian Kent 890377
+	char *name = n_ptr = strdup(host);
Ian Kent 890377
 	int len;
Ian Kent 890377
 	char buf[MAX_ERR_BUF];
Ian Kent 890377
 	int rr = 0;
Ian Kent 890377
@@ -1125,15 +1126,17 @@ static int add_host_addrs(struct host **list, const char *host,
Ian Kent 890377
 	}
Ian Kent 890377
 	len = strlen(name);
Ian Kent 890377
 
Ian Kent 890377
-	if (name[0] == '[' && name[--len] == ']')
Ian Kent 890377
+	if (name[0] == '[' && name[--len] == ']') {
Ian Kent 890377
 		name[len] = '\0';
Ian Kent 890377
+		name++;
Ian Kent 890377
+	}
Ian Kent 890377
 
Ian Kent 890377
 	memset(&hints, 0, sizeof(hints));
Ian Kent 890377
 	hints.ai_flags = AI_NUMERICHOST;
Ian Kent 890377
 	hints.ai_family = AF_UNSPEC;
Ian Kent 890377
 	hints.ai_socktype = SOCK_DGRAM;
Ian Kent 890377
 
Ian Kent 890377
-	ret = getaddrinfo(name + 1, NULL, &hints, &ni);
Ian Kent 890377
+	ret = getaddrinfo(name, NULL, &hints, &ni);
Ian Kent 890377
 	if (ret)
Ian Kent 890377
 		goto try_name;
Ian Kent 890377
 
Ian Kent 890377
@@ -1153,7 +1156,7 @@ try_name:
Ian Kent 890377
 	hints.ai_family = AF_UNSPEC;
Ian Kent 890377
 	hints.ai_socktype = SOCK_DGRAM;
Ian Kent 890377
 
Ian Kent 890377
-	ret = getaddrinfo(name + 1, NULL, &hints, &ni);
Ian Kent 890377
+	ret = getaddrinfo(name, NULL, &hints, &ni);
Ian Kent 890377
 	if (ret) {
Ian Kent 890377
 		error(LOGOPT_ANY, "hostname lookup failed: %s",
Ian Kent 890377
 		      gai_strerror(ret));
Ian Kent 890377
@@ -1172,7 +1175,7 @@ try_name:
Ian Kent 890377
 	}
Ian Kent 890377
 	freeaddrinfo(ni);
Ian Kent 890377
 done:
Ian Kent 890377
-	free(name);
Ian Kent 890377
+	free(n_ptr);
Ian Kent 890377
 	return ret;
Ian Kent 890377
 }
Ian Kent 890377