Ian Kent 597437
autofs-5.0.4 - zero s_magic is valid
Ian Kent 597437
Ian Kent 597437
From: Ian Kent <raven@themaw.net>
Ian Kent 597437
Ian Kent 597437
When checking the super magic using the mount control ioctl
Ian Kent 597437
re-implementation an incorrect assumption is made that s_magic
Ian Kent 597437
field in the super block will not be zero.
Ian Kent 597437
---
Ian Kent 597437
Ian Kent 597437
 CHANGELOG           |    1 +
Ian Kent 597437
 lib/dev-ioctl-lib.c |   10 ++++------
Ian Kent 597437
 2 files changed, 5 insertions(+), 6 deletions(-)
Ian Kent 597437
Ian Kent 597437
Ian Kent 597437
diff --git a/CHANGELOG b/CHANGELOG
Ian Kent 597437
index 5f1cf7f..4ed80e0 100644
Ian Kent 597437
--- a/CHANGELOG
Ian Kent 597437
+++ b/CHANGELOG
Ian Kent 597437
@@ -39,6 +39,7 @@
Ian Kent 597437
 - fix memory leak reading master map.
Ian Kent 597437
 - fix st_remove_tasks() locking.
Ian Kent 597437
 - reset flex scanner when setting buffer.
Ian Kent 597437
+- zero s_magic is valid.
Ian Kent 597437
 
Ian Kent 597437
 4/11/2008 autofs-5.0.4
Ian Kent 597437
 -----------------------
Ian Kent 597437
diff --git a/lib/dev-ioctl-lib.c b/lib/dev-ioctl-lib.c
Ian Kent 597437
index 7c8c433..a034a3d 100644
Ian Kent 597437
--- a/lib/dev-ioctl-lib.c
Ian Kent 597437
+++ b/lib/dev-ioctl-lib.c
Ian Kent 597437
@@ -764,12 +764,10 @@ static int dev_ioctl_ismountpoint(unsigned int logopt,
Ian Kent 597437
 	if (err) {
Ian Kent 597437
 		*mountpoint = DEV_IOCTL_IS_MOUNTED;
Ian Kent 597437
 
Ian Kent 597437
-		if (param->ismountpoint.out.magic) {
Ian Kent 597437
-			if (param->ismountpoint.out.magic == AUTOFS_SUPER_MAGIC)
Ian Kent 597437
-				*mountpoint |= DEV_IOCTL_IS_AUTOFS;
Ian Kent 597437
-			else
Ian Kent 597437
-				*mountpoint |= DEV_IOCTL_IS_OTHER;
Ian Kent 597437
-		}
Ian Kent 597437
+		if (param->ismountpoint.out.magic == AUTOFS_SUPER_MAGIC)
Ian Kent 597437
+			*mountpoint |= DEV_IOCTL_IS_AUTOFS;
Ian Kent 597437
+		else
Ian Kent 597437
+			*mountpoint |= DEV_IOCTL_IS_OTHER;
Ian Kent 597437
 	}
Ian Kent 597437
 
Ian Kent 597437
 	free_dev_ioctl_path(param);