b484bb
From 612010470f4217b447b5ed5fe964fce1d895566a Mon Sep 17 00:00:00 2001
b484bb
From: =?UTF-8?q?Rapha=C3=ABl=20Pinson?= <raphael.pinson@camptocamp.com>
b484bb
Date: Tue, 12 Nov 2019 13:33:26 +0100
b484bb
Subject: [PATCH] Rsyslog: support multiple actions in filters and selectors
b484bb
 (#653)
b484bb
b484bb
(cherry picked from commit 5181105bae84dc7819a00886f068ad0bb4e6d05a)
b484bb
---
b484bb
 lenses/rsyslog.aug            | 11 ++++++++---
b484bb
 lenses/tests/test_rsyslog.aug | 37 +++++++++++++++++++++++++++++++++++
b484bb
 2 files changed, 45 insertions(+), 3 deletions(-)
b484bb
b484bb
diff --git a/lenses/rsyslog.aug b/lenses/rsyslog.aug
b484bb
index 7b9f7dc9..29ff9b10 100644
b484bb
--- a/lenses/rsyslog.aug
b484bb
+++ b/lenses/rsyslog.aug
b484bb
@@ -65,11 +65,17 @@ let hostname = [ label "hostname" .
b484bb
       ( Syslog.plus | [ Build.xchgs "-" "reverse" ] ) .
b484bb
       Syslog.hostnames . Util.eol .  Syslog.entries ]
b484bb
 
b484bb
+(* View: actions *)
b484bb
+let actions =
b484bb
+     let prop_act  = [ label "action" . action ]
b484bb
+  in let act_sep = del /[ \t]*\n&[ \t]*/ "\n& "
b484bb
+  in Build.opt_list prop_act act_sep
b484bb
+
b484bb
 (* View: entry
b484bb
    An entry contains selectors and an action
b484bb
 *)
b484bb
 let entry = [ label "entry" . Syslog.selectors . Syslog.sep_tab .
b484bb
-              [ label "action" . action ] . Util.eol ]
b484bb
+              actions . Util.eol ]
b484bb
 
b484bb
 (* View: prop_filter
b484bb
    Parses property-based filters, which start with ":" and the property name *)
b484bb
@@ -78,9 +84,8 @@ let prop_filter =
b484bb
   in let prop_name = [ Util.del_str ":" . label "property" . store Rx.word ]
b484bb
   in let prop_oper = [ label "operation" . store /[A-Za-z!-]+/ ]
b484bb
   in let prop_val  = [ label "value" . Quote.do_dquote (store /[^\n"]*/) ]
b484bb
-  in let prop_act  = [ label "action" . action ]
b484bb
   in [ label "filter" . prop_name . sep . prop_oper . sep . prop_val .
b484bb
-       Sep.space . prop_act . Util.eol ]
b484bb
+       Sep.space . actions . Util.eol ]
b484bb
 
b484bb
 let entries = ( Syslog.empty | Util.comment | entry | macro | config_object | prop_filter )*
b484bb
 
b484bb
diff --git a/lenses/tests/test_rsyslog.aug b/lenses/tests/test_rsyslog.aug
b484bb
index 9011a2b3..e83613a2 100644
b484bb
--- a/lenses/tests/test_rsyslog.aug
b484bb
+++ b/lenses/tests/test_rsyslog.aug
b484bb
@@ -222,3 +222,40 @@ test Rsyslog.lns get "*.* ?DynamicFile\n" =
b484bb
       { "dynamic" = "DynamicFile" }
b484bb
     }
b484bb
   }
b484bb
+
b484bb
+(* Multiple actions in filters and selectors *)
b484bb
+test Rsyslog.lns get ":msg, startswith, \"iptables:\" -/var/log/iptables.log
b484bb
+& ~
b484bb
+# Save boot messages also to boot.log
b484bb
+local7.*                                                /var/log/boot.log
b484bb
+local3.err                                              /var/log/nfsen/nfsenlog
b484bb
+& /var/log/also.log
b484bb
+\n" =
b484bb
+  { "filter"
b484bb
+    { "property" = "msg" }
b484bb
+    { "operation" = "startswith" }
b484bb
+    { "value" = "iptables:" }
b484bb
+    { "action"
b484bb
+      { "no_sync" }
b484bb
+      { "file" = "/var/log/iptables.log" } }
b484bb
+    { "action"
b484bb
+      { "discard" } }
b484bb
+  }
b484bb
+  { "#comment" = "Save boot messages also to boot.log" }
b484bb
+  { "entry"
b484bb
+    { "selector"
b484bb
+      { "facility" = "local7" }
b484bb
+      { "level" = "*" } }
b484bb
+    { "action"
b484bb
+      { "file" = "/var/log/boot.log" } }
b484bb
+  }
b484bb
+  { "entry"
b484bb
+    { "selector"
b484bb
+      { "facility" = "local3" }
b484bb
+      { "level" = "err" } }
b484bb
+    { "action"
b484bb
+      { "file" = "/var/log/nfsen/nfsenlog" } }
b484bb
+    { "action"
b484bb
+      { "file" = "/var/log/also.log" } } }
b484bb
+  {  }
b484bb
+
b484bb
-- 
d7e0d2
2.24.1
b484bb