Martin Kolman 15b08d
From 544a83ef63454e91cfea835b74bd76310d8774cc Mon Sep 17 00:00:00 2001
Martin Kolman 15b08d
From: Vendula Poncova <vponcova@redhat.com>
Martin Kolman 15b08d
Date: Fri, 9 Mar 2018 11:16:07 +0100
Martin Kolman 15b08d
Subject: [PATCH] User module should parse only rootpw for now (#1553488)
Martin Kolman 15b08d
Martin Kolman 15b08d
User module doesn't define the UserData and the GroupData in its
Martin Kolman 15b08d
specification, so Anaconda fails when the kickstart file specifies
Martin Kolman 15b08d
a user or a group. User module should parse only rootpw for now.
Martin Kolman 15b08d
Martin Kolman 15b08d
Resolves: rhbz#1553488
Martin Kolman 15b08d
---
Martin Kolman 15b08d
 pyanaconda/modules/user/kickstart.py       | 6 +-----
Martin Kolman 15b08d
 tests/pyanaconda_tests/module_user_test.py | 2 +-
Martin Kolman 15b08d
 2 files changed, 2 insertions(+), 6 deletions(-)
Martin Kolman 15b08d
Martin Kolman 15b08d
diff --git a/pyanaconda/modules/user/kickstart.py b/pyanaconda/modules/user/kickstart.py
Martin Kolman 15b08d
index 0a6cd66c5..5a78e8cd2 100644
Martin Kolman 15b08d
--- a/pyanaconda/modules/user/kickstart.py
Martin Kolman 15b08d
+++ b/pyanaconda/modules/user/kickstart.py
Martin Kolman 15b08d
@@ -17,9 +17,7 @@
Martin Kolman 15b08d
 # License and may only be used or replicated with the express permission of
Martin Kolman 15b08d
 # Red Hat, Inc.
Martin Kolman 15b08d
 #
Martin Kolman 15b08d
-from pykickstart.commands.user import F24_User
Martin Kolman 15b08d
 from pykickstart.commands.rootpw import F18_RootPw
Martin Kolman 15b08d
-from pykickstart.commands.group import F12_Group
Martin Kolman 15b08d
 from pykickstart.version import F28
Martin Kolman 15b08d
 from pyanaconda.core.kickstart import KickstartSpecification
Martin Kolman 15b08d
 
Martin Kolman 15b08d
@@ -28,7 +26,5 @@ class UserKickstartSpecification(KickstartSpecification):
Martin Kolman 15b08d
 
Martin Kolman 15b08d
     version = F28
Martin Kolman 15b08d
     commands = {
Martin Kolman 15b08d
-        "rootpw": F18_RootPw,
Martin Kolman 15b08d
-        "user": F24_User,
Martin Kolman 15b08d
-        "group": F12_Group,
Martin Kolman 15b08d
+        "rootpw": F18_RootPw
Martin Kolman 15b08d
     }
Martin Kolman 15b08d
diff --git a/tests/pyanaconda_tests/module_user_test.py b/tests/pyanaconda_tests/module_user_test.py
Martin Kolman 15b08d
index e67cd3504..6ea81ada4 100644
Martin Kolman 15b08d
--- a/tests/pyanaconda_tests/module_user_test.py
Martin Kolman 15b08d
+++ b/tests/pyanaconda_tests/module_user_test.py
Martin Kolman 15b08d
@@ -40,7 +40,7 @@ class UserInterfaceTestCase(unittest.TestCase):
Martin Kolman 15b08d
 
Martin Kolman 15b08d
     def kickstart_properties_test(self):
Martin Kolman 15b08d
         """Test kickstart properties."""
Martin Kolman 15b08d
-        self.assertEqual(self.user_interface.KickstartCommands, ["rootpw", "user", "group"])
Martin Kolman 15b08d
+        self.assertEqual(self.user_interface.KickstartCommands, ["rootpw"])
Martin Kolman 15b08d
         self.assertEqual(self.user_interface.KickstartSections, [])
Martin Kolman 15b08d
         self.assertEqual(self.user_interface.KickstartAddons, [])
Martin Kolman 15b08d
         self.callback.assert_not_called()
Martin Kolman 15b08d
-- 
Martin Kolman 15b08d
2.14.3
Martin Kolman 15b08d