Jan Grulich d585b4
From 1a175067dfeec339ac77cbb12f23abc858f8f4bb Mon Sep 17 00:00:00 2001
Jan Grulich d585b4
From: Jan Grulich <jgrulich@redhat.com>
Jan Grulich d585b4
Date: Thu, 30 Jun 2016 11:28:00 +0200
Jan Grulich d585b4
Subject: Attempt to fix missing menubar issue for QtCreator
Jan Grulich d585b4
Jan Grulich d585b4
It shouldn't be necessary to set MenuBar size, as height should be already set by MenuBarItem and setting
Jan Grulich d585b4
width to 30px doesn't make much sense as it will be always wider
Jan Grulich d585b4
Jan Grulich 9d7bde
diff --git a/src/style/adwaita.cpp b/src/style/adwaita.cpp
Jan Grulich d585b4
index f751d50..9c719a0 100644
Jan Grulich 9d7bde
--- a/src/style/adwaita.cpp
Jan Grulich 9d7bde
+++ b/src/style/adwaita.cpp
Jan Grulich d585b4
@@ -1670,14 +1670,20 @@ QSize Adwaita::sizeFromContents(QStyle::ContentsType ct, const QStyleOption* opt
Jan Grulich d585b4
         }
Jan Grulich d585b4
         case CT_MenuBarItem: {
Jan Grulich d585b4
             //const QStyleOptionMenuItem *miopt = qstyleoption_cast<const QStyleOptionMenuItem*>(opt);
Jan Grulich d585b4
-            return QSize(QCommonStyle::sizeFromContents(ct, opt, contentsSize, widget).width() + 16, 30);
Jan Grulich d585b4
+            return QCommonStyle::sizeFromContents(ct, opt, contentsSize, widget) + QSize(16, 8);
Jan Grulich d585b4
         }
Jan Grulich 9d7bde
         case CT_MenuItem: {
Jan Grulich 9d7bde
             return QCommonStyle::sizeFromContents(ct, opt, contentsSize, widget) + QSize(24, 0);
Jan Grulich 9d7bde
         }
Jan Grulich 9d7bde
+
Jan Grulich 9d7bde
+        // FIXME: is it necessary to set MenuBar size? Height should be already set by MenuBarItem to 30px and setting
Jan Grulich 9d7bde
+        // width to 30px doesn't really make sense to me. Resolves: https://github.com/MartinBriza/adwaita-qt/issues/34
Jan Grulich 9d7bde
+
Jan Grulich 9d7bde
+        /*
Jan Grulich 9d7bde
         case CT_MenuBar: {
Jan Grulich 9d7bde
             return QSize(30, 30);
Jan Grulich 9d7bde
         }
Jan Grulich 9d7bde
+        */
Jan Grulich 9d7bde
         case CT_ComboBox: {
Jan Grulich 9d7bde
             return QCommonStyle::sizeFromContents(ct, opt, contentsSize, widget) + QSize(4, 6);
Jan Grulich 9d7bde
         }