751739
From b4f85d66280affcb52e998661f782c2ab4f806a7 Mon Sep 17 00:00:00 2001
751739
From: Ray Strode <rstrode@redhat.com>
751739
Date: Thu, 9 May 2019 14:58:34 -0400
751739
Subject: [PATCH] data: don't send change updates for login-history
751739
751739
The login-history property of user objects can be quite large.
751739
If wtmp is changed frequently, that can lead to memory fragmentation
751739
in clients.
751739
751739
Furthermore, most clients never check login-history, so it's
751739
wasted memory and wasted cpu.
751739
751739
This commit disables change notification for that property.  If
751739
a client really needs to get updates, they can manually refresh
751739
their cache when appropriate.
751739
---
751739
 data/org.freedesktop.Accounts.User.xml | 1 +
751739
 1 file changed, 1 insertion(+)
751739
751739
diff --git a/data/org.freedesktop.Accounts.User.xml b/data/org.freedesktop.Accounts.User.xml
751739
index 8d3fe1c..3b839a3 100644
751739
--- a/data/org.freedesktop.Accounts.User.xml
751739
+++ b/data/org.freedesktop.Accounts.User.xml
751739
@@ -785,60 +785,61 @@
751739
     <doc:doc>
751739
       <doc:description>
751739
         <doc:para>
751739
           The users location.
751739
         </doc:para>
751739
       </doc:description>
751739
     </doc:doc>
751739
   </property>
751739
 
751739
   <property name="LoginFrequency" type="t" access="read">
751739
     <doc:doc>
751739
       <doc:description>
751739
         <doc:para>
751739
           How often the user has logged in.
751739
         </doc:para>
751739
       </doc:description>
751739
     </doc:doc>
751739
   </property>
751739
 
751739
   <property name="LoginTime" type="x" access="read">
751739
     <doc:doc>
751739
       <doc:description>
751739
         <doc:para>
751739
           The last login time.
751739
         </doc:para>
751739
       </doc:description>
751739
     </doc:doc>
751739
   </property>
751739
 
751739
   <property name="LoginHistory" type="a(xxa{sv})" access="read">
751739
+    <annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal" value="false"/>
751739
     <doc:doc>
751739
       <doc:description>
751739
         <doc:para>
751739
           The login history for this user.
751739
           Each entry in the array represents a login session. The first two
751739
           members are the login time and logout time, as timestamps (seconds since the epoch). If the session is still running, the logout time
751739
           is 0.
751739
         </doc:para>
751739
         <doc:para>
751739
           The a{sv} member is a dictionary containing additional information
751739
           about the session. Possible members include 'type' (with values like ':0', 'tty0', 'pts/0' etc).
751739
         </doc:para>
751739
       </doc:description>
751739
     </doc:doc>
751739
   </property>
751739
 
751739
   <property name="IconFile" type="s" access="read">
751739
     <doc:doc>
751739
       <doc:description>
751739
         <doc:para>
751739
            The filename of a png file containing the users icon.
751739
         </doc:para>
751739
       </doc:description>
751739
     </doc:doc>
751739
   </property>
751739
 
751739
   <property name="Saved" type="b" access="read">
751739
     <doc:doc>
751739
       <doc:description>
751739
         <doc:para>
751739
-- 
751739
2.21.0
751739