30d571
From f982995841607f06faaa055740310e0520c07c67 Mon Sep 17 00:00:00 2001
30d571
From: Jakub Filak <jfilak@redhat.com>
30d571
Date: Wed, 30 Sep 2015 12:24:32 +0200
30d571
Subject: [PATCH] ccpp: save abrt core files only to new files
30d571
30d571
Prior this commit abrt-hook-ccpp saved a core file generated by a
30d571
process running a program whose name starts with "abrt" in
30d571
DUMP_LOCATION/$(basename program)-coredump. If the file was a symlink,
30d571
the hook followed and wrote core file to the symlink's target.
30d571
30d571
This commit addresses CVE-2015-5287
30d571
Related: #1262252
30d571
30d571
Signed-off-by: Jakub Filak <jfilak@redhat.com>
30d571
---
30d571
 src/hooks/abrt-hook-ccpp.c | 3 ++-
30d571
 1 file changed, 2 insertions(+), 1 deletion(-)
30d571
30d571
diff --git a/src/hooks/abrt-hook-ccpp.c b/src/hooks/abrt-hook-ccpp.c
30d571
index 7a19cc2..9648b16 100644
30d571
--- a/src/hooks/abrt-hook-ccpp.c
30d571
+++ b/src/hooks/abrt-hook-ccpp.c
30d571
@@ -857,7 +857,8 @@ int main(int argc, char** argv)
30d571
         if (snprintf(path, sizeof(path), "%s/%s-coredump", g_settings_dump_location, last_slash) >= sizeof(path))
30d571
             error_msg_and_die("Error saving '%s': truncated long file path", path);
30d571
 
30d571
-        int abrt_core_fd = xopen3(path, O_WRONLY | O_CREAT | O_TRUNC, 0600);
30d571
+        unlink(path);
30d571
+        int abrt_core_fd = xopen3(path, O_WRONLY | O_CREAT | O_EXCL, 0600);
30d571
         off_t core_size = copyfd_eof(STDIN_FILENO, abrt_core_fd, COPYFD_SPARSE);
30d571
         if (core_size < 0 || fsync(abrt_core_fd) != 0)
30d571
         {
30d571
-- 
30d571
1.8.3.1
30d571