47a88a
From b5c28f6c7ce86fc53048d5c51a4850a82f48f876 Mon Sep 17 00:00:00 2001
47a88a
From: Jakub Filak <jfilak@redhat.com>
47a88a
Date: Tue, 11 Aug 2015 10:01:53 +0200
47a88a
Subject: [PATCH] cli: fix testing of DBus API return codes
47a88a
47a88a
The DBus wrapper functions uses ERR_PTR to report an error, so the
47a88a
callers has to test the returned pointers for NULL and for ERR_PTR.
47a88a
47a88a
Related: rhbz#1224984
47a88a
47a88a
Signed-off-by: Jakub Filak <jfilak@redhat.com>
47a88a
---
47a88a
 src/cli/list.c   | 3 +++
47a88a
 src/cli/status.c | 5 ++++-
47a88a
 2 files changed, 7 insertions(+), 1 deletion(-)
47a88a
47a88a
diff --git a/src/cli/list.c b/src/cli/list.c
47a88a
index c76e4fb..e688d2f 100644
47a88a
--- a/src/cli/list.c
47a88a
+++ b/src/cli/list.c
47a88a
@@ -36,6 +36,9 @@ static problem_data_t *load_problem_data(const char *problem_id)
47a88a
 
47a88a
     /* First, check if there is a problem with the passed id */
47a88a
     GList *problems = get_problems_over_dbus(g_cli_authenticate);
47a88a
+    if (problems == ERR_PTR)
47a88a
+        return NULL;
47a88a
+
47a88a
     GList *item = g_list_find_custom(problems, problem_id, (GCompareFunc)strcmp);
47a88a
 
47a88a
     /* (git requires at least 5 char hash prefix, we do the same) */
47a88a
diff --git a/src/cli/status.c b/src/cli/status.c
47a88a
index 0635289..3620cea 100644
47a88a
--- a/src/cli/status.c
47a88a
+++ b/src/cli/status.c
47a88a
@@ -27,6 +27,9 @@ static unsigned int count_problem_dirs(unsigned long since)
47a88a
     unsigned count = 0;
47a88a
 
47a88a
     GList *problems = get_problems_over_dbus(g_cli_authenticate);
47a88a
+    if (problems == ERR_PTR)
47a88a
+        return count;
47a88a
+
47a88a
     for (GList *iter = problems; iter != NULL; iter = g_list_next(iter))
47a88a
     {
47a88a
         const char *problem_id = (const char *)iter->data;
47a88a
@@ -37,7 +40,7 @@ static unsigned int count_problem_dirs(unsigned long since)
47a88a
         }
47a88a
 
47a88a
         char *time_str = load_text_over_dbus(problem_id, FILENAME_LAST_OCCURRENCE);
47a88a
-        if (time_str == NULL)
47a88a
+        if (time_str == ERR_PTR || time_str == NULL)
47a88a
         {
47a88a
             log_debug("Not counting problem %s: failed to get time element", problem_id);
47a88a
             continue;
47a88a
-- 
47a88a
2.4.3
47a88a