baab13
From 4f2c1ddd3e3b81d2d5146b883115371f1cada9f9 Mon Sep 17 00:00:00 2001
baab13
From: Jakub Filak <jfilak@redhat.com>
baab13
Date: Wed, 15 Apr 2015 12:14:52 +0200
baab13
Subject: [ABRT PATCH] ccpp: do not read data from root directories
baab13
baab13
Users are allowed to modify /proc/[pid]/root to any directory by running
baab13
their own MOUNT namespace.
baab13
baab13
Related: #1211835
baab13
baab13
Signed-off-by: Jakub Filak <jfilak@redhat.com>
baab13
---
baab13
 src/hooks/abrt-hook-ccpp.c | 2 +-
baab13
 1 file changed, 1 insertion(+), 1 deletion(-)
baab13
baab13
diff --git a/src/hooks/abrt-hook-ccpp.c b/src/hooks/abrt-hook-ccpp.c
baab13
index 5694f84..0606519 100644
baab13
--- a/src/hooks/abrt-hook-ccpp.c
baab13
+++ b/src/hooks/abrt-hook-ccpp.c
baab13
@@ -678,7 +678,7 @@ int main(int argc, char** argv)
baab13
     {
baab13
         char *rootdir = get_rootdir(pid);
baab13
 
baab13
-        dd_create_basic_files(dd, fsuid, (rootdir && strcmp(rootdir, "/") != 0) ? rootdir : NULL);
baab13
+        dd_create_basic_files(dd, fsuid, NULL);
baab13
 
baab13
         char source_filename[sizeof("/proc/%lu/somewhat_long_name") + sizeof(long)*3];
baab13
         int source_base_ofs = sprintf(source_filename, "/proc/%lu/smaps", (long)pid);
baab13
-- 
baab13
1.8.3.1
baab13