Matej Habrnal fa1950
From 491668f3d83f763a11111151a3fc1f3d78cec3ab Mon Sep 17 00:00:00 2001
Matej Habrnal fa1950
From: Jakub Filak <jfilak@redhat.com>
Matej Habrnal fa1950
Date: Wed, 8 Apr 2015 09:47:08 +0200
Matej Habrnal fa1950
Subject: [PATCH] cli-status: don't return 0 if there is a problem older than
Matej Habrnal fa1950
 limit
Matej Habrnal fa1950
Matej Habrnal fa1950
The loop should skip such a problem and not return from the counting
Matej Habrnal fa1950
function with 0. This is an obvious bug introduced in
Matej Habrnal fa1950
commit 58d8e83f58afb32db3bdfd5170e65dc0ef2d2ce0
Matej Habrnal fa1950
Matej Habrnal fa1950
Signed-off-by: Jakub Filak <jfilak@redhat.com>
Matej Habrnal fa1950
---
Matej Habrnal fa1950
 src/cli/status.c | 11 ++++++++++-
Matej Habrnal fa1950
 1 file changed, 10 insertions(+), 1 deletion(-)
Matej Habrnal fa1950
Matej Habrnal fa1950
diff --git a/src/cli/status.c b/src/cli/status.c
Matej Habrnal fa1950
index 68bdd0e..a65ba05 100644
Matej Habrnal fa1950
--- a/src/cli/status.c
Matej Habrnal fa1950
+++ b/src/cli/status.c
Matej Habrnal fa1950
@@ -30,16 +30,25 @@ static unsigned int count_problem_dirs(unsigned long since)
Matej Habrnal fa1950
     {
Matej Habrnal fa1950
         const char *problem_id = (const char *)iter->data;
Matej Habrnal fa1950
         if (test_exist_over_dbus(problem_id, FILENAME_REPORTED_TO))
Matej Habrnal fa1950
+        {
Matej Habrnal fa1950
+            log_debug("Not counting problem %s: already reported", problem_id);
Matej Habrnal fa1950
             continue;
Matej Habrnal fa1950
+        }
Matej Habrnal fa1950
 
Matej Habrnal fa1950
         char *time_str = load_text_over_dbus(problem_id, FILENAME_LAST_OCCURRENCE);
Matej Habrnal fa1950
         if (time_str == NULL)
Matej Habrnal fa1950
+        {
Matej Habrnal fa1950
+            log_debug("Not counting problem %s: failed to get time element", problem_id);
Matej Habrnal fa1950
             continue;
Matej Habrnal fa1950
+        }
Matej Habrnal fa1950
 
Matej Habrnal fa1950
         long val = atol(time_str);
Matej Habrnal fa1950
         free(time_str);
Matej Habrnal fa1950
         if (val < since)
Matej Habrnal fa1950
-            return 0;
Matej Habrnal fa1950
+        {
Matej Habrnal fa1950
+            log_debug("Not counting problem %s: older tham limit (%ld < %ld)", problem_id, val, since);
Matej Habrnal fa1950
+            continue;
Matej Habrnal fa1950
+        }
Matej Habrnal fa1950
 
Matej Habrnal fa1950
         count++;
Matej Habrnal fa1950
     }
Matej Habrnal fa1950
-- 
Matej Habrnal fa1950
2.1.0
Matej Habrnal fa1950