|
Jakub Filak |
d596ad |
From 82264feebb3a816098e68f0dce1502521b6b7a92 Mon Sep 17 00:00:00 2001
|
|
Jakub Filak |
d596ad |
From: Jakub Filak <jfilak@redhat.com>
|
|
Jakub Filak |
d596ad |
Date: Wed, 30 Sep 2015 12:19:48 +0200
|
|
Jakub Filak |
d596ad |
Subject: [PATCH] ccpp: ignore crashes of ABRT binaries if DebugLevel == 0
|
|
Jakub Filak |
d596ad |
|
|
Jakub Filak |
d596ad |
Prior this commit abrt-hook-ccpp was saved core file of any
|
|
Jakub Filak |
d596ad |
crashed process executing program whose name starts with "abrt" in
|
|
Jakub Filak |
d596ad |
DUMP_LOCATION.
|
|
Jakub Filak |
d596ad |
|
|
Jakub Filak |
d596ad |
ABRT does not check size constraints of these core files, so the files
|
|
Jakub Filak |
d596ad |
could consume an uncontrolled amount of disk space.
|
|
Jakub Filak |
d596ad |
|
|
Jakub Filak |
d596ad |
Related to CVE-2015-5287
|
|
Jakub Filak |
d596ad |
|
|
Jakub Filak |
d596ad |
Signed-off-by: Jakub Filak <jfilak@redhat.com>
|
|
Jakub Filak |
d596ad |
---
|
|
Jakub Filak |
d596ad |
src/hooks/abrt-hook-ccpp.c | 7 +++++++
|
|
Jakub Filak |
d596ad |
1 file changed, 7 insertions(+)
|
|
Jakub Filak |
d596ad |
|
|
Jakub Filak |
d596ad |
diff --git a/src/hooks/abrt-hook-ccpp.c b/src/hooks/abrt-hook-ccpp.c
|
|
Jakub Filak |
d596ad |
index 4b79900..4a31b81 100644
|
|
Jakub Filak |
d596ad |
--- a/src/hooks/abrt-hook-ccpp.c
|
|
Jakub Filak |
d596ad |
+++ b/src/hooks/abrt-hook-ccpp.c
|
|
Jakub Filak |
d596ad |
@@ -703,6 +703,13 @@ int main(int argc, char** argv)
|
|
Jakub Filak |
d596ad |
const char *last_slash = strrchr(executable, '/');
|
|
Jakub Filak |
d596ad |
if (last_slash && strncmp(++last_slash, "abrt", 4) == 0)
|
|
Jakub Filak |
d596ad |
{
|
|
Jakub Filak |
d596ad |
+ if (g_settings_debug_level == 0)
|
|
Jakub Filak |
d596ad |
+ {
|
|
Jakub Filak |
d596ad |
+ log_warning("Ignoring crash of %s (SIG%s).",
|
|
Jakub Filak |
d596ad |
+ executable, signame ? signame : signal_str);
|
|
Jakub Filak |
d596ad |
+ goto cleanup_and_exit;
|
|
Jakub Filak |
d596ad |
+ }
|
|
Jakub Filak |
d596ad |
+
|
|
Jakub Filak |
d596ad |
/* If abrtd/abrt-foo crashes, we don't want to create a _directory_,
|
|
Jakub Filak |
d596ad |
* since that can make new copy of abrtd to process it,
|
|
Jakub Filak |
d596ad |
* and maybe crash again...
|
|
Jakub Filak |
d596ad |
--
|
|
Jakub Filak |
d596ad |
2.6.3
|
|
Jakub Filak |
d596ad |
|