|
Matej Habrnal |
ef5d23 |
From fe4196bd067e938303ec3cdee7c912e84cea6aa0 Mon Sep 17 00:00:00 2001
|
|
Matej Habrnal |
ef5d23 |
From: Jakub Filak <jfilak@redhat.com>
|
|
Matej Habrnal |
ef5d23 |
Date: Tue, 25 Aug 2015 08:25:19 +0200
|
|
Matej Habrnal |
ef5d23 |
Subject: [PATCH] convert all 'ex.message' stmts to 'str(ex)'
|
|
Matej Habrnal |
ef5d23 |
|
|
Matej Habrnal |
ef5d23 |
Python 3 exceptions do not have the 'message' attribute.
|
|
Matej Habrnal |
ef5d23 |
The 'message' attribute has been deprecated since Python 2.6
|
|
Matej Habrnal |
ef5d23 |
https://www.python.org/dev/peps/pep-0352/
|
|
Matej Habrnal |
ef5d23 |
|
|
Matej Habrnal |
ef5d23 |
Signed-off-by: Jakub Filak <jfilak@redhat.com>
|
|
Matej Habrnal |
ef5d23 |
---
|
|
Matej Habrnal |
ef5d23 |
src/plugins/abrt-action-generate-machine-id | 2 +-
|
|
Matej Habrnal |
ef5d23 |
src/plugins/abrt-action-notify | 12 ++++++------
|
|
Matej Habrnal |
ef5d23 |
2 files changed, 7 insertions(+), 7 deletions(-)
|
|
Matej Habrnal |
ef5d23 |
|
|
Matej Habrnal |
ef5d23 |
diff --git a/src/plugins/abrt-action-generate-machine-id b/src/plugins/abrt-action-generate-machine-id
|
|
Matej Habrnal |
ef5d23 |
index 63b5c93..c547d7c 100644
|
|
Matej Habrnal |
ef5d23 |
--- a/src/plugins/abrt-action-generate-machine-id
|
|
Matej Habrnal |
ef5d23 |
+++ b/src/plugins/abrt-action-generate-machine-id
|
|
Matej Habrnal |
ef5d23 |
@@ -110,7 +110,7 @@ def generate_machine_id(generators):
|
|
Matej Habrnal |
ef5d23 |
ids[sd] = workers[sd]()
|
|
Matej Habrnal |
ef5d23 |
except RuntimeError as ex:
|
|
Matej Habrnal |
ef5d23 |
logging.error("Machine-ID generator '{0}' failed: {1}"
|
|
Matej Habrnal |
ef5d23 |
- .format(sd, ex.message))
|
|
Matej Habrnal |
ef5d23 |
+ .format(sd, str(ex)))
|
|
Matej Habrnal |
ef5d23 |
|
|
Matej Habrnal |
ef5d23 |
return ids
|
|
Matej Habrnal |
ef5d23 |
|
|
Matej Habrnal |
ef5d23 |
diff --git a/src/plugins/abrt-action-notify b/src/plugins/abrt-action-notify
|
|
Matej Habrnal |
ef5d23 |
index 716de45..ca8f807 100644
|
|
Matej Habrnal |
ef5d23 |
--- a/src/plugins/abrt-action-notify
|
|
Matej Habrnal |
ef5d23 |
+++ b/src/plugins/abrt-action-notify
|
|
Matej Habrnal |
ef5d23 |
@@ -116,7 +116,7 @@ def emit_crash_dbus_signal(problem_data):
|
|
Matej Habrnal |
ef5d23 |
bus.send_message(msg)
|
|
Matej Habrnal |
ef5d23 |
except dbus.exceptions.DBusException as ex:
|
|
Matej Habrnal |
ef5d23 |
raise RuntimeError("Failed to emit D-Bus Crash signal: {0}"
|
|
Matej Habrnal |
ef5d23 |
- .format(ex.message))
|
|
Matej Habrnal |
ef5d23 |
+ .format(str(ex)))
|
|
Matej Habrnal |
ef5d23 |
finally:
|
|
Matej Habrnal |
ef5d23 |
if bus is not None:
|
|
Matej Habrnal |
ef5d23 |
bus.close()
|
|
Matej Habrnal |
ef5d23 |
@@ -213,7 +213,7 @@ if __name__ == "__main__":
|
|
Matej Habrnal |
ef5d23 |
PD = build_notification_problem_data(DIR_PATH)
|
|
Matej Habrnal |
ef5d23 |
except ValueError as ex:
|
|
Matej Habrnal |
ef5d23 |
sys.stderr.write("Cannot notify '{0}': {1}\n".
|
|
Matej Habrnal |
ef5d23 |
- format(DIR_PATH, ex.message))
|
|
Matej Habrnal |
ef5d23 |
+ format(DIR_PATH, str(ex)))
|
|
Matej Habrnal |
ef5d23 |
sys.exit(RETURN_FAILURE)
|
|
Matej Habrnal |
ef5d23 |
|
|
Matej Habrnal |
ef5d23 |
# The execution must continue because we should try to notify via all
|
|
Matej Habrnal |
ef5d23 |
@@ -223,13 +223,13 @@ if __name__ == "__main__":
|
|
Matej Habrnal |
ef5d23 |
emit_crash_dbus_signal(PD)
|
|
Matej Habrnal |
ef5d23 |
except RuntimeError as ex:
|
|
Matej Habrnal |
ef5d23 |
sys.stderr.write("Cannot notify '{0}' via D-Bus: {1}\n".
|
|
Matej Habrnal |
ef5d23 |
- format(DIR_PATH, ex.message))
|
|
Matej Habrnal |
ef5d23 |
+ format(DIR_PATH, str(ex)))
|
|
Matej Habrnal |
ef5d23 |
return_status = RETURN_FAILURE
|
|
Matej Habrnal |
ef5d23 |
except KeyError as ex:
|
|
Matej Habrnal |
ef5d23 |
# this is a bug in build_notification_problem_data()
|
|
Matej Habrnal |
ef5d23 |
sys.stderr.write("BUG: problem data misses required element '{0}'"
|
|
Matej Habrnal |
ef5d23 |
" required for D-Bus notification\n"
|
|
Matej Habrnal |
ef5d23 |
- .format(ex.message))
|
|
Matej Habrnal |
ef5d23 |
+ .format(str(ex)))
|
|
Matej Habrnal |
ef5d23 |
|
|
Matej Habrnal |
ef5d23 |
return_status = RETURN_FAILURE
|
|
Matej Habrnal |
ef5d23 |
|
|
Matej Habrnal |
ef5d23 |
@@ -247,13 +247,13 @@ if __name__ == "__main__":
|
|
Matej Habrnal |
ef5d23 |
run_autoreport(PD, event_name)
|
|
Matej Habrnal |
ef5d23 |
except RuntimeError as ex:
|
|
Matej Habrnal |
ef5d23 |
sys.stderr.write("Cannot notify '{0}' via uReport: {1}\n".
|
|
Matej Habrnal |
ef5d23 |
- format(DIR_PATH, ex.message))
|
|
Matej Habrnal |
ef5d23 |
+ format(DIR_PATH, str(ex)))
|
|
Matej Habrnal |
ef5d23 |
return_status = RETURN_FAILURE
|
|
Matej Habrnal |
ef5d23 |
except KeyError as ex:
|
|
Matej Habrnal |
ef5d23 |
# this is a bug in build_notification_problem_data()
|
|
Matej Habrnal |
ef5d23 |
sys.stderr.write(
|
|
Matej Habrnal |
ef5d23 |
"BUG: problem data misses required element '{0}'"
|
|
Matej Habrnal |
ef5d23 |
- " required for uReport notification\n".format(ex.message))
|
|
Matej Habrnal |
ef5d23 |
+ " required for uReport notification\n".format(str(ex)))
|
|
Matej Habrnal |
ef5d23 |
|
|
Matej Habrnal |
ef5d23 |
return_status = RETURN_FAILURE
|
|
Matej Habrnal |
ef5d23 |
|
|
Matej Habrnal |
ef5d23 |
--
|
|
Matej Habrnal |
ef5d23 |
2.5.0
|
|
Matej Habrnal |
ef5d23 |
|