Matej Habrnal 933436
From 5c011b291a65f88036884bf388859e68fe7162a9 Mon Sep 17 00:00:00 2001
Matej Habrnal 933436
From: Matej Habrnal <mhabrnal@redhat.com>
Matej Habrnal 933436
Date: Thu, 26 May 2016 10:15:07 +0200
Matej Habrnal 933436
Subject: [PATCH] abrt-hook-ccpp: save get_fsuid() return values in int
Matej Habrnal 933436
 variables
Matej Habrnal 933436
Matej Habrnal 933436
int because get_fsuid() returns negative values in case of error
Matej Habrnal 933436
Revealed by coverity.
Matej Habrnal 933436
Matej Habrnal 933436
Related to: #1337186
Matej Habrnal 933436
Matej Habrnal 933436
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
Matej Habrnal 933436
---
Matej Habrnal 933436
 src/hooks/abrt-hook-ccpp.c | 7 ++++---
Matej Habrnal 933436
 1 file changed, 4 insertions(+), 3 deletions(-)
Matej Habrnal 933436
Matej Habrnal 933436
diff --git a/src/hooks/abrt-hook-ccpp.c b/src/hooks/abrt-hook-ccpp.c
Matej Habrnal 933436
index dfe9526..10f137b 100644
Matej Habrnal 933436
--- a/src/hooks/abrt-hook-ccpp.c
Matej Habrnal 933436
+++ b/src/hooks/abrt-hook-ccpp.c
Matej Habrnal 933436
@@ -725,7 +725,8 @@ int main(int argc, char** argv)
Matej Habrnal 933436
     char *proc_pid_status = xmalloc_xopen_read_close(path, /*maxsz:*/ NULL);
Matej Habrnal 933436
 
Matej Habrnal 933436
     uid_t fsuid = uid;
Matej Habrnal 933436
-    uid_t tmp_fsuid = get_fsuid(proc_pid_status);
Matej Habrnal 933436
+    /* int because get_fsuid() returns negative values in case of error */
Matej Habrnal 933436
+    int tmp_fsuid = get_fsuid(proc_pid_status);
Matej Habrnal 933436
     if (tmp_fsuid < 0)
Matej Habrnal 933436
     {
Matej Habrnal 933436
         error_msg_ignore_crash(pid_str, NULL, (long unsigned)uid, signal_no,
Matej Habrnal 933436
@@ -742,12 +743,12 @@ int main(int argc, char** argv)
Matej Habrnal 933436
     }
Matej Habrnal 933436
 
Matej Habrnal 933436
     int suid_policy = dump_suid_policy();
Matej Habrnal 933436
-    if (tmp_fsuid != uid)
Matej Habrnal 933436
+    if ((uid_t)tmp_fsuid != uid)
Matej Habrnal 933436
     {
Matej Habrnal 933436
         /* use root for suided apps unless it's explicitly set to UNSAFE */
Matej Habrnal 933436
         fsuid = 0;
Matej Habrnal 933436
         if (suid_policy == DUMP_SUID_UNSAFE)
Matej Habrnal 933436
-            fsuid = tmp_fsuid;
Matej Habrnal 933436
+            fsuid = (uid_t)tmp_fsuid;
Matej Habrnal 933436
         else
Matej Habrnal 933436
         {
Matej Habrnal 933436
             g_user_core_flags = O_EXCL;
Matej Habrnal 933436
-- 
Matej Habrnal 933436
2.7.4
Matej Habrnal 933436