Matej Habrnal ef5d23
From 37794a0573fd7b3586e72071d27f27f173459142 Mon Sep 17 00:00:00 2001
Matej Habrnal ef5d23
From: Jakub Filak <jfilak@redhat.com>
Matej Habrnal ef5d23
Date: Thu, 20 Aug 2015 11:15:59 +0200
Matej Habrnal ef5d23
Subject: [PATCH] cli: don't start reporting of not-reportable problems
Matej Habrnal ef5d23
Matej Habrnal ef5d23
If the reported problem data contains 'not-reportable' element, the
Matej Habrnal ef5d23
reporting process fails unexpectedly and after the reporter already spent some
Matej Habrnal ef5d23
time on it.
Matej Habrnal ef5d23
Matej Habrnal ef5d23
This commit ensures that the reporting process won't start, so
Matej Habrnal ef5d23
abrt-cli's behaviour will be consistent with ABRT GUI.
Matej Habrnal ef5d23
Matej Habrnal ef5d23
However, this is not an ideal solution because we might want to allow
Matej Habrnal ef5d23
the reporter to report the problem directly to developers via e-mail.
Matej Habrnal ef5d23
Matej Habrnal ef5d23
Closes #986
Matej Habrnal ef5d23
Matej Habrnal ef5d23
Signed-off-by: Jakub Filak <jfilak@redhat.com>
Matej Habrnal ef5d23
---
Matej Habrnal ef5d23
 src/cli/report.c | 9 +++++++++
Matej Habrnal ef5d23
 1 file changed, 9 insertions(+)
Matej Habrnal ef5d23
Matej Habrnal ef5d23
diff --git a/src/cli/report.c b/src/cli/report.c
Matej Habrnal ef5d23
index 19b4c51..cc4035e 100644
Matej Habrnal ef5d23
--- a/src/cli/report.c
Matej Habrnal ef5d23
+++ b/src/cli/report.c
Matej Habrnal ef5d23
@@ -36,6 +36,15 @@ int _cmd_report(const char **dirs_strv, int remove)
Matej Habrnal ef5d23
             continue;
Matej Habrnal ef5d23
         }
Matej Habrnal ef5d23
 
Matej Habrnal ef5d23
+        const int not_reportable = test_exist_over_dbus(real_problem_id, FILENAME_NOT_REPORTABLE);
Matej Habrnal ef5d23
+        if (not_reportable != 0)
Matej Habrnal ef5d23
+        {
Matej Habrnal ef5d23
+            error_msg(_("Problem '%s' cannot be reported"), real_problem_id);
Matej Habrnal ef5d23
+            free(real_problem_id);
Matej Habrnal ef5d23
+            ++ret;
Matej Habrnal ef5d23
+            continue;
Matej Habrnal ef5d23
+        }
Matej Habrnal ef5d23
+
Matej Habrnal ef5d23
         const int res = chown_dir_over_dbus(real_problem_id);
Matej Habrnal ef5d23
         if (res != 0)
Matej Habrnal ef5d23
         {
Matej Habrnal ef5d23
-- 
Matej Habrnal ef5d23
2.5.0
Matej Habrnal ef5d23