|
Matej Habrnal |
933436 |
From 19863406cee41c1f806397173d04701b21e65478 Mon Sep 17 00:00:00 2001
|
|
Matej Habrnal |
933436 |
From: Matej Habrnal <mhabrnal@redhat.com>
|
|
Matej Habrnal |
933436 |
Date: Fri, 20 May 2016 15:50:05 +0200
|
|
Matej Habrnal |
933436 |
Subject: [PATCH] a-dump-journal-xorg: allow *libexec/X* to be executable
|
|
Matej Habrnal |
933436 |
element
|
|
Matej Habrnal |
933436 |
|
|
Matej Habrnal |
933436 |
Analyzed lot of xorg backtraces extracted from journal by ABRT and figured out
|
|
Matej Habrnal |
933436 |
almost all crashes are from '/usr/libexec/Xorg' executable but default
|
|
Matej Habrnal |
933436 |
executable /usr/bin/X(org) is wrongly used instead.
|
|
Matej Habrnal |
933436 |
The rest of backtaces contain the substring 'bin/X' hence the
|
|
Matej Habrnal |
933436 |
executable is determined right.
|
|
Matej Habrnal |
933436 |
|
|
Matej Habrnal |
933436 |
Allow executable element with "libexec/X" substring should limit using the
|
|
Matej Habrnal |
933436 |
default executable wrongly.
|
|
Matej Habrnal |
933436 |
|
|
Matej Habrnal |
933436 |
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
|
|
Matej Habrnal |
933436 |
---
|
|
Matej Habrnal |
933436 |
src/plugins/xorg-utils.c | 4 ++--
|
|
Matej Habrnal |
933436 |
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
Matej Habrnal |
933436 |
|
|
Matej Habrnal |
933436 |
diff --git a/src/plugins/xorg-utils.c b/src/plugins/xorg-utils.c
|
|
Matej Habrnal |
933436 |
index 6039acd..a8dfc51 100644
|
|
Matej Habrnal |
933436 |
--- a/src/plugins/xorg-utils.c
|
|
Matej Habrnal |
933436 |
+++ b/src/plugins/xorg-utils.c
|
|
Matej Habrnal |
933436 |
@@ -224,8 +224,8 @@ struct xorg_crash_info *process_xorg_bt(char *(*get_next_line)(void *), void *da
|
|
Matej Habrnal |
933436 |
char *filename_end = skip_non_whitespace(filename);
|
|
Matej Habrnal |
933436 |
char sv = *filename_end;
|
|
Matej Habrnal |
933436 |
*filename_end = '\0';
|
|
Matej Habrnal |
933436 |
- /* Does it look like "[/usr]/[s]bin/Xfoo"? */
|
|
Matej Habrnal |
933436 |
- if (strstr(filename, "bin/X"))
|
|
Matej Habrnal |
933436 |
+ /* Does it look like "[/usr]/[s]bin/Xfoo" or [/usr]/libexec/Xfoo"? */
|
|
Matej Habrnal |
933436 |
+ if (strstr(filename, "bin/X") || strstr(filename, "libexec/X"))
|
|
Matej Habrnal |
933436 |
exe = xstrdup(filename);
|
|
Matej Habrnal |
933436 |
*filename_end = sv;
|
|
Matej Habrnal |
933436 |
}
|
|
Matej Habrnal |
933436 |
--
|
|
Matej Habrnal |
933436 |
2.7.4
|
|
Matej Habrnal |
933436 |
|