|
Jakub Filak |
6313c5 |
From c542dcd6d620ceb3f896b6016e95172db81bddab Mon Sep 17 00:00:00 2001
|
|
Jakub Filak |
6313c5 |
From: Jakub Filak <jfilak@redhat.com>
|
|
Jakub Filak |
6313c5 |
Date: Wed, 27 Aug 2014 09:30:54 +0200
|
|
Jakub Filak |
6313c5 |
Subject: [PATCH 23/24] logging: less log messages for duplicates
|
|
Jakub Filak |
6313c5 |
|
|
Jakub Filak |
6313c5 |
Related to rhbz#1133674
|
|
Jakub Filak |
6313c5 |
|
|
Jakub Filak |
6313c5 |
Signed-off-by: Jakub Filak <jfilak@redhat.com>
|
|
Jakub Filak |
6313c5 |
---
|
|
Jakub Filak |
6313c5 |
src/daemon/abrt-handle-event.c | 4 ++--
|
|
Jakub Filak |
6313c5 |
src/daemon/abrt-server.c | 5 ++---
|
|
Jakub Filak |
6313c5 |
2 files changed, 4 insertions(+), 5 deletions(-)
|
|
Jakub Filak |
6313c5 |
|
|
Jakub Filak |
6313c5 |
diff --git a/src/daemon/abrt-handle-event.c b/src/daemon/abrt-handle-event.c
|
|
Jakub Filak |
6313c5 |
index a65f86e..2ed88db 100644
|
|
Jakub Filak |
6313c5 |
--- a/src/daemon/abrt-handle-event.c
|
|
Jakub Filak |
6313c5 |
+++ b/src/daemon/abrt-handle-event.c
|
|
Jakub Filak |
6313c5 |
@@ -142,7 +142,7 @@ static int dup_uuid_compare(const struct dump_dir *dd)
|
|
Jakub Filak |
6313c5 |
free(dd_uuid);
|
|
Jakub Filak |
6313c5 |
|
|
Jakub Filak |
6313c5 |
if (!different)
|
|
Jakub Filak |
6313c5 |
- log("Duplicate: UUID");
|
|
Jakub Filak |
6313c5 |
+ log_notice("Duplicate: UUID");
|
|
Jakub Filak |
6313c5 |
|
|
Jakub Filak |
6313c5 |
return !different;
|
|
Jakub Filak |
6313c5 |
}
|
|
Jakub Filak |
6313c5 |
@@ -197,7 +197,7 @@ static int dup_corebt_compare(const struct dump_dir *dd)
|
|
Jakub Filak |
6313c5 |
free(dd_corebt);
|
|
Jakub Filak |
6313c5 |
|
|
Jakub Filak |
6313c5 |
if (isdup)
|
|
Jakub Filak |
6313c5 |
- log("Duplicate: core backtrace");
|
|
Jakub Filak |
6313c5 |
+ log_notice("Duplicate: core backtrace");
|
|
Jakub Filak |
6313c5 |
|
|
Jakub Filak |
6313c5 |
return isdup;
|
|
Jakub Filak |
6313c5 |
}
|
|
Jakub Filak |
6313c5 |
diff --git a/src/daemon/abrt-server.c b/src/daemon/abrt-server.c
|
|
Jakub Filak |
6313c5 |
index 307b41b..9951468 100644
|
|
Jakub Filak |
6313c5 |
--- a/src/daemon/abrt-server.c
|
|
Jakub Filak |
6313c5 |
+++ b/src/daemon/abrt-server.c
|
|
Jakub Filak |
6313c5 |
@@ -194,15 +194,14 @@ static int run_post_create(const char *dirname)
|
|
Jakub Filak |
6313c5 |
strbuf_append_str(cmd_output, raw);
|
|
Jakub Filak |
6313c5 |
char *msg = cmd_output->buf;
|
|
Jakub Filak |
6313c5 |
|
|
Jakub Filak |
6313c5 |
- /* Hmm, DUP_OF_DIR: ends up in syslog. move log() into 'else'? */
|
|
Jakub Filak |
6313c5 |
- log("%s", msg);
|
|
Jakub Filak |
6313c5 |
-
|
|
Jakub Filak |
6313c5 |
if (child_is_post_create
|
|
Jakub Filak |
6313c5 |
&& prefixcmp(msg, "DUP_OF_DIR: ") == 0
|
|
Jakub Filak |
6313c5 |
) {
|
|
Jakub Filak |
6313c5 |
free(dup_of_dir);
|
|
Jakub Filak |
6313c5 |
dup_of_dir = xstrdup(msg + strlen("DUP_OF_DIR: "));
|
|
Jakub Filak |
6313c5 |
}
|
|
Jakub Filak |
6313c5 |
+ else
|
|
Jakub Filak |
6313c5 |
+ log("%s", msg);
|
|
Jakub Filak |
6313c5 |
|
|
Jakub Filak |
6313c5 |
strbuf_clear(cmd_output);
|
|
Jakub Filak |
6313c5 |
/* jump to next line */
|
|
Jakub Filak |
6313c5 |
--
|
|
Jakub Filak |
6313c5 |
2.1.0
|
|
Jakub Filak |
6313c5 |
|