|
Adam Williamson |
bcfb1b |
From af51c51636eb0ca318e62d4c712f2ba3e60ed9b0 Mon Sep 17 00:00:00 2001
|
|
Adam Williamson |
bcfb1b |
From: Martin Kutlak <mkutlak@redhat.com>
|
|
Adam Williamson |
bcfb1b |
Date: Tue, 28 Aug 2018 10:26:47 +0200
|
|
Adam Williamson |
bcfb1b |
Subject: [PATCH] gui: Replace deprecated g_type_class_add_private
|
|
Adam Williamson |
bcfb1b |
|
|
Adam Williamson |
bcfb1b |
g_type_class_add_private will be deprecated in Glib 2.58 [1].
|
|
Adam Williamson |
bcfb1b |
|
|
Adam Williamson |
bcfb1b |
There is a G_DEFINE_TYPE_WITH_PRIVATE macro that can replace
|
|
Adam Williamson |
bcfb1b |
the deprecated function and it is backwards compatible [2].
|
|
Adam Williamson |
bcfb1b |
|
|
Adam Williamson |
bcfb1b |
[1] blog.gtk.org/2018/07/11/news-from-glib-2-58
|
|
Adam Williamson |
bcfb1b |
[2] bassi.io/articles/2013/06/21/the-king-is-dead
|
|
Adam Williamson |
bcfb1b |
|
|
Adam Williamson |
bcfb1b |
Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
|
|
Adam Williamson |
bcfb1b |
---
|
|
Adam Williamson |
bcfb1b |
src/configuration-gui/abrt-config-widget.c | 9 ++-------
|
|
Adam Williamson |
bcfb1b |
1 file changed, 2 insertions(+), 7 deletions(-)
|
|
Adam Williamson |
bcfb1b |
|
|
Adam Williamson |
bcfb1b |
diff --git a/src/configuration-gui/abrt-config-widget.c b/src/configuration-gui/abrt-config-widget.c
|
|
Adam Williamson |
bcfb1b |
index 62910db6..aa3b5c01 100644
|
|
Adam Williamson |
bcfb1b |
--- a/src/configuration-gui/abrt-config-widget.c
|
|
Adam Williamson |
bcfb1b |
+++ b/src/configuration-gui/abrt-config-widget.c
|
|
Adam Williamson |
bcfb1b |
@@ -27,9 +27,6 @@
|
|
Adam Williamson |
bcfb1b |
#include "libabrt.h"
|
|
Adam Williamson |
bcfb1b |
#include <assert.h>
|
|
Adam Williamson |
bcfb1b |
|
|
Adam Williamson |
bcfb1b |
-#define ABRT_CONFIG_WIDGET_GET_PRIVATE(o) \
|
|
Adam Williamson |
bcfb1b |
- (G_TYPE_INSTANCE_GET_PRIVATE((o), TYPE_ABRT_CONFIG_WIDGET, AbrtConfigWidgetPrivate))
|
|
Adam Williamson |
bcfb1b |
-
|
|
Adam Williamson |
bcfb1b |
#define WID(s) GTK_WIDGET(gtk_builder_get_object(self->priv->builder, s))
|
|
Adam Williamson |
bcfb1b |
|
|
Adam Williamson |
bcfb1b |
#define UI_FILE_NAME "abrt-config-widget.glade"
|
|
Adam Williamson |
bcfb1b |
@@ -107,7 +104,7 @@ struct AbrtConfigWidgetPrivate {
|
|
Adam Williamson |
bcfb1b |
AbrtConfigWidgetOption options[_ABRT_OPT_END_];
|
|
Adam Williamson |
bcfb1b |
};
|
|
Adam Williamson |
bcfb1b |
|
|
Adam Williamson |
bcfb1b |
-G_DEFINE_TYPE(AbrtConfigWidget, abrt_config_widget, GTK_TYPE_BOX)
|
|
Adam Williamson |
bcfb1b |
+G_DEFINE_TYPE_WITH_PRIVATE(AbrtConfigWidget, abrt_config_widget, GTK_TYPE_BOX)
|
|
Adam Williamson |
bcfb1b |
|
|
Adam Williamson |
bcfb1b |
enum {
|
|
Adam Williamson |
bcfb1b |
SN_CHANGED,
|
|
Adam Williamson |
bcfb1b |
@@ -214,8 +211,6 @@ abrt_config_widget_class_init(AbrtConfigWidgetClass *klass)
|
|
Adam Williamson |
bcfb1b |
|
|
Adam Williamson |
bcfb1b |
object_class->finalize = abrt_config_widget_finalize;
|
|
Adam Williamson |
bcfb1b |
|
|
Adam Williamson |
bcfb1b |
- g_type_class_add_private(klass, sizeof(AbrtConfigWidgetPrivate));
|
|
Adam Williamson |
bcfb1b |
-
|
|
Adam Williamson |
bcfb1b |
s_signals[SN_CHANGED] = g_signal_new ("changed",
|
|
Adam Williamson |
bcfb1b |
G_TYPE_FROM_CLASS (klass),
|
|
Adam Williamson |
bcfb1b |
G_SIGNAL_RUN_LAST,
|
|
Adam Williamson |
bcfb1b |
@@ -413,7 +408,7 @@ abrt_config_widget_init(AbrtConfigWidget *self)
|
|
Adam Williamson |
bcfb1b |
{
|
|
Adam Williamson |
bcfb1b |
GError *error = NULL;
|
|
Adam Williamson |
bcfb1b |
|
|
Adam Williamson |
bcfb1b |
- self->priv = ABRT_CONFIG_WIDGET_GET_PRIVATE(self);
|
|
Adam Williamson |
bcfb1b |
+ self->priv = abrt_config_widget_get_instance_private(self);
|
|
Adam Williamson |
bcfb1b |
|
|
Adam Williamson |
bcfb1b |
self->priv->builder = gtk_builder_new();
|
|
Adam Williamson |
bcfb1b |
gtk_builder_set_translation_domain(self->priv->builder, GETTEXT_PACKAGE);
|
|
Adam Williamson |
bcfb1b |
--
|
|
Adam Williamson |
bcfb1b |
2.19.0
|
|
Adam Williamson |
bcfb1b |
|