|
Zbigniew Jędrzejewski-Szmek |
a52f67 |
From c4f7609113a7734313d95f33774deb4b9c143b29 Mon Sep 17 00:00:00 2001
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
From: Lennart Poettering <lennart@poettering.net>
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
Date: Mon, 16 Dec 2013 17:04:36 +0100
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
Subject: [PATCH] util: try harder to increase the send/recv buffers of sockets
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
If we have the priviliges we will try SO_SNDBUFFORCE/SO_RCVBUFFORCE and
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
only fall back to SO_SNDBUF/SO_RCVBUF if that fails.
|
|
Zbigniew Jędrzejewski-Szmek |
a52f67 |
|
|
Zbigniew Jędrzejewski-Szmek |
a52f67 |
(cherry picked from commit 92d75ca419994f3924dc14117b71f8706d9e1f57)
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
---
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
src/shared/util.c | 25 ++++++++++++-------------
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
1 file changed, 12 insertions(+), 13 deletions(-)
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
diff --git a/src/shared/util.c b/src/shared/util.c
|
|
Zbigniew Jędrzejewski-Szmek |
1cc3df |
index 02bae9043c..8824b9b9a2 100644
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
--- a/src/shared/util.c
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
+++ b/src/shared/util.c
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
@@ -4928,15 +4928,15 @@ int fd_inc_sndbuf(int fd, size_t n) {
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
socklen_t l = sizeof(value);
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
r = getsockopt(fd, SOL_SOCKET, SO_SNDBUF, &value, &l);
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
- if (r >= 0 &&
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
- l == sizeof(value) &&
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
- (size_t) value >= n*2)
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
+ if (r >= 0 && l == sizeof(value) && (size_t) value >= n*2)
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
return 0;
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
+ /* If we have the privileges we will ignore the kernel limit. */
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
+
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
value = (int) n;
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
- r = setsockopt(fd, SOL_SOCKET, SO_SNDBUF, &value, sizeof(value));
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
- if (r < 0)
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
- return -errno;
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
+ if (setsockopt(fd, SOL_SOCKET, SO_SNDBUFFORCE, &value, sizeof(value)) < 0)
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
+ if (setsockopt(fd, SOL_SOCKET, SO_SNDBUF, &value, sizeof(value)) < 0)
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
+ return -errno;
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
return 1;
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
}
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
@@ -4946,16 +4946,15 @@ int fd_inc_rcvbuf(int fd, size_t n) {
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
socklen_t l = sizeof(value);
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
r = getsockopt(fd, SOL_SOCKET, SO_RCVBUF, &value, &l);
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
- if (r >= 0 &&
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
- l == sizeof(value) &&
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
- (size_t) value >= n*2)
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
+ if (r >= 0 && l == sizeof(value) && (size_t) value >= n*2)
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
return 0;
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
- value = (int) n;
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
- r = setsockopt(fd, SOL_SOCKET, SO_RCVBUF, &value, sizeof(value));
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
- if (r < 0)
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
- return -errno;
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
+ /* If we have the privileges we will ignore the kernel limit. */
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
+ value = (int) n;
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
+ if (setsockopt(fd, SOL_SOCKET, SO_RCVBUFFORCE, &value, sizeof(value)) < 0)
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
+ if (setsockopt(fd, SOL_SOCKET, SO_RCVBUF, &value, sizeof(value)) < 0)
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
+ return -errno;
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
return 1;
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
}
|
|
Zbigniew Jędrzejewski-Szmek |
b12ff7 |
|